mmc: Initialize mmc_devices list statically
PATCH 1/1 mmc: Initialize mmc_devices list statically
Currently mmc_device list is initialized from mmc_initialize() function. So crash happens if any function which use mmc_devices list (find_mmc_device, print_mmc_devices, etc.) is called before mmc_initialize().
Fix this by initializing mmc_devices list statically.
--- drivers/mmc/mmc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mmc/mmc.c +1 -2
@@ -21,7 +21,7 @@#define CONFIG_SYS_MMC_MAX_BLK_COUNT 65535#endif -static struct list_head mmc_devices; +LIST_HEAD (mmc_devices);static int cur_dev_num =-1 ;int __weak board_mmc_getwp (struct mmc *mmc)
@@ -1477,7 +1477,6 @@ static void do_preinit(void)int mmc_initialize (bd_t *bis) { -INIT_LIST_HEAD (&mmc_devices); cur_dev_num =0 ;if (board_mmc_init (bis) <0 )
Signature · 1 line
1.7.9.5
PATCH 1/1 mmc: Initialize mmc_devices list statically
Hi Taras,
What are you doing that makes you call any of the mmc_devices list functions before calling mmc_initialize()
Which board has this problem; this looks like a board problem to me.
Regards
-- Pantelis
Quoted 39 lines · Taras Kondratiuk
Currently
mmc_devicelist is initialized frommmc_initialize()function. So crash happens if any function which usemmc_deviceslist (find_mmc_device,print_mmc_devices, etc.) is called beforemmc_initialize().Fix this by initializing
mmc_deviceslist statically.Signed-off-by Taras Kondratiuk <[email protected]>---
drivers/mmc/mmc.c| 3 +--1 file changed, 1 insertion(+), 2 deletions(-)drivers/mmc/mmc.c +1
-2@@ -21,7 +21,7 @@#define CONFIG_SYS_MMC_MAX_BLK_COUNT 65535#endif -static struct list_head mmc_devices; +LIST_HEAD (mmc_devices);static int cur_dev_num =-1 ;int __weak board_mmc_getwp (struct mmc *mmc)@@ -1477,7 +1477,6 @@ static void do_preinit(void)int mmc_initialize (bd_t *bis) { -INIT_LIST_HEAD (&mmc_devices); cur_dev_num =0 ;if (board_mmc_init (bis) <0 )Signature · 6 lines
1.7.9.5 _______________________________________________ U-Boot mailing list U-Boot at lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot