Skip to contentSkip to conversation

PRs, Breakage architecture

U-Boot Stefano Babic 2 participants 3 messages Feb 15, 2019

lore
Share & tools
lore
#0 lore raw

Hi Tom,

my run on Travis reports errors with sun8i and sun50i (I do not think they are related to commits on u-boot-imx). I see on your travis that you have a "WIP-14Feb2019 u-boot-sunxi merged", and this runs succesfully (but not yet merged). So if I send a PR now, I have a broken run on Travis. What is your expectation I should do ? Simply send a PR because issues are known or wait until WIP-14Feb2019 goes to -master (but this means a rebase of u-boto-imx) ?

Thanks,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#1 lore raw
Quoted 9 lines · Stefano Babic

Hi Tom,

my run on Travis reports errors with sun8i and sun50i (I do not think they are related to commits on u-boot-imx). I see on your travis that you have a "WIP-14Feb2019 u-boot-sunxi merged", and this runs succesfully (but not yet merged). So if I send a PR now, I have a broken run on Travis. What is your expectation I should do ? Simply send a PR because issues are known or wait until WIP-14Feb2019 goes to -master (but this means a rebase of u-boto-imx) ?

As a rule, https://travis-ci.org/u-boot/u-boot/builds and master (so also https://travis-ci.org/trini/u-boot and master) is always green. If something fails in any of my WIP-* (or other things like TRAVIS-* or GC-*), then I fix the failure.

Looking at https://travis-ci.org/sbabic/u-boot-imx/jobs/493736548
something in your PR is causing sunxi to overflow there. You should be able to build for orangepi_pc2 locally and also see the overflow and bisect your way to what change is causing things to break. It's just a coincidence that I'm testing a sunxi PR right now.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190215/0b4dde96/attachment.sig>
#2 lore raw

Hi Tom,

Quoted 12 lines · Tom Rini
Quoted 9 lines · Stefano Babic

Hi Tom,

my run on Travis reports errors with sun8i and sun50i (I do not think they are related to commits on u-boot-imx). I see on your travis that you have a "WIP-14Feb2019 u-boot-sunxi merged", and this runs succesfully (but not yet merged). So if I send a PR now, I have a broken run on Travis. What is your expectation I should do ? Simply send a PR because issues are known or wait until WIP-14Feb2019 goes to -master (but this means a rebase of u-boto-imx) ?

Quoted 2 lines

As a rule, https://travis-ci.org/u-boot/u-boot/builds and master (so also https://travis-ci.org/trini/u-boot and master) is always green.

Got it.

Quoted 9 lines

If
something fails in any of my WIP-* (or other things like TRAVIS-* or GC-*), then I fix the failure.

Looking at https://travis-ci.org/sbabic/u-boot-imx/jobs/493736548
something in your PR is causing sunxi to overflow there. You should be able to build for orangepi_pc2 locally and also see the overflow and bisect your way to what change is causing things to break. It's just a coincidence that I'm testing a sunxi PR right now.

Understood, thanks ;-)

Starting bisecting....

Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================