Skip to contentSkip to conversation

for-each-ref: call --start-after argument "marker"

PATCH In review René Scharfe 3 participants 8 messages Aug 9, 2025 – Aug 12, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 for-each-ref: call --start-after argument "marker"

dabecb9db2 (for-each-ref: introduce a '--start-after' option, 2025-07-15) added the option --start-after and referred to its argument as "marker" in documentation and usage string, but not in the option's short help. Use "marker" there as well for consistency and brevity.

---
 builtin/for-each-ref.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
builtin/for-each-ref.c +1 -1
index 8b5fe7b65e..222637a2c0 100644
@@ -46,7 +46,7 @@ int cmd_for_each_ref(int argc,
 		OPT_GROUP(""),
 		OPT_INTEGER( 0 , "count", &format.array_opts.max_count, N_("show only <n> matched refs")),
 		OPT_STRING(  0 , "format", &format.format, N_("format"), N_("format to use for the output")),
-		OPT_STRING(  0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
+		OPT_STRING(  0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),
 		OPT__COLOR(&format.use_color, N_("respect format colors")),
 		OPT_REF_FILTER_EXCLUDE(&filter),
 		OPT_REF_SORT(&sorting_options),
Signature · 1 line
2.50.1
#1 lore raw
Quoted 4 lines · René Scharfe

dabecb9db2 (for-each-ref: introduce a '--start-after' option, 2025-07-15) added the option --start-after and referred to its argument as "marker" in documentation and usage string, but not in the option's short help. Use "marker" there as well for consistency and brevity.

Great. Nobody seems to have noticed it (including me X-<) primarily because the command is still listed in t/0450/adoc-help-mismatches file.

Thanks.

#2 lore raw
In reply to René Scharfe
Quoted 15 lines · René Scharfe

dabecb9db2 (for-each-ref: introduce a '--start-after' option, 2025-07-15) added the option --start-after and referred to its argument as "marker" in documentation and usage string, but not in the option's short help. Use "marker" there as well for consistency and brevity.

---
 builtin/for-each-ref.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
builtin/for-each-ref.c +0 -0
index 8b5fe7b65e..222637a2c0 100644

builtin/for-each-ref.c int cmd_for_each_ref(int argc, · line 50

Quoted 6 lines
builtin/for-each-ref.c +1 -1
@@ -46,7 +46,7 @@ int cmd_for_each_ref(int argc,
 		OPT_GROUP(""),
 		OPT_INTEGER( 0 , "count", &format.array_opts.max_count, N_("show only <n> matched refs")),
 		OPT_STRING(  0 , "format", &format.format, N_("format"), N_("format to use for the output")),
-		OPT_STRING(  0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
+		OPT_STRING(  0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),
 

Ah! I did fix a typo here, but your fix is better. Thanks.

Quoted 5 lines
builtin/for-each-ref.c +0 -0
 		OPT__COLOR(&format.use_color, N_("respect format colors")),
 		OPT_REF_FILTER_EXCLUDE(&filter),

OPT_REF_SORT(&sorting_options),
--
2.50.1

#3 lore raw
Quoted 5 lines · Karthik Nayak

builtin/for-each-ref.c int cmd_for_each_ref(int argc, · line 49

Quoted 3 lines
builtin/for-each-ref.c +1 -1
-		OPT_STRING(  0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
+		OPT_STRING(  0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),

Ah! I did fix a typo here, but your fix is better. Thanks.

Here where? Is that "fix a typo" something I should go around and make sure I do not miss?

Thanks.

Quoted 6 lines
Quoted 6 lines
builtin/for-each-ref.c +0 -1
 		OPT__COLOR(&format.use_color, N_("respect format colors")),
 		OPT_REF_FILTER_EXCLUDE(&filter),
 		OPT_REF_SORT(&sorting_options),
--

2.50.1

#4 lore raw
Quoted 11 lines · Junio C Hamano
Quoted 5 lines · Karthik Nayak

builtin/for-each-ref.c int cmd_for_each_ref(int argc, · line 49

Quoted 3 lines
builtin/for-each-ref.c +1 -1
-		OPT_STRING(  0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
+		OPT_STRING(  0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),

Ah! I did fix a typo here, but your fix is better. Thanks.

Here where? Is that "fix a typo" something I should go around and make sure I do not miss?

I meant my earlier patch fa0f4e46f5 (for-each-ref: reword the documentation for '--start-after', 2025-07-28) which is merged to master now.

Quoted 8 lines

Thanks.

Quoted 6 lines
Quoted 6 lines
builtin/for-each-ref.c +0 -1
 		OPT__COLOR(&format.use_color, N_("respect format colors")),
 		OPT_REF_FILTER_EXCLUDE(&filter),
 		OPT_REF_SORT(&sorting_options),
--

2.50.1

#5 lore raw
Quoted 10 lines · Karthik Nayak
Quoted 8 lines · Junio C Hamano
Quoted 5 lines · Karthik Nayak

builtin/for-each-ref.c int cmd_for_each_ref(int argc, · line 49

Quoted 3 lines
builtin/for-each-ref.c +1 -1
-		OPT_STRING(  0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
+		OPT_STRING(  0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),

Ah! I did fix a typo here, but your fix is better. Thanks.

Quoted 6 lines
Quoted 2 lines

Here where? Is that "fix a typo" something I should go around and make sure I do not miss?

I meant my earlier patch fa0f4e46f5 (for-each-ref: reword the documentation for '--start-after', 2025-07-28) which is merged to master now.

Hmph, so what does mentioning of your earlier typofix add to review of this new patch? We should revert your earlier change and replace it with this one? Or there were two typos, you fixed only one, and this patch ties a loose end left by it (but then that is not what I'd describe "yours is better", so I am still puzzled)?

Thanks.

#6 lore raw
Quoted 19 lines · Junio C Hamano
Quoted 10 lines · Karthik Nayak
Quoted 8 lines · Junio C Hamano
Quoted 5 lines · Karthik Nayak

builtin/for-each-ref.c int cmd_for_each_ref(int argc, · line 49

Quoted 3 lines
builtin/for-each-ref.c +1 -1
-		OPT_STRING(  0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
+		OPT_STRING(  0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),

Ah! I did fix a typo here, but your fix is better. Thanks.

Quoted 6 lines
Quoted 2 lines

Here where? Is that "fix a typo" something I should go around and make sure I do not miss?

I meant my earlier patch fa0f4e46f5 (for-each-ref: reword the documentation for '--start-after', 2025-07-28) which is merged to master now.

Quoted 6 lines

Hmph, so what does mentioning of your earlier typofix add to review of this new patch? We should revert your earlier change and replace it with this one? Or there were two typos, you fixed only one, and this patch ties a loose end left by it (but then that is not what I'd describe "yours is better", so I am still puzzled)?

I was referring to the fact that I made the change from "start-start" to "start-after", but "marker" would've been the better replacement, so my review was concluding that while I was here and made a change it still was lacking.

"yours is better" is poor choice of words.

Quoted 1 line

Thanks.

#7 lore raw
Quoted 4 lines · Karthik Nayak

I was referring to the fact that I made the change from "start-start" to "start-after", but "marker" would've been the better replacement, so my review was concluding that while I was here and made a change it still was lacking.

Thanks for clarifying and unconfusing me ;-)