xfrm/compat: Remove use of kmalloc_track_caller
Subsystems (3)
PATCH 1/1 xfrm/compat: Remove use of kmalloc_track_caller
The __kmalloc_track_caller symbol is not exported if SLUB/SLOB are enabled instead of SLAB, which breaks the build on such configs when CONFIG_XFRM_USER_COMPAT=m.
ERROR: "__kmalloc_track_caller" [net/xfrm/xfrm_compat.ko] undefined!
Other users of this symbol are 'bool' options, but changing this to bool would require XFRM_USER to be built in as well, which doesn't seem worth it. Go back to kmalloc().
--- net/xfrm/xfrm_compat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/xfrm/xfrm_compat.c +1 -1
@@ -585,7 +585,7 @@ static int xfrm_user_policy_compat(u8 **pdata32, int optlen)if (optlen <sizeof (*p))return -EINVAL ; - data64 =kmalloc_track_caller (optlen +4 ,GFP_USER | __GFP_NOWARN); + data64 =kmalloc (optlen +4 ,GFP_USER | __GFP_NOWARN);if (!data64)return -ENOMEM ;
Signature · 1 line
2.29.1.341.ge80a0c044ae-goog
Quoted 10 lines · Alistair Delva
The
__kmalloc_track_callersymbol is not exported if SLUB/SLOB are enabled instead of SLAB, which breaks the build on such configs whenCONFIG_XFRM_USER_COMPAT=m.ERROR: "
__kmalloc_track_caller" [net/xfrm/xfrm_compat.ko] undefined!Other users of this symbol are 'bool' options, but changing this to bool would require
XFRM_USERto be built in as well, which doesn't seem worth it. Go back tokmalloc().
Quoted 5 lines
Fixes 96392ee5a13b9 ("xfrm/compat: Translate 32-bit user_policy from sockptr")Cc Dmitry Safonov <[email protected]>Cc Maciej Żenczykowski <[email protected]>Cc Steffen Klassert <[email protected]>Signed-off-by Alistair Delva <[email protected]>
Thank you!
--
Dmitry
Herbert Xu
maintainerQuoted 5 lines · Alistair Delva
The
__kmalloc_track_callersymbol is not exported if SLUB/SLOB are enabled instead of SLAB, which breaks the build on such configs whenCONFIG_XFRM_USER_COMPAT=m.ERROR: "
__kmalloc_track_caller" [net/xfrm/xfrm_compat.ko] undefined!
Is this with a recent kernel? Because they should be exported:
commit fd7cb5753ef49964ea9db5121c3fc9a4ec21ed8e
Author: Daniel Vetter <[email protected]> Date: Mon Mar 23 15:49:00 2020 +0100
mm/sl[uo]b: export __kmalloc_track(_node)_caller
Cheers,
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Quoted 7 lines · Herbert Xu
Quoted 6 lines · Alistair Delva
The
__kmalloc_track_callersymbol is not exported if SLUB/SLOB are enabled instead of SLAB, which breaks the build on such configs whenCONFIG_XFRM_USER_COMPAT=m.ERROR: "
__kmalloc_track_caller" [net/xfrm/xfrm_compat.ko] undefined!
Quoted 7 lines
Is this with a recent kernel? Because they should be exported:
commit
fd7cb5753ef49964ea9db5121c3fc9a4ec21ed8eAuthor: Daniel Vetter <[email protected]> Date: Mon Mar 23 15:49:00 2020 +0100mm/sl[uo]b: export __kmalloc_track(_node)_caller
Whoops, you're right - I confused two allmodconfig issues when backporting. Sorry for the noise.
Quoted 9 lines
Cheers,
--
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt--
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].