Skip to contentSkip to conversation

arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware

PATCH Applied Brian Masney 3 participants 6 messages Mar 7, 2023 – Mar 15, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware

The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and correct the name to match what's in Qualcomm's deliverable.

---
 arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sa8540p-ride.dts +1 -1
index 6c547f1b13dc..0f560a4661eb 100644
@@ -177,7 +177,7 @@ &qup2_uart17 {
 };
 
 &remoteproc_nsp0 {
-	firmware-name = "qcom/sa8540p/cdsp.mbn";
+	firmware-name = "qcom/sa8540p/cdsp0.mbn";
 	status = "okay";
 };
 
Signature · 1 line
2.39.2
#1 lore raw
Quoted 3 lines · Brian Masney

The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and correct the name to match what's in Qualcomm's deliverable.

I don't think vendor deliverables matter. linux-firmware is here more important. The file will be cdsp.mbn in the firmware, won't it?

Best regards,
Krzysztof

#2 lore raw
Quoted 7 lines · Krzysztof Kozlowski
Quoted 3 lines · Brian Masney

The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and correct the name to match what's in Qualcomm's deliverable.

I don't think vendor deliverables matter. linux-firmware is here more important. The file will be cdsp.mbn in the firmware, won't it?

cdsp0.mbn and cdsp1.mbn for the sa8540p are not in linux-firmware and I far as I know there's no plan for someone to submit those since QC would need to approve that. I can ask though since the DTS for these two bits has been submitted upstream.

Brian

#3 lore raw
Quoted 6 lines · Brian Masney
Quoted 5 lines · Krzysztof Kozlowski
Quoted 3 lines · Brian Masney

The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and correct the name to match what's in Qualcomm's deliverable.

Quoted 7 lines
Quoted 2 lines

I don't think vendor deliverables matter. linux-firmware is here more important. The file will be cdsp.mbn in the firmware, won't it?

cdsp0.mbn and cdsp1.mbn for the sa8540p are not in linux-firmware and I far as I know there's no plan for someone to submit those since QC would need to approve that. I can ask though since the DTS for these two bits has been submitted upstream.

If they are never going to be submitted, vendor is allowed to rename them all the time in their "deliverables". Are you going to rename the file every time Qualcomm decides to rename them? There is no single guarantee the names would be fixed, because vendor is allowed to do absolutely anything.

Sorry, but any argument in upstream DTS that "someone downstream does something" is deemed to fail in many cases.

Best regards,
Krzysztof

maintainer
#4 lore raw
Quoted 15 lines · Krzysztof Kozlowski
Quoted 6 lines · Brian Masney
Quoted 5 lines · Krzysztof Kozlowski
Quoted 3 lines · Brian Masney

The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and correct the name to match what's in Qualcomm's deliverable.

Quoted 7 lines
Quoted 2 lines

I don't think vendor deliverables matter. linux-firmware is here more important. The file will be cdsp.mbn in the firmware, won't it?

cdsp0.mbn and cdsp1.mbn for the sa8540p are not in linux-firmware and I far as I know there's no plan for someone to submit those since QC would need to approve that. I can ask though since the DTS for these two bits has been submitted upstream.

Quoted 6 lines

If they are never going to be submitted, vendor is allowed to rename them all the time in their "deliverables". Are you going to rename the file every time Qualcomm decides to rename them? There is no single guarantee the names would be fixed, because vendor is allowed to do absolutely anything.

cdsp0.mbn and cdsp1.mbn are better names, so let's use this patch to define that if/when they are pushed to linux-firmware it should follow this scheme.

Quoted 3 lines

Sorry, but any argument in upstream DTS that "someone downstream does something" is deemed to fail in many cases.

That is indeed an insufficient argument, in many cases.

Regards,
Bjorn

maintainer Applied
#5 lore raw
In reply to Brian Masney
Quoted 5 lines · Brian Masney

The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and correct the name to match what's in Qualcomm's deliverable.

Applied, thanks!

[1/1] arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware

      commit: b891251b40d4dc4cfd28341f62f6784c02ad3a78

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>