Skip to contentSkip to conversation

brcmfmac: no need to check return value of debugfs_create functions

PATCH In review Greg Kroah-Hartman 3 participants 3 messages Apr 29, 2020 – May 4, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 brcmfmac: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.

In doing this, make brcmf_debugfs_add_entry() return void as no one was even paying attention to the return value.

Cc Arend van Spriel <[email protected]>
Cc Franky Lin <[email protected]>
Cc Hante Meuleman <[email protected]>
Cc Chi-Hsien Lin <[email protected]>
Cc Wright Feng <[email protected]>
Cc Kalle Valo <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Pieter-Paul Giesberts <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc "Rafał Miłecki" <[email protected]>
---
 .../net/wireless/broadcom/brcm80211/brcmfmac/debug.c |  9 +++------
 .../net/wireless/broadcom/brcm80211/brcmfmac/debug.h | 12 +++++-------
 2 files changed, 8 insertions(+), 13 deletions(-)
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c +3 -6
index 120515fe8250..eecf8a38d94a 100644
@@ -47,13 +47,10 @@ struct dentry *brcmf_debugfs_get_devdir(struct brcmf_pub *drvr)
 	return drvr->wiphy->debugfsdir;
 }
 
-int brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
+void brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
 			    int (*read_fn)(struct seq_file *seq, void *data))
 {
-	struct dentry *e;
-
 	WARN(!drvr->wiphy->debugfsdir, "wiphy not (yet) registered\n");
-	e = debugfs_create_devm_seqfile(drvr->bus_if->dev, fn,
-					drvr->wiphy->debugfsdir, read_fn);
-	return PTR_ERR_OR_ZERO(e);
+	debugfs_create_devm_seqfile(drvr->bus_if->dev, fn,
+				    drvr->wiphy->debugfsdir, read_fn);
 }
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h +5 -7
index 9b221b509ade..4146faeed344 100644
@@ -116,8 +116,8 @@ struct brcmf_bus;
 struct brcmf_pub;
 #ifdef DEBUG
 struct dentry *brcmf_debugfs_get_devdir(struct brcmf_pub *drvr);
-int brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
-			    int (*read_fn)(struct seq_file *seq, void *data));
+void brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
+			     int (*read_fn)(struct seq_file *seq, void *data));
 int brcmf_debug_create_memdump(struct brcmf_bus *bus, const void *data,
 			       size_t len);
 #else
@@ -126,11 +126,9 @@ static inline struct dentry *brcmf_debugfs_get_devdir(struct brcmf_pub *drvr)
 	return ERR_PTR(-ENOENT);
 }
 static inline
-int brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
-			    int (*read_fn)(struct seq_file *seq, void *data))
-{
-	return 0;
-}
+void brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
+			     int (*read_fn)(struct seq_file *seq, void *data))
+{ }
 static inline
 int brcmf_debug_create_memdump(struct brcmf_bus *bus, const void *data,
 			       size_t len)
Signature · 1 line
2.26.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Greg Kroah-Hartman

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.

In doing this, make brcmf_debugfs_add_entry() return void as no one was even paying attention to the return value.

Quoted 15 lines
Cc Arend van Spriel <[email protected]>
Cc Franky Lin <[email protected]>
Cc Hante Meuleman <[email protected]>
Cc Chi-Hsien Lin <[email protected]>
Cc Wright Feng <[email protected]>
Cc Kalle Valo <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Pieter-Paul Giesberts <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc "Rafał Miłecki" <[email protected]>
Quoted 5 lines
---
  .../net/wireless/broadcom/brcm80211/brcmfmac/debug.c |  9 +++------
  .../net/wireless/broadcom/brcm80211/brcmfmac/debug.h | 12 +++++-------
  2 files changed, 8 insertions(+), 13 deletions(-)
#2 lore raw
In reply to Greg Kroah-Hartman
Quoted 16 lines · Greg Kroah-Hartman

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.

In doing this, make brcmf_debugfs_add_entry() return void as no one was even paying attention to the return value.

Cc Arend van Spriel <[email protected]>
Cc Franky Lin <[email protected]>
Cc Hante Meuleman <[email protected]>
Cc Chi-Hsien Lin <[email protected]>
Cc Wright Feng <[email protected]>
Cc Kalle Valo <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Pieter-Paul Giesberts <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Quoted 8 lines

Patch applied to wireless-drivers-next.git, thanks.

ea1b3bc6d5ad brcmfmac: no need to check return value of debugfs_create functions

Signature · 3 lines
https://patchwork.kernel.org/patch/11516617/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches