s390/cio: fix device lifecycle handling in css_alloc_subchannel()
Subsystems (2)
PATCH 1/1 s390/cio: fix device lifecycle handling in css_alloc_subchannel()
css_alloc_subchannel() calls device_initialize() before setting up the DMA masks. If dma_set_coherent_mask() or dma_set_mask() fails, the error path frees the subchannel structure directly, bypassing the device model reference counting.
Once device_initialize() has been called, the embedded struct device must be released via put_device(), allowing the release callback to free the container structure.
Fix the error path by dropping the initial device reference with put_device() instead of calling kfree() directly.
This ensures correct device lifetime handling and avoids potential use-after-free or double-free issues.
--- drivers/s390/cio/css.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/s390/cio/css.c +1 -1
@@ -235,7 +235,7 @@ struct subchannel *css_alloc_subchannel(struct subchannel_id schid,return sch; err: -kfree (sch); +put_device (&sch->dev);return ERR_PTR (ret); }
Signature · 1 line
2.43.0
Quoted 12 lines · Salah Triki
css_alloc_subchannel()callsdevice_initialize()before setting up the DMA masks. Ifdma_set_coherent_mask()ordma_set_mask()fails, the error path frees the subchannel structure directly, bypassing the device model reference counting.Once
device_initialize()has been called, the embedded struct device must be released viaput_device(), allowing the release callback to free the container structure.Fix the error path by dropping the initial device reference with
put_device()instead of callingkfree()directly.
Quoted 7 lines
This ensures correct device lifetime handling and avoids potential use-after-free or double-free issues.
Fixes e5dcf0025d7af ("s390/css: move subchannel lock allocation")Signed-off-by Salah Triki<[email protected]>---
Thank you.
this looks good to me.
Quoted 15 lines · Salah Triki
css_alloc_subchannel()callsdevice_initialize()before setting up the DMA masks. Ifdma_set_coherent_mask()ordma_set_mask()fails, the error path frees the subchannel structure directly, bypassing the device model reference counting.Once
device_initialize()has been called, the embedded struct device must be released viaput_device(), allowing the release callback to free the container structure.Fix the error path by dropping the initial device reference with
put_device()instead of callingkfree()directly.This ensures correct device lifetime handling and avoids potential use-after-free or double-free issues.
Quoted 6 lines
Fixes e5dcf0025d7af ("s390/css: move subchannel lock allocation")Signed-off-by Salah Triki <[email protected]>--- drivers/s390/cio/css.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.