nvdimm: Use of_property_present() and of_property_read_bool()
PATCH 1/1 nvdimm: Use of_property_present() and of_property_read_bool()
Use of_property_present() and of_property_read_bool() to test property presence and read boolean properties rather than of_(find|get)_property(). This is part of a larger effort to remove callers of of_find_property() and similar functions. of_(find|get)_property() leak the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed.
--- drivers/nvdimm/of_pmem.c | 2 +- drivers/nvmem/layouts.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/nvdimm/of_pmem.c +1 -1
@@ -47,7 +47,7 @@ static int of_pmem_region_probe(struct platform_device *pdev) }platform_set_drvdata (pdev, priv); - is_volatile = !!of_find_property (np,"volatile" ,NULL ); + is_volatile =of_property_read_bool (np,"volatile" );dev_dbg (&pdev->dev,"Registering %s regions from %pOF\n" , is_volatile ?"volatile" :"non-volatile" , np);
drivers/nvmem/layouts.c +1 -1
@@ -123,7 +123,7 @@ static int nvmem_layout_bus_populate(struct nvmem_device *nvmem,int ret;/* Make sure it has a compatible property */ -if (!of_get_property (layout_dn,"compatible" ,NULL )) { +if (!of_property_present (layout_dn,"compatible" )) {pr_debug ("%s() - skipping %pOF, no compatible prop\n" , __func__, layout_dn);return 0 ;
Signature · 1 line
2.43.0
Quoted 8 lines · Rob Herring (Arm)
Use
of_property_present()andof_property_read_bool()to test property presence and read boolean properties rather than of_(find|get)_property(). This is part of a larger effort to remove callers ofof_find_property()and similar functions. of_(find|get)_property() leak the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed.Signed-off-by Rob Herring (Arm) <[email protected]>
Quoted 31 lines
--- drivers/nvdimm/of_pmem.c | 2 +- drivers/nvmem/layouts.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/nvdimm/of_pmem.c +1
-1@@ -47,7 +47,7 @@ static int of_pmem_region_probe(struct platform_device *pdev) }platform_set_drvdata (pdev, priv); - is_volatile = !!of_find_property (np,"volatile" ,NULL ); + is_volatile =of_property_read_bool (np,"volatile" );dev_dbg (&pdev->dev,"Registering %s regions from %pOF\n" , is_volatile ?"volatile" :"non-volatile" , np);drivers/nvmem/layouts.c +1
-1@@ -123,7 +123,7 @@ static int nvmem_layout_bus_populate(struct nvmem_device *nvmem,int ret;/* Make sure it has a compatible property */ -if (!of_get_property (layout_dn,"compatible" ,NULL )) { +if (!of_property_present (layout_dn,"compatible" )) {pr_debug ("%s() - skipping %pOF, no compatible prop\n" , __func__, layout_dn);return 0 ;
Quoted 8 lines · Rob Herring (Arm)
Use
of_property_present()andof_property_read_bool()to test property presence and read boolean properties rather than of_(find|get)_property(). This is part of a larger effort to remove callers ofof_find_property()and similar functions. of_(find|get)_property() leak the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed.
Quoted 5 lines
Signed-off-by Rob Herring (Arm) <[email protected]>--- drivers/nvdimm/of_pmem.c | 2 +- drivers/nvmem/layouts.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Ping
Quoted 29 lines
drivers/nvdimm/of_pmem.c +1
-1@@ -47,7 +47,7 @@ static int of_pmem_region_probe(struct platform_device *pdev) }platform_set_drvdata (pdev, priv); - is_volatile = !!of_find_property (np,"volatile" ,NULL ); + is_volatile =of_property_read_bool (np,"volatile" );dev_dbg (&pdev->dev,"Registering %s regions from %pOF\n" , is_volatile ?"volatile" :"non-volatile" , np);drivers/nvmem/layouts.c +1
-2@@ -123,7 +123,7 @@ static int nvmem_layout_bus_populate(struct nvmem_device *nvmem,int ret;/* Make sure it has a compatible property */ -if (!of_get_property (layout_dn,"compatible" ,NULL )) { +if (!of_property_present (layout_dn,"compatible" )) {pr_debug ("%s() - skipping %pOF, no compatible prop\n" , __func__, layout_dn);return 0 ; --2.43.0
Quoted 9 lines · Rob Herring
Quoted 8 lines · Rob Herring (Arm)
Use
of_property_present()andof_property_read_bool()to test property presence and read boolean properties rather than of_(find|get)_property(). This is part of a larger effort to remove callers ofof_find_property()and similar functions. of_(find|get)_property() leak the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed.
Quoted 7 lines
Quoted 5 lines
Signed-off-by Rob Herring (Arm) <[email protected]>--- drivers/nvdimm/of_pmem.c | 2 +- drivers/nvmem/layouts.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)Ping
It is soaking for 6.12.
https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git/log/?h=libnvdimm-for-next
Thanks,
Ira
Quoted 30 lines
Quoted 30 lines
drivers/nvdimm/of_pmem.c +1
-1@@ -47,7 +47,7 @@ static int of_pmem_region_probe(struct platform_device *pdev) }platform_set_drvdata (pdev, priv); - is_volatile = !!of_find_property (np,"volatile" ,NULL ); + is_volatile =of_property_read_bool (np,"volatile" );dev_dbg (&pdev->dev,"Registering %s regions from %pOF\n" , is_volatile ?"volatile" :"non-volatile" , np);drivers/nvmem/layouts.c +1
-2@@ -123,7 +123,7 @@ static int nvmem_layout_bus_populate(struct nvmem_device *nvmem,int ret;/* Make sure it has a compatible property */ -if (!of_get_property (layout_dn,"compatible" ,NULL )) { +if (!of_property_present (layout_dn,"compatible" )) {pr_debug ("%s() - skipping %pOF, no compatible prop\n" , __func__, layout_dn);return 0 ; --2.43.0