drm/damage_helper: Check if damage clips has valid values
PATCH v5 1/6 drm/damage_helper: Check if damage clips has valid values
Userspace can set a damage clip with a negative coordinate, negative width or height or larger than the plane.
This invalid values could cause issues in some HW or even worst enable security flaws.
v2:
- add debug messages to let userspace know why atomic commit failed due invalid damage clips
--- drivers/gpu/drm/drm_atomic_helper.c | 4 +- drivers/gpu/drm/drm_damage_helper.c | 59 ++++++++++++++++++++++++----- include/drm/drm_damage_helper.h | 4 +- 3 files changed, 55 insertions(+), 12 deletions(-)
drivers/gpu/drm/drm_atomic_helper.c +3 -1
@@ -897,7 +897,9 @@ drm_atomic_helper_check_planes(struct drm_device *dev,drm_atomic_helper_plane_changed (state, old_plane_state, new_plane_state, plane); -drm_atomic_helper_check_plane_damage (state, new_plane_state); + ret =drm_atomic_helper_check_plane_damage (state, new_plane_state); +if (ret) +return ret;if (!funcs || !funcs->atomic_check)continue ;
drivers/gpu/drm/drm_damage_helper.c +50 -9
92 lines not on this page · raw message
include/drm/drm_damage_helper.h +2 -2
@@ -65,8 +65,8 @@ struct drm_atomic_helper_damage_iter { };void drm_plane_enable_fb_damage_clips (struct drm_plane *plane); -void drm_atomic_helper_check_plane_damage (struct drm_atomic_state *state, -struct drm_plane_state *plane_state); +int drm_atomic_helper_check_plane_damage (struct drm_atomic_state *state, +struct drm_plane_state *plane_state); int drm_atomic_helper_dirtyfb(struct drm_framebuffer *fb, struct drm_file *file_priv, unsigned int flags, unsigned int color, struct drm_clip_rect *clips,
Signature · 6 lines
2.29.2 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v5 2/6 drm/i915/display: Check plane damage clips
Call the function that validates every damage clips of each plane. As in commit 093a3a300009 ("drm/i915: Add plane damage clips property") this property was only enabled for gen12+ only checking it for gen12 too.
v2:
- add logs to underspace understand why commit was rejected
--- drivers/gpu/drm/i915/display/intel_sprite.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/display/intel_sprite.c +7 -0
@@ -2492,6 +2492,13 @@ static int skl_plane_check(struct intel_crtc_state *crtc_state,if (ret)return ret; +if (INTEL_GEN (dev_priv) >=12 ) { + ret =drm_atomic_helper_check_plane_damage (crtc_state->uapi.state, + &plane_state->uapi); +if (ret) +return ret; + } +/* HW only has 8 bits pixel precision, disable plane if invisible */ if (!(plane_state->hw.alpha >>8 )) plane_state->uapi.visible = false;
Signature · 6 lines
2.29.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v5 2/6] drm/i915/display: Check plane damage clips
Quoted 22 lines · José Roberto de Souza
Call the function that validates every damage clips of each plane. As in commit
093a3a300009("drm/i915: Add plane damage clips property")
this property was only enabled for gen12+ only checking it for gen12 too.v2:
- add logs to underspace understand why commit was rejectedCc Gwan-gyeong Mun <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by José Roberto de Souza <[email protected]>--- drivers/gpu/drm/i915/display/intel_sprite.c | 7 +++++++ 1 file changed, 7 insertions(+)drivers/gpu/drm/i915/display/intel_sprite.c +0
-0
drivers/gpu/drm/i915/display/intel_sprite.c static int skl_plane_check(struct · line 2499
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_sprite.c +3
-0@@ -2492,6 +2492,13 @@ static int skl_plane_check(struct intel_crtc_state *crtc_state, if (ret) return ret; +if (INTEL_GEN (dev_priv) >=12 ) { + ret = drm_atomic_helper_check_plane_damage(crtc_state- >uapi.state, +
we should only exclude the damaged clip which is outside fb src. therefore if there is at least one damage clip intersect fb src rect, we should handle this damage clip region.
drivers/gpu/drm/i915/display/intel_sprite.c static int skl_plane_check(struct intel_crtc_state *crtc_state, · line 2504
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_sprite.c +4
-1&plane_state ->uapi); +if (ret) +return ret; + } +/* HW only has 8 bits pixel precision, disable plane if invisible */
drivers/gpu/drm/i915/display/intel_sprite.c +0
-0if (!(plane_state->hw.alpha >>8 )) plane_state->uapi.visible = false;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 3/6 drm/i915/display/psr: Use plane damage clips to calculate damaged area
In reply to José Roberto de SouzaNow using plane damage clips property to calcualte the damaged area. Selective fetch only supports one region to be fetched so software needs to calculate a bounding box around all damage clips.
Now that we are not complete fetching each plane, there is another loop needed as all the plane areas that intersect with the pipe damadged area needs to be fetched from memory so the complete blending of all planes can happen.
v2:
- do not shifthing new_plane_state->uapi.dst only src is in 16.16 format
v4:
- setting plane selective fetch area using the whole pipe damage area
- mark the whole plane area damaged if plane visibility or alpha changed
v5:
- taking in consideration src.y1 in the damage coordinates
- adding to the pipe damaged area planes that were visible but are invisible in the new state
--- drivers/gpu/drm/i915/display/intel_psr.c | 93 ++++++++++++++++++++---- 1 file changed, 79 insertions(+), 14 deletions(-)
drivers/gpu/drm/i915/display/intel_psr.c +79 -14
@@ -1269,11 +1269,11 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state, struct intel_crtc *crtc) {struct intel_crtc_state *crtc_state =intel_atomic_get_new_crtc_state (state, crtc); +struct drm_rect pipe_clip = { .x1 =0 , .y1 =-1 , .x2 =INT_MAX , .y2 =-1 };struct intel_plane_state *new_plane_state, *old_plane_state; -struct drm_rect pipe_clip = { .y1 =-1 };struct intel_plane *plane;bool full_update = false; -int i, ret; +int i, src_y1, src_y2, ret;if (!crtc_state->enable_psr2_sel_fetch)return 0 ;
@@ -1282,9 +1282,21 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,if (ret)return ret; + src_y1 = new_plane_state->uapi.src.y1 >>16 ; + src_y2 = new_plane_state->uapi.src.y2 >>16 ; + +/* +* Calculate minimal selective fetch area of each plane and calculate +* the pipe damaged area. +* In the next loop the plane selective fetch area will actually be set +* using whole pipe damaged area. +*/ for_each_oldnew_intel_plane_in_state (state, plane, old_plane_state, new_plane_state, i) { -struct drm_rect *sel_fetch_area, temp; +struct drm_mode_rect *damaged_clips; +struct drm_rect sel_fetch_area = { .y1 =-1 }; +u32 num_clips; +int j;if (new_plane_state->uapi.crtc != crtc_state->uapi.crtc)continue ;
@@ -1300,23 +1312,76 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,break ; } -if (!new_plane_state->uapi.visible) -continue ; + damaged_clips =drm_plane_get_damage_clips (&new_plane_state->uapi); + num_clips =drm_plane_get_damage_clips_count (&new_plane_state->uapi);/* -* For now doing a selective fetch in the whole plane area, -* optimizations will come in the future. +* If visibility or alpha changed or plane moved, mark the whole +* plane area as damaged as it needs to be complete redraw in +* the new position. */ - sel_fetch_area = &new_plane_state->psr2_sel_fetch_area; - sel_fetch_area->y1 = new_plane_state->uapi.src.y1 >>16 ; - sel_fetch_area->y2 = new_plane_state->uapi.src.y2 >>16 ; +if (new_plane_state->uapi.visible != old_plane_state->uapi.visible || + new_plane_state->uapi.alpha != old_plane_state->uapi.alpha || + !drm_rect_equals (&new_plane_state->uapi.dst, + &old_plane_state->uapi.dst)) { + num_clips =0 ; + sel_fetch_area.y1 = src_y1; + sel_fetch_area.y2 = src_y2; + }else if (!num_clips && new_plane_state->uapi.fb != + old_plane_state->uapi.fb) { +/* +* If the plane don't have damage areas but the +* framebuffer changed, mark the whole plane area as +* damaged. +*/ + sel_fetch_area.y1 = src_y1; + sel_fetch_area.y2 = src_y2; + } + +for (j =0 ; j < num_clips; j++) { +struct drm_rect damage_area; + + damage_area.y1 = damaged_clips[j].y1 + src_y1; + damage_area.y2 = damaged_clips[j].y2 + src_y1; +clip_area_update (&sel_fetch_area, &damage_area); + } + +/* No damaged area in this plane */ +if (sel_fetch_area.y1 ==-1 ) { + sel_fetch_area.y1 =0 ; + sel_fetch_area.y2 =0 ; + } - temp = *sel_fetch_area; - temp.y1 += new_plane_state->uapi.dst.y1; - temp.y2 += new_plane_state->uapi.dst.y2; -clip_area_update (&pipe_clip, &temp); + sel_fetch_area.y1 += new_plane_state->uapi.dst.y1; + sel_fetch_area.y2 += new_plane_state->uapi.dst.y1; +clip_area_update (&pipe_clip, &sel_fetch_area); + } + +if (full_update) + goto skip_sel_fetch_set_loop; + +/* +* Now that we have the pipe damaged area check if it intersect with +* every plane, if it does set the plane selective fetch area. +*/ +for_each_oldnew_intel_plane_in_state (state, plane, old_plane_state, + new_plane_state, i) { +struct drm_rect *sel_fetch_area, inter; + +if (new_plane_state->uapi.crtc != crtc_state->uapi.crtc || + !new_plane_state->uapi.visible) +continue ; + + inter = pipe_clip; +if (!drm_rect_intersect (&inter, &new_plane_state->uapi.dst)) +continue ; + + sel_fetch_area = &new_plane_state->psr2_sel_fetch_area; + sel_fetch_area->y1 = inter.y1 - new_plane_state->uapi.dst.y1 + src_y1; + sel_fetch_area->y2 = inter.y2 - new_plane_state->uapi.dst.y1 + src_y1; } +skip_sel_fetch_set_loop:psr2_man_trk_ctl_calc (crtc_state, &pipe_clip, full_update);return 0 ; }
Signature · 6 lines
2.29.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v5 3/6] drm/i915/display/psr: Use plane damage clips to calculate damaged area
Quoted 138 lines · José Roberto de Souza
Now using plane damage clips property to calcualte the damaged area. Selective fetch only supports one region to be fetched so software needs to calculate a bounding box around all damage clips.
Now that we are not complete fetching each plane, there is another loop needed as all the plane areas that intersect with the pipe damadged area needs to be fetched from memory so the complete blending
of all planes can happen.v2:
- do not shifthingnew_plane_state->uapi.dstonly src is in 16.16 formatv4:
- setting plane selective fetch area using the whole pipe damage area
- mark the whole plane area damaged if plane visibility or alpha changedv5:
- taking in consideration src.y1 in the damage coordinates
- adding to the pipe damaged area planes that were visible but are invisible in the new stateCc Ville Syrjälä <[email protected]>Cc Gwan-gyeong Mun <[email protected]>Signed-off-by José Roberto de Souza <[email protected]>--- drivers/gpu/drm/i915/display/intel_psr.c | 93 ++++++++++++++++++++ ---- 1 file changed, 79 insertions(+), 14 deletions(-)drivers/gpu/drm/i915/display/intel_psr.c +2
-2@@ -1269,11 +1269,11 @@ int intel_psr2_sel_fetch_update(structintel_atomic_state *state, struct intel_crtc *crtc) { struct intel_crtc_state *crtc_state =intel_atomic_get_new_crtc_state (state, crtc); +struct drm_rect pipe_clip = { .x1 =0 , .y1 =-1 , .x2 =INT_MAX , .y2 =-1 };struct intel_plane_state *new_plane_state, *old_plane_state; -struct drm_rect pipe_clip = { .y1 =-1 };struct intel_plane *plane;bool full_update = false; -int i, ret; +int i, src_y1, src_y2, ret;drivers/gpu/drm/i915/display/intel_psr.c +5
-0if (!crtc_state->enable_psr2_sel_fetch)return 0 ;@@ -1282,9 +1282,21 @@ int intel_psr2_sel_fetch_update(structintel_atomic_state *state, if (ret) return ret; + src_y1 = new_plane_state->uapi.src.y1 >>16 ; + src_y2 = new_plane_state->uapi.src.y2 >>16 ; + +/* +* Calculate minimal selective fetch area of each plane and calculate
drivers/gpu/drm/i915/display/intel_psr.c +2
-0+* the pipe damaged area. +* In the next loop the plane selective fetch area will actually be set
drivers/gpu/drm/i915/display/intel_psr.c +2
-0+* using whole pipe damaged area. +*/ for_each_oldnew_intel_plane_in_state(state, plane,
old_plane_state,drivers/gpu/drm/i915/display/intel_psr.c +4
-1new_plane_state, i) { - struct drm_rect *sel_fetch_area, temp; + struct drm_mode_rect *damaged_clips; + struct drm_rect sel_fetch_area = { .y1 = -1 }; + u32 num_clips; + int j; if (new_plane_state->uapi.crtc != crtc_state-Quoted 1 line
uapi.crtc)
drivers/gpu/drm/i915/display/intel_psr.c +3
-4continue ;@@ -1300,23 +1312,76 @@ int intel_psr2_sel_fetch_update(structintel_atomic_state *state, break; } -if (!new_plane_state->uapi.visible) -continue ; + damaged_clips =drm_plane_get_damage_clips (&new_plane_state->uapi); + num_clips =drm_plane_get_damage_clips_count (&new_plane_state->uapi);/* -* For now doing a selective fetch in the whole plane area, -* optimizations will come in the future. +* If visibility or alpha changed or plane moved, mark the whole
drivers/gpu/drm/i915/display/intel_psr.c +1
-0+* plane area as damaged as it needs to be complete redraw in
drivers/gpu/drm/i915/display/intel_psr.c +1
-2+* the new position. */ - sel_fetch_area = &new_plane_state->psr2_sel_fetch_area; - sel_fetch_area->y1 = new_plane_state->uapi.src.y1 >>16;
drivers/gpu/drm/i915/display/intel_psr.c +0
-1- sel_fetch_area->y2 = new_plane_state->uapi.src.y2 >>16;
drivers/gpu/drm/i915/display/intel_psr.c +1
-0+ if (new_plane_state->uapi.visible != old_plane_state-Quoted 1 line
uapi.visible ||
drivers/gpu/drm/i915/display/intel_psr.c +1
-0+ new_plane_state->uapi.alpha != old_plane_state-Quoted 1 line
uapi.alpha ||
drivers/gpu/drm/i915/display/intel_psr.c +10
-0+ !drm_rect_equals(&new_plane_state->uapi.dst, + &old_plane_state->uapi.dst)) { + num_clips =0 ; + sel_fetch_area.y1 = src_y1; + sel_fetch_area.y2 = src_y2; + } else if (!num_clips && new_plane_state->uapi.fb != + old_plane_state->uapi.fb) { +/* +* If the plane don't have damage areas but the +* framebuffer changed, mark the whole plane area as
drivers/gpu/drm/i915/display/intel_psr.c +12
-0+* damaged. +*/ + sel_fetch_area.y1 = src_y1; + sel_fetch_area.y2 = src_y2; + } + +for (j =0 ; j < num_clips; j++) { +struct drm_rect damage_area; + + damage_area.y1 = damaged_clips[j].y1 + src_y1; + damage_area.y2 = damaged_clips[j].y2 + src_y1; + clip_area_update(&sel_fetch_area,
&damage_area);
drivers/gpu/drm/i915/display/intel_psr.c int intel_psr2_sel_fetch_update(struct intel_atomic_state *state, · line 1353
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_psr.c +7
-0+ } + +/* No damaged area in this plane */ +if (sel_fetch_area.y1 ==-1 ) { + sel_fetch_area.y1 =0 ; + sel_fetch_area.y2 =0 ; + }
1. Visibility change case
The pipe damaged area (The Selective Update region) needs to
accumulate both old and new plane's dst
2. Move case
The pipe damaged area (The Selective Update region) needs to
accumulate both old and new plane's dst
3. damage case
if the damage clips don't intersect src we don't need to accumalate it
to merged damage area.
we can calculate the SelectiveUpdate area with plane's dst and only the damage area need to be translated to dst coordinates.
drivers/gpu/drm/i915/display/intel_psr.c int intel_psr2_sel_fetch_update(struct intel_atomic_state *state, · line 1316
Quoted 3 lines
drivers/gpu/drm/i915/display/intel_psr.c +0
-3- temp = *sel_fetch_area; - temp.y1 += new_plane_state->uapi.dst.y1; - temp.y2 += new_plane_state->uapi.dst.y2;
for translating to dst coordinates from src coordinates, we should do like this
dst_damaged_area.y1 = src_damaged_area.y1 - plane's src.y1 + plane's dst.y1;
Quoted 34 lines
drivers/gpu/drm/i915/display/intel_psr.c +10
-1-clip_area_update (&pipe_clip, &temp); + sel_fetch_area.y1 += new_plane_state->uapi.dst.y1; + sel_fetch_area.y2 += new_plane_state->uapi.dst.y1; +clip_area_update (&pipe_clip, &sel_fetch_area); + } + +if (full_update) + goto skip_sel_fetch_set_loop; + +/* +* Now that we have the pipe damaged area check if it intersect with
drivers/gpu/drm/i915/display/intel_psr.c +3
-0+* every plane, if it does set the plane selective fetch area. +*/ + for_each_oldnew_intel_plane_in_state(state, plane,
old_plane_state,drivers/gpu/drm/i915/display/intel_psr.c +4
-0+ new_plane_state, i) { +struct drm_rect *sel_fetch_area, inter; + + if (new_plane_state->uapi.crtc != crtc_state->uapi.crtc||
drivers/gpu/drm/i915/display/intel_psr.c +5
-0+ !new_plane_state->uapi.visible) +continue ; + + inter = pipe_clip; + if (!drm_rect_intersect(&inter, &new_plane_state-Quoted 1 line
uapi.dst))
drivers/gpu/drm/i915/display/intel_psr.c +4
-0+continue ; + + sel_fetch_area = &new_plane_state->psr2_sel_fetch_area; + sel_fetch_area->y1 = inter.y1 - new_plane_state-Quoted 1 line
uapi.dst.y1 +
src_y1;drivers/gpu/drm/i915/display/intel_psr.c +1
-0+ sel_fetch_area->y2 = inter.y2 - new_plane_state-Quoted 1 line
uapi.dst.y1 +
src_y1;
drivers/gpu/drm/i915/display/intel_psr.c int intel_psr2_sel_fetch_update(struct intel_atomic_state *state, · line 1387
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_psr.c +1
-0} +skip_sel_fetch_set_loop:psr2_man_trk_ctl_calc (crtc_state, &pipe_clip, full_update);return 0 ; }
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v5 3/6] drm/i915/display/psr: Use plane damage clips to calculate damaged area
Quoted 165 lines · Gwan-gyeong
Quoted 153 lines · José Roberto de Souza
Now using plane damage clips property to calcualte the damaged area. Selective fetch only supports one region to be fetched so software needs to calculate a bounding box around all damage clips.
Now that we are not complete fetching each plane, there is another loop needed as all the plane areas that intersect with the pipe damadged area needs to be fetched from memory so the complete blending
of all planes can happen.v2:
- do not shifthingnew_plane_state->uapi.dstonly src is in 16.16 formatv4:
- setting plane selective fetch area using the whole pipe damage area
- mark the whole plane area damaged if plane visibility or alpha changedv5:
- taking in consideration src.y1 in the damage coordinates
- adding to the pipe damaged area planes that were visible but are invisible in the new stateCc Ville Syrjälä <[email protected]>Cc Gwan-gyeong Mun <[email protected]>Signed-off-by José Roberto de Souza <[email protected]>---
drivers/gpu/drm/i915/display/intel_psr.c | 93 ++++++++++++++++++++
----1 file changed, 79 insertions(+), 14 deletions(-)drivers/gpu/drm/i915/display/intel_psr.c +0
-0@@ -1269,11 +1269,11 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state, struct intel_crtc *crtc) {struct
intel_crtc_state*crtc_state=intel_atomic_get_new_crtc_state(state, crtc);drivers/gpu/drm/i915/display/intel_psr.c +1
-0+struct drm_rect pipe_clip = { .x1 =0 , .y1 =-1 , .x2 =INT_MAX ,.y2 = -1 };
structintel_plane_state*new_plane_state,*old_plane_state;drivers/gpu/drm/i915/display/intel_psr.c +0
-1-struct drm_rect pipe_clip = { .y1 =-1 };struct
intel_plane*plane;
boolfull_update= false;drivers/gpu/drm/i915/display/intel_psr.c +1
-1-int i, ret; +int i, src_y1, src_y2, ret;if (!crtc_state->enable_psr2_sel_fetch)
return 0;drivers/gpu/drm/i915/display/intel_psr.c +0
-0@@ -1282,9 +1282,21 @@ int intel_psr2_sel_fetch_update(structintel_atomic_state *state, if (ret) return ret;drivers/gpu/drm/i915/display/intel_psr.c +5
-0+ src_y1 = new_plane_state->uapi.src.y1 >>16 ; + src_y2 = new_plane_state->uapi.src.y2 >>16 ; + +/* +* Calculate minimal selective fetch area of each plane and calculate
drivers/gpu/drm/i915/display/intel_psr.c +2
-0+* the pipe damaged area. +* In the next loop the plane selective fetch area will actually be set
drivers/gpu/drm/i915/display/intel_psr.c +2
-0+* using whole pipe damaged area. +*/ for_each_oldnew_intel_plane_in_state(state, plane,
old_plane_state,
new_plane_state, i) {drivers/gpu/drm/i915/display/intel_psr.c +4
-1-struct drm_rect *sel_fetch_area, temp; +struct drm_mode_rect *damaged_clips; +struct drm_rect sel_fetch_area = { .y1 =-1 }; +u32 num_clips; +int j;if (
new_plane_state->uapi.crtc!= crtc_state-Quoted 1 line
uapi.crtc)
continue;
drivers/gpu/drm/i915/display/intel_psr.c +0
-0@@ -1300,23 +1312,76 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state, break; }drivers/gpu/drm/i915/display/intel_psr.c +1
-2-if (!new_plane_state->uapi.visible) -continue ; + damaged_clips =
drm_plane_get_damage_clips(&new_plane_state->uapi);drivers/gpu/drm/i915/display/intel_psr.c +1
-0+ num_clips =
drm_plane_get_damage_clips_count(&new_plane_state->uapi);/*
drivers/gpu/drm/i915/display/intel_psr.c +0
-1-* For now doing a selective fetch in the whole plane area,
drivers/gpu/drm/i915/display/intel_psr.c +1
-1-* optimizations will come in the future. +* If visibility or alpha changed or plane moved, mark the whole
drivers/gpu/drm/i915/display/intel_psr.c +1
-0+* plane area as damaged as it needs to be complete redraw in
drivers/gpu/drm/i915/display/intel_psr.c +1
-0+* the new position. */
drivers/gpu/drm/i915/display/intel_psr.c +0
-2- sel_fetch_area = &new_plane_state->psr2_sel_fetch_area; - sel_fetch_area->y1 = new_plane_state->uapi.src.y1 >>16;
drivers/gpu/drm/i915/display/intel_psr.c +0
-1- sel_fetch_area->y2 = new_plane_state->uapi.src.y2 >>16;
drivers/gpu/drm/i915/display/intel_psr.c +1
-0+ if (new_plane_state->uapi.visible != old_plane_state-Quoted 1 line
uapi.visible ||
drivers/gpu/drm/i915/display/intel_psr.c +1
-0+ new_plane_state->uapi.alpha != old_plane_state-Quoted 1 line
uapi.alpha ||
drivers/gpu/drm/i915/display/intel_psr.c +10
-0+ !drm_rect_equals(&new_plane_state->uapi.dst, + &old_plane_state->uapi.dst)) { + num_clips =0 ; + sel_fetch_area.y1 = src_y1; + sel_fetch_area.y2 = src_y2; + } else if (!num_clips && new_plane_state->uapi.fb != + old_plane_state->uapi.fb) { +/* +* If the plane don't have damage areas but the +* framebuffer changed, mark the whole plane area as
drivers/gpu/drm/i915/display/intel_psr.c +12
-0+* damaged. +*/ + sel_fetch_area.y1 = src_y1; + sel_fetch_area.y2 = src_y2; + } + +for (j =0 ; j < num_clips; j++) { +struct drm_rect damage_area; + + damage_area.y1 = damaged_clips[j].y1 + src_y1; + damage_area.y2 = damaged_clips[j].y2 + src_y1; + clip_area_update(&sel_fetch_area,
&damage_area);drivers/gpu/drm/i915/display/intel_psr.c int intel_psr2_sel_fetch_update(struct intel_atomic_state *state, · line 1353
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_psr.c +7
-0+ } + +/* No damaged area in this plane */ +if (sel_fetch_area.y1 ==-1 ) { + sel_fetch_area.y1 =0 ; + sel_fetch_area.y2 =0 ; + }1. Visibility change case
The pipe damaged area (The Selective Update region) needs to accumulate both old and new plane's dst
Quoted 7 lines
2. Move case
The pipe damaged area (The Selective Update region) needs to accumulate both old and new plane's dst3. damage case
if the damage clips don't intersect src we don't need to accumalate it to merged damage area.
Makes sense, doing the changes.
Quoted 4 lines
we can calculate the SelectiveUpdate area with plane's dst and only the damage area need to be translated to dst coordinates.
Quoted 50 lines
drivers/gpu/drm/i915/display/intel_psr.c int intel_psr2_sel_fetch_update(struct intel_atomic_state *state, · line 1316
Quoted 3 lines
drivers/gpu/drm/i915/display/intel_psr.c +0
-3- temp = *sel_fetch_area; - temp.y1 += new_plane_state->uapi.dst.y1; - temp.y2 += new_plane_state->uapi.dst.y2;for translating to dst coordinates from src coordinates, we should do like this
dst_damaged_area.y1 = src_damaged_area.y1 - plane's src.y1 + plane's dst.y1;Quoted 43 lines
drivers/gpu/drm/i915/display/intel_psr.c +10
-1-clip_area_update (&pipe_clip, &temp); + sel_fetch_area.y1 += new_plane_state->uapi.dst.y1; + sel_fetch_area.y2 += new_plane_state->uapi.dst.y1; +clip_area_update (&pipe_clip, &sel_fetch_area); + } + +if (full_update) + goto skip_sel_fetch_set_loop; + +/* +* Now that we have the pipe damaged area check if it intersect with
drivers/gpu/drm/i915/display/intel_psr.c +3
-0+* every plane, if it does set the plane selective fetch area. +*/ + for_each_oldnew_intel_plane_in_state(state, plane,
old_plane_state,drivers/gpu/drm/i915/display/intel_psr.c +4
-0+ new_plane_state, i) { +struct drm_rect *sel_fetch_area, inter; + + if (new_plane_state->uapi.crtc != crtc_state->uapi.crtcQuoted 1 line
Quoted 1 line
drivers/gpu/drm/i915/display/intel_psr.c +5
-0+ !new_plane_state->uapi.visible) +continue ; + + inter = pipe_clip; + if (!drm_rect_intersect(&inter, &new_plane_state-Quoted 1 line
uapi.dst))
drivers/gpu/drm/i915/display/intel_psr.c +4
-0+continue ; + + sel_fetch_area = &new_plane_state->psr2_sel_fetch_area; + sel_fetch_area->y1 = inter.y1 - new_plane_state-Quoted 1 line
uapi.dst.y1 +
src_y1;drivers/gpu/drm/i915/display/intel_psr.c +1
-0+ sel_fetch_area->y2 = inter.y2 - new_plane_state-Quoted 1 line
uapi.dst.y1 +
src_y1;}
+skip_sel_fetch_set_loop:
psr2_man_trk_ctl_calc(crtc_state, &pipe_clip, full_update); return 0;
}
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 4/6 drm/i915/display: Split and export main surface calculation from skl_check_main_surface()
In reply to José Roberto de SouzaThe calculation the offsets of the main surface will be needed by PSR2 selective fetch code so here splitting and exporting it.
No functional changes were done here.
v3: Rebased
--- drivers/gpu/drm/i915/display/intel_display.c | 78 ++++++++++++-------- drivers/gpu/drm/i915/display/intel_display.h | 2 + 2 files changed, 51 insertions(+), 29 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +49 -29
@@ -3821,33 +3821,19 @@ static int intel_plane_max_height(struct intel_plane *plane,return INT_MAX ; } -static int skl_check_main_surface (struct intel_plane_state *plane_state) +int skl_calc_main_surface_offset (const struct intel_plane_state *plane_state, +int *x,int *y,u32 *offset) {struct intel_plane *plane =to_intel_plane (plane_state->uapi.plane);struct drm_i915_private *dev_priv =to_i915 (plane->base.dev);const struct drm_framebuffer *fb = plane_state->hw.fb; -unsigned int rotation = plane_state->hw.rotation; -int x = plane_state->uapi.src.x1 >>16 ; -int y = plane_state->uapi.src.y1 >>16 ; -int w =drm_rect_width (&plane_state->uapi.src) >>16 ; -int h =drm_rect_height (&plane_state->uapi.src) >>16 ; -int min_width =intel_plane_min_width (plane, fb,0 , rotation); -int max_width =intel_plane_max_width (plane, fb,0 , rotation); -int max_height =intel_plane_max_height (plane, fb,0 , rotation); -int aux_plane =intel_main_to_aux_plane (fb,0 ); -u32 aux_offset = plane_state->color_plane[aux_plane].offset; -u32 alignment, offset; +const int aux_plane =intel_main_to_aux_plane (fb,0 ); +const u32 aux_offset = plane_state->color_plane[aux_plane].offset; +const u32 alignment =intel_surf_alignment (fb,0 ); +const int w =drm_rect_width (&plane_state->uapi.src) >>16 ; -if (w > max_width || w < min_width || h > max_height) { -drm_dbg_kms (&dev_priv->drm, -"requested Y/RGB source size %dx%d outside limits (min: %dx1 max: %dx%d)\n" , - w, h, min_width, max_width, max_height); -return -EINVAL ; - } - -intel_add_fb_offsets (&x, &y, plane_state,0 ); - offset =intel_plane_compute_aligned_offset (&x, &y, plane_state,0 ); - alignment =intel_surf_alignment (fb,0 ); +intel_add_fb_offsets (x, y, plane_state,0 ); + *offset =intel_plane_compute_aligned_offset (x, y, plane_state,0 );if (drm_WARN_ON (&dev_priv->drm, alignment && !is_power_of_2 (alignment)))return -EINVAL ;
@@ -3856,9 +3842,10 @@ static int skl_check_main_surface(struct intel_plane_state *plane_state)* main surface offset, and it must be non-negative. Make * sure that is what we will get. */ -if (aux_plane && offset > aux_offset) - offset =intel_plane_adjust_aligned_offset (&x, &y, plane_state,0 , - offset, aux_offset & ~(alignment -1 )); +if (aux_plane && *offset > aux_offset) + *offset =intel_plane_adjust_aligned_offset (x, y, plane_state,0 , + *offset, + aux_offset & ~(alignment -1 ));/* * When using an X-tiled surface, the plane blows up
@@ -3869,18 +3856,51 @@ static int skl_check_main_surface(struct intel_plane_state *plane_state)if (fb->modifier ==I915_FORMAT_MOD_X_TILED ) {int cpp = fb->format->cpp[0 ]; -while ((x + w) * cpp > plane_state->color_plane[0 ].stride) { -if (offset ==0 ) { +while ((*x + w) * cpp > plane_state->color_plane[0 ].stride) { +if (*offset ==0 ) {drm_dbg_kms (&dev_priv->drm,"Unable to find suitable display surface offset due to X-tiling\n" );return -EINVAL ; } - offset =intel_plane_adjust_aligned_offset (&x, &y, plane_state,0 , - offset, offset - alignment); + *offset =intel_plane_adjust_aligned_offset (x, y, plane_state,0 , + *offset, + *offset - alignment); } } +return 0 ; +} + +static int skl_check_main_surface (struct intel_plane_state *plane_state) +{ +struct intel_plane *plane =to_intel_plane (plane_state->uapi.plane); +struct drm_i915_private *dev_priv =to_i915 (plane->base.dev); +const struct drm_framebuffer *fb = plane_state->hw.fb; +const unsigned int rotation = plane_state->hw.rotation; +int x = plane_state->uapi.src.x1 >>16 ; +int y = plane_state->uapi.src.y1 >>16 ; +const int w =drm_rect_width (&plane_state->uapi.src) >>16 ; +const int h =drm_rect_height (&plane_state->uapi.src) >>16 ; +const int min_width =intel_plane_min_width (plane, fb,0 , rotation); +const int max_width =intel_plane_max_width (plane, fb,0 , rotation); +const int max_height =intel_plane_max_height (plane, fb,0 , rotation); +const int aux_plane =intel_main_to_aux_plane (fb,0 ); +const u32 alignment =intel_surf_alignment (fb,0 ); +u32 offset; +int ret; + +if (w > max_width || w < min_width || h > max_height) { +drm_dbg_kms (&dev_priv->drm, +"requested Y/RGB source size %dx%d outside limits (min: %dx1 max: %dx%d)\n" , + w, h, min_width, max_width, max_height); +return -EINVAL ; + } + + ret =skl_calc_main_surface_offset (plane_state, &x, &y, &offset); +if (ret) +return ret; +/* * CCS AUX surface doesn't have its own x/y offsets, we must make sure * they match with the main surface x/y offsets.
drivers/gpu/drm/i915/display/intel_display.h +2 -0
@@ -630,6 +630,8 @@ u32 skl_plane_ctl_crtc(const struct intel_crtc_state *crtc_state);u32 skl_plane_stride (const struct intel_plane_state *plane_state,int plane);int skl_check_plane_surface (struct intel_plane_state *plane_state); +int skl_calc_main_surface_offset (const struct intel_plane_state *plane_state, +int *x,int *y,u32 *offset);int i9xx_check_plane_surface (struct intel_plane_state *plane_state);int skl_format_to_fourcc (int format,bool rgb_order,bool alpha); unsigned int i9xx_plane_max_stride(struct intel_plane *plane,
Signature · 6 lines
2.29.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 5/6 drm/i915/display/psr: Program plane's calculated offset to plane SF register
In reply to José Roberto de SouzaIt programs Plane's calculated x, y, offset to Plane SF register. It does the calculation of x and y offsets using skl_calc_main_surface_offset().
v3: Update commit message
--- drivers/gpu/drm/i915/display/intel_psr.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/display/intel_psr.c +10 -4
@@ -1186,7 +1186,8 @@ void intel_psr2_program_plane_sel_fetch(struct intel_plane *plane,struct drm_i915_private *dev_priv =to_i915 (plane->base.dev);enum pipe pipe = plane->pipe;const struct drm_rect *clip; -u32 val; +u32 val, offset; +int ret, x, y;if (!crtc_state->enable_psr2_sel_fetch)return ;
@@ -1203,9 +1204,14 @@ void intel_psr2_program_plane_sel_fetch(struct intel_plane *plane, val |= plane_state->uapi.dst.x1;intel_de_write_fw (dev_priv,PLANE_SEL_FETCH_POS (pipe, plane->id), val); -/* TODO: consider tiling and auxiliary surfaces */ - val = (clip->y1 + plane_state->color_plane[color_plane].y) <<16 ; - val |= plane_state->color_plane[color_plane].x; +/* TODO: consider auxiliary surfaces */ + x = plane_state->uapi.src.x1 >>16 ; + y = (plane_state->uapi.src.y1 >>16 ) + clip->y1; + ret =skl_calc_main_surface_offset (plane_state, &x, &y, &offset); +if (ret) +drm_warn_once (&dev_priv->drm,"skl_calc_main_surface_offset() returned %i\n" , + ret); + val = y <<16 | x;intel_de_write_fw (dev_priv,PLANE_SEL_FETCH_OFFSET (pipe, plane->id), val);
Signature · 6 lines
2.29.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 6/6 HAX/DO_NOT_MERGE_IT: drm/i915/display: Enable PSR2 selective fetch for testing
In reply to José Roberto de SouzaEnabling it to check if it causes regressions in CI but the feature is still not ready to be enabled by default.
--- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_params.h +1 -1
@@ -54,7 +54,7 @@ struct drm_printer; param(int, enable_fbc, -1, 0600) \ param(int, enable_psr, -1, 0600) \ param(bool, psr_safest_params, false, 0600) \ - param(bool, enable_psr2_sel_fetch, false, 0600) \ + param(bool, enable_psr2_sel_fetch, true, 0600) \ param(int, disable_power_well, -1, 0400) \ param(int, enable_ips, 1, 0600) \param (int, invert_brightness,0 ,0600 ) \
Signature · 6 lines
2.29.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v5,1/6] drm/damage_helper: Check if damage clips has valid values
In reply to José Roberto de Souza== Series Details ==
== Series Details ==
Series: series starting with [v5,1/6] drm/damage_helper: Check if damage clips has valid values
URL : https://patchwork.freedesktop.org/series/84874/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +drivers/gpu/drm/i915/intel_wakeref.c:137:19: warning: context imbalance in 'wakeref_auto_timeout' - unexpected unlock +drivers/gpu/drm/selftests/test-drm_damage_helper.c:244:25: warning: Using plain integer as NULL pointer +drivers/gpu/drm/selftests/test-drm_damage_helper.c:268:23: warning: Using plain integer as NULL pointer
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [v5,1/6] drm/damage_helper: Check if damage clips has valid values
In reply to José Roberto de Souza== Series Details ==
== Series Details ==
Series: series starting with [v5,1/6] drm/damage_helper: Check if damage clips has valid values
URL : https://patchwork.freedesktop.org/series/84874/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915 Error: Cannot open file ./drivers/gpu/drm/i915/gt/intel_lrc.c WARNING: kernel-doc './scripts/kernel-doc -rst -enable-lineno -sphinx-version 1.7.9 -function Logical Rings, Logical Ring Contexts and Execlists ./drivers/gpu/drm/i915/gt/intel_lrc.c' failed with return code 1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v5,1/6] drm/damage_helper: Check if damage clips has valid values
In reply to José Roberto de Souza== Series Details ==
== Series Details ==
Series: series starting with [v5,1/6] drm/damage_helper: Check if damage clips has valid values
URL : https://patchwork.freedesktop.org/series/84874/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9478 -> Patchwork_19130
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/index.html
Changes
-------
No changes found
Participating hosts (42 -> 33)
------------------------------
Missing (9): fi-bxt-dsi fi-bdw-samus fi-tgl-u2 fi-bsw-n3050 fi-skl-guc fi-hsw-4200u fi-blb-e6850 fi-tgl-y fi-skl-6700k2
Build changes
-------------
* Linux: CI_DRM_9478 -> Patchwork_19130
CI-20190529: 20190529
CI_DRM_9478: 94cf3a4cc350324f21728c70954c46e535405c87 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5890: 0e209dc3cd7561a57ec45be74b8b299eaf391950 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19130: af66f7ce909e50ccda4b3751a3b1619e4836c473 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
af66f7ce909e HAX/DO_NOT_MERGE_IT: drm/i915/display: Enable PSR2 selective fetch for testing 00461c41ab57 drm/i915/display/psr: Program plane's calculated offset to plane SF register ad158b219b69 drm/i915/display: Split and export main surface calculation from skl_check_main_surface() b7fdc2e15cce drm/i915/display/psr: Use plane damage clips to calculate damaged area 55ba6d00f603 drm/i915/display: Check plane damage clipsa04301392942 drm/damage_helper: Check if damage clips has valid values
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v5,1/6] drm/damage_helper: Check if damage clips has valid values
In reply to José Roberto de Souza== Series Details ==
== Series Details ==
Series: series starting with [v5,1/6] drm/damage_helper: Check if damage clips has valid values
URL : https://patchwork.freedesktop.org/series/84874/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9478_full -> Patchwork_19130_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_19130_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_params@rsvd2-dirt:
- shard-iclb: NOTRUN -> [SKIP][1] ([fdo#109283])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@[email protected]
* igt@gem_exec_reloc@basic-wide-active@rcs0:
- shard-iclb: NOTRUN -> [FAIL][2] ([i915#2389]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@gem_exec_reloc@[email protected]
- shard-kbl: NOTRUN -> [FAIL][3] ([i915#2389]) +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-kbl4/igt@gem_exec_reloc@[email protected]
* igt@gem_render_copy@y-tiled-to-vebox-linear:
- shard-iclb: NOTRUN -> [SKIP][4] ([i915#768])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@[email protected]
* igt@gen9_exec_parse@batch-without-end:
- shard-iclb: NOTRUN -> [SKIP][5] ([fdo#112306])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][6] -> [FAIL][7] ([i915#454])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-iclb3/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@[email protected]
* igt@kms_big_fb@y-tiled-64bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][8] ([fdo#110725] / [fdo#111614])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@[email protected]
* igt@kms_big_fb@yf-tiled-8bpp-rotate-0:
- shard-iclb: NOTRUN -> [SKIP][9] ([fdo#110723])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@[email protected]
* igt@kms_chamelium@hdmi-frame-dump:
- shard-skl: NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#111827]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-skl9/igt@[email protected]
* igt@kms_color_chamelium@pipe-a-ctm-max:
- shard-iclb: NOTRUN -> [SKIP][11] ([fdo#109284] / [fdo#111827]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@[email protected]
* igt@kms_color_chamelium@pipe-d-ctm-max:
- shard-kbl: NOTRUN -> [SKIP][12] ([fdo#109271] / [fdo#111827]) +6 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-kbl4/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][13] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@[email protected]
* igt@kms_content_protection@legacy:
- shard-iclb: NOTRUN -> [SKIP][14] ([fdo#109300] / [fdo#111066])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@[email protected]
* igt@kms_content_protection@uevent:
- shard-kbl: NOTRUN -> [FAIL][15] ([i915#2105])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-kbl4/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-skl: [PASS][16] -> [INCOMPLETE][17] ([i915#2295] / [i915#300])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-skl5/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-skl10/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-512x512-onscreen:
- shard-iclb: NOTRUN -> [SKIP][18] ([fdo#109278] / [fdo#109279]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-64x64-offscreen:
- shard-skl: [PASS][19] -> [FAIL][20] ([i915#54]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-skl10/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-skl4/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-128x42-sliding:
- shard-skl: NOTRUN -> [FAIL][21] ([i915#54]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-skl2/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-128x128-sliding:
- shard-iclb: NOTRUN -> [SKIP][22] ([fdo#109278]) +6 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-snb: [PASS][23] -> [SKIP][24] ([fdo#109271])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-snb4/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-snb6/igt@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
- shard-hsw: [PASS][25] -> [FAIL][26] ([i915#2370])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-hsw1/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
* igt@kms_flip@2x-plain-flip:
- shard-iclb: NOTRUN -> [SKIP][27] ([fdo#109274])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2:
- shard-glk: [PASS][28] -> [FAIL][29] ([i915#79])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-glk1/igt@kms_flip@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-glk7/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate@b-edp1:
- shard-skl: [PASS][30] -> [FAIL][31] ([i915#2122])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-skl10/igt@kms_flip@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-skl4/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-kbl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#2672])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-kbl4/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
- shard-iclb: NOTRUN -> [SKIP][33] ([i915#2587])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile:
- shard-skl: NOTRUN -> [FAIL][34] ([i915#2628])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-skl2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw:
- shard-iclb: NOTRUN -> [SKIP][35] ([fdo#109280]) +9 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt:
- shard-skl: NOTRUN -> [SKIP][36] ([fdo#109271]) +42 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-skl1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-iclb: [PASS][37] -> [INCOMPLETE][38] ([i915#1185] / [i915#123])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-iclb4/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb3/igt@[email protected]
* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][39] -> [FAIL][40] ([i915#1188])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-skl7/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-skl8/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-kbl: NOTRUN -> [FAIL][41] ([fdo#108145] / [i915#265]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-kbl4/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: NOTRUN -> [FAIL][42] ([fdo#108145] / [i915#265]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-skl2/igt@[email protected]
* igt@kms_plane_multiple@atomic-pipe-d-tiling-x:
- shard-kbl: NOTRUN -> [SKIP][43] ([fdo#109271]) +68 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-kbl4/igt@[email protected]
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][44] -> [SKIP][45] ([fdo#109441]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@kms_psr@psr2_cursor_render.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#109441])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-kbl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#533]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-kbl4/igt@[email protected]
* igt@kms_writeback@writeback-fb-id:
- shard-kbl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#2437])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-kbl4/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][49] ([i915#2437])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@[email protected]
* igt@nouveau_crc@pipe-c-ctx-flip-skip-current-frame:
- shard-iclb: NOTRUN -> [SKIP][50] ([i915#2530])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@[email protected]
* igt@perf_pmu@event-wait@rcs0:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#112283])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@perf_pmu@[email protected]
* igt@prime_nv_test@nv_i915_sharing:
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109291])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@prime_nv_test@nv_i915_sharing.html
* igt@prime_vgem@coherency-gtt:
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109292])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_whisper@basic-contexts-forked:
- shard-glk: [DMESG-WARN][54] ([i915#118] / [i915#95]) -> [PASS][55] +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-glk4/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-glk2/igt@[email protected]
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [FAIL][56] ([i915#644]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-glk5/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-glk3/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen:
- shard-skl: [FAIL][58] ([i915#54]) -> [PASS][59] +4 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-skl9/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-skl1/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [FAIL][60] ([i915#2346] / [i915#533]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [DMESG-WARN][62] ([i915#180]) -> [PASS][63] +3 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-kbl1/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-kbl4/igt@[email protected]
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][64] ([fdo#109441]) -> [PASS][65] +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-iclb1/igt@kms_psr@psr2_no_drrs.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][66] ([i915#658]) -> [SKIP][67] ([i915#588])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-iclb1/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb2/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][68] ([i915#2684]) -> [WARN][69] ([i915#1804] / [i915#2684])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-iclb5/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb7/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: ([FAIL][70], [FAIL][71], [FAIL][72], [FAIL][73]) ([i915#1814] / [i915#2295] / [i915#2722] / [i915#483]) -> [FAIL][74] ([i915#2295] / [i915#2722] / [i915#483])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-kbl7/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-kbl3/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-kbl1/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-kbl4/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-kbl2/igt@[email protected]
- shard-iclb: ([FAIL][75], [FAIL][76]) ([i915#1569] / [i915#2295] / [i915#2722] / [i915#2724]) -> [FAIL][77] ([i915#2295] / [i915#2722] / [i915#2724] / [i915#483])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-iclb2/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-iclb2/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-iclb8/igt@[email protected]
- shard-glk: [FAIL][78] ([i915#2295] / [i915#2722] / [k.org#202321]) -> [FAIL][79] ([i915#2295] / [i915#2722] / [i915#483] / [k.org#202321])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-glk9/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-glk3/igt@[email protected]
- shard-skl: ([FAIL][80], [FAIL][81]) ([i915#1814] / [i915#2029] / [i915#2295] / [i915#2722] / [i915#483]) -> [FAIL][82] ([i915#2295] / [i915#2722])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-skl3/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9478/shard-skl5/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/shard-skl2/igt@[email protected]
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109292]: https://bugs.freedesktop.org/show_bug.cgi?id=109292
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi?id=111066
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[fdo#112306]: https://bugs.freedesktop.org/show_bug.cgi?id=112306
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#1569]: https://gitlab.freedesktop.org/drm/intel/issues/1569
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2105]: https://gitlab.freedesktop.org/drm/intel/issues/2105
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2370]: https://gitlab.freedesktop.org/drm/intel/issues/2370
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2628]: https://gitlab.freedesktop.org/drm/intel/issues/2628
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2724]: https://gitlab.freedesktop.org/drm/intel/issues/2724
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9478 -> Patchwork_19130
CI-20190529: 20190529
CI_DRM_9478: 94cf3a4cc350324f21728c70954c46e535405c87 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5890: 0e209dc3cd7561a57ec45be74b8b299eaf391950 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19130: af66f7ce909e50ccda4b3751a3b1619e4836c473 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19130/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 9 lines
Userspace can set a damage clip with a negative coordinate, negative width or height or larger than the plane.
This invalid values could cause issues in some HW or even worst enable security flaws.v2:
- add debug messages to let userspace know why atomic commit failed due invalid damage clips
Quoted 7 lines
Cc Simon Ser <[email protected]>Cc Gwan-gyeong Mun <[email protected]>Cc Sean Paul <[email protected]>Cc Fabio Estevam <[email protected]>Cc Deepak Rawat <[email protected]>Signed-off-by José Roberto de Souza <[email protected]>
After looking at the kernel code, it seems like the kernel already checks for all of that in drm_atomic_plane_check. Are you aware of this?
drivers/gpu/drm/drm_damage_helper.c void drm_plane_enable_fb_damage_clips(struct drm_plane *plane) · line 151
Quoted 2 lines
drivers/gpu/drm/drm_damage_helper.c +2
-0+ w =drm_rect_width (&plane_state->src) >>16 ; + h =drm_rect_height (&plane_state->src) >>16 ;
The docs say this should be in FB coordinates, not in SRC_* coordinates. So we shouldn't need to check any SRC_* prop here.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 23 lines · Simon Ser
Quoted 11 lines
Userspace can set a damage clip with a negative coordinate, negative
width or height or larger than the plane.
This invalid values could cause issues in some HW or even worst enable
security flaws.v2:
- add debug messages to let userspace know why atomic commit failed due invalid damage clipsQuoted 7 lines
Cc Simon Ser <[email protected]>Cc Gwan-gyeong Mun <[email protected]>Cc Sean Paul <[email protected]>Cc Fabio Estevam <[email protected]>Cc Deepak Rawat <[email protected]>Signed-off-by José Roberto de Souza <[email protected]>After looking at the kernel code, it seems like the kernel already checks for
all of that indrm_atomic_plane_check. Are you aware of this?
Quoted 7 lines
drivers/gpu/drm/drm_damage_helper.c void drm_plane_enable_fb_damage_clips(struct drm_plane *plane) · line 151
Quoted 2 lines
drivers/gpu/drm/drm_damage_helper.c +2
-0+ w =drm_rect_width (&plane_state->src) >>16 ; + h =drm_rect_height (&plane_state->src) >>16 ;The docs say this should be in FB coordinates, not in SRC_* coordinates. So we
shouldn't need to check any SRC_* prop here.
I agree the Simon's opinion. it does check between plane's frame buffer src geometry and damage clips. (Plane's damage clip might exist outside of fb src geometry.)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 31 lines · Gwan-gyeong
Quoted 23 lines · Simon Ser
Quoted 11 lines
Userspace can set a damage clip with a negative coordinate, negative
width or height or larger than the plane.
This invalid values could cause issues in some HW or even worst enable
security flaws.v2:
- add debug messages to let userspace know why atomic commit failed due invalid damage clipsQuoted 7 lines
Cc Simon Ser <[email protected]>Cc Gwan-gyeong Mun <[email protected]>Cc Sean Paul <[email protected]>Cc Fabio Estevam <[email protected]>Cc Deepak Rawat <[email protected]>Signed-off-by José Roberto de Souza <[email protected]>After looking at the kernel code, it seems like the kernel already checks for
all of that indrm_atomic_plane_check. Are you aware of this?Quoted 7 lines
drivers/gpu/drm/drm_damage_helper.c void drm_plane_enable_fb_damage_clips(struct drm_plane *plane) · line 151
Quoted 2 lines
drivers/gpu/drm/drm_damage_helper.c +2
-0+ w =drm_rect_width (&plane_state->src) >>16 ; + h =drm_rect_height (&plane_state->src) >>16 ;The docs say this should be in FB coordinates, not in SRC_* coordinates. So we
shouldn't need to check any SRC_* prop here.
Quoted 3 lines
I agree the Simon's opinion. it does check between plane's frame buffer src geometry and damage clips. (Plane's damage clip might exist outside of fb src geometry.)
Since this is causing confusion, please make sure that the igt for damage clips validates this correctly. I think some of the igts that vmwgfx people have created have still not yet landed, so we definitely want to land these.
Note that basic damage clips tests should be fully generic, i.e. not tied to anything driver specific like our psr testcases are. -Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx