drm/i915: Update Gen11 forcewake ranges
Subsystems (2)
PATCH 1/3 drm/i915: Update Gen11 forcewake ranges
Daniele noticed new render ranges in Gen11 fw table.
Bspec: 18331
--- drivers/gpu/drm/i915/intel_uncore.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-)
drivers/gpu/drm/i915/intel_uncore.c +9 -14
@@ -805,9 +805,6 @@ void assert_forcewakes_active(struct intel_uncore *uncore,/* We give fast paths for the really cool registers */ #define NEEDS_FORCE_WAKE (reg) ((reg) < 0x40000) -#define GEN11_NEEDS_FORCE_WAKE (reg) \ - ((reg) < 0x40000 || ((reg) >= 0x1c0000 && (reg) < 0x1dc000)) -#define __gen6_reg_read_fw_domains (uncore, offset) \ ({ \ enum forcewake_domains __fwd; \
@@ -903,12 +900,7 @@ static const struct intel_forcewake_range __vlv_fw_ranges[] = { })#define __gen11_fwtable_reg_read_fw_domains (uncore, offset) \ -({ \ - enum forcewake_domains __fwd = 0; \ - if (GEN11_NEEDS_FORCE_WAKE((offset))) \ - __fwd = find_fw_domain(uncore, offset); \ - __fwd; \ -}) + find_fw_domain(uncore, offset)/* *Must* be sorted by offset! See intel_shadow_table_check(). */ static const i915_reg_t gen8_shadowed_regs[] = {
@@ -1005,8 +997,9 @@ static const struct intel_forcewake_range __chv_fw_ranges[] = {#define __gen11_fwtable_reg_write_fw_domains (uncore, offset) \ ({ \ enum forcewake_domains __fwd = 0; \ - if (GEN11_NEEDS_FORCE_WAKE((offset)) && !is_gen11_shadowed(offset)) \ - __fwd = find_fw_domain(uncore, offset); \ + const u32 __offset = (offset); \ + if (!is_gen11_shadowed(__offset)) \ + __fwd = find_fw_domain(uncore, __offset); \ __fwd; \ })
@@ -1065,9 +1058,11 @@ static const struct intel_forcewake_range __gen11_fw_ranges[] = {GEN_FW_RANGE (0x9400 ,0x97ff ,FORCEWAKE_ALL ),GEN_FW_RANGE (0x9800 ,0xafff ,FORCEWAKE_BLITTER ),GEN_FW_RANGE (0xb000 ,0xb47f ,FORCEWAKE_RENDER ), -GEN_FW_RANGE (0xb480 ,0xdfff ,FORCEWAKE_BLITTER ), -GEN_FW_RANGE (0xe000 ,0xe8ff ,FORCEWAKE_RENDER ), -GEN_FW_RANGE (0xe900 ,0x243ff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0xb480 ,0xdeff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0xdf00 ,0xe8ff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0xe900 ,0x16dff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x16e00 ,0x19fff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x1a000 ,0x243ff ,FORCEWAKE_BLITTER ),GEN_FW_RANGE (0x24400 ,0x247ff ,FORCEWAKE_RENDER ),GEN_FW_RANGE (0x24800 ,0x3ffff ,FORCEWAKE_BLITTER ), GEN_FW_RANGE(0x40000, 0x1bffff, 0),
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/3 drm/i915/tgl: Introduce gen12 forcewake ranges
From: Michel Thierry <[email protected]>
The media ranges extend beyond what gen11 gives so we can't piggypack on gen11 ranges, even on read side.
Introduce a table for gen12 and accessors for it.
v2: correctly implement gen12_fwtable_write/read (Daniele)
v3: update with ranges from bspec.
v4: avoid GEN11_NEEDS_FORCEWAKE (Mika)
v5: bspec ref (Daniele)
BSpec: 52078
--- drivers/gpu/drm/i915/intel_uncore.c | 75 ++++++++++++++++++- drivers/gpu/drm/i915/selftests/intel_uncore.c | 2 + 2 files changed, 76 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_uncore.c +74 -1
@@ -902,6 +902,9 @@ static const struct intel_forcewake_range __vlv_fw_ranges[] = {#define __gen11_fwtable_reg_read_fw_domains (uncore, offset) \ find_fw_domain(uncore, offset) +#define __gen12_fwtable_reg_read_fw_domains (uncore, offset) \ + find_fw_domain(uncore, offset) +/* *Must* be sorted by offset! See intel_shadow_table_check(). */ static const i915_reg_t gen8_shadowed_regs[] = {RING_TAIL (RENDER_RING_BASE ),/* 0x2000 (base) */
@@ -927,6 +930,20 @@ static const i915_reg_t gen11_shadowed_regs[] = {/* TODO: Other registers are not yet used */ }; +static const i915_reg_t gen12_shadowed_regs[] = { +RING_TAIL (RENDER_RING_BASE ),/* 0x2000 (base) */ +GEN6_RPNSWREQ ,/* 0xA008 */ +GEN6_RC_VIDEO_FREQ ,/* 0xA00C */ +RING_TAIL (BLT_RING_BASE ),/* 0x22000 (base) */ +RING_TAIL (GEN11_BSD_RING_BASE ),/* 0x1C0000 (base) */ +RING_TAIL (GEN11_BSD2_RING_BASE ),/* 0x1C4000 (base) */ +RING_TAIL (GEN11_VEBOX_RING_BASE ),/* 0x1C8000 (base) */ +RING_TAIL (GEN11_BSD3_RING_BASE ),/* 0x1D0000 (base) */ +RING_TAIL (GEN11_BSD4_RING_BASE ),/* 0x1D4000 (base) */ +RING_TAIL (GEN11_VEBOX2_RING_BASE ),/* 0x1D8000 (base) */ +/* TODO: Other registers are not yet used */ +}; +static int mmio_reg_cmp (u32 key,const i915_reg_t *reg) {u32 offset =i915_mmio_reg_offset (*reg);
@@ -949,6 +966,7 @@ static bool is_gen##x##_shadowed(u32 offset) \ __is_genX_shadowed(8) __is_genX_shadowed(11) +__is_genX_shadowed(12)static enum forcewake_domains gen6_reg_write_fw_domains (struct intel_uncore *uncore,i915_reg_t reg)
@@ -1003,6 +1021,15 @@ static const struct intel_forcewake_range __chv_fw_ranges[] = { __fwd; \ }) +#define __gen12_fwtable_reg_write_fw_domains (uncore, offset) \ +({ \ + enum forcewake_domains __fwd = 0; \ + const u32 __offset = (offset); \ + if (!is_gen12_shadowed(__offset)) \ + __fwd = find_fw_domain(uncore, __offset); \ + __fwd; \ +}) +/* *Must* be sorted by offset ranges! See intel_fw_table_check(). */ static const struct intel_forcewake_range __gen9_fw_ranges[] = {GEN_FW_RANGE (0x0 ,0xaff ,FORCEWAKE_BLITTER ),
@@ -1075,6 +1102,46 @@ static const struct intel_forcewake_range __gen11_fw_ranges[] = {GEN_FW_RANGE (0x1d8000 ,0x1dbfff ,FORCEWAKE_MEDIA_VEBOX1 ) }; +/* *Must* be sorted by offset ranges! See intel_fw_table_check(). */ +static const struct intel_forcewake_range __gen12_fw_ranges[] = { +GEN_FW_RANGE (0x0 ,0xaff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0xb00 ,0x1fff ,0 ),/* uncore range */ +GEN_FW_RANGE (0x2000 ,0x26ff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x2700 ,0x2fff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x3000 ,0x3fff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x4000 ,0x51ff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x5200 ,0x7fff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x8000 ,0x813f ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x8140 ,0x815f ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x8160 ,0x82ff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x8300 ,0x84ff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x8500 ,0x8bff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x8c00 ,0x8cff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x8d00 ,0x93ff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x9400 ,0x97ff ,FORCEWAKE_ALL ), +GEN_FW_RANGE (0x9800 ,0xafff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0xb000 ,0xb47f ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0xb480 ,0xdfff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0xe000 ,0xe8ff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0xe900 ,0x147ff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x14800 ,0x148ff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x14900 ,0x19fff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x1a000 ,0x1a7ff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x1a800 ,0x1afff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x1b000 ,0x1bfff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x1c000 ,0x243ff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x24400 ,0x247ff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x24800 ,0x3ffff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x40000 ,0x1bffff ,0 ), +GEN_FW_RANGE (0x1c0000 ,0x1c3fff ,FORCEWAKE_MEDIA_VDBOX0 ), +GEN_FW_RANGE (0x1c4000 ,0x1c7fff ,FORCEWAKE_MEDIA_VDBOX1 ), +GEN_FW_RANGE (0x1c8000 ,0x1cbfff ,FORCEWAKE_MEDIA_VEBOX0 ), +GEN_FW_RANGE (0x1cc000 ,0x1cffff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x1d0000 ,0x1d3fff ,FORCEWAKE_MEDIA_VDBOX2 ), +GEN_FW_RANGE (0x1d4000 ,0x1d7fff ,FORCEWAKE_MEDIA_VDBOX3 ), +GEN_FW_RANGE (0x1d8000 ,0x1dbfff ,FORCEWAKE_MEDIA_VEBOX1 ) +}; +static void ilk_dummy_write (struct intel_uncore *uncore) {
@@ -1223,6 +1290,7 @@ __gen_read(func, 16) \ __gen_read(func, 32) \ __gen_read(func, 64) +__gen_reg_read_funcs (gen12_fwtable);__gen_reg_read_funcs (gen11_fwtable);__gen_reg_read_funcs (fwtable);__gen_reg_read_funcs (gen6);
@@ -1314,6 +1382,7 @@ __gen_write(func, 8) \ __gen_write(func, 16) \ __gen_write(func, 32) +__gen_reg_write_funcs (gen12_fwtable);__gen_reg_write_funcs (gen11_fwtable);__gen_reg_write_funcs (fwtable);__gen_reg_write_funcs (gen8);
@@ -1685,10 +1754,14 @@ static int uncore_forcewake_init(struct intel_uncore *uncore)ASSIGN_FW_DOMAINS_TABLE (uncore, __gen9_fw_ranges);ASSIGN_WRITE_MMIO_VFUNCS (uncore, fwtable);ASSIGN_READ_MMIO_VFUNCS (uncore, fwtable); - }else { + }else if (IS_GEN (i915,11 )) {ASSIGN_FW_DOMAINS_TABLE (uncore, __gen11_fw_ranges);ASSIGN_WRITE_MMIO_VFUNCS (uncore, gen11_fwtable);ASSIGN_READ_MMIO_VFUNCS (uncore, gen11_fwtable); + }else { +ASSIGN_FW_DOMAINS_TABLE (uncore, __gen12_fw_ranges); +ASSIGN_WRITE_MMIO_VFUNCS (uncore, gen12_fwtable); +ASSIGN_READ_MMIO_VFUNCS (uncore, gen12_fwtable); } uncore->pmic_bus_access_nb.notifier_call = i915_pmic_bus_access_notifier;
drivers/gpu/drm/i915/selftests/intel_uncore.c +2 -0
@@ -67,6 +67,7 @@ static int intel_shadow_table_check(void) } reg_lists[] = { { gen8_shadowed_regs, ARRAY_SIZE(gen8_shadowed_regs) }, { gen11_shadowed_regs, ARRAY_SIZE(gen11_shadowed_regs) }, + { gen12_shadowed_regs, ARRAY_SIZE(gen12_shadowed_regs) }, }; const i915_reg_t *reg; unsigned int i, j;
@@ -101,6 +102,7 @@ int intel_uncore_mock_selftests(void) { __chv_fw_ranges, ARRAY_SIZE(__chv_fw_ranges), false }, { __gen9_fw_ranges, ARRAY_SIZE(__gen9_fw_ranges), true }, { __gen11_fw_ranges, ARRAY_SIZE(__gen11_fw_ranges), true }, + { __gen12_fw_ranges, ARRAY_SIZE(__gen12_fw_ranges), true }, };int err, i;
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 2/3] drm/i915/tgl: Introduce gen12 forcewake ranges
Quoted 27 lines · Mika Kuoppala
From: Michel Thierry <[email protected]>
The media ranges extend beyond what gen11 gives so we can't piggypack on gen11 ranges, even on read side.
Introduce a table for gen12 and accessors for it.
v2: correctly implement gen12_fwtable_write/read (Daniele)
v3: update with ranges from bspec.
v4: avoidGEN11_NEEDS_FORCEWAKE(Mika)
v5: bspec ref (Daniele)BSpec: 52078
Cc Tvrtko Ursulin <[email protected]>Cc Daniele Ceraolo Spurio <[email protected]>Signed-off-by Michel Thierry <[email protected]>Signed-off-by Mika Kuoppala <[email protected]>--- drivers/gpu/drm/i915/intel_uncore.c | 75 ++++++++++++++++++- drivers/gpu/drm/i915/selftests/intel_uncore.c | 2 + 2 files changed, 76 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/intel_uncore.c +0
-0
drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __vlv_fw_ranges[] = { · line 906
Quoted 5 lines
drivers/gpu/drm/i915/intel_uncore.c +2
-0@@ -902,6 +902,9 @@ static const struct intel_forcewake_range __vlv_fw_ranges[] = {#define __gen11_fwtable_reg_read_fw_domains (uncore, offset) \ find_fw_domain(uncore, offset) +#define __gen12_fwtable_reg_read_fw_domains (uncore, offset) \ + find_fw_domain(uncore, offset)
The gen12 read path is now the same as the gen11 one so we could skip this, but I agree it looks nice having symmetrical read/write functions so I'm ok with keeping it. The table matches the specs, so:
Daniele
Quoted 142 lines
drivers/gpu/drm/i915/intel_uncore.c +72
-1+/* *Must* be sorted by offset! See intel_shadow_table_check(). */ static const i915_reg_t gen8_shadowed_regs[] = {RING_TAIL (RENDER_RING_BASE ),/* 0x2000 (base) */ @@ -927,6 +930,20 @@ static const i915_reg_t gen11_shadowed_regs[] = {/* TODO: Other registers are not yet used */ }; +static const i915_reg_t gen12_shadowed_regs[] = { +RING_TAIL (RENDER_RING_BASE ),/* 0x2000 (base) */ +GEN6_RPNSWREQ ,/* 0xA008 */ +GEN6_RC_VIDEO_FREQ ,/* 0xA00C */ +RING_TAIL (BLT_RING_BASE ),/* 0x22000 (base) */ +RING_TAIL (GEN11_BSD_RING_BASE ),/* 0x1C0000 (base) */ +RING_TAIL (GEN11_BSD2_RING_BASE ),/* 0x1C4000 (base) */ +RING_TAIL (GEN11_VEBOX_RING_BASE ),/* 0x1C8000 (base) */ +RING_TAIL (GEN11_BSD3_RING_BASE ),/* 0x1D0000 (base) */ +RING_TAIL (GEN11_BSD4_RING_BASE ),/* 0x1D4000 (base) */ +RING_TAIL (GEN11_VEBOX2_RING_BASE ),/* 0x1D8000 (base) */ +/* TODO: Other registers are not yet used */ +}; +static int mmio_reg_cmp (u32 key,const i915_reg_t *reg) {u32 offset =i915_mmio_reg_offset (*reg);@@ -949,6 +966,7 @@ static bool is_gen##x##_shadowed(u32 offset) \ __is_genX_shadowed(8) __is_genX_shadowed(11) +__is_genX_shadowed(12)static enum forcewake_domains gen6_reg_write_fw_domains (struct intel_uncore *uncore,i915_reg_t reg)@@ -1003,6 +1021,15 @@ static const struct intel_forcewake_range __chv_fw_ranges[] = { __fwd; \ }) +#define __gen12_fwtable_reg_write_fw_domains (uncore, offset) \ +({ \ + enum forcewake_domains __fwd = 0; \ + const u32 __offset = (offset); \ + if (!is_gen12_shadowed(__offset)) \ + __fwd = find_fw_domain(uncore, __offset); \ + __fwd; \ +}) +/* *Must* be sorted by offset ranges! See intel_fw_table_check(). */ static const struct intel_forcewake_range __gen9_fw_ranges[] = {GEN_FW_RANGE (0x0 ,0xaff ,FORCEWAKE_BLITTER ),@@ -1075,6 +1102,46 @@ static const struct intel_forcewake_range __gen11_fw_ranges[] = {GEN_FW_RANGE (0x1d8000 ,0x1dbfff ,FORCEWAKE_MEDIA_VEBOX1 ) }; +/* *Must* be sorted by offset ranges! See intel_fw_table_check(). */ +static const struct intel_forcewake_range __gen12_fw_ranges[] = { +GEN_FW_RANGE (0x0 ,0xaff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0xb00 ,0x1fff ,0 ),/* uncore range */ +GEN_FW_RANGE (0x2000 ,0x26ff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x2700 ,0x2fff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x3000 ,0x3fff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x4000 ,0x51ff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x5200 ,0x7fff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x8000 ,0x813f ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x8140 ,0x815f ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x8160 ,0x82ff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x8300 ,0x84ff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x8500 ,0x8bff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x8c00 ,0x8cff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x8d00 ,0x93ff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x9400 ,0x97ff ,FORCEWAKE_ALL ), +GEN_FW_RANGE (0x9800 ,0xafff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0xb000 ,0xb47f ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0xb480 ,0xdfff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0xe000 ,0xe8ff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0xe900 ,0x147ff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x14800 ,0x148ff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x14900 ,0x19fff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x1a000 ,0x1a7ff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x1a800 ,0x1afff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x1b000 ,0x1bfff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x1c000 ,0x243ff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x24400 ,0x247ff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x24800 ,0x3ffff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x40000 ,0x1bffff ,0 ), +GEN_FW_RANGE (0x1c0000 ,0x1c3fff ,FORCEWAKE_MEDIA_VDBOX0 ), +GEN_FW_RANGE (0x1c4000 ,0x1c7fff ,FORCEWAKE_MEDIA_VDBOX1 ), +GEN_FW_RANGE (0x1c8000 ,0x1cbfff ,FORCEWAKE_MEDIA_VEBOX0 ), +GEN_FW_RANGE (0x1cc000 ,0x1cffff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x1d0000 ,0x1d3fff ,FORCEWAKE_MEDIA_VDBOX2 ), +GEN_FW_RANGE (0x1d4000 ,0x1d7fff ,FORCEWAKE_MEDIA_VDBOX3 ), +GEN_FW_RANGE (0x1d8000 ,0x1dbfff ,FORCEWAKE_MEDIA_VEBOX1 ) +}; +static void ilk_dummy_write (struct intel_uncore *uncore) {@@ -1223,6 +1290,7 @@ __gen_read(func, 16) \ __gen_read(func, 32) \ __gen_read(func, 64) +__gen_reg_read_funcs (gen12_fwtable);__gen_reg_read_funcs (gen11_fwtable);__gen_reg_read_funcs (fwtable);__gen_reg_read_funcs (gen6);@@ -1314,6 +1382,7 @@ __gen_write(func, 8) \ __gen_write(func, 16) \ __gen_write(func, 32) +__gen_reg_write_funcs (gen12_fwtable);__gen_reg_write_funcs (gen11_fwtable);__gen_reg_write_funcs (fwtable);__gen_reg_write_funcs (gen8);@@ -1685,10 +1754,14 @@ static int uncore_forcewake_init(struct intel_uncore *uncore)ASSIGN_FW_DOMAINS_TABLE (uncore, __gen9_fw_ranges);ASSIGN_WRITE_MMIO_VFUNCS (uncore, fwtable);ASSIGN_READ_MMIO_VFUNCS (uncore, fwtable); - }else { + }else if (IS_GEN (i915,11 )) {ASSIGN_FW_DOMAINS_TABLE (uncore, __gen11_fw_ranges);ASSIGN_WRITE_MMIO_VFUNCS (uncore, gen11_fwtable);ASSIGN_READ_MMIO_VFUNCS (uncore, gen11_fwtable); + }else { +ASSIGN_FW_DOMAINS_TABLE (uncore, __gen12_fw_ranges); +ASSIGN_WRITE_MMIO_VFUNCS (uncore, gen12_fwtable); +ASSIGN_READ_MMIO_VFUNCS (uncore, gen12_fwtable); } uncore->pmic_bus_access_nb.notifier_call = i915_pmic_bus_access_notifier;drivers/gpu/drm/i915/selftests/intel_uncore.c +1
-0@@ -67,6 +67,7 @@ static int intel_shadow_table_check(void) } reg_lists[] = { { gen8_shadowed_regs, ARRAY_SIZE(gen8_shadowed_regs) }, { gen11_shadowed_regs, ARRAY_SIZE(gen11_shadowed_regs) }, + { gen12_shadowed_regs, ARRAY_SIZE(gen12_shadowed_regs) }, }; const i915_reg_t *reg; unsigned int i, j;
drivers/gpu/drm/i915/selftests/intel_uncore.c int intel_uncore_mock_selftests(void) · line 108
Quoted 7 lines
drivers/gpu/drm/i915/selftests/intel_uncore.c +1
-0@@ -101,6 +102,7 @@ int intel_uncore_mock_selftests(void) { __chv_fw_ranges, ARRAY_SIZE(__chv_fw_ranges), false }, { __gen9_fw_ranges, ARRAY_SIZE(__gen9_fw_ranges), true }, { __gen11_fw_ranges, ARRAY_SIZE(__gen11_fw_ranges), true }, + { __gen12_fw_ranges, ARRAY_SIZE(__gen12_fw_ranges), true }, };int err, i;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/3 drm/i915: Check that we do find forcewake domain on gen11+
In reply to Mika KuoppalaBy always requiring a valid forcewake domain, even FORCEWAKE_NONE, we can make assertions that accesses need to land on a valid domain and not go out of bounds.
--- drivers/gpu/drm/i915/intel_uncore.c | 46 +++++++++++++++++++++++------ drivers/gpu/drm/i915/intel_uncore.h | 4 ++- 2 files changed, 40 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/intel_uncore.c +37 -9
@@ -845,7 +845,7 @@ static int fw_range_cmp(u32 offset, const struct intel_forcewake_range *entry) })static enum forcewake_domains -find_fw_domain (struct intel_uncore *uncore,u32 offset) +__find_fw_domain (struct intel_uncore *uncore,u32 offset) {const struct intel_forcewake_range *entry;
@@ -855,7 +855,7 @@ find_fw_domain(struct intel_uncore *uncore, u32 offset) fw_range_cmp);if (!entry) -return 0 ; +return FORCEWAKE_INVALID ;/* * The list of FW domains depends on the SKU in gen11+ so we
@@ -872,6 +872,34 @@ find_fw_domain(struct intel_uncore *uncore, u32 offset)return entry->domains; } +static enum forcewake_domains +find_fw_domain (struct intel_uncore *uncore,u32 offset) +{ +enum forcewake_domains fw_domains; + + fw_domains =__find_fw_domain (uncore, offset); + +if (fw_domains ==FORCEWAKE_INVALID ) +return FORCEWAKE_NONE ; +else +return fw_domains; +} + +static enum forcewake_domains +find_fw_domain_check (struct intel_uncore *uncore,u32 offset) +{ +enum forcewake_domains fw_domains; + + fw_domains =__find_fw_domain (uncore, offset); + +if (WARN (fw_domains ==FORCEWAKE_INVALID , +"Unknown forcewake domain(s) accessed at 0x%x\n" , + offset)) +return FORCEWAKE_ALL ; + +return fw_domains; +} +#define GEN_FW_RANGE (s, e, d) \ { .start = (s), .end = (e), .domains = (d) }
@@ -900,10 +928,10 @@ static const struct intel_forcewake_range __vlv_fw_ranges[] = { })#define __gen11_fwtable_reg_read_fw_domains (uncore, offset) \ - find_fw_domain(uncore, offset) + find_fw_domain_check(uncore, offset)#define __gen12_fwtable_reg_read_fw_domains (uncore, offset) \ - find_fw_domain(uncore, offset) + find_fw_domain_check(uncore, offset)/* *Must* be sorted by offset! See intel_shadow_table_check(). */ static const i915_reg_t gen8_shadowed_regs[] = {
@@ -1033,7 +1061,7 @@ static const struct intel_forcewake_range __chv_fw_ranges[] = {/* *Must* be sorted by offset ranges! See intel_fw_table_check(). */ static const struct intel_forcewake_range __gen9_fw_ranges[] = {GEN_FW_RANGE (0x0 ,0xaff ,FORCEWAKE_BLITTER ), -GEN_FW_RANGE (0xb00 ,0x1fff ,0 ),/* uncore range */ +GEN_FW_RANGE (0xb00 ,0x1fff ,FORCEWAKE_NONE ),/* uncore range */ GEN_FW_RANGE (0x2000 ,0x26ff ,FORCEWAKE_RENDER ),GEN_FW_RANGE (0x2700 ,0x2fff ,FORCEWAKE_BLITTER ),GEN_FW_RANGE (0x3000 ,0x3fff ,FORCEWAKE_RENDER ),
@@ -1069,7 +1097,7 @@ static const struct intel_forcewake_range __gen9_fw_ranges[] = {/* *Must* be sorted by offset ranges! See intel_fw_table_check(). */ static const struct intel_forcewake_range __gen11_fw_ranges[] = {GEN_FW_RANGE (0x0 ,0xaff ,FORCEWAKE_BLITTER ), -GEN_FW_RANGE (0xb00 ,0x1fff ,0 ),/* uncore range */ +GEN_FW_RANGE (0xb00 ,0x1fff ,FORCEWAKE_NONE ),/* uncore range */ GEN_FW_RANGE (0x2000 ,0x26ff ,FORCEWAKE_RENDER ),GEN_FW_RANGE (0x2700 ,0x2fff ,FORCEWAKE_BLITTER ),GEN_FW_RANGE (0x3000 ,0x3fff ,FORCEWAKE_RENDER ),
@@ -1092,7 +1120,7 @@ static const struct intel_forcewake_range __gen11_fw_ranges[] = {GEN_FW_RANGE (0x1a000 ,0x243ff ,FORCEWAKE_BLITTER ),GEN_FW_RANGE (0x24400 ,0x247ff ,FORCEWAKE_RENDER ),GEN_FW_RANGE (0x24800 ,0x3ffff ,FORCEWAKE_BLITTER ), -GEN_FW_RANGE (0x40000 ,0x1bffff ,0 ), +GEN_FW_RANGE (0x40000 ,0x1bffff ,FORCEWAKE_NONE ),GEN_FW_RANGE (0x1c0000 ,0x1c3fff ,FORCEWAKE_MEDIA_VDBOX0 ),GEN_FW_RANGE (0x1c4000 ,0x1c7fff ,FORCEWAKE_MEDIA_VDBOX1 ), GEN_FW_RANGE(0x1c8000, 0x1cbfff, FORCEWAKE_MEDIA_VEBOX0),
@@ -1105,7 +1133,7 @@ static const struct intel_forcewake_range __gen11_fw_ranges[] = {/* *Must* be sorted by offset ranges! See intel_fw_table_check(). */ static const struct intel_forcewake_range __gen12_fw_ranges[] = {GEN_FW_RANGE (0x0 ,0xaff ,FORCEWAKE_BLITTER ), -GEN_FW_RANGE (0xb00 ,0x1fff ,0 ),/* uncore range */ +GEN_FW_RANGE (0xb00 ,0x1fff ,FORCEWAKE_NONE ),/* uncore range */ GEN_FW_RANGE (0x2000 ,0x26ff ,FORCEWAKE_RENDER ),GEN_FW_RANGE (0x2700 ,0x2fff ,FORCEWAKE_BLITTER ),GEN_FW_RANGE (0x3000 ,0x3fff ,FORCEWAKE_RENDER ),
@@ -1132,7 +1160,7 @@ static const struct intel_forcewake_range __gen12_fw_ranges[] = {GEN_FW_RANGE (0x1c000 ,0x243ff ,FORCEWAKE_BLITTER ),GEN_FW_RANGE (0x24400 ,0x247ff ,FORCEWAKE_RENDER ),GEN_FW_RANGE (0x24800 ,0x3ffff ,FORCEWAKE_BLITTER ), -GEN_FW_RANGE (0x40000 ,0x1bffff ,0 ), +GEN_FW_RANGE (0x40000 ,0x1bffff ,FORCEWAKE_NONE ),GEN_FW_RANGE (0x1c0000 ,0x1c3fff ,FORCEWAKE_MEDIA_VDBOX0 ),GEN_FW_RANGE (0x1c4000 ,0x1c7fff ,FORCEWAKE_MEDIA_VDBOX1 ), GEN_FW_RANGE(0x1c8000, 0x1cbfff, FORCEWAKE_MEDIA_VEBOX0),
drivers/gpu/drm/i915/intel_uncore.h +3 -1
@@ -58,6 +58,7 @@ enum forcewake_domain_id { };enum forcewake_domains { +FORCEWAKE_NONE =0 ,FORCEWAKE_RENDER =BIT (FW_DOMAIN_ID_RENDER ),FORCEWAKE_BLITTER =BIT (FW_DOMAIN_ID_BLITTER ),FORCEWAKE_MEDIA =BIT (FW_DOMAIN_ID_MEDIA ),
@@ -68,7 +69,8 @@ enum forcewake_domains {FORCEWAKE_MEDIA_VEBOX0 =BIT (FW_DOMAIN_ID_MEDIA_VEBOX0 ),FORCEWAKE_MEDIA_VEBOX1 =BIT (FW_DOMAIN_ID_MEDIA_VEBOX1 ), -FORCEWAKE_ALL =BIT (FW_DOMAIN_ID_COUNT ) -1 +FORCEWAKE_ALL =BIT (FW_DOMAIN_ID_COUNT ) -1 , + FORCEWAKE_INVALID = BIT(FW_DOMAIN_ID_COUNT), }; struct intel_uncore_funcs {
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 3/3] drm/i915: Check that we do find forcewake domain on gen11+
Quoting Mika Kuoppala (2019-09-13 15:16:52)
Quoted 3 lines
By always requiring a valid forcewake domain, even
FORCEWAKE_NONE, we can make assertions that accesses need to land on a valid domain and not go out of bounds.
So since we only look up restricted ranges in the fw_table, we could just have a short selftest (intel_fw_table_check) to assert those ranges are filled and we have no holes.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915: Update Gen11 forcewake ranges
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/3] drm/i915: Update Gen11 forcewake ranges
URL : https://patchwork.freedesktop.org/series/66666/
State : warning
== Summary ==
$ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915: Update Gen11 forcewake ranges Okay!
Commit: drm/i915/tgl: Introduce gen12 forcewake ranges+./include/linux/spinlock.h:393:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:393:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:393:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:393:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:393:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:393:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:393:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block
Commit: drm/i915: Check that we do find forcewake domain on gen11+ Okay!
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Update Gen11 forcewake ranges
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/3] drm/i915: Update Gen11 forcewake ranges
URL : https://patchwork.freedesktop.org/series/66666/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6890 -> Patchwork_14401
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14401:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@i915_pm_rpm@basic-pci-d3-state:
- {fi-tgl-u}: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/fi-tgl-u/igt@[email protected]
* igt@i915_pm_rpm@basic-rte:
- {fi-tgl-u}: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/fi-tgl-u/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_14401 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_basic@create-close:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/fi-icl-u3/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/fi-icl-u3/igt@[email protected]
* igt@gem_ctx_create@basic-files:
- fi-cml-u2: [PASS][5] -> [INCOMPLETE][6] ([fdo#110566])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/fi-cml-u2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/fi-cml-u2/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: [PASS][7] -> [FAIL][8] ([fdo#109483])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/fi-icl-u2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/fi-icl-u2/igt@[email protected]
#### Possible fixes ####
* igt@gem_render_linear_blits@basic:
- fi-icl-u3: [DMESG-WARN][9] ([fdo#107724]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/fi-icl-u3/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/fi-icl-u3/igt@[email protected]
* igt@gem_sync@basic-each:
- {fi-tgl-u}: [INCOMPLETE][11] ([fdo#111647]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/fi-tgl-u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/fi-tgl-u/igt@[email protected]
* igt@i915_selftest@live_execlists:
- fi-skl-gvtdvm: [DMESG-FAIL][13] ([fdo#111108]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
* igt@kms_frontbuffer_tracking@basic:
- {fi-icl-u4}: [FAIL][15] ([fdo#103167]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/fi-icl-u4/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/fi-icl-u4/igt@[email protected]
- fi-icl-u2: [FAIL][17] ([fdo#103167]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/fi-icl-u2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/fi-icl-u2/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566
[fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108
[fdo#111647]: https://bugs.freedesktop.org/show_bug.cgi?id=111647
Participating hosts (54 -> 47)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6890 -> Patchwork_14401
CI-20190529: 20190529
CI_DRM_6890: 85db8e7ffdfa727551a7d99e77a26c4befb8e640 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5180: 811b10e2bd7fd2cd8ced9bbb55361c178886bbbd @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14401: 9e9ce022994530974159c0e074e79c030d046393 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
9e9ce0229945 drm/i915: Check that we do find forcewake domain on gen11+ ac8ad4596f29 drm/i915/tgl: Introduce gen12 forcewake ranges add2464ff921 drm/i915: Update Gen11 forcewake ranges
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 5 lines · Mika Kuoppala
Daniele noticed new render ranges in Gen11 fw table.
Bspec: 18331
Cc Daniele Ceraolo Spurio <[email protected]>Signed-off-by Mika Kuoppala <[email protected]>
Daniele
Quoted 50 lines
--- drivers/gpu/drm/i915/intel_uncore.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-)drivers/gpu/drm/i915/intel_uncore.c +4
-12@@ -805,9 +805,6 @@ void assert_forcewakes_active(struct intel_uncore *uncore,/* We give fast paths for the really cool registers */ #define NEEDS_FORCE_WAKE (reg) ((reg) < 0x40000) -#define GEN11_NEEDS_FORCE_WAKE (reg) \ - ((reg) < 0x40000 || ((reg) >= 0x1c0000 && (reg) < 0x1dc000)) -#define __gen6_reg_read_fw_domains (uncore, offset) \ ({ \ enum forcewake_domains __fwd; \@@ -903,12 +900,7 @@ static const struct intel_forcewake_range __vlv_fw_ranges[] = { })#define __gen11_fwtable_reg_read_fw_domains (uncore, offset) \ -({ \ - enum forcewake_domains __fwd = 0; \ - if (GEN11_NEEDS_FORCE_WAKE((offset))) \ - __fwd = find_fw_domain(uncore, offset); \ - __fwd; \ -}) + find_fw_domain(uncore, offset)/* *Must* be sorted by offset! See intel_shadow_table_check(). */ static const i915_reg_t gen8_shadowed_regs[] = {@@ -1005,8 +997,9 @@ static const struct intel_forcewake_range __chv_fw_ranges[] = {#define __gen11_fwtable_reg_write_fw_domains (uncore, offset) \ ({ \ enum forcewake_domains __fwd = 0; \ - if (GEN11_NEEDS_FORCE_WAKE((offset)) && !is_gen11_shadowed(offset)) \ - __fwd = find_fw_domain(uncore, offset); \ + const u32 __offset = (offset); \ + if (!is_gen11_shadowed(__offset)) \ + __fwd = find_fw_domain(uncore, __offset); \ __fwd; \ })@@ -1065,9 +1058,11 @@ static const struct intel_forcewake_range __gen11_fw_ranges[] = {GEN_FW_RANGE (0x9400 ,0x97ff ,FORCEWAKE_ALL ),GEN_FW_RANGE (0x9800 ,0xafff ,FORCEWAKE_BLITTER ), GEN_FW_RANGE(0xb000, 0xb47f, FORCEWAKE_RENDER), - GEN_FW_RANGE(0xb480, 0xdfff, FORCEWAKE_BLITTER),
drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1068
Quoted 10 lines
drivers/gpu/drm/i915/intel_uncore.c +5
-2-GEN_FW_RANGE (0xe000 ,0xe8ff ,FORCEWAKE_RENDER ), -GEN_FW_RANGE (0xe900 ,0x243ff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0xb480 ,0xdeff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0xdf00 ,0xe8ff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0xe900 ,0x16dff ,FORCEWAKE_BLITTER ), +GEN_FW_RANGE (0x16e00 ,0x19fff ,FORCEWAKE_RENDER ), +GEN_FW_RANGE (0x1a000 ,0x243ff ,FORCEWAKE_BLITTER ),GEN_FW_RANGE (0x24400 ,0x247ff ,FORCEWAKE_RENDER ),GEN_FW_RANGE (0x24800 ,0x3ffff ,FORCEWAKE_BLITTER ), GEN_FW_RANGE(0x40000, 0x1bffff, 0),
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915: Update Gen11 forcewake ranges
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/3] drm/i915: Update Gen11 forcewake ranges
URL : https://patchwork.freedesktop.org/series/66666/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6890_full -> Patchwork_14401_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_14401_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_14401_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14401_full:
### IGT changes ###
#### Possible regressions ####
* igt@perf_pmu@enable-race-rcs0:
- shard-skl: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-skl1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-skl7/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_14401_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#110841])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-iclb6/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-iclb2/igt@[email protected]
* igt@gem_eio@reset-stress:
- shard-iclb: [PASS][5] -> [FAIL][6] ([fdo#109661])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-iclb8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-iclb3/igt@[email protected]
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#111325]) +6 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-iclb6/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-iclb2/igt@[email protected]
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([fdo#108566]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-kbl2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-kbl3/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-skl: [PASS][11] -> [INCOMPLETE][12] ([fdo#110741])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-skl3/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-skl9/igt@[email protected]
* igt@kms_cursor_legacy@pipe-a-forked-bo:
- shard-apl: [PASS][13] -> [DMESG-WARN][14] ([fdo#103558] / [fdo#105602]) +18 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-apl1/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-apl8/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-xtiled:
- shard-skl: [PASS][15] -> [FAIL][16] ([fdo#103184] / [fdo#103232])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-skl9/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-skl6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
- shard-iclb: [PASS][17] -> [FAIL][18] ([fdo#103167]) +5 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-apl2/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-apl1/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-wc:
- shard-skl: [PASS][21] -> [FAIL][22] ([fdo#103167])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-skl9/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-wc.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-wc.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-skl: [PASS][23] -> [INCOMPLETE][24] ([fdo#104108])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-skl9/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-skl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#108145]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-skl9/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-skl6/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#103166])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-iclb4/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-iclb6/igt@[email protected]
* igt@kms_plane_scaling@pipe-a-scaler-with-pixel-format:
- shard-glk: [PASS][29] -> [INCOMPLETE][30] ([fdo#103359] / [k.org#198133])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-glk5/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-glk2/igt@[email protected]
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109441])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-iclb4/igt@kms_psr@psr2_cursor_render.html
* igt@perf@blocking:
- shard-skl: [PASS][33] -> [FAIL][34] ([fdo#110728])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-skl6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-skl8/igt@[email protected]
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109276]) +17 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-iclb1/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-iclb7/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [SKIP][37] ([fdo#109276]) -> [PASS][38] +14 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-iclb6/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-iclb2/igt@[email protected]
* igt@gem_exec_schedule@pi-ringfull-bsd:
- shard-iclb: [SKIP][39] ([fdo#111325]) -> [PASS][40] +4 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-iclb1/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-iclb7/igt@[email protected]
* igt@gem_softpin@noreloc-s3:
- shard-kbl: [DMESG-WARN][41] ([fdo#108566]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-kbl3/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-kbl2/igt@[email protected]
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][43] ([fdo#108566]) -> [PASS][44] +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-apl8/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-apl7/igt@[email protected]
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-apl: [INCOMPLETE][45] ([fdo#103927]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-apl8/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-apl8/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: [FAIL][47] ([fdo#103167]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][49] ([fdo#108341]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-iclb1/igt@kms_psr@no_drrs.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-iclb7/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][51] ([fdo#109441]) -> [PASS][52] +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-iclb6/igt@kms_psr@psr2_no_drrs.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@perf@polling:
- shard-skl: [FAIL][53] ([fdo#110728]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-skl3/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-skl6/igt@[email protected]
#### Warnings ####
* igt@gem_mocs_settings@mocs-isolation-bsd2:
- shard-iclb: [FAIL][55] ([fdo#111330]) -> [SKIP][56] ([fdo#109276])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-iclb2/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-iclb6/igt@[email protected]
* igt@kms_busy@extended-modeset-hang-newfb-render-e:
- shard-apl: [SKIP][57] ([fdo#109271] / [fdo#109278]) -> [SKIP][58] ([fdo#105602] / [fdo#109271] / [fdo#109278]) +2 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-apl1/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-apl8/igt@[email protected]
* igt@kms_content_protection@lic:
- shard-apl: [FAIL][59] ([fdo#110321]) -> [SKIP][60] ([fdo#105602] / [fdo#109271])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-apl1/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-apl8/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-cpu:
- shard-apl: [SKIP][61] ([fdo#109271]) -> [SKIP][62] ([fdo#105602] / [fdo#109271]) +9 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6890/shard-apl1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-cpu.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/shard-apl8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-cpu.html
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
[fdo#110741]: https://bugs.freedesktop.org/show_bug.cgi?id=110741
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6890 -> Patchwork_14401
CI-20190529: 20190529
CI_DRM_6890: 85db8e7ffdfa727551a7d99e77a26c4befb8e640 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5180: 811b10e2bd7fd2cd8ced9bbb55361c178886bbbd @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14401: 9e9ce022994530974159c0e074e79c030d046393 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14401/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx