drm/amdgpu: Replace tmp_adev with hive in amdgpu_pci_slot_reset
Subsystems (2)
PATCH 1/1 drm/amdgpu: Replace tmp_adev with hive in amdgpu_pci_slot_reset
Checking hive is more readable.
The following smatch warning:drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:6820 amdgpu_pci_slot_reset()
warn: iterator used outside loop: 'tmp_adev'
Fixes 8ba904f54148 ("drm/amdgpu: Multi-GPU DPC recovery support")
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Ce Sun <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
@@ -6846,7 +6846,7 @@ pci_ers_result_t amdgpu_pci_slot_reset(struct pci_dev *pdev)dev_info (adev->dev,"PCIe error recovery succeeded\n" ); }else {dev_err (adev->dev,"PCIe error recovery failed, err:%d\n" , r); -if (tmp_adev) { +if (hive) {list_for_each_entry (tmp_adev, &device_list, reset_list)amdgpu_device_unset_mp1_state (tmp_adev);amdgpu_device_unlock_reset_domain (adev->reset_domain);
Signature · 1 line
2.34.1
Am 09.04.25 um 15:18 schrieb Ce Sun:
Quoted 5 lines
Checking hive is more readable.
The following smatch warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:6820amdgpu_pci_slot_reset()
warn: iterator used outside loop: 'tmp_adev'
Please also remove the setting of hive and tmp_adev to NULL at the declaration.
This now becomes unnecessary and I'm pretty sure that some automated checker could complain about that as well.
Apart from that looks good to me.
Thanks,
Christian.
Quoted 21 lines
Fixes 8ba904f54148 ("drm/amdgpu: Multi-GPU DPC recovery support")Reported-by Dan Carpenter <[email protected]>Signed-off-by Ce Sun <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-1@@ -6846,7 +6846,7 @@ pci_ers_result_t amdgpu_pci_slot_reset(struct pci_dev *pdev)dev_info (adev->dev,"PCIe error recovery succeeded\n" ); }else {dev_err (adev->dev,"PCIe error recovery failed, err:%d\n" , r); -if (tmp_adev) { +if (hive) {list_for_each_entry (tmp_adev, &device_list, reset_list)amdgpu_device_unset_mp1_state (tmp_adev);amdgpu_device_unlock_reset_domain (adev->reset_domain);