Skip to contentSkip to conversation

Fix a bug of testing preferred mode

PATCH In review Hai Lan 2 participants 2 messages Apr 26, 2011

lore
Share & tools
lore

Hai Lan

author
#0 lore raw

PATCH 1/1 Fix a bug of testing preferred mode

---
 tests/testdisplay.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)
tests/testdisplay.c +6 -4
index 5bf5183..48684e1 100644
@@ -157,7 +157,7 @@ struct connector {
 
 static void dump_mode(drmModeModeInfo *mode)
 {
-	printf("  %s %d %d %d %d %d %d %d %d %d\n",
+	printf("  %s %d %d %d %d %d %d %d %d %d 0x%x 0x%x\n",
 	       mode->name,
 	       mode->vrefresh,
 	       mode->hdisplay,
@@ -167,7 +167,9 @@ static void dump_mode(drmModeModeInfo *mode)
 	       mode->vdisplay,
 	       mode->vsync_start,
 	       mode->vsync_end,
-	       mode->vtotal);
+	       mode->vtotal,
+	       mode->flags,
+	       mode->type);
 }
 
 static void dump_connectors(void)
@@ -199,7 +201,7 @@ static void dump_connectors(void)
 
 		printf("  modes:\n");
 		printf("  name refresh (Hz) hdisp hss hse htot vdisp "
-		       "vss vse vtot)\n");
+		       "vss vse vtot flags type\n");
 		for (j = 0; j < connector->count_modes; j++)
 			dump_mode(&connector->modes[j]);
 
@@ -271,7 +273,7 @@ static void connector_find_preferred_mode(struct connector *c)
 
 	for (j = 0; j < connector->count_modes; j++) {
 		c->mode = connector->modes[j];
-		if (c->mode.flags & DRM_MODE_TYPE_PREFERRED) {
+		if (c->mode.type & DRM_MODE_TYPE_PREFERRED) {
 			c->mode_valid = 1;
 			break;
 		}
Signature · 1 line
1.7.0.1
#1 lore raw

Good catch!

Thanks,
-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre