Skip to contentSkip to conversation

Linux 2.4.28-pre4

DISCUSSION Marcelo Tosatti 7 participants 7 messages Oct 8, 2004 – Oct 16, 2004

lore
Share & tools
lore
#0 lore raw

Hi,

Here goes 2.4.28-pre4...

It contains a number of driver updates (pcnet, e1000, gdth, prism54), a network update from David, few more gcc3.4 warning fixes.

I'm happy that the number of updates is small, -pre3 has been released more than one month ago.

Quoted 1 line

From now on can now change only what is necessary and let

the 2.4 tree in peace :)

Summary of changes from v2.4.28-pre3 to v2.4.28-pre4
============================================

<ajgrothe:yahoo.com>:
o [CRYPTO]: Whirlpool algorithm updates
o [CRYPTO]: Add missing tcrypt part of whirlpool updates

<ananth:broadcom.com>:
o [libata sata_svw] race condition fix, new device support

<joshk:triplehelix.org>:
o radeonfb: Fix module unload and red/blue typo
o hotplug: Don't build cpqphp_proc.o if !PROC_FS

<lesanti:sinectis.com.ar>:
o fix dcache nr_dentry race

<martin.wilck:fujitsu-siemens.com>:
o [TG3]: Fix pause handling, we had duplicate flags for the same thing

<michael.waychison:sun.com>:
o [TG3]: Fix thinko in 5704 fibre hw autoneg code

<peter:pantasys.com>:
o [IPCONFIG]: Verify DHCPACK packets
o [IPV4]: Fix DHCPACK checking in ipconfig.c

<tkooda-patch-kernel:devsec.org>:
o [CRYPTO]: xtea_encrypt() should use XTEA_DELTA instead of TEA_DELTA

<vda:port.imtp.ilyichevsk.odessa.ua>:
o trivial patch for 2.4: always inline __constant_*

Achim Leubner:
o gdth update

David S. Miller:
o [NET]: Kill SCM_CONNECT, never used and unreferenced
o [TCP]: Just silently ignore ICMP Source Quench messages
o [TG3]: Recognize all onboard Sun variants, not just 5704
o [TG3]: Update driver version and reldate
o [CRYPTO]: Zero out tfm before freeing in crypto_free_tfm()
o [SPARC64]: Do not log streaming byte hole errors
o [PKT_SCHED]: sch_netem.c needs linux/init.h
o [SPARC64]: Disable SBH interrupt properly

David Woodhouse:
o [NET]: In compat syscall handling, check socket option types correctly

Don Fry:
o pcnet32: discard oversize rx packets
o pcnet32: recover after rx hang
o pcnet32: cleanup IRQ limitation
o pcnet32: Add HomePNA parameter for 79C978
o pcnet32: correctly program bcr32

Doug Ledford:
o RAID1 error handling locking fix

Ganesh Venkatesan:
o e1000 - ethtool support cleanup
o e1000 - Enable TSO
o e1000 - Replace kmalloc with vmalloc for data structures not shared with h/w
o e1000 - TSO context descriptor setup fixes (in preparation for IPv6 TSO)
o e1000 - Fix to prevent infinite loop trying to re-establish link while actively communicating
o e1000 - Condition that determines when to quit polling mode includes work done in Tx path
o e1000 - Shutdown PHY while bringing the interface down (if WoL not enabled)
o e1000 - add likely/unlikely to assist branch prediction, other cleanups
o e1000 - more DPRINTK messages
o e1000 - suspend/resume fix from [email protected]
o e1000 - white space corrections
o e1000 - remove support for advanced TCO features
o e1000 - Fix MODULE_PARM, module_param and module_param_array usage
o e1000 - Fix VLAN filter setup errors (while running on PPC)
o e1000 - Polarity reversal workaround for 10F/10H links
o e1000 - white space corrections, other cleanups
o e1000 update - reset default ITR value to 8000

Geert Uytterhoeven:
o m68k MM off-by-one
o Atari ST-RAM setup
o Amiga frame buffer: kill obsolete DMI Resolver code
o fbdev monochrome lines

Herbert Xu:
o Backport Via IRQ mask fix

Hideaki Yoshifuji:
o [IPV6] Fix routing header handling
o [IPV6] Fix skb allocation size for RST and ACK
o [IPV6]: Missing ip_rt_put() in SIT error path

Jack Hammer:
o broken ips update

Jean Delvare:
o Update Documentation/i2c/writing-clients

Jeff Garzik:
o [TG3]: Kill all on-chip send BD support code
o linux/compiler.h: dummy __iomem macro (an sparse annotation)
o [libata] resync with 2.6.x
o [libata] remove distinction between MMIO/PIO helper functions
o [libata] consolidate legacy/native mode init code into helpers
o [libata] minor comment updates, preparing for iomap merge

Jens Axboe:
o irq safe gendisk_lock

Linus Torvalds:
o libata: initial PCI memory annotations

Marcelo Tosatti:

  o Cset exclude: [email protected]|ChangeSet|20040928105422|00490

o Mike Miller: cciss typo fix
o Changed EXTRAVERSION to -pre4

Margit Schubert-While:
o prism54 Code cleanup
o prism54 remove module params
o prism54 add WE17 support
o prism54 initial WPA support
o prism54 fix wpa_supplicant frequency parsing
o prism54 remove TRACE
o prism54 Bug in timeout scheduling
o prism54 print firmware version
o prism54 bug initialization/mgt_commit

Maximilian Attems:
o menuconfig fix crash due to infinite recursion

Mikael Pettersson:
o 53c700 scsi driver gcc-3.4 fixes
o pcmcia mem_op.h gcc-3.4 fixes
o ATM drivers gcc-3.4 fixes
o IBM PCI hotplug controller driver gcc-3.4 fixes
o ISDN drivers gcc-3.4 fixes
o MTD drivers gcc-3.4 fixes
o RIVA driver gcc-3.4 fix
o E100 driver gcc-3.4 fixes
o PPC32 PReP residual data gcc-3.4 fix
o matrox framebuffer driver gcc-3.4 fix

Pete Zaitcev:
o USB drivers gcc-3.4 fixes

Stephen Hemminger:
o [TCP]: Store congestion algorithm per socket
o [TCP]: Add vegas style bandwidth info to 2.4.x tcp diag
o [TCP]: Backport 2.6.x cleanup of westwood code

Thomas Graf:
o [PKT_SCHED]: Fix slab corruption in cbq_destroy
o [PKT_SCHED] Report qdisc parent to userspace

Wensong Zhang:
o [IPVS] add the MAINTAINERS entry

#1 lore raw

2.4.28-pre4: e1000_main.c gcc 3.4 compile error

Quoted 8 lines · Marcelo Tosatti

...
Summary of changes from v2.4.28-pre3 to v2.4.28-pre4
============================================
...
Ganesh Venkatesan:
...
o e1000 - white space corrections, other cleanups
...

The "other cleanups" are moving e1000_irq_enable/e1000_irq_disable/e1000_rx_checksum around resulting in at least the following compile error with gcc 3.4:

<-- snip -->

...
gcc-3.4 -D__KERNEL__ -I/home/bunk/linux/kernel-2.4/linux-2.4.28-pre4-full/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=athlon
-fno-unit-at-a-time -nostdinc -iwithprefix include
-DKBUILD_BASENAME=e1000_main -c -o e1000_main.o e1000_main.c e1000_main.c: In function `e1000_up':
e1000_main.c:132: sorry, unimplemented: inlining failed in call to 'e1000_irq_enable': function body not available e1000_main.c:277: sorry, unimplemented: called from here make[4]: *** [e1000_main.o] Error 1
make[4]: Leaving directory `/home/bunk/linux/kernel-2.4/linux-2.4.28-pre4-full/drivers/net/e1000'

<-- snip -->

Please drop this changeset.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#2 lore raw
In reply to Marcelo Tosatti

no chance of including IMQ?

http://www.linuximq.net/

Quoted 178 lines · Marcelo Tosatti

Hi,

Here goes 2.4.28-pre4...

It contains a number of driver updates (pcnet, e1000, gdth, prism54), a network update from David, few more gcc3.4 warning fixes.

I'm happy that the number of updates is small, -pre3 has been released more than one month ago.

From now on can now change only what is necessary and let the 2.4 tree in peace :)

Summary of changes from v2.4.28-pre3 to v2.4.28-pre4
============================================

<ajgrothe:yahoo.com>:
o [CRYPTO]: Whirlpool algorithm updates
o [CRYPTO]: Add missing tcrypt part of whirlpool updates

<ananth:broadcom.com>:
o [libata sata_svw] race condition fix, new device support

<joshk:triplehelix.org>:
o radeonfb: Fix module unload and red/blue typo
o hotplug: Don't build cpqphp_proc.o if !PROC_FS

<lesanti:sinectis.com.ar>:
o fix dcache nr_dentry race

<martin.wilck:fujitsu-siemens.com>:
o [TG3]: Fix pause handling, we had duplicate flags for the same thing

<michael.waychison:sun.com>:
o [TG3]: Fix thinko in 5704 fibre hw autoneg code

<peter:pantasys.com>:
o [IPCONFIG]: Verify DHCPACK packets
o [IPV4]: Fix DHCPACK checking in ipconfig.c

<tkooda-patch-kernel:devsec.org>:
o [CRYPTO]: xtea_encrypt() should use XTEA_DELTA instead of TEA_DELTA

<vda:port.imtp.ilyichevsk.odessa.ua>:
o trivial patch for 2.4: always inline __constant_*

Achim Leubner:
o gdth update

David S. Miller:
o [NET]: Kill SCM_CONNECT, never used and unreferenced
o [TCP]: Just silently ignore ICMP Source Quench messages
o [TG3]: Recognize all onboard Sun variants, not just 5704
o [TG3]: Update driver version and reldate
o [CRYPTO]: Zero out tfm before freeing in crypto_free_tfm()
o [SPARC64]: Do not log streaming byte hole errors
o [PKT_SCHED]: sch_netem.c needs linux/init.h
o [SPARC64]: Disable SBH interrupt properly

David Woodhouse:
o [NET]: In compat syscall handling, check socket option types correctly

Don Fry:
o pcnet32: discard oversize rx packets
o pcnet32: recover after rx hang
o pcnet32: cleanup IRQ limitation
o pcnet32: Add HomePNA parameter for 79C978
o pcnet32: correctly program bcr32

Doug Ledford:
o RAID1 error handling locking fix

Ganesh Venkatesan:
o e1000 - ethtool support cleanup
o e1000 - Enable TSO
o e1000 - Replace kmalloc with vmalloc for data structures not shared with h/w
o e1000 - TSO context descriptor setup fixes (in preparation for IPv6 TSO)
o e1000 - Fix to prevent infinite loop trying to re-establish link while actively communicating
o e1000 - Condition that determines when to quit polling mode includes work done in Tx path
o e1000 - Shutdown PHY while bringing the interface down (if WoL not enabled)
o e1000 - add likely/unlikely to assist branch prediction, other cleanups
o e1000 - more DPRINTK messages
o e1000 - suspend/resume fix from [email protected]
o e1000 - white space corrections
o e1000 - remove support for advanced TCO features
o e1000 - Fix MODULE_PARM, module_param and module_param_array usage
o e1000 - Fix VLAN filter setup errors (while running on PPC)
o e1000 - Polarity reversal workaround for 10F/10H links
o e1000 - white space corrections, other cleanups
o e1000 update - reset default ITR value to 8000

Geert Uytterhoeven:
o m68k MM off-by-one
o Atari ST-RAM setup
o Amiga frame buffer: kill obsolete DMI Resolver code
o fbdev monochrome lines

Herbert Xu:
o Backport Via IRQ mask fix

Hideaki Yoshifuji:
o [IPV6] Fix routing header handling
o [IPV6] Fix skb allocation size for RST and ACK
o [IPV6]: Missing ip_rt_put() in SIT error path

Jack Hammer:
o broken ips update

Jean Delvare:
o Update Documentation/i2c/writing-clients

Jeff Garzik:
o [TG3]: Kill all on-chip send BD support code
o linux/compiler.h: dummy __iomem macro (an sparse annotation)
o [libata] resync with 2.6.x
o [libata] remove distinction between MMIO/PIO helper functions
o [libata] consolidate legacy/native mode init code into helpers
o [libata] minor comment updates, preparing for iomap merge

Jens Axboe:
o irq safe gendisk_lock

Linus Torvalds:
o libata: initial PCI memory annotations

Marcelo Tosatti:

  o Cset exclude: [email protected]|ChangeSet|20040928105422|00490

o Mike Miller: cciss typo fix
o Changed EXTRAVERSION to -pre4

Margit Schubert-While:
o prism54 Code cleanup
o prism54 remove module params
o prism54 add WE17 support
o prism54 initial WPA support
o prism54 fix wpa_supplicant frequency parsing
o prism54 remove TRACE
o prism54 Bug in timeout scheduling
o prism54 print firmware version
o prism54 bug initialization/mgt_commit

Maximilian Attems:
o menuconfig fix crash due to infinite recursion

Mikael Pettersson:
o 53c700 scsi driver gcc-3.4 fixes
o pcmcia mem_op.h gcc-3.4 fixes
o ATM drivers gcc-3.4 fixes
o IBM PCI hotplug controller driver gcc-3.4 fixes
o ISDN drivers gcc-3.4 fixes
o MTD drivers gcc-3.4 fixes
o RIVA driver gcc-3.4 fix
o E100 driver gcc-3.4 fixes
o PPC32 PReP residual data gcc-3.4 fix
o matrox framebuffer driver gcc-3.4 fix

Pete Zaitcev:
o USB drivers gcc-3.4 fixes

Stephen Hemminger:
o [TCP]: Store congestion algorithm per socket
o [TCP]: Add vegas style bandwidth info to 2.4.x tcp diag
o [TCP]: Backport 2.6.x cleanup of westwood code

Thomas Graf:
o [PKT_SCHED]: Fix slab corruption in cbq_destroy
o [PKT_SCHED] Report qdisc parent to userspace

Wensong Zhang:
o [IPVS] add the MAINTAINERS entry

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#3 lore raw
In reply to Marcelo Tosatti

At some point, can we get forcedeth.c updated in 2.4.x? We've taken the latest from 2.6.8 and posted a patch against 2.4.27, but it isn't getting picked up. See
http://www.uwsg.indiana.edu/hypermail/linux/kernel/0408.1/1523.html

Regards,
Brian

Quoted 190 lines · Marcelo Tosatti

Hi,

Here goes 2.4.28-pre4...

It contains a number of driver updates (pcnet, e1000, gdth, prism54), a network update from David, few more gcc3.4 warning fixes.

I'm happy that the number of updates is small, -pre3 has been released more than one month ago.

Quoted 1 line

From now on can now change only what is necessary and let

the 2.4 tree in peace :)

Summary of changes from v2.4.28-pre3 to v2.4.28-pre4
============================================

<ajgrothe:yahoo.com>:
o [CRYPTO]: Whirlpool algorithm updates
o [CRYPTO]: Add missing tcrypt part of whirlpool updates

<ananth:broadcom.com>:
o [libata sata_svw] race condition fix, new device support

<joshk:triplehelix.org>:
o radeonfb: Fix module unload and red/blue typo
o hotplug: Don't build cpqphp_proc.o if !PROC_FS

<lesanti:sinectis.com.ar>:
o fix dcache nr_dentry race

<martin.wilck:fujitsu-siemens.com>:
o [TG3]: Fix pause handling, we had duplicate flags for the same
thing

<michael.waychison:sun.com>:
o [TG3]: Fix thinko in 5704 fibre hw autoneg code

<peter:pantasys.com>:
o [IPCONFIG]: Verify DHCPACK packets
o [IPV4]: Fix DHCPACK checking in ipconfig.c

<tkooda-patch-kernel:devsec.org>:
o [CRYPTO]: xtea_encrypt() should use XTEA_DELTA instead of
TEA_DELTA

<vda:port.imtp.ilyichevsk.odessa.ua>:
o trivial patch for 2.4: always inline __constant_*

Achim Leubner:
o gdth update

David S. Miller:
o [NET]: Kill SCM_CONNECT, never used and unreferenced
o [TCP]: Just silently ignore ICMP Source Quench messages
o [TG3]: Recognize all onboard Sun variants, not just 5704
o [TG3]: Update driver version and reldate
o [CRYPTO]: Zero out tfm before freeing in crypto_free_tfm()
o [SPARC64]: Do not log streaming byte hole errors
o [PKT_SCHED]: sch_netem.c needs linux/init.h
o [SPARC64]: Disable SBH interrupt properly

David Woodhouse:
o [NET]: In compat syscall handling, check socket option types
correctly

Don Fry:
o pcnet32: discard oversize rx packets
o pcnet32: recover after rx hang
o pcnet32: cleanup IRQ limitation
o pcnet32: Add HomePNA parameter for 79C978
o pcnet32: correctly program bcr32

Doug Ledford:
o RAID1 error handling locking fix

Ganesh Venkatesan:
o e1000 - ethtool support cleanup
o e1000 - Enable TSO
o e1000 - Replace kmalloc with vmalloc for data structures not
shared with h/w
o e1000 - TSO context descriptor setup fixes (in preparation for
IPv6 TSO)
o e1000 - Fix to prevent infinite loop trying to re-establish link
while actively communicating
o e1000 - Condition that determines when to quit polling mode
includes work done in Tx path
o e1000 - Shutdown PHY while bringing the interface down (if WoL not
enabled)
o e1000 - add likely/unlikely to assist branch prediction, other
cleanups
o e1000 - more DPRINTK messages
o e1000 - suspend/resume fix from [email protected]
o e1000 - white space corrections
o e1000 - remove support for advanced TCO features
o e1000 - Fix MODULE_PARM, module_param and module_param_array usage
o e1000 - Fix VLAN filter setup errors (while running on PPC)
o e1000 - Polarity reversal workaround for 10F/10H links
o e1000 - white space corrections, other cleanups
o e1000 update - reset default ITR value to 8000

Geert Uytterhoeven:
o m68k MM off-by-one
o Atari ST-RAM setup
o Amiga frame buffer: kill obsolete DMI Resolver code
o fbdev monochrome lines

Herbert Xu:
o Backport Via IRQ mask fix

Hideaki Yoshifuji:
o [IPV6] Fix routing header handling
o [IPV6] Fix skb allocation size for RST and ACK
o [IPV6]: Missing ip_rt_put() in SIT error path

Jack Hammer:
o broken ips update

Jean Delvare:
o Update Documentation/i2c/writing-clients

Jeff Garzik:
o [TG3]: Kill all on-chip send BD support code
o linux/compiler.h: dummy __iomem macro (an sparse annotation)
o [libata] resync with 2.6.x
o [libata] remove distinction between MMIO/PIO helper functions
o [libata] consolidate legacy/native mode init code into helpers
o [libata] minor comment updates, preparing for iomap merge

Jens Axboe:
o irq safe gendisk_lock

Linus Torvalds:
o libata: initial PCI memory annotations

Marcelo Tosatti:
o Cset exclude:
[email protected]|ChangeSet|20040928105422|00490
o Mike Miller: cciss typo fix
o Changed EXTRAVERSION to -pre4

Margit Schubert-While:
o prism54 Code cleanup
o prism54 remove module params
o prism54 add WE17 support
o prism54 initial WPA support
o prism54 fix wpa_supplicant frequency parsing
o prism54 remove TRACE
o prism54 Bug in timeout scheduling
o prism54 print firmware version
o prism54 bug initialization/mgt_commit

Maximilian Attems:
o menuconfig fix crash due to infinite recursion

Mikael Pettersson:
o 53c700 scsi driver gcc-3.4 fixes
o pcmcia mem_op.h gcc-3.4 fixes
o ATM drivers gcc-3.4 fixes
o IBM PCI hotplug controller driver gcc-3.4 fixes
o ISDN drivers gcc-3.4 fixes
o MTD drivers gcc-3.4 fixes
o RIVA driver gcc-3.4 fix
o E100 driver gcc-3.4 fixes
o PPC32 PReP residual data gcc-3.4 fix
o matrox framebuffer driver gcc-3.4 fix

Pete Zaitcev:
o USB drivers gcc-3.4 fixes

Stephen Hemminger:
o [TCP]: Store congestion algorithm per socket
o [TCP]: Add vegas style bandwidth info to 2.4.x tcp diag
o [TCP]: Backport 2.6.x cleanup of westwood code

Thomas Graf:
o [PKT_SCHED]: Fix slab corruption in cbq_destroy
o [PKT_SCHED] Report qdisc parent to userspace

Wensong Zhang:
o [IPVS] add the MAINTAINERS entry

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#4 lore raw
Quoted 3 lines · Brian Lazara

At some point, can we get forcedeth.c updated in 2.4.x? We've taken the latest from 2.6.8

The driver in 2.6.8 contains a critical bug that prevents the operation on the non-GB board with a modularized driver. See
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=128292

It's now fixed, I've written a backport of the 0.29 driver, it's at

http://marc.theaimsgroup.com/?l=linux-kernel&m=109439014812433&w=2

But that backport was stopped due to an oddity in your original backport:

Quoted 6 lines

From http://www.uwsg.indiana.edu/hypermail/linux/kernel/0408.1/1523.html:

#define PCI_DEVICE_ID_NVIDIA_NFORCE3 0x00d1
#define PCI_DEVICE_ID_NVIDIA_NFORCE3_IDE 0x00d5
+#define PCI_DEVICE_ID_NVIDIA_NVENET_3 0x00d5
#define PCI_DEVICE_ID_NVIDIA_MCP3_AUDIO 0x00da

NVENET_3 can't have the id 0x00d5. I've asked Jane Liu a month ago to double check the values and I'm still waiting for a reply.

For me, that's the only open point that prevents merging. What I'm missing is a positive test report from a non-GB board, but that's not mandatory - IMHO the code receives enough testing in 2.6.

--
Manfred

#6 lore raw
In reply to Marcelo Tosatti
Quoted 2 lines · Marcelo Tosatti

From now on can now change only what is necessary and let the 2.4 tree in peace :)

Is it still possible to add this patch to 2.4 (i.e. 2.4.28 or 2.4.29), or is it too late/too invasive?

[PATCH] fix ELF exec with huge bss
http://linux.bkbits.net:8080/linux-2.5/cset@3ff112802L-9-rs0BbkozDnTnpch9w

AFAIK, this patch has been in 2.6 for several months and has been in Red Hat Enterprise Linux 3 kernels for a long while too. The reason I'd like to see it in a future 2.4 kernel is that it fixes some crashes that some of my users are seeing (e.g. with a Fortran 77 program that has a BSS larger than 2GB).

BTW, if the above patch is added to 2.4, maybe this patch is also needed to handle a corner case (like the previous patch, it's been in 2.6 for several months and RHEL 3 for a long time):

[PATCH] binfmt_elf.c fix for 32-bit apps with large bss
http://linux.bkbits.net:8080/linux-2.5/cset@407afc8e4kEZSl4pklf3Ptrl2ZzkeA

-Barry K. Nathan <[email protected]>