Skip to contentSkip to conversation

drivers/fsl_linflexuart.c : remove redundant uart type

PATCH In review lizhe 2 participants 2 messages Jan 3, 2023 TTY layer and serial drivers

lore
Share & tools
lore

lizhe

author
#0 lore raw

PATCH 1/1 drivers/fsl_linflexuart.c : remove redundant uart type

in linflex_config_port() the member variable will be assigned again . see linflex_config_port()

---
 drivers/tty/serial/fsl_linflexuart.c | 1 -
 1 file changed, 1 deletion(-)
drivers/tty/serial/fsl_linflexuart.c +0 -1
index 6fc21b6684e6..34400cc6ac7f 100644
@@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev)
 		return PTR_ERR(sport->membase);
 
 	sport->dev = &pdev->dev;
-	sport->type = PORT_LINFLEXUART;
 	sport->iotype = UPIO_MEM;
 	sport->irq = platform_get_irq(pdev, 0);
 	sport->ops = &linflex_pops;
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 2 lines · lizhe

in linflex_config_port() the member variable will be assigned again . see linflex_config_port()

Fine, but can you make the subject and the commit message a little bit saner?

I.e. no tabs, no spaces before semicolons and colons. The subject should be something like "serial: linflexuart: remove redundant uart type _assignment_" and so on.

Quoted 1 line

Is this your legal name?

Quoted 16 lines
---
  drivers/tty/serial/fsl_linflexuart.c | 1 -
  1 file changed, 1 deletion(-)
drivers/tty/serial/fsl_linflexuart.c +0 -1
index 6fc21b6684e6..34400cc6ac7f 100644
@@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev)
  		return PTR_ERR(sport->membase);
 
  	sport->dev = &pdev->dev;
-	sport->type = PORT_LINFLEXUART;
  	sport->iotype = UPIO_MEM;
  	sport->irq = platform_get_irq(pdev, 0);
  	sport->ops = &linflex_pops;
Signature · 2 lines
js
suse labs