Skip to contentSkip to conversation

hid: add info to Kconfig

PATCH In review Albert Zhou 2 participants 3 messages Nov 20, 2022 – Nov 21, 2022 HID

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hid: add info to Kconfig

Nowadays many laptops use multitouch for their touchpads. This is now indicated in the help message for HID_MULTITOUCH in the Kconfig.

---
 drivers/hid/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/hid/Kconfig +2 -1
index 185a077d59cd..86f65258a912 100644
@@ -697,7 +697,8 @@ config HID_MONTEREY
 config HID_MULTITOUCH
 	tristate "HID Multitouch panels"
 	help
-	  Generic support for HID multitouch panels.
+	  Generic support for HID multitouch panels. Many newer laptops (like
+	  the Dell XPS 13 9360) use multitouch for their touchpads.
 
 	  Say Y here if you have one of the following devices:
 	  - 3M PCT touch screens

base-commit: fe24a97cf2543e8832e7a2124802e5c32aac05aa

Signature · 1 line
2.34.1
#1 lore raw

Hi Albert,

Quoted 13 lines · Albert Zhou

Nowadays many laptops use multitouch for their touchpads. This is now indicated in the help message for HID_MULTITOUCH in the Kconfig.

---
 drivers/hid/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/hid/Kconfig +0 -0
index 185a077d59cd..86f65258a912 100644

drivers/hid/Kconfig config HID_MONTEREY · line 701

Quoted 6 lines
drivers/hid/Kconfig +2 -1
@@ -697,7 +697,8 @@ config HID_MONTEREY
 config HID_MULTITOUCH
 	tristate "HID Multitouch panels"
 	help
-	  Generic support for HID multitouch panels.
+	  Generic support for HID multitouch panels. Many newer laptops (like
+	  the Dell XPS 13 9360) use multitouch for their touchpads.

This is just my opinion, but the intent is to describe what the feature does, not make claims about what products might happen to use it as of today.

Furthermore, "newer" is relative. This statement won't have the same meaning years from now. I think the description is fine as-is.

Quoted 8 lines
drivers/hid/Kconfig +0 -0
 	  Say Y here if you have one of the following devices:
 	  - 3M PCT touch screens
 

base-commit: fe24a97cf2543e8832e7a2124802e5c32aac05aa

Signature · 1 line
2.34.1

Kind regards,
Jeff LaBundy

#2 lore raw
Quoted 7 lines · Jeff LaBundy

This is just my opinion, but the intent is to describe what the feature does, not make claims about what products might happen to use it as of today.

Furthermore, "newer" is relative. This statement won't have the same meaning years from now. I think the description is fine as-is.

Hi Jeff,

Currently the long list of supported products consists almost exclusively of touchscreen devices, giving the false impression it's not relevant for laptop touchpads.

Actually I turned this off because I thought I wouldn't need it, but later I discovered it's used for my touchpad, which is why I thought it might be useful to add this to the help message.

From Albert Zhou