Skip to contentSkip to conversation

scsi: ufs-qcom: remove broken hci version quirk

PATCH In review Asutosh Das 2 participants 3 messages Jan 30, 2018 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: ufs-qcom: remove broken hci version quirk

From: Subhash Jadavani <[email protected]>

UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION is only applicable for QCOM UFS host controller version 2.x.y and this has been fixed from version 3.x.y onwards, hence this change removes this quirk for version 3.x.y onwards.

---
 drivers/scsi/ufs/ufs-qcom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/ufs/ufs-qcom.c +1 -1
index 2b38db2..221820a 100644
@@ -1098,7 +1098,7 @@ static void ufs_qcom_advertise_quirks(struct ufs_hba *hba)
 		hba->quirks |= UFSHCD_QUIRK_BROKEN_LCC;
 	}
 
-	if (host->hw_ver.major >= 0x2) {
+	if (host->hw_ver.major == 0x2) {
 		hba->quirks |= UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION;
 
 		if (!ufs_qcom_cap_qunipro(host))
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
#1 lore raw

Hi Asutosh,

Quoted 9 lines · Asutosh Das

From: Subhash Jadavani <[email protected]>

UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION is only applicable for QCOM UFS host controller version 2.x.y and this has been fixed from version 3.x.y onwards, hence this change removes this quirk for version 3.x.y onwards.

---

This patch and all other ufs patches that you have posted recently, do they all fall under one 'ufs-qcom fixes' patch series for fixes that we would want to do?
If it is so, then please club them together in a series, so that it's easy for reviewers and maintainers to review, and keep track of all the patches that can get-in after the reviews.
If they belong to two or more separate patch-series then please create such patch series.
It's difficult to read through a lot of [PATCH 1/1] ... patch.

Regards
Vivek

Quoted 16 lines
  drivers/scsi/ufs/ufs-qcom.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/ufs/ufs-qcom.c +1 -1
index 2b38db2..221820a 100644
@@ -1098,7 +1098,7 @@ static void ufs_qcom_advertise_quirks(struct ufs_hba *hba)
  		hba->quirks |= UFSHCD_QUIRK_BROKEN_LCC;
  	}
 
-	if (host->hw_ver.major >= 0x2) {
+	if (host->hw_ver.major == 0x2) {
  		hba->quirks |= UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION;
 
  		if (!ufs_qcom_cap_qunipro(host))
#2 lore raw
Quoted 14 lines · Vivek Gautam

Hi Asutosh,

Quoted 9 lines · Asutosh Das

From: Subhash Jadavani <[email protected]>

UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION is only applicable for QCOM UFS host controller version 2.x.y and this has been fixed from version 3.x.y onwards, hence this change removes this quirk for version 3.x.y onwards.

---

Quoted 9 lines

This patch and all other ufs patches that you have posted recently, do they all fall under one 'ufs-qcom fixes' patch series for fixes that we would want to do?
If it is so, then please club them together in a series, so that it's easy for reviewers and maintainers to review, and keep track of all the patches that can get-in after the reviews.
If they belong to two or more separate patch-series then please create such patch series.
It's difficult to read through a lot of [PATCH 1/1] ... patch.

Sure Vivek - Makes sense. Will resend it.

Quoted 20 lines

Regards
Vivek

Quoted 15 lines

  drivers/scsi/ufs/ufs-qcom.c | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/ufs/ufs-qcom.c +1 -1
index 2b38db2..221820a 100644
@@ -1098,7 +1098,7 @@ static void ufs_qcom_advertise_quirks(struct 
 ufs_hba *hba)
           hba->quirks |= UFSHCD_QUIRK_BROKEN_LCC;
       }
-    if (host->hw_ver.major >= 0x2) {
+    if (host->hw_ver.major == 0x2) {
           hba->quirks |= UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION;
           if (!ufs_qcom_cap_qunipro(host))
Signature · 1 line
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project