Verify measurement of certificate imported into a keyring
cover Verify measurement of certificate imported into a keyring
The IMA subsystem supports measuring certificates that have been loaded into user-defined keyrings and system built-in keyrings. A test to verify that those measurements are correct is required.
The first two patches in this patchset fix up left-over documentation and move some datafiles around to prepare for more datafiles in the 3rd patch.
The third patch adds a new test to the ima_keys.sh file, which imports a certificate into a user-defined keyring, and then verifies that the certificate has been measured correctly by the IMA subsystem.
Lachlan Sneff (3):
IMA: Update key test documentation
IMA: Refactor datafiles directory
IMA: Add a test to verify measurement of certificate imported into a
keyring
.../kernel/security/integrity/ima/README.md | 32 +++++++------
.../security/integrity/ima/datafiles/Makefile | 6 +--
.../integrity/ima/datafiles/keys/Makefile | 15 ++++++
.../integrity/ima/datafiles/keys/x509_ima.der | Bin 0 -> 650 bytes
.../integrity/ima/datafiles/policy/Makefile | 15 ++++++
.../ima/datafiles/{ => policy}/kexec.policy | 0
.../datafiles/{ => policy}/keycheck.policy | 0
.../ima/datafiles/{ => policy}/measure.policy | 0
.../{ => policy}/measure.policy-invalid | 0
.../security/integrity/ima/tests/ima_keys.sh | 44 +++++++++++++++++-
10 files changed, 91 insertions(+), 21 deletions(-)
create mode 100644 testcases/kernel/security/integrity/ima/datafiles/keys/Makefile
create mode 100644 testcases/kernel/security/integrity/ima/datafiles/keys/x509_ima.der
create mode 100644 testcases/kernel/security/integrity/ima/datafiles/policy/Makefile
rename testcases/kernel/security/integrity/ima/datafiles/{ => policy}/kexec.policy (100%)
rename testcases/kernel/security/integrity/ima/datafiles/{ => policy}/keycheck.policy (100%)
rename testcases/kernel/security/integrity/ima/datafiles/{ => policy}/measure.policy (100%)
rename testcases/kernel/security/integrity/ima/datafiles/{ => policy}/measure.policy-invalid (100%)Signature · 1 line
2.25.1
PATCH 1/3 IMA: Update key test documentation
The current documentation for the existing IMA key test was left in by accident by a previous merge. It does not apply to the test that is currently included in the LTP.
Update the documentation for the IMA key test.
--- .../kernel/security/integrity/ima/README.md | 22 +++++-------------- 1 file changed, 5 insertions(+), 17 deletions(-)
testcases/kernel/security/integrity/ima/README.md +5 -17
@@ -15,27 +15,15 @@ Although a custom policy, loaded via dracut, systemd or manually from user space, may contain equivalent measurement tcb rules, detecting them would require `IMA_READ_POLICY=y` therefore ignore this option. -### IMA key import test -`ima_keys.sh` requires a x509 public key, by default in `/etc/keys/x509_ima.der` -(defined in `CONFIG_IMA_X509_PATH` kernel config option). -The key must be signed by the private key you generate. Follow these instructions: -https://manpages.ubuntu.com/manpages/disco/man1/evmctl.1.html#generate%20trusted%20keys - -The test cannot be set-up automatically because the x509 public key must be -built into the kernel and loaded onto a trusted keyring -(e.g. `.builtin_trusted_keys`, `.secondary_trusted_keyring`). - -As well as what's required for the IMA tests, the following are also required -in the kernel configuration: +### IMA key test +`ima_keys.sh` requires a readable IMA policy, as well as a loaded policy +with `func=KEY_CHECK keyrings=...`, see example in `keycheck.policy`. + +Mandatory kernel configuration for IMA: ``` CONFIG_IMA_READ_POLICY=y -CONFIG_IMA_X509_PATH="/etc/keys/x509_ima.der" -CONFIG_SYSTEM_TRUSTED_KEYRING=y -CONFIG_SYSTEM_TRUSTED_KEYS="/etc/keys/ima-local-ca.pem" ``` -Test also requires loaded policy with `func=KEY_CHECK`, see example in `keycheck.policy`. - ### IMA kexec test `ima_kexec.sh` requires loaded policy which contains `measure func=KEXEC_CMDLINE`,
Signature · 1 line
2.25.1
Re: [PATCH 1/3] IMA: Update key test documentation
Hi Lachlan,
Quoted 5 lines
The current documentation for the existing IMA key test was left in by accident by a previous merge. It does not apply to the test that is currently included in the LTP.
Update the documentation for the IMA key test.
Thanks for fixing this, I propose this changes:
Quoted 19 lines
--- .../kernel/security/integrity/ima/README.md | 22 +++++-------------- 1 file changed, 5 insertions(+), 17 deletions(-)testcases/kernel/security/integrity/ima/README.md +0
-7@@ -15,27 +15,15 @@ Although a custom policy, loaded via dracut, systemd or manually from user space, may contain equivalent measurement tcb rules, detecting them would require `IMA_READ_POLICY=y` therefore ignore this option. -### IMA key import test -`ima_keys.sh` requires a x509 public key, by default in `/etc/keys/x509_ima.der` -(defined in `CONFIG_IMA_X509_PATH` kernel config option). -The key must be signed by the private key you generate. Follow these instructions: -https://manpages.ubuntu.com/manpages/disco/man1/evmctl.1.html#generate%20trusted%20keys - -The test cannot be set-up automatically because the x509 public key must be
testcases/kernel/security/integrity/ima/README.md Although a custom policy, loaded via dracut, systemd or manually from user · line 22
Quoted 10 lines
testcases/kernel/security/integrity/ima/README.md +5
-5-built into the kernel and loaded onto a trusted keyring -(e.g. `.builtin_trusted_keys`, `.secondary_trusted_keyring`). - -As well as what's required for the IMA tests, the following are also required -in the kernel configuration: +### IMA key test +`ima_keys.sh` requires a readable IMA policy, as well as a loaded policy +with `func=KEY_CHECK keyrings=...`, see example in `keycheck.policy`. + +Mandatory kernel configuration for IMA:
This "Mandatory kernel configuration for IMA:" would be in docs twice. The above one (CONFIG_INTEGRITY=y, CONFIG_IMA=y) is required for all tests. Take it that "### IMA key test" is header 3, but ## IMA tests
is header 2 (upper level).
testcases/kernel/security/integrity/ima/README.md Although a custom policy, loaded via dracut, systemd or manually from user · line 29
Quoted 12 lines
testcases/kernel/security/integrity/ima/README.md +0
-5``` CONFIG_IMA_READ_POLICY=y -CONFIG_IMA_X509_PATH="/etc/keys/x509_ima.der" -CONFIG_SYSTEM_TRUSTED_KEYRING=y -CONFIG_SYSTEM_TRUSTED_KEYS="/etc/keys/ima-local-ca.pem" ``` -Test also requires loaded policy with `func=KEY_CHECK`, see example in `keycheck.policy`. - ### IMA kexec test `ima_kexec.sh` requires loaded policy which contains `measure func=KEXEC_CMDLINE`,
I also removed "IMA" from EVM tests header.
Kind regards,
Petr
kernel/security/integrity/ima/README.md +4 -3
@@ -19,7 +19,8 @@ require `IMA_READ_POLICY=y` therefore ignore this option. `ima_keys.sh` requires a readable IMA policy, as well as a loaded policy with `func=KEY_CHECK keyrings=...`, see example in `keycheck.policy`. -Mandatory kernel configuration for IMA: +As well as what's required for the IMA tests, the following are also required +-in the kernel configuration: ``` CONFIG_IMA_READ_POLICY=y ```
@@ -38,7 +39,7 @@ To kexec a different kernel image export `IMA_KEXEC_IMAGE=<pathname>`. kernel parameter) which appraises the integrity of all files owned by root and EVM setup. Again, for simplicity ignore possibility to load requires rules via custom policy. -Mandatory kernel configuration for IMA & EVM: +Mandatory kernel configuration for EVM tests: ``` CONFIG_INTEGRITY=y CONFIG_INTEGRITY_SIGNATURE=y
@@ -50,7 +51,7 @@ CONFIG_TRUSTED_KEYS=y CONFIG_ENCRYPTED_KEYS=y ``` -Example of installing IMA + EVM on openSUSE: +Example of preparing environment on for EVM on openSUSE: * Boot install system with `ima_policy=tcb|appraise_tcb ima_appraise=fix evm=fix` kernel parameters (for IMA measurement, IMA appraisal and EVM protection)
Re: [PATCH 1/3] IMA: Update key test documentation
Hi Petr,
Thanks for updating the readme. Should I send a new patch with the changes you have proposed?
Thanks,
Lachlan
Quoted 90 lines · Petr Vorel
Hi Lachlan,
Quoted 4 lines
The current documentation for the existing IMA key test was left in by accident by a previous merge. It does not apply to the test that is currently included in the LTP. Update the documentation for the IMA key test.
Reviewed-by Petr Vorel <[email protected]>Thanks for fixing this, I propose this changes:
Fixes d2768c84e ("IMA: Add a test to verify measurement of keys")Quoted 17 lines
--- .../kernel/security/integrity/ima/README.md | 22 +++++-------------- 1 file changed, 5 insertions(+), 17 deletions(-)testcases/kernel/security/integrity/ima/README.md +0
-7@@ -15,27 +15,15 @@ Although a custom policy, loaded via dracut, systemd or manually from user space, may contain equivalent measurement tcb rules, detecting them would require `IMA_READ_POLICY=y` therefore ignore this option. -### IMA key import test -`ima_keys.sh` requires a x509 public key, by default in `/etc/keys/x509_ima.der` -(defined in `CONFIG_IMA_X509_PATH` kernel config option). -The key must be signed by the private key you generate. Follow these instructions: -https://manpages.ubuntu.com/manpages/disco/man1/evmctl.1.html#generate%20trusted%20keys - -The test cannot be set-up automatically because the x509 public key must betestcases/kernel/security/integrity/ima/README.md Although a custom policy, loaded via dracut, systemd or manually from user · line 21
Quoted 10 lines
testcases/kernel/security/integrity/ima/README.md +5
-5-built into the kernel and loaded onto a trusted keyring -(e.g. `.builtin_trusted_keys`, `.secondary_trusted_keyring`). - -As well as what's required for the IMA tests, the following are also required -in the kernel configuration: +### IMA key test +`ima_keys.sh` requires a readable IMA policy, as well as a loaded policy +with `func=KEY_CHECK keyrings=...`, see example in `keycheck.policy`. + +Mandatory kernel configuration for IMA:This "Mandatory kernel configuration for IMA:" would be in docs twice. The above one (
CONFIG_INTEGRITY=y,CONFIG_IMA=y) is required for all tests. Take it that "### IMA key test" is header 3, but ## IMA tests
is header 2 (upper level).testcases/kernel/security/integrity/ima/README.md Although a custom policy, loaded via dracut, systemd or manually from user · line 26
Quoted 10 lines
testcases/kernel/security/integrity/ima/README.md +0
-5``` CONFIG_IMA_READ_POLICY=y -CONFIG_IMA_X509_PATH="/etc/keys/x509_ima.der" -CONFIG_SYSTEM_TRUSTED_KEYRING=y -CONFIG_SYSTEM_TRUSTED_KEYS="/etc/keys/ima-local-ca.pem" ``` -Test also requires loaded policy with `func=KEY_CHECK`, see example in `keycheck.policy`. - ### IMA kexec test `ima_kexec.sh` requires loaded policy which contains `measure func=KEXEC_CMDLINE`,I also removed "IMA" from EVM tests header.
Kind regards,
Petrkernel/security/integrity/ima/README.md +4
-3@@ -19,7 +19,8 @@ require `IMA_READ_POLICY=y` therefore ignore this option. `ima_keys.sh` requires a readable IMA policy, as well as a loaded policy with `func=KEY_CHECK keyrings=...`, see example in `keycheck.policy`. -Mandatory kernel configuration for IMA: +As well as what's required for the IMA tests, the following are also required +-in the kernel configuration: ``` CONFIG_IMA_READ_POLICY=y ```@@ -38,7 +39,7 @@ To kexec a different kernel image export `IMA_KEXEC_IMAGE=<pathname>`. kernel parameter) which appraises the integrity of all files owned by root and EVM setup. Again, for simplicity ignore possibility to load requires rules via custom policy. -Mandatory kernel configuration for IMA & EVM: +Mandatory kernel configuration for EVM tests: ``` CONFIG_INTEGRITY=y CONFIG_INTEGRITY_SIGNATURE=y@@ -50,7 +51,7 @@ CONFIG_TRUSTED_KEYS=y CONFIG_ENCRYPTED_KEYS=y ``` -Example of installing IMA + EVM on openSUSE: +Example of preparing environment on for EVM on openSUSE: * Boot install system with `ima_policy=tcb|appraise_tcb ima_appraise=fix evm=fix` kernel parameters (for IMA measurement, IMA appraisal and EVM protection)
Re: [PATCH 1/3] IMA: Update key test documentation
Hi Lachlan,
Quoted 3 lines
Hi Petr,
Thanks for updating the readme. Should I send a new patch with the changes you have proposed?
No, I'll just fix it before merging this patch.
Kind regards,
Petr
Re: [PATCH 1/3] IMA: Update key test documentation
In reply to Lachlan SneffHi Lachlan,
Merged, with slightly changed text.
Sorry for introducing this error.
Forged to add Fixes: :(.
Kind regards,
Petr
PATCH 2/3 IMA: Refactor datafiles directory
In reply to Lachlan SneffThe IMA datafiles directory is structured so that it cannot be directly expanded to include datafiles for tests other than ima_policy.sh.
Move the contents of the IMA datafiles directory into an IMA datafiles/policy directory.
---
.../security/integrity/ima/datafiles/Makefile | 6 ++----
.../integrity/ima/datafiles/policy/Makefile | 15 +++++++++++++++
.../ima/datafiles/{ => policy}/kexec.policy | 0
.../ima/datafiles/{ => policy}/keycheck.policy | 0
.../ima/datafiles/{ => policy}/measure.policy | 0
.../datafiles/{ => policy}/measure.policy-invalid | 0
6 files changed, 17 insertions(+), 4 deletions(-)
create mode 100644 testcases/kernel/security/integrity/ima/datafiles/policy/Makefile
rename testcases/kernel/security/integrity/ima/datafiles/{ => policy}/kexec.policy (100%)
rename testcases/kernel/security/integrity/ima/datafiles/{ => policy}/keycheck.policy (100%)
rename testcases/kernel/security/integrity/ima/datafiles/{ => policy}/measure.policy (100%)
rename testcases/kernel/security/integrity/ima/datafiles/{ => policy}/measure.policy-invalid (100%)testcases/kernel/security/integrity/ima/datafiles/Makefile +2 -4
@@ -24,8 +24,6 @@ top_srcdir ?= ../../../../../.. include $(top_srcdir)/include/mk/env_pre.mk -INSTALL_DIR := testcases/data/ima_policy +SUBDIRS := policy -INSTALL_TARGETS := measure.policy-invalid *.policy - -include $(top_srcdir)/include/mk/generic_leaf_target.mk +include $(top_srcdir)/include/mk/generic_trunk_target.mk
testcases/kernel/security/integrity/ima/datafiles/policy/Makefile new file +15 -0
@@ -0,0 +1,15 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) 2020 Microsoft Corporation +# Author: Lachlan Sneff <[email protected]> +# +# IMA datafiles/policy Makefile + +top_srcdir ?= ../../../../../../.. + +include $(top_srcdir)/include/mk/env_pre.mk + +INSTALL_DIR := testcases/data/ima_policy + +INSTALL_TARGETS := measure.policy-invalid *.policy + +include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/security/integrity/ima/datafiles/policy/kexec.policy renamed from testcases/kernel/security/integrity/ima/datafiles/kexec.policy +0 -0
testcases/kernel/security/integrity/ima/datafiles/policy/keycheck.policy renamed from testcases/kernel/security/integrity/ima/datafiles/keycheck.policy +0 -0
testcases/kernel/security/integrity/ima/datafiles/policy/measure.policy renamed from testcases/kernel/security/integrity/ima/datafiles/measure.policy +0 -0
testcases/kernel/security/integrity/ima/datafiles/policy/measure.policy-invalid renamed from testcases/kernel/security/integrity/ima/datafiles/measure.policy-invalid +0 -0
Signature · 1 line
2.25.1
Re: [PATCH 2/3] IMA: Refactor datafiles directory
Hi Lachlan,
Quoted 5 lines
The IMA datafiles directory is structured so that it cannot be directly expanded to include datafiles for tests other than
ima_policy.sh.Move the contents of the IMA datafiles directory into an IMA datafiles/policy directory.
Why it's required? Can't you use glob for inclusion?
*.policy for valid policies
*.policy-invalid for invalid policies
*.policy* for all policies
BTW I plan to use policies for other tests than just ima_policy.sh
I don't refuse this patch, I just simply don't understand why it's required.
Kind regards,
Petr
Petr Vorel
Reviewed-byRe: [PATCH 2/3] IMA: Refactor datafiles directory
Hi Lachlan,
Quoted 8 lines
Quoted 5 lines
The IMA datafiles directory is structured so that it cannot be directly expanded to include datafiles for tests other than
ima_policy.sh.Move the contents of the IMA datafiles directory into an IMA datafiles/policy directory.
Why it's required? Can't you use glob for inclusion?
Quoted 7 lines
*.policy for valid policies
*.policy-invalid for invalid policies
*.policy* for all policiesBTW I plan to use policies for other tests than just
ima_policy.shI don't refuse this patch, I just simply don't understand why it's required.
OK, I got that. Looking into $TST_DATAROOT is self explanatory.
And I plan to use IMA policy as well for more tests will require some trick, but that's another story.
Kind regards,
Petr
Re: [PATCH 2/3] IMA: Refactor datafiles directory
Hi Lachlan,
Quoted 14 lines
Quoted 13 lines
Quoted 5 lines
The IMA datafiles directory is structured so that it cannot be directly expanded to include datafiles for tests other than
ima_policy.sh.Move the contents of the IMA datafiles directory into an IMA datafiles/policy directory.
Why it's required? Can't you use glob for inclusion?
*.policy for valid policies
*.policy-invalid for invalid policies
*.policy* for all policiesBTW I plan to use policies for other tests than just
ima_policy.sh
Quoted 7 lines
Quoted 1 line
I don't refuse this patch, I just simply don't understand why it's required.
OK, I got that. Looking into $TST_DATAROOT is self explanatory.
Reviewed-by Petr Vorel <[email protected]>And I plan to use IMA policy as well for more tests will require some trick, but that's another story.
Thinking about it twice, keycheck.policy and kexec.policy should not be in /opt/ltp/testcases/data/ima_policy/ as they belong to the their tests (ima_keys.sh resp. ima_kexec.sh). I forget where are installed due "policy" (the name of the directory).
I'll send v2 (altogether with fixes for the test) to speedup the things.
Kind regards,
Petr
PATCH 3/3 IMA: Add a test to verify measurement of certificate imported into a keyring
In reply to Lachlan SneffThe IMA subsystem supports measuring certificates that have been imported into either system built-in or user-defined keyrings. A test to verify measurement of a certificate imported into a keyring is required.
Add an IMA measurement test that verifies that an x509 certificate can be imported into a newly-created, user-defined keyring and measured correctly by the IMA subsystem.
A certificate used by the test is included in the datafiles/keys directory.
There can be restrictions on importing a certificate into a builtin trusted keyring. For example, the .ima keyring requires that imported certs be signed by a kernel private key in certain kernel configurations. For this reason, this test defines a user-defined keyring and imports a certificate into that.
--- .../kernel/security/integrity/ima/README.md | 14 ++++++ .../security/integrity/ima/datafiles/Makefile | 2 +- .../integrity/ima/datafiles/keys/Makefile | 15 ++++++ .../integrity/ima/datafiles/keys/x509_ima.der | Bin 0 -> 650 bytes .../security/integrity/ima/tests/ima_keys.sh | 44 +++++++++++++++++- 5 files changed, 72 insertions(+), 3 deletions(-) create mode 100644 testcases/kernel/security/integrity/ima/datafiles/keys/Makefile create mode 100644 testcases/kernel/security/integrity/ima/datafiles/keys/x509_ima.der
testcases/kernel/security/integrity/ima/README.md +14 -0
@@ -23,6 +23,20 @@ Mandatory kernel configuration for IMA: ``` CONFIG_IMA_READ_POLICY=y ``` +The certificate import test in `ima_keys.sh` also requires that +the `key_import_test` keyring is specified in the IMA policy. + +One way to do this is to modify an existing KEY_CHECK entry +in the IMA policy by adding `key_import_test` for keyrings: +``` +measure func=KEY_CHECK keyrings=.ima|.evm|key_import_test template=ima-buf +``` + +If KEY_CHECK entry does not exist in the IMA policy then by adding +the following line: +``` +measure func=KEY_CHECK keyrings=key_import_test template=ima-buf +``` ### IMA kexec test
testcases/kernel/security/integrity/ima/datafiles/Makefile +1 -1
@@ -24,6 +24,6 @@ top_srcdir ?= ../../../../../.. include $(top_srcdir)/include/mk/env_pre.mk -SUBDIRS := policy +SUBDIRS := policy keys include $(top_srcdir)/include/mk/generic_trunk_target.mk
testcases/kernel/security/integrity/ima/datafiles/keys/Makefile new file +15 -0
@@ -0,0 +1,15 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) 2020 Microsoft Corporation +# Author: Lachlan Sneff <[email protected]> +# +# IMA datafiles/keys Makefile + +top_srcdir ?= ../../../../../../.. + +include $(top_srcdir)/include/mk/env_pre.mk + +INSTALL_DIR := testcases/data/ima_keys + +INSTALL_TARGETS := x509_ima.der + +include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/security/integrity/ima/datafiles/keys/x509_ima.der new file binary +0 -0
testcases/kernel/security/integrity/ima/tests/ima_keys.sh +42 -2
55 lines not on this page · raw message
Signature · 1 line
2.25.1