phy ic isn't reset
Hi:
I work on one board based on at9g25evk board now. I find one issue that phy IC isn't reset, so network can't work. Only the different crystal with evk board is connected to PHY IC. I copy the phy-reset part of at9260 to at9g25. It can work now. Please the maintainer of at9gx5 check this. The modification I do is as below:
+
+#ifdef CONFIG_MACB
+int at91sam9x5ek_macb_hw_init(void)
+{
+ struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC;
+ struct at91_port *pioa = (struct at91_port *)ATMEL_BASE_PIOA;
+ struct at91_rstc *rstc = (struct at91_rstc *)ATMEL_BASE_RSTC;
+ unsigned long erstl;
+
+ /* Enable EMAC clock */
+ writel(1 << ATMEL_ID_EMAC0, &pmc->pcer);
+
+ erstl = readl(&rstc->mr) & AT91_RSTC_MR_ERSTL_MASK;
+
+ /* Need to reset PHY -> 500ms reset */
+ writel(AT91_RSTC_KEY | AT91_RSTC_MR_ERSTL(13) |
+ AT91_RSTC_MR_URSTEN, &rstc->mr);
+
+ writel(AT91_RSTC_KEY | AT91_RSTC_CR_EXTRST, &rstc->cr);
+
+ /* Wait for end hardware reset */
+ while (!(readl(&rstc->sr) & AT91_RSTC_SR_NRSTL))
+ ;
+
+ /* Restore NRST value */
+ writel(AT91_RSTC_KEY | erstl | AT91_RSTC_MR_URSTEN,
+ &rstc->mr);
+
+ at91_macb_hw_init();
+}
+#endif
Best Regards,
Alex
Hi Alex,
Quoted 6 lines · alex
Hi:
I work on one board based on at9g25evk board now. I find one issue
that phy IC isn't reset, so network can't work. Only the different crystal with evk board is connected to PHY IC. I copy the phy-reset part of at9260 to at9g25. It can work now. Please the maintainer of at9gx5 check this. The modification I do is as below:
As you mentioned, you use different crystal, please specify this in detail.
Quoted 21 lines
(quoted diff) +21
-0+ +#ifdef CONFIG_MACB +int at91sam9x5ek_macb_hw_init(void) +{ + struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC; + struct at91_port *pioa = (struct at91_port *)ATMEL_BASE_PIOA; + struct at91_rstc *rstc = (struct at91_rstc *)ATMEL_BASE_RSTC; + unsigned long erstl; + + /* Enable EMAC clock */ + writel(1 << ATMEL_ID_EMAC0, &pmc->pcer); + + erstl = readl(&rstc->mr) & AT91_RSTC_MR_ERSTL_MASK; + + /* Need to reset PHY -> 500ms reset */ + writel(AT91_RSTC_KEY | AT91_RSTC_MR_ERSTL(13) | + AT91_RSTC_MR_URSTEN, &rstc->mr); + + writel(AT91_RSTC_KEY | AT91_RSTC_CR_EXTRST, &rstc->cr); + + /* Wait for end hardware reset */
Review
Quoted 10 lines
(quoted diff) +10
-0+ while (!(readl(&rstc->sr) & AT91_RSTC_SR_NRSTL)) + ; + + /* Restore NRST value */ + writel(AT91_RSTC_KEY | erstl | AT91_RSTC_MR_URSTEN, + &rstc->mr); + + at91_macb_hw_init(); +} +#endif
On at91sam9g25ek, it don't need this patch. The network work properly.
Btw, please help provide the log information for why not ethernet doesn't work.
Best Regards,
Bo Shen
Quoted 5 lines
Best Regards,
Alex
Quoted 11 lines · At 2013-04-18 09:23:48,"Bo Shen" <[email protected]> wrote:
Hi Alex,
Quoted 6 lines · alex
Hi:
I work on one board based on at9g25evk board now. I find one issue
that phy IC isn't reset, so network can't work. Only the different crystal with evk board is connected to PHY IC. I copy the phy-reset part of at9260 to at9g25. It can work now. Please the maintainer of at9gx5 check this. The modification I do is as below:As you mentioned, you use different crystal, please specify this in detail.
S3225A package, 50Mhz crystal oscillator. ocean comonents ltd. ---> can work. asem series:ASEM1-50.000MHZ-LC-T ---->can't work.
Quoted 37 lines
Quoted 22 lines
(quoted diff) +21
-0+ +#ifdef CONFIG_MACB +int at91sam9x5ek_macb_hw_init(void) +{ + struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC; + struct at91_port *pioa = (struct at91_port *)ATMEL_BASE_PIOA; + struct at91_rstc *rstc = (struct at91_rstc *)ATMEL_BASE_RSTC; + unsigned long erstl; + + /* Enable EMAC clock */ + writel(1 << ATMEL_ID_EMAC0, &pmc->pcer); + + erstl = readl(&rstc->mr) & AT91_RSTC_MR_ERSTL_MASK; + + /* Need to reset PHY -> 500ms reset */ + writel(AT91_RSTC_KEY | AT91_RSTC_MR_ERSTL(13) | + AT91_RSTC_MR_URSTEN, &rstc->mr); + + writel(AT91_RSTC_KEY | AT91_RSTC_CR_EXTRST, &rstc->cr); + + /* Wait for end hardware reset */Review
Quoted 10 lines
(quoted diff) +10
-0+ while (!(readl(&rstc->sr) & AT91_RSTC_SR_NRSTL)) + ; + + /* Restore NRST value */ + writel(AT91_RSTC_KEY | erstl | AT91_RSTC_MR_URSTEN, + &rstc->mr); + + at91_macb_hw_init(); +} +#endifOn at91sam9g25ek, it don't need this patch. The network work properly.
Btw, please help provide the log information for why not ethernet doesn't work.
Hi Alex
Quoted 53 lines · alex
Quoted 11 lines · At 2013-04-18 09:23:48,"Bo Shen" <[email protected]> wrote:
Hi Alex,
Quoted 6 lines · alex
Hi:
I work on one board based on at9g25evk board now. I find one issue
that phy IC isn't reset, so network can't work. Only the different crystal with evk board is connected to PHY IC. I copy the phy-reset part of at9260 to at9g25. It can work now. Please the maintainer of at9gx5 check this. The modification I do is as below:As you mentioned, you use different crystal, please specify this in detail.
S3225A package, 50Mhz crystal oscillator. ocean comonents ltd. ---> can work.
asem series:ASEM1-50.000MHZ-LC-T ---->can't work.
Quoted 35 lines
Quoted 22 lines
(quoted diff) +21
-0+ +#ifdef CONFIG_MACB +int at91sam9x5ek_macb_hw_init(void) +{ + struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC; + struct at91_port *pioa = (struct at91_port *)ATMEL_BASE_PIOA; + struct at91_rstc *rstc = (struct at91_rstc *)ATMEL_BASE_RSTC; + unsigned long erstl; + + /* Enable EMAC clock */ + writel(1 << ATMEL_ID_EMAC0, &pmc->pcer); + + erstl = readl(&rstc->mr) & AT91_RSTC_MR_ERSTL_MASK; + + /* Need to reset PHY -> 500ms reset */ + writel(AT91_RSTC_KEY | AT91_RSTC_MR_ERSTL(13) | + AT91_RSTC_MR_URSTEN, &rstc->mr); + + writel(AT91_RSTC_KEY | AT91_RSTC_CR_EXTRST, &rstc->cr); + + /* Wait for end hardware reset */Review
Quoted 10 lines
(quoted diff) +10
-0+ while (!(readl(&rstc->sr) & AT91_RSTC_SR_NRSTL)) + ; + + /* Restore NRST value */ + writel(AT91_RSTC_KEY | erstl | AT91_RSTC_MR_URSTEN, + &rstc->mr); + + at91_macb_hw_init(); +} +#endifOn at91sam9g25ek, it don't need this patch. The network work properly.
Quoted 5 lines
Quoted 2 lines
Btw, please help provide the log information for why not ethernet doesn't work.
From at91sam9g25ek side, no any error. If you only plug network line , the network traffic led is always off, that is,DM9161AEP doesn't check this change.
Even if I add this patch, no any defect, right?
I won't suggest do like this, if you use reset controller, it will assert nRST pin. If one more device use nRST, it will also reset other device. if only PHY use nRST and no other consideration, I think it is OK.
Best Regards,
Bo Shen
Quoted 20 lines · At 2013-04-18 14:32:52,"Bo Shen" <[email protected]> wrote:
Hi Alex
Quoted 17 lines · alex
Quoted 11 lines · At 2013-04-18 09:23:48,"Bo Shen" <[email protected]> wrote:
Hi Alex,
Quoted 6 lines · alex
Hi:
I work on one board based on at9g25evk board now. I find one issue
that phy IC isn't reset, so network can't work. Only the different crystal with evk board is connected to PHY IC. I copy the phy-reset part of at9260 to at9g25. It can work now. Please the maintainer of at9gx5 check this. The modification I do is as below:As you mentioned, you use different crystal, please specify this in detail.
S3225A package, 50Mhz crystal oscillator. ocean comonents ltd. ---> can work.
asem series:ASEM1-50.000MHZ-LC-T ---->can't work.
More information. asem crystal: only plug the network line, and then powerup, it can work.
Quoted 39 lines
Quoted 39 lines
Quoted 38 lines
Quoted 23 lines
(quoted diff) +21
-0+ +#ifdef CONFIG_MACB +int at91sam9x5ek_macb_hw_init(void) +{ + struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC; + struct at91_port *pioa = (struct at91_port *)ATMEL_BASE_PIOA; + struct at91_rstc *rstc = (struct at91_rstc *)ATMEL_BASE_RSTC; + unsigned long erstl; + + /* Enable EMAC clock */ + writel(1 << ATMEL_ID_EMAC0, &pmc->pcer); + + erstl = readl(&rstc->mr) & AT91_RSTC_MR_ERSTL_MASK; + + /* Need to reset PHY -> 500ms reset */ + writel(AT91_RSTC_KEY | AT91_RSTC_MR_ERSTL(13) | + AT91_RSTC_MR_URSTEN, &rstc->mr); + + writel(AT91_RSTC_KEY | AT91_RSTC_CR_EXTRST, &rstc->cr); + + /* Wait for end hardware reset */Review
Quoted 10 lines
(quoted diff) +10
-0+ while (!(readl(&rstc->sr) & AT91_RSTC_SR_NRSTL)) + ; + + /* Restore NRST value */ + writel(AT91_RSTC_KEY | erstl | AT91_RSTC_MR_URSTEN, + &rstc->mr); + + at91_macb_hw_init(); +} +#endifOn at91sam9g25ek, it don't need this patch. The network work properly.
Btw, please help provide the log information for why not ethernet doesn't work.
Quoted 6 lines
Quoted 2 lines
From at91sam9g25ek side, no any error. If you only plug network line , the network traffic led is always off, that is,DM9161AEP doesn't check this change.
Even if I add this patch, no any defect, right?I won't suggest do like this, if you use reset controller, it will assert nRST pin. If one more device use nRST, it will also reset other device. if only PHY use nRST and no other consideration, I think it is OK.
On my board, only PHY use nRST.
Understand, and thanks for your reply.
Quoted 4 lines
Best Regards,
Bo Shen
Dear Bo Shen,
Quoted 62 lines · Bo Shen
Hi Alex
Quoted 59 lines · alex
Quoted 11 lines · At 2013-04-18 09:23:48,"Bo Shen" <[email protected]> wrote:
Hi Alex,
Quoted 7 lines · alex
Hi:
I work on one board based on at9g25evk board now. I find one issue
that phy IC isn't reset, so network can't work. Only the different crystal with evk board is connected to PHY IC. I copy the phy-reset part
of at9260 to at9g25. It can work now. Please the maintainer of at9gx5 check this. The modification I do is as below:Quoted 2 lines
As you mentioned, you use different crystal, please specify this in detail.
S3225A package, 50Mhz crystal oscillator. ocean comonents ltd. ---> can work.
asem series:ASEM1-50.000MHZ-LC-T ---->can't work.
Quoted 37 lines
Quoted 22 lines
(quoted diff) +21
-0+ +#ifdef CONFIG_MACB +int at91sam9x5ek_macb_hw_init(void) +{ + struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC; + struct at91_port *pioa = (struct at91_port *)ATMEL_BASE_PIOA; + struct at91_rstc *rstc = (struct at91_rstc *)ATMEL_BASE_RSTC; + unsigned long erstl; + + /* Enable EMAC clock */ + writel(1 << ATMEL_ID_EMAC0, &pmc->pcer); + + erstl = readl(&rstc->mr) & AT91_RSTC_MR_ERSTL_MASK; + + /* Need to reset PHY -> 500ms reset */ + writel(AT91_RSTC_KEY | AT91_RSTC_MR_ERSTL(13) | + AT91_RSTC_MR_URSTEN, &rstc->mr); + + writel(AT91_RSTC_KEY | AT91_RSTC_CR_EXTRST, &rstc->cr); + + /* Wait for end hardware reset */Review
Quoted 10 lines
(quoted diff) +10
-0+ while (!(readl(&rstc->sr) & AT91_RSTC_SR_NRSTL)) + ; + + /* Restore NRST value */ + writel(AT91_RSTC_KEY | erstl | AT91_RSTC_MR_URSTEN, + &rstc->mr); + + at91_macb_hw_init(); +} +#endifOn at91sam9g25ek, it don't need this patch. The network work properly.
Btw, please help provide the log information for why not ethernet doesn't work.
Quoted 8 lines
Quoted 4 lines
From at91sam9g25ek side, no any error. If you only plug network line
, the network traffic led is always off, that is,DM9161AEP doesn't check this change.
Even if I add this patch, no any defect, right?I won't suggest do like this, if you use reset controller, it will assert nRST pin. If one more device use nRST, it will also reset other device. if only PHY use nRST and no other consideration, I think it is OK.
I would like to point out that older atmel eval kits use this trick heavily. This is due to missing pullup/pulldown on the board, therefore it is required to setup some gpio first and then issue a reset (again) to the PHY cause it is misconfigured. Maybe this can also be esablished with some (R)MII communication, but thats how it is implemented currently.
Regarding the crystal, what is the root cause of your issue? Does it not oscillate or is your PHY 'mis-configured' in means of wrong initial setup on configuration lines?
In both cases I recommend to find a HW solution for the final product.
Best regards
Andreas Bie?mann
Hi Andreas,
Quoted 74 lines · Andreas Bie?mann
Dear Bo Shen,
Quoted 62 lines · Bo Shen
Hi Alex
Quoted 59 lines · alex
Quoted 11 lines · At 2013-04-18 09:23:48,"Bo Shen" <[email protected]> wrote:
Hi Alex,
Quoted 7 lines · alex
Hi:
I work on one board based on at9g25evk board now. I find one issue
that phy IC isn't reset, so network can't work. Only the different crystal with evk board is connected to PHY IC. I copy the phy-reset part
of at9260 to at9g25. It can work now. Please the maintainer of at9gx5 check this. The modification I do is as below:Quoted 2 lines
As you mentioned, you use different crystal, please specify this in detail.
S3225A package, 50Mhz crystal oscillator. ocean comonents ltd. ---> can work.
asem series:ASEM1-50.000MHZ-LC-T ---->can't work.
Quoted 37 lines
Quoted 22 lines
(quoted diff) +21
-0+ +#ifdef CONFIG_MACB +int at91sam9x5ek_macb_hw_init(void) +{ + struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC; + struct at91_port *pioa = (struct at91_port *)ATMEL_BASE_PIOA; + struct at91_rstc *rstc = (struct at91_rstc *)ATMEL_BASE_RSTC; + unsigned long erstl; + + /* Enable EMAC clock */ + writel(1 << ATMEL_ID_EMAC0, &pmc->pcer); + + erstl = readl(&rstc->mr) & AT91_RSTC_MR_ERSTL_MASK; + + /* Need to reset PHY -> 500ms reset */ + writel(AT91_RSTC_KEY | AT91_RSTC_MR_ERSTL(13) | + AT91_RSTC_MR_URSTEN, &rstc->mr); + + writel(AT91_RSTC_KEY | AT91_RSTC_CR_EXTRST, &rstc->cr); + + /* Wait for end hardware reset */Review
Quoted 10 lines
(quoted diff) +10
-0+ while (!(readl(&rstc->sr) & AT91_RSTC_SR_NRSTL)) + ; + + /* Restore NRST value */ + writel(AT91_RSTC_KEY | erstl | AT91_RSTC_MR_URSTEN, + &rstc->mr); + + at91_macb_hw_init(); +} +#endifOn at91sam9g25ek, it don't need this patch. The network work properly.
Btw, please help provide the log information for why not ethernet doesn't work.
Quoted 8 lines
Quoted 4 lines
From at91sam9g25ek side, no any error. If you only plug network line
, the network traffic led is always off, that is,DM9161AEP doesn't check this change.
Even if I add this patch, no any defect, right?I won't suggest do like this, if you use reset controller, it will assert nRST pin. If one more device use nRST, it will also reset other device. if only PHY use nRST and no other consideration, I think it is OK.
Quoted 5 lines
I would like to point out that older atmel eval kits use this trick heavily. This is due to missing pullup/pulldown on the board, therefore it is required to setup some gpio first and then issue a reset (again) to the PHY cause it is misconfigured. Maybe this can also be esablished with some (R)MII communication, but thats how it is implemented currently.
Thanks for this information.
Quoted 4 lines
Regarding the crystal, what is the root cause of your issue? Does it not oscillate or is your PHY 'mis-configured' in means of wrong initial setup on configuration lines?
In both cases I recommend to find a HW solution for the final product.
Hi Alex,
Please check your issue according to Andreas' suggestion. And try to
fix it through HW solution.
Best Regards,
Bo Shen
Quoted 4 lines
Best regards
Andreas Bie?mann