dt-bindings: iommu: Fix interrupt type in example
Subsystems (3)
PATCH 1/2 dt-bindings: iommu: Fix interrupt type in example
The CMDQV interrupt on Tegra264 is edge-triggered per the hardware interrupt documentation, but the binding example describes it as level-triggered. Correct the example to use IRQ_TYPE_EDGE_RISING so that it does not propagate the wrong trigger type.
--- .../devicetree/bindings/iommu/nvidia,tegra264-cmdqv.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/iommu/nvidia,tegra264-cmdqv.yaml +1 -1
@@ -38,5 +38,5 @@ examples: cmdqv@5200000 { compatible = "nvidia,tegra264-cmdqv"; reg = <0x5200000 0x830000>; - interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 19 IRQ_TYPE_EDGE_RISING>; };
Signature · 1 line
2.50.1
PATCH 2/2 arm64: tegra: Fix CMDQV interrupt type on Tegra264
The CMDQV interrupts on Tegra264 are described as level-triggered, but per the hardware interrupt documentation these interrupts are actually edge-triggered.
Correct the interrupt type for all CMDQV nodes from IRQ_TYPE_LEVEL_HIGH to IRQ_TYPE_EDGE_RISING.
--- arch/arm64/boot/dts/nvidia/tegra264.dtsi | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/nvidia/tegra264.dtsi +5 -5
@@ -3393,7 +3393,7 @@ smmu1: iommu@5000000 { cmdqv1: cmdqv@5200000 { compatible = "nvidia,tegra264-cmdqv"; reg = <0x00 0x5200000 0x0 0x830000>; - interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 19 IRQ_TYPE_EDGE_RISING>; status = "disabled"; };
@@ -3413,7 +3413,7 @@ smmu2: iommu@6000000 { cmdqv2: cmdqv@6200000 { compatible = "nvidia,tegra264-cmdqv"; reg = <0x00 0x6200000 0x0 0x830000>; - interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 8 IRQ_TYPE_EDGE_RISING>; status = "disabled"; };
@@ -3486,7 +3486,7 @@ smmu0: iommu@a000000 { cmdqv0: cmdqv@a200000 { compatible = "nvidia,tegra264-cmdqv"; reg = <0x00 0xa200000 0x0 0x830000>; - interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 28 IRQ_TYPE_EDGE_RISING>; status = "disabled"; };
@@ -3506,7 +3506,7 @@ smmu4: iommu@b000000 { cmdqv4: cmdqv@b200000 { compatible = "nvidia,tegra264-cmdqv"; reg = <0x00 0xb200000 0x0 0x830000>; - interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 37 IRQ_TYPE_EDGE_RISING>; status = "disabled"; };
@@ -3831,7 +3831,7 @@ smmu3: iommu@6000000 { cmdqv3: cmdqv@6200000 { compatible = "nvidia,tegra264-cmdqv"; reg = <0x00 0x6200000 0x0 0x830000>; - interrupts = <GIC_SPI 232 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 232 IRQ_TYPE_EDGE_RISING>; status = "disabled"; };
Signature · 1 line
2.50.1
Re: [PATCH 2/2] arm64: tegra: Fix CMDQV interrupt type on Tegra264
Quoted 10 lines · Ashish Mhetre
The CMDQV interrupts on Tegra264 are described as level-triggered, but per the hardware interrupt documentation these interrupts are actually edge-triggered.
Correct the interrupt type for all CMDQV nodes from
IRQ_TYPE_LEVEL_HIGHtoIRQ_TYPE_EDGE_RISING.Fixes fe57d0ac4835 ("arm64: tegra: Add nodes for CMDQV")Reported-by Nicolin Chen <[email protected]>Signed-off-by Ashish Mhetre <[email protected]>
Re: [PATCH 2/2] arm64: tegra: Fix CMDQV interrupt type on Tegra264
In reply to Ashish MhetreQuoted 55 lines · Ashish Mhetre
The CMDQV interrupts on Tegra264 are described as level-triggered, but per the hardware interrupt documentation these interrupts are actually edge-triggered.
Correct the interrupt type for all CMDQV nodes from
IRQ_TYPE_LEVEL_HIGHtoIRQ_TYPE_EDGE_RISING.Fixes fe57d0ac4835 ("arm64: tegra: Add nodes for CMDQV")Reported-by Nicolin Chen <[email protected]>Signed-off-by Ashish Mhetre <[email protected]>--- arch/arm64/boot/dts/nvidia/tegra264.dtsi | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)arch/arm64/boot/dts/nvidia/tegra264.dtsi +4
-4@@ -3393,7 +3393,7 @@ smmu1: iommu@5000000 { cmdqv1: cmdqv@5200000 { compatible = "nvidia,tegra264-cmdqv"; reg = <0x00 0x5200000 0x0 0x830000>; - interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 19 IRQ_TYPE_EDGE_RISING>; status = "disabled"; };@@ -3413,7 +3413,7 @@ smmu2: iommu@6000000 { cmdqv2: cmdqv@6200000 { compatible = "nvidia,tegra264-cmdqv"; reg = <0x00 0x6200000 0x0 0x830000>; - interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 8 IRQ_TYPE_EDGE_RISING>; status = "disabled"; };@@ -3486,7 +3486,7 @@ smmu0: iommu@a000000 { cmdqv0: cmdqv@a200000 { compatible = "nvidia,tegra264-cmdqv"; reg = <0x00 0xa200000 0x0 0x830000>; - interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 28 IRQ_TYPE_EDGE_RISING>; status = "disabled"; };@@ -3506,7 +3506,7 @@ smmu4: iommu@b000000 { cmdqv4: cmdqv@b200000 { compatible = "nvidia,tegra264-cmdqv"; reg = <0x00 0xb200000 0x0 0x830000>; - interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 37 IRQ_TYPE_EDGE_RISING>; status = "disabled"; };
arch/arm64/boot/dts/nvidia/tegra264.dtsi smmu3: iommu@6000000 { · line 3837
Quoted 8 lines
arch/arm64/boot/dts/nvidia/tegra264.dtsi +1
-1@@ -3831,7 +3831,7 @@ smmu3: iommu@6000000 { cmdqv3: cmdqv@6200000 { compatible = "nvidia,tegra264-cmdqv"; reg = <0x00 0x6200000 0x0 0x830000>; - interrupts = <GIC_SPI 232 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 232 IRQ_TYPE_EDGE_RISING>; status = "disabled"; };
Thanks!
Jon
Signature · 1 line
nvpublic
pw-bot: not-applicable
Quoted 8 lines · Ashish Mhetre
The CMDQV interrupt on Tegra264 is edge-triggered per the hardware interrupt documentation, but the binding example describes it as level-triggered. Correct the example to use
IRQ_TYPE_EDGE_RISINGso that it does not propagate the wrong trigger type.Fixes 8a59954192eb ("dt-bindings: iommu: Add NVIDIA Tegra CMDQV support")Reported-by Nicolin Chen <[email protected]>Signed-off-by Ashish Mhetre <[email protected]>
Quoted 17 lines · Ashish Mhetre
The CMDQV interrupt on Tegra264 is edge-triggered per the hardware interrupt documentation, but the binding example describes it as level-triggered. Correct the example to use
IRQ_TYPE_EDGE_RISINGso that it does not propagate the wrong trigger type.Fixes 8a59954192eb ("dt-bindings: iommu: Add NVIDIA Tegra CMDQV support")Reported-by Nicolin Chen <[email protected]>Signed-off-by Ashish Mhetre <[email protected]>--- .../devicetree/bindings/iommu/nvidia,tegra264-cmdqv.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/iommu/nvidia,tegra264-cmdqv.yaml +0
-0
Documentation/devicetree/bindings/iommu/nvidia,tegra264-cmdqv.yaml examples: · line 42
Quoted 6 lines
Documentation/devicetree/bindings/iommu/nvidia,tegra264-cmdqv.yaml +1
-1@@ -38,5 +38,5 @@ examples: cmdqv@5200000 { compatible = "nvidia,tegra264-cmdqv"; reg = <0x5200000 0x830000>; - interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 19 IRQ_TYPE_EDGE_RISING>; };
Thanks!
Jon
Signature · 1 line
nvpublic
Re: (subset) [PATCH 1/2] dt-bindings: iommu: Fix interrupt type in example
In reply to Ashish MhetreFrom: Thierry Reding <[email protected]>
Quoted 4 lines · Ashish Mhetre
The CMDQV interrupt on Tegra264 is edge-triggered per the hardware interrupt documentation, but the binding example describes it as level-triggered. Correct the example to use
IRQ_TYPE_EDGE_RISINGso that it does not propagate the wrong trigger type.
Applied, thanks!
[2/2] arm64: tegra: Fix CMDQV interrupt type on Tegra264
commit: e70af6a126e172274d9e6459d80438a46d4455f3
Best regards,
Signature · 1 line
Thierry Reding <[email protected]>
Will Deacon
maintainerQuoted 6 lines · Ashish Mhetre
The CMDQV interrupt on Tegra264 is edge-triggered per the hardware interrupt documentation, but the binding example describes it as level-triggered. Correct the example to use
IRQ_TYPE_EDGE_RISINGso that it does not propagate the wrong trigger type.
Applied bindings update to iommu (arm/smmu/bindings), thanks!
[1/2] dt-bindings: iommu: Fix interrupt type in example
https://git.kernel.org/iommu/c/20df8037968d
Cheers,
Signature · 5 lines
Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev