Skip to contentSkip to conversation

virtio_ring: boolean values to a bool variable

PATCH In review Jiapeng Zhong 3 participants 3 messages Jan 15, 2021 – May 3, 2021 virtio core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio_ring: boolean values to a bool variable

Fix the following coccicheck warnings:

./drivers/virtio/virtio_ring.c:1637:1-29: WARNING: Assignment of 0/1 to bool variable.

./drivers/virtio/virtio_ring.c:1636:1-30: WARNING: Assignment of 0/1 to bool variable.

---
 drivers/virtio/virtio_ring.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/virtio/virtio_ring.c +2 -2
index 71e16b5..5adb361 100644
@@ -1633,8 +1633,8 @@ static struct virtqueue *vring_create_virtqueue_packed(
 	vq->packed.vring.device = device;
 
 	vq->packed.next_avail_idx = 0;
-	vq->packed.avail_wrap_counter = 1;
-	vq->packed.used_wrap_counter = 1;
+	vq->packed.avail_wrap_counter = true;
+	vq->packed.used_wrap_counter = true;
 	vq->packed.event_flags_shadow = 0;
 	vq->packed.avail_used_flags = 1 << VRING_PACKED_DESC_F_AVAIL;
 
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 10 lines · Jiapeng Zhong

Fix the following coccicheck warnings:

./drivers/virtio/virtio_ring.c:1637:1-29: WARNING: Assignment of 0/1 to bool variable.

./drivers/virtio/virtio_ring.c:1636:1-30: WARNING: Assignment of 0/1 to bool variable.

It looks to me it's not the only places:

git grep avail_wrap_counter
drivers/virtio/virtio_ring.c:                   bool avail_wrap_counter; drivers/virtio/virtio_ring.c: vq->packed.avail_wrap_counter ^= 1; drivers/virtio/virtio_ring.c: vq->packed.avail_wrap_counter ^= 1; drivers/virtio/virtio_ring.c:   if (wrap_counter != vq->packed.avail_wrap_counter) drivers/virtio/virtio_ring.c:   vq->packed.avail_wrap_counter = 1;

Thanks

Quoted 9 lines
---
  drivers/virtio/virtio_ring.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/virtio/virtio_ring.c +0 -0
index 71e16b5..5adb361 100644

drivers/virtio/virtio_ring.c static struct virtqueue *vring_create_virtqueue_packed( · line 1640

Quoted 10 lines
drivers/virtio/virtio_ring.c +2 -2
@@ -1633,8 +1633,8 @@ static struct virtqueue *vring_create_virtqueue_packed(
  	vq->packed.vring.device = device;
 
  	vq->packed.next_avail_idx = 0;
-	vq->packed.avail_wrap_counter = 1;
-	vq->packed.used_wrap_counter = 1;
+	vq->packed.avail_wrap_counter = true;
+	vq->packed.used_wrap_counter = true;
  	vq->packed.event_flags_shadow = 0;
  	vq->packed.avail_used_flags = 1 << VRING_PACKED_DESC_F_AVAIL;
 

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

#2 lore raw
Quoted 24 lines · Jason Wang
Quoted 10 lines · Jiapeng Zhong

Fix the following coccicheck warnings:

./drivers/virtio/virtio_ring.c:1637:1-29: WARNING: Assignment of 0/1 to bool variable.

./drivers/virtio/virtio_ring.c:1636:1-30: WARNING: Assignment of 0/1 to bool variable.

It looks to me it's not the only places:

git grep avail_wrap_counter
drivers/virtio/virtio_ring.c:                   bool avail_wrap_counter; drivers/virtio/virtio_ring.c: vq->packed.avail_wrap_counter ^= 1; drivers/virtio/virtio_ring.c: vq->packed.avail_wrap_counter ^= 1; drivers/virtio/virtio_ring.c:   if (wrap_counter != vq->packed.avail_wrap_counter)
drivers/virtio/virtio_ring.c:   vq->packed.avail_wrap_counter = 1;

Quoted 1 line

Thanks

Agreed if we are doing this let's change them all.

Quoted 5 lines
Quoted 5 lines
---
  drivers/virtio/virtio_ring.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 13 lines

drivers/virtio/virtio_ring.c static struct virtqueue *vring_create_virtqueue_packed( · line 1638

Quoted 13 lines
drivers/virtio/virtio_ring.c +2 -2
index 71e16b5..5adb361 100644
@@ -1633,8 +1633,8 @@ static struct virtqueue *vring_create_virtqueue_packed(
  	vq->packed.vring.device = device;
  	vq->packed.next_avail_idx = 0;
-	vq->packed.avail_wrap_counter = 1;
-	vq->packed.used_wrap_counter = 1;
+	vq->packed.avail_wrap_counter = true;
+	vq->packed.used_wrap_counter = true;
  	vq->packed.event_flags_shadow = 0;
  	vq->packed.avail_used_flags = 1 << VRING_PACKED_DESC_F_AVAIL;

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization