Skip to contentSkip to conversation

ARM: dts: exynos4x12-pinctrl: Correct pin configuration of SD 4

PATCH New Shirish S 3 participants 3 messages Feb 11, 2013 – Feb 12, 2013

Subsystems (2)
lore
Share & tools
lore

Shirish S

author
#0 lore raw

PATCH 1/1 ARM: dts: exynos4x12-pinctrl: Correct pin configuration of SD 4

This patch corrects the pin function value of sd4_bus8 from 3 to 4.
This is verified on origen board for testing eMMC on dw_mci controller.

---
 arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4x12-pinctrl.dtsi +1 -1
index 8e6115a..099cec7 100644
@@ -661,7 +661,7 @@
 
 		sd4_bus8: sd4-bus-width8 {
 			samsung,pins = "gpk1-3", "gpk1-4", "gpk1-5", "gpk1-6";
-			samsung,pin-function = <3>;
+			samsung,pin-function = <4>;
 			samsung,pin-pud = <4>;
 			samsung,pin-drv = <3>;
 		};
Signature · 1 line
1.8.0
#1 lore raw

PATCH 1/1 ARM: dts: exynos4x12-pinctrl: Correct pin configuration of SD 4

Quoted 17 lines · On Monday 11 of February 2013 05:21:13 Shirish S wrote:

This patch corrects the pin function value of sd4_bus8 from 3 to 4.
This is verified on origen board for testing eMMC on dw_mci controller.

---
 arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi index 8e6115a..099cec7 100644

arch/arm/boot/dts/exynos4x12-pinctrl.dtsi line 667

Quoted 8 lines
arch/arm/boot/dts/exynos4x12-pinctrl.dtsi +1 -1
@@ -661,7 +661,7 @@
 
 		sd4_bus8: sd4-bus-width8 {
 			samsung,pins = "gpk1-3", "gpk1-4", "gpk1-5", "gpk1-6";
-			samsung,pin-function = <3>;
+			samsung,pin-function = <4>;
 			samsung,pin-pud = <4>;
 			samsung,pin-drv = <3>;
 		};

Best regards,

Signature · 3 lines
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform
Applied
#2 lore raw

PATCH 1/1 ARM: dts: exynos4x12-pinctrl: Correct pin configuration of SD 4

Quoted 23 lines · Tomasz Figa
Quoted 17 lines · On Monday 11 of February 2013 05:21:13 Shirish S wrote:

This patch corrects the pin function value of sd4_bus8 from 3 to 4.
This is verified on origen board for testing eMMC on dw_mci controller.

---
 arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi index 8e6115a..099cec7 100644

arch/arm/boot/dts/exynos4x12-pinctrl.dtsi line 663

Quoted 3 lines
arch/arm/boot/dts/exynos4x12-pinctrl.dtsi +0 -0
@@ -661,7 +661,7 @@
 
 		sd4_bus8: sd4-bus-width8 {
 			samsung,pins = "gpk1-3", "gpk1-4", "gpk1-5", "gpk1-

6";

Quoted 8 lines

arch/arm/boot/dts/exynos4x12-pinctrl.dtsi line 667

Quoted 5 lines
arch/arm/boot/dts/exynos4x12-pinctrl.dtsi +1 -1
-			samsung,pin-function = <3>;
+			samsung,pin-function = <4>;
 			samsung,pin-pud = <4>;
 			samsung,pin-drv = <3>;
 		};

Applied into next/fixes-samsung for v3.9 because this is not a critical bug fix.

BTW, I'd preferred to use 'ARM: dts: .... for exynos4x12-pinctrl' in subject because if we use the title like "ARM: dts: exynos4x12-pinctrl: ...", the main description should be moved back and head of subject is a bit long. So sometimes we cannot understand the title in the e-mail box before checking/opening the patch. See below.

Shirish S [PATCH] ARM: dts: exynos4x12-pinctrl: Correct pin...
Mon/2/11/2013 ...
Shirish S [PATCH] ARM: dts: Correct pin configuration of SD...
Mon/2/11/2013 ...

Thanks.

- Kukjin