Skip to contentSkip to conversation

Multicolor Framework (array edition)

PATCH Superseded Dan Murphy 3 participants 44 messages Apr 23, 2020 – Apr 28, 2020

Subsystems (4)

v20 of 33 Superseded Latest is v33 →

lore
Share & tools
lore

Dan Murphy

author
#0 lore raw

v20 cover Multicolor Framework (array edition)

This is the multi color LED framework. This framework presents clustered
colored LEDs into an array and allows the user space to adjust the brightness of the cluster using a single file write. The individual colored LEDs intensities are controlled via a single file that is an array of LEDs

A design alternative to having files that have multiple values written to a single file is here:

https://lore.kernel.org/patchwork/patch/1186194/*

Dan Murphy (17):
dt: bindings: Add multicolor class dt bindings documention
leds: Add multicolor ID to the color ID list
leds: multicolor: Introduce a multicolor class definition
dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers
leds: lp50xx: Add the LP50XX family of the RGB LED driver
dt: bindings: lp55xx: Be consistent in the document with LED acronym
dt: bindings: lp55xx: Update binding for Multicolor Framework
ARM: dts: n900: Add reg property to the LP5523 channel node
ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node
ARM: dts: ste-href: Add reg property to the LP5521 channel nodes
leds: lp55xx: Convert LED class registration to devm_*
leds: lp55xx: Add multicolor framework support to lp55xx
leds: lp5523: Update the lp5523 code to add multicolor brightness
function
leds: lp5521: Add multicolor framework multicolor brightness support
leds: lp55xx: Fix checkpatch file permissions issues
leds: lp5523: Fix checkpatch issues in the code
dt: bindings: Update lp55xx binding to recommended LED naming

 .../ABI/testing/sysfs-class-led-multicolor    |  42 +
 .../bindings/leds/leds-class-multicolor.txt   |  98 +++
 .../devicetree/bindings/leds/leds-lp50xx.txt  | 148 ++++
 .../devicetree/bindings/leds/leds-lp55xx.txt  | 163 +++-
 Documentation/leds/index.rst                  |   1 +
 Documentation/leds/leds-class-multicolor.rst  |  92 +++
 arch/arm/boot/dts/imx6dl-yapp4-common.dtsi    |  14 +-
 arch/arm/boot/dts/omap3-n900.dts              |  29 +-
 arch/arm/boot/dts/ste-href.dtsi               |  22 +-
 drivers/leds/Kconfig                          |  22 +
 drivers/leds/Makefile                         |   2 +
 drivers/leds/led-class-multicolor.c           | 206 +++++
 drivers/leds/led-core.c                       |   1 +
 drivers/leds/leds-lp50xx.c                    | 778 ++++++++++++++++++
 drivers/leds/leds-lp5521.c                    |  43 +-
 drivers/leds/leds-lp5523.c                    |  62 +-
 drivers/leds/leds-lp5562.c                    |  22 +-
 drivers/leds/leds-lp55xx-common.c             | 213 +++--
 drivers/leds/leds-lp55xx-common.h             |  13 +-
 drivers/leds/leds-lp8501.c                    |  23 +-
 include/dt-bindings/leds/common.h             |   3 +-
 include/linux/led-class-multicolor.h          | 121 +++
 include/linux/platform_data/leds-lp55xx.h     |   8 +
 23 files changed, 1968 insertions(+), 158 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-class-led-multicolor
 create mode 100644 Documentation/devicetree/bindings/leds/leds-class-multicolor.txt
 create mode 100644 Documentation/devicetree/bindings/leds/leds-lp50xx.txt
 create mode 100644 Documentation/leds/leds-class-multicolor.rst
 create mode 100644 drivers/leds/led-class-multicolor.c
 create mode 100644 drivers/leds/leds-lp50xx.c
 create mode 100644 include/linux/led-class-multicolor.h
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH v20 1/17 dt: bindings: Add multicolor class dt bindings documention

Add DT bindings for the LEDs multicolor class framework. Add multicolor ID to the color ID list for device tree bindings.

---

v20 - Squashed Patch 1 and 2 from v19 into a single patch

 .../bindings/leds/leds-class-multicolor.txt   | 98 +++++++++++++++++++
 include/dt-bindings/leds/common.h             |  3 +-
 2 files changed, 100 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-class-multicolor.txt
Documentation/devicetree/bindings/leds/leds-class-multicolor.txt new file +98 -0
new file mode 100644
index 000000000000..4b1bd82f2a42
@@ -0,0 +1,98 @@
+* Multicolor LED properties
+
+Bindings for multi color LEDs show how to describe current outputs of
+either integrated multi-color LED elements (like RGB, RGBW, RGBWA-UV
+etc.) or standalone LEDs, to achieve logically grouped multi-color LED
+modules. This is achieved by adding multi-led nodes layer to the
+monochrome LED bindings.
+
+The nodes and properties defined in this document are unique to the multicolor
+LED class.  Common LED nodes and properties are inherited from the common.txt
+within this documentation directory.
+
+Required LED child properties:
+	- color : For multicolor LED support this property should be defined as
+		  LED_COLOR_ID_MULTI and further definition can be found in
+		  include/linux/leds/common.h.
+
+led-controller@30 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	compatible = "ti,lp5024";
+	reg = <0x29>;
+
+	multi-led@1 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <1>;
+		color = <LED_COLOR_ID_MULTI>;
+		function = LED_FUNCTION_CHARGING;
+
+
+		led@3 {
+			reg = <3>;
+			color = <LED_COLOR_ID_RED>;
+		};
+
+		led@4 {
+			reg = <4>;
+			color = <LED_COLOR_ID_GREEN>;
+		};
+
+		led@5 {
+			reg = <5>;
+			color = <LED_COLOR_ID_BLUE>;
+		};
+	};
+
+	multi-led@2 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		color = <LED_COLOR_ID_MULTI>;
+		function = LED_FUNCTION_ACTIVITY;
+		reg = <2>;
+		ti,led-bank = <2 3 5>;
+
+		led@6 {
+			reg = <0x6>;
+			color = <LED_COLOR_ID_RED>;
+			led-sources = <6 9 15>;
+		};
+
+		led@7 {
+			reg = <0x7>;
+			color = <LED_COLOR_ID_GREEN>;
+			led-sources = <7 10 16>;
+		};
+
+		led@8 {
+			reg = <0x8>;
+			color = <LED_COLOR_ID_BLUE>;
+			led-sources = <8 11 17>;
+		};
+	};
+
+	multi-led@4 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <4>;
+		color = <LED_COLOR_ID_MULTI>;
+		function = LED_FUNCTION_ACTIVITY;
+
+		led@12 {
+			reg = <12>;
+			color = <LED_COLOR_ID_RED>;
+		};
+
+		led@13 {
+			reg = <13>;
+			color = <LED_COLOR_ID_GREEN>;
+		};
+
+		led@14 {
+			reg = <14>;
+			color = <LED_COLOR_ID_BLUE>;
+		};
+	};
+
+};
include/dt-bindings/leds/common.h +2 -1
index 0ce7dfc00dcb..a463ce6a8794 100644
@@ -30,7 +30,8 @@
 #define LED_COLOR_ID_VIOLET	5
 #define LED_COLOR_ID_YELLOW	6
 #define LED_COLOR_ID_IR		7
-#define LED_COLOR_ID_MAX	8
+#define LED_COLOR_ID_MULTI	8
+#define LED_COLOR_ID_MAX	9
 
 /* Standard LED functions */
 /* Keyboard LEDs, usually it would be input4::capslock etc. */
Signature · 1 line
2.25.1
author
#2 lore raw

PATCH v20 2/17 leds: Add multicolor ID to the color ID list

In reply to Dan Murphy

Add a new color ID that is declared as MULTICOLOR as with the multicolor framework declaring a definitive color is not accurate as the node can contain multiple colors.

---
 drivers/leds/led-core.c | 1 +
 1 file changed, 1 insertion(+)
drivers/leds/led-core.c +1 -0
index f1f718dbe0f8..846248a0693d 100644
@@ -34,6 +34,7 @@ const char * const led_colors[LED_COLOR_ID_MAX] = {
 	[LED_COLOR_ID_VIOLET] = "violet",
 	[LED_COLOR_ID_YELLOW] = "yellow",
 	[LED_COLOR_ID_IR] = "ir",
+	[LED_COLOR_ID_MULTI] = "multicolor",
 };
 EXPORT_SYMBOL_GPL(led_colors);
 
Signature · 1 line
2.25.1
#3 lore raw

Re: [PATCH v20 02/17] leds: Add multicolor ID to the color ID list

Quoted 5 lines · Dan Murphy

Add a new color ID that is declared as MULTICOLOR as with the multicolor framework declaring a definitive color is not accurate as the node can contain multiple colors.

Please merge with previous patch, and you can keep reviews.

Thanks,

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
author
#4 lore raw

Re: [PATCH v20 02/17] leds: Add multicolor ID to the color ID list

Pavel

Quoted 7 lines · Pavel Machek
Quoted 5 lines · Dan Murphy

Add a new color ID that is declared as MULTICOLOR as with the multicolor framework declaring a definitive color is not accurate as the node can contain multiple colors.

Please merge with previous patch, and you can keep reviews.

Not sure we should do that.  The previous patches deals directly with the bindings and this is code.

I thought the rule was to keep bindings and code separated.

It made sense to squash the bindings header patch to the bindings document patch but it does not make sense to squash this patch to the bindings.

Please let me know if you want me to proceed with the squash.

Dan

#5 lore raw

Re: [PATCH v20 02/17] leds: Add multicolor ID to the color ID list

Quoted 14 lines · Dan Murphy

Pavel

Quoted 7 lines · Pavel Machek
Quoted 5 lines · Dan Murphy

Add a new color ID that is declared as MULTICOLOR as with the multicolor framework declaring a definitive color is not accurate as the node can contain multiple colors.

Please merge with previous patch, and you can keep reviews.

Not sure we should do that.  The previous patches deals directly with the bindings and this is code.

Quoted 6 lines

I thought the rule was to keep bindings and code separated.

It made sense to squash the bindings header patch to the bindings document patch but it does not make sense to squash this patch to the bindings.

Please let me know if you want me to proceed with the squash.

Well, OTOH it seems wrong to have array that is only half-initialized... But it is not a big deal.

Best regards,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
author
#6 lore raw

Re: [PATCH v20 02/17] leds: Add multicolor ID to the color ID list

Pavel

Quoted 14 lines · Pavel Machek
Quoted 13 lines · Dan Murphy

Pavel

Quoted 7 lines · Pavel Machek
Quoted 5 lines · Dan Murphy

Add a new color ID that is declared as MULTICOLOR as with the multicolor framework declaring a definitive color is not accurate as the node can contain multiple colors.

Please merge with previous patch, and you can keep reviews.

Not sure we should do that.  The previous patches deals directly with the bindings and this is code.

Quoted 8 lines
Quoted 6 lines

I thought the rule was to keep bindings and code separated.

It made sense to squash the bindings header patch to the bindings document patch but it does not make sense to squash this patch to the bindings.

Please let me know if you want me to proceed with the squash.

Well, OTOH it seems wrong to have array that is only half-initialized... But it is not a big deal.

I will squash it into the previous patch as you asked.  Like you said it is not a big deal.

Dan

author
#7 lore raw

PATCH v20 3/17 leds: multicolor: Introduce a multicolor class definition

In reply to Dan Murphy

Introduce a multicolor class that groups colored LEDs within a LED node.

The multi color class groups monochrome LEDs and allows controlling two aspects of the final combined color: hue and lightness. The former is controlled via color_intensity file and the latter is controlled via brightness file.

---

v20 - Change color_ file names to multi_led, dynamically allocate the multicolor_info struct. Fixed documentation issues from Randy D.

 .../ABI/testing/sysfs-class-led-multicolor    |  42 ++++
 Documentation/leds/index.rst                  |   1 +
 Documentation/leds/leds-class-multicolor.rst  |  92 ++++++++
 drivers/leds/Kconfig                          |  10 +
 drivers/leds/Makefile                         |   1 +
 drivers/leds/led-class-multicolor.c           | 206 ++++++++++++++++++
 include/linux/led-class-multicolor.h          | 121 ++++++++++
 7 files changed, 473 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-class-led-multicolor
 create mode 100644 Documentation/leds/leds-class-multicolor.rst
 create mode 100644 drivers/leds/led-class-multicolor.c
 create mode 100644 include/linux/led-class-multicolor.h
Documentation/ABI/testing/sysfs-class-led-multicolor new file +42 -0
new file mode 100644
index 000000000000..ada0dbecfeab
@@ -0,0 +1,42 @@
+What:		/sys/class/leds/<led>/brightness
+Date:		March 2020
+KernelVersion:	5.8
+Contact:	Dan Murphy <[email protected]>
+Description:	read/write
+		Writing to this file will update all LEDs within the group to a
+		calculated percentage of what each color LED intensity is set
+		to. The percentage is calculated for each grouped LED via the
+		equation below:
+
+		led_brightness = brightness * multi_led_intensity/max_brightness
+
+		For additional details please refer to
+		Documentation/leds/leds-class-multicolor.rst.
+
+		The value of the color is from 0 to
+		/sys/class/leds/<led>/max_brightness.
+
+What:		/sys/class/leds/<led>/multi_led_index
+Date:		March 2020
+KernelVersion:	5.8
+Contact:	Dan Murphy <[email protected]>
+Description:	read
+		The multi_led_index array, when read, will output the LED colors
+		by name as they are indexed in the multi_led_intensity file.
+
+What:		/sys/class/leds/<led>/num_multi_leds
+Date:		March 2020
+KernelVersion:	5.8
+Contact:	Dan Murphy <[email protected]>
+Description:	read
+		The num_multi_leds indicates the number of LEDs defined in the
+		multi_led_intensity and multi_led_index files.
+
+What:		/sys/class/leds/<led>/multi_led_intensity
+Date:		March 2020
+KernelVersion:	5.8
+Contact:	Dan Murphy <[email protected]>
+Description:	read/write
+		Intensity level for the LED color within the array.
+		The intensities for each color must be entered based on the
+		multi_led_index array.
Documentation/leds/index.rst +1 -0
index 060f4e485897..bc70c6aa7138 100644
@@ -9,6 +9,7 @@ LEDs
 
    leds-class
    leds-class-flash
+   leds-class-multicolor
    ledtrig-oneshot
    ledtrig-transient
    ledtrig-usbport
Documentation/leds/leds-class-multicolor.rst new file +92 -0

92 lines not on this page · raw message

drivers/leds/Kconfig +10 -0
index c664d84e1667..dd2f64be493c 100644
@@ -30,6 +30,16 @@ config LEDS_CLASS_FLASH
 	  for the flash related features of a LED device. It can be built
 	  as a module.
 
+config LEDS_CLASS_MULTI_COLOR
+	tristate "LED MultiColor LED Class Support"
+	depends on LEDS_CLASS
+	help
+	  This option enables the multicolor LED sysfs class in /sys/class/leds.
+	  It wraps LED class and adds multicolor LED specific sysfs attributes
+	  and kernel internal API to it. You'll need this to provide support
+	  for multicolor LEDs that are grouped together. This class is not
+	  intended for single color LEDs. It can be built as a module.
+
 config LEDS_BRIGHTNESS_HW_CHANGED
 	bool "LED Class brightness_hw_changed attribute support"
 	depends on LEDS_CLASS
drivers/leds/Makefile +1 -0
index 45235d5fb218..6cbaa3f232ac 100644
@@ -4,6 +4,7 @@
 obj-$(CONFIG_NEW_LEDS)			+= led-core.o
 obj-$(CONFIG_LEDS_CLASS)		+= led-class.o
 obj-$(CONFIG_LEDS_CLASS_FLASH)		+= led-class-flash.o
+obj-$(CONFIG_LEDS_CLASS_MULTI_COLOR)	+= led-class-multicolor.o
 obj-$(CONFIG_LEDS_TRIGGERS)		+= led-triggers.o
 
 # LED Platform Drivers (keep this sorted, M-| sort)
drivers/leds/led-class-multicolor.c new file +206 -0

206 lines not on this page · raw message

include/linux/led-class-multicolor.h new file +121 -0

121 lines not on this page · raw message

Signature · 1 line
2.25.1
#8 lore raw

Re: [PATCH v20 03/17] leds: multicolor: Introduce a multicolor class definition

Hi!

Quoted 7 lines

Introduce a multicolor class that groups colored LEDs within a LED node.

The multi color class groups monochrome LEDs and allows controlling two aspects of the final combined color: hue and lightness. The former is controlled via color_intensity file and the latter is controlled via brightness file.

It is now multi_intensity, AFAICT.
Pavel

author
#9 lore raw

Re: [PATCH v20 03/17] leds: multicolor: Introduce a multicolor class definition

Pavel

Quoted 11 lines · Pavel Machek

Hi!

Quoted 7 lines

Introduce a multicolor class that groups colored LEDs within a LED node.

The multi color class groups monochrome LEDs and allows controlling two aspects of the final combined color: hue and lightness. The former is controlled via color_intensity file and the latter is controlled via brightness file.

It is now multi_intensity, AFAICT.

Ack

Quoted 1 line

Pavel

#10 lore raw

Re: [PATCH v20 03/17] leds: multicolor: Introduce a multicolor class definition

In reply to Dan Murphy

Hi!

ting/sysfs-class-led-multicolor

Documentation/ABI/testing/sysfs-class-led-multicolor line 7

Quoted 12 lines

new file mode 100644
index 000000000000..ada0dbecfeab

Documentation/ABI/testing/sysfs-class-led-multicolor new file +7 -0
@@ -0,0 +1,42 @@
+What:		/sys/class/leds/<led>/multi_led_index
+Date:		March 2020
+KernelVersion:	5.8
+Contact:	Dan Murphy <[email protected]>
+Description:	read
+		The multi_led_index array, when read, will output the LED colors
+		by name as they are indexed in the multi_led_intensity file.

Can we make it multi_index? We are already in leds directory, and it is a bit shorter.

Documentation/ABI/testing/sysfs-class-led-multicolor line 33

Quoted 7 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +7 -0
+What:		/sys/class/leds/<led>/num_multi_leds
+Date:		March 2020
+KernelVersion:	5.8
+Contact:	Dan Murphy <[email protected]>
+Description:	read
+		The num_multi_leds indicates the number of LEDs defined in the
+		multi_led_intensity and multi_led_index files.

Please drop this one.

Documentation/ABI/testing/sysfs-class-led-multicolor line 42

Quoted 8 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +8 -0
+What:		/sys/class/leds/<led>/multi_led_intensity
+Date:		March 2020
+KernelVersion:	5.8
+Contact:	Dan Murphy <[email protected]>
+Description:	read/write
+		Intensity level for the LED color within the array.
+		The intensities for each color must be entered based on the
+		multi_led_index array.

And let this one be multi_intensity.

Documentation/ABI/testing/sysfs-class-led-multicolor line 24

Quoted 2 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +2 -0
+For more details on hue and lightness notions please refer to
+https://en.wikipedia.org/wiki/CIECAM02.

I'd drop this reference. multi_intensity file controls both hue and saturation AFAICT.

Documentation/ABI/testing/sysfs-class-led-multicolor line 28

Quoted 4 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +4 -0
+Example:
+A user first writes the multi_led_intensity file with the brightness levels
+for each LED that are necessary to achieve a blueish violet output from a
+multicolor LED group.

I don't believe we can guarantee that. 255/255/255 will produce different colors on different hardware (not white), and 43/226/138 will also produce different colors....

Documentation/ABI/testing/sysfs-class-led-multicolor line 30

Quoted 2 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +2 -0
+cat /sys/class/leds/multicolor:status/multi_led_index
+green blue red

Hmm. We should really make sure LEDs are ordered as "red green blue". Yes, userspace should support any order, but...

Documentation/ABI/testing/sysfs-class-led-multicolor line 32

Quoted 2 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +2 -0
+The user can control the brightness of that multicolor LED group by writing the
+parent 'brightness' control.  Assuming a parent max_brightness of 255 the user

delete "parent", twice?

Documentation/ABI/testing/sysfs-class-led-multicolor line 36

Quoted 4 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +4 -0
+	for (i = 0; i < mcled_cdev->num_colors; i++)
+		mcled_cdev->multicolor_info[i].color_brightness = brightness *
+					  mcled_cdev->multicolor_info[i].color_led_intensity /
+					  led_cdev->max_brightness;

It would be good to get this under ~80 characters. Perhaps shorter identifiers would help... shortening multicolor_ to mc_?

Quoted 8 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +8 -0
+static ssize_t multi_led_intensity_store(struct device *dev,
+				struct device_attribute *intensity_attr,
+				const char *buf, size_t size)
+{
+	struct led_classdev *led_cdev = dev_get_drvdata(dev);
+	struct led_classdev_mc *mcled_cdev = lcdev_to_mccdev(led_cdev);
+	int nrchars, offset = 0;
+	int intensity_value[LED_COLOR_ID_MAX];

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 10 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +10 -0
+	int i;
+	ssize_t ret;
+
+	mutex_lock(&led_cdev->led_access);
+
+	for (i = 0; i < mcled_cdev->num_colors; i++) {
+		ret = sscanf(buf + offset, "%i%n",
+			     &intensity_value[i], &nrchars);
+		if (ret != 1) {
+			dev_err(led_cdev->dev,

dev_dbg, at most. It is user-triggerable.

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 3 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +3 -0
+				"Incorrect number of LEDs expected %i values intensity was not applied\n",
+				mcled_cdev->num_colors);
+			goto err_out;

Should not we return -ERRNO to userspace on error?

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 3 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +3 -0
+		}
+		offset += nrchars;
+	}

This checks for "not enough" intensities. Do we need check for "too many" intensities?

Quoted 4 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +4 -0
+static ssize_t multi_led_intensity_show(struct device *dev,
+			      struct device_attribute *intensity_attr,
+			      char *buf)
+{

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 10 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +10 -0
+	struct led_classdev *led_cdev = dev_get_drvdata(dev);
+	struct led_classdev_mc *mcled_cdev = lcdev_to_mccdev(led_cdev);
+	int len = 0;
+	int i;
+
+	for (i = 0; i < mcled_cdev->num_colors; i++)
+		len += sprintf(buf + len, "%d ",
+			    mcled_cdev->multicolor_info[i].color_led_intensity);
+
+	len += sprintf(buf + len, "%s", "\n");

This will result in extra " " before end of line.

Please don't use "%s", "\n" to add single character. "\n" would be enough.

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 12 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +12 -0
+	struct led_classdev *led_cdev = dev_get_drvdata(dev);
+	struct led_classdev_mc *mcled_cdev = lcdev_to_mccdev(led_cdev);
+	int len = 0;
+	int index;
+	int i;
+
+	for (i = 0; i < mcled_cdev->num_colors; i++) {
+		index = mcled_cdev->multicolor_info[i].color_index;
+		len += sprintf(buf + len, "%s ", led_colors[index]);
+	}
+
+	len += sprintf(buf + len, "%s", "\n");

Same here.

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 11 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +11 -0
+int led_classdev_multicolor_register_ext(struct device *parent,
+				     struct led_classdev_mc *mcled_cdev,
+				     struct led_init_data *init_data)
+{
+	struct led_classdev *led_cdev;
+
+	if (!mcled_cdev)
+		return -EINVAL;
+
+	if (!mcled_cdev->num_colors)
+		return -EINVAL;

if (num_colors > max)... ?

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 2 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +2 -0
+#ifndef __LINUX_MULTICOLOR_LEDS_H_INCLUDED
+#define __LINUX_MULTICOLOR_LEDS_H_INCLUDED

Usual style is "_LINUX_MULTICOLOR_LEDS_H".

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 3 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +3 -0
+#else
+
+static inline  int led_classdev_multicolor_register_ext(struct device *parent,

double space after "inline".

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 5 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +5 -0
+					    struct led_classdev_mc *mcled_cdev,
+					    struct led_init_data *init_data)
+{
+	return -EINVAL;
+}

Do we need to include these stubs? I guess it is okay to have them, OTOH I'd expect drivers to depend on MULTICOLOR being available...

Best regards,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#11 lore raw

Re: [PATCH v20 03/17] leds: multicolor: Introduce a multicolor class definition

Hi all,

Quoted 2 lines · Pavel Machek

Hi!

[...]

Quoted 7 lines

drivers/leds/led-class-multicolor.c line 24

Quoted 4 lines
drivers/leds/led-class-multicolor.c new file +4 -0
+	for (i = 0; i < mcled_cdev->num_colors; i++)
+		mcled_cdev->multicolor_info[i].color_brightness = brightness *
+					  mcled_cdev->multicolor_info[i].color_led_intensity /
+					  led_cdev->max_brightness;

It would be good to get this under ~80 characters. Perhaps shorter identifiers would help... shortening multicolor_ to mc_?

And color_led_intensity to led_intensity.

Quoted 95 lines
Quoted 9 lines
drivers/leds/led-class-multicolor.c new file +8 -0
+static ssize_t multi_led_intensity_store(struct device *dev,
+				struct device_attribute *intensity_attr,
+				const char *buf, size_t size)
+{
+	struct led_classdev *led_cdev = dev_get_drvdata(dev);
+	struct led_classdev_mc *mcled_cdev = lcdev_to_mccdev(led_cdev);
+	int nrchars, offset = 0;
+	int intensity_value[LED_COLOR_ID_MAX];

drivers/leds/led-class-multicolor.c line 47

Quoted 10 lines
drivers/leds/led-class-multicolor.c new file +10 -0
+	int i;
+	ssize_t ret;
+
+	mutex_lock(&led_cdev->led_access);
+
+	for (i = 0; i < mcled_cdev->num_colors; i++) {
+		ret = sscanf(buf + offset, "%i%n",
+			     &intensity_value[i], &nrchars);
+		if (ret != 1) {
+			dev_err(led_cdev->dev,

dev_dbg, at most. It is user-triggerable.

drivers/leds/led-class-multicolor.c line 50

Quoted 3 lines
drivers/leds/led-class-multicolor.c new file +3 -0
+				"Incorrect number of LEDs expected %i values intensity was not applied\n",
+				mcled_cdev->num_colors);
+			goto err_out;

Should not we return -ERRNO to userspace on error?

drivers/leds/led-class-multicolor.c line 53

Quoted 3 lines
drivers/leds/led-class-multicolor.c new file +3 -0
+		}
+		offset += nrchars;
+	}

This checks for "not enough" intensities. Do we need check for "too many" intensities?

Quoted 4 lines
drivers/leds/led-class-multicolor.c new file +4 -0
+static ssize_t multi_led_intensity_show(struct device *dev,
+			      struct device_attribute *intensity_attr,
+			      char *buf)
+{

drivers/leds/led-class-multicolor.c line 79

Quoted 10 lines
drivers/leds/led-class-multicolor.c new file +10 -0
+	struct led_classdev *led_cdev = dev_get_drvdata(dev);
+	struct led_classdev_mc *mcled_cdev = lcdev_to_mccdev(led_cdev);
+	int len = 0;
+	int i;
+
+	for (i = 0; i < mcled_cdev->num_colors; i++)
+		len += sprintf(buf + len, "%d ",
+			    mcled_cdev->multicolor_info[i].color_led_intensity);
+
+	len += sprintf(buf + len, "%s", "\n");

This will result in extra " " before end of line.

Please don't use "%s", "\n" to add single character. "\n" would be enough.

drivers/leds/led-class-multicolor.c line 100

Quoted 12 lines
drivers/leds/led-class-multicolor.c new file +12 -0
+	struct led_classdev *led_cdev = dev_get_drvdata(dev);
+	struct led_classdev_mc *mcled_cdev = lcdev_to_mccdev(led_cdev);
+	int len = 0;
+	int index;
+	int i;
+
+	for (i = 0; i < mcled_cdev->num_colors; i++) {
+		index = mcled_cdev->multicolor_info[i].color_index;
+		len += sprintf(buf + len, "%s ", led_colors[index]);
+	}
+
+	len += sprintf(buf + len, "%s", "\n");

Same here.

drivers/leds/led-class-multicolor.c line 135

Quoted 11 lines
drivers/leds/led-class-multicolor.c new file +11 -0
+int led_classdev_multicolor_register_ext(struct device *parent,
+				     struct led_classdev_mc *mcled_cdev,
+				     struct led_init_data *init_data)
+{
+	struct led_classdev *led_cdev;
+
+	if (!mcled_cdev)
+		return -EINVAL;
+
+	if (!mcled_cdev->num_colors)
+		return -EINVAL;

if (num_colors > max)... ?

include/linux/led-class-multicolor.h line 7

Quoted 2 lines
include/linux/led-class-multicolor.h new file +2 -0
+#ifndef __LINUX_MULTICOLOR_LEDS_H_INCLUDED
+#define __LINUX_MULTICOLOR_LEDS_H_INCLUDED

Usual style is "_LINUX_MULTICOLOR_LEDS_H".

include/linux/led-class-multicolor.h line 82

Quoted 3 lines
include/linux/led-class-multicolor.h new file +3 -0
+#else
+
+static inline  int led_classdev_multicolor_register_ext(struct device *parent,

double space after "inline".

Quoted 8 lines

drivers/leds/led-class-multicolor.c line 141

Quoted 5 lines
drivers/leds/led-class-multicolor.c new file +5 -0
+					    struct led_classdev_mc *mcled_cdev,
+					    struct led_init_data *init_data)
+{
+	return -EINVAL;
+}

Do we need to include these stubs? I guess it is okay to have them, OTOH I'd expect drivers to depend on MULTICOLOR being available...

Single driver can support both monochrome and multicolor LED class, which is chosen basing on DT. In this regard having no-ops for LED mc class is justified since it is a superset of monochrome LED class.

Signature · 2 lines
Best regards,
Jacek Anaszewski
#12 lore raw

Re: [PATCH v20 03/17] leds: multicolor: Introduce a multicolor class definition

Hi!

Quoted 6 lines
Quoted 2 lines

Do we need to include these stubs? I guess it is okay to have them, OTOH I'd expect drivers to depend on MULTICOLOR being available...

Single driver can support both monochrome and multicolor LED class, which is chosen basing on DT. In this regard having no-ops for LED mc class is justified since it is a superset of monochrome LED class.

Ok, makes sense.

Best regards,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
author
#13 lore raw

Re: [PATCH v20 03/17] leds: multicolor: Introduce a multicolor class definition

In reply to Pavel Machek

Pavel

Quoted 17 lines · Pavel Machek

Hi!

ting/sysfs-class-led-multicolor

Documentation/ABI/testing/sysfs-class-led-multicolor line 7

Quoted 12 lines

new file mode 100644
index 000000000000..ada0dbecfeab

Documentation/ABI/testing/sysfs-class-led-multicolor new file +7 -0
@@ -0,0 +1,42 @@
+What:		/sys/class/leds/<led>/multi_led_index
+Date:		March 2020
+KernelVersion:	5.8
+Contact:	Dan Murphy <[email protected]>
+Description:	read
+		The multi_led_index array, when read, will output the LED colors
+		by name as they are indexed in the multi_led_intensity file.

Can we make it multi_index? We are already in leds directory, and it is a bit shorter.

Ack

Quoted 8 lines

Documentation/ABI/testing/sysfs-class-led-multicolor line 33

Quoted 7 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +7 -0
+What:		/sys/class/leds/<led>/num_multi_leds
+Date:		March 2020
+KernelVersion:	5.8
+Contact:	Dan Murphy <[email protected]>
+Description:	read
+		The num_multi_leds indicates the number of LEDs defined in the
+		multi_led_intensity and multi_led_index files.

Please drop this one.

Ack

Quoted 9 lines

Documentation/ABI/testing/sysfs-class-led-multicolor line 42

Quoted 8 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +8 -0
+What:		/sys/class/leds/<led>/multi_led_intensity
+Date:		March 2020
+KernelVersion:	5.8
+Contact:	Dan Murphy <[email protected]>
+Description:	read/write
+		Intensity level for the LED color within the array.
+		The intensities for each color must be entered based on the
+		multi_led_index array.

And let this one be multi_intensity.

Ack

Quoted 4 lines

Documentation/ABI/testing/sysfs-class-led-multicolor line 24

Quoted 2 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +2 -0
+For more details on hue and lightness notions please refer to
+https://en.wikipedia.org/wiki/CIECAM02.

I'd drop this reference. multi_intensity file controls both hue and saturation AFAICT.

Ack

Quoted 7 lines

Documentation/ABI/testing/sysfs-class-led-multicolor line 28

Quoted 4 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +4 -0
+Example:
+A user first writes the multi_led_intensity file with the brightness levels
+for each LED that are necessary to achieve a blueish violet output from a
+multicolor LED group.

I don't believe we can guarantee that. 255/255/255 will produce different colors on different hardware (not white), and 43/226/138 will also produce different colors.

I changed it to be a bit more ambiguous.

Quoted 6 lines

...

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 2 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +2 -0
+cat /sys/class/leds/multicolor:status/multi_led_index
+green blue red

Hmm. We should really make sure LEDs are ordered as "red green blue". Yes, userspace should support any order, but...

Ordering is not guaranteed since it is based on the DT ordering. I don't think we can mandate that these LEDs be put in order in the DT.

Besides the framework and the device driver do not care what color is where only the user space needs to care.  The FW and device driver only care about the brightness, intensity and channel.

Quoted 4 lines

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 3 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +2 -0
+The user can control the brightness of that multicolor LED group by writing the
+parent 'brightness' control.  Assuming a parent max_brightness of 255 the user

delete "parent", twice?

Ack

Quoted 8 lines

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 6 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +4 -0
+	for (i = 0; i < mcled_cdev->num_colors; i++)
+		mcled_cdev->multicolor_info[i].color_brightness = brightness *
+					  mcled_cdev->multicolor_info[i].color_led_intensity /
+					  led_cdev->max_brightness;

It would be good to get this under ~80 characters. Perhaps shorter identifiers would help... shortening multicolor_ to mc_?

ACK

Quoted 11 lines
Quoted 11 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +11 -0
+static ssize_t multi_led_intensity_store(struct device *dev,
+				struct device_attribute *intensity_attr,
+				const char *buf, size_t size)
+{
+	struct led_classdev *led_cdev = dev_get_drvdata(dev);
+	struct led_classdev_mc *mcled_cdev = lcdev_to_mccdev(led_cdev);
+	int nrchars, offset = 0;
+	int intensity_value[LED_COLOR_ID_MAX];
+	int i;
+	ssize_t ret;
+
Quoted 8 lines

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 7 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +7 -0
+	mutex_lock(&led_cdev->led_access);
+
+	for (i = 0; i < mcled_cdev->num_colors; i++) {
+		ret = sscanf(buf + offset, "%i%n",
+			     &intensity_value[i], &nrchars);
+		if (ret != 1) {
+			dev_err(led_cdev->dev,

dev_dbg, at most. It is user-triggerable.

ACK

Quoted 4 lines

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 3 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +3 -0
+				"Incorrect number of LEDs expected %i values intensity was not applied\n",
+				mcled_cdev->num_colors);
+			goto err_out;

Should not we return -ERRNO to userspace on error?

ACK

Quoted 6 lines

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 4 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +3 -0
+		}
+		offset += nrchars;
+	}

This checks for "not enough" intensities. Do we need check for "too many" intensities?

We ignore anything greater then mcled_cdev->num_colors.  So if this is set to 3 we only read the first 3 values.

So we cannot read more then what is set by the DT.

Quoted 17 lines
Quoted 5 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +4 -0
+static ssize_t multi_led_intensity_show(struct device *dev,
+			      struct device_attribute *intensity_attr,
+			      char *buf)
+{

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 10 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +10 -0
+	struct led_classdev *led_cdev = dev_get_drvdata(dev);
+	struct led_classdev_mc *mcled_cdev = lcdev_to_mccdev(led_cdev);
+	int len = 0;
+	int i;
+
+	for (i = 0; i < mcled_cdev->num_colors; i++)
+		len += sprintf(buf + len, "%d ",
+			    mcled_cdev->multicolor_info[i].color_led_intensity);
+
+	len += sprintf(buf + len, "%s", "\n");

This will result in extra " " before end of line.

Quoted 1 line

Please don't use "%s", "\n" to add single character. "\n" would be enough.

Ack changed to just sprintf(buf + len, "\n");

Quoted 14 lines

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 13 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +12 -0
+	struct led_classdev *led_cdev = dev_get_drvdata(dev);
+	struct led_classdev_mc *mcled_cdev = lcdev_to_mccdev(led_cdev);
+	int len = 0;
+	int index;
+	int i;
+
+	for (i = 0; i < mcled_cdev->num_colors; i++) {
+		index = mcled_cdev->multicolor_info[i].color_index;
+		len += sprintf(buf + len, "%s ", led_colors[index]);
+	}
+
+	len += sprintf(buf + len, "%s", "\n");

Same here.

Same as above

Quoted 4 lines
Quoted 4 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +4 -0
+int led_classdev_multicolor_register_ext(struct device *parent,
+				     struct led_classdev_mc *mcled_cdev,
+				     struct led_init_data *init_data)
+{
Quoted 8 lines

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 7 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +7 -0
+	struct led_classdev *led_cdev;
+
+	if (!mcled_cdev)
+		return -EINVAL;
+
+	if (!mcled_cdev->num_colors)
+		return -EINVAL;

if (num_colors > max)... ?

ACK

Quoted 3 lines

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 2 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +2 -0
+#ifndef __LINUX_MULTICOLOR_LEDS_H_INCLUDED
+#define __LINUX_MULTICOLOR_LEDS_H_INCLUDED

Usual style is "_LINUX_MULTICOLOR_LEDS_H".

Ack

Quoted 4 lines

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 3 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +3 -0
+#else
+
+static inline  int led_classdev_multicolor_register_ext(struct device *parent,

double space after "inline".

Ack

Quoted 7 lines

Documentation/ABI/testing/sysfs-class-led-multicolor

Quoted 5 lines
Documentation/ABI/testing/sysfs-class-led-multicolor new file +5 -0
+					    struct led_classdev_mc *mcled_cdev,
+					    struct led_init_data *init_data)
+{
+	return -EINVAL;
+}

Do we need to include these stubs? I guess it is okay to have them, OTOH I'd expect drivers to depend on MULTICOLOR being available...

Jacek Answered this.

Dan

Quoted 2 lines

Best regards,
Pavel

#14 lore raw

Re: [PATCH v20 03/17] leds: multicolor: Introduce a multicolor class definition

Hi!

Quoted 11 lines
Quoted 4 lines

Documentation/leds/leds-class-multicolor.rst line 60

Quoted 2 lines
Documentation/leds/leds-class-multicolor.rst new file +2 -0
+cat /sys/class/leds/multicolor:status/multi_led_index
+green blue red

Hmm. We should really make sure LEDs are ordered as "red green blue". Yes, userspace should support any order, but...

Ordering is not guaranteed since it is based on the DT ordering. I don't think we can mandate that these LEDs be put in order in the DT.

Besides the framework and the device driver do not care what color is where only the user space needs to care.  The FW and device driver only care about the brightness, intensity and channel.

Ok, lets keep it like this.

Quoted 9 lines
Quoted 4 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+		offset += nrchars;
+	}

This checks for "not enough" intensities. Do we need check for "too many" intensities?

We ignore anything greater then mcled_cdev->num_colors.  So if this is set to 3 we only read the first 3 values.

So we cannot read more then what is set by the DT.

Please make it return an error if extra values are passed in.

Quoted 16 lines
Quoted 16 lines
Quoted 4 lines
drivers/leds/led-class-multicolor.c new file +4 -0
+static ssize_t multi_led_intensity_show(struct device *dev,
+			      struct device_attribute *intensity_attr,
+			      char *buf)
+{

drivers/leds/led-class-multicolor.c line 79

Quoted 10 lines
drivers/leds/led-class-multicolor.c new file +10 -0
+	struct led_classdev *led_cdev = dev_get_drvdata(dev);
+	struct led_classdev_mc *mcled_cdev = lcdev_to_mccdev(led_cdev);
+	int len = 0;
+	int i;
+
+	for (i = 0; i < mcled_cdev->num_colors; i++)
+		len += sprintf(buf + len, "%d ",
+			    mcled_cdev->multicolor_info[i].color_led_intensity);
+
+	len += sprintf(buf + len, "%s", "\n");

This will result in extra " " before end of line.

Quoted 2 lines
Quoted 1 line

Please don't use "%s", "\n" to add single character. "\n" would be enough.

Ack changed to just sprintf(buf + len, "\n");

Also note the extra space before end of line.

Best regards,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#15 lore raw

Re: [PATCH v20 03/17] leds: multicolor: Introduce a multicolor class definition

In reply to Dan Murphy

Hi Dan,

Quoted 14 lines · Dan Murphy

Introduce a multicolor class that groups colored LEDs within a LED node.

The multi color class groups monochrome LEDs and allows controlling two aspects of the final combined color: hue and lightness. The former is controlled via color_intensity file and the latter is controlled via brightness file.

---

v20 - Change color_ file names to multi_led, dynamically allocate the multicolor_info struct. Fixed documentation issues from Randy D.

[...]

Quoted 23 lines
drivers/leds/led-class-multicolor.c new file +3 -0
+MODULE_AUTHOR("Dan Murphy <[email protected]>");
+MODULE_DESCRIPTION("Multi Color LED class interface");
+MODULE_LICENSE("GPL v2");
include/linux/led-class-multicolor.h new file +14 -0
new file mode 100644
index 000000000000..7c5befb270f8
@@ -0,0 +1,121 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/* LED Multicolor class interface
+ * Copyright (C) 2019-20 Texas Instruments Incorporated - http://www.ti.com/
+ */
+
+#ifndef __LINUX_MULTICOLOR_LEDS_H_INCLUDED
+#define __LINUX_MULTICOLOR_LEDS_H_INCLUDED
+
+#include <linux/leds.h>
+#include <dt-bindings/leds/common.h>
+
+struct led_mc_subled {
+	int color_index;
+	int color_brightness;

include/linux/led-class-multicolor.h line 24

Quoted 10 lines
include/linux/led-class-multicolor.h new file +10 -0
+	int color_led_intensity;
+	int color_channel;
+};
+
+struct led_classdev_mc {
+	/* led class device */
+	struct led_classdev led_cdev;
+	int num_colors;
+
+	struct led_mc_subled *multicolor_info;

I think mc_subleds (or even subleds alone - we are already in led_classdev_*mc*) would be way more informative name for this property.

And as already proposed in the other message:

s/color_led_intensity/color_intensity/

Also, I would like to have just "brightness" instead of color_brightness, which is ambiguous. And having brightness in this struct led_mc_subled would clearly state that this is the value to be written to the hardware similarly as is struct led_classdev's brightness for monochrome LEDs.

Signature · 2 lines
Best regards,
Jacek Anaszewski
author
#16 lore raw

PATCH v20 4/17 dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers

In reply to Dan Murphy

Introduce the bindings for the Texas Instruments LP5036, LP5030, LP5024, LP5018, LP5012 and LP5009 RGB LED device driver. The LP5036/30/24/18/12/9 can control RGB LEDs individually or as part of a control bank group. These devices have the ability to adjust the mixing control for the RGB LEDs to obtain different colors independent of the overall brightness of the LED grouping.

Datasheet:
http://www.ti.com/lit/ds/symlink/lp5012.pdf
http://www.ti.com/lit/ds/symlink/lp5024.pdf
http://www.ti.com/lit/ds/symlink/lp5036.pdf

---
 .../devicetree/bindings/leds/leds-lp50xx.txt  | 148 ++++++++++++++++++
 1 file changed, 148 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-lp50xx.txt
Documentation/devicetree/bindings/leds/leds-lp50xx.txt new file +148 -0
new file mode 100644
index 000000000000..291d418642e0
@@ -0,0 +1,148 @@
+* Texas Instruments - LP5009/12/18/24/30/36 RGB LED driver
+
+The LP50XX is multi-channel, I2C RGB LED Drivers that can group RGB LEDs into
+a LED group or control them individually.
+
+The difference in these RGB LED drivers is the number of supported RGB modules.
+
+Required parent properties:
+	- compatible:
+		"ti,lp5009"
+		"ti,lp5012"
+		"ti,lp5018"
+		"ti,lp5024"
+		"ti,lp5030"
+		"ti,lp5036"
+	- reg :  I2C slave address
+		lp5009/12 - 0x14, 0x15, 0x16, 0x17
+		lp5018/24 - 0x28, 0x29, 0x2a, 0x2b
+		lp5030/36 - 0x30, 0x31, 0x32, 0x33
+	- #address-cells : 1
+	- #size-cells : 0
+
+Optional parent properties:
+	- enable-gpios : gpio pin to enable/disable the device.
+	- vled-supply : LED supply
+
+Required child properties:
+	- #address-cells : 1
+	- #size-cells : 0
+	- reg : This is the LED module number.
+	- color : Must be LED_COLOR_ID_MULTI
+	- function : see Documentation/devicetree/bindings/leds/common.txt
+
+Required child properties only if LED modules will be banked:
+	- ti,led-bank : This property denotes the LED module numbers that will
+			be controlled as a single RGB cluster.  Each LED module
+			number will be controlled by a single LED class instance.
+			There can only be one instance of the ti,led-bank
+			property for each device node.
+
+Required grandchildren properties:
+	- reg : A single entry denoting the LED output that controls
+		the monochrome LED.
+	- color : see Documentation/devicetree/bindings/leds/common.txt
+	- led-sources : see Documentation/devicetree/bindings/leds/common.txt
+
+The LED outputs associated with the LED modules are defined in Table 1 of the
+corresponding data sheets.
+
+LP5009 - 3 Total RGB cluster LED outputs 0-2
+LP5012 - 4 Total RGB cluster LED outputs 0-3
+LP5018 - 6 Total RGB cluster LED outputs 0-5
+LP5024 - 8 Total RGB cluster LED outputs 0-7
+LP5030 - 10 Total RGB cluster LED outputs 0-9
+LP5036 - 12 Total RGB cluster LED outputs 0-11
+
+Optional child properties:
+	- label : see Documentation/devicetree/bindings/leds/common.txt
+	- linux,default-trigger :
+	   see Documentation/devicetree/bindings/leds/common.txt
+
+Examples:
+led-controller@29 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	compatible = "ti,lp5024";
+	reg = <0x29>;
+	enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
+	vled-supply = <&vmmcsd_fixed>;
+
+	multi-led@1 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <1>;
+		color = <LED_COLOR_ID_MULTI>;
+		function = LED_FUNCTION_STATUS;
+
+		led@3 {
+			reg = <3>;
+			color = <LED_COLOR_ID_RED>;
+		};
+
+		led@4 {
+			reg = <4>;
+			color = <LED_COLOR_ID_GREEN>;
+		};
+
+		led@5 {
+			reg = <5>;
+			color = <LED_COLOR_ID_BLUE>;
+		};
+	};
+
+	multi-led@2 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <2>;
+		color = <LED_COLOR_ID_MULTI>;
+		function = LED_FUNCTION_STANDBY;
+		ti,led-bank = <2 3 5>;
+
+		led@6 {
+			reg = <0x6>;
+			color = <LED_COLOR_ID_RED>;
+			led-sources = <6 9 15>;
+		};
+
+		led@7 {
+			reg = <0x7>;
+			color = <LED_COLOR_ID_GREEN>;
+			led-sources = <7 10 16>;
+		};
+
+		led@8 {
+			reg = <0x8>;
+			color = <LED_COLOR_ID_BLUE>;
+			led-sources = <8 11 17>;
+		};
+	};
+
+	multi-led@4 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <4>;
+		color = <LED_COLOR_ID_MULTI>;
+		function = LED_FUNCTION_ACTIVITY;
+
+		led@12 {
+			reg = <12>;
+			color = <LED_COLOR_ID_RED>;
+		};
+
+		led@13 {
+			reg = <13>;
+			color = <LED_COLOR_ID_GREEN>;
+		};
+
+		led@14 {
+			reg = <14>;
+			color = <LED_COLOR_ID_BLUE>;
+		};
+	};
+};
+
+For more product information please see the link below:
+http://www.ti.com/lit/ds/symlink/lp5012.pdf
+http://www.ti.com/lit/ds/symlink/lp5024.pdf
+http://www.ti.com/lit/ds/symlink/lp5036.pdf
Signature · 1 line
2.25.1
#17 lore raw

Re: [PATCH v20 04/17] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers

Hi!

Quoted 7 lines

Introduce the bindings for the Texas Instruments LP5036, LP5030, LP5024, LP5018, LP5012 and LP5009 RGB LED device driver. The LP5036/30/24/18/12/9 can control RGB LEDs individually or as part of a control bank group. These devices have the ability to adjust the mixing control for the RGB LEDs to obtain different colors independent of the overall brightness of the LED grouping.

Quoted 8 lines

Datasheet:
http://www.ti.com/lit/ds/symlink/lp5012.pdf
http://www.ti.com/lit/ds/symlink/lp5024.pdf
http://www.ti.com/lit/ds/symlink/lp5036.pdf

---
 .../devicetree/bindings/leds/leds-lp50xx.txt  | 148 ++++++++++++++++++

Not sure here, but should new bindings be .yml?
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
author
#18 lore raw

Re: [PATCH v20 04/17] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers

Pavel

Quoted 14 lines · Pavel Machek

Hi!

Quoted 12 lines

Introduce the bindings for the Texas Instruments LP5036, LP5030, LP5024, LP5018, LP5012 and LP5009 RGB LED device driver. The LP5036/30/24/18/12/9 can control RGB LEDs individually or as part of a control bank group. These devices have the ability to adjust the mixing control for the RGB LEDs to obtain different colors independent of the overall brightness of the LED grouping.

Datasheet:
http://www.ti.com/lit/ds/symlink/lp5012.pdf
http://www.ti.com/lit/ds/symlink/lp5024.pdf
http://www.ti.com/lit/ds/symlink/lp5036.pdf

Quoted 5 lines
Quoted 3 lines
---
  .../devicetree/bindings/leds/leds-lp50xx.txt  | 148 ++++++++++++++++++

Not sure here, but should new bindings be .yml?

Yeah it should be now.  This patch has been around so long that it was done before yaml conversion ;)

Dan

Quoted 2 lines

Pavel

author
#19 lore raw

PATCH v20 5/17 leds: lp50xx: Add the LP50XX family of the RGB LED driver

In reply to Dan Murphy

Introduce the LP5036/30/24/18/12/9 RGB LED driver. The difference in these parts are the number of LED outputs where the:

LP5036 can control 36 LEDs
LP5030 can control 30 LEDs
LP5024 can control 24 LEDs
LP5018 can control 18 LEDs
LP5012 can control 12 LEDs
LP5009 can control 9 LEDs

The device has the ability to group LED output into control banks so that multiple LED banks can be controlled with the same mixing and brightness. Inversely the LEDs can also be controlled independently.

---
 drivers/leds/Kconfig       |  11 +
 drivers/leds/Makefile      |   1 +
 drivers/leds/leds-lp50xx.c | 778 +++++++++++++++++++++++++++++++++++++
 3 files changed, 790 insertions(+)
 create mode 100644 drivers/leds/leds-lp50xx.c
drivers/leds/Kconfig +11 -0
index dd2f64be493c..66253a2a01d3 100644
@@ -363,6 +363,17 @@ config LEDS_LP3952
 	  To compile this driver as a module, choose M here: the
 	  module will be called leds-lp3952.
 
+config LEDS_LP50XX
+	tristate "LED Support for TI LP5036/30/24/18/12/9 LED driver chip"
+	depends on LEDS_CLASS && REGMAP_I2C
+	depends on LEDS_CLASS_MULTI_COLOR
+	help
+	  If you say yes here you get support for the Texas Instruments
+	  LP5036, LP5030, LP5024, LP5018, LP5012 and LP5009 LED driver.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called leds-lp50xx.
+
 config LEDS_LP55XX_COMMON
 	tristate "Common Driver for TI/National LP5521/5523/55231/5562/8501"
 	depends on LEDS_LP5521 || LEDS_LP5523 || LEDS_LP5562 || LEDS_LP8501
drivers/leds/Makefile +1 -0
index 6cbaa3f232ac..f6b320d1a403 100644
@@ -47,6 +47,7 @@ obj-$(CONFIG_LEDS_LM3697)		+= leds-lm3697.o
 obj-$(CONFIG_LEDS_LOCOMO)		+= leds-locomo.o
 obj-$(CONFIG_LEDS_LP3944)		+= leds-lp3944.o
 obj-$(CONFIG_LEDS_LP3952)		+= leds-lp3952.o
+obj-$(CONFIG_LEDS_LP50XX)		+= leds-lp50xx.o
 obj-$(CONFIG_LEDS_LP5521)		+= leds-lp5521.o
 obj-$(CONFIG_LEDS_LP5523)		+= leds-lp5523.o
 obj-$(CONFIG_LEDS_LP5562)		+= leds-lp5562.o
drivers/leds/leds-lp50xx.c new file +778 -0

778 lines not on this page · raw message

Signature · 1 line
2.25.1
author
#20 lore raw

PATCH v20 6/17 dt: bindings: lp55xx: Be consistent in the document with LED acronym

In reply to Dan Murphy

Update the document to be consistent in case when using "LED". This acronym should be capital throughout the document.

---
 Documentation/devicetree/bindings/leds/leds-lp55xx.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/leds/leds-lp55xx.txt +3 -3
index 1b66a413fb9d..bfe2805c5534 100644
@@ -1,4 +1,4 @@
-Binding for TI/National Semiconductor LP55xx Led Drivers
+Binding for TI/National Semiconductor LP55xx LED Drivers
 
 Required properties:
 - compatible: one of
@@ -12,8 +12,8 @@ Required properties:
 - clock-mode: Input clock mode, (0: automode, 1: internal, 2: external)
 
 Each child has own specific current settings
-- led-cur: Current setting at each led channel (mA x10, 0 if led is not connected)
-- max-cur: Maximun current at each led channel.
+- led-cur: Current setting at each LED channel (mA x10, 0 if LED is not connected)
+- max-cur: Maximun current at each LED channel.
 
 Optional properties:
 - enable-gpio: GPIO attached to the chip's enable pin
Signature · 1 line
2.25.1
author
#21 lore raw

PATCH v20 7/17 dt: bindings: lp55xx: Update binding for Multicolor Framework

In reply to Dan Murphy

Update the DT binding to include the properties to use the multicolor framework for the devices that use the LP55xx framework.

CC Tony Lindgren <[email protected]>
CC "Benoît Cousson" <[email protected]>
CC Linus Walleij <[email protected]>
CC Shawn Guo <[email protected]>
CC Sascha Hauer <[email protected]>
CC Pengutronix Kernel Team <[email protected]>
CC Fabio Estevam <[email protected]>
CC NXP Linux Team <[email protected]>
---
 .../devicetree/bindings/leds/leds-lp55xx.txt  | 149 +++++++++++++++---
 1 file changed, 124 insertions(+), 25 deletions(-)
Documentation/devicetree/bindings/leds/leds-lp55xx.txt +124 -25
index bfe2805c5534..0ccc1efc2499 100644
@@ -1,6 +1,8 @@
 Binding for TI/National Semiconductor LP55xx LED Drivers
 
 Required properties:
+- #address-cells: 1
+- #size-cells: 0
 - compatible: one of
 	national,lp5521
 	national,lp5523
@@ -14,6 +16,18 @@ Required properties:
 Each child has own specific current settings
 - led-cur: Current setting at each LED channel (mA x10, 0 if LED is not connected)
 - max-cur: Maximun current at each LED channel.
+- reg: Output channel for the LED.  This is zero based channel identifier and
+	the data sheet is a one based channel identifier.
+	reg value to output to LED output number
+	D1 = reg value is 0
+	D2 = reg value is 1
+	D3 = reg value is 2
+	D4 = reg value is 3
+	D5 = reg value is 4
+	D6 = reg value is 5
+	D7 = reg value is 6
+	D8 = reg value is 7
+	D9 = reg value is 8
 
 Optional properties:
 - enable-gpio: GPIO attached to the chip's enable pin
@@ -35,23 +49,28 @@ example 1) LP5521
 on channel 0.
 
 lp5521@32 {
+	#address-cells = <1>;
+	#size-cells = <0>;
 	compatible = "national,lp5521";
 	reg = <0x32>;
 	label = "lp5521_pri";
 	clock-mode = /bits/ 8 <2>;
 
-	chan0 {
+	chan@0 {
+		reg = <0>;
 		led-cur = /bits/ 8 <0x2f>;
 		max-cur = /bits/ 8 <0x5f>;
 		linux,default-trigger = "heartbeat";
 	};
 
-	chan1 {
+	chan@1 {
+		reg = <1>;
 		led-cur = /bits/ 8 <0x2f>;
 		max-cur = /bits/ 8 <0x5f>;
 	};
 
-	chan2 {
+	chan@2 {
+		reg = <2>;
 		led-cur = /bits/ 8 <0x2f>;
 		max-cur = /bits/ 8 <0x5f>;
 	};
@@ -70,59 +89,70 @@ ASEL1    ASEL0    Address
  VEN      VEN       35h
 
 lp5523@32 {
+	#address-cells = <1>;
+	#size-cells = <0>;
 	compatible = "national,lp5523";
 	reg = <0x32>;
 	clock-mode = /bits/ 8 <1>;
 
-	chan0 {
+	chan@0 {
+		reg = <0>;
 		chan-name = "d1";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan1 {
+	chan@1 {
+		reg = <1>;
 		chan-name = "d2";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan2 {
+	chan@2 {
+		reg = <2>;
 		chan-name = "d3";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan3 {
+	chan@3 {
+		reg = <3>;
 		chan-name = "d4";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan4 {
+	chan@4 {
+		reg = <4>;
 		chan-name = "d5";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan5 {
+	chan@5 {
+		reg = <5>;
 		chan-name = "d6";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan6 {
+	chan@6 {
+		reg = <6>;
 		chan-name = "d7";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan7 {
+	chan@7 {
+		reg = <7>;
 		chan-name = "d8";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan8 {
+	chan@8 {
+		reg = <8>;
 		chan-name = "d9";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
@@ -133,29 +163,35 @@ example 3) LP5562
 4 channels are defined.
 
 lp5562@30 {
+	#address-cells = <1>;
+	#size-cells = <0>;
 	compatible = "ti,lp5562";
 	reg = <0x30>;
 	clock-mode = /bits/8 <2>;
 
-	chan0 {
+	chan@0 {
+		reg = <0>;
 		chan-name = "R";
 		led-cur = /bits/ 8 <0x20>;
 		max-cur = /bits/ 8 <0x60>;
 	};
 
-	chan1 {
+	chan@1 {
+		reg = <1>;
 		chan-name = "G";
 		led-cur = /bits/ 8 <0x20>;
 		max-cur = /bits/ 8 <0x60>;
 	};
 
-	chan2 {
+	chan@2 {
+		reg = <2>;
 		chan-name = "B";
 		led-cur = /bits/ 8 <0x20>;
 		max-cur = /bits/ 8 <0x60>;
 	};
 
-	chan3 {
+	chan@3 {
+		reg = <3>;
 		chan-name = "W";
 		led-cur = /bits/ 8 <0x20>;
 		max-cur = /bits/ 8 <0x60>;
@@ -167,62 +203,125 @@ example 4) LP8501
 Others are same as LP5523.
 
 lp8501@32 {
+	#address-cells = <1>;
+	#size-cells = <0>;
 	compatible = "ti,lp8501";
 	reg = <0x32>;
 	clock-mode = /bits/ 8 <2>;
 	pwr-sel = /bits/ 8 <3>;	/* D1~9 connected to VOUT */
 
-	chan0 {
+	chan@0 {
+		reg = <0>;
 		chan-name = "d1";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan1 {
+	chan@1 {
+		reg = <1>;
 		chan-name = "d2";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan2 {
+	chan@2 {
+		reg = <2>;
 		chan-name = "d3";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan3 {
+	chan@3 {
+		reg = <3>;
 		chan-name = "d4";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan4 {
+	chan@4 {
+		reg = <4>;
 		chan-name = "d5";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan5 {
+	chan@5 {
+		reg = <5>;
 		chan-name = "d6";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan6 {
+	chan@6 {
+		reg = <6>;
 		chan-name = "d7";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan7 {
+	chan@7 {
+		reg = <7>;
 		chan-name = "d8";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan8 {
+	chan@8 {
+		reg = <8>;
 		chan-name = "d9";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 };
+
+Multicolor Framework Support
+In addition to the nodes and properties defined above for device support the
+properties below are needed for multicolor framework support as defined in
+Documentation/devicetree/bindings/leds/leds-class-multicolor.txt
+
+Required child properties for multicolor framework
+	- color : Must be LED_COLOR_ID_MULTI
+	- function : see Documentation/devicetree/bindings/leds/common.txt
+
+Required grandchildren properties
+	- reg : This is the LED output of the device
+	- color : see Documentation/devicetree/bindings/leds/common.txt
+
+Multicolor LED example:
+led-controller@32 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	compatible = "national,lp5523";
+	reg = <0x32>;
+	clock-mode = /bits/ 8 <0>; /* LP55XX_CLOCK_AUTO */
+
+	multi-led@2 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <2>;
+		color = <LED_COLOR_ID_MULTI>;
+		function = LED_FUNCTION_STANDBY;
+		linux,default-trigger = "heartbeat";
+
+		led@0 {
+			led-cur = /bits/ 8 <50>;
+			max-cur = /bits/ 8 <100>;
+			reg = <0x0>;
+			color = <LED_COLOR_ID_GREEN>;
+		};
+
+		led@1 {
+			led-cur = /bits/ 8 <50>;
+			max-cur = /bits/ 8 <100>;
+			reg = <0x1>;
+			color = <LED_COLOR_ID_BLUE>;
+		};
+
+		led@6 {
+			led-cur = /bits/ 8 <50>;
+			max-cur = /bits/ 8 <100>;
+			reg = <0x6>;
+			color = <LED_COLOR_ID_RED>;
+		};
+	};
+};
Signature · 1 line
2.25.1
author
#22 lore raw

PATCH v20 8/17 ARM: dts: n900: Add reg property to the LP5523 channel node

In reply to Dan Murphy

Add the reg property to each channel node. This update is to accomodate the multicolor framework. In addition to the accomodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order.

---
 arch/arm/boot/dts/omap3-n900.dts | 29 ++++++++++++++++++++---------
 1 file changed, 20 insertions(+), 9 deletions(-)
arch/arm/boot/dts/omap3-n900.dts +20 -9
index 4089d97405c9..ebe93b06b4f7 100644
@@ -618,63 +618,74 @@ indicator {
 	};
 
 	lp5523: lp5523@32 {
+		#address-cells = <1>;
+		#size-cells = <0>;
 		compatible = "national,lp5523";
 		reg = <0x32>;
 		clock-mode = /bits/ 8 <0>; /* LP55XX_CLOCK_AUTO */
 		enable-gpio = <&gpio2 9 GPIO_ACTIVE_HIGH>; /* 41 */
 
-		chan0 {
+		chan@0 {
 			chan-name = "lp5523:kb1";
 			led-cur = /bits/ 8 <50>;
 			max-cur = /bits/ 8 <100>;
+			reg = <0>;
 		};
 
-		chan1 {
+		chan@1 {
 			chan-name = "lp5523:kb2";
 			led-cur = /bits/ 8 <50>;
 			max-cur = /bits/ 8 <100>;
+			reg = <1>;
 		};
 
-		chan2 {
+		chan@2 {
 			chan-name = "lp5523:kb3";
 			led-cur = /bits/ 8 <50>;
 			max-cur = /bits/ 8 <100>;
+			reg = <2>;
 		};
 
-		chan3 {
+		chan@3 {
 			chan-name = "lp5523:kb4";
 			led-cur = /bits/ 8 <50>;
 			max-cur = /bits/ 8 <100>;
+			reg = <3>;
 		};
 
-		chan4 {
+		chan@4 {
 			chan-name = "lp5523:b";
 			led-cur = /bits/ 8 <50>;
 			max-cur = /bits/ 8 <100>;
+			reg = <4>;
 		};
 
-		chan5 {
+		chan@5 {
 			chan-name = "lp5523:g";
 			led-cur = /bits/ 8 <50>;
 			max-cur = /bits/ 8 <100>;
+			reg = <5>;
 		};
 
-		chan6 {
+		chan@6 {
 			chan-name = "lp5523:r";
 			led-cur = /bits/ 8 <50>;
 			max-cur = /bits/ 8 <100>;
+			reg = <6>;
 		};
 
-		chan7 {
+		chan@7 {
 			chan-name = "lp5523:kb5";
 			led-cur = /bits/ 8 <50>;
 			max-cur = /bits/ 8 <100>;
+			reg = <7>;
 		};
 
-		chan8 {
+		chan@8 {
 			chan-name = "lp5523:kb6";
 			led-cur = /bits/ 8 <50>;
 			max-cur = /bits/ 8 <100>;
+			reg = <8>;
 		};
 	};
 
Signature · 1 line
2.25.1
author
#23 lore raw

PATCH v20 9/17 ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node

In reply to Dan Murphy

Add the reg property to each channel node. This update is to accomodate the multicolor framework. In addition to the accomodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order.

CC Shawn Guo <[email protected]>
CC Sascha Hauer <[email protected]>
CC Pengutronix Kernel Team <[email protected]>
CC Fabio Estevam <[email protected]>
CC NXP Linux Team <[email protected]>
---
 arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)
arch/arm/boot/dts/imx6dl-yapp4-common.dtsi +10 -4
index 2b9423d55c37..77aa90640052 100644
@@ -258,29 +258,35 @@ leds: led-controller@30 {
 		reg = <0x30>;
 		clock-mode = /bits/ 8 <1>;
 		status = "disabled";
+		#address-cells = <1>;
+		#size-cells = <0>;
 
-		chan0 {
+		chan@0 {
 			chan-name = "R";
 			led-cur = /bits/ 8 <0x20>;
 			max-cur = /bits/ 8 <0x60>;
+			reg = <0>;
 		};
 
-		chan1 {
+		chan@1 {
 			chan-name = "G";
 			led-cur = /bits/ 8 <0x20>;
 			max-cur = /bits/ 8 <0x60>;
+			reg = <1>;
 		};
 
-		chan2 {
+		chan@2 {
 			chan-name = "B";
 			led-cur = /bits/ 8 <0x20>;
 			max-cur = /bits/ 8 <0x60>;
+			reg = <2>;
 		};
 
-		chan3 {
+		chan@3 {
 			chan-name = "W";
 			led-cur = /bits/ 8 <0x0>;
 			max-cur = /bits/ 8 <0x0>;
+			reg = <3>;
 		};
 	};
 
Signature · 1 line
2.25.1
Acked-by on v20 9/17
#24 lore raw

Re: [PATCH v20 09/17] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node

Quoted 6 lines · Dan Murphy

Add the reg property to each channel node. This update is to accomodate the multicolor framework. In addition to the accomodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order.

Quoted 6 lines
CC Shawn Guo <[email protected]>
CC Sascha Hauer <[email protected]>
CC Pengutronix Kernel Team <[email protected]>
CC Fabio Estevam <[email protected]>
CC NXP Linux Team <[email protected]>
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
author
#25 lore raw

PATCH v20 10/17 ARM: dts: ste-href: Add reg property to the LP5521 channel nodes

In reply to Dan Murphy

Add the reg property to each channel node. This update is to accomodate the multicolor framework. In addition to the accomodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order.

---
 arch/arm/boot/dts/ste-href.dtsi | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)
arch/arm/boot/dts/ste-href.dtsi +16 -6
index 33e3b0b3c53d..ff47cbf6ed3b 100644
@@ -58,16 +58,21 @@ lp5521@33 {
 				reg = <0x33>;
 				label = "lp5521_pri";
 				clock-mode = /bits/ 8 <2>;
-				chan0 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				chan@0 {
+					reg = <0>;
 					led-cur = /bits/ 8 <0x2f>;
 					max-cur = /bits/ 8 <0x5f>;
 					linux,default-trigger = "heartbeat";
 				};
-				chan1 {
+				chan@1 {
+					reg = <1>;
 					led-cur = /bits/ 8 <0x2f>;
 					max-cur = /bits/ 8 <0x5f>;
 				};
-				chan2 {
+				chan@2 {
+					reg = <2>;
 					led-cur = /bits/ 8 <0x2f>;
 					max-cur = /bits/ 8 <0x5f>;
 				};
@@ -77,15 +82,20 @@ lp5521@34 {
 				reg = <0x34>;
 				label = "lp5521_sec";
 				clock-mode = /bits/ 8 <2>;
-				chan0 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				chan@0 {
+					reg = <0>;
 					led-cur = /bits/ 8 <0x2f>;
 					max-cur = /bits/ 8 <0x5f>;
 				};
-				chan1 {
+				chan@1 {
+					reg = <1>;
 					led-cur = /bits/ 8 <0x2f>;
 					max-cur = /bits/ 8 <0x5f>;
 				};
-				chan2 {
+				chan@2 {
+					reg = <2>;
 					led-cur = /bits/ 8 <0x2f>;
 					max-cur = /bits/ 8 <0x5f>;
 				};
Signature · 1 line
2.25.1
author
#26 lore raw

Re: [PATCH v20 10/17] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes

Linus

Quoted 9 lines · Dan Murphy

Add the reg property to each channel node. This update is to accomodate the multicolor framework. In addition to the accomodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order.

Pavel is asking for a review and if ok your ack

Dan

author
#27 lore raw

PATCH v20 11/17 leds: lp55xx: Convert LED class registration to devm_*

In reply to Dan Murphy

Convert the LED class registration calls to the LED devm_* registration calls.

---
 drivers/leds/leds-lp5521.c        |  9 +++------
 drivers/leds/leds-lp5523.c        |  9 +++------
 drivers/leds/leds-lp5562.c        |  9 +++------
 drivers/leds/leds-lp55xx-common.c | 15 +--------------
 drivers/leds/leds-lp55xx-common.h |  2 --
 drivers/leds/leds-lp8501.c        |  9 +++------
 6 files changed, 13 insertions(+), 40 deletions(-)
drivers/leds/leds-lp5521.c +3 -6
index 6f0272249dc8..6d2163c0f625 100644
@@ -541,19 +541,17 @@ static int lp5521_probe(struct i2c_client *client,
 
 	ret = lp55xx_register_leds(led, chip);
 	if (ret)
-		goto err_register_leds;
+		goto err_out;
 
 	ret = lp55xx_register_sysfs(chip);
 	if (ret) {
 		dev_err(&client->dev, "registering sysfs failed\n");
-		goto err_register_sysfs;
+		goto err_out;
 	}
 
 	return 0;
 
-err_register_sysfs:
-	lp55xx_unregister_leds(led, chip);
-err_register_leds:
+err_out:
 	lp55xx_deinit_device(chip);
 err_init:
 	return ret;
@@ -566,7 +564,6 @@ static int lp5521_remove(struct i2c_client *client)
 
 	lp5521_stop_all_engines(chip);
 	lp55xx_unregister_sysfs(chip);
-	lp55xx_unregister_leds(led, chip);
 	lp55xx_deinit_device(chip);
 
 	return 0;
drivers/leds/leds-lp5523.c +3 -6
index d0b931a136b9..15e7051392f5 100644
@@ -908,19 +908,17 @@ static int lp5523_probe(struct i2c_client *client,
 
 	ret = lp55xx_register_leds(led, chip);
 	if (ret)
-		goto err_register_leds;
+		goto err_out;
 
 	ret = lp55xx_register_sysfs(chip);
 	if (ret) {
 		dev_err(&client->dev, "registering sysfs failed\n");
-		goto err_register_sysfs;
+		goto err_out;
 	}
 
 	return 0;
 
-err_register_sysfs:
-	lp55xx_unregister_leds(led, chip);
-err_register_leds:
+err_out:
 	lp55xx_deinit_device(chip);
 err_init:
 	return ret;
@@ -933,7 +931,6 @@ static int lp5523_remove(struct i2c_client *client)
 
 	lp5523_stop_all_engines(chip);
 	lp55xx_unregister_sysfs(chip);
-	lp55xx_unregister_leds(led, chip);
 	lp55xx_deinit_device(chip);
 
 	return 0;
drivers/leds/leds-lp5562.c +3 -6
index edb57c42e8b1..1c94422408b0 100644
@@ -554,19 +554,17 @@ static int lp5562_probe(struct i2c_client *client,
 
 	ret = lp55xx_register_leds(led, chip);
 	if (ret)
-		goto err_register_leds;
+		goto err_out;
 
 	ret = lp55xx_register_sysfs(chip);
 	if (ret) {
 		dev_err(&client->dev, "registering sysfs failed\n");
-		goto err_register_sysfs;
+		goto err_out;
 	}
 
 	return 0;
 
-err_register_sysfs:
-	lp55xx_unregister_leds(led, chip);
-err_register_leds:
+err_out:
 	lp55xx_deinit_device(chip);
 err_init:
 	return ret;
@@ -580,7 +578,6 @@ static int lp5562_remove(struct i2c_client *client)
 	lp5562_stop_engine(chip);
 
 	lp55xx_unregister_sysfs(chip);
-	lp55xx_unregister_leds(led, chip);
 	lp55xx_deinit_device(chip);
 
 	return 0;
drivers/leds/leds-lp55xx-common.c +1 -14
index 44ced02b49f9..882ef39e4965 100644
@@ -181,7 +181,7 @@ static int lp55xx_init_led(struct lp55xx_led *led,
 		led->cdev.name = name;
 	}
 
-	ret = led_classdev_register(dev, &led->cdev);
+	ret = devm_led_classdev_register(dev, &led->cdev);
 	if (ret) {
 		dev_err(dev, "led register err: %d\n", ret);
 		return ret;
@@ -490,23 +490,10 @@ int lp55xx_register_leds(struct lp55xx_led *led, struct lp55xx_chip *chip)
 	return 0;
 
 err_init_led:
-	lp55xx_unregister_leds(led, chip);
 	return ret;
 }
 EXPORT_SYMBOL_GPL(lp55xx_register_leds);
 
-void lp55xx_unregister_leds(struct lp55xx_led *led, struct lp55xx_chip *chip)
-{
-	int i;
-	struct lp55xx_led *each;
-
-	for (i = 0; i < chip->num_leds; i++) {
-		each = led + i;
-		led_classdev_unregister(&each->cdev);
-	}
-}
-EXPORT_SYMBOL_GPL(lp55xx_unregister_leds);
-
 int lp55xx_register_sysfs(struct lp55xx_chip *chip)
 {
 	struct device *dev = &chip->cl->dev;
drivers/leds/leds-lp55xx-common.h +0 -2
index 783ed5103ce5..b9b1041e8143 100644
@@ -189,8 +189,6 @@ extern void lp55xx_deinit_device(struct lp55xx_chip *chip);
 /* common LED class device functions */
 extern int lp55xx_register_leds(struct lp55xx_led *led,
 				struct lp55xx_chip *chip);
-extern void lp55xx_unregister_leds(struct lp55xx_led *led,
-				struct lp55xx_chip *chip);
 
 /* common device attributes functions */
 extern int lp55xx_register_sysfs(struct lp55xx_chip *chip);
drivers/leds/leds-lp8501.c +3 -6
index 2638dbf0e8ac..a58019cdb8c3 100644
@@ -344,19 +344,17 @@ static int lp8501_probe(struct i2c_client *client,
 
 	ret = lp55xx_register_leds(led, chip);
 	if (ret)
-		goto err_register_leds;
+		goto err_out;
 
 	ret = lp55xx_register_sysfs(chip);
 	if (ret) {
 		dev_err(&client->dev, "registering sysfs failed\n");
-		goto err_register_sysfs;
+		goto err_out;
 	}
 
 	return 0;
 
-err_register_sysfs:
-	lp55xx_unregister_leds(led, chip);
-err_register_leds:
+err_out:
 	lp55xx_deinit_device(chip);
 err_init:
 	return ret;
@@ -369,7 +367,6 @@ static int lp8501_remove(struct i2c_client *client)
 
 	lp8501_stop_engine(chip);
 	lp55xx_unregister_sysfs(chip);
-	lp55xx_unregister_leds(led, chip);
 	lp55xx_deinit_device(chip);
 
 	return 0;
Signature · 1 line
2.25.1
author
#28 lore raw

PATCH v20 12/17 leds: lp55xx: Add multicolor framework support to lp55xx

In reply to Dan Murphy

Add multicolor framework support for the lp55xx family.

---
 drivers/leds/Kconfig                      |   1 +
 drivers/leds/leds-lp5521.c                |  14 +-
 drivers/leds/leds-lp5523.c                |  14 +-
 drivers/leds/leds-lp5562.c                |  13 +-
 drivers/leds/leds-lp55xx-common.c         | 178 +++++++++++++++++++---
 drivers/leds/leds-lp55xx-common.h         |  11 +-
 drivers/leds/leds-lp8501.c                |  14 +-
 include/linux/platform_data/leds-lp55xx.h |   8 +
 8 files changed, 207 insertions(+), 46 deletions(-)
drivers/leds/Kconfig +1 -0
index 66253a2a01d3..d5226ebb28b2 100644
@@ -377,6 +377,7 @@ config LEDS_LP50XX
 config LEDS_LP55XX_COMMON
 	tristate "Common Driver for TI/National LP5521/5523/55231/5562/8501"
 	depends on LEDS_LP5521 || LEDS_LP5523 || LEDS_LP5562 || LEDS_LP8501
+	depends on OF
 	select FW_LOADER
 	select FW_LOADER_USER_HELPER
 	help
drivers/leds/leds-lp5521.c +8 -6
index 6d2163c0f625..6ff81d6be789 100644
@@ -505,9 +505,16 @@ static int lp5521_probe(struct i2c_client *client,
 	struct lp55xx_platform_data *pdata = dev_get_platdata(&client->dev);
 	struct device_node *np = client->dev.of_node;
 
+	chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
+	if (!chip)
+		return -ENOMEM;
+
+	chip->cfg = &lp5521_cfg;
+
 	if (!pdata) {
 		if (np) {
-			pdata = lp55xx_of_populate_pdata(&client->dev, np);
+			pdata = lp55xx_of_populate_pdata(&client->dev, np,
+							 chip);
 			if (IS_ERR(pdata))
 				return PTR_ERR(pdata);
 		} else {
@@ -516,10 +523,6 @@ static int lp5521_probe(struct i2c_client *client,
 		}
 	}
 
-	chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
-	if (!chip)
-		return -ENOMEM;
-
 	led = devm_kcalloc(&client->dev,
 			pdata->num_channels, sizeof(*led), GFP_KERNEL);
 	if (!led)
@@ -527,7 +530,6 @@ static int lp5521_probe(struct i2c_client *client,
 
 	chip->cl = client;
 	chip->pdata = pdata;
-	chip->cfg = &lp5521_cfg;
 
 	mutex_init(&chip->lock);
 
drivers/leds/leds-lp5523.c +8 -6
index 15e7051392f5..b076c16df9ab 100644
@@ -872,9 +872,16 @@ static int lp5523_probe(struct i2c_client *client,
 	struct lp55xx_platform_data *pdata = dev_get_platdata(&client->dev);
 	struct device_node *np = client->dev.of_node;
 
+	chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
+	if (!chip)
+		return -ENOMEM;
+
+	chip->cfg = &lp5523_cfg;
+
 	if (!pdata) {
 		if (np) {
-			pdata = lp55xx_of_populate_pdata(&client->dev, np);
+			pdata = lp55xx_of_populate_pdata(&client->dev, np,
+							 chip);
 			if (IS_ERR(pdata))
 				return PTR_ERR(pdata);
 		} else {
@@ -883,10 +890,6 @@ static int lp5523_probe(struct i2c_client *client,
 		}
 	}
 
-	chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
-	if (!chip)
-		return -ENOMEM;
-
 	led = devm_kcalloc(&client->dev,
 			pdata->num_channels, sizeof(*led), GFP_KERNEL);
 	if (!led)
@@ -894,7 +897,6 @@ static int lp5523_probe(struct i2c_client *client,
 
 	chip->cl = client;
 	chip->pdata = pdata;
-	chip->cfg = &lp5523_cfg;
 
 	mutex_init(&chip->lock);
 
drivers/leds/leds-lp5562.c +8 -5
index 1c94422408b0..7ecdd199d7ef 100644
@@ -520,9 +520,16 @@ static int lp5562_probe(struct i2c_client *client,
 	struct lp55xx_platform_data *pdata = dev_get_platdata(&client->dev);
 	struct device_node *np = client->dev.of_node;
 
+	chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
+	if (!chip)
+		return -ENOMEM;
+
+	chip->cfg = &lp5562_cfg;
+
 	if (!pdata) {
 		if (np) {
-			pdata = lp55xx_of_populate_pdata(&client->dev, np);
+			pdata = lp55xx_of_populate_pdata(&client->dev, np,
+							 chip);
 			if (IS_ERR(pdata))
 				return PTR_ERR(pdata);
 		} else {
@@ -531,9 +538,6 @@ static int lp5562_probe(struct i2c_client *client,
 		}
 	}
 
-	chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
-	if (!chip)
-		return -ENOMEM;
 
 	led = devm_kcalloc(&client->dev,
 			pdata->num_channels, sizeof(*led), GFP_KERNEL);
@@ -542,7 +546,6 @@ static int lp5562_probe(struct i2c_client *client,
 
 	chip->cl = client;
 	chip->pdata = pdata;
-	chip->cfg = &lp5562_cfg;
 
 	mutex_init(&chip->lock);
 
drivers/leds/leds-lp55xx-common.c +156 -22

235 lines not on this page · raw message

drivers/leds/leds-lp55xx-common.h +10 -1
index b9b1041e8143..a9d7ba3f2fd1 100644
@@ -12,6 +12,8 @@
 #ifndef _LEDS_LP55XX_COMMON_H
 #define _LEDS_LP55XX_COMMON_H
 
+#include <linux/led-class-multicolor.h>
+
 enum lp55xx_engine_index {
 	LP55XX_ENGINE_INVALID,
 	LP55XX_ENGINE_1,
@@ -109,6 +111,9 @@ struct lp55xx_device_config {
 	/* access brightness register */
 	int (*brightness_fn)(struct lp55xx_led *led);
 
+	/* perform brightness value to multiple LEDs */
+	int (*multicolor_brightness_fn)(struct lp55xx_led *led);
+
 	/* current setting function */
 	void (*set_led_current) (struct lp55xx_led *led, u8 led_current);
 
@@ -159,6 +164,8 @@ struct lp55xx_chip {
  * struct lp55xx_led
  * @chan_nr         : Channel number
  * @cdev            : LED class device
+ * @mc_cdev	    : Multi color class device
+ * @color_components: Multi color LED map information
  * @led_current     : Current setting at each led channel
  * @max_current     : Maximun current at each led channel
  * @brightness      : Brightness value
@@ -167,6 +174,7 @@ struct lp55xx_chip {
 struct lp55xx_led {
 	int chan_nr;
 	struct led_classdev cdev;
+	struct led_classdev_mc mc_cdev;
 	u8 led_current;
 	u8 max_current;
 	u8 brightness;
@@ -196,6 +204,7 @@ extern void lp55xx_unregister_sysfs(struct lp55xx_chip *chip);
 
 /* common device tree population function */
 extern struct lp55xx_platform_data
-*lp55xx_of_populate_pdata(struct device *dev, struct device_node *np);
+*lp55xx_of_populate_pdata(struct device *dev, struct device_node *np,
+			  struct lp55xx_chip *chip);
 
 #endif /* _LEDS_LP55XX_COMMON_H */
drivers/leds/leds-lp8501.c +8 -6
index a58019cdb8c3..ac2c31db4a65 100644
@@ -308,9 +308,16 @@ static int lp8501_probe(struct i2c_client *client,
 	struct lp55xx_platform_data *pdata = dev_get_platdata(&client->dev);
 	struct device_node *np = client->dev.of_node;
 
+	chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
+	if (!chip)
+		return -ENOMEM;
+
+	chip->cfg = &lp8501_cfg;
+
 	if (!pdata) {
 		if (np) {
-			pdata = lp55xx_of_populate_pdata(&client->dev, np);
+			pdata = lp55xx_of_populate_pdata(&client->dev, np,
+							 chip);
 			if (IS_ERR(pdata))
 				return PTR_ERR(pdata);
 		} else {
@@ -319,10 +326,6 @@ static int lp8501_probe(struct i2c_client *client,
 		}
 	}
 
-	chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
-	if (!chip)
-		return -ENOMEM;
-
 	led = devm_kcalloc(&client->dev,
 			pdata->num_channels, sizeof(*led), GFP_KERNEL);
 	if (!led)
@@ -330,7 +333,6 @@ static int lp8501_probe(struct i2c_client *client,
 
 	chip->cl = client;
 	chip->pdata = pdata;
-	chip->cfg = &lp8501_cfg;
 
 	mutex_init(&chip->lock);
 
include/linux/platform_data/leds-lp55xx.h +8 -0
index 96a787100fda..d85275aea38c 100644
@@ -12,17 +12,25 @@
 #ifndef _LEDS_LP55XX_H
 #define _LEDS_LP55XX_H
 
+#include <linux/led-class-multicolor.h>
+
 /* Clock configuration */
 #define LP55XX_CLOCK_AUTO	0
 #define LP55XX_CLOCK_INT	1
 #define LP55XX_CLOCK_EXT	2
 
+#define LP55XX_MAX_GROUPED_CHAN	4
+
 struct lp55xx_led_config {
 	const char *name;
 	const char *default_trigger;
 	u8 chan_nr;
 	u8 led_current; /* mA x10, 0 if led is not connected */
 	u8 max_current;
+	int num_colors;
+	unsigned int max_channel;
+	int color_id[LED_COLOR_ID_MAX];
+	int output_num[LED_COLOR_ID_MAX];
 };
 
 struct lp55xx_predef_pattern {
Signature · 1 line
2.25.1
Acked-by on v20 12/17
#29 lore raw

Re: [PATCH v20 12/17] leds: lp55xx: Add multicolor framework support to lp55xx

Quoted 3 lines · Dan Murphy

Add multicolor framework support for the lp55xx family.

drivers/leds/leds-lp55xx-common.h struct lp55xx_chip { · line 168

Quoted 6 lines
drivers/leds/leds-lp55xx-common.h +2 -0
@@ -159,6 +164,8 @@ struct lp55xx_chip {
  * struct lp55xx_led
  * @chan_nr         : Channel number
  * @cdev            : LED class device
+ * @mc_cdev	    : Multi color class device
+ * @color_components: Multi color LED map information

Whitespace is funny here.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#30 lore raw

Re: [PATCH v20 12/17] leds: lp55xx: Add multicolor framework support to lp55xx

In reply to Dan Murphy

Hi Dan,

One nit below.

Quoted 14 lines · Dan Murphy

Add multicolor framework support for the lp55xx family.

---
  drivers/leds/Kconfig                      |   1 +
  drivers/leds/leds-lp5521.c                |  14 +-
  drivers/leds/leds-lp5523.c                |  14 +-
  drivers/leds/leds-lp5562.c                |  13 +-
  drivers/leds/leds-lp55xx-common.c         | 178 +++++++++++++++++++---
  drivers/leds/leds-lp55xx-common.h         |  11 +-
  drivers/leds/leds-lp8501.c                |  14 +-
  include/linux/platform_data/leds-lp55xx.h |   8 +
  8 files changed, 207 insertions(+), 46 deletions(-)

[...]

Quoted 14 lines
drivers/leds/leds-lp55xx-common.h +2 -0
index b9b1041e8143..a9d7ba3f2fd1 100644
@@ -12,6 +12,8 @@
  #ifndef _LEDS_LP55XX_COMMON_H
  #define _LEDS_LP55XX_COMMON_H
 
+#include <linux/led-class-multicolor.h>
+
  enum lp55xx_engine_index {
  	LP55XX_ENGINE_INVALID,
  	LP55XX_ENGINE_1,

drivers/leds/leds-lp55xx-common.h struct lp55xx_device_config { · line 115

Quoted 5 lines
drivers/leds/leds-lp55xx-common.h +2 -0
@@ -109,6 +111,9 @@ struct lp55xx_device_config {
  	/* access brightness register */
  	int (*brightness_fn)(struct lp55xx_led *led);
 
+	/* perform brightness value to multiple LEDs */
+	int (*multicolor_brightness_fn)(struct lp55xx_led *led);

Isn't some word missing here? IMO it should be rephrased. Maybe "write multi color brightness to hw" ?

Quoted 3 lines
drivers/leds/leds-lp55xx-common.h +0 -0
  	/* current setting function */
  	void (*set_led_current) (struct lp55xx_led *led, u8 led_current);
 

[...]

Signature · 2 lines
Best regards,
Jacek Anaszewski
author
#31 lore raw

Re: [PATCH v20 12/17] leds: lp55xx: Add multicolor framework support to lp55xx

Jacek

Quoted 32 lines · Jacek Anaszewski

Hi Dan,

One nit below.

Quoted 14 lines · Dan Murphy

Add multicolor framework support for the lp55xx family.

---
  drivers/leds/Kconfig                      |   1 +

  drivers/leds/leds-lp5521.c                |  14 +-
  drivers/leds/leds-lp5523.c                |  14 +-
  drivers/leds/leds-lp5562.c                |  13 +-

  drivers/leds/leds-lp55xx-common.c         | 178 +++++++++++++++++++--- drivers/leds/leds-lp55xx-common.h         |  11 +- drivers/leds/leds-lp8501.c                |  14 +- include/linux/platform_data/leds-lp55xx.h |   8 +

  8 files changed, 207 insertions(+), 46 deletions(-)

[...]

Quoted 12 lines
drivers/leds/leds-lp55xx-common.h +0 -0
index b9b1041e8143..a9d7ba3f2fd1 100644
@@ -12,6 +12,8 @@
   #ifndef _LEDS_LP55XX_COMMON_H
   #define _LEDS_LP55XX_COMMON_H

  +#include <linux/led-class-multicolor.h>
+
  enum lp55xx_engine_index {
      LP55XX_ENGINE_INVALID,
      LP55XX_ENGINE_1,

Quoted 9 lines
Quoted 5 lines
drivers/leds/leds-lp55xx-common.h +0 -0
@@ -109,6 +111,9 @@ struct lp55xx_device_config {
       /* access brightness register */
       int (*brightness_fn)(struct lp55xx_led *led);

  +    /* perform brightness value to multiple LEDs */ +    int (*multicolor_brightness_fn)(struct lp55xx_led *led);

Isn't some word missing here? IMO it should be rephrased. Maybe "write multi color brightness to hw" ?

But brightness_fn does not say write_brightness_fn so I think this would look weird to add write to the function name

Dan

#32 lore raw

Re: [PATCH v20 12/17] leds: lp55xx: Add multicolor framework support to lp55xx

Dan,

Quoted 44 lines · Dan Murphy

Jacek

Quoted 32 lines · Jacek Anaszewski

Hi Dan,

One nit below.

Quoted 14 lines · Dan Murphy

Add multicolor framework support for the lp55xx family.

---
  drivers/leds/Kconfig                      |   1 +

  drivers/leds/leds-lp5521.c                |  14 +-
  drivers/leds/leds-lp5523.c                |  14 +-
  drivers/leds/leds-lp5562.c                |  13 +-

  drivers/leds/leds-lp55xx-common.c         | 178 +++++++++++++++++++--- drivers/leds/leds-lp55xx-common.h         |  11 +- drivers/leds/leds-lp8501.c                |  14 +- include/linux/platform_data/leds-lp55xx.h |   8 +

  8 files changed, 207 insertions(+), 46 deletions(-)

[...]

Quoted 12 lines
drivers/leds/leds-lp55xx-common.h +0 -0
index b9b1041e8143..a9d7ba3f2fd1 100644
@@ -12,6 +12,8 @@
   #ifndef _LEDS_LP55XX_COMMON_H
   #define _LEDS_LP55XX_COMMON_H

  +#include <linux/led-class-multicolor.h>
+
  enum lp55xx_engine_index {
      LP55XX_ENGINE_INVALID,
      LP55XX_ENGINE_1,

Quoted 9 lines
Quoted 5 lines
drivers/leds/leds-lp55xx-common.h +0 -0
@@ -109,6 +111,9 @@ struct lp55xx_device_config {
       /* access brightness register */
       int (*brightness_fn)(struct lp55xx_led *led);

  +    /* perform brightness value to multiple LEDs */ +    int (*multicolor_brightness_fn)(struct lp55xx_led *led);

Isn't some word missing here? IMO it should be rephrased. Maybe "write multi color brightness to hw" ?

Quoted 1 line

But brightness_fn does not say write_brightness_fn so I think this would look weird to add write to the function name

I referred to the comment, not to the function name. And the comment for brightness_fn is vague IMO. So I propose to change both comments:

s/access brightness register/set LED brightness/
s/perform brightness value to multiple LEDs/
set multicolor LED brightness/

Signature · 2 lines
Best regards,
Jacek Anaszewski
author
#33 lore raw

Re: [PATCH v20 12/17] leds: lp55xx: Add multicolor framework support to lp55xx

Jacek

Quoted 50 lines · Jacek Anaszewski

Dan,

Quoted 45 lines · Dan Murphy

Jacek

Quoted 33 lines · Jacek Anaszewski

Hi Dan,

One nit below.

Quoted 15 lines · Dan Murphy

Add multicolor framework support for the lp55xx family.

---
  drivers/leds/Kconfig                      |   1 +

  drivers/leds/leds-lp5521.c                |  14 +-
  drivers/leds/leds-lp5523.c                |  14 +-
  drivers/leds/leds-lp5562.c                |  13 +-

  drivers/leds/leds-lp55xx-common.c         | 178
+++++++++++++++++++---
  drivers/leds/leds-lp55xx-common.h         |  11 +- drivers/leds/leds-lp8501.c                |  14 +- include/linux/platform_data/leds-lp55xx.h |   8 +

  8 files changed, 207 insertions(+), 46 deletions(-)

[...]

Quoted 12 lines
drivers/leds/leds-lp55xx-common.h +0 -0
index b9b1041e8143..a9d7ba3f2fd1 100644
@@ -12,6 +12,8 @@
   #ifndef _LEDS_LP55XX_COMMON_H
   #define _LEDS_LP55XX_COMMON_H

  +#include <linux/led-class-multicolor.h>
+
  enum lp55xx_engine_index {
      LP55XX_ENGINE_INVALID,
      LP55XX_ENGINE_1,

Quoted 9 lines
Quoted 5 lines
drivers/leds/leds-lp55xx-common.h +0 -0
@@ -109,6 +111,9 @@ struct lp55xx_device_config {
       /* access brightness register */
       int (*brightness_fn)(struct lp55xx_led *led);

  +    /* perform brightness value to multiple LEDs */ +    int (*multicolor_brightness_fn)(struct lp55xx_led *led);

Isn't some word missing here? IMO it should be rephrased. Maybe "write multi color brightness to hw" ?

Quoted 1 line

But brightness_fn does not say write_brightness_fn so I think this would look weird to add write to the function name

Quoted 8 lines

I referred to the comment, not to the function name. And the comment for brightness_fn is vague IMO. So I propose to change both comments:

s/access brightness register/set LED brightness/
s/perform brightness value to multiple LEDs/
  set multicolor LED brightness/

Obviously I misunderstood.  I thought that was for the preceding line of code that the comment was made.

I will update the comment.

Dan

author
#34 lore raw

PATCH v20 13/17 leds: lp5523: Update the lp5523 code to add multicolor brightness function

In reply to Dan Murphy

Add the multicolor brightness call back to support the multicolor framework. This call back allows setting brightness on grouped channels in a single function.

---
 drivers/leds/leds-lp5523.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
drivers/leds/leds-lp5523.c +20 -0
index b076c16df9ab..80d364f237d0 100644
@@ -791,6 +791,25 @@ static ssize_t store_master_fader_leds(struct device *dev,
 	return ret;
 }
 
+static int lp5523_multicolor_brightness(struct lp55xx_led *led)
+{
+	struct lp55xx_chip *chip = led->chip;
+	int ret;
+	int i;
+
+	mutex_lock(&chip->lock);
+	for (i = 0; i < led->mc_cdev.num_colors; i++) {
+		ret = lp55xx_write(chip,
+				   LP5523_REG_LED_PWM_BASE +
+				   led->mc_cdev.multicolor_info[i].color_channel,
+				   led->mc_cdev.multicolor_info[i].color_brightness);
+		if (ret)
+			break;
+	}
+	mutex_unlock(&chip->lock);
+	return ret;
+}
+
 static int lp5523_led_brightness(struct lp55xx_led *led)
 {
 	struct lp55xx_chip *chip = led->chip;
@@ -857,6 +876,7 @@ static struct lp55xx_device_config lp5523_cfg = {
 	.max_channel  = LP5523_MAX_LEDS,
 	.post_init_device   = lp5523_post_init_device,
 	.brightness_fn      = lp5523_led_brightness,
+	.multicolor_brightness_fn = lp5523_multicolor_brightness,
 	.set_led_current    = lp5523_set_led_current,
 	.firmware_cb        = lp5523_firmware_loaded,
 	.run_engine         = lp5523_run_engine,
Signature · 1 line
2.25.1
Acked-by on v20 13/17
#35 lore raw

Re: [PATCH v20 13/17] leds: lp5523: Update the lp5523 code to add multicolor brightness function

Quoted 2 lines · Dan Murphy

Add the multicolor brightness call back to support the multicolor framework. This call back allows setting brightness on grouped channels

Double space after "setting".

Quoted 3 lines

in a single function.

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
author
#36 lore raw

PATCH v20 14/17 leds: lp5521: Add multicolor framework multicolor brightness support

In reply to Dan Murphy

Add the multicolor brightness call back to support the multicolor framework. This function allows setting the brightness across grouped LED channels in a single call.

---
 drivers/leds/leds-lp5521.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
drivers/leds/leds-lp5521.c +20 -0
index 6ff81d6be789..26498d5d3bb3 100644
@@ -349,6 +349,25 @@ static int lp5521_run_selftest(struct lp55xx_chip *chip, char *buf)
 	return 0;
 }
 
+static int lp5521_multicolor_brightness(struct lp55xx_led *led)
+{
+	struct lp55xx_chip *chip = led->chip;
+	int ret;
+	int i;
+
+	mutex_lock(&chip->lock);
+	for (i = 0; i < led->mc_cdev.num_colors; i++) {
+		ret = lp55xx_write(chip,
+				   LP5521_REG_LED_PWM_BASE +
+				   led->mc_cdev.multicolor_info[i].color_channel,
+				   led->mc_cdev.multicolor_info[i].color_brightness);
+		if (ret)
+			break;
+	}
+	mutex_unlock(&chip->lock);
+	return ret;
+}
+
 static int lp5521_led_brightness(struct lp55xx_led *led)
 {
 	struct lp55xx_chip *chip = led->chip;
@@ -490,6 +509,7 @@ static struct lp55xx_device_config lp5521_cfg = {
 	.max_channel  = LP5521_MAX_LEDS,
 	.post_init_device   = lp5521_post_init_device,
 	.brightness_fn      = lp5521_led_brightness,
+	.multicolor_brightness_fn = lp5521_multicolor_brightness,
 	.set_led_current    = lp5521_set_led_current,
 	.firmware_cb        = lp5521_firmware_loaded,
 	.run_engine         = lp5521_run_engine,
Signature · 1 line
2.25.1
#37 lore raw

Re: [PATCH v20 14/17] leds: lp5521: Add multicolor framework multicolor brightness support

Quoted 5 lines · Dan Murphy

Add the multicolor brightness call back to support the multicolor framework. This function allows setting the brightness across grouped LED channels in a single call.

ACK.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
author
#38 lore raw

PATCH v20 15/17 leds: lp55xx: Fix checkpatch file permissions issues

In reply to Dan Murphy

Fix the checkpatch warnings for the use of the file permission macros. In converting the file permissions to the DEVICE_ATTR_XX macros the call back function names needed to be updated within the code.

This means that the lp55xx_ needed to be dropped in the name to keep in harmony with the ABI documentation.

---
 drivers/leds/leds-lp55xx-common.c | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)
drivers/leds/leds-lp55xx-common.c +10 -12
index f32105f8bfca..ba761824447e 100644
@@ -83,7 +83,7 @@ static int lp55xx_post_init_device(struct lp55xx_chip *chip)
 	return cfg->post_init_device(chip);
 }
 
-static ssize_t lp55xx_show_current(struct device *dev,
+static ssize_t led_current_show(struct device *dev,
 			    struct device_attribute *attr,
 			    char *buf)
 {
@@ -92,7 +92,7 @@ static ssize_t lp55xx_show_current(struct device *dev,
 	return scnprintf(buf, PAGE_SIZE, "%d\n", led->led_current);
 }
 
-static ssize_t lp55xx_store_current(struct device *dev,
+static ssize_t led_current_store(struct device *dev,
 			     struct device_attribute *attr,
 			     const char *buf, size_t len)
 {
@@ -116,7 +116,7 @@ static ssize_t lp55xx_store_current(struct device *dev,
 	return len;
 }
 
-static ssize_t lp55xx_show_max_current(struct device *dev,
+static ssize_t max_current_show(struct device *dev,
 			    struct device_attribute *attr,
 			    char *buf)
 {
@@ -125,9 +125,8 @@ static ssize_t lp55xx_show_max_current(struct device *dev,
 	return scnprintf(buf, PAGE_SIZE, "%d\n", led->max_current);
 }
 
-static DEVICE_ATTR(led_current, S_IRUGO | S_IWUSR, lp55xx_show_current,
-		lp55xx_store_current);
-static DEVICE_ATTR(max_current, S_IRUGO , lp55xx_show_max_current, NULL);
+static DEVICE_ATTR_RW(led_current);
+static DEVICE_ATTR_RO(max_current);
 
 static struct attribute *lp55xx_led_attrs[] = {
 	&dev_attr_led_current.attr,
@@ -272,7 +271,7 @@ static int lp55xx_request_firmware(struct lp55xx_chip *chip)
 				GFP_KERNEL, chip, lp55xx_firmware_loaded);
 }
 
-static ssize_t lp55xx_show_engine_select(struct device *dev,
+static ssize_t select_engine_show(struct device *dev,
 			    struct device_attribute *attr,
 			    char *buf)
 {
@@ -282,7 +281,7 @@ static ssize_t lp55xx_show_engine_select(struct device *dev,
 	return sprintf(buf, "%d\n", chip->engine_idx);
 }
 
-static ssize_t lp55xx_store_engine_select(struct device *dev,
+static ssize_t select_engine_store(struct device *dev,
 			     struct device_attribute *attr,
 			     const char *buf, size_t len)
 {
@@ -324,7 +323,7 @@ static inline void lp55xx_run_engine(struct lp55xx_chip *chip, bool start)
 		chip->cfg->run_engine(chip, start);
 }
 
-static ssize_t lp55xx_store_engine_run(struct device *dev,
+static ssize_t run_engine_store(struct device *dev,
 			     struct device_attribute *attr,
 			     const char *buf, size_t len)
 {
@@ -349,9 +348,8 @@ static ssize_t lp55xx_store_engine_run(struct device *dev,
 	return len;
 }
 
-static DEVICE_ATTR(select_engine, S_IRUGO | S_IWUSR,
-		   lp55xx_show_engine_select, lp55xx_store_engine_select);
-static DEVICE_ATTR(run_engine, S_IWUSR, NULL, lp55xx_store_engine_run);
+static DEVICE_ATTR_RW(select_engine);
+static DEVICE_ATTR_WO(run_engine);
 
 static struct attribute *lp55xx_engine_attributes[] = {
 	&dev_attr_select_engine.attr,
Signature · 1 line
2.25.1
author
#39 lore raw

PATCH v20 16/17 leds: lp5523: Fix checkpatch issues in the code

In reply to Dan Murphy

Fix checkpatch errors and warnings for the LP5523.c device driver.

---
 drivers/leds/leds-lp5523.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)
drivers/leds/leds-lp5523.c +10 -9
index 80d364f237d0..8ce278348495 100644
@@ -23,13 +23,13 @@
 
 #define LP5523_PROGRAM_LENGTH		32	/* bytes */
 /* Memory is used like this:
-   0x00 engine 1 program
-   0x10 engine 2 program
-   0x20 engine 3 program
-   0x30 engine 1 muxing info
-   0x40 engine 2 muxing info
-   0x50 engine 3 muxing info
-*/
+ * 0x00 engine 1 program
+ * 0x10 engine 2 program
+ * 0x20 engine 3 program
+ * 0x30 engine 1 muxing info
+ * 0x40 engine 2 muxing info
+ * 0x50 engine 3 muxing info
+ */
 #define LP5523_MAX_LEDS			9
 
 /* Registers */
@@ -326,7 +326,7 @@ static int lp5523_update_program_memory(struct lp55xx_chip *chip,
 					const u8 *data, size_t size)
 {
 	u8 pattern[LP5523_PROGRAM_LENGTH] = {0};
-	unsigned cmd;
+	unsigned int cmd;
 	char c[3];
 	int nrchars;
 	int ret;
@@ -468,6 +468,7 @@ static int lp5523_mux_parse(const char *buf, u16 *mux, size_t len)
 static void lp5523_mux_to_array(u16 led_mux, char *array)
 {
 	int i, pos = 0;
+
 	for (i = 0; i < LP5523_MAX_LEDS; i++)
 		pos += sprintf(array + pos, "%x", LED_ACTIVE(led_mux, i));
 
@@ -506,7 +507,7 @@ static int lp5523_load_mux(struct lp55xx_chip *chip, u16 mux, int nr)
 	if (ret)
 		return ret;
 
-	ret = lp55xx_write(chip, LP5523_REG_PROG_MEM , (u8)(mux >> 8));
+	ret = lp55xx_write(chip, LP5523_REG_PROG_MEM, (u8)(mux >> 8));
 	if (ret)
 		return ret;
 
Signature · 1 line
2.25.1
author
#40 lore raw

PATCH v20 17/17 dt: bindings: Update lp55xx binding to recommended LED naming

In reply to Dan Murphy

Update the LP55xx DT binding examples to the recommended node naming convention. There are no changes to the DT properties.

CC Rob Herring <[email protected]>
CC Tony Lindgren <[email protected]>
CC "Benoît Cousson" <[email protected]>
CC Linus Walleij <[email protected]>
CC Shawn Guo <[email protected]>
CC Sascha Hauer <[email protected]>
CC Pengutronix Kernel Team <[email protected]>
CC Fabio Estevam <[email protected]>
CC NXP Linux Team <[email protected]>
---
 .../devicetree/bindings/leds/leds-lp55xx.txt  | 58 +++++++++----------
 1 file changed, 29 insertions(+), 29 deletions(-)
Documentation/devicetree/bindings/leds/leds-lp55xx.txt +29 -29
index 0ccc1efc2499..5475f45ef51f 100644
@@ -48,7 +48,7 @@ example 1) LP5521
 'lp5521_pri:channel1' and 'lp5521_pri:channel2', with a heartbeat trigger
 on channel 0.
 
-lp5521@32 {
+led-controller@32 {
 	#address-cells = <1>;
 	#size-cells = <0>;
 	compatible = "national,lp5521";
@@ -56,20 +56,20 @@ lp5521@32 {
 	label = "lp5521_pri";
 	clock-mode = /bits/ 8 <2>;
 
-	chan@0 {
+	led@0 {
 		reg = <0>;
 		led-cur = /bits/ 8 <0x2f>;
 		max-cur = /bits/ 8 <0x5f>;
 		linux,default-trigger = "heartbeat";
 	};
 
-	chan@1 {
+	led@1 {
 		reg = <1>;
 		led-cur = /bits/ 8 <0x2f>;
 		max-cur = /bits/ 8 <0x5f>;
 	};
 
-	chan@2 {
+	led@2 {
 		reg = <2>;
 		led-cur = /bits/ 8 <0x2f>;
 		max-cur = /bits/ 8 <0x5f>;
@@ -88,70 +88,70 @@ ASEL1    ASEL0    Address
  VEN      GND       34h
  VEN      VEN       35h
 
-lp5523@32 {
+led-controller@32 {
 	#address-cells = <1>;
 	#size-cells = <0>;
 	compatible = "national,lp5523";
 	reg = <0x32>;
 	clock-mode = /bits/ 8 <1>;
 
-	chan@0 {
+	led@0 {
 		reg = <0>;
 		chan-name = "d1";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan@1 {
+	led@1 {
 		reg = <1>;
 		chan-name = "d2";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan@2 {
+	led@2 {
 		reg = <2>;
 		chan-name = "d3";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan@3 {
+	led@3 {
 		reg = <3>;
 		chan-name = "d4";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan@4 {
+	led@4 {
 		reg = <4>;
 		chan-name = "d5";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan@5 {
+	led@5 {
 		reg = <5>;
 		chan-name = "d6";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan@6 {
+	led@6 {
 		reg = <6>;
 		chan-name = "d7";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan@7 {
+	led@7 {
 		reg = <7>;
 		chan-name = "d8";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan@8 {
+	led@8 {
 		reg = <8>;
 		chan-name = "d9";
 		led-cur = /bits/ 8 <0x14>;
@@ -162,35 +162,35 @@ lp5523@32 {
 example 3) LP5562
 4 channels are defined.
 
-lp5562@30 {
+led-controller@30 {
 	#address-cells = <1>;
 	#size-cells = <0>;
 	compatible = "ti,lp5562";
 	reg = <0x30>;
 	clock-mode = /bits/8 <2>;
 
-	chan@0 {
+	led@0 {
 		reg = <0>;
 		chan-name = "R";
 		led-cur = /bits/ 8 <0x20>;
 		max-cur = /bits/ 8 <0x60>;
 	};
 
-	chan@1 {
+	led@1 {
 		reg = <1>;
 		chan-name = "G";
 		led-cur = /bits/ 8 <0x20>;
 		max-cur = /bits/ 8 <0x60>;
 	};
 
-	chan@2 {
+	led@2 {
 		reg = <2>;
 		chan-name = "B";
 		led-cur = /bits/ 8 <0x20>;
 		max-cur = /bits/ 8 <0x60>;
 	};
 
-	chan@3 {
+	led@3 {
 		reg = <3>;
 		chan-name = "W";
 		led-cur = /bits/ 8 <0x20>;
@@ -202,7 +202,7 @@ example 4) LP8501
 9 channels are defined. The 'pwr-sel' is LP8501 specific property.
 Others are same as LP5523.
 
-lp8501@32 {
+led-controller@32 {
 	#address-cells = <1>;
 	#size-cells = <0>;
 	compatible = "ti,lp8501";
@@ -210,63 +210,63 @@ lp8501@32 {
 	clock-mode = /bits/ 8 <2>;
 	pwr-sel = /bits/ 8 <3>;	/* D1~9 connected to VOUT */
 
-	chan@0 {
+	led@0 {
 		reg = <0>;
 		chan-name = "d1";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan@1 {
+	led@1 {
 		reg = <1>;
 		chan-name = "d2";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan@2 {
+	led@2 {
 		reg = <2>;
 		chan-name = "d3";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan@3 {
+	led@3 {
 		reg = <3>;
 		chan-name = "d4";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan@4 {
+	led@4 {
 		reg = <4>;
 		chan-name = "d5";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan@5 {
+	led@5 {
 		reg = <5>;
 		chan-name = "d6";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan@6 {
+	led@6 {
 		reg = <6>;
 		chan-name = "d7";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan@7 {
+	led@7 {
 		reg = <7>;
 		chan-name = "d8";
 		led-cur = /bits/ 8 <0x14>;
 		max-cur = /bits/ 8 <0x20>;
 	};
 
-	chan@8 {
+	led@8 {
 		reg = <8>;
 		chan-name = "d9";
 		led-cur = /bits/ 8 <0x14>;
Signature · 1 line
2.25.1
#41 lore raw
In reply to Dan Murphy

Hi!

Quoted 5 lines

This is the multi color LED framework. This framework presents clustered
colored LEDs into an array and allows the user space to adjust the brightness of the cluster using a single file write. The individual colored LEDs intensities are controlled via a single file that is an array of LEDs

Thanks for the series.

I believe 6/, 11/, 15/, 16/ could be applied now. Should I do that?

8..10/ might be ready, too... but I'm not relevant maintainer, so you'll need to push them separately. I added my acks.

Best regards,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
author
#42 lore raw

Pavel

Quoted 8 lines · Pavel Machek

Hi!

Quoted 5 lines

This is the multi color LED framework. This framework presents clustered
colored LEDs into an array and allows the user space to adjust the brightness of the cluster using a single file write. The individual colored LEDs intensities are controlled via a single file that is an array of LEDs

Thanks for the series.

Thank you for taking the time to review this series.  I would prefer them to all go in at the same time as the LP50xx and LP55xx devices were tested incrementally and together as a full series.

I need to check back a few series patches 8->10 may have acks from maintainers but may have gotten lost.  If I find the maintainer ack I will post the URL where they ack'd it if not I will ask the maintainer for their review and ACK.

Dan

Quoted 8 lines

I believe 6/, 11/, 15/, 16/ could be applied now. Should I do that?

8..10/ might be ready, too... but I'm not relevant maintainer, so you'll need to push them separately. I added my acks.

Best regards,
Pavel

author
#43 lore raw

Pavel

Quoted 10 lines · Dan Murphy

Pavel

Quoted 7 lines · Pavel Machek

Hi!

Quoted 5 lines

This is the multi color LED framework. This framework presents clustered colored LEDs into an array and allows the user space to adjust the brightness of the cluster using a single file write.  The individual colored LEDs intensities are controlled via a single file that is an array of LEDs

Quoted 14 lines
Quoted 1 line

Thanks for the series.

Thank you for taking the time to review this series.  I would prefer them to all go in at the same time as the LP50xx and LP55xx devices were tested incrementally and together as a full series.

I need to check back a few series patches 8->10 may have acks from maintainers but may have gotten lost.  If I find the maintainer ack I will post the URL where they ack'd it if not I will ask the maintainer for their review and ACK.

Dan

Quoted 6 lines

I believe 6/, 11/, 15/, 16/ could be applied now. Should I do that?

8..10/ might be ready, too... but I'm not relevant maintainer, so you'll need to push them separately. I added my acks.

8 was acked by the maintainer 9/10/11 were not.

I should be able to post v21 tomorrow.  Just need to finish making changes and test them

Dan

Quoted 2 lines
Quoted 2 lines

Best regards,
                                    Pavel