Skip to contentSkip to conversation

net: ravb: Initialize PHY in probe() once

PATCH New Marek Vasut 3 participants 4 messages Feb 13, 2018 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: ravb: Initialize PHY in probe() once

Reset and initialize the PHY once in the probe() function rather than doing it over and over again is start() function. This requires us to keep the clock enabled while the driver is in use. This significantly reduces the time between transfers as the PHY doesn't have to restart autonegotiation between transfers, which takes forever.

Cc Geert Uytterhoeven <[email protected]>
Cc Joe Hershberger <[email protected]>
---
 drivers/net/ravb.c | 32 +++++++++++++++++++-------------
 1 file changed, 19 insertions(+), 13 deletions(-)
drivers/net/ravb.c +19 -13
index 093288b639..bd30cba940 100644
@@ -399,7 +399,7 @@ static int ravb_dmac_init(struct udevice *dev)
 static int ravb_config(struct udevice *dev)
 {
 	struct ravb_priv *eth = dev_get_priv(dev);
-	struct phy_device *phy;
+	struct phy_device *phy = eth->phydev;
 	u32 mask = ECMR_CHG_DM | ECMR_RE | ECMR_TE;
 	int ret;
 
@@ -410,13 +410,6 @@ static int ravb_config(struct udevice *dev)
 	ravb_mac_init(eth);
 	ravb_write_hwaddr(dev);
 
-	/* Configure phy */
-	ret = ravb_phy_config(dev);
-	if (ret)
-		return ret;
-
-	phy = eth->phydev;
-
 	ret = phy_startup(phy);
 	if (ret)
 		return ret;
@@ -443,10 +436,6 @@ static int ravb_start(struct udevice *dev)
 	struct ravb_priv *eth = dev_get_priv(dev);
 	int ret;
 
-	ret = clk_enable(&eth->clk);
-	if (ret)
-		return ret;
-
 	ret = ravb_reset(dev);
 	if (ret)
 		goto err;
@@ -473,8 +462,8 @@ static void ravb_stop(struct udevice *dev)
 {
 	struct ravb_priv *eth = dev_get_priv(dev);
 
+	phy_shutdown(eth->phydev);
 	ravb_reset(dev);
-	clk_disable(&eth->clk);
 }
 
 static int ravb_probe(struct udevice *dev)
@@ -512,8 +501,23 @@ static int ravb_probe(struct udevice *dev)
 
 	eth->bus = miiphy_get_dev_by_name(dev->name);
 
+	/* Bring up PHY */
+	ret = clk_enable(&eth->clk);
+	if (ret)
+		goto err_mdio_register;
+
+	ret = ravb_reset(dev);
+	if (ret)
+		goto err_mdio_reset;
+
+	ret = ravb_phy_config(dev);
+	if (ret)
+		goto err_mdio_reset;
+
 	return 0;
 
+err_mdio_reset:
+	clk_disable(&eth->clk);
 err_mdio_register:
 	mdio_free(mdiodev);
 err_mdio_alloc:
@@ -525,6 +529,8 @@ static int ravb_remove(struct udevice *dev)
 {
 	struct ravb_priv *eth = dev_get_priv(dev);
 
+	clk_disable(&eth->clk);
+
 	free(eth->phydev);
 	mdio_unregister(eth->bus);
 	mdio_free(eth->bus);
Signature · 1 line
2.15.1
#1 lore raw

PATCH 1/1 net: ravb: Initialize PHY in probe() once

Quoted 9 lines · Marek Vasut

Reset and initialize the PHY once in the probe() function rather than doing it over and over again is start() function. This requires us to keep the clock enabled while the driver is in use. This significantly reduces the time between transfers as the PHY doesn't have to restart autonegotiation between transfers, which takes forever.

Cc Geert Uytterhoeven <[email protected]>
Cc Joe Hershberger <[email protected]>
#2 lore raw

PATCH 1/1 net: ravb: Initialize PHY in probe() once

Quoted 7 lines · Joe Hershberger
Quoted 6 lines · Marek Vasut

Reset and initialize the PHY once in the probe() function rather than doing it over and over again is start() function. This requires us to keep the clock enabled while the driver is in use. This significantly reduces the time between transfers as the PHY doesn't have to restart autonegotiation between transfers, which takes forever.

Quoted 5 lines
Quoted 3 lines
Cc Geert Uytterhoeven <[email protected]>
Cc Joe Hershberger <[email protected]>

Thanks, I'll pick it via u-boot-sh if you don't mind. Or do you want to take it ?

Signature · 2 lines
Best regards,
Marek Vasut
#3 lore raw

PATCH 1/1 net: ravb: Initialize PHY in probe() once

Quoted 8 lines · Marek Vasut
Quoted 7 lines · Joe Hershberger
Quoted 6 lines · Marek Vasut

Reset and initialize the PHY once in the probe() function rather than doing it over and over again is start() function. This requires us to keep the clock enabled while the driver is in use. This significantly reduces the time between transfers as the PHY doesn't have to restart autonegotiation between transfers, which takes forever.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Cc Geert Uytterhoeven <[email protected]>
Cc Joe Hershberger <[email protected]>

Thanks, I'll pick it via u-boot-sh if you don't mind. Or do you want to take it ?

Feel free to take it, but update patchwork to delegate to you.

Cheers,
-Joe

Quoted 4 lines

--
Best regards,
Marek Vasut