Skip to contentSkip to conversation

meta/meta-selftest: add selftest-hello-mod recipe

PATCH Superseded Dixit Parmar 3 participants 8 messages Jun 9, 2025 – Jun 21, 2025

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 meta/meta-selftest: add selftest-hello-mod recipe

Kernel module specific oe test cases requires a test kernel module package to work with. Added selftest-hello-mod derived from meta-skeleton/recipes-kernel/hello-mod.

---
 .../files/hello-mod/Makefile                  | 14 +++++++++++
 .../files/hello-mod/hello.c                   | 24 +++++++++++++++++++
 .../selftest-hello-mod/hello-mod_0.1.bb       | 17 +++++++++++++
 3 files changed, 55 insertions(+)
 create mode 100644 meta-selftest/recipes-test/selftest-hello-mod/files/hello-mod/Makefile
 create mode 100644 meta-selftest/recipes-test/selftest-hello-mod/files/hello-mod/hello.c
 create mode 100644 meta-selftest/recipes-test/selftest-hello-mod/hello-mod_0.1.bb
meta-selftest/recipes-test/selftest-hello-mod/files/hello-mod/Makefile new file +14 -0
new file mode 100644
index 0000000000..4ded35fbc3
@@ -0,0 +1,14 @@
+obj-m := hello.o
+
+SRC := $(shell pwd)
+
+all:
+	$(MAKE) -C $(KERNEL_SRC) M=$(SRC)
+
+modules_install:
+	$(MAKE) -C $(KERNEL_SRC) M=$(SRC) modules_install
+
+clean:
+	rm -f *.o *~ core .depend .*.cmd *.ko *.mod.c
+	rm -f Module.markers Module.symvers modules.order
+	rm -rf .tmp_versions Modules.symvers
meta-selftest/recipes-test/selftest-hello-mod/files/hello-mod/hello.c new file +24 -0
new file mode 100644
index 0000000000..4f73455d20
@@ -0,0 +1,24 @@
+/******************************************************************************
+ *
+ *   Copyright (C) 2011  Intel Corporation. All rights reserved.
+ *
+ *   SPDX-License-Identifier: GPL-2.0-only
+ *
+ *****************************************************************************/
+
+#include <linux/module.h>
+
+static int __init hello_init(void)
+{
+	pr_info("Hello World!\n");
+	return 0;
+}
+
+static void __exit hello_exit(void)
+{
+	pr_info("Goodbye Cruel World!\n");
+}
+
+module_init(hello_init);
+module_exit(hello_exit);
+MODULE_LICENSE("GPL");
meta-selftest/recipes-test/selftest-hello-mod/hello-mod_0.1.bb new file +17 -0
new file mode 100644
index 0000000000..8a98c70703
@@ -0,0 +1,17 @@
+SUMMARY = "Example of how to build an external Linux kernel module - selftest variant"
+DESCRIPTION = "${SUMMARY}"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda2f7b4f302"
+
+inherit module
+
+SRC_URI = "file://hello-mod/Makefile \
+           file://hello-mod/hello.c \
+          "
+
+S = "${WORKDIR}/hello-mod"
+
+# The inherit of module.bbclass will automatically name module packages with
+# "kernel-module-" prefix as required by the oe-core build environment.
+
+RPROVIDES:${PN} += "kernel-module-hello"
Signature · 1 line
2.43.0
#1 lore raw
Quoted 11 lines · Dixit Parmar via lists.openembedded.org

<snip>

meta-selftest/recipes-test/selftest-hello-mod/files/hello-mod/hello.c new file +7 -0
@@ -0,0 +1,24 @@
+/******************************************************************************
+ *
+ *   Copyright (C) 2011  Intel Corporation. All rights reserved.
+ *
+ *   SPDX-License-Identifier: GPL-2.0-only
+ *
+ *****************************************************************************/

<snip>

meta-selftest/recipes-test/selftest-hello-mod/files/hello-mod/hello.c

Quoted 3 lines
meta-selftest/recipes-test/selftest-hello-mod/files/hello-mod/hello.c new file +2 -0
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda2f7b4f302"

One note: the recipe says MIT license, but the source claims to be GPL-2.0-only

#2 lore raw

Yes. The entire hello-mod package is taken from meta-skeleton. The source file remained unchanged, so it has the same License as it is in the meta-skeleton. The bb recipe file is modified to match the build requirements and is kept under the MIT license, following other recipes under the meta-selftest. I hope that should be fine.

#3 lore raw
In reply to Dixit Parmar
Quoted 6 lines · Dixit Parmar via lists.openembedded.org

Kernel module specific oe test cases requires a test kernel module package to work with. Added selftest-hello-mod derived from meta-skeleton/recipes-kernel/hello-mod.

---

Thanks or your patch.

Quoted 1 line

+S = "${WORKDIR}/hello-mod"

This will trigger an error if some patches in master-next are merged, you can rebase on master-next to see the error. The hello-mod recipe of meta-skeleton was also updated accordingly.

https://lists.openembedded.org/g/openembedded-core/message/218806
https://lists.openembedded.org/g/openembedded-core/message/218804

Signature · 3 lines
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw
Quoted 11 lines · Mathieu Dubois-Briand
Quoted 6 lines · Dixit Parmar via lists.openembedded.org

Kernel module specific oe test cases requires a test kernel module package to work with. Added selftest-hello-mod derived from meta-skeleton/recipes-kernel/hello-mod.

---

Quoted 8 lines

Thanks or your patch.

Quoted 1 line

+S = "${WORKDIR}/hello-mod"

This will trigger an error if some patches in master-next are merged, you can rebase on master-next to see the error. The hello-mod recipe of meta-skeleton was also updated accordingly.

Do you mean I should take the latest reference from master-next for the meta-skeleton/hello-mod to meta-selftest?

Quoted 8 lines

https://lists.openembedded.org/g/openembedded-core/message/218806
https://lists.openembedded.org/g/openembedded-core/message/218804

--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

#5 lore raw
Quoted 16 lines · Dixit Parmar via lists.openembedded.org
Quoted 14 lines · Mathieu Dubois-Briand
Quoted 6 lines · Dixit Parmar via lists.openembedded.org

Kernel module specific oe test cases requires a test kernel module package to work with. Added selftest-hello-mod derived from meta-skeleton/recipes-kernel/hello-mod.

---

Thanks or your patch.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

+S = "${WORKDIR}/hello-mod"

This will trigger an error if some patches in master-next are merged, you can rebase on master-next to see the error. The hello-mod recipe of meta-skeleton was also updated accordingly.

Do you mean I should take the latest reference from master-next for the meta-skeleton/hello-mod to meta-selftest?

All I can say for sure is we cannot take both the series from Alexander and your patch as-is.

So as I believe the said series is likely to be merged, I would indeed suggest to modify your patch accordingly, and this can be done by taking the last version of meta-skeleton/hello-mod. But again, I'm not the one deciding what gets merged, so I cannot be sure if and when it will be merged.

Signature · 3 lines
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#6 lore raw
Quoted 31 lines · Mathieu Dubois-Briand
Quoted 18 lines · Dixit Parmar via lists.openembedded.org
Quoted 15 lines · Mathieu Dubois-Briand
Quoted 6 lines · Dixit Parmar via lists.openembedded.org

Kernel module specific oe test cases requires a test kernel module package to work with. Added selftest-hello-mod derived from meta-skeleton/recipes-kernel/hello-mod.

---

Thanks or your patch.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

+S = "${WORKDIR}/hello-mod"

This will trigger an error if some patches in master-next are merged, you can rebase on master-next to see the error. The hello-mod recipe of meta-skeleton was also updated accordingly.

Do you mean I should take the latest reference from master-next for the meta-skeleton/hello-mod to meta-selftest?

Quoted 8 lines

All I can say for sure is we cannot take both the series from Alexander and your patch as-is.

So as I believe the said series is likely to be merged, I would indeed suggest to modify your patch accordingly, and this can be done by taking the last version of meta-skeleton/hello-mod. But again, I'm not the one deciding what gets merged, so I cannot be sure if and when it will be merged.

Understood. A failure was reported with the previous version of this patch, where the .bb file was missing the WORKDIR-related changes for ${S} as it was directly taken from the meta-skeleton/hello-mod. Now, to fix that, I have incorporated the solution this way. do you think this will give errors too? Pls don't misunderstand me, I get your point of rebasing to the latest meta-skeleton as reference but I just want to understand if this will get failed or not. because the said master-next patch sets are still yet to get merged.

Quoted 5 lines

--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com