fix default max mtu size when device configured
cover fix default max mtu size when device configured
testpmd will initialize default max packet length to 1518 which does't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
configure the correct default max packet size in dev_config ops.
SteveX Yang (5):
net/e1000: fix max mtu size packets with vlan tag cannot be received
by default
net/igc: fix max mtu size packets with vlan tag cannot be received by
default
net/ice: fix max mtu size packets with vlan tag cannot be received by
default
net/iavf: fix max mtu size packets with vlan tag cannot be received by
default
net/i40e: fix max mtu size packets with vlan tag cannot be received by
default
drivers/net/e1000/em_ethdev.c | 11 +++++++++++ drivers/net/i40e/i40e_ethdev.c | 10 ++++++++++ drivers/net/i40e/i40e_ethdev_vf.c | 11 +++++++++++ drivers/net/iavf/iavf_ethdev.c | 13 +++++++++++-- drivers/net/ice/ice_ethdev.c | 14 ++++++++++++-- drivers/net/igc/igc_ethdev.c | 10 ++++++++++ 6 files changed, 65 insertions(+), 4 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/5 net/e1000: fix max mtu size packets with vlan tag cannot be received by default
testpmd will initialize default max packet length to 1518 which does't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
e1000 can support single vlan tags that need more 4 bytes for max packet size, so, configures the correct max packet size in dev_config ops.
--- drivers/net/e1000/em_ethdev.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/net/e1000/em_ethdev.c +11 -0
@@ -437,10 +437,21 @@ eth_em_configure(struct rte_eth_dev *dev) {struct e1000_interrupt *intr =E1000_DEV_PRIVATE_TO_INTR (dev->data->dev_private); +struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;PMD_INIT_FUNC_TRACE (); intr->flags |=E1000_FLAG_NEED_LINK_UPDATE ; +/** +* Considering vlan tag packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +if (dev->data->mtu ==RTE_ETHER_MTU && + rxmode->max_rx_pkt_len ==RTE_ETHER_MAX_LEN ) { + rxmode->max_rx_pkt_len =RTE_ETHER_MTU +E1000_ETH_OVERHEAD ; + rxmode->offloads |=DEV_RX_OFFLOAD_JUMBO_FRAME ; + } +PMD_INIT_FUNC_TRACE ();return 0 ;
Signature · 1 line
2.17.1
PATCH 2/5 net/igc: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangtestpmd will initialize default max packet length to 1518 which does't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
igc can support single vlan tag that need more 4 bytes for max packet size, so, configures the correct max packet size in dev_config ops.
--- drivers/net/igc/igc_ethdev.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/net/igc/igc_ethdev.c +10 -0
@@ -341,10 +341,20 @@ static int eth_igc_configure(struct rte_eth_dev *dev) {struct igc_interrupt *intr =IGC_DEV_PRIVATE_INTR (dev); +struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;int ret;PMD_INIT_FUNC_TRACE (); +/* Considering vlan tag packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +if (dev->data->mtu ==RTE_ETHER_MTU && + rxmode->max_rx_pkt_len ==RTE_ETHER_MAX_LEN ) { + rxmode->max_rx_pkt_len =RTE_ETHER_MTU +IGC_ETH_OVERHEAD ; + rxmode->offloads |=DEV_RX_OFFLOAD_JUMBO_FRAME ; + } + ret =igc_check_mq_mode (dev);if (ret !=0 )return ret;
Signature · 1 line
2.17.1
PATCH 3/5 net/ice: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangtestpmd will initialize default max packet length to 1518 which does't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
ice can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in dev_config ops.
--- drivers/net/ice/ice_ethdev.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
drivers/net/ice/ice_ethdev.c +12 -2
@@ -3129,6 +3129,7 @@ ice_dev_configure(struct rte_eth_dev *dev)struct ice_adapter *ad =ICE_DEV_PRIVATE_TO_ADAPTER (dev->data->dev_private);struct ice_pf *pf =ICE_DEV_PRIVATE_TO_PF (dev->data->dev_private); +struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;int ret;/* Initialize to TRUE. If any of Rx queues doesn't meet the
@@ -3137,8 +3138,17 @@ ice_dev_configure(struct rte_eth_dev *dev) ad->rx_bulk_alloc_allowed = true; ad->tx_simple_allowed = true; -if (dev->data->dev_conf.rxmode.mq_mode Ð_MQ_RX_RSS_FLAG ) - dev->data->dev_conf.rxmode.offloads |=DEV_RX_OFFLOAD_RSS_HASH ; +if (rxmode->mq_mode Ð_MQ_RX_RSS_FLAG ) + rxmode->offloads |=DEV_RX_OFFLOAD_RSS_HASH ; + +/* Considering QinQ packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +if (dev->data->mtu ==RTE_ETHER_MTU && + rxmode->max_rx_pkt_len ==RTE_ETHER_MAX_LEN ) { + rxmode->max_rx_pkt_len =RTE_ETHER_MTU +ICE_ETH_OVERHEAD ; + rxmode->offloads |=DEV_RX_OFFLOAD_JUMBO_FRAME ; + } ret =ice_init_rss (pf);if (ret) {
Signature · 1 line
2.17.1
PATCH 4/5 net/iavf: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangtestpmd will initialize default max packet length to 1518 which does't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
iavf can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in dev_config ops.
--- drivers/net/iavf/iavf_ethdev.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)
drivers/net/iavf/iavf_ethdev.c +11 -2
@@ -217,7 +217,7 @@ iavf_dev_configure(struct rte_eth_dev *dev)struct iavf_adapter *ad =IAVF_DEV_PRIVATE_TO_ADAPTER (dev->data->dev_private);struct iavf_info *vf =IAVF_DEV_PRIVATE_TO_VF (ad); -struct rte_eth_conf *dev_conf = &dev->data->dev_conf; +struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode; ad->rx_bulk_alloc_allowed = true;/* Initialize to TRUE. If any of Rx queues doesn't meet the
@@ -229,9 +229,18 @@ iavf_dev_configure(struct rte_eth_dev *dev)if (dev->data->dev_conf.rxmode.mq_mode Ð_MQ_RX_RSS_FLAG ) dev->data->dev_conf.rxmode.offloads |=DEV_RX_OFFLOAD_RSS_HASH ; +/* Considering QinQ packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +if (dev->data->mtu ==RTE_ETHER_MTU && + rxmode->max_rx_pkt_len ==RTE_ETHER_MAX_LEN ) { + rxmode->max_rx_pkt_len =RTE_ETHER_MTU +IAVF_ETH_OVERHEAD ; + rxmode->offloads |=DEV_RX_OFFLOAD_JUMBO_FRAME ; + } +/* Vlan stripping setting */ if (vf->vf_res->vf_cap_flags &VIRTCHNL_VF_OFFLOAD_VLAN ) { -if (dev_conf->rxmode.offloads &DEV_RX_OFFLOAD_VLAN_STRIP ) +if (rxmode->offloads &DEV_RX_OFFLOAD_VLAN_STRIP )iavf_enable_vlan_strip (ad);else iavf_disable_vlan_strip (ad);
Signature · 1 line
2.17.1
PATCH 5/5 net/i40e: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangtestpmd will initialize default max packet length to 1518 which does't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. But for i40e/i40evf, they should support dual vlan tags that need more 8 bytes for max packet size, so, configure the correct max packet size in dev_config ops.
--- drivers/net/i40e/i40e_ethdev.c | 10 ++++++++++ drivers/net/i40e/i40e_ethdev_vf.c | 11 +++++++++++ 2 files changed, 21 insertions(+)
drivers/net/i40e/i40e_ethdev.c +10 -0
@@ -1917,6 +1917,7 @@ i40e_dev_configure(struct rte_eth_dev *dev)struct i40e_hw *hw =I40E_DEV_PRIVATE_TO_HW (dev->data->dev_private);enum rte_eth_rx_mq_mode mq_mode = dev->data->dev_conf.rxmode.mq_mode;int i, ret; +struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode; ret =i40e_dev_sync_phy_type (hw);if (ret)
@@ -1930,6 +1931,15 @@ i40e_dev_configure(struct rte_eth_dev *dev) ad->tx_simple_allowed = true; ad->tx_vec_allowed = true; +/* Considering QinQ packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +if (dev->data->mtu ==RTE_ETHER_MTU && + rxmode->max_rx_pkt_len ==RTE_ETHER_MAX_LEN ) { + rxmode->max_rx_pkt_len =RTE_ETHER_MTU +I40E_ETH_OVERHEAD ; + rxmode->offloads |=DEV_RX_OFFLOAD_JUMBO_FRAME ; + } +if (dev->data->dev_conf.rxmode.mq_mode Ð_MQ_RX_RSS_FLAG ) dev->data->dev_conf.rxmode.offloads |=DEV_RX_OFFLOAD_RSS_HASH ;
drivers/net/i40e/i40e_ethdev_vf.c +11 -0
@@ -1669,6 +1669,7 @@ i40evf_dev_configure(struct rte_eth_dev *dev)I40E_DEV_PRIVATE_TO_ADAPTER (dev->data->dev_private);uint16_t num_queue_pairs =RTE_MAX (dev->data->nb_rx_queues, dev->data->nb_tx_queues); +struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;/* Initialize to TRUE. If any of Rx queues doesn't meet the bulk * allocation or vector Rx preconditions we will reset it.
@@ -1681,6 +1682,16 @@ i40evf_dev_configure(struct rte_eth_dev *dev) dev->data->dev_conf.intr_conf.lsc = !!(dev->data->dev_flags &RTE_ETH_DEV_INTR_LSC ); + +/* Considering QinQ packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +if (dev->data->mtu ==RTE_ETHER_MTU && + rxmode->max_rx_pkt_len ==RTE_ETHER_MAX_LEN ) { + rxmode->max_rx_pkt_len =RTE_ETHER_MTU +I40E_ETH_OVERHEAD ; + rxmode->offloads |=DEV_RX_OFFLOAD_JUMBO_FRAME ; + } +if (num_queue_pairs > vf->vsi_res->num_queue_pairs) {struct i40e_hw *hw;int ret;
Signature · 1 line
2.17.1
Re: [dpdk-dev] [PATCH v1 5/5] net/i40e: fix max mtu size packets with vlan tag cannot be received by default
Quoted 28 lines
testpmd will initialize default max packet length to 1518 which does't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. But for i40e/i40evf, they should support dual vlan tags that need more 8 bytes for max packet size, so, configure the correct max packet size in
dev_configops.Fixes ff8282f4bbcd ("net/i40e: consider QinQ when setting MTU")Signed-off-by SteveX Yang <[email protected]>--- drivers/net/i40e/i40e_ethdev.c | 10 ++++++++++ drivers/net/i40e/i40e_ethdev_vf.c | 11 +++++++++++ 2 files changed, 21 insertions(+)drivers/net/i40e/i40e_ethdev.c +1
-0@@ -1917,6 +1917,7 @@ i40e_dev_configure(struct rte_eth_dev *dev)struct i40e_hw *hw =I40E_DEV_PRIVATE_TO_HW (dev->data->dev_private);enum rte_eth_rx_mq_mode mq_mode = dev->data->dev_conf.rxmode.mq_mode;int i, ret; +struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode; ret =i40e_dev_sync_phy_type (hw);if (ret)
drivers/net/i40e/i40e_ethdev.c i40e_dev_configure(struct rte_eth_dev *dev) · line 1938
Quoted 8 lines
drivers/net/i40e/i40e_ethdev.c +5
-0@@ -1930,6 +1931,15 @@ i40e_dev_configure(struct rte_eth_dev *dev) ad->tx_simple_allowed = true; ad->tx_vec_allowed = true; +/* Considering QinQ packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +if (dev->data->mtu ==RTE_ETHER_MTU && + rxmode->max_rx_pkt_len ==RTE_ETHER_MAX_LEN ) {
Wonder why that particular max_rx_pkt_len and mtu values are important? Shouldn't we always do here same calculations as we do in i40e_dev_mtu_set()?
Quoted 38 lines
drivers/net/i40e/i40e_ethdev.c +4
-0+ rxmode->max_rx_pkt_len =RTE_ETHER_MTU +I40E_ETH_OVERHEAD ; + rxmode->offloads |=DEV_RX_OFFLOAD_JUMBO_FRAME ; + } +if (dev->data->dev_conf.rxmode.mq_mode Ð_MQ_RX_RSS_FLAG ) dev->data->dev_conf.rxmode.offloads |=DEV_RX_OFFLOAD_RSS_HASH ;drivers/net/i40e/i40e_ethdev_vf.c +11
-1@@ -1669,6 +1669,7 @@ i40evf_dev_configure(struct rte_eth_dev *dev)I40E_DEV_PRIVATE_TO_ADAPTER (dev->data->dev_private);uint16_t num_queue_pairs =RTE_MAX (dev->data->nb_rx_queues, dev->data->nb_tx_queues); +struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;/* Initialize to TRUE. If any of Rx queues doesn't meet the bulk * allocation or vector Rx preconditions we will reset it. @@ -1681,6 +1682,16 @@ i40evf_dev_configure(struct rte_eth_dev *dev) dev->data->dev_conf.intr_conf.lsc = !!(dev->data->dev_flags &RTE_ETH_DEV_INTR_LSC ); + +/* Considering QinQ packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +if (dev->data->mtu ==RTE_ETHER_MTU && + rxmode->max_rx_pkt_len ==RTE_ETHER_MAX_LEN ) { + rxmode->max_rx_pkt_len =RTE_ETHER_MTU +I40E_ETH_OVERHEAD ; + rxmode->offloads |=DEV_RX_OFFLOAD_JUMBO_FRAME ; + } +if (num_queue_pairs > vf->vsi_res->num_queue_pairs) {struct i40e_hw *hw;int ret; --2.17.1
A message that is not in the archive (sent off-list or not yet received): DM6PR11MB4362E5FF332551D12AA20017F93E0@DM6PR11MB4362.namprd11.prod.outlook.com
Re: [dpdk-dev] [PATCH v1 5/5] net/i40e: fix max mtu size packets with vlan tag cannot be received by default
Quoted 48 lines
Quoted 38 lines
Subject: RE: [dpdk-dev] [PATCH v1 5/5] net/i40e: fix max mtu size packets with vlan tag cannot be received by default
Quoted 6 lines
testpmd will initialize default max packet length to 1518 which does't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. But for i40e/i40evf, they should support dual vlan tags that need more 8 bytes for max packet size, so, configure the correct max packet size in
dev_configops.
Quoted 27 lines
Fixes ff8282f4bbcd ("net/i40e: consider QinQ when setting MTU")Signed-off-by SteveX Yang <[email protected]>--- drivers/net/i40e/i40e_ethdev.c | 10 ++++++++++ drivers/net/i40e/i40e_ethdev_vf.c | 11 +++++++++++ 2 files changed, 21 insertions(+)(quoted diff) +0
-0
b/drivers/net/i40e/i40e_ethdev.cindex 841447228..787ff61c0 100644drivers/net/i40e/i40e_ethdev.c +1
-0@@ -1917,6 +1917,7 @@ i40e_dev_configure(struct rte_eth_dev *dev)struct i40e_hw *hw =I40E_DEV_PRIVATE_TO_HW (dev->data- dev_private);enum rte_eth_rx_mq_mode mq_mode = dev->data- dev_conf.rxmode.mq_mode;int i, ret; +struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;drivers/net/i40e/i40e_ethdev.c +0
-0ret =i40e_dev_sync_phy_type (hw);if (ret)@@ -1930,6 +1931,15 @@ i40e_dev_configure(struct rte_eth_dev *dev) ad->tx_simple_allowed = true; ad->tx_vec_allowed = true;Quoted 9 lines
drivers/net/i40e/i40e_ethdev.c i40e_dev_configure(struct rte_eth_dev *dev) · line 1938
Quoted 5 lines
drivers/net/i40e/i40e_ethdev.c +5
-0+/* Considering QinQ packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +if (dev->data->mtu ==RTE_ETHER_MTU && + rxmode->max_rx_pkt_len ==RTE_ETHER_MAX_LEN ) {Wonder why that particular
max_rx_pkt_lenand mtu values are important? Shouldn't we always do here same calculations as we do ini40e_dev_mtu_set()?
Quoted 4 lines
The combination of
RTE_ETHER_MTU(1500) &RTE_ETHER_MAX_LEN(1518) is the generical default value from test-pmd or other apps. theRTE_ETHER_MAX_LENdoesn't include VLAN tag(s) size, hence, only need adjust frame size to hold real mtu size packet for the particular condition.
Ok, but user can overwrite default values in dev_configure.
What would happen if user would set rxmode.max_rx_pkt_len to RTE_ETHER_MAX_LEN + 1 or RTE_ETHER_MAX_LEN - 1?
Quoted 46 lines
Quoted 46 lines
drivers/net/i40e/i40e_ethdev.c i40e_dev_configure(struct rte_eth_dev *dev) · line 1939
Quoted 4 lines
drivers/net/i40e/i40e_ethdev.c +1
-0+ rxmode->max_rx_pkt_len = RTE_ETHER_MTU +
I40E_ETH_OVERHEAD;drivers/net/i40e/i40e_ethdev.c i40e_dev_configure(struct rte_eth_dev *dev)
Quoted 4 lines
drivers/net/i40e/i40e_ethdev.c +3
-0+ rxmode->offloads |=DEV_RX_OFFLOAD_JUMBO_FRAME ; + } + if (dev->data->dev_conf.rxmode.mq_mode &
ETH_MQ_RX_RSS_FLAG)drivers/net/i40e/i40e_ethdev.c i40e_dev_configure(struct rte_eth_dev *dev) · line 1944
Quoted 1 line
drivers/net/i40e/i40e_ethdev.c +0
-0dev->data->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_RSS_HASH;Quoted 15 lines
drivers/net/i40e/i40e_ethdev_vf.c +1
-0@@ -1669,6 +1669,7 @@ i40evf_dev_configure(struct rte_eth_dev *dev)I40E_DEV_PRIVATE_TO_ADAPTER (dev->data->dev_private);uint16_t num_queue_pairs =RTE_MAX (dev->data->nb_rx_queues, dev->data->nb_tx_queues); +struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;/* Initialize to TRUE. If any of Rx queues doesn't meet the bulk * allocation or vector Rx preconditions we will reset it. drivers/net/i40e/i40e_ethdev_vf.c i40evf_dev_configure(struct rte_eth_dev *dev) · line 1691
Quoted 10 lines
drivers/net/i40e/i40e_ethdev_vf.c +7
-0@@ -1681,6 +1682,16 @@ i40evf_dev_configure(struct rte_eth_dev *dev) dev->data->dev_conf.intr_conf.lsc = !!(dev->data->dev_flags &RTE_ETH_DEV_INTR_LSC ); + +/* Considering QinQ packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +if (dev->data->mtu ==RTE_ETHER_MTU && + rxmode->max_rx_pkt_len ==RTE_ETHER_MAX_LEN ) { + rxmode->max_rx_pkt_len = RTE_ETHER_MTU +
I40E_ETH_OVERHEAD;Quoted 8 lines
drivers/net/i40e/i40e_ethdev_vf.c +3
-1+ rxmode->offloads |=DEV_RX_OFFLOAD_JUMBO_FRAME ; + } +if (num_queue_pairs > vf->vsi_res->num_queue_pairs) {struct i40e_hw *hw;int ret; --2.17.1
v2 cover fix default max mtu size when device configured
In reply to SteveX Yangtestpmd will initialize default max packet length to 1518 which does't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
configure the correct default max packet size in dev_config ops.
v2:
* change the max_rx_pkt_len via mtu_set ops;
SteveX Yang (5):
net/e1000: fix max mtu size packets with vlan tag cannot be received
by default
net/igc: fix max mtu size packets with vlan tag cannot be received by
default
net/ice: fix max mtu size packets with vlan tag cannot be received by
default
net/i40e: fix max mtu size packets with vlan tag cannot be received by
default
net/iavf: fix max mtu size packets with vlan tag cannot be received by
default
drivers/net/e1000/em_ethdev.c | 6 ++++++ drivers/net/i40e/i40e_ethdev.c | 5 +++++ drivers/net/i40e/i40e_ethdev_vf.c | 11 +++++++++++ drivers/net/iavf/iavf_ethdev.c | 5 +++++ drivers/net/ice/ice_ethdev.c | 5 +++++ drivers/net/igc/igc_ethdev.c | 7 ++++++- 6 files changed, 38 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1
PATCH v2 1/5 net/e1000: fix max mtu size packets with vlan tag cannot be received by default
testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
e1000 can support single vlan tags that need more 4 bytes for max packet size, so, configures the correct max packet size in dev_config ops.
--- drivers/net/e1000/em_ethdev.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/net/e1000/em_ethdev.c +6 -0
@@ -441,6 +441,12 @@ eth_em_configure(struct rte_eth_dev *dev)PMD_INIT_FUNC_TRACE (); intr->flags |=E1000_FLAG_NEED_LINK_UPDATE ; +/** +* Considering vlan tag packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +eth_em_mtu_set (dev, dev->data->mtu); +PMD_INIT_FUNC_TRACE ();return 0 ;
Signature · 1 line
2.17.1
PATCH v2 2/5 net/igc: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangtestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
igc can support single vlan tag that need more 4 bytes for max packet size, so, configures the correct max packet size in dev_config ops.
--- drivers/net/igc/igc_ethdev.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/net/igc/igc_ethdev.c +6 -1
@@ -341,7 +341,12 @@ eth_igc_configure(struct rte_eth_dev *dev)PMD_INIT_FUNC_TRACE (); - ret =igc_check_mq_mode (dev); +/* Considering vlan tag packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +eth_igc_mtu_set (dev, dev->data->mtu); + + ret =igc_check_mq_mode (dev);if (ret !=0 )return ret;
Signature · 1 line
2.17.1
PATCH v2 3/5 net/ice: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangtestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
ice can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in dev_config ops.
--- drivers/net/ice/ice_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/net/ice/ice_ethdev.c +5 -0
@@ -3157,6 +3157,11 @@ ice_dev_configure(struct rte_eth_dev *dev)if (dev->data->dev_conf.rxmode.mq_mode Ð_MQ_RX_RSS_FLAG ) dev->data->dev_conf.rxmode.offloads |=DEV_RX_OFFLOAD_RSS_HASH ; +/* Considering QinQ packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +ice_mtu_set (dev, dev->data->mtu); + ret =ice_init_rss (pf);if (ret) {PMD_DRV_LOG (ERR ,"Failed to enable rss for PF" );
Signature · 1 line
2.17.1
PATCH v2 4/5 net/i40e: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangtestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. But for i40e/i40evf, they should support dual vlan tags that need more 8 bytes for max packet size, so, configure the correct max packet size in dev_config ops.
--- drivers/net/i40e/i40e_ethdev.c | 5 +++++ drivers/net/i40e/i40e_ethdev_vf.c | 11 +++++++++++ 2 files changed, 16 insertions(+)
drivers/net/i40e/i40e_ethdev.c +5 -0
@@ -1930,6 +1930,11 @@ i40e_dev_configure(struct rte_eth_dev *dev) ad->tx_simple_allowed = true; ad->tx_vec_allowed = true; +/* Considering QinQ packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +i40e_dev_mtu_set (dev, dev->data->mtu); +if (dev->data->dev_conf.rxmode.mq_mode Ð_MQ_RX_RSS_FLAG ) dev->data->dev_conf.rxmode.offloads |=DEV_RX_OFFLOAD_RSS_HASH ;
drivers/net/i40e/i40e_ethdev_vf.c +11 -0
@@ -1669,6 +1669,7 @@ i40evf_dev_configure(struct rte_eth_dev *dev)I40E_DEV_PRIVATE_TO_ADAPTER (dev->data->dev_private);uint16_t num_queue_pairs =RTE_MAX (dev->data->nb_rx_queues, dev->data->nb_tx_queues); +struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;/* Initialize to TRUE. If any of Rx queues doesn't meet the bulk * allocation or vector Rx preconditions we will reset it.
@@ -1681,6 +1682,16 @@ i40evf_dev_configure(struct rte_eth_dev *dev) dev->data->dev_conf.intr_conf.lsc = !!(dev->data->dev_flags &RTE_ETH_DEV_INTR_LSC ); + +/* Considering QinQ packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +if (dev->data->mtu ==RTE_ETHER_MTU && + rxmode->max_rx_pkt_len ==RTE_ETHER_MAX_LEN ) { + rxmode->max_rx_pkt_len =RTE_ETHER_MTU +I40E_ETH_OVERHEAD ; + rxmode->offloads |=DEV_RX_OFFLOAD_JUMBO_FRAME ; + } +if (num_queue_pairs > vf->vsi_res->num_queue_pairs) {struct i40e_hw *hw;int ret;
Signature · 1 line
2.17.1
Re: [dpdk-dev] [PATCH v2 4/5] net/i40e: fix max mtu size packets with vlan tag cannot be received by default
Quoted 57 lines
-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Tuesday, September 22, 2020 2:24 AM
To: [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Ananyev, Konstantin <[email protected]>; Yang, SteveX <[email protected]>
Subject: [PATCH v2 4/5] net/i40e: fix max mtu size packets with vlan tag cannot be received by defaulttestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. But for i40e/i40evf, they should support dual vlan tags that need more 8 bytes for max packet size, so, configure the correct max packet size in
dev_configops.Fixes ff8282f4bbcd ("net/i40e: consider QinQ when setting MTU")Signed-off-by SteveX Yang <[email protected]>--- drivers/net/i40e/i40e_ethdev.c | 5 +++++ drivers/net/i40e/i40e_ethdev_vf.c | 11 +++++++++++ 2 files changed, 16 insertions(+)drivers/net/i40e/i40e_ethdev.c +5
-0@@ -1930,6 +1930,11 @@ i40e_dev_configure(struct rte_eth_dev *dev) ad->tx_simple_allowed = true; ad->tx_vec_allowed = true; +/* Considering QinQ packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +i40e_dev_mtu_set (dev, dev->data->mtu); +if (dev->data->dev_conf.rxmode.mq_mode Ð_MQ_RX_RSS_FLAG ) dev->data->dev_conf.rxmode.offloads |=DEV_RX_OFFLOAD_RSS_HASH ;drivers/net/i40e/i40e_ethdev_vf.c +1
-0@@ -1669,6 +1669,7 @@ i40evf_dev_configure(struct rte_eth_dev *dev)I40E_DEV_PRIVATE_TO_ADAPTER (dev->data->dev_private);uint16_t num_queue_pairs =RTE_MAX (dev->data->nb_rx_queues, dev->data->nb_tx_queues); +struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;/* Initialize to TRUE. If any of Rx queues doesn't meet the bulk * allocation or vector Rx preconditions we will reset it. @@ -1681,6 +1682,16 @@ i40evf_dev_configure(struct rte_eth_dev *dev) dev->data->dev_conf.intr_conf.lsc = !!(dev->data->dev_flags &RTE_ETH_DEV_INTR_LSC );
drivers/net/i40e/i40e_ethdev_vf.c i40evf_dev_configure(struct rte_eth_dev *dev) · line 1693
Quoted 10 lines
drivers/net/i40e/i40e_ethdev_vf.c +9
-0+ +/* Considering QinQ packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +if (dev->data->mtu ==RTE_ETHER_MTU && + rxmode->max_rx_pkt_len ==RTE_ETHER_MAX_LEN ) { + rxmode->max_rx_pkt_len =RTE_ETHER_MTU +I40E_ETH_OVERHEAD ; + rxmode->offloads |=DEV_RX_OFFLOAD_JUMBO_FRAME ; + }
Wonder why vf code-path is different here?
Can't we also do mtu_set() here?
Quoted 6 lines
drivers/net/i40e/i40e_ethdev_vf.c +1
-1+if (num_queue_pairs > vf->vsi_res->num_queue_pairs) {struct i40e_hw *hw;int ret; --2.17.1
PATCH v2 5/5 net/iavf: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangtestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
iavf can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in dev_config ops.
--- drivers/net/iavf/iavf_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/net/iavf/iavf_ethdev.c +5 -0
@@ -226,6 +226,11 @@ iavf_dev_configure(struct rte_eth_dev *dev)if (dev->data->dev_conf.rxmode.mq_mode Ð_MQ_RX_RSS_FLAG ) dev->data->dev_conf.rxmode.offloads |=DEV_RX_OFFLOAD_RSS_HASH ; +/* Considering QinQ packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +iavf_dev_mtu_set (dev, dev->data->mtu); +/* Vlan stripping setting */ if (vf->vf_res->vf_cap_flags &VIRTCHNL_VF_OFFLOAD_VLAN ) {if (dev_conf->rxmode.offloads &DEV_RX_OFFLOAD_VLAN_STRIP )
Signature · 1 line
2.17.1
v3 cover fix default max mtu size when device configured
In reply to SteveX Yangtestpmd will initialize default max packet length to 1518 which does't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
configure the correct default max packet size in dev_config ops.
v3:
* change the i40evf relative code;
v2:
* change the max_rx_pkt_len via mtu_set ops;
SteveX Yang (5):
net/e1000: fix max mtu size packets with vlan tag cannot be received
by default
net/igc: fix max mtu size packets with vlan tag cannot be received by
default
net/ice: fix max mtu size packets with vlan tag cannot be received by
default
net/i40e: fix max mtu size packets with vlan tag cannot be received by
default
net/iavf: fix max mtu size packets with vlan tag cannot be received by
default
drivers/net/e1000/em_ethdev.c | 6 ++++++ drivers/net/i40e/i40e_ethdev.c | 5 +++++ drivers/net/i40e/i40e_ethdev_vf.c | 5 +++++ drivers/net/iavf/iavf_ethdev.c | 5 +++++ drivers/net/ice/ice_ethdev.c | 5 +++++ drivers/net/igc/igc_ethdev.c | 7 ++++++- 6 files changed, 32 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1
PATCH v3 1/5 net/e1000: fix max mtu size packets with vlan tag cannot be received by default
testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
e1000 can support single vlan tags that need more 4 bytes for max packet size, so, configures the correct max packet size in dev_config ops.
--- drivers/net/e1000/em_ethdev.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/net/e1000/em_ethdev.c +6 -0
@@ -441,6 +441,12 @@ eth_em_configure(struct rte_eth_dev *dev)PMD_INIT_FUNC_TRACE (); intr->flags |=E1000_FLAG_NEED_LINK_UPDATE ; +/** +* Considering vlan tag packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +eth_em_mtu_set (dev, dev->data->mtu); +PMD_INIT_FUNC_TRACE ();return 0 ;
Signature · 1 line
2.17.1
PATCH v3 2/5 net/igc: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangtestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
igc can support single vlan tag that need more 4 bytes for max packet size, so, configures the correct max packet size in dev_config ops.
--- drivers/net/igc/igc_ethdev.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/net/igc/igc_ethdev.c +6 -1
@@ -341,7 +341,12 @@ eth_igc_configure(struct rte_eth_dev *dev)PMD_INIT_FUNC_TRACE (); - ret =igc_check_mq_mode (dev); +/* Considering vlan tag packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +eth_igc_mtu_set (dev, dev->data->mtu); + + ret =igc_check_mq_mode (dev);if (ret !=0 )return ret;
Signature · 1 line
2.17.1
PATCH v3 3/5 net/ice: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangtestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
ice can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in dev_config ops.
--- drivers/net/ice/ice_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/net/ice/ice_ethdev.c +5 -0
@@ -3157,6 +3157,11 @@ ice_dev_configure(struct rte_eth_dev *dev)if (dev->data->dev_conf.rxmode.mq_mode Ð_MQ_RX_RSS_FLAG ) dev->data->dev_conf.rxmode.offloads |=DEV_RX_OFFLOAD_RSS_HASH ; +/* Considering QinQ packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +ice_mtu_set (dev, dev->data->mtu); + ret =ice_init_rss (pf);if (ret) {PMD_DRV_LOG (ERR ,"Failed to enable rss for PF" );
Signature · 1 line
2.17.1
PATCH v3 4/5 net/i40e: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangtestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. But for i40e/i40evf, they should support dual vlan tags that need more 8 bytes for max packet size, so, configure the correct max packet size in dev_config ops.
--- drivers/net/i40e/i40e_ethdev.c | 5 +++++ drivers/net/i40e/i40e_ethdev_vf.c | 5 +++++ 2 files changed, 10 insertions(+)
drivers/net/i40e/i40e_ethdev.c +5 -0
@@ -1930,6 +1930,11 @@ i40e_dev_configure(struct rte_eth_dev *dev) ad->tx_simple_allowed = true; ad->tx_vec_allowed = true; +/* Considering QinQ packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +i40e_dev_mtu_set (dev, dev->data->mtu); +if (dev->data->dev_conf.rxmode.mq_mode Ð_MQ_RX_RSS_FLAG ) dev->data->dev_conf.rxmode.offloads |=DEV_RX_OFFLOAD_RSS_HASH ;
drivers/net/i40e/i40e_ethdev_vf.c +5 -0
@@ -1681,6 +1681,11 @@ i40evf_dev_configure(struct rte_eth_dev *dev) dev->data->dev_conf.intr_conf.lsc = !!(dev->data->dev_flags &RTE_ETH_DEV_INTR_LSC ); +/* Considering QinQ packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +i40evf_dev_mtu_set (dev, dev->data->mtu); +if (num_queue_pairs > vf->vsi_res->num_queue_pairs) {struct i40e_hw *hw;int ret;
Signature · 1 line
2.17.1
PATCH v3 5/5 net/iavf: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangtestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
iavf can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in dev_config ops.
--- drivers/net/iavf/iavf_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/net/iavf/iavf_ethdev.c +5 -0
@@ -226,6 +226,11 @@ iavf_dev_configure(struct rte_eth_dev *dev)if (dev->data->dev_conf.rxmode.mq_mode Ð_MQ_RX_RSS_FLAG ) dev->data->dev_conf.rxmode.offloads |=DEV_RX_OFFLOAD_RSS_HASH ; +/* Considering QinQ packet, max frame size should be MTU and +* corresponding ether overhead. +*/ +iavf_dev_mtu_set (dev, dev->data->mtu); +/* Vlan stripping setting */ if (vf->vf_res->vf_cap_flags &VIRTCHNL_VF_OFFLOAD_VLAN ) {if (dev_conf->rxmode.offloads &DEV_RX_OFFLOAD_VLAN_STRIP )
Signature · 1 line
2.17.1
v4 cover fix default max mtu size when device configured
In reply to SteveX Yangtestpmd will initialize default max packet length to 1518 which does't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
configure the correct default max packet size in dev_config ops.
v4:
* add the adjust condition for max_rx_pkt_len;
v3:
* change the i40evf relative code;
v2:
* change the max_rx_pkt_len via mtu_set ops;
SteveX Yang (5):
net/e1000: fix max mtu size packets with vlan tag cannot be received
by default
net/igc: fix max mtu size packets with vlan tag cannot be received by
default
net/ice: fix max mtu size packets with vlan tag cannot be received by
default
net/i40e: fix max mtu size packets with vlan tag cannot be received by
default
net/iavf: fix max mtu size packets with vlan tag cannot be received by
default
drivers/net/e1000/em_ethdev.c | 12 ++++++++++++ drivers/net/i40e/i40e_ethdev.c | 11 +++++++++++ drivers/net/i40e/i40e_ethdev_vf.c | 13 ++++++++++++- drivers/net/iavf/iavf_ethdev.c | 12 ++++++++++++ drivers/net/ice/ice_ethdev.c | 11 +++++++++++ drivers/net/igc/igc_ethdev.c | 13 ++++++++++++- 6 files changed, 70 insertions(+), 2 deletions(-)
Signature · 1 line
2.17.1
PATCH v4 1/5 net/e1000: fix max mtu size packets with vlan tag cannot be received by default
testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
e1000 can support single vlan tags that need more 4 bytes for max packet size, so, configures the correct max packet size in dev_config ops.
--- drivers/net/e1000/em_ethdev.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/net/e1000/em_ethdev.c +12 -0
@@ -437,10 +437,22 @@ eth_em_configure(struct rte_eth_dev *dev) {struct e1000_interrupt *intr =E1000_DEV_PRIVATE_TO_INTR (dev->data->dev_private); +uint16_t frame_size = dev->data->mtu +E1000_ETH_OVERHEAD ; +int rc =0 ;PMD_INIT_FUNC_TRACE (); intr->flags |=E1000_FLAG_NEED_LINK_UPDATE ; +/** +* Considering vlan tag packet, max frame size should be equal or +* larger than total size of MTU and Ether overhead. +*/ +if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) { + rc =eth_em_mtu_set (dev, dev->data->mtu); +if (rc !=0 ) +return rc; + } +PMD_INIT_FUNC_TRACE ();return 0 ;
Signature · 1 line
2.17.1
PATCH v4 2/5 net/igc: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangtestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
igc can support single vlan tag that need more 4 bytes for max packet size, so, configures the correct max packet size in dev_config ops.
--- drivers/net/igc/igc_ethdev.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
drivers/net/igc/igc_ethdev.c +12 -1
@@ -337,11 +337,22 @@ static int eth_igc_configure(struct rte_eth_dev *dev) {struct igc_interrupt *intr =IGC_DEV_PRIVATE_INTR (dev); +uint32_t frame_size = dev->data->mtu +IGC_ETH_OVERHEAD ;int ret;PMD_INIT_FUNC_TRACE (); - ret =igc_check_mq_mode (dev); +/** +* Considering vlan tag packet, max frame size should be equal or +* larger than total size of MTU and Ether overhead. +*/ +if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) { + ret =eth_igc_mtu_set (dev, dev->data->mtu); +if (ret !=0 ) +return ret; + } + + ret =igc_check_mq_mode (dev);if (ret !=0 )return ret;
Signature · 1 line
2.17.1
PATCH v4 3/5 net/ice: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangtestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
ice can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in dev_config ops.
--- drivers/net/ice/ice_ethdev.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/net/ice/ice_ethdev.c +11 -0
@@ -3146,6 +3146,7 @@ ice_dev_configure(struct rte_eth_dev *dev)struct ice_adapter *ad =ICE_DEV_PRIVATE_TO_ADAPTER (dev->data->dev_private);struct ice_pf *pf =ICE_DEV_PRIVATE_TO_PF (dev->data->dev_private); +uint32_t frame_size = dev->data->mtu +ICE_ETH_OVERHEAD ;int ret;/* Initialize to TRUE. If any of Rx queues doesn't meet the
@@ -3157,6 +3158,16 @@ ice_dev_configure(struct rte_eth_dev *dev)if (dev->data->dev_conf.rxmode.mq_mode Ð_MQ_RX_RSS_FLAG ) dev->data->dev_conf.rxmode.offloads |=DEV_RX_OFFLOAD_RSS_HASH ; +/** +* Considering QinQ packet, max frame size should be equal or +* larger than total size of MTU and Ether overhead. +*/ +if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) { + ret =ice_mtu_set (dev, dev->data->mtu); +if (ret !=0 ) +return ret; + } + ret =ice_init_rss (pf);if (ret) {PMD_DRV_LOG (ERR ,"Failed to enable rss for PF" );
Signature · 1 line
2.17.1
Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Quoted 46 lines
-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Monday, September 28, 2020 2:56 PM
To: [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Ananyev, Konstantin <[email protected]>; Yang, SteveX <[email protected]>
Subject: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaulttestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
ice can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in
dev_configops.Fixes 50cc9d2a6e9d ("net/ice: fix max frame size")Signed-off-by SteveX Yang <[email protected]>--- drivers/net/ice/ice_ethdev.c | 11 +++++++++++ 1 file changed, 11 insertions(+)drivers/net/ice/ice_ethdev.c index renamed from drivers/net/ice/ice_ethdev.c +0
-0
cfd357b05..6b7098444100644drivers/net/ice/ice_ethdev.c +2
-0@@ -3146,6 +3146,7 @@ ice_dev_configure(struct rte_eth_dev *dev)struct ice_adapter *ad =ICE_DEV_PRIVATE_TO_ADAPTER (dev->data->dev_private);struct ice_pf *pf =ICE_DEV_PRIVATE_TO_PF (dev->data->dev_private); +uint32_t frame_size = dev->data->mtu +ICE_ETH_OVERHEAD ;int ret;/* Initialize to TRUE. If any of Rx queues doesn't meet the @@ -3157,6 +3158,16 @@ ice_dev_configure(struct rte_eth_dev *dev) if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) dev->data->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_RSS_HASH;
drivers/net/ice/ice_ethdev.c ice_dev_configure(struct rte_eth_dev *dev) · line 3165
Quoted 6 lines
drivers/net/ice/ice_ethdev.c +5
-0+/** +* Considering QinQ packet, max frame size should be equal or +* larger than total size of MTU and Ether overhead. +*/ +if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) {
Why we need this check?
Can we just call ice_mtu_set directly
And please remove above comment, since ether overhead is already considered in ice_mtu_set.
Quoted 10 lines
drivers/net/ice/ice_ethdev.c +5
-1+ ret =ice_mtu_set (dev, dev->data->mtu); +if (ret !=0 ) +return ret; + } + ret =ice_init_rss (pf);if (ret) {PMD_DRV_LOG (ERR ,"Failed to enable rss for PF" ); --2.17.1
Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Quoted 50 lines
Quoted 49 lines
-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Monday, September 28, 2020 2:56 PM
To: [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Ananyev, Konstantin <[email protected]>; Yang, SteveX <[email protected]>
Subject: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaulttestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
ice can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in
dev_configops.Fixes 50cc9d2a6e9d ("net/ice: fix max frame size")Signed-off-by SteveX Yang <[email protected]>--- drivers/net/ice/ice_ethdev.c | 11 +++++++++++ 1 file changed, 11 insertions(+)drivers/net/ice/ice_ethdev.c index renamed from drivers/net/ice/ice_ethdev.c +0
-0
cfd357b05..6b7098444100644drivers/net/ice/ice_ethdev.c +2
-0@@ -3146,6 +3146,7 @@ ice_dev_configure(struct rte_eth_dev *dev)struct ice_adapter *ad =ICE_DEV_PRIVATE_TO_ADAPTER (dev->data->dev_private);struct ice_pf *pf =ICE_DEV_PRIVATE_TO_PF (dev->data->dev_private); +uint32_t frame_size = dev->data->mtu +ICE_ETH_OVERHEAD ;int ret;/* Initialize to TRUE. If any of Rx queues doesn't meet the @@ -3157,6 +3158,16 @@ ice_dev_configure(struct rte_eth_dev *dev) if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) dev->data->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_RSS_HASH;+/**
+ * Considering QinQ packet, max frame size should be equal or
+ * larger than total size of MTU and Ether overhead.
+ */
Quoted 5 lines
Quoted 1 line
+if (
frame_size>dev->data->dev_conf.rxmode.max_rx_pkt_len) {Why we need this check?
Can we just callice_mtu_setdirectly
I think that without that check we can silently overwrite provided by user dev_conf.rxmode.max_rx_pkt_len value.
Quoted 14 lines
And please remove above comment, since ether overhead is already considered in
ice_mtu_set.Quoted 10 lines
drivers/net/ice/ice_ethdev.c +5
-1+ret =ice_mtu_set (dev, dev->data->mtu); +if (ret !=0 ) +return ret; +} + ret =ice_init_rss (pf);if (ret) {PMD_DRV_LOG (ERR ,"Failed to enable rss for PF" ); --2.17.1
Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Quoted 64 lines
-----Original Message-----
From: Ananyev, Konstantin <[email protected]>
Sent: Wednesday, September 30, 2020 7:02 AM
To: Zhang, Qi Z <[email protected]>; Yang, SteveX <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 51 lines
Quoted 50 lines
-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Monday, September 28, 2020 2:56 PM
To: [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Ananyev, Konstantin <[email protected]>; Yang, SteveX <[email protected]>
Subject: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaulttestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
ice can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in
dev_configops.Fixes 50cc9d2a6e9d ("net/ice: fix max frame size")Signed-off-by SteveX Yang <[email protected]>--- drivers/net/ice/ice_ethdev.c | 11 +++++++++++ 1 file changed, 11 insertions(+)(quoted diff) +0
-0
b/drivers/net/ice/ice_ethdev.cindexcfd357b05..6b7098444100644drivers/net/ice/ice_ethdev.c +0
-0@@ -3146,6 +3146,7 @@ ice_dev_configure(struct rte_eth_dev *dev)struct
ice_adapter*ad =ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
structice_pf*pf =ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
+uint32_tframe_size=dev->data->mtu+ICE_ETH_OVERHEAD;
int ret;/* Initialize to TRUE. If any of Rx queues doesn't meet the @@
-3157,6
+3158,16 @@ice_dev_configure(struct rte_eth_dev *dev)
if (dev->data->dev_conf.rxmode.mq_modeÐ_MQ_RX_RSS_FLAG)dev->data->dev_conf.rxmode.offloads|=DEV_RX_OFFLOAD_RSS_HASH;+/**
+ * Considering QinQ packet, max frame size should be equal or
+ * larger than total size of MTU and Ether overhead.
+ */
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
+if (
frame_size>dev->data->dev_conf.rxmode.max_rx_pkt_len) {Why we need this check?
Can we just callice_mtu_setdirectlyI think that without that check we can silently overwrite provided by user dev_conf.rxmode.max_rx_pkt_len value.
OK, I see
But still have one questiondev->data->mtu is initialized to 1518 as default , but if application set dev_conf.rxmode.max_rx_pkt_len = 1000 in dev_configure. does that mean we will still will set mtu to 1518, is this expected?
Should we just call ice_mtu_set(dev, dev_conf.rxmode.max_rx_pkt_len) here?
Quoted 14 lines
Quoted 2 lines
And please remove above comment, since ether overhead is already
considered in
ice_mtu_set.Quoted 10 lines
Quoted 9 lines
drivers/net/ice/ice_ethdev.c +2
-1+ret =ice_mtu_set (dev, dev->data->mtu);if (ret !=0 )return ret; } + ret =ice_init_rss (pf);if (ret) {PMD_DRV_LOG (ERR ,"Failed to enable rss for PF" ); --2.17.1
A message that is not in the archive (sent off-list or not yet received): DM6PR11MB4362515283D00E27A793E6B0F9330@DM6PR11MB4362.namprd11.prod.outlook.com
Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Quoted 114 lines
-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Wednesday, September 30, 2020 9:32 AM
To: Zhang, Qi Z <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 42 lines
-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Wednesday, September 30, 2020 8:35 AM
To: Ananyev, Konstantin <[email protected]>; Yang, SteveX <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 29 lines
-----Original Message-----
From: Ananyev, Konstantin <[email protected]>
Sent: Wednesday, September 30, 2020 7:02 AM
To: Zhang, Qi Z <[email protected]>; Yang, SteveX <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 18 lines
Quoted 18 lines
-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Monday, September 28, 2020 2:56 PM
To: [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Ananyev, Konstantin <[email protected]>; Yang, SteveX <[email protected]>
Subject: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaulttestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw
side.
Quoted 47 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
ice can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in
dev_configops.
Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
Fixes 50cc9d2a6e9d ("net/ice: fix max frame size")Signed-off-by SteveX Yang <[email protected]>--- drivers/net/ice/ice_ethdev.c | 11 +++++++++++ 1 file changed, 11 insertions(+)(quoted diff) +0
-0
b/drivers/net/ice/ice_ethdev.cindexcfd357b05..6b7098444100644drivers/net/ice/ice_ethdev.c +0
-0@@ -3146,6 +3146,7 @@ ice_dev_configure(struct rte_eth_dev *dev)struct
ice_adapter*ad =ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
structice_pf*pf =ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); +uint32_tframe_size=dev->data->mtu+ICE_ETH_OVERHEAD;
int ret;Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
/* Initialize to TRUE. If any of Rx queues doesn't meet the @@
-3157,6
+3158,16 @@ice_dev_configure(struct rte_eth_dev *dev)
if (dev->data->dev_conf.rxmode.mq_modeÐ_MQ_RX_RSS_FLAG)dev->data->dev_conf.rxmode.offloads|=
DEV_RX_OFFLOAD_RSS_HASH;Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
+/**
+ * Considering QinQ packet, max frame size should be equal or
+ * larger than total size of MTU and Ether overhead.
+ */Quoted 8 lines
Quoted 5 lines
Quoted 1 line
+if (
frame_size>dev->data->dev_conf.rxmode.max_rx_pkt_len) {Why we need this check?
Can we just callice_mtu_setdirectlyI think that without that check we can silently overwrite provided by user dev_conf.rxmode.max_rx_pkt_len value.
Quoted 8 lines
OK, I see
But still have one question
dev->data->mtuis initialized to 1518 as default , but if applicationdev->data->set
dev_conf.rxmode.max_rx_pkt_len = 1000 indev_configure. does that mean we will still will set mtu to 1518, is this expected?
Quoted 2 lines
max_rx_pkt_lenshould be larger than mtu at least, so we should raise themax_rx_pkt_len(e.g.:1518) to hold expected mtu value (e.g.: 1500).
Ok, this describe the problem more general and better to replace exist code comment and commit log for easy understanding. Please send a new version for reword
Quoted 33 lines
Generally, the mtu value can be adjustable from user (e.g.: ip link set ens801f0 mtu 1400), hence, we just adjust the
max_rx_pkt_lento satisfy mtu requirement.Quoted 2 lines
Should we just call
ice_mtu_set(dev, dev_conf.rxmode.max_rx_pkt_len)here?
ice_mtu_set(dev, mtu)will append ether overhead to frame_size/max_rx_pkt_len, so we need pass the mtu value as the 2nd parameter, or not themax_rx_pkt_len.Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
And please remove above comment, since ether overhead is already
considered in
ice_mtu_set.Ether overhead is already considered in
ice_mtu_set, but it also should be considered as the adjustment condition that ifice_mtu_setneed be invoked. So, it perhaps should remain this comment before thisif()condition.Quoted 13 lines
Quoted 12 lines
Quoted 11 lines
Quoted 10 lines
drivers/net/ice/ice_ethdev.c +3
-1+ret =ice_mtu_set (dev, dev->data->mtu);if (ret !=0 )return +ret; } + ret =ice_init_rss (pf);if (ret) {PMD_DRV_LOG (ERR ,"Failed to enable rss for PF" ); --2.17.1
Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Quoted 114 lines · Qi Z
Quoted 114 lines
-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Wednesday, September 30, 2020 9:32 AM
To: Zhang, Qi Z <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 42 lines
-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Wednesday, September 30, 2020 8:35 AM
To: Ananyev, Konstantin <[email protected]>; Yang, SteveX <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 29 lines
-----Original Message-----
From: Ananyev, Konstantin <[email protected]>
Sent: Wednesday, September 30, 2020 7:02 AM
To: Zhang, Qi Z <[email protected]>; Yang, SteveX <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 18 lines
Quoted 18 lines
-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Monday, September 28, 2020 2:56 PM
To: [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Ananyev, Konstantin <[email protected]>; Yang, SteveX <[email protected]>
Subject: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaulttestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw
side.
Quoted 55 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
ice can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in
dev_configops.
Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
Fixes 50cc9d2a6e9d ("net/ice: fix max frame size")Signed-off-by SteveX Yang <[email protected]>--- drivers/net/ice/ice_ethdev.c | 11 +++++++++++ 1 file changed, 11 insertions(+)(quoted diff) +0
-0
b/drivers/net/ice/ice_ethdev.cindexcfd357b05..6b7098444100644drivers/net/ice/ice_ethdev.c +0
-0@@ -3146,6 +3146,7 @@ ice_dev_configure(struct rte_eth_dev *dev)struct
ice_adapter*ad =ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
structice_pf*pf =ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); +uint32_tframe_size=dev->data->mtu+ICE_ETH_OVERHEAD;
int ret;Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
/* Initialize to TRUE. If any of Rx queues doesn't meet the @@
-3157,6
+3158,16 @@ice_dev_configure(struct rte_eth_dev *dev)
if (dev->data->dev_conf.rxmode.mq_modeÐ_MQ_RX_RSS_FLAG)dev->data->dev_conf.rxmode.offloads|=
DEV_RX_OFFLOAD_RSS_HASH;Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
+/**
+ * Considering QinQ packet, max frame size should be equal or
+ * larger than total size of MTU and Ether overhead.
+ */Quoted 8 lines
Quoted 5 lines
Quoted 1 line
+if (
frame_size>dev->data->dev_conf.rxmode.max_rx_pkt_len) {Why we need this check?
Can we just callice_mtu_setdirectlyI think that without that check we can silently overwrite provided by user dev_conf.rxmode.max_rx_pkt_len value.
OK, I see
But still have one question
dev->data->mtuis initialized to 1518 as default , but if applicationdev->data->set
dev_conf.rxmode.max_rx_pkt_len = 1000 indev_configure. does that mean we will still will set mtu to 1518, is this expected?
Quoted 6 lines
Quoted 2 lines
max_rx_pkt_lenshould be larger than mtu at least, so we should raise themax_rx_pkt_len(e.g.:1518) to hold expected mtu value (e.g.: 1500).Ok, this describe the problem more general and better to replace exist code comment and commit log for easy understanding. Please send a new version for reword
I didn't really get this set.
Application explicitly sets 'max_rx_pkt_len' to '1518', and a frame bigger than this size is dropped. Isn't this what should be, why we are trying to overwrite user configuration in PMD to prevent this?
During eth_dev allocation, mtu set to default '1500', by ethdev layer.
And testpmd sets 'max_rx_pkt_len' by default to '1518'.
I think Qi's concern above is valid, what is user set 'max_rx_pkt_len' to '1000' and mean it? PMD will not honor the user config.
Why not simply increase the default 'max_rx_pkt_len' in testpmd?
And I guess even better what we need is to tell to the application what the frame overhead PMD accepts.
So the application can set proper 'max_rx_pkt_len' value per port for a given/requested MTU value.
@Ian, cc'ed, was complaining almost same thing years ago, these PMD overhead macros and 'max_mtu'/'min_mtu' added because of that, perhaps he has a solution now?
And why this same thing can't happen to other PMDs? If this is a problem for all PMDs, we should solve in other level, not for only some PMDs.
Quoted 35 lines
Quoted 34 lines
Generally, the mtu value can be adjustable from user (e.g.: ip link set ens801f0 mtu 1400), hence, we just adjust the
max_rx_pkt_lento satisfy mtu requirement.Quoted 2 lines
Should we just call
ice_mtu_set(dev, dev_conf.rxmode.max_rx_pkt_len)here?
ice_mtu_set(dev, mtu)will append ether overhead to frame_size/max_rx_pkt_len, so we need pass the mtu value as the 2nd parameter, or not themax_rx_pkt_len.Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
And please remove above comment, since ether overhead is already
considered in
ice_mtu_set.Ether overhead is already considered in
ice_mtu_set, but it also should be considered as the adjustment condition that ifice_mtu_setneed be invoked. So, it perhaps should remain this comment before thisif()condition.Quoted 13 lines
Quoted 12 lines
Quoted 11 lines
Quoted 10 lines
drivers/net/ice/ice_ethdev.c +3
-1+ret =ice_mtu_set (dev, dev->data->mtu);if (ret !=0 )return +ret; } + ret =ice_init_rss (pf);if (ret) {PMD_DRV_LOG (ERR ,"Failed to enable rss for PF" ); --2.17.1
A message that is not in the archive (sent off-list or not yet received): DM6PR11MB43628BBF9DCE7CC4D7C05AD8F91E0@DM6PR11MB4362.namprd11.prod.outlook.com
Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Quoted 162 lines
Quoted 137 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Wednesday, October 14, 2020 11:38 PM
To: Zhang, Qi Z <[email protected]>; Yang, SteveX <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Stokes, Ian <[email protected]>
Subject: Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 15 lines · Qi Z
Quoted 15 lines
-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Wednesday, September 30, 2020 9:32 AM
To: Zhang, Qi Z <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 4 lines
Quoted 4 lines
Quoted 4 lines
-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Wednesday, September 30, 2020 8:35 AM
To: Ananyev, Konstantin <[email protected]>; Yang,SteveX
Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
<[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 12 lines
-----Original Message-----
From: Ananyev, Konstantin <[email protected]>
Sent: Wednesday, September 30, 2020 7:02 AM
To: Zhang, Qi Z <[email protected]>; Yang, SteveX <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 1 line
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Monday, September 28, 2020 2:56 PM
To: [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>;Zhang,
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Ananyev, Konstantin <[email protected]>; Yang,
SteveX
Quoted 22 lines
Quoted 22 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
<[email protected]>
Subject: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaulttestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw
side.
Quoted 13 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
ice can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in
dev_configops.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Fixes 50cc9d2a6e9d ("net/ice: fix max frame size")Signed-off-by SteveX Yang <[email protected]>--- drivers/net/ice/ice_ethdev.c | 11 +++++++++++ 1 file changed, 11 insertions(+)Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
drivers/net/ice/ice_ethdev.c ice_dev_configure(struct rte_eth_dev
Quoted 6 lines
(quoted diff) +0
-0
b/drivers/net/ice/ice_ethdev.cindexcfd357b05..6b7098444100644drivers/net/ice/ice_ethdev.c +0
-0@@ -3146,6 +3146,7 @@ ice_dev_configure(struct rte_eth_dev*dev)
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
struct
ice_adapter*ad =ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
structice_pf*pf =ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); +uint32_tframe_size=dev->data->mtu+ICE_ETH_OVERHEAD;
int ret;/* Initialize to TRUE. If any of Rx queues doesn't meet the @@
-3157,6
+3158,16 @@ice_dev_configure(struct rte_eth_dev *dev)
if (dev->data->dev_conf.rxmode.mq_mode&
ETH_MQ_RX_RSS_FLAG)Quoted 26 lines
Quoted 26 lines
Quoted 25 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
dev->data->dev_conf.rxmode.offloads|=
DEV_RX_OFFLOAD_RSS_HASH;Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
+/**
+ * Considering QinQ packet, max frame size should be equal or
+ * larger than total size of MTU and Ether overhead.
+ */Quoted 8 lines
Quoted 5 lines
Quoted 1 line
+if (
frame_size>dev->data->dev_conf.rxmode.max_rx_pkt_len) {Why we need this check?
Can we just callice_mtu_setdirectlyI think that without that check we can silently overwrite provided by user dev_conf.rxmode.max_rx_pkt_len value.
OK, I see
But still have one question
dev->data->mtuis initialized to 1518 as default , but ifdev->data->applicationset
dev_conf.rxmode.max_rx_pkt_len = 1000 indev_configure. does that mean we will still will set mtu to 1518, is this expected?Quoted 4 lines
Quoted 2 lines
max_rx_pkt_lenshould be larger than mtu at least, so we should raise themax_rx_pkt_len(e.g.:1518) to hold expected mtu value (e.g.: 1500).Ok, this describe the problem more general and better to replace exist
Quoted 8 lines
code comment and commit log for easy understanding.
Quoted 2 lines
Please send a new version for reword
I didn't really get this set.
Application explicitly sets '
max_rx_pkt_len' to '1518', and a frame bigger than this size is dropped.Sure, it is normal case for dropping oversize data.
Quoted 3 lines
Isn't this what should be, why we are trying to overwrite user configuration in PMD to prevent this?
But it is a confliction that application/user sets mtu &
max_rx_pkt_lenat the same time.
This fix will make a decision when confliction occurred.
MTU value will come from user operation (e.g.: port config mtu 0 1500) directly,
so, themax_rx_pkt_lenwill resize itself to adapt expected MTU value if its size is smaller than MTU + Ether overhead.Quoted 4 lines
During
eth_devallocation, mtu set to default '1500', by ethdev layer. And testpmd sets 'max_rx_pkt_len' by default to '1518'.
I think Qi's concern above is valid, what is user set 'max_rx_pkt_len' to '1000' and mean it? PMD will not honor the user config.
Quoted 16 lines
I'm not sure when set 'mtu' to '1500' and '
max_rx_pkt_len' to '1000', what's the behavior expected? If still keep the 'max_rx_pkt_len' value, that means the larger 'mtu' will be invalid.Quoted 3 lines
Why not simply increase the default '
max_rx_pkt_len' in testpmd?The default '
max_rx_pkt_len' has been initialized to generical value (1518) and default 'mtu' is '1500' in testpmd, But it isn't suitable to those NIC drivers which Ether overhead is larger than 18. (e.g.: ice, i40e) if 'mtu' value is preferable.Quoted 7 lines
And I guess even better what we need is to tell to the application what the frame overhead PMD accepts.
So the application can set proper 'max_rx_pkt_len' value per port for a given/requested MTU value.
@Ian, cc'ed, was complaining almost same thing years ago, these PMD overhead macros and 'max_mtu'/'min_mtu' added because of that, perhaps he has a solution now?
From my perspective the main problem here:
We have 2 different variables for nearly the same thing:
rte_eth_dev_data.mtu and rte_eth_dev_data.dev_conf.max_rx_pkt_len. and 2 different API to update them: dev_mtu_set() and dev_configure(). And inside majority of Intel PMDs we don't keep these 2 variables in sync:
- mtu_set() will update both variables.
- dev_configure() will update only max_rx_pkt_len, but will keep mtu intact.
This patch fixes this inconsistency, which I think is a good thing. Though yes, it introduces change in behaviour.
Let say the code:rte_eth_dev_set_mtu(port, 1500);
dev_conf.max_rx_pkt_len = 1000;rte_eth_dev_configure(port, 1, 1, &dev_conf);
Before the patch will result:
mtu==1500, max_rx_pkt_len=1000; //out of sync looks wrong to me
After the patch:
mtu=1500, max_rx_ptk_len=1518; // in sync, change in behaviour.
If you think we need to preserve current behaviour,
then I suppose the easiest thing would be to change dev_config() code to update mtu value based on max_rx_pkt_len.
I.E: dev_configure {...; mtu_set(max_rx_pkt_len - OVERHEAD); ...} So the code snippet above will result:
mtu=982,max_rx_pkt_len=1000;
Konstantin
Quoted 46 lines
Quoted 5 lines
And why this same thing can't happen to other PMDs? If this is a problem for all PMDs, we should solve in other level, not for only some PMDs.
No, all PMDs exist the same issue, another proposal:
-rte_ethdevprovides the unique resize 'max_rx_pkt_len' inrte_eth_dev_configure();
- provide the uniform API for fetching the NIC's supported Ether Overhead size;
Is it feasible?Quoted 36 lines
Quoted 14 lines
Quoted 14 lines
Generally, the mtu value can be adjustable from user (e.g.: ip link set ens801f0 mtu 1400), hence, we just adjust the
max_rx_pkt_lento satisfy mtu requirement.Quoted 2 lines
Should we just call
ice_mtu_set(dev, dev_conf.rxmode.max_rx_pkt_len)here?
ice_mtu_set(dev, mtu)will append ether overhead to frame_size/max_rx_pkt_len, so we need pass the mtu value as the 2nd parameter, or not themax_rx_pkt_len.Quoted 3 lines
Quoted 3 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Quoted 1 line
And please remove above comment, since ether overhead is already
considered in
ice_mtu_set.Ether overhead is already considered in
ice_mtu_set, but it also should be considered as the adjustment condition that ifice_mtu_setneed be invoked.
Quoted 17 lines
Quoted 16 lines
So, it perhaps should remain this comment before this
if()condition.Quoted 13 lines
Quoted 12 lines
Quoted 11 lines
Quoted 10 lines
drivers/net/ice/ice_ethdev.c +3
-1+ret =ice_mtu_set (dev, dev->data->mtu);if (ret !=0 )return +ret; } + ret =ice_init_rss (pf);if (ret) {PMD_DRV_LOG (ERR ,"Failed to enable rss for PF" ); --2.17.1
Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Quoted 179 lines · Konstantin
Quoted 162 lines
Quoted 137 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Wednesday, October 14, 2020 11:38 PM
To: Zhang, Qi Z <[email protected]>; Yang, SteveX <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Stokes, Ian <[email protected]>
Subject: Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 15 lines · Qi Z
Quoted 15 lines
-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Wednesday, September 30, 2020 9:32 AM
To: Zhang, Qi Z <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 4 lines
Quoted 4 lines
Quoted 4 lines
-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Wednesday, September 30, 2020 8:35 AM
To: Ananyev, Konstantin <[email protected]>; Yang,SteveX
Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
<[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 12 lines
-----Original Message-----
From: Ananyev, Konstantin <[email protected]>
Sent: Wednesday, September 30, 2020 7:02 AM
To: Zhang, Qi Z <[email protected]>; Yang, SteveX <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 1 line
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Monday, September 28, 2020 2:56 PM
To: [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>;Zhang,
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Ananyev, Konstantin <[email protected]>; Yang,
SteveX
Quoted 22 lines
Quoted 22 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
<[email protected]>
Subject: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaulttestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw
side.
Quoted 13 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
ice can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in
dev_configops.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Fixes 50cc9d2a6e9d ("net/ice: fix max frame size")Signed-off-by SteveX Yang <[email protected]>--- drivers/net/ice/ice_ethdev.c | 11 +++++++++++ 1 file changed, 11 insertions(+)Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
drivers/net/ice/ice_ethdev.c ice_dev_configure(struct rte_eth_dev
Quoted 6 lines
(quoted diff) +0
-0
b/drivers/net/ice/ice_ethdev.cindexcfd357b05..6b7098444100644drivers/net/ice/ice_ethdev.c +0
-0@@ -3146,6 +3146,7 @@ ice_dev_configure(struct rte_eth_dev*dev)
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
struct
ice_adapter*ad =ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
structice_pf*pf =ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);+uint32_t frame_size = dev->data->mtu + ICE_ETH_OVERHEAD; int ret; /* Initialize to TRUE. If any of Rx queues doesn't meet the @@-3157,6
+3158,16 @@ice_dev_configure(struct rte_eth_dev *dev)
if (dev->data->dev_conf.rxmode.mq_mode&
ETH_MQ_RX_RSS_FLAG)Quoted 26 lines
Quoted 26 lines
Quoted 25 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
dev->data->dev_conf.rxmode.offloads|=
DEV_RX_OFFLOAD_RSS_HASH;Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
+/**
+ * Considering QinQ packet, max frame size should be equal or
+ * larger than total size of MTU and Ether overhead.
+ */Quoted 8 lines
Quoted 5 lines
Quoted 1 line
+if (
frame_size>dev->data->dev_conf.rxmode.max_rx_pkt_len) {Why we need this check?
Can we just callice_mtu_setdirectlyI think that without that check we can silently overwrite provided by user dev_conf.rxmode.max_rx_pkt_len value.
OK, I see
But still have one question
dev->data->mtuis initialized to 1518 as default , but ifdev->data->applicationset
dev_conf.rxmode.max_rx_pkt_len = 1000 indev_configure. does that mean we will still will set mtu to 1518, is this expected?Quoted 4 lines
Quoted 2 lines
max_rx_pkt_lenshould be larger than mtu at least, so we should raise themax_rx_pkt_len(e.g.:1518) to hold expected mtu value (e.g.: 1500).Ok, this describe the problem more general and better to replace exist
Quoted 8 lines
code comment and commit log for easy understanding.
Quoted 2 lines
Please send a new version for reword
I didn't really get this set.
Application explicitly sets '
max_rx_pkt_len' to '1518', and a frame bigger than this size is dropped.Sure, it is normal case for dropping oversize data.
Quoted 3 lines
Isn't this what should be, why we are trying to overwrite user configuration in PMD to prevent this?
But it is a confliction that application/user sets mtu &
max_rx_pkt_lenat the same time.
This fix will make a decision when confliction occurred.
MTU value will come from user operation (e.g.: port config mtu 0 1500) directly,
so, themax_rx_pkt_lenwill resize itself to adapt expected MTU value if its size is smaller than MTU + Ether overhead.Quoted 4 lines
During
eth_devallocation, mtu set to default '1500', by ethdev layer. And testpmd sets 'max_rx_pkt_len' by default to '1518'.
I think Qi's concern above is valid, what is user set 'max_rx_pkt_len' to '1000' and mean it? PMD will not honor the user config.Quoted 16 lines
I'm not sure when set 'mtu' to '1500' and '
max_rx_pkt_len' to '1000', what's the behavior expected? If still keep the 'max_rx_pkt_len' value, that means the larger 'mtu' will be invalid.Quoted 3 lines
Why not simply increase the default '
max_rx_pkt_len' in testpmd?The default '
max_rx_pkt_len' has been initialized to generical value (1518) and default 'mtu' is '1500' in testpmd, But it isn't suitable to those NIC drivers which Ether overhead is larger than 18. (e.g.: ice, i40e) if 'mtu' value is preferable.Quoted 7 lines
And I guess even better what we need is to tell to the application what the frame overhead PMD accepts.
So the application can set proper 'max_rx_pkt_len' value per port for a given/requested MTU value.
@Ian, cc'ed, was complaining almost same thing years ago, these PMD overhead macros and 'max_mtu'/'min_mtu' added because of that, perhaps he has a solution now?
Quoted 4 lines
From my perspective the main problem here:
We have 2 different variables for nearly the same thing:
rte_eth_dev_data.mtu and rte_eth_dev_data.dev_conf.max_rx_pkt_len. and 2 different API to update them:dev_mtu_set()anddev_configure().
According API 'max_rx_pkt_len' is 'Only used if JUMBO_FRAME enabled' Although not sure that is practically what is done for all drivers.
Quoted 4 lines
And inside majority of Intel PMDs we don't keep these 2 variables in sync:
-mtu_set()will update both variables.
-dev_configure()will update onlymax_rx_pkt_len, but will keep mtu intact.
Quoted 8 lines
This patch fixes this inconsistency, which I think is a good thing. Though yes, it introduces change in behaviour.
Let say the code:
rte_eth_dev_set_mtu(port, 1500);
dev_conf.max_rx_pkt_len = 1000;rte_eth_dev_configure(port, 1, 1, &dev_conf);
'rte_eth_dev_configure()' is one of the first APIs called, it is called before 'rte_eth_dev_set_mtu().
When 'rte_eth_dev_configure()' is called, MTU is set to '1500' by default by ethdev layer, so it is not user configuration, but 'max_rx_pkt_len' is.
And later, when 'rte_eth_dev_set_mtu()' is called, but MTU and 'max_rx_pkt_len' are updated (mostly).
Quoted 6 lines
Before the patch will result:
mtu==1500, max_rx_pkt_len=1000; //out of sync looks wrong to meAfter the patch:
mtu=1500, max_rx_ptk_len=1518; // in sync, change in behaviour.
Quoted 7 lines
If you think we need to preserve current behaviour,
then I suppose the easiest thing would be to changedev_config()code to update mtu value based onmax_rx_pkt_len.
I.E:dev_configure{...;mtu_set(max_rx_pkt_len - OVERHEAD); ...} So the code snippet above will result:
mtu=982,max_rx_pkt_len=1000;
The 'max_rx_ptk_len' is annoyance for a long time, what do you think to just drop it?
By default device will be up with default MTU (1500), later 'rte_eth_dev_set_mtu' can be used to set the MTU, no frame size setting at all.
Will this work?
And for short term, for above Intel PMDs, there must be a place this 'max_rx_pkt_len' value taken into account (mostly 'start()' dev_ops), that function can be updated to take 'max_rx_pkt_len' only if JUMBO_FRAME set, otherwise use the 'MTU' value.
Without 'start()' updated the current logic won't work after stop & start anyway.
Quoted 72 lines
Konstantin
Quoted 46 lines
Quoted 5 lines
And why this same thing can't happen to other PMDs? If this is a problem for all PMDs, we should solve in other level, not for only some PMDs.
No, all PMDs exist the same issue, another proposal:
-rte_ethdevprovides the unique resize 'max_rx_pkt_len' inrte_eth_dev_configure();
- provide the uniform API for fetching the NIC's supported Ether Overhead size;
Is it feasible?Quoted 36 lines
Quoted 14 lines
Quoted 14 lines
Generally, the mtu value can be adjustable from user (e.g.: ip link set ens801f0 mtu 1400), hence, we just adjust the
max_rx_pkt_lento satisfy mtu requirement.Quoted 2 lines
Should we just call
ice_mtu_set(dev, dev_conf.rxmode.max_rx_pkt_len)here?
ice_mtu_set(dev, mtu)will append ether overhead to frame_size/max_rx_pkt_len, so we need pass the mtu value as the 2nd parameter, or not themax_rx_pkt_len.Quoted 3 lines
Quoted 3 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Quoted 1 line
And please remove above comment, since ether overhead is already
considered in
ice_mtu_set.Ether overhead is already considered in
ice_mtu_set, but it also should be considered as the adjustment condition that ifice_mtu_setneed be invoked.
Quoted 17 lines
Quoted 16 lines
So, it perhaps should remain this comment before this
if()condition.Quoted 13 lines
Quoted 12 lines
Quoted 11 lines
Quoted 10 lines
drivers/net/ice/ice_ethdev.c +3
-1+ret =ice_mtu_set (dev, dev->data->mtu);if (ret !=0 )return +ret; } + ret =ice_init_rss (pf);if (ret) {PMD_DRV_LOG (ERR ,"Failed to enable rss for PF" ); --2.17.1
Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Quoted 110 lines
Quoted 110 lines
Quoted 109 lines
Quoted 68 lines
Quoted 19 lines
Quoted 19 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw
side.
Quoted 13 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
ice can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in
dev_configops.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Fixes 50cc9d2a6e9d ("net/ice: fix max frame size")Signed-off-by SteveX Yang <[email protected]>--- drivers/net/ice/ice_ethdev.c | 11 +++++++++++ 1 file changed, 11 insertions(+)Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
drivers/net/ice/ice_ethdev.c ice_dev_configure(struct rte_eth_dev
Quoted 6 lines
(quoted diff) +0
-0
b/drivers/net/ice/ice_ethdev.cindexcfd357b05..6b7098444100644drivers/net/ice/ice_ethdev.c +0
-0@@ -3146,6 +3146,7 @@ ice_dev_configure(struct rte_eth_dev*dev)
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
struct
ice_adapter*ad =ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
structice_pf*pf =ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);+uint32_t frame_size = dev->data->mtu + ICE_ETH_OVERHEAD; int ret; /* Initialize to TRUE. If any of Rx queues doesn't meet the @@-3157,6
+3158,16 @@ice_dev_configure(struct rte_eth_dev *dev)
if (dev->data->dev_conf.rxmode.mq_mode&
ETH_MQ_RX_RSS_FLAG)Quoted 26 lines
Quoted 26 lines
Quoted 25 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
dev->data->dev_conf.rxmode.offloads|=
DEV_RX_OFFLOAD_RSS_HASH;Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
+/**
+ * Considering QinQ packet, max frame size should be equal or
+ * larger than total size of MTU and Ether overhead.
+ */Quoted 8 lines
Quoted 5 lines
Quoted 1 line
+if (
frame_size>dev->data->dev_conf.rxmode.max_rx_pkt_len) {Why we need this check?
Can we just callice_mtu_setdirectlyI think that without that check we can silently overwrite provided by user dev_conf.rxmode.max_rx_pkt_len value.
OK, I see
But still have one question
dev->data->mtuis initialized to 1518 as default , but ifdev->data->applicationset
dev_conf.rxmode.max_rx_pkt_len = 1000 indev_configure. does that mean we will still will set mtu to 1518, is this expected?Quoted 4 lines
Quoted 2 lines
max_rx_pkt_lenshould be larger than mtu at least, so we should raise themax_rx_pkt_len(e.g.:1518) to hold expected mtu value (e.g.: 1500).Ok, this describe the problem more general and better to replace exist
Quoted 8 lines
code comment and commit log for easy understanding.
Quoted 2 lines
Please send a new version for reword
I didn't really get this set.
Application explicitly sets '
max_rx_pkt_len' to '1518', and a frame bigger than this size is dropped.Sure, it is normal case for dropping oversize data.
Quoted 3 lines
Isn't this what should be, why we are trying to overwrite user configuration in PMD to prevent this?
But it is a confliction that application/user sets mtu &
max_rx_pkt_lenat the same time.
This fix will make a decision when confliction occurred.
MTU value will come from user operation (e.g.: port config mtu 0 1500) directly,
so, themax_rx_pkt_lenwill resize itself to adapt expected MTU value if its size is smaller than MTU + Ether overhead.Quoted 4 lines
During
eth_devallocation, mtu set to default '1500', by ethdev layer. And testpmd sets 'max_rx_pkt_len' by default to '1518'.
I think Qi's concern above is valid, what is user set 'max_rx_pkt_len' to '1000' and mean it? PMD will not honor the user config.I'm not sure when set 'mtu' to '1500' and '
max_rx_pkt_len' to '1000', what's the behavior expected? If still keep the 'max_rx_pkt_len' value, that means the larger 'mtu' will be invalid.Quoted 3 lines
Why not simply increase the default '
max_rx_pkt_len' in testpmd?The default '
max_rx_pkt_len' has been initialized to generical value (1518) and default 'mtu' is '1500' in testpmd, But it isn't suitable to those NIC drivers which Ether overhead is larger than 18. (e.g.: ice, i40e) if 'mtu' value is preferable.Quoted 7 lines
And I guess even better what we need is to tell to the application what the frame overhead PMD accepts.
So the application can set proper 'max_rx_pkt_len' value per port for a given/requested MTU value.
@Ian, cc'ed, was complaining almost same thing years ago, these PMD overhead macros and 'max_mtu'/'min_mtu' added because of that, perhaps he has a solution now?
Quoted 7 lines
Quoted 4 lines
From my perspective the main problem here:
We have 2 different variables for nearly the same thing:
rte_eth_dev_data.mtu and rte_eth_dev_data.dev_conf.max_rx_pkt_len. and 2 different API to update them:dev_mtu_set()anddev_configure().According API '
max_rx_pkt_len' is 'Only used ifJUMBO_FRAMEenabled' Although not sure that is practically what is done for all drivers.
I think most of Intel PMDs use it unconditionally.
Quoted 8 lines
Quoted 8 lines
And inside majority of Intel PMDs we don't keep these 2 variables in sync:
-mtu_set()will update both variables.
-dev_configure()will update onlymax_rx_pkt_len, but will keep mtu intact.This patch fixes this inconsistency, which I think is a good thing. Though yes, it introduces change in behaviour.
Quoted 8 lines
Quoted 5 lines
Let say the code:
rte_eth_dev_set_mtu(port, 1500);
dev_conf.max_rx_pkt_len = 1000;rte_eth_dev_configure(port, 1, 1, &dev_conf);'
rte_eth_dev_configure()' is one of the first APIs called, it is called before 'rte_eth_dev_set_mtu().
Usually yes.
But you can still do sometimes later: dev_mtu_set(); ...; dev_stop(); dev_configure(); dev_start();
Quoted 3 lines
When '
rte_eth_dev_configure()' is called, MTU is set to '1500' by default by ethdev layer, so it is not user configuration, but 'max_rx_pkt_len' is.
See above.
PMD doesn't know where this MTU value came from (default ethdev value or user specified value) and probably it shouldn't care.
Quoted 3 lines
And later, when '
rte_eth_dev_set_mtu()' is called, but MTU and 'max_rx_pkt_len' are updated (mostly).
Yes, in mtu_set() we update both.
But we don't update MTU in dev_configure(), only max_rx_pkt_len. That what this patch tries to fix (as I understand it).
Quoted 16 lines
Quoted 8 lines
Before the patch will result:
mtu==1500, max_rx_pkt_len=1000; //out of sync looks wrong to meAfter the patch:
mtu=1500, max_rx_ptk_len=1518; // in sync, change in behaviour.Quoted 7 lines
If you think we need to preserve current behaviour,
then I suppose the easiest thing would be to changedev_config()code to update mtu value based onmax_rx_pkt_len.
I.E:dev_configure{...;mtu_set(max_rx_pkt_len - OVERHEAD); ...} So the code snippet above will result:
mtu=982,max_rx_pkt_len=1000;
Quoted 7 lines
The '
max_rx_ptk_len' is annoyance for a long time, what do you think to just drop it?By default device will be up with default MTU (1500), later '
rte_eth_dev_set_mtu' can be used to set the MTU, no frame size setting at all.Will this work?
I think it might, but that's a big change, probably too risky at that stage...
Quoted 6 lines
And for short term, for above Intel PMDs, there must be a place this '
max_rx_pkt_len' value taken into account (mostly 'start()'dev_ops), that function can be updated to take 'max_rx_pkt_len' only ifJUMBO_FRAMEset, otherwise use the 'MTU' value.
Even if we'll use max_rx_pkt_len only when if JUMBO_FRAME is set, I think we still need to keep max_rx_pkt_len and MTU values in sync.
Quoted 54 lines
Without '
start()' updated the current logic won't work after stop & start anyway.Quoted 50 lines
Quoted 49 lines
Quoted 8 lines
And why this same thing can't happen to other PMDs? If this is a problem for all PMDs, we should solve in other level, not for only some PMDs.
No, all PMDs exist the same issue, another proposal:
-rte_ethdevprovides the unique resize 'max_rx_pkt_len' inrte_eth_dev_configure();
- provide the uniform API for fetching the NIC's supported Ether Overhead size;
Is it feasible?Quoted 36 lines
Quoted 14 lines
Quoted 14 lines
Generally, the mtu value can be adjustable from user (e.g.: ip link set ens801f0 mtu 1400), hence, we just adjust the
max_rx_pkt_lento satisfy mtu requirement.Quoted 2 lines
Should we just call
ice_mtu_set(dev, dev_conf.rxmode.max_rx_pkt_len)here?
ice_mtu_set(dev, mtu)will append ether overhead to frame_size/max_rx_pkt_len, so we need pass the mtu value as the 2nd parameter, or not themax_rx_pkt_len.Quoted 3 lines
Quoted 3 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Quoted 1 line
And please remove above comment, since ether overhead is already
considered in
ice_mtu_set.Ether overhead is already considered in
ice_mtu_set, but it also should be considered as the adjustment condition that ifice_mtu_setneed be invoked.
Quoted 17 lines
Quoted 16 lines
So, it perhaps should remain this comment before this
if()condition.Quoted 13 lines
Quoted 12 lines
Quoted 11 lines
Quoted 10 lines
drivers/net/ice/ice_ethdev.c +3
-1+ret =ice_mtu_set (dev, dev->data->mtu);if (ret !=0 )return +ret; } + ret =ice_init_rss (pf);if (ret) {PMD_DRV_LOG (ERR ,"Failed to enable rss for PF" ); --2.17.1
Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Quoted 151 lines
Quoted 112 lines
Quoted 112 lines
Quoted 111 lines
Quoted 70 lines
Quoted 21 lines
Quoted 21 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw
side.
Quoted 13 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
ice can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in
dev_configops.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Fixes 50cc9d2a6e9d ("net/ice: fix max frame size")Signed-off-by SteveX Yang <[email protected]>--- drivers/net/ice/ice_ethdev.c | 11 +++++++++++ 1 file changed, 11 insertions(+)Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
drivers/net/ice/ice_ethdev.c ice_dev_configure(struct rte_eth_dev
Quoted 6 lines
(quoted diff) +0
-0
b/drivers/net/ice/ice_ethdev.cindexcfd357b05..6b7098444100644drivers/net/ice/ice_ethdev.c +0
-0@@ -3146,6 +3146,7 @@ ice_dev_configure(struct rte_eth_dev*dev)
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
struct
ice_adapter*ad =ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
structice_pf*pf =ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);+uint32_t frame_size = dev->data->mtu + ICE_ETH_OVERHEAD; int ret; /* Initialize to TRUE. If any of Rx queues doesn't meet the @@-3157,6
+3158,16 @@ice_dev_configure(struct rte_eth_dev *dev)
if (dev->data->dev_conf.rxmode.mq_mode&
ETH_MQ_RX_RSS_FLAG)Quoted 26 lines
Quoted 26 lines
Quoted 25 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
dev->data->dev_conf.rxmode.offloads|=
DEV_RX_OFFLOAD_RSS_HASH;Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
+/**
+ * Considering QinQ packet, max frame size should be equal or
+ * larger than total size of MTU and Ether overhead.
+ */Quoted 8 lines
Quoted 5 lines
Quoted 1 line
+if (
frame_size>dev->data->dev_conf.rxmode.max_rx_pkt_len) {Why we need this check?
Can we just callice_mtu_setdirectlyI think that without that check we can silently overwrite provided by user dev_conf.rxmode.max_rx_pkt_len value.
OK, I see
But still have one question
dev->data->mtuis initialized to 1518 as default , but ifdev->data->applicationset
dev_conf.rxmode.max_rx_pkt_len = 1000 indev_configure. does that mean we will still will set mtu to 1518, is this expected?Quoted 4 lines
Quoted 2 lines
max_rx_pkt_lenshould be larger than mtu at least, so we should raise themax_rx_pkt_len(e.g.:1518) to hold expected mtu value (e.g.: 1500).Ok, this describe the problem more general and better to replace exist
Quoted 8 lines
code comment and commit log for easy understanding.
Quoted 2 lines
Please send a new version for reword
I didn't really get this set.
Application explicitly sets '
max_rx_pkt_len' to '1518', and a frame bigger than this size is dropped.Sure, it is normal case for dropping oversize data.
Quoted 3 lines
Isn't this what should be, why we are trying to overwrite user configuration in PMD to prevent this?
But it is a confliction that application/user sets mtu &
max_rx_pkt_lenat the same time.
This fix will make a decision when confliction occurred.
MTU value will come from user operation (e.g.: port config mtu 0 1500) directly,
so, themax_rx_pkt_lenwill resize itself to adapt expected MTU value if its size is smaller than MTU + Ether overhead.Quoted 4 lines
During
eth_devallocation, mtu set to default '1500', by ethdev layer. And testpmd sets 'max_rx_pkt_len' by default to '1518'.
I think Qi's concern above is valid, what is user set 'max_rx_pkt_len' to '1000' and mean it? PMD will not honor the user config.I'm not sure when set 'mtu' to '1500' and '
max_rx_pkt_len' to '1000', what's the behavior expected? If still keep the 'max_rx_pkt_len' value, that means the larger 'mtu' will be invalid.Quoted 3 lines
Why not simply increase the default '
max_rx_pkt_len' in testpmd?The default '
max_rx_pkt_len' has been initialized to generical value (1518) and default 'mtu' is '1500' in testpmd, But it isn't suitable to those NIC drivers which Ether overhead is larger than 18. (e.g.: ice, i40e) if 'mtu' value is preferable.Quoted 7 lines
And I guess even better what we need is to tell to the application what the frame overhead PMD accepts.
So the application can set proper 'max_rx_pkt_len' value per port for a given/requested MTU value.
@Ian, cc'ed, was complaining almost same thing years ago, these PMD overhead macros and 'max_mtu'/'min_mtu' added because of that, perhaps he has a solution now?Quoted 7 lines
Quoted 4 lines
From my perspective the main problem here:
We have 2 different variables for nearly the same thing:
rte_eth_dev_data.mtu and rte_eth_dev_data.dev_conf.max_rx_pkt_len. and 2 different API to update them:dev_mtu_set()anddev_configure().According API '
max_rx_pkt_len' is 'Only used ifJUMBO_FRAMEenabled' Although not sure that is practically what is done for all drivers.I think most of Intel PMDs use it unconditionally.
Quoted 8 lines
Quoted 8 lines
And inside majority of Intel PMDs we don't keep these 2 variables in sync:
-mtu_set()will update both variables.
-dev_configure()will update onlymax_rx_pkt_len, but will keep mtu intact.This patch fixes this inconsistency, which I think is a good thing. Though yes, it introduces change in behaviour.
Quoted 8 lines
Quoted 5 lines
Let say the code:
rte_eth_dev_set_mtu(port, 1500);
dev_conf.max_rx_pkt_len = 1000;rte_eth_dev_configure(port, 1, 1, &dev_conf);'
rte_eth_dev_configure()' is one of the first APIs called, it is called before 'rte_eth_dev_set_mtu().Usually yes.
But you can still do sometimes later:dev_mtu_set(); ...;dev_stop();dev_configure();dev_start();Quoted 3 lines
When '
rte_eth_dev_configure()' is called, MTU is set to '1500' by default by ethdev layer, so it is not user configuration, but 'max_rx_pkt_len' is.See above.
PMD doesn't know where this MTU value came from (default ethdev value or user specified value) and probably it shouldn't care.Quoted 1 line
Quoted 6 lines
Quoted 2 lines
And later, when '
rte_eth_dev_set_mtu()' is called, but MTU and 'max_rx_pkt_len' are updated (mostly).Yes, in
mtu_set()we update both.
But we don't update MTU indev_configure(), onlymax_rx_pkt_len. That what this patch tries to fix (as I understand it).
To be more precise - it doesn't change MTU value in dev_configure(), but instead doesn't allow max_rx_pkt_len to become smaller then MTU + OVERHEAD.
Probably changing MTU value instead is a better choice.
Quoted 91 lines
Quoted 16 lines
Quoted 8 lines
Before the patch will result:
mtu==1500, max_rx_pkt_len=1000; //out of sync looks wrong to meAfter the patch:
mtu=1500, max_rx_ptk_len=1518; // in sync, change in behaviour.Quoted 7 lines
If you think we need to preserve current behaviour,
then I suppose the easiest thing would be to changedev_config()code to update mtu value based onmax_rx_pkt_len.
I.E:dev_configure{...;mtu_set(max_rx_pkt_len - OVERHEAD); ...} So the code snippet above will result:
mtu=982,max_rx_pkt_len=1000;Quoted 7 lines
The '
max_rx_ptk_len' is annoyance for a long time, what do you think to just drop it?By default device will be up with default MTU (1500), later '
rte_eth_dev_set_mtu' can be used to set the MTU, no frame size setting at all.Will this work?
I think it might, but that's a big change, probably too risky at that stage...
Quoted 6 lines
And for short term, for above Intel PMDs, there must be a place this '
max_rx_pkt_len' value taken into account (mostly 'start()'dev_ops), that function can be updated to take 'max_rx_pkt_len' only ifJUMBO_FRAMEset, otherwise use the 'MTU' value.Even if we'll use
max_rx_pkt_lenonly when ifJUMBO_FRAMEis set, I think we still need to keepmax_rx_pkt_lenand MTU values in sync.Quoted 54 lines
Without '
start()' updated the current logic won't work after stop & start anyway.Quoted 50 lines
Quoted 49 lines
Quoted 8 lines
And why this same thing can't happen to other PMDs? If this is a problem for all PMDs, we should solve in other level, not for only some PMDs.
No, all PMDs exist the same issue, another proposal:
-rte_ethdevprovides the unique resize 'max_rx_pkt_len' inrte_eth_dev_configure();
- provide the uniform API for fetching the NIC's supported Ether Overhead size;
Is it feasible?Quoted 36 lines
Quoted 14 lines
Quoted 14 lines
Generally, the mtu value can be adjustable from user (e.g.: ip link set ens801f0 mtu 1400), hence, we just adjust the
max_rx_pkt_lento satisfy mtu requirement.Quoted 2 lines
Should we just call
ice_mtu_set(dev, dev_conf.rxmode.max_rx_pkt_len)here?
ice_mtu_set(dev, mtu)will append ether overhead to frame_size/max_rx_pkt_len, so we need pass the mtu value as the 2nd parameter, or not themax_rx_pkt_len.Quoted 3 lines
Quoted 3 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Quoted 1 line
And please remove above comment, since ether overhead is already
considered in
ice_mtu_set.Ether overhead is already considered in
ice_mtu_set, but it also should be considered as the adjustment condition that ifice_mtu_setneed be invoked.
Quoted 17 lines
Quoted 16 lines
So, it perhaps should remain this comment before this
if()condition.Quoted 13 lines
Quoted 12 lines
Quoted 11 lines
Quoted 10 lines
drivers/net/ice/ice_ethdev.c +3
-1+ret =ice_mtu_set (dev, dev->data->mtu);if (ret !=0 )return +ret; } + ret =ice_init_rss (pf);if (ret) {PMD_DRV_LOG (ERR ,"Failed to enable rss for PF" ); --2.17.1
Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Quoted 154 lines · Konstantin
Quoted 154 lines
Quoted 112 lines
Quoted 112 lines
Quoted 111 lines
Quoted 70 lines
Quoted 21 lines
Quoted 21 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw
side.
Quoted 13 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
ice can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in
dev_configops.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Fixes 50cc9d2a6e9d ("net/ice: fix max frame size")Signed-off-by SteveX Yang <[email protected]>--- drivers/net/ice/ice_ethdev.c | 11 +++++++++++ 1 file changed, 11 insertions(+)Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
drivers/net/ice/ice_ethdev.c ice_dev_configure(struct rte_eth_dev
Quoted 6 lines
(quoted diff) +0
-0
b/drivers/net/ice/ice_ethdev.cindexcfd357b05..6b7098444100644drivers/net/ice/ice_ethdev.c +0
-0@@ -3146,6 +3146,7 @@ ice_dev_configure(struct rte_eth_dev*dev)
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
struct
ice_adapter*ad =ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
structice_pf*pf =ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);+uint32_t frame_size = dev->data->mtu + ICE_ETH_OVERHEAD; int ret; /* Initialize to TRUE. If any of Rx queues doesn't meet the @@ -3157,6 +3158,16 @@ ice_dev_configure(struct rte_eth_dev *dev) if (dev->data->dev_conf.rxmode.mq_mode &
ETH_MQ_RX_RSS_FLAG)Quoted 26 lines
Quoted 26 lines
Quoted 25 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
dev->data->dev_conf.rxmode.offloads|=
DEV_RX_OFFLOAD_RSS_HASH;Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
+/**
+ * Considering QinQ packet, max frame size should be equal or
+ * larger than total size of MTU and Ether overhead.
+ */Quoted 8 lines
Quoted 5 lines
Quoted 1 line
+if (
frame_size>dev->data->dev_conf.rxmode.max_rx_pkt_len) {Why we need this check?
Can we just callice_mtu_setdirectlyI think that without that check we can silently overwrite provided by user dev_conf.rxmode.max_rx_pkt_len value.
OK, I see
But still have one question
dev->data->mtuis initialized to 1518 as default , but ifdev->data->applicationset
dev_conf.rxmode.max_rx_pkt_len = 1000 indev_configure. does that mean we will still will set mtu to 1518, is this expected?Quoted 4 lines
Quoted 2 lines
max_rx_pkt_lenshould be larger than mtu at least, so we should raise themax_rx_pkt_len(e.g.:1518) to hold expected mtu value (e.g.: 1500).Ok, this describe the problem more general and better to replace exist
Quoted 8 lines
code comment and commit log for easy understanding.
Quoted 2 lines
Please send a new version for reword
I didn't really get this set.
Application explicitly sets '
max_rx_pkt_len' to '1518', and a frame bigger than this size is dropped.Sure, it is normal case for dropping oversize data.
Quoted 3 lines
Isn't this what should be, why we are trying to overwrite user configuration in PMD to prevent this?
But it is a confliction that application/user sets mtu &
max_rx_pkt_lenat the same time.
This fix will make a decision when confliction occurred.
MTU value will come from user operation (e.g.: port config mtu 0 1500) directly,
so, themax_rx_pkt_lenwill resize itself to adapt expected MTU value if its size is smaller than MTU + Ether overhead.Quoted 4 lines
During
eth_devallocation, mtu set to default '1500', by ethdev layer. And testpmd sets 'max_rx_pkt_len' by default to '1518'.
I think Qi's concern above is valid, what is user set 'max_rx_pkt_len' to '1000' and mean it? PMD will not honor the user config.I'm not sure when set 'mtu' to '1500' and '
max_rx_pkt_len' to '1000', what's the behavior expected? If still keep the 'max_rx_pkt_len' value, that means the larger 'mtu' will be invalid.Quoted 3 lines
Why not simply increase the default '
max_rx_pkt_len' in testpmd?The default '
max_rx_pkt_len' has been initialized to generical value (1518) and default 'mtu' is '1500' in testpmd, But it isn't suitable to those NIC drivers which Ether overhead is larger than 18. (e.g.: ice, i40e) if 'mtu' value is preferable.Quoted 7 lines
And I guess even better what we need is to tell to the application what the frame overhead PMD accepts.
So the application can set proper 'max_rx_pkt_len' value per port for a given/requested MTU value.
@Ian, cc'ed, was complaining almost same thing years ago, these PMD overhead macros and 'max_mtu'/'min_mtu' added because of that, perhaps he has a solution now?Quoted 7 lines
Quoted 4 lines
From my perspective the main problem here:
We have 2 different variables for nearly the same thing:
rte_eth_dev_data.mtu and rte_eth_dev_data.dev_conf.max_rx_pkt_len. and 2 different API to update them:dev_mtu_set()anddev_configure().According API '
max_rx_pkt_len' is 'Only used ifJUMBO_FRAMEenabled' Although not sure that is practically what is done for all drivers.I think most of Intel PMDs use it unconditionally.
Quoted 8 lines
Quoted 8 lines
And inside majority of Intel PMDs we don't keep these 2 variables in sync:
-mtu_set()will update both variables.
-dev_configure()will update onlymax_rx_pkt_len, but will keep mtu intact.This patch fixes this inconsistency, which I think is a good thing. Though yes, it introduces change in behaviour.
Quoted 8 lines
Quoted 5 lines
Let say the code:
rte_eth_dev_set_mtu(port, 1500);
dev_conf.max_rx_pkt_len = 1000;rte_eth_dev_configure(port, 1, 1, &dev_conf);'
rte_eth_dev_configure()' is one of the first APIs called, it is called before 'rte_eth_dev_set_mtu().Usually yes.
But you can still do sometimes later:dev_mtu_set(); ...;dev_stop();dev_configure();dev_start();Quoted 3 lines
When '
rte_eth_dev_configure()' is called, MTU is set to '1500' by default by ethdev layer, so it is not user configuration, but 'max_rx_pkt_len' is.See above.
PMD doesn't know where this MTU value came from (default ethdev value or user specified value) and probably it shouldn't care.Quoted 3 lines
And later, when '
rte_eth_dev_set_mtu()' is called, but MTU and 'max_rx_pkt_len' are updated (mostly).
Quoted 9 lines
Quoted 3 lines
Yes, in
mtu_set()we update both.
But we don't update MTU indev_configure(), onlymax_rx_pkt_len. That what this patch tries to fix (as I understand it).To be more precise - it doesn't change MTU value in
dev_configure(), but instead doesn't allowmax_rx_pkt_lento become smaller then MTU + OVERHEAD.
Probably changing MTU value instead is a better choice.
+1 to change mtu for this case.
And this is what happens in practice when there is no 'rte_eth_dev_set_mtu()' call, since PMD is using ('max_rx_pkt_len' - OVERHEAD) to set MTU.
But this won't solve the problem Steve is trying to solve.
Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
Quoted 8 lines
Before the patch will result:
mtu==1500, max_rx_pkt_len=1000; //out of sync looks wrong to meAfter the patch:
mtu=1500, max_rx_ptk_len=1518; // in sync, change in behaviour.Quoted 7 lines
If you think we need to preserve current behaviour,
then I suppose the easiest thing would be to changedev_config()code to update mtu value based onmax_rx_pkt_len.
I.E:dev_configure{...;mtu_set(max_rx_pkt_len - OVERHEAD); ...} So the code snippet above will result:
mtu=982,max_rx_pkt_len=1000;The '
max_rx_ptk_len' is annoyance for a long time, what do you think to just drop it?
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
By default device will be up with default MTU (1500), later '
rte_eth_dev_set_mtu' can be used to set the MTU, no frame size setting at all.Will this work?
I think it might, but that's a big change, probably too risky at that stage...
Defintely, I was thinking for 21.11. Let me send a deprecation notice and see what happens.
Quoted 66 lines
Quoted 65 lines
Quoted 7 lines
And for short term, for above Intel PMDs, there must be a place this '
max_rx_pkt_len' value taken into account (mostly 'start()'dev_ops), that function can be updated to take 'max_rx_pkt_len' only ifJUMBO_FRAMEset, otherwise use the 'MTU' value.Even if we'll use
max_rx_pkt_lenonly when ifJUMBO_FRAMEis set, I think we still need to keepmax_rx_pkt_lenand MTU values in sync.Quoted 54 lines
Without '
start()' updated the current logic won't work after stop & start anyway.Quoted 50 lines
Quoted 49 lines
Quoted 8 lines
And why this same thing can't happen to other PMDs? If this is a problem for all PMDs, we should solve in other level, not for only some PMDs.
No, all PMDs exist the same issue, another proposal:
-rte_ethdevprovides the unique resize 'max_rx_pkt_len' inrte_eth_dev_configure();
- provide the uniform API for fetching the NIC's supported Ether Overhead size;
Is it feasible?Quoted 36 lines
Quoted 14 lines
Quoted 14 lines
Generally, the mtu value can be adjustable from user (e.g.: ip link set ens801f0 mtu 1400), hence, we just adjust the
max_rx_pkt_lento satisfy mtu requirement.Quoted 2 lines
Should we just call
ice_mtu_set(dev, dev_conf.rxmode.max_rx_pkt_len)here?
ice_mtu_set(dev, mtu)will append ether overhead to frame_size/max_rx_pkt_len, so we need pass the mtu value as the 2nd parameter, or not themax_rx_pkt_len.Quoted 3 lines
Quoted 3 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Quoted 1 line
And please remove above comment, since ether overhead is already
considered in
ice_mtu_set.Ether overhead is already considered in
ice_mtu_set, but it also should be considered as the adjustment condition that ifice_mtu_setneed be invoked.
Quoted 17 lines
Quoted 16 lines
So, it perhaps should remain this comment before this
if()condition.Quoted 13 lines
Quoted 12 lines
Quoted 11 lines
Quoted 10 lines
drivers/net/ice/ice_ethdev.c +3
-1+ret =ice_mtu_set (dev, dev->data->mtu);if (ret !=0 )return +ret; } + ret =ice_init_rss (pf);if (ret) {PMD_DRV_LOG (ERR ,"Failed to enable rss for PF" ); --2.17.1
Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Quoted 163 lines
Quoted 153 lines
Quoted 153 lines
Quoted 111 lines
Quoted 111 lines
Quoted 110 lines
Quoted 69 lines
Quoted 20 lines
Quoted 20 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
testpmd will initialize default max packet length to 1518 which
doesn't include vlan tag size in ether overheader. Once, send the
max mtu length packet with vlan tag, the max packet length will
exceed 1518 that will cause packets dropped directly from NIC hwside.
Quoted 13 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
ice can support dual vlan tags that need more 8 bytes for max
packet size, so, configures the correct max packet size in
dev_configops.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Fixes: 50cc9d2a6e9d ("net/ice: fix max frame size")
Signed-off-by: SteveX Yang <[email protected]>
---
drivers/net/ice/ice_ethdev.c | 11 +++++++++++
1 file changed, 11 insertions(+)Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
diff --git a/drivers/net/ice/ice_ethdev.c
b/drivers/net/ice/ice_ethdev.c index
cfd357b05..6b7098444 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -3146,6 +3146,7 @@ ice_dev_configure(struct rte_eth_dev*dev)
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
struct ice_adapter *ad =
ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct ice_pf *pf =
ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
+uint32_t frame_size = dev->data->mtu + ICE_ETH_OVERHEAD;
int ret;/* Initialize to TRUE. If any of Rx queues doesn't meet the @@
-3157,6
+3158,16 @@ ice_dev_configure(struct rte_eth_dev *dev)
if (dev->data->dev_conf.rxmode.mq_mode &
ETH_MQ_RX_RSS_FLAG)Quoted 26 lines
Quoted 26 lines
Quoted 25 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
dev->data->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_RSS_HASH;Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
+/**
+ * Considering QinQ packet, max frame size should be equal or
+ * larger than total size of MTU and Ether overhead.
+ */Quoted 8 lines
Quoted 5 lines
Quoted 1 line
+if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) {
Why we need this check?
Can we just callice_mtu_setdirectlyI think that without that check we can silently overwrite provided by user dev_conf.rxmode.max_rx_pkt_len value.
OK, I see
But still have one question
dev->data->mtuis initialized to 1518 as default , but ifdev->data->applicationset
dev_conf.rxmode.max_rx_pkt_len = 1000 indev_configure. does that mean we will still will set mtu to 1518, is this expected?Quoted 4 lines
Quoted 2 lines
max_rx_pkt_lenshould be larger than mtu at least, so we should raise themax_rx_pkt_len(e.g.:1518) to hold expected mtu value (e.g.: 1500).Ok, this describe the problem more general and better to replace exist
Quoted 8 lines
code comment and commit log for easy understanding.
Quoted 2 lines
Please send a new version for reword
I didn't really get this set.
Application explicitly sets '
max_rx_pkt_len' to '1518', and a frame bigger than this size is dropped.Sure, it is normal case for dropping oversize data.
Quoted 3 lines
Isn't this what should be, why we are trying to overwrite user configuration in PMD to prevent this?
But it is a confliction that application/user sets mtu &
max_rx_pkt_lenat the same time.
This fix will make a decision when confliction occurred.
MTU value will come from user operation (e.g.: port config mtu 0 1500) directly,
so, themax_rx_pkt_lenwill resize itself to adapt expected MTU value if its size is smaller than MTU + Ether overhead.Quoted 4 lines
During
eth_devallocation, mtu set to default '1500', by ethdev layer. And testpmd sets 'max_rx_pkt_len' by default to '1518'.
I think Qi's concern above is valid, what is user set 'max_rx_pkt_len' to '1000' and mean it? PMD will not honor the user config.I'm not sure when set 'mtu' to '1500' and '
max_rx_pkt_len' to '1000', what's the behavior expected? If still keep the 'max_rx_pkt_len' value, that means the larger 'mtu' will be invalid.Quoted 3 lines
Why not simply increase the default '
max_rx_pkt_len' in testpmd?The default '
max_rx_pkt_len' has been initialized to generical value (1518) and default 'mtu' is '1500' in testpmd, But it isn't suitable to those NIC drivers which Ether overhead is larger than 18. (e.g.: ice, i40e) if 'mtu' value is preferable.Quoted 7 lines
And I guess even better what we need is to tell to the application what the frame overhead PMD accepts.
So the application can set proper 'max_rx_pkt_len' value per port for a given/requested MTU value.
@Ian, cc'ed, was complaining almost same thing years ago, these PMD overhead macros and 'max_mtu'/'min_mtu' added because of that, perhaps he has a solution now?Quoted 7 lines
Quoted 4 lines
From my perspective the main problem here:
We have 2 different variables for nearly the same thing:
rte_eth_dev_data.mtu and rte_eth_dev_data.dev_conf.max_rx_pkt_len. and 2 different API to update them:dev_mtu_set()anddev_configure().According API '
max_rx_pkt_len' is 'Only used ifJUMBO_FRAMEenabled' Although not sure that is practically what is done for all drivers.I think most of Intel PMDs use it unconditionally.
Quoted 8 lines
Quoted 8 lines
And inside majority of Intel PMDs we don't keep these 2 variables in sync:
-mtu_set()will update both variables.
-dev_configure()will update onlymax_rx_pkt_len, but will keep mtu intact.This patch fixes this inconsistency, which I think is a good thing. Though yes, it introduces change in behaviour.
Quoted 8 lines
Quoted 5 lines
Let say the code:
rte_eth_dev_set_mtu(port, 1500);
dev_conf.max_rx_pkt_len = 1000;rte_eth_dev_configure(port, 1, 1, &dev_conf);'
rte_eth_dev_configure()' is one of the first APIs called, it is called before 'rte_eth_dev_set_mtu().Usually yes.
But you can still do sometimes later:dev_mtu_set(); ...;dev_stop();dev_configure();dev_start();Quoted 3 lines
When '
rte_eth_dev_configure()' is called, MTU is set to '1500' by default by ethdev layer, so it is not user configuration, but 'max_rx_pkt_len' is.See above.
PMD doesn't know where this MTU value came from (default ethdev value or user specified value) and probably it shouldn't care.Quoted 3 lines
And later, when '
rte_eth_dev_set_mtu()' is called, but MTU and 'max_rx_pkt_len' are updated (mostly).Quoted 9 lines
Quoted 3 lines
Yes, in
mtu_set()we update both.
But we don't update MTU indev_configure(), onlymax_rx_pkt_len. That what this patch tries to fix (as I understand it).To be more precise - it doesn't change MTU value in
dev_configure(), but instead doesn't allowmax_rx_pkt_lento become smaller then MTU + OVERHEAD.
Probably changing MTU value instead is a better choice.
Quoted 3 lines
+1 to change mtu for this case.
And this is what happens in practice when there is no 'rte_eth_dev_set_mtu()' call, since PMD is using ('max_rx_pkt_len' - OVERHEAD) to set MTU.
Hmm, I don't see that happens within Intel PMDs.
As I can read the code: if user never call mtu_set(), then MTU value is left intact.
Quoted 1 line
But this won't solve the problem Steve is trying to solve.
You mean we still need to update test-pmd code to calculate max_rx_pkt_len properly for default mtu value?
Quoted 96 lines
Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
Quoted 8 lines
Before the patch will result:
mtu==1500, max_rx_pkt_len=1000; //out of sync looks wrong to meAfter the patch:
mtu=1500, max_rx_ptk_len=1518; // in sync, change in behaviour.Quoted 7 lines
If you think we need to preserve current behaviour,
then I suppose the easiest thing would be to changedev_config()code to update mtu value based onmax_rx_pkt_len.
I.E:dev_configure{...;mtu_set(max_rx_pkt_len - OVERHEAD); ...} So the code snippet above will result:
mtu=982,max_rx_pkt_len=1000;The '
max_rx_ptk_len' is annoyance for a long time, what do you think to just drop it?Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
By default device will be up with default MTU (1500), later '
rte_eth_dev_set_mtu' can be used to set the MTU, no frame size setting at all.Will this work?
I think it might, but that's a big change, probably too risky at that stage...
Defintely, I was thinking for 21.11. Let me send a deprecation notice and see what happens.
Quoted 66 lines
Quoted 65 lines
Quoted 7 lines
And for short term, for above Intel PMDs, there must be a place this '
max_rx_pkt_len' value taken into account (mostly 'start()'dev_ops), that function can be updated to take 'max_rx_pkt_len' only ifJUMBO_FRAMEset, otherwise use the 'MTU' value.Even if we'll use
max_rx_pkt_lenonly when ifJUMBO_FRAMEis set, I think we still need to keepmax_rx_pkt_lenand MTU values in sync.Quoted 54 lines
Without '
start()' updated the current logic won't work after stop & start anyway.Quoted 50 lines
Quoted 49 lines
Quoted 8 lines
And why this same thing can't happen to other PMDs? If this is a problem for all PMDs, we should solve in other level, not for only some PMDs.
No, all PMDs exist the same issue, another proposal:
-rte_ethdevprovides the unique resize 'max_rx_pkt_len' inrte_eth_dev_configure();
- provide the uniform API for fetching the NIC's supported Ether Overhead size;
Is it feasible?Quoted 36 lines
Quoted 14 lines
Quoted 14 lines
Generally, the mtu value can be adjustable from user (e.g.: ip link set ens801f0 mtu 1400), hence, we just adjust the
max_rx_pkt_lento satisfy mtu requirement.Quoted 2 lines
Should we just call
ice_mtu_set(dev, dev_conf.rxmode.max_rx_pkt_len)here?
ice_mtu_set(dev, mtu)will append ether overhead to frame_size/max_rx_pkt_len, so we need pass the mtu value as the 2nd parameter, or not themax_rx_pkt_len.Quoted 3 lines
Quoted 3 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Quoted 1 line
And please remove above comment, since ether overhead is already
considered in
ice_mtu_set.Ether overhead is already considered in
ice_mtu_set, but it also should be considered as the adjustment condition that ifice_mtu_setneed be invoked.
Quoted 17 lines
Quoted 16 lines
So, it perhaps should remain this comment before this
if()condition.Quoted 13 lines
Quoted 12 lines
Quoted 11 lines
Quoted 10 lines
+ret = ice_mtu_set(dev, dev->data->mtu); if (ret != 0) return
+ret; }
+
ret = ice_init_rss(pf);
if (ret) {
PMD_DRV_LOG(ERR, "Failed to enable rss for PF");
--
2.17.1
Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Quoted 163 lines · Konstantin
Quoted 163 lines
Quoted 162 lines
Quoted 150 lines
Quoted 111 lines
Quoted 111 lines
Quoted 110 lines
Quoted 69 lines
Quoted 20 lines
Quoted 20 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
testpmd will initialize default max packet length to 1518 which
doesn't include vlan tag size in ether overheader. Once, send the
max mtu length packet with vlan tag, the max packet length will
exceed 1518 that will cause packets dropped directly from NIC hwside.
Quoted 13 lines
Quoted 4 lines
Quoted 4 lines
ice can support dual vlan tags that need more 8 bytes for max
packet size, so, configures the correct max packet size in
dev_configops.
Quoted 8 lines
Quoted 8 lines
Fixes: 50cc9d2a6e9d ("net/ice: fix max frame size")
Signed-off-by: SteveX Yang <[email protected]>
---
drivers/net/ice/ice_ethdev.c | 11 +++++++++++
1 file changed, 11 insertions(+)Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
diff --git a/drivers/net/ice/ice_ethdev.c
b/drivers/net/ice/ice_ethdev.c index
cfd357b05..6b7098444 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -3146,6 +3146,7 @@ ice_dev_configure(struct rte_eth_dev*dev)
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
struct ice_adapter *ad =
ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct ice_pf *pf =
ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
+uint32_t frame_size = dev->data->mtu + ICE_ETH_OVERHEAD;
int ret;/* Initialize to TRUE. If any of Rx queues doesn't meet the @@
-3157,6
+3158,16 @@ ice_dev_configure(struct rte_eth_dev *dev)
if (dev->data->dev_conf.rxmode.mq_mode &
ETH_MQ_RX_RSS_FLAG)Quoted 26 lines
Quoted 26 lines
Quoted 25 lines
Quoted 1 line
Quoted 1 line
dev->data->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_RSS_HASH;Quoted 6 lines
Quoted 6 lines
+/**
+ * Considering QinQ packet, max frame size should be equal or
+ * larger than total size of MTU and Ether overhead.
+ */Quoted 8 lines
Quoted 5 lines
+if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) {
Why we need this check?
Can we just call ice_mtu_set directlyI think that without that check we can silently overwrite provided by user dev_conf.rxmode.max_rx_pkt_len value.
OK, I see
But still have one question
dev->data->mtuis initialized to 1518 as default , but ifdev->data->applicationset
dev_conf.rxmode.max_rx_pkt_len = 1000 indev_configure. does that mean we will still will set mtu to 1518, is this expected?Quoted 4 lines
Quoted 2 lines
max_rx_pkt_lenshould be larger than mtu at least, so we should raise themax_rx_pkt_len(e.g.:1518) to hold expected mtu value (e.g.: 1500).Ok, this describe the problem more general and better to replace exist
Quoted 8 lines
code comment and commit log for easy understanding.
Quoted 2 lines
Please send a new version for reword
I didn't really get this set.
Application explicitly sets '
max_rx_pkt_len' to '1518', and a frame bigger than this size is dropped.Sure, it is normal case for dropping oversize data.
Quoted 3 lines
Isn't this what should be, why we are trying to overwrite user configuration in PMD to prevent this?
But it is a confliction that application/user sets mtu &
max_rx_pkt_lenat the same time.
This fix will make a decision when confliction occurred.
MTU value will come from user operation (e.g.: port config mtu 0 1500) directly,
so, themax_rx_pkt_lenwill resize itself to adapt expected MTU value if its size is smaller than MTU + Ether overhead.Quoted 4 lines
During
eth_devallocation, mtu set to default '1500', by ethdev layer. And testpmd sets 'max_rx_pkt_len' by default to '1518'.
I think Qi's concern above is valid, what is user set 'max_rx_pkt_len' to '1000' and mean it? PMD will not honor the user config.I'm not sure when set 'mtu' to '1500' and '
max_rx_pkt_len' to '1000', what's the behavior expected? If still keep the 'max_rx_pkt_len' value, that means the larger 'mtu' will be invalid.Quoted 3 lines
Why not simply increase the default '
max_rx_pkt_len' in testpmd?The default '
max_rx_pkt_len' has been initialized to generical value (1518) and default 'mtu' is '1500' in testpmd, But it isn't suitable to those NIC drivers which Ether overhead is larger than 18. (e.g.: ice, i40e) if 'mtu' value is preferable.Quoted 7 lines
And I guess even better what we need is to tell to the application what the frame overhead PMD accepts.
So the application can set proper 'max_rx_pkt_len' value per port for a given/requested MTU value.
@Ian, cc'ed, was complaining almost same thing years ago, these PMD overhead macros and 'max_mtu'/'min_mtu' added because of that, perhaps he has a solution now?Quoted 7 lines
Quoted 4 lines
From my perspective the main problem here:
We have 2 different variables for nearly the same thing:
rte_eth_dev_data.mtu and rte_eth_dev_data.dev_conf.max_rx_pkt_len. and 2 different API to update them:dev_mtu_set()anddev_configure().According API '
max_rx_pkt_len' is 'Only used ifJUMBO_FRAMEenabled' Although not sure that is practically what is done for all drivers.I think most of Intel PMDs use it unconditionally.
Quoted 8 lines
Quoted 8 lines
And inside majority of Intel PMDs we don't keep these 2 variables in sync:
-mtu_set()will update both variables.
-dev_configure()will update onlymax_rx_pkt_len, but will keep mtu intact.This patch fixes this inconsistency, which I think is a good thing. Though yes, it introduces change in behaviour.
Quoted 8 lines
Quoted 5 lines
Let say the code:
rte_eth_dev_set_mtu(port, 1500);
dev_conf.max_rx_pkt_len = 1000;rte_eth_dev_configure(port, 1, 1, &dev_conf);'
rte_eth_dev_configure()' is one of the first APIs called, it is called before 'rte_eth_dev_set_mtu().Usually yes.
But you can still do sometimes later:dev_mtu_set(); ...;dev_stop();dev_configure();dev_start();Quoted 3 lines
When '
rte_eth_dev_configure()' is called, MTU is set to '1500' by default by ethdev layer, so it is not user configuration, but 'max_rx_pkt_len' is.See above.
PMD doesn't know where this MTU value came from (default ethdev value or user specified value) and probably it shouldn't care.Quoted 1 line
Quoted 6 lines
Quoted 2 lines
And later, when '
rte_eth_dev_set_mtu()' is called, but MTU and 'max_rx_pkt_len' are updated (mostly).Yes, in
mtu_set()we update both.
But we don't update MTU indev_configure(), onlymax_rx_pkt_len. That what this patch tries to fix (as I understand it).To be more precise - it doesn't change MTU value in
dev_configure(), but instead doesn't allowmax_rx_pkt_lento become smaller then MTU + OVERHEAD.
Probably changing MTU value instead is a better choice.
Quoted 7 lines
Quoted 3 lines
+1 to change mtu for this case.
And this is what happens in practice when there is no 'rte_eth_dev_set_mtu()' call, since PMD is using ('max_rx_pkt_len' - OVERHEAD) to set MTU.Hmm, I don't see that happens within Intel PMDs.
As I can read the code: if user never callmtu_set(), then MTU value is left intact.
I was checking ice,
in 'ice_dev_start()', 'rxmode.max_rx_pkt_len' is used to configure the device.
Quoted 5 lines
Quoted 1 line
But this won't solve the problem Steve is trying to solve.
You mean we still need to update test-pmd code to calculate
max_rx_pkt_lenproperly for default mtu value?
Yes.
Because target of this set is able to receive packets with payload size 'RTE_ETHER_MTU', if MTU is updated according to the provided 'max_rx_pkt_len', device still won't able to receive those packets.
Quoted 97 lines
Quoted 96 lines
Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
Quoted 8 lines
Before the patch will result:
mtu==1500, max_rx_pkt_len=1000; //out of sync looks wrong to meAfter the patch:
mtu=1500, max_rx_ptk_len=1518; // in sync, change in behaviour.Quoted 7 lines
If you think we need to preserve current behaviour,
then I suppose the easiest thing would be to changedev_config()code to update mtu value based onmax_rx_pkt_len.
I.E:dev_configure{...;mtu_set(max_rx_pkt_len - OVERHEAD); ...} So the code snippet above will result:
mtu=982,max_rx_pkt_len=1000;The '
max_rx_ptk_len' is annoyance for a long time, what do you think to just drop it?Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
By default device will be up with default MTU (1500), later '
rte_eth_dev_set_mtu' can be used to set the MTU, no frame size setting at all.Will this work?
I think it might, but that's a big change, probably too risky at that stage...
Defintely, I was thinking for 21.11. Let me send a deprecation notice and see what happens.
Quoted 66 lines
Quoted 65 lines
Quoted 7 lines
And for short term, for above Intel PMDs, there must be a place this '
max_rx_pkt_len' value taken into account (mostly 'start()'dev_ops), that function can be updated to take 'max_rx_pkt_len' only ifJUMBO_FRAMEset, otherwise use the 'MTU' value.Even if we'll use
max_rx_pkt_lenonly when ifJUMBO_FRAMEis set, I think we still need to keepmax_rx_pkt_lenand MTU values in sync.Quoted 54 lines
Without '
start()' updated the current logic won't work after stop & start anyway.Quoted 50 lines
Quoted 49 lines
Quoted 8 lines
And why this same thing can't happen to other PMDs? If this is a problem for all PMDs, we should solve in other level, not for only some PMDs.
No, all PMDs exist the same issue, another proposal:
-rte_ethdevprovides the unique resize 'max_rx_pkt_len' inrte_eth_dev_configure();
- provide the uniform API for fetching the NIC's supported Ether Overhead size;
Is it feasible?Quoted 36 lines
Quoted 14 lines
Quoted 14 lines
Generally, the mtu value can be adjustable from user (e.g.: ip link set ens801f0 mtu 1400), hence, we just adjust the
max_rx_pkt_lento satisfy mtu requirement.Quoted 2 lines
Should we just call
ice_mtu_set(dev, dev_conf.rxmode.max_rx_pkt_len)here?
ice_mtu_set(dev, mtu)will append ether overhead to frame_size/max_rx_pkt_len, so we need pass the mtu value as the 2nd parameter, or not themax_rx_pkt_len.Quoted 3 lines
Quoted 3 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Quoted 1 line
And please remove above comment, since ether overhead is already
considered in
ice_mtu_set.Ether overhead is already considered in
ice_mtu_set, but it also should be considered as the adjustment condition that ifice_mtu_setneed be invoked.
Quoted 17 lines
Quoted 16 lines
So, it perhaps should remain this comment before this
if()condition.Quoted 13 lines
Quoted 12 lines
Quoted 11 lines
+ret = ice_mtu_set(dev, dev->data->mtu); if (ret != 0) return
+ret; }
+
ret = ice_init_rss(pf);
if (ret) {
PMD_DRV_LOG(ERR, "Failed to enable rss for PF");
--
2.17.1
Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Quoted 171 lines · Konstantin
Quoted 167 lines
Quoted 166 lines
Quoted 153 lines
Quoted 153 lines
Quoted 111 lines
Quoted 111 lines
Quoted 110 lines
Quoted 69 lines
Quoted 20 lines
Quoted 20 lines
Quoted 6 lines
Quoted 6 lines
testpmd will initialize default max packet length to 1518 which
doesn't include vlan tag size in ether overheader. Once, send the
max mtu length packet with vlan tag, the max packet length will
exceed 1518 that will cause packets dropped directly from NIC hwside.
Quoted 13 lines
Quoted 4 lines
ice can support dual vlan tags that need more 8 bytes for max
packet size, so, configures the correct max packet size in
dev_configops.
Quoted 8 lines
Fixes: 50cc9d2a6e9d ("net/ice: fix max frame size")
Signed-off-by: SteveX Yang <[email protected]>
---
drivers/net/ice/ice_ethdev.c | 11 +++++++++++
1 file changed, 11 insertions(+)Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
diff --git a/drivers/net/ice/ice_ethdev.c
b/drivers/net/ice/ice_ethdev.c index
cfd357b05..6b7098444 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -3146,6 +3146,7 @@ ice_dev_configure(struct rte_eth_dev*dev)
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
struct ice_adapter *ad =
ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct ice_pf *pf =
ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
+uint32_t frame_size = dev->data->mtu + ICE_ETH_OVERHEAD;
int ret;/* Initialize to TRUE. If any of Rx queues doesn't meet the @@
-3157,6
+3158,16 @@ ice_dev_configure(struct rte_eth_dev *dev)
if (dev->data->dev_conf.rxmode.mq_mode &
ETH_MQ_RX_RSS_FLAG)Quoted 26 lines
Quoted 26 lines
Quoted 25 lines
Quoted 1 line
dev->data->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_RSS_HASH;Quoted 14 lines
+/**
+ * Considering QinQ packet, max frame size should be equal or
+ * larger than total size of MTU and Ether overhead.
+ */+if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) {
Why we need this check?
Can we just call ice_mtu_set directlyI think that without that check we can silently overwrite provided
by user dev_conf.rxmode.max_rx_pkt_len value.OK, I see
But still have one question
dev->data->mtuis initialized to 1518 as default , but ifdev->data->applicationset
dev_conf.rxmode.max_rx_pkt_len = 1000 indev_configure. does that mean we will still will set mtu to 1518, is this expected?Quoted 4 lines
Quoted 2 lines
max_rx_pkt_lenshould be larger than mtu at least, so we should raise themax_rx_pkt_len(e.g.:1518) to hold expected mtu value (e.g.: 1500).Ok, this describe the problem more general and better to replace exist
Quoted 8 lines
code comment and commit log for easy understanding.
Quoted 2 lines
Please send a new version for reword
I didn't really get this set.
Application explicitly sets '
max_rx_pkt_len' to '1518', and a frame bigger than this size is dropped.Sure, it is normal case for dropping oversize data.
Quoted 3 lines
Isn't this what should be, why we are trying to overwrite user configuration in PMD to prevent this?
But it is a confliction that application/user sets mtu &
max_rx_pkt_lenat the same time.
This fix will make a decision when confliction occurred.
MTU value will come from user operation (e.g.: port config mtu 0 1500) directly,
so, themax_rx_pkt_lenwill resize itself to adapt expected MTU value if its size is smaller than MTU + Ether overhead.Quoted 4 lines
During
eth_devallocation, mtu set to default '1500', by ethdev layer. And testpmd sets 'max_rx_pkt_len' by default to '1518'.
I think Qi's concern above is valid, what is user set 'max_rx_pkt_len' to '1000' and mean it? PMD will not honor the user config.I'm not sure when set 'mtu' to '1500' and '
max_rx_pkt_len' to '1000', what's the behavior expected? If still keep the 'max_rx_pkt_len' value, that means the larger 'mtu' will be invalid.Quoted 3 lines
Why not simply increase the default '
max_rx_pkt_len' in testpmd?The default '
max_rx_pkt_len' has been initialized to generical value (1518) and default 'mtu' is '1500' in testpmd, But it isn't suitable to those NIC drivers which Ether overhead is larger than 18. (e.g.: ice, i40e) if 'mtu' value is preferable.Quoted 7 lines
And I guess even better what we need is to tell to the application what the frame overhead PMD accepts.
So the application can set proper 'max_rx_pkt_len' value per port for a given/requested MTU value.
@Ian, cc'ed, was complaining almost same thing years ago, these PMD overhead macros and 'max_mtu'/'min_mtu' added because of that, perhaps he has a solution now?Quoted 7 lines
Quoted 4 lines
From my perspective the main problem here:
We have 2 different variables for nearly the same thing:
rte_eth_dev_data.mtu and rte_eth_dev_data.dev_conf.max_rx_pkt_len. and 2 different API to update them:dev_mtu_set()anddev_configure().According API '
max_rx_pkt_len' is 'Only used ifJUMBO_FRAMEenabled' Although not sure that is practically what is done for all drivers.I think most of Intel PMDs use it unconditionally.
Quoted 8 lines
Quoted 8 lines
And inside majority of Intel PMDs we don't keep these 2 variables in sync:
-mtu_set()will update both variables.
-dev_configure()will update onlymax_rx_pkt_len, but will keep mtu intact.This patch fixes this inconsistency, which I think is a good thing. Though yes, it introduces change in behaviour.
Quoted 8 lines
Quoted 5 lines
Let say the code:
rte_eth_dev_set_mtu(port, 1500);
dev_conf.max_rx_pkt_len = 1000;rte_eth_dev_configure(port, 1, 1, &dev_conf);'
rte_eth_dev_configure()' is one of the first APIs called, it is called before 'rte_eth_dev_set_mtu().Usually yes.
But you can still do sometimes later:dev_mtu_set(); ...;dev_stop();dev_configure();dev_start();Quoted 3 lines
When '
rte_eth_dev_configure()' is called, MTU is set to '1500' by default by ethdev layer, so it is not user configuration, but 'max_rx_pkt_len' is.See above.
PMD doesn't know where this MTU value came from (default ethdev value or user specified value) and probably it shouldn't care.Quoted 3 lines
And later, when '
rte_eth_dev_set_mtu()' is called, but MTU and 'max_rx_pkt_len' are updated (mostly).Quoted 9 lines
Quoted 3 lines
Yes, in
mtu_set()we update both.
But we don't update MTU indev_configure(), onlymax_rx_pkt_len. That what this patch tries to fix (as I understand it).To be more precise - it doesn't change MTU value in
dev_configure(), but instead doesn't allowmax_rx_pkt_lento become smaller then MTU + OVERHEAD.
Probably changing MTU value instead is a better choice.+1 to change mtu for this case.
And this is what happens in practice when there is no 'rte_eth_dev_set_mtu()' call, since PMD is using ('max_rx_pkt_len' - OVERHEAD) to set MTU.
Quoted 6 lines
Quoted 3 lines
Hmm, I don't see that happens within Intel PMDs.
As I can read the code: if user never callmtu_set(), then MTU value is left intact.I was checking ice,
in 'ice_dev_start()', 'rxmode.max_rx_pkt_len' is used to configure the device.
Yes, I am not arguing with that.
What I am saying - dev_config() doesn't update MTU based on max_rx_pkt_len. While it probably should.
Quoted 11 lines
Quoted 6 lines
Quoted 2 lines
But this won't solve the problem Steve is trying to solve.
You mean we still need to update test-pmd code to calculate
max_rx_pkt_lenproperly for default mtu value?Yes.
Because target of this set is able to receive packets with payload size 'RTE_ETHER_MTU', if MTU is updated according to the provided 'max_rx_pkt_len', device still won't able to receive those packets.
Agree.
Quoted 98 lines
Quoted 98 lines
Quoted 97 lines
Quoted 20 lines
Quoted 20 lines
Quoted 20 lines
Quoted 9 lines
Before the patch will result:
mtu==1500, max_rx_pkt_len=1000; //out of sync looks wrong to meAfter the patch:
mtu=1500, max_rx_ptk_len=1518; // in sync, change in behaviour.Quoted 7 lines
If you think we need to preserve current behaviour,
then I suppose the easiest thing would be to changedev_config()code to update mtu value based onmax_rx_pkt_len.
I.E:dev_configure{...;mtu_set(max_rx_pkt_len - OVERHEAD); ...} So the code snippet above will result:
mtu=982,max_rx_pkt_len=1000;The '
max_rx_ptk_len' is annoyance for a long time, what do you think to just drop it?Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
By default device will be up with default MTU (1500), later '
rte_eth_dev_set_mtu' can be used to set the MTU, no frame size setting at all.Will this work?
I think it might, but that's a big change, probably too risky at that stage...
Defintely, I was thinking for 21.11. Let me send a deprecation notice and see what happens.
Quoted 66 lines
Quoted 65 lines
Quoted 7 lines
And for short term, for above Intel PMDs, there must be a place this '
max_rx_pkt_len' value taken into account (mostly 'start()'dev_ops), that function can be updated to take 'max_rx_pkt_len' only ifJUMBO_FRAMEset, otherwise use the 'MTU' value.Even if we'll use
max_rx_pkt_lenonly when ifJUMBO_FRAMEis set, I think we still need to keepmax_rx_pkt_lenand MTU values in sync.Quoted 54 lines
Without '
start()' updated the current logic won't work after stop & start anyway.Quoted 50 lines
Quoted 49 lines
Quoted 8 lines
And why this same thing can't happen to other PMDs? If this is a problem for all PMDs, we should solve in other level, not for only some PMDs.
No, all PMDs exist the same issue, another proposal:
-rte_ethdevprovides the unique resize 'max_rx_pkt_len' inrte_eth_dev_configure();
- provide the uniform API for fetching the NIC's supported Ether Overhead size;
Is it feasible?Quoted 36 lines
Quoted 14 lines
Quoted 14 lines
Generally, the mtu value can be adjustable from user (e.g.: ip link set ens801f0 mtu 1400), hence, we just adjust the
max_rx_pkt_lento satisfy mtu requirement.Quoted 2 lines
Should we just call
ice_mtu_set(dev, dev_conf.rxmode.max_rx_pkt_len)here?
ice_mtu_set(dev, mtu)will append ether overhead to frame_size/max_rx_pkt_len, so we need pass the mtu value as the 2nd parameter, or not themax_rx_pkt_len.Quoted 3 lines
Quoted 3 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
And please remove above comment, since ether overhead is already
considered in ice_mtu_set.Ether overhead is already considered in
ice_mtu_set, but it also should be considered as the adjustment condition that ifice_mtu_setneed be invoked.
Quoted 17 lines
Quoted 16 lines
So, it perhaps should remain this comment before this
if()condition.Quoted 13 lines
Quoted 12 lines
+ret = ice_mtu_set(dev, dev->data->mtu); if (ret != 0) return
+ret; }
+
ret = ice_init_rss(pf);
if (ret) {
PMD_DRV_LOG(ERR, "Failed to enable rss for PF");
--
2.17.1
Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Quoted 175 lines · Konstantin
Quoted 175 lines · Konstantin
Quoted 170 lines
Quoted 163 lines
Quoted 153 lines
Quoted 153 lines
Quoted 111 lines
Quoted 111 lines
Quoted 110 lines
Quoted 69 lines
Quoted 20 lines
Quoted 20 lines
Quoted 6 lines
testpmd will initialize default max packet length to 1518 which
doesn't include vlan tag size in ether overheader. Once, send the
max mtu length packet with vlan tag, the max packet length will
exceed 1518 that will cause packets dropped directly from NIC hwside.
Quoted 13 lines
ice can support dual vlan tags that need more 8 bytes for max
packet size, so, configures the correct max packet size in
dev_config
ops.Fixes: 50cc9d2a6e9d ("net/ice: fix max frame size")
Signed-off-by: SteveX Yang <[email protected]>
---
drivers/net/ice/ice_ethdev.c | 11 +++++++++++
1 file changed, 11 insertions(+)Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
diff --git a/drivers/net/ice/ice_ethdev.c
b/drivers/net/ice/ice_ethdev.c index
cfd357b05..6b7098444 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -3146,6 +3146,7 @@ ice_dev_configure(struct rte_eth_dev*dev)
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
struct ice_adapter *ad =
ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct ice_pf *pf =
ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
+uint32_t frame_size = dev->data->mtu + ICE_ETH_OVERHEAD;
int ret;/* Initialize to TRUE. If any of Rx queues doesn't meet the @@
-3157,6
+3158,16 @@ ice_dev_configure(struct rte_eth_dev *dev)
if (dev->data->dev_conf.rxmode.mq_mode &
ETH_MQ_RX_RSS_FLAG)Quoted 26 lines
Quoted 26 lines
Quoted 25 lines
dev->data->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_RSS_HASH;+/**
+ * Considering QinQ packet, max frame size should be equal or
+ * larger than total size of MTU and Ether overhead.
+ */+if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) {
Why we need this check?
Can we just call ice_mtu_set directlyI think that without that check we can silently overwrite provided
by user dev_conf.rxmode.max_rx_pkt_len value.OK, I see
But still have one question
dev->data->mtu is initialized to 1518 as default , but if
dev->data->application set
dev_conf.rxmode.max_rx_pkt_len = 1000 in dev_configure.
does that mean we will still will set mtu to 1518, is this expected?Quoted 4 lines
Quoted 2 lines
max_rx_pkt_lenshould be larger than mtu at least, so we should raise themax_rx_pkt_len(e.g.:1518) to hold expected mtu value (e.g.: 1500).Ok, this describe the problem more general and better to replace exist
Quoted 8 lines
code comment and commit log for easy understanding.
Quoted 2 lines
Please send a new version for reword
I didn't really get this set.
Application explicitly sets '
max_rx_pkt_len' to '1518', and a frame bigger than this size is dropped.Sure, it is normal case for dropping oversize data.
Quoted 3 lines
Isn't this what should be, why we are trying to overwrite user configuration in PMD to prevent this?
But it is a confliction that application/user sets mtu &
max_rx_pkt_lenat the same time.
This fix will make a decision when confliction occurred.
MTU value will come from user operation (e.g.: port config mtu 0 1500) directly,
so, themax_rx_pkt_lenwill resize itself to adapt expected MTU value if its size is smaller than MTU + Ether overhead.Quoted 4 lines
During
eth_devallocation, mtu set to default '1500', by ethdev layer. And testpmd sets 'max_rx_pkt_len' by default to '1518'.
I think Qi's concern above is valid, what is user set 'max_rx_pkt_len' to '1000' and mean it? PMD will not honor the user config.I'm not sure when set 'mtu' to '1500' and '
max_rx_pkt_len' to '1000', what's the behavior expected? If still keep the 'max_rx_pkt_len' value, that means the larger 'mtu' will be invalid.Quoted 3 lines
Why not simply increase the default '
max_rx_pkt_len' in testpmd?The default '
max_rx_pkt_len' has been initialized to generical value (1518) and default 'mtu' is '1500' in testpmd, But it isn't suitable to those NIC drivers which Ether overhead is larger than 18. (e.g.: ice, i40e) if 'mtu' value is preferable.Quoted 7 lines
And I guess even better what we need is to tell to the application what the frame overhead PMD accepts.
So the application can set proper 'max_rx_pkt_len' value per port for a given/requested MTU value.
@Ian, cc'ed, was complaining almost same thing years ago, these PMD overhead macros and 'max_mtu'/'min_mtu' added because of that, perhaps he has a solution now?Quoted 7 lines
Quoted 4 lines
From my perspective the main problem here:
We have 2 different variables for nearly the same thing:
rte_eth_dev_data.mtu and rte_eth_dev_data.dev_conf.max_rx_pkt_len. and 2 different API to update them:dev_mtu_set()anddev_configure().According API '
max_rx_pkt_len' is 'Only used ifJUMBO_FRAMEenabled' Although not sure that is practically what is done for all drivers.I think most of Intel PMDs use it unconditionally.
Quoted 8 lines
Quoted 8 lines
And inside majority of Intel PMDs we don't keep these 2 variables in sync:
-mtu_set()will update both variables.
-dev_configure()will update onlymax_rx_pkt_len, but will keep mtu intact.This patch fixes this inconsistency, which I think is a good thing. Though yes, it introduces change in behaviour.
Quoted 8 lines
Quoted 5 lines
Let say the code:
rte_eth_dev_set_mtu(port, 1500);
dev_conf.max_rx_pkt_len = 1000;rte_eth_dev_configure(port, 1, 1, &dev_conf);'
rte_eth_dev_configure()' is one of the first APIs called, it is called before 'rte_eth_dev_set_mtu().Usually yes.
But you can still do sometimes later:dev_mtu_set(); ...;dev_stop();dev_configure();dev_start();Quoted 3 lines
When '
rte_eth_dev_configure()' is called, MTU is set to '1500' by default by ethdev layer, so it is not user configuration, but 'max_rx_pkt_len' is.See above.
PMD doesn't know where this MTU value came from (default ethdev value or user specified value) and probably it shouldn't care.Quoted 3 lines
And later, when '
rte_eth_dev_set_mtu()' is called, but MTU and 'max_rx_pkt_len' are updated (mostly).Quoted 9 lines
Quoted 3 lines
Yes, in
mtu_set()we update both.
But we don't update MTU indev_configure(), onlymax_rx_pkt_len. That what this patch tries to fix (as I understand it).To be more precise - it doesn't change MTU value in
dev_configure(), but instead doesn't allowmax_rx_pkt_lento become smaller then MTU + OVERHEAD.
Probably changing MTU value instead is a better choice.Quoted 3 lines
+1 to change mtu for this case.
And this is what happens in practice when there is no 'rte_eth_dev_set_mtu()' call, since PMD is using ('max_rx_pkt_len' - OVERHEAD) to set MTU.Hmm, I don't see that happens within Intel PMDs.
As I can read the code: if user never callmtu_set(), then MTU value is left intact.
Quoted 7 lines
Quoted 2 lines
I was checking ice,
in 'ice_dev_start()', 'rxmode.max_rx_pkt_len' is used to configure the device.Yes, I am not arguing with that.
What I am saying -dev_config()doesn't update MTU based onmax_rx_pkt_len. While it probably should.
Yes 'dev_configure()' doesn't update the 'dev->data->mtu' and 'max_rx_pkt_len' & 'dev->data->mtu' may diverge there.
I think best place to update 'dev->data->mtu' is where the device is actually updated, but to prevent the diversion above we can update 'dev->data->mtu' in ethdev layer, in 'rte_eth_dev_configure()' based on 'max_rx_pkt_len', will it work?
Only concern I see is if user reads the MTU ('rte_eth_dev_get_mtu()') after 'rte_eth_dev_configure()' but before device configured, user will get the wrong value, I guess that problem was already there but changing default value may make it more visible.
Quoted 113 lines
Quoted 11 lines
Quoted 6 lines
Quoted 2 lines
But this won't solve the problem Steve is trying to solve.
You mean we still need to update test-pmd code to calculate
max_rx_pkt_lenproperly for default mtu value?Yes.
Because target of this set is able to receive packets with payload size 'RTE_ETHER_MTU', if MTU is updated according to the provided 'max_rx_pkt_len', device still won't able to receive those packets.Agree.
Quoted 98 lines
Quoted 98 lines
Quoted 97 lines
Quoted 20 lines
Quoted 20 lines
Quoted 20 lines
Quoted 9 lines
Before the patch will result:
mtu==1500, max_rx_pkt_len=1000; //out of sync looks wrong to meAfter the patch:
mtu=1500, max_rx_ptk_len=1518; // in sync, change in behaviour.Quoted 7 lines
If you think we need to preserve current behaviour,
then I suppose the easiest thing would be to changedev_config()code to update mtu value based onmax_rx_pkt_len.
I.E:dev_configure{...;mtu_set(max_rx_pkt_len - OVERHEAD); ...} So the code snippet above will result:
mtu=982,max_rx_pkt_len=1000;The '
max_rx_ptk_len' is annoyance for a long time, what do you think to just drop it?Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
By default device will be up with default MTU (1500), later '
rte_eth_dev_set_mtu' can be used to set the MTU, no frame size setting at all.Will this work?
I think it might, but that's a big change, probably too risky at that stage...
Defintely, I was thinking for 21.11. Let me send a deprecation notice and see what happens.
Quoted 66 lines
Quoted 65 lines
Quoted 7 lines
And for short term, for above Intel PMDs, there must be a place this '
max_rx_pkt_len' value taken into account (mostly 'start()'dev_ops), that function can be updated to take 'max_rx_pkt_len' only ifJUMBO_FRAMEset, otherwise use the 'MTU' value.Even if we'll use
max_rx_pkt_lenonly when ifJUMBO_FRAMEis set, I think we still need to keepmax_rx_pkt_lenand MTU values in sync.Quoted 54 lines
Without '
start()' updated the current logic won't work after stop & start anyway.Quoted 50 lines
Quoted 49 lines
Quoted 8 lines
And why this same thing can't happen to other PMDs? If this is a problem for all PMDs, we should solve in other level, not for only some PMDs.
No, all PMDs exist the same issue, another proposal:
-rte_ethdevprovides the unique resize 'max_rx_pkt_len' inrte_eth_dev_configure();
- provide the uniform API for fetching the NIC's supported Ether Overhead size;
Is it feasible?Quoted 36 lines
Quoted 14 lines
Quoted 14 lines
Generally, the mtu value can be adjustable from user (e.g.: ip link set ens801f0 mtu 1400), hence, we just adjust the
max_rx_pkt_lento satisfy mtu requirement.Quoted 2 lines
Should we just call ice_mtu_set(dev, dev_conf.rxmode.max_rx_pkt_len)
here?
ice_mtu_set(dev, mtu)will append ether overhead to frame_size/max_rx_pkt_len, so we need pass the mtu value as the 2nd parameter, or not themax_rx_pkt_len.Quoted 3 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
And please remove above comment, since ether overhead is already
considered in ice_mtu_set.Ether overhead is already considered in
ice_mtu_set, but it also should be considered as the adjustment condition that ifice_mtu_setneed be invoked.
Quoted 17 lines
Quoted 16 lines
So, it perhaps should remain this comment before this
if()condition.Quoted 13 lines
+ret = ice_mtu_set(dev, dev->data->mtu); if (ret != 0) return
+ret; }
+
ret = ice_init_rss(pf);
if (ret) {
PMD_DRV_LOG(ERR, "Failed to enable rss for PF");
--
2.17.1
Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Quoted 180 lines
Quoted 172 lines
Quoted 172 lines · Konstantin
Quoted 170 lines
Quoted 163 lines
Quoted 153 lines
Quoted 153 lines
Quoted 111 lines
Quoted 111 lines
Quoted 110 lines
Quoted 69 lines
Quoted 20 lines
Quoted 20 lines
testpmd will initialize default max packet length to 1518 which
doesn't include vlan tag size in ether overheader. Once, send the
max mtu length packet with vlan tag, the max packet length will
exceed 1518 that will cause packets dropped directly from NIC hw
side.ice can support dual vlan tags that need more 8 bytes for max
packet size, so, configures the correct max packet size in
dev_config
ops.Fixes: 50cc9d2a6e9d ("net/ice: fix max frame size")
Signed-off-by: SteveX Yang <[email protected]>
---
drivers/net/ice/ice_ethdev.c | 11 +++++++++++
1 file changed, 11 insertions(+)Quoted 6 lines
Quoted 6 lines
diff --git a/drivers/net/ice/ice_ethdev.c
b/drivers/net/ice/ice_ethdev.c index
cfd357b05..6b7098444 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -3146,6 +3146,7 @@ ice_dev_configure(struct rte_eth_dev*dev)
Quoted 11 lines
Quoted 11 lines
struct ice_adapter *ad =
ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct ice_pf *pf =
ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
+uint32_t frame_size = dev->data->mtu + ICE_ETH_OVERHEAD;
int ret;/* Initialize to TRUE. If any of Rx queues doesn't meet the @@
-3157,6
+3158,16 @@ ice_dev_configure(struct rte_eth_dev *dev)
if (dev->data->dev_conf.rxmode.mq_mode &
ETH_MQ_RX_RSS_FLAG)Quoted 26 lines
Quoted 26 lines
dev->data->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_RSS_HASH;+/**
+ * Considering QinQ packet, max frame size should be equal or
+ * larger than total size of MTU and Ether overhead.
+ */+if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) {
Why we need this check?
Can we just call ice_mtu_set directlyI think that without that check we can silently overwrite provided
by user dev_conf.rxmode.max_rx_pkt_len value.OK, I see
But still have one question
dev->data->mtu is initialized to 1518 as default , but if
dev->data->application set
dev_conf.rxmode.max_rx_pkt_len = 1000 in dev_configure.
does that mean we will still will set mtu to 1518, is this expected?Quoted 4 lines
Quoted 2 lines
max_rx_pkt_len should be larger than mtu at least, so we should raise
the max_rx_pkt_len (e.g.:1518) to hold expected mtu value (e.g.: 1500).Ok, this describe the problem more general and better to replace exist
Quoted 8 lines
code comment and commit log for easy understanding.
Quoted 2 lines
Please send a new version for reword
I didn't really get this set.
Application explicitly sets '
max_rx_pkt_len' to '1518', and a frame bigger than this size is dropped.Sure, it is normal case for dropping oversize data.
Quoted 3 lines
Isn't this what should be, why we are trying to overwrite user configuration in PMD to prevent this?
But it is a confliction that application/user sets mtu &
max_rx_pkt_lenat the same time.
This fix will make a decision when confliction occurred.
MTU value will come from user operation (e.g.: port config mtu 0 1500) directly,
so, themax_rx_pkt_lenwill resize itself to adapt expected MTU value if its size is smaller than MTU + Ether overhead.Quoted 4 lines
During
eth_devallocation, mtu set to default '1500', by ethdev layer. And testpmd sets 'max_rx_pkt_len' by default to '1518'.
I think Qi's concern above is valid, what is user set 'max_rx_pkt_len' to '1000' and mean it? PMD will not honor the user config.I'm not sure when set 'mtu' to '1500' and '
max_rx_pkt_len' to '1000', what's the behavior expected? If still keep the 'max_rx_pkt_len' value, that means the larger 'mtu' will be invalid.Quoted 3 lines
Why not simply increase the default '
max_rx_pkt_len' in testpmd?The default '
max_rx_pkt_len' has been initialized to generical value (1518) and default 'mtu' is '1500' in testpmd, But it isn't suitable to those NIC drivers which Ether overhead is larger than 18. (e.g.: ice, i40e) if 'mtu' value is preferable.Quoted 7 lines
And I guess even better what we need is to tell to the application what the frame overhead PMD accepts.
So the application can set proper 'max_rx_pkt_len' value per port for a given/requested MTU value.
@Ian, cc'ed, was complaining almost same thing years ago, these PMD overhead macros and 'max_mtu'/'min_mtu' added because of that, perhaps he has a solution now?Quoted 7 lines
Quoted 4 lines
From my perspective the main problem here:
We have 2 different variables for nearly the same thing:
rte_eth_dev_data.mtu and rte_eth_dev_data.dev_conf.max_rx_pkt_len. and 2 different API to update them:dev_mtu_set()anddev_configure().According API '
max_rx_pkt_len' is 'Only used ifJUMBO_FRAMEenabled' Although not sure that is practically what is done for all drivers.I think most of Intel PMDs use it unconditionally.
Quoted 8 lines
Quoted 8 lines
And inside majority of Intel PMDs we don't keep these 2 variables in sync:
-mtu_set()will update both variables.
-dev_configure()will update onlymax_rx_pkt_len, but will keep mtu intact.This patch fixes this inconsistency, which I think is a good thing. Though yes, it introduces change in behaviour.
Quoted 8 lines
Quoted 5 lines
Let say the code:
rte_eth_dev_set_mtu(port, 1500);
dev_conf.max_rx_pkt_len = 1000;rte_eth_dev_configure(port, 1, 1, &dev_conf);'
rte_eth_dev_configure()' is one of the first APIs called, it is called before 'rte_eth_dev_set_mtu().Usually yes.
But you can still do sometimes later:dev_mtu_set(); ...;dev_stop();dev_configure();dev_start();Quoted 3 lines
When '
rte_eth_dev_configure()' is called, MTU is set to '1500' by default by ethdev layer, so it is not user configuration, but 'max_rx_pkt_len' is.See above.
PMD doesn't know where this MTU value came from (default ethdev value or user specified value) and probably it shouldn't care.Quoted 3 lines
And later, when '
rte_eth_dev_set_mtu()' is called, but MTU and 'max_rx_pkt_len' are updated (mostly).Quoted 9 lines
Quoted 3 lines
Yes, in
mtu_set()we update both.
But we don't update MTU indev_configure(), onlymax_rx_pkt_len. That what this patch tries to fix (as I understand it).To be more precise - it doesn't change MTU value in
dev_configure(), but instead doesn't allowmax_rx_pkt_lento become smaller then MTU + OVERHEAD.
Probably changing MTU value instead is a better choice.Quoted 3 lines
+1 to change mtu for this case.
And this is what happens in practice when there is no 'rte_eth_dev_set_mtu()' call, since PMD is using ('max_rx_pkt_len' - OVERHEAD) to set MTU.Hmm, I don't see that happens within Intel PMDs.
As I can read the code: if user never callmtu_set(), then MTU value is left intact.Quoted 7 lines
Quoted 2 lines
I was checking ice,
in 'ice_dev_start()', 'rxmode.max_rx_pkt_len' is used to configure the device.Yes, I am not arguing with that.
What I am saying -dev_config()doesn't update MTU based onmax_rx_pkt_len. While it probably should.
Quoted 6 lines
Yes '
dev_configure()' doesn't update the 'dev->data->mtu' and 'max_rx_pkt_len' & 'dev->data->mtu' may diverge there.I think best place to update '
dev->data->mtu' is where the device is actually updated, but to prevent the diversion above we can update 'dev->data->mtu' in ethdev layer, in 'rte_eth_dev_configure()' based on 'max_rx_pkt_len', will it work?
I think - yes.
At least, I don't foresee any implications with that.
Quoted 119 lines
Only concern I see is if user reads the MTU ('
rte_eth_dev_get_mtu()') after 'rte_eth_dev_configure()' but before device configured, user will get the wrong value, I guess that problem was already there but changing default value may make it more visible.Quoted 113 lines
Quoted 11 lines
Quoted 6 lines
Quoted 2 lines
But this won't solve the problem Steve is trying to solve.
You mean we still need to update test-pmd code to calculate
max_rx_pkt_lenproperly for default mtu value?Yes.
Because target of this set is able to receive packets with payload size 'RTE_ETHER_MTU', if MTU is updated according to the provided 'max_rx_pkt_len', device still won't able to receive those packets.Agree.
Quoted 98 lines
Quoted 98 lines
Quoted 97 lines
Quoted 20 lines
Quoted 20 lines
Quoted 20 lines
Quoted 9 lines
Before the patch will result:
mtu==1500, max_rx_pkt_len=1000; //out of sync looks wrong to meAfter the patch:
mtu=1500, max_rx_ptk_len=1518; // in sync, change in behaviour.Quoted 7 lines
If you think we need to preserve current behaviour,
then I suppose the easiest thing would be to changedev_config()code to update mtu value based onmax_rx_pkt_len.
I.E:dev_configure{...;mtu_set(max_rx_pkt_len - OVERHEAD); ...} So the code snippet above will result:
mtu=982,max_rx_pkt_len=1000;The '
max_rx_ptk_len' is annoyance for a long time, what do you think to just drop it?Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
By default device will be up with default MTU (1500), later '
rte_eth_dev_set_mtu' can be used to set the MTU, no frame size setting at all.Will this work?
I think it might, but that's a big change, probably too risky at that stage...
Defintely, I was thinking for 21.11. Let me send a deprecation notice and see what happens.
Quoted 66 lines
Quoted 65 lines
Quoted 7 lines
And for short term, for above Intel PMDs, there must be a place this '
max_rx_pkt_len' value taken into account (mostly 'start()'dev_ops), that function can be updated to take 'max_rx_pkt_len' only ifJUMBO_FRAMEset, otherwise use the 'MTU' value.Even if we'll use
max_rx_pkt_lenonly when ifJUMBO_FRAMEis set, I think we still need to keepmax_rx_pkt_lenand MTU values in sync.Quoted 54 lines
Without '
start()' updated the current logic won't work after stop & start anyway.Quoted 50 lines
Quoted 49 lines
Quoted 8 lines
And why this same thing can't happen to other PMDs? If this is a problem for all PMDs, we should solve in other level, not for only some PMDs.
No, all PMDs exist the same issue, another proposal:
-rte_ethdevprovides the unique resize 'max_rx_pkt_len' inrte_eth_dev_configure();
- provide the uniform API for fetching the NIC's supported Ether Overhead size;
Is it feasible?Quoted 36 lines
Quoted 14 lines
Quoted 14 lines
Generally, the mtu value can be adjustable from user (e.g.: ip link
set ens801f0 mtu 1400), hence, we just adjust the max_rx_pkt_len to
satisfy mtu requirement.Should we just call ice_mtu_set(dev, dev_conf.rxmode.max_rx_pkt_len)
here?
ice_mtu_set(dev, mtu) will append ether overhead to
frame_size/max_rx_pkt_len, so we need pass the mtu value as the 2nd
parameter, or not the max_rx_pkt_len.Quoted 4 lines
Quoted 4 lines
And please remove above comment, since ether overhead is already
considered in ice_mtu_set.
Ether overhead is already considered in ice_mtu_set, but it also
should be considered as the adjustment condition that if ice_mtu_setneed be invoked.
Quoted 17 lines
Quoted 16 lines
So, it perhaps should remain this comment before this if() condition.
+ret = ice_mtu_set(dev, dev->data->mtu); if (ret != 0) return
+ret; }
+
ret = ice_init_rss(pf);
if (ret) {
PMD_DRV_LOG(ERR, "Failed to enable rss for PF");
--
2.17.1
Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Quoted 183 lines · Konstantin
Quoted 183 lines
Quoted 172 lines
Quoted 172 lines · Konstantin
Quoted 170 lines
Quoted 163 lines
Quoted 153 lines
Quoted 153 lines
Quoted 111 lines
Quoted 111 lines
Quoted 110 lines
Quoted 69 lines
Quoted 26 lines
testpmd will initialize default max packet length to 1518 which
doesn't include vlan tag size in ether overheader. Once, send the
max mtu length packet with vlan tag, the max packet length will
exceed 1518 that will cause packets dropped directly from NIC hw
side.ice can support dual vlan tags that need more 8 bytes for max
packet size, so, configures the correct max packet size in
dev_config
ops.Fixes: 50cc9d2a6e9d ("net/ice: fix max frame size")
Signed-off-by: SteveX Yang <[email protected]>
---
drivers/net/ice/ice_ethdev.c | 11 +++++++++++
1 file changed, 11 insertions(+)diff --git a/drivers/net/ice/ice_ethdev.c
b/drivers/net/ice/ice_ethdev.c index
cfd357b05..6b7098444 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -3146,6 +3146,7 @@ ice_dev_configure(struct rte_eth_dev*dev)
Quoted 11 lines
struct ice_adapter *ad =
ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct ice_pf *pf =
ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
+uint32_t frame_size = dev->data->mtu + ICE_ETH_OVERHEAD;
int ret;/* Initialize to TRUE. If any of Rx queues doesn't meet the @@
-3157,6
+3158,16 @@ ice_dev_configure(struct rte_eth_dev *dev)
if (dev->data->dev_conf.rxmode.mq_mode &
ETH_MQ_RX_RSS_FLAG)Quoted 30 lines
dev->data->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_RSS_HASH;+/**
+ * Considering QinQ packet, max frame size should be equal or
+ * larger than total size of MTU and Ether overhead.
+ */+if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) {
Why we need this check?
Can we just call ice_mtu_set directlyI think that without that check we can silently overwrite provided
by user dev_conf.rxmode.max_rx_pkt_len value.OK, I see
But still have one question
dev->data->mtu is initialized to 1518 as default , but if
dev->data->application set
dev_conf.rxmode.max_rx_pkt_len = 1000 in dev_configure.
does that mean we will still will set mtu to 1518, is this expected?max_rx_pkt_len should be larger than mtu at least, so we should raise
the max_rx_pkt_len (e.g.:1518) to hold expected mtu value (e.g.: 1500).Ok, this describe the problem more general and better to replace exist
Quoted 8 lines
code comment and commit log for easy understanding.
Quoted 2 lines
Please send a new version for reword
I didn't really get this set.
Application explicitly sets '
max_rx_pkt_len' to '1518', and a frame bigger than this size is dropped.Sure, it is normal case for dropping oversize data.
Quoted 3 lines
Isn't this what should be, why we are trying to overwrite user configuration in PMD to prevent this?
But it is a confliction that application/user sets mtu &
max_rx_pkt_lenat the same time.
This fix will make a decision when confliction occurred.
MTU value will come from user operation (e.g.: port config mtu 0 1500) directly,
so, themax_rx_pkt_lenwill resize itself to adapt expected MTU value if its size is smaller than MTU + Ether overhead.Quoted 4 lines
During
eth_devallocation, mtu set to default '1500', by ethdev layer. And testpmd sets 'max_rx_pkt_len' by default to '1518'.
I think Qi's concern above is valid, what is user set 'max_rx_pkt_len' to '1000' and mean it? PMD will not honor the user config.I'm not sure when set 'mtu' to '1500' and '
max_rx_pkt_len' to '1000', what's the behavior expected? If still keep the 'max_rx_pkt_len' value, that means the larger 'mtu' will be invalid.Quoted 3 lines
Why not simply increase the default '
max_rx_pkt_len' in testpmd?The default '
max_rx_pkt_len' has been initialized to generical value (1518) and default 'mtu' is '1500' in testpmd, But it isn't suitable to those NIC drivers which Ether overhead is larger than 18. (e.g.: ice, i40e) if 'mtu' value is preferable.Quoted 7 lines
And I guess even better what we need is to tell to the application what the frame overhead PMD accepts.
So the application can set proper 'max_rx_pkt_len' value per port for a given/requested MTU value.
@Ian, cc'ed, was complaining almost same thing years ago, these PMD overhead macros and 'max_mtu'/'min_mtu' added because of that, perhaps he has a solution now?Quoted 7 lines
Quoted 4 lines
From my perspective the main problem here:
We have 2 different variables for nearly the same thing:
rte_eth_dev_data.mtu and rte_eth_dev_data.dev_conf.max_rx_pkt_len. and 2 different API to update them:dev_mtu_set()anddev_configure().According API '
max_rx_pkt_len' is 'Only used ifJUMBO_FRAMEenabled' Although not sure that is practically what is done for all drivers.I think most of Intel PMDs use it unconditionally.
Quoted 8 lines
Quoted 8 lines
And inside majority of Intel PMDs we don't keep these 2 variables in sync:
-mtu_set()will update both variables.
-dev_configure()will update onlymax_rx_pkt_len, but will keep mtu intact.This patch fixes this inconsistency, which I think is a good thing. Though yes, it introduces change in behaviour.
Quoted 8 lines
Quoted 5 lines
Let say the code:
rte_eth_dev_set_mtu(port, 1500);
dev_conf.max_rx_pkt_len = 1000;rte_eth_dev_configure(port, 1, 1, &dev_conf);'
rte_eth_dev_configure()' is one of the first APIs called, it is called before 'rte_eth_dev_set_mtu().Usually yes.
But you can still do sometimes later:dev_mtu_set(); ...;dev_stop();dev_configure();dev_start();Quoted 3 lines
When '
rte_eth_dev_configure()' is called, MTU is set to '1500' by default by ethdev layer, so it is not user configuration, but 'max_rx_pkt_len' is.See above.
PMD doesn't know where this MTU value came from (default ethdev value or user specified value) and probably it shouldn't care.Quoted 3 lines
And later, when '
rte_eth_dev_set_mtu()' is called, but MTU and 'max_rx_pkt_len' are updated (mostly).Quoted 9 lines
Quoted 3 lines
Yes, in
mtu_set()we update both.
But we don't update MTU indev_configure(), onlymax_rx_pkt_len. That what this patch tries to fix (as I understand it).To be more precise - it doesn't change MTU value in
dev_configure(), but instead doesn't allowmax_rx_pkt_lento become smaller then MTU + OVERHEAD.
Probably changing MTU value instead is a better choice.Quoted 3 lines
+1 to change mtu for this case.
And this is what happens in practice when there is no 'rte_eth_dev_set_mtu()' call, since PMD is using ('max_rx_pkt_len' - OVERHEAD) to set MTU.Hmm, I don't see that happens within Intel PMDs.
As I can read the code: if user never callmtu_set(), then MTU value is left intact.Quoted 7 lines
Quoted 2 lines
I was checking ice,
in 'ice_dev_start()', 'rxmode.max_rx_pkt_len' is used to configure the device.Yes, I am not arguing with that.
What I am saying -dev_config()doesn't update MTU based onmax_rx_pkt_len. While it probably should.Yes '
dev_configure()' doesn't update the 'dev->data->mtu' and 'max_rx_pkt_len' & 'dev->data->mtu' may diverge there.
Quoted 7 lines
Quoted 3 lines
I think best place to update '
dev->data->mtu' is where the device is actually updated, but to prevent the diversion above we can update 'dev->data->mtu' in ethdev layer, in 'rte_eth_dev_configure()' based on 'max_rx_pkt_len', will it work?I think - yes.
At least, I don't foresee any implications with that.
Thanks.
@Steve, I think there is agreement on two patches:
1- Update testpmd to take overhead account instead of setting 'max_rx_pkt_len' to 1518 blindly.
2- In 'rte_eth_dev_configure()' update 'dev->data->mtu' based on 'max_rx_pkt_len', again taking overhead into the account.
Would you mind updating the new version as above?
Thanks,
ferruh
Quoted 120 lines
Quoted 119 lines
Only concern I see is if user reads the MTU ('
rte_eth_dev_get_mtu()') after 'rte_eth_dev_configure()' but before device configured, user will get the wrong value, I guess that problem was already there but changing default value may make it more visible.Quoted 113 lines
Quoted 11 lines
Quoted 6 lines
Quoted 2 lines
But this won't solve the problem Steve is trying to solve.
You mean we still need to update test-pmd code to calculate
max_rx_pkt_lenproperly for default mtu value?Yes.
Because target of this set is able to receive packets with payload size 'RTE_ETHER_MTU', if MTU is updated according to the provided 'max_rx_pkt_len', device still won't able to receive those packets.Agree.
Quoted 98 lines
Quoted 98 lines
Quoted 97 lines
Quoted 20 lines
Quoted 20 lines
Quoted 20 lines
Quoted 9 lines
Before the patch will result:
mtu==1500, max_rx_pkt_len=1000; //out of sync looks wrong to meAfter the patch:
mtu=1500, max_rx_ptk_len=1518; // in sync, change in behaviour.Quoted 7 lines
If you think we need to preserve current behaviour,
then I suppose the easiest thing would be to changedev_config()code to update mtu value based onmax_rx_pkt_len.
I.E:dev_configure{...;mtu_set(max_rx_pkt_len - OVERHEAD); ...} So the code snippet above will result:
mtu=982,max_rx_pkt_len=1000;The '
max_rx_ptk_len' is annoyance for a long time, what do you think to just drop it?Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
By default device will be up with default MTU (1500), later '
rte_eth_dev_set_mtu' can be used to set the MTU, no frame size setting at all.Will this work?
I think it might, but that's a big change, probably too risky at that stage...
Defintely, I was thinking for 21.11. Let me send a deprecation notice and see what happens.
Quoted 66 lines
Quoted 65 lines
Quoted 7 lines
And for short term, for above Intel PMDs, there must be a place this '
max_rx_pkt_len' value taken into account (mostly 'start()'dev_ops), that function can be updated to take 'max_rx_pkt_len' only ifJUMBO_FRAMEset, otherwise use the 'MTU' value.Even if we'll use
max_rx_pkt_lenonly when ifJUMBO_FRAMEis set, I think we still need to keepmax_rx_pkt_lenand MTU values in sync.Quoted 54 lines
Without '
start()' updated the current logic won't work after stop & start anyway.Quoted 50 lines
Quoted 49 lines
Quoted 8 lines
And why this same thing can't happen to other PMDs? If this is a problem for all PMDs, we should solve in other level, not for only some PMDs.
No, all PMDs exist the same issue, another proposal:
-rte_ethdevprovides the unique resize 'max_rx_pkt_len' inrte_eth_dev_configure();
- provide the uniform API for fetching the NIC's supported Ether Overhead size;
Is it feasible?Quoted 36 lines
Quoted 18 lines
Generally, the mtu value can be adjustable from user (e.g.: ip link
set ens801f0 mtu 1400), hence, we just adjust the max_rx_pkt_len to
satisfy mtu requirement.Should we just call ice_mtu_set(dev, dev_conf.rxmode.max_rx_pkt_len)
here?
ice_mtu_set(dev, mtu) will append ether overhead to
frame_size/max_rx_pkt_len, so we need pass the mtu value as the 2nd
parameter, or not the max_rx_pkt_len.And please remove above comment, since ether overhead is already
considered in ice_mtu_set.
Ether overhead is already considered in ice_mtu_set, but it also
should be considered as the adjustment condition that if ice_mtu_setneed be invoked.
Quoted 17 lines
So, it perhaps should remain this comment before this if() condition.
+ret = ice_mtu_set(dev, dev->data->mtu); if (ret != 0) return
+ret; }
+
ret = ice_init_rss(pf);
if (ret) {
PMD_DRV_LOG(ERR, "Failed to enable rss for PF");
--
2.17.1
Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
In reply to a message not in the archiveQuoted 182 lines · SteveX
Quoted 138 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Wednesday, October 14, 2020 11:38 PM
To: Zhang, Qi Z <[email protected]>; Yang, SteveX <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Stokes, Ian <[email protected]>
Subject: Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 15 lines · Qi Z
Quoted 15 lines
-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Wednesday, September 30, 2020 9:32 AM
To: Zhang, Qi Z <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 4 lines
Quoted 4 lines
Quoted 4 lines
-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Wednesday, September 30, 2020 8:35 AM
To: Ananyev, Konstantin <[email protected]>; Yang,SteveX
Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
<[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 12 lines
-----Original Message-----
From: Ananyev, Konstantin <[email protected]>
Sent: Wednesday, September 30, 2020 7:02 AM
To: Zhang, Qi Z <[email protected]>; Yang, SteveX <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 1 line
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Monday, September 28, 2020 2:56 PM
To: [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>;Zhang,
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Ananyev, Konstantin <[email protected]>; Yang,
SteveX
Quoted 22 lines
Quoted 22 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
<[email protected]>
Subject: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaulttestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw
side.
Quoted 13 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
ice can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in
dev_configops.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Fixes 50cc9d2a6e9d ("net/ice: fix max frame size")Signed-off-by SteveX Yang <[email protected]>--- drivers/net/ice/ice_ethdev.c | 11 +++++++++++ 1 file changed, 11 insertions(+)Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
drivers/net/ice/ice_ethdev.c ice_dev_configure(struct rte_eth_dev
Quoted 6 lines
(quoted diff) +0
-0
b/drivers/net/ice/ice_ethdev.cindexcfd357b05..6b7098444100644drivers/net/ice/ice_ethdev.c +0
-0@@ -3146,6 +3146,7 @@ ice_dev_configure(struct rte_eth_dev*dev)
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
struct
ice_adapter*ad =ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
structice_pf*pf =ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);+uint32_t frame_size = dev->data->mtu + ICE_ETH_OVERHEAD; int ret; /* Initialize to TRUE. If any of Rx queues doesn't meet the @@-3157,6
+3158,16 @@ice_dev_configure(struct rte_eth_dev *dev)
if (dev->data->dev_conf.rxmode.mq_mode&
ETH_MQ_RX_RSS_FLAG)Quoted 26 lines
Quoted 26 lines
Quoted 25 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
dev->data->dev_conf.rxmode.offloads|=
DEV_RX_OFFLOAD_RSS_HASH;Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
+/**
+ * Considering QinQ packet, max frame size should be equal or
+ * larger than total size of MTU and Ether overhead.
+ */Quoted 8 lines
Quoted 5 lines
Quoted 1 line
+if (
frame_size>dev->data->dev_conf.rxmode.max_rx_pkt_len) {Why we need this check?
Can we just callice_mtu_setdirectlyI think that without that check we can silently overwrite provided by user dev_conf.rxmode.max_rx_pkt_len value.
OK, I see
But still have one question
dev->data->mtuis initialized to 1518 as default , but ifdev->data->applicationset
dev_conf.rxmode.max_rx_pkt_len = 1000 indev_configure. does that mean we will still will set mtu to 1518, is this expected?Quoted 4 lines
Quoted 2 lines
max_rx_pkt_lenshould be larger than mtu at least, so we should raise themax_rx_pkt_len(e.g.:1518) to hold expected mtu value (e.g.: 1500).Ok, this describe the problem more general and better to replace exist
Quoted 8 lines
code comment and commit log for easy understanding.
Quoted 2 lines
Please send a new version for reword
I didn't really get this set.
Application explicitly sets '
max_rx_pkt_len' to '1518', and a frame bigger than this size is dropped.Sure, it is normal case for dropping oversize data.
Quoted 3 lines
Isn't this what should be, why we are trying to overwrite user configuration in PMD to prevent this?
But it is a confliction that application/user sets mtu &
max_rx_pkt_lenat the same time.
This fix will make a decision when confliction occurred.
MTU value will come from user operation (e.g.: port config mtu 0 1500) directly,
so, themax_rx_pkt_lenwill resize itself to adapt expected MTU value if its size is smaller than MTU + Ether overhead.Quoted 4 lines
During
eth_devallocation, mtu set to default '1500', by ethdev layer. And testpmd sets 'max_rx_pkt_len' by default to '1518'.
I think Qi's concern above is valid, what is user set 'max_rx_pkt_len' to '1000' and mean it? PMD will not honor the user config.I'm not sure when set 'mtu' to '1500' and '
max_rx_pkt_len' to '1000', what's the behavior expected? If still keep the 'max_rx_pkt_len' value, that means the larger 'mtu' will be invalid.Quoted 3 lines
Why not simply increase the default '
max_rx_pkt_len' in testpmd?The default '
max_rx_pkt_len' has been initialized to generical value (1518) and default 'mtu' is '1500' in testpmd, But it isn't suitable to those NIC drivers which Ether overhead is larger than 18. (e.g.: ice, i40e) if 'mtu' value is preferable.Quoted 10 lines
And I guess even better what we need is to tell to the application what the frame overhead PMD accepts.
So the application can set proper 'max_rx_pkt_len' value per port for a given/requested MTU value.
@Ian, cc'ed, was complaining almost same thing years ago, these PMD overhead macros and 'max_mtu'/'min_mtu' added because of that, perhaps he has a solution now?
Quoted 8 lines
Quoted 3 lines
And why this same thing can't happen to other PMDs? If this is a problem for all PMDs, we should solve in other level, not for only some PMDs.
No, all PMDs exist the same issue, another proposal:
-rte_ethdevprovides the unique resize 'max_rx_pkt_len' inrte_eth_dev_configure();
- provide the uniform API for fetching the NIC's supported Ether Overhead size;
Is it feasible?
overhead can be calculated as "dev_info.max_rx_pktlen - dev_info.max_mtu"
What do you think update the testpmd 'init_config()', to update 'port->dev_conf.rxmode.max_rx_pkt_len' as "RTE_ETHER_MTU + overhead"?
Quoted 37 lines
Quoted 36 lines
Quoted 14 lines
Quoted 14 lines
Generally, the mtu value can be adjustable from user (e.g.: ip link set ens801f0 mtu 1400), hence, we just adjust the
max_rx_pkt_lento satisfy mtu requirement.Quoted 2 lines
Should we just call
ice_mtu_set(dev, dev_conf.rxmode.max_rx_pkt_len)here?
ice_mtu_set(dev, mtu)will append ether overhead to frame_size/max_rx_pkt_len, so we need pass the mtu value as the 2nd parameter, or not themax_rx_pkt_len.Quoted 3 lines
Quoted 3 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Quoted 1 line
And please remove above comment, since ether overhead is already
considered in
ice_mtu_set.Ether overhead is already considered in
ice_mtu_set, but it also should be considered as the adjustment condition that ifice_mtu_setneed be invoked.
Quoted 17 lines
Quoted 16 lines
So, it perhaps should remain this comment before this
if()condition.Quoted 13 lines
Quoted 12 lines
Quoted 11 lines
Quoted 10 lines
drivers/net/ice/ice_ethdev.c +3
-1+ret =ice_mtu_set (dev, dev->data->mtu);if (ret !=0 )return +ret; } + ret =ice_init_rss (pf);if (ret) {PMD_DRV_LOG (ERR ,"Failed to enable rss for PF" ); --2.17.1
A message that is not in the archive (sent off-list or not yet received): DM6PR11MB4362F936BFC715BF6BABBAD0F91F0@DM6PR11MB4362.namprd11.prod.outlook.com
Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Quoted 223 lines · SteveX
Quoted 223 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Tuesday, October 20, 2020 2:05 AM
To: Yang, SteveX <[email protected]>; Zhang, Qi Z <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Stokes, Ian <[email protected]>
Subject: Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 114 lines · SteveX
Quoted 114 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Wednesday, October 14, 2020 11:38 PM
To: Zhang, Qi Z <[email protected]>; Yang, SteveX <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Stokes, Ian <[email protected]>
Subject: Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 15 lines · Qi Z
Quoted 15 lines
-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Wednesday, September 30, 2020 9:32 AM
To: Zhang, Qi Z <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 4 lines
Quoted 4 lines
Quoted 4 lines
-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Wednesday, September 30, 2020 8:35 AM
To: Ananyev, Konstantin <[email protected]>; Yang,SteveX
Quoted 23 lines
Quoted 23 lines
Quoted 23 lines
<[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 13 lines
-----Original Message-----
From: Ananyev, Konstantin <[email protected]>
Sent: Wednesday, September 30, 2020 7:02 AM
To: Zhang, Qi Z <[email protected]>; Yang, SteveX <[email protected]>; [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaultQuoted 1 line
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Monday, September 28, 2020 2:56 PM
To: [email protected]
Cc: Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>;Zhang,
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Ananyev, Konstantin <[email protected]>; Yang,
SteveX
Quoted 23 lines
Quoted 23 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
<[email protected]>
Subject: [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by defaulttestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw
side.
Quoted 13 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
ice can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in
dev_configops.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Fixes 50cc9d2a6e9d ("net/ice: fix max frame size")Signed-off-by SteveX Yang <[email protected]>--- drivers/net/ice/ice_ethdev.c | 11 +++++++++++ 1 file changed, 11 insertions(+)Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
drivers/net/ice/ice_ethdev.c ice_dev_configure(struct rte_eth_dev
Quoted 6 lines
(quoted diff) +0
-0
b/drivers/net/ice/ice_ethdev.cindexcfd357b05..6b7098444100644drivers/net/ice/ice_ethdev.c +0
-0@@ -3146,6 +3146,7 @@ ice_dev_configure(struct rte_eth_dev*dev)
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
struct
ice_adapter*ad =ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
structice_pf*pf =ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);+uint32_t frame_size = dev->data->mtu + ICE_ETH_OVERHEAD; int ret;Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
/* Initialize to TRUE. If any of Rx queues doesn't meet the @@ -3157,6 +3158,16 @@ ice_dev_configure(struct rte_eth_dev *dev) if (dev->data->dev_conf.rxmode.mq_mode &
ETH_MQ_RX_RSS_FLAG)Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
dev->data->dev_conf.rxmode.offloads|=Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
DEV_RX_OFFLOAD_RSS_HASH;Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
drivers/net/ice/ice_ethdev.c +5
-0+/** +* Considering QinQ packet, max frame size should be equal or +* larger than total size of MTU and Ether overhead. +*/ +if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len){
Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
Quoted 16 lines
Quoted 7 lines
Quoted 4 lines
Why we need this check?
Can we just callice_mtu_setdirectlyI think that without that check we can silently overwrite provided by user dev_conf.rxmode.max_rx_pkt_len value.
OK, I see
But still have one question
dev->data->mtuis initialized to 1518 as default , but ifdev->data->applicationset
dev_conf.rxmode.max_rx_pkt_len = 1000 indev_configure. does that mean we will still will set mtu to 1518, is this expected?Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
max_rx_pkt_lenshould be larger than mtu at least, so we should raise themax_rx_pkt_len(e.g.:1518) to hold expected mtu value (e.g.:1500).
Quoted 12 lines
Quoted 11 lines
Quoted 3 lines
Ok, this describe the problem more general and better to replace exist
code comment and commit log for easy understanding.
Quoted 2 lines
Please send a new version for reword
I didn't really get this set.
Application explicitly sets '
max_rx_pkt_len' to '1518', and a frame bigger than this size is dropped.Quoted 7 lines
Sure, it is normal case for dropping oversize data.
Quoted 3 lines
Isn't this what should be, why we are trying to overwrite user configuration in PMD to prevent this?
But it is a confliction that application/user sets mtu &
max_rx_pkt_lenatthe same time.
Quoted 3 lines
This fix will make a decision when confliction occurred.
MTU value will come from user operation (e.g.: port config mtu 0 1500) directly, so, themax_rx_pkt_lenwill resize itself to adapt expected MTUvalue if its size is smaller than MTU + Ether overhead.
Quoted 4 lines
Quoted 4 lines
During
eth_devallocation, mtu set to default '1500', by ethdev layer. And testpmd sets 'max_rx_pkt_len' by default to '1518'.
I think Qi's concern above is valid, what is user set 'max_rx_pkt_len' to'1000'
Quoted 3 lines
Quoted 1 line
and mean it? PMD will not honor the user config.
I'm not sure when set 'mtu' to '1500' and '
max_rx_pkt_len' to '1000', what'sthe behavior expected?
Quoted 1 line
If still keep the '
max_rx_pkt_len' value, that means the larger 'mtu' will beinvalid.
Quoted 6 lines
Quoted 4 lines
Why not simply increase the default '
max_rx_pkt_len' in testpmd?The default '
max_rx_pkt_len' has been initialized to generical value (1518) and default 'mtu' is '1500' in testpmd, But it isn't suitable to thoseNIC drivers which Ether overhead is larger than 18. (e.g.: ice, i40e) if 'mtu' value is preferable.
Quoted 11 lines
Quoted 11 lines
And I guess even better what we need is to tell to the application what the frame overhead PMD accepts.
So the application can set proper 'max_rx_pkt_len' value per port for a given/requested MTU value.
@Ian, cc'ed, was complaining almost same thing years ago, these PMD overhead macros and 'max_mtu'/'min_mtu' added because of that, perhaps he has a solution now?Quoted 2 lines
Quoted 2 lines
And why this same thing can't happen to other PMDs? If this is a problem for all PMDs, we should solve in other level, not for only some
PMDs.
Quoted 3 lines
Quoted 1 line
No, all PMDs exist the same issue, another proposal:
-rte_ethdevprovides the unique resize 'max_rx_pkt_len' in
rte_eth_dev_configure();Quoted 3 lines
- provide the uniform API for fetching the NIC's supported Ether
Overhead size; Is it feasible?
Quoted 9 lines
Quoted 5 lines
overhead can be calculated as "dev_info.max_rx_pktlen - dev_info.max_mtu"
What do you think update the testpmd '
init_config()', to update 'port-Quoted 1 line
dev_conf.rxmode.max_rx_pkt_len' as "
RTE_ETHER_MTU+ overhead"?If update the testpmd relative code, this fix will only impact testpmd application, Need we make the change more common for other applications or DPDK clients?
This is something needs to be done in application level. Testpmd update can be a sample usage for them.
Quoted 2 lines
How about update '
max_rx_pkt_len' within 'rte_eth_dev_configure()' ofrte_ethdev?
What is your proposal to do in the ethdev layer?
Quoted 42 lines
Quoted 41 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Generally, the mtu value can be adjustable from user (e.g.: ip link set ens801f0 mtu 1400), hence, we just adjust the
max_rx_pkt_lento satisfy mtu requirement.Quoted 1 line
Should we just call ice_mtu_set(dev,
dev_conf.rxmode.max_rx_pkt_len)
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
here?
ice_mtu_set(dev, mtu)will append ether overhead to frame_size/max_rx_pkt_len, so we need pass the mtu value as the2nd
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
parameter, or not the
max_rx_pkt_len.Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
And please remove above comment, since ether overhead is
already
Quoted 22 lines
Quoted 21 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
Quoted 1 line
considered in
ice_mtu_set.Ether overhead is already considered in
ice_mtu_set, but it also should be considered as the adjustment condition that ifice_mtu_setneed be invoked.
Quoted 17 lines
Quoted 16 lines
So, it perhaps should remain this comment before this
if()condition.Quoted 13 lines
Quoted 12 lines
Quoted 11 lines
Quoted 10 lines
drivers/net/ice/ice_ethdev.c +3
-1+ret =ice_mtu_set (dev, dev->data->mtu);if (ret !=0 )return +ret; } + ret =ice_init_rss (pf);if (ret) {PMD_DRV_LOG (ERR ,"Failed to enable rss for PF" ); --2.17.1
PATCH v4 4/5 net/i40e: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangtestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. But for i40e/i40evf, they should support dual vlan tags that need more 8 bytes for max packet size, so, configure the correct max packet size in dev_config ops.
--- drivers/net/i40e/i40e_ethdev.c | 11 +++++++++++ drivers/net/i40e/i40e_ethdev_vf.c | 13 ++++++++++++- 2 files changed, 23 insertions(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev.c +11 -0
@@ -1916,6 +1916,7 @@ i40e_dev_configure(struct rte_eth_dev *dev)struct i40e_pf *pf =I40E_DEV_PRIVATE_TO_PF (dev->data->dev_private);struct i40e_hw *hw =I40E_DEV_PRIVATE_TO_HW (dev->data->dev_private);enum rte_eth_rx_mq_mode mq_mode = dev->data->dev_conf.rxmode.mq_mode; +uint32_t frame_size = dev->data->mtu +I40E_ETH_OVERHEAD ;int i, ret; ret =i40e_dev_sync_phy_type (hw);
@@ -1930,6 +1931,16 @@ i40e_dev_configure(struct rte_eth_dev *dev) ad->tx_simple_allowed = true; ad->tx_vec_allowed = true; +/** +* Considering QinQ packet, max frame size should be equal or +* larger than total size of MTU and Ether overhead. +*/ +if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) { + ret =i40e_dev_mtu_set (dev, dev->data->mtu); +if (ret !=0 ) +return ret; + } +if (dev->data->dev_conf.rxmode.mq_mode Ð_MQ_RX_RSS_FLAG ) dev->data->dev_conf.rxmode.offloads |=DEV_RX_OFFLOAD_RSS_HASH ;
drivers/net/i40e/i40e_ethdev_vf.c +12 -1
@@ -1669,6 +1669,8 @@ i40evf_dev_configure(struct rte_eth_dev *dev)I40E_DEV_PRIVATE_TO_ADAPTER (dev->data->dev_private);uint16_t num_queue_pairs =RTE_MAX (dev->data->nb_rx_queues, dev->data->nb_tx_queues); +uint32_t frame_size = dev->data->mtu +I40E_ETH_OVERHEAD ; +int ret;/* Initialize to TRUE. If any of Rx queues doesn't meet the bulk * allocation or vector Rx preconditions we will reset it.
@@ -1681,9 +1683,18 @@ i40evf_dev_configure(struct rte_eth_dev *dev) dev->data->dev_conf.intr_conf.lsc = !!(dev->data->dev_flags &RTE_ETH_DEV_INTR_LSC ); +/** +* Considering QinQ packet, max frame size should be equal or +* larger than total size of MTU and Ether overhead. +*/ +if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) { + ret =i40evf_dev_mtu_set (dev, dev->data->mtu); +if (ret !=0 ) +return ret; + } +if (num_queue_pairs > vf->vsi_res->num_queue_pairs) {struct i40e_hw *hw; -int ret;if (rte_eal_process_type () !=RTE_PROC_PRIMARY ) { PMD_DRV_LOG(ERR,
Signature · 1 line
2.17.1
PATCH v4 5/5 net/iavf: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangtestpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side.
iavf can support dual vlan tags that need more 8 bytes for max packet size, so, configures the correct max packet size in dev_config ops.
--- drivers/net/iavf/iavf_ethdev.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/net/iavf/iavf_ethdev.c +12 -0
@@ -258,6 +258,8 @@ iavf_dev_configure(struct rte_eth_dev *dev)IAVF_DEV_PRIVATE_TO_ADAPTER (dev->data->dev_private);struct iavf_info *vf =IAVF_DEV_PRIVATE_TO_VF (ad);struct rte_eth_conf *dev_conf = &dev->data->dev_conf; +uint32_t frame_size = dev->data->mtu +IAVF_ETH_OVERHEAD ; +int ret; ad->rx_bulk_alloc_allowed = true;/* Initialize to TRUE. If any of Rx queues doesn't meet the
@@ -269,6 +271,16 @@ iavf_dev_configure(struct rte_eth_dev *dev)if (dev->data->dev_conf.rxmode.mq_mode Ð_MQ_RX_RSS_FLAG ) dev->data->dev_conf.rxmode.offloads |=DEV_RX_OFFLOAD_RSS_HASH ; +/** +* Considering QinQ packet, max frame size should be equal or +* larger than total size of MTU and Ether overhead. +*/ +if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) { + ret =iavf_dev_mtu_set (dev, dev->data->mtu); +if (ret !=0 ) +return ret; + } +/* Vlan stripping setting */ if (vf->vf_res->vf_cap_flags &VIRTCHNL_VF_OFFLOAD_VLAN ) {if (dev_conf->rxmode.offloads &DEV_RX_OFFLOAD_VLAN_STRIP )
Signature · 1 line
2.17.1
v5 cover fix default max mtu size when device configured
In reply to SteveX Yangwhen application presets the max rx packet length and expected mtu at the same time, driver need identify if the preset max frame size can hold mtu data and Ether overhead completely.
if not, adjust the max frame size via mtu_set ops within dev_configure.
v5:
* update comments and commit messages;
v4:
* add the adjust condition for max_rx_pkt_len;
v3:
* change the i40evf relative code;
v2:
* change the max_rx_pkt_len via mtu_set ops;
SteveX Yang (5):
net/e1000: fix max mtu size packets with vlan tag cannot be received
by default
net/igc: fix max mtu size packets with vlan tag cannot be received by
default
net/ice: fix max mtu size packets with vlan tag cannot be received by
default
net/i40e: fix max mtu size packets with vlan tag cannot be received by
default
net/iavf: fix max mtu size packets with vlan tag cannot be received by
default
drivers/net/e1000/em_ethdev.c | 12 ++++++++++++ drivers/net/i40e/i40e_ethdev.c | 11 +++++++++++ drivers/net/i40e/i40e_ethdev_vf.c | 13 ++++++++++++- drivers/net/iavf/iavf_ethdev.c | 12 ++++++++++++ drivers/net/ice/ice_ethdev.c | 11 +++++++++++ drivers/net/igc/igc_ethdev.c | 13 ++++++++++++- 6 files changed, 70 insertions(+), 2 deletions(-)
Signature · 1 line
2.17.1
PATCH v5 1/5 net/e1000: fix max mtu size packets with vlan tag cannot be received by default
when application presets the max rx packet length and expected mtu at the same time, driver need identify if the preset max frame size can hold mtu data and Ether overhead completely.
if not, adjust the max frame size via mtu_set ops within dev_configure.
--- drivers/net/e1000/em_ethdev.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/net/e1000/em_ethdev.c +12 -0
@@ -432,10 +432,22 @@ eth_em_configure(struct rte_eth_dev *dev) {struct e1000_interrupt *intr =E1000_DEV_PRIVATE_TO_INTR (dev->data->dev_private); +uint16_t frame_size = dev->data->mtu +E1000_ETH_OVERHEAD ; +int rc =0 ;PMD_INIT_FUNC_TRACE (); intr->flags |=E1000_FLAG_NEED_LINK_UPDATE ; +/** +* Reset the max frame size via mtu_set ops if preset max frame +* cannot hold MTU data and Ether overhead. +*/ +if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) { + rc =eth_em_mtu_set (dev, dev->data->mtu); +if (rc !=0 ) +return rc; + } +PMD_INIT_FUNC_TRACE ();return 0 ;
Signature · 1 line
2.17.1
PATCH v5 2/5 net/igc: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangwhen application presets the max rx packet length and expected mtu at the same time, driver need identify if the preset max frame size can hold mtu data and Ether overhead completely.
if not, adjust the max frame size via mtu_set ops within dev_configure.
--- drivers/net/igc/igc_ethdev.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
drivers/net/igc/igc_ethdev.c +12 -1
@@ -337,11 +337,22 @@ static int eth_igc_configure(struct rte_eth_dev *dev) {struct igc_interrupt *intr =IGC_DEV_PRIVATE_INTR (dev); +uint32_t frame_size = dev->data->mtu +IGC_ETH_OVERHEAD ;int ret;PMD_INIT_FUNC_TRACE (); - ret =igc_check_mq_mode (dev); +/** +* Reset the max frame size via mtu_set ops if preset max frame +* cannot hold MTU data and Ether overhead. +*/ +if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) { + ret =eth_igc_mtu_set (dev, dev->data->mtu); +if (ret !=0 ) +return ret; + } + + ret =igc_check_mq_mode (dev);if (ret !=0 )return ret;
Signature · 1 line
2.17.1
PATCH v5 3/5 net/ice: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangwhen application presets the max rx packet length and expected mtu at the same time, driver need identify if the preset max frame size can hold mtu data and Ether overhead completely.
if not, adjust the max frame size via mtu_set ops within dev_configure.
--- drivers/net/ice/ice_ethdev.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/net/ice/ice_ethdev.c +11 -0
@@ -3305,6 +3305,7 @@ ice_dev_configure(struct rte_eth_dev *dev)struct ice_adapter *ad =ICE_DEV_PRIVATE_TO_ADAPTER (dev->data->dev_private);struct ice_pf *pf =ICE_DEV_PRIVATE_TO_PF (dev->data->dev_private); +uint32_t frame_size = dev->data->mtu +ICE_ETH_OVERHEAD ;int ret;/* Initialize to TRUE. If any of Rx queues doesn't meet the
@@ -3316,6 +3317,16 @@ ice_dev_configure(struct rte_eth_dev *dev)if (dev->data->dev_conf.rxmode.mq_mode Ð_MQ_RX_RSS_FLAG ) dev->data->dev_conf.rxmode.offloads |=DEV_RX_OFFLOAD_RSS_HASH ; +/** +* Reset the max frame size via mtu_set ops if preset max frame +* cannot hold MTU data and Ether overhead. +*/ +if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) { + ret =ice_mtu_set (dev, dev->data->mtu); +if (ret !=0 ) +return ret; + } + ret =ice_init_rss (pf);if (ret) {PMD_DRV_LOG (ERR ,"Failed to enable rss for PF" );
Signature · 1 line
2.17.1
Re: [dpdk-dev] [PATCH v5 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Couple comments inline,
Btw, no need to submit a new version, I will ack and merge the patch with below fix directly. but please keep in mind in your next patch.
Quoted 10 lines
-----Original Message-----
From: SteveX Yang <[email protected]>
Sent: Wednesday, October 14, 2020 5:20 PM
To: [email protected]
Cc: Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Ananyev, Konstantin <[email protected]>; Yang, SteveX <[email protected]>
Subject: [PATCH v5 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default
Title is too long, please use check-git-log.sh
Renamed to
"fix MTU size for VLAN packets"
Quoted 2 lines
when application presets the max rx packet length and expected mtu at the
s/when/When
Quoted 4 lines
same time, driver need identify if the preset max frame size can hold mtu data and Ether overhead completely.
if not, adjust the max frame size via
mtu_setops withindev_configure.
s/if/If
Quoted 41 lines
Fixes 50cc9d2a6e9d ("net/ice: fix max frame size")Signed-off-by SteveX Yang <[email protected]>--- drivers/net/ice/ice_ethdev.c | 11 +++++++++++ 1 file changed, 11 insertions(+)drivers/net/ice/ice_ethdev.c index renamed from drivers/net/ice/ice_ethdev.c +0
-0
0056da78a..a707612c2100644drivers/net/ice/ice_ethdev.c +2
-0@@ -3305,6 +3305,7 @@ ice_dev_configure(struct rte_eth_dev *dev)struct ice_adapter *ad =ICE_DEV_PRIVATE_TO_ADAPTER (dev->data->dev_private);struct ice_pf *pf =ICE_DEV_PRIVATE_TO_PF (dev->data->dev_private); +uint32_t frame_size = dev->data->mtu +ICE_ETH_OVERHEAD ;int ret;/* Initialize to TRUE. If any of Rx queues doesn't meet the @@ -3316,6 +3317,16 @@ ice_dev_configure(struct rte_eth_dev *dev) if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) dev->data->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_RSS_HASH;drivers/net/ice/ice_ethdev.c +10
-1+/** +* Reset the max frame size via mtu_set ops if preset max frame +* cannot hold MTU data and Ether overhead. +*/ +if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) { + ret =ice_mtu_set (dev, dev->data->mtu); +if (ret !=0 ) +return ret; + } + ret =ice_init_rss (pf);if (ret) {PMD_DRV_LOG (ERR ,"Failed to enable rss for PF" ); --2.17.1
PATCH v5 4/5 net/i40e: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangwhen application presets the max rx packet length and expected mtu at the same time, driver need identify if the preset max frame size can hold mtu data and Ether overhead completely.
if not, adjust the max frame size via mtu_set ops within dev_configure.
--- drivers/net/i40e/i40e_ethdev.c | 11 +++++++++++ drivers/net/i40e/i40e_ethdev_vf.c | 13 ++++++++++++- 2 files changed, 23 insertions(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev.c +11 -0
@@ -1911,6 +1911,7 @@ i40e_dev_configure(struct rte_eth_dev *dev)struct i40e_pf *pf =I40E_DEV_PRIVATE_TO_PF (dev->data->dev_private);struct i40e_hw *hw =I40E_DEV_PRIVATE_TO_HW (dev->data->dev_private);enum rte_eth_rx_mq_mode mq_mode = dev->data->dev_conf.rxmode.mq_mode; +uint32_t frame_size = dev->data->mtu +I40E_ETH_OVERHEAD ;int i, ret; ret =i40e_dev_sync_phy_type (hw);
@@ -1925,6 +1926,16 @@ i40e_dev_configure(struct rte_eth_dev *dev) ad->tx_simple_allowed = true; ad->tx_vec_allowed = true; +/** +* Reset the max frame size via mtu_set ops if preset max frame +* cannot hold MTU data and Ether overhead. +*/ +if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) { + ret =i40e_dev_mtu_set (dev, dev->data->mtu); +if (ret !=0 ) +return ret; + } +if (dev->data->dev_conf.rxmode.mq_mode Ð_MQ_RX_RSS_FLAG ) dev->data->dev_conf.rxmode.offloads |=DEV_RX_OFFLOAD_RSS_HASH ;
drivers/net/i40e/i40e_ethdev_vf.c +12 -1
@@ -1664,6 +1664,8 @@ i40evf_dev_configure(struct rte_eth_dev *dev)I40E_DEV_PRIVATE_TO_ADAPTER (dev->data->dev_private);uint16_t num_queue_pairs =RTE_MAX (dev->data->nb_rx_queues, dev->data->nb_tx_queues); +uint32_t frame_size = dev->data->mtu +I40E_ETH_OVERHEAD ; +int ret;/* Initialize to TRUE. If any of Rx queues doesn't meet the bulk * allocation or vector Rx preconditions we will reset it.
@@ -1676,9 +1678,18 @@ i40evf_dev_configure(struct rte_eth_dev *dev) dev->data->dev_conf.intr_conf.lsc = !!(dev->data->dev_flags &RTE_ETH_DEV_INTR_LSC ); +/** +* Reset the max frame size via mtu_set ops if preset max frame +* cannot hold MTU data and Ether overhead. +*/ +if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) { + ret =i40evf_dev_mtu_set (dev, dev->data->mtu); +if (ret !=0 ) +return ret; + } +if (num_queue_pairs > vf->vsi_res->num_queue_pairs) {struct i40e_hw *hw; -int ret;if (rte_eal_process_type () !=RTE_PROC_PRIMARY ) { PMD_DRV_LOG(ERR,
Signature · 1 line
2.17.1
Re: [dpdk-dev] [PATCH v5 4/5] net/i40e: fix max mtu size packets with vlan tag cannot be received by default
Quoted 29 lines
when application presets the max rx packet length and expected mtu at the same time, driver need identify if the preset max frame size can hold mtu data and Ether overhead completely.
if not, adjust the max frame size via
mtu_setops withindev_configure.Fixes ff8282f4bbcd ("net/i40e: consider QinQ when setting MTU")Signed-off-by SteveX Yang <[email protected]>--- drivers/net/i40e/i40e_ethdev.c | 11 +++++++++++ drivers/net/i40e/i40e_ethdev_vf.c | 13 ++++++++++++- 2 files changed, 23 insertions(+), 1 deletion(-)drivers/net/i40e/i40e_ethdev.c +1
-0@@ -1911,6 +1911,7 @@ i40e_dev_configure(struct rte_eth_dev *dev)struct i40e_pf *pf =I40E_DEV_PRIVATE_TO_PF (dev->data->dev_private);struct i40e_hw *hw =I40E_DEV_PRIVATE_TO_HW (dev->data->dev_private);enum rte_eth_rx_mq_mode mq_mode = dev->data->dev_conf.rxmode.mq_mode; +uint32_t frame_size = dev->data->mtu +I40E_ETH_OVERHEAD ;int i, ret; ret =i40e_dev_sync_phy_type (hw);
drivers/net/i40e/i40e_ethdev.c i40e_dev_configure(struct rte_eth_dev *dev) · line 1930
Quoted 5 lines
drivers/net/i40e/i40e_ethdev.c +2
-0@@ -1925,6 +1926,16 @@ i40e_dev_configure(struct rte_eth_dev *dev) ad->tx_simple_allowed = true; ad->tx_vec_allowed = true; +/** +* Reset the max frame size via mtu_set ops if preset max frame
Typo, should be 'present', I think.
Quoted 46 lines
drivers/net/i40e/i40e_ethdev.c +8
-0+* cannot hold MTU data and Ether overhead. +*/ +if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) { + ret =i40e_dev_mtu_set (dev, dev->data->mtu); +if (ret !=0 ) +return ret; + } +if (dev->data->dev_conf.rxmode.mq_mode Ð_MQ_RX_RSS_FLAG ) dev->data->dev_conf.rxmode.offloads |=DEV_RX_OFFLOAD_RSS_HASH ;drivers/net/i40e/i40e_ethdev_vf.c +12
-2@@ -1664,6 +1664,8 @@ i40evf_dev_configure(struct rte_eth_dev *dev)I40E_DEV_PRIVATE_TO_ADAPTER (dev->data->dev_private);uint16_t num_queue_pairs =RTE_MAX (dev->data->nb_rx_queues, dev->data->nb_tx_queues); +uint32_t frame_size = dev->data->mtu +I40E_ETH_OVERHEAD ; +int ret;/* Initialize to TRUE. If any of Rx queues doesn't meet the bulk * allocation or vector Rx preconditions we will reset it. @@ -1676,9 +1678,18 @@ i40evf_dev_configure(struct rte_eth_dev *dev) dev->data->dev_conf.intr_conf.lsc = !!(dev->data->dev_flags &RTE_ETH_DEV_INTR_LSC ); +/** +* Reset the max frame size via mtu_set ops if preset max frame +* cannot hold MTU data and Ether overhead. +*/ +if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) { + ret =i40evf_dev_mtu_set (dev, dev->data->mtu); +if (ret !=0 ) +return ret; + } +if (num_queue_pairs > vf->vsi_res->num_queue_pairs) {struct i40e_hw *hw; -int ret;if (rte_eal_process_type () !=RTE_PROC_PRIMARY ) { PMD_DRV_LOG(ERR, --2.17.1
PATCH v5 5/5 net/iavf: fix max mtu size packets with vlan tag cannot be received by default
In reply to SteveX Yangwhen application presets the max rx packet length and expected mtu at the same time, driver need identify if the preset max frame size can hold mtu data and Ether overhead completely.
if not, adjust the max frame size via mtu_set ops within dev_configure.
--- drivers/net/iavf/iavf_ethdev.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/net/iavf/iavf_ethdev.c +12 -0
@@ -291,6 +291,8 @@ iavf_dev_configure(struct rte_eth_dev *dev)IAVF_DEV_PRIVATE_TO_ADAPTER (dev->data->dev_private);struct iavf_info *vf =IAVF_DEV_PRIVATE_TO_VF (ad);struct rte_eth_conf *dev_conf = &dev->data->dev_conf; +uint32_t frame_size = dev->data->mtu +IAVF_ETH_OVERHEAD ; +int ret; ad->rx_bulk_alloc_allowed = true;/* Initialize to TRUE. If any of Rx queues doesn't meet the
@@ -302,6 +304,16 @@ iavf_dev_configure(struct rte_eth_dev *dev)if (dev->data->dev_conf.rxmode.mq_mode Ð_MQ_RX_RSS_FLAG ) dev->data->dev_conf.rxmode.offloads |=DEV_RX_OFFLOAD_RSS_HASH ; +/** +* Reset the max frame size via mtu_set ops if preset max frame +* cannot hold MTU data and Ether overhead. +*/ +if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) { + ret =iavf_dev_mtu_set (dev, dev->data->mtu); +if (ret !=0 ) +return ret; + } +/* Vlan stripping setting */ if (vf->vf_res->vf_cap_flags &VIRTCHNL_VF_OFFLOAD_VLAN ) {if (dev_conf->rxmode.offloads &DEV_RX_OFFLOAD_VLAN_STRIP )
Signature · 1 line
2.17.1
Quoted 47 lines
-----Original Message-----
From: SteveX Yang <[email protected]>
Sent: Wednesday, October 14, 2020 5:20 PM
To: [email protected]
Cc: Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Ananyev, Konstantin <[email protected]>; Yang, SteveX <[email protected]>
Subject: [PATCH v5 0/5] fix default max mtu size when device configuredwhen application presets the max rx packet length and expected mtu at the same time, driver need identify if the preset max frame size can hold mtu data and Ether overhead completely.
if not, adjust the max frame size via
mtu_setops withindev_configure.v5:
* update comments and commit messages;
v4:
* add the adjust condition formax_rx_pkt_len;
v3:
* change the i40evf relative code;
v2:
* change themax_rx_pkt_lenviamtu_setops;SteveX Yang (5):
net/e1000: fix max mtu size packets with vlan tag cannot be received
by default
net/igc: fix max mtu size packets with vlan tag cannot be received by
default
net/ice: fix max mtu size packets with vlan tag cannot be received by
default
net/i40e: fix max mtu size packets with vlan tag cannot be received by
default
net/iavf: fix max mtu size packets with vlan tag cannot be received by
defaultdrivers/net/e1000/em_ethdev.c | 12 ++++++++++++ drivers/net/i40e/i40e_ethdev.c | 11 +++++++++++ drivers/net/i40e/i40e_ethdev_vf.c | 13 ++++++++++++- drivers/net/iavf/iavf_ethdev.c | 12 ++++++++++++ drivers/net/ice/ice_ethdev.c | 11 +++++++++++ drivers/net/igc/igc_ethdev.c | 13 ++++++++++++- 6 files changed, 70 insertions(+), 2 deletions(-)
Quoted 2 lines
--
2.17.1
Applied to dpdk-next-net-intel.
Thanks
Qi
v6 cover fix default max mtu size when device configured
In reply to SteveX YangFor testpmd, increase the max rx packet length when size of mtu and overhead exceeds max_rx_pkt_len.
For generic ethdev, readuce the mtu size to ensure the rx frame size is larger than size of mtu and overhead.
v6:
* change the max_rx_pkt_len in the init_config of testpmd;
* change the mtu value in the rte_ethdev;
v5:
* update comments and commit messages;
v4:
* add the adjust condition for max_rx_pkt_len;
v3:
* change the i40evf relative code;
v2:
* change the max_rx_pkt_len via mtu_set ops;
SteveX Yang (2):
app/testpmd: fix max rx packet length for VLAN packets
librte_ethdev: fix MTU size exceeds max rx packet length
app/test-pmd/testpmd.c | 52 +++++++++++++++++++++++++--------- lib/librte_ethdev/rte_ethdev.c | 14 +++++++++ 2 files changed, 52 insertions(+), 14 deletions(-)
Signature · 1 line
2.17.1
PATCH v6 1/2 app/testpmd: fix max rx packet length for VLAN packets
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped.
--- app/test-pmd/testpmd.c | 52 ++++++++++++++++++++++++++++++------------ 1 file changed, 38 insertions(+), 14 deletions(-)
app/test-pmd/testpmd.c +38 -14
@@ -1418,9 +1418,13 @@ init_config(void)unsigned int nb_mbuf_per_pool;lcoreid_t lc_id;uint8_t port_per_socket[RTE_MAX_NUMA_NODES ]; +struct rte_eth_dev_info *dev_info; +struct rte_eth_conf *dev_conf;struct rte_gro_param gro_param;uint32_t gso_types;uint16_t data_size; +uint16_t overhead_len; +uint16_t frame_size;bool warning =0 ;int k;int ret;
@@ -1448,18 +1452,40 @@ init_config(void)RTE_ETH_FOREACH_DEV (pid) { port = &ports[pid]; + + dev_info = &port->dev_info; + dev_conf = &port->dev_conf; +/* Apply default TxRx configuration for all ports */ - port->dev_conf.txmode = tx_mode; - port->dev_conf.rxmode = rx_mode; + dev_conf->txmode = tx_mode; + dev_conf->rxmode = rx_mode; - ret =eth_dev_info_get_print_err (pid, &port->dev_info); + ret =eth_dev_info_get_print_err (pid, dev_info);if (ret !=0 )rte_exit (EXIT_FAILURE ,"rte_eth_dev_info_get() failed\n" ); -if (!(port->dev_info.tx_offload_capa & +/* +* Update the max_rx_pkt_len to ensure that its size equals the +* sum of default mtu size and ether overhead length at least. +*/ +if (dev_info->max_rx_pktlen && dev_info->max_mtu) + overhead_len = + dev_info->max_rx_pktlen - dev_info->max_mtu; +else + overhead_len = +RTE_ETHER_HDR_LEN +RTE_ETHER_CRC_LEN ; + + frame_size =RTE_ETHER_MTU + overhead_len; +if (frame_size >RTE_ETHER_MAX_LEN ) { + dev_conf->rxmode.max_rx_pkt_len = frame_size; + dev_conf->rxmode.offloads |= +DEV_RX_OFFLOAD_JUMBO_FRAME ; + } + +if (!(dev_info->tx_offload_capa &DEV_TX_OFFLOAD_MBUF_FAST_FREE )) - port->dev_conf.txmode.offloads &= + dev_conf->txmode.offloads &= ~DEV_TX_OFFLOAD_MBUF_FAST_FREE ;if (numa_support) {if (port_numa[pid] !=NUMA_NO_CONFIG )
@@ -1478,13 +1504,11 @@ init_config(void) }/* Apply Rx offloads configuration */ -for (k =0 ; k < port->dev_info.max_rx_queues; k++) - port->rx_conf[k].offloads = - port->dev_conf.rxmode.offloads; +for (k =0 ; k < dev_info->max_rx_queues; k++) + port->rx_conf[k].offloads = dev_conf->rxmode.offloads;/* Apply Tx offloads configuration */ -for (k =0 ; k < port->dev_info.max_tx_queues; k++) - port->tx_conf[k].offloads = - port->dev_conf.txmode.offloads; +for (k =0 ; k < dev_info->max_tx_queues; k++) + port->tx_conf[k].offloads = dev_conf->txmode.offloads;/* set flag to initialize port/queue */ port->need_reconfig =1 ;
@@ -1494,10 +1518,10 @@ init_config(void)/* Check for maximum number of segments per MTU. Accordingly * update the mbuf data size. */ -if (port->dev_info.rx_desc_lim.nb_mtu_seg_max !=UINT16_MAX && - port->dev_info.rx_desc_lim.nb_mtu_seg_max !=0 ) { +if (dev_info->rx_desc_lim.nb_mtu_seg_max !=UINT16_MAX && + dev_info->rx_desc_lim.nb_mtu_seg_max !=0 ) { data_size = rx_mode.max_rx_pkt_len / - port->dev_info.rx_desc_lim.nb_mtu_seg_max; + dev_info->rx_desc_lim.nb_mtu_seg_max;if ((data_size +RTE_PKTMBUF_HEADROOM ) > mbuf_data_size[0 ]) {
Signature · 1 line
2.17.1
Re: [dpdk-dev] [PATCH v6 1/2] app/testpmd: fix max rx packet length for VLAN packets
Quoted 32 lines · SteveX Yang
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped.
Fixes 35b2d13fd6fd ("net: add rte prefix to ether defines")Signed-off-by SteveX Yang <[email protected]>--- app/test-pmd/testpmd.c | 52 ++++++++++++++++++++++++++++++------------ 1 file changed, 38 insertions(+), 14 deletions(-)app/test-pmd/testpmd.c +4
-0@@ -1418,9 +1418,13 @@ init_config(void)unsigned int nb_mbuf_per_pool;lcoreid_t lc_id;uint8_t port_per_socket[RTE_MAX_NUMA_NODES ]; +struct rte_eth_dev_info *dev_info; +struct rte_eth_conf *dev_conf;struct rte_gro_param gro_param;uint32_t gso_types;uint16_t data_size; +uint16_t overhead_len; +uint16_t frame_size;bool warning =0 ;int k;int ret;@@ -1448,18 +1452,40 @@ init_config(void)RTE_ETH_FOREACH_DEV (pid) {
app/test-pmd/testpmd.c init_config(void) · line 1461
Quoted 10 lines
app/test-pmd/testpmd.c +6
-2port = &ports[pid]; + + dev_info = &port->dev_info; + dev_conf = &port->dev_conf; +/* Apply default TxRx configuration for all ports */ - port->dev_conf.txmode = tx_mode; - port->dev_conf.rxmode = rx_mode; + dev_conf->txmode = tx_mode; + dev_conf->rxmode = rx_mode;
Hi Steve,
This patch does a small refactoring ('dev_info' & 'dev_conf') and a small update, but the refactoring shows the patch more complex than it actually is, if you think that is required can you please seperate these two?
app/test-pmd/testpmd.c init_config(void) · line 1471
Quoted 12 lines
app/test-pmd/testpmd.c +5
-2- ret =eth_dev_info_get_print_err (pid, &port->dev_info); + ret =eth_dev_info_get_print_err (pid, dev_info);if (ret !=0 )rte_exit (EXIT_FAILURE ,"rte_eth_dev_info_get() failed\n" ); - if (!(port->dev_info.tx_offload_capa & +/* +* Update the max_rx_pkt_len to ensure that its size equals the +* sum of default mtu size and ether overhead length at least. +*/
What about simplifying the above comment like:
" Update the max_rx_pkt_len to have MTU as RTE_ETHER_MTU "
app/test-pmd/testpmd.c init_config(void) · line 1483
Quoted 12 lines
app/test-pmd/testpmd.c +12
-0+if (dev_info->max_rx_pktlen && dev_info->max_mtu) + overhead_len = + dev_info->max_rx_pktlen - dev_info->max_mtu; +else + overhead_len = +RTE_ETHER_HDR_LEN +RTE_ETHER_CRC_LEN ; + + frame_size =RTE_ETHER_MTU + overhead_len; +if (frame_size >RTE_ETHER_MAX_LEN ) { + dev_conf->rxmode.max_rx_pkt_len = frame_size; + dev_conf->rxmode.offloads |= +DEV_RX_OFFLOAD_JUMBO_FRAME ;
I am not sure the jumbo frame asignment is always true.
'frame_size' can be bigger than 'RTE_ETHER_MAX_LEN', but mtu still can be <= 1500. What about dropping this?
Quoted 42 lines
app/test-pmd/testpmd.c +11
-10+ } + +if (!(dev_info->tx_offload_capa &DEV_TX_OFFLOAD_MBUF_FAST_FREE )) - port->dev_conf.txmode.offloads &= + dev_conf->txmode.offloads &= ~DEV_TX_OFFLOAD_MBUF_FAST_FREE ;if (numa_support) {if (port_numa[pid] !=NUMA_NO_CONFIG )@@ -1478,13 +1504,11 @@ init_config(void) }/* Apply Rx offloads configuration */ -for (k =0 ; k < port->dev_info.max_rx_queues; k++) - port->rx_conf[k].offloads = - port->dev_conf.rxmode.offloads; +for (k =0 ; k < dev_info->max_rx_queues; k++) + port->rx_conf[k].offloads = dev_conf->rxmode.offloads;/* Apply Tx offloads configuration */ -for (k =0 ; k < port->dev_info.max_tx_queues; k++) - port->tx_conf[k].offloads = - port->dev_conf.txmode.offloads; +for (k =0 ; k < dev_info->max_tx_queues; k++) + port->tx_conf[k].offloads = dev_conf->txmode.offloads;/* set flag to initialize port/queue */ port->need_reconfig =1 ;@@ -1494,10 +1518,10 @@ init_config(void)/* Check for maximum number of segments per MTU. Accordingly * update the mbuf data size. */ -if (port->dev_info.rx_desc_lim.nb_mtu_seg_max !=UINT16_MAX && - port->dev_info.rx_desc_lim.nb_mtu_seg_max !=0 ) { +if (dev_info->rx_desc_lim.nb_mtu_seg_max !=UINT16_MAX && + dev_info->rx_desc_lim.nb_mtu_seg_max !=0 ) { data_size = rx_mode.max_rx_pkt_len / - port->dev_info.rx_desc_lim.nb_mtu_seg_max; + dev_info->rx_desc_lim.nb_mtu_seg_max;if ((data_size +RTE_PKTMBUF_HEADROOM ) > mbuf_data_size[0 ]) {
PATCH v6 2/2 librte_ethdev: fix MTU size exceeds max rx packet length
In reply to SteveX YangIf max rx packet length is smaller then MTU + Ether overhead, that will drop all MTU size packets.
Update the MTU size according to the max rx packet and Ether overhead.
--- lib/librte_ethdev/rte_ethdev.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
lib/librte_ethdev/rte_ethdev.c +14 -0
@@ -1290,6 +1290,8 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,struct rte_eth_dev *dev;struct rte_eth_dev_info dev_info;struct rte_eth_conf orig_conf; +uint16_t overhead_len; +uint16_t max_rx_pktlen;int diag;int ret;
@@ -1415,6 +1417,18 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,RTE_ETHER_MAX_LEN ; } +/* +* Update MTU value if MTU + OVERHEAD exceeds the max_rx_pkt_len +*/ + max_rx_pktlen = dev->data->dev_conf.rxmode.max_rx_pkt_len; +if (dev_info.max_rx_pktlen && dev_info.max_mtu) + overhead_len = dev_info.max_rx_pktlen - dev_info.max_mtu; +else + overhead_len =RTE_ETHER_HDR_LEN +RTE_ETHER_CRC_LEN ; + +if (max_rx_pktlen < dev->data->mtu + overhead_len) + dev->data->mtu = max_rx_pktlen - overhead_len; +/* * If LRO is enabled, check that the maximum aggregated packet * size is supported by the configured device.
Signature · 1 line
2.17.1
Re: [dpdk-dev] [PATCH v6 2/2] librte_ethdev: fix MTU size exceeds max rx packet length
Quoted 26 lines · SteveX Yang
If max rx packet length is smaller then MTU + Ether overhead, that will drop all MTU size packets.
Update the MTU size according to the max rx packet and Ether overhead.
Fixes 59d0ecdbf0e1 ("ethdev: MTU accessors")Signed-off-by SteveX Yang <[email protected]>--- lib/librte_ethdev/rte_ethdev.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)lib/librte_ethdev/rte_ethdev.c +2
-0@@ -1290,6 +1290,8 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,struct rte_eth_dev *dev;struct rte_eth_dev_info dev_info;struct rte_eth_conf orig_conf; +uint16_t overhead_len; +uint16_t max_rx_pktlen;int diag;int ret;
lib/librte_ethdev/rte_ethdev.c rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q, · line 1422
Quoted 6 lines
lib/librte_ethdev/rte_ethdev.c +3
-0@@ -1415,6 +1417,18 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,RTE_ETHER_MAX_LEN ; } +/* +* Update MTU value if MTU + OVERHEAD exceeds the max_rx_pkt_len +*/
I am not sure this conditional update is required, the target is keep 'max_rx_pktlen' & 'mtu' in sync.
So why not just:dev->data->mtu = max_rx_pktlen - overhead_len;
Quoted 13 lines
lib/librte_ethdev/rte_ethdev.c +9
-0+ max_rx_pktlen = dev->data->dev_conf.rxmode.max_rx_pkt_len; +if (dev_info.max_rx_pktlen && dev_info.max_mtu) + overhead_len = dev_info.max_rx_pktlen - dev_info.max_mtu; +else + overhead_len =RTE_ETHER_HDR_LEN +RTE_ETHER_CRC_LEN ; + +if (max_rx_pktlen < dev->data->mtu + overhead_len) + dev->data->mtu = max_rx_pktlen - overhead_len; +/* * If LRO is enabled, check that the maximum aggregated packet * size is supported by the configured device.
Re: [dpdk-dev] [PATCH v6 2/2] librte_ethdev: fix MTU size exceeds max rx packet length
In reply to SteveX YangQuoted 28 lines
Update the MTU size according to the max rx packet and Ether overhead.
Fixes 59d0ecdbf0e1 ("ethdev: MTU accessors")Signed-off-by SteveX Yang <[email protected]>--- lib/librte_ethdev/rte_ethdev.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)lib/librte_ethdev/rte_ethdev.c +2
-0@@ -1290,6 +1290,8 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,struct rte_eth_dev *dev;struct rte_eth_dev_info dev_info;struct rte_eth_conf orig_conf; +uint16_t overhead_len; +uint16_t max_rx_pktlen;int diag;int ret;@@ -1415,6 +1417,18 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,RTE_ETHER_MAX_LEN ; }
lib/librte_ethdev/rte_ethdev.c rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q, · line 1429
Quoted 10 lines
lib/librte_ethdev/rte_ethdev.c +10
-0+/* +* Update MTU value if MTU + OVERHEAD exceeds the max_rx_pkt_len +*/ + max_rx_pktlen = dev->data->dev_conf.rxmode.max_rx_pkt_len; +if (dev_info.max_rx_pktlen && dev_info.max_mtu) + overhead_len = dev_info.max_rx_pktlen - dev_info.max_mtu; +else + overhead_len =RTE_ETHER_HDR_LEN +RTE_ETHER_CRC_LEN ; + +if (max_rx_pktlen < dev->data->mtu + overhead_len)
Do we need that if() here?
Might be do assignment unconditionally?
Quoted 7 lines
lib/librte_ethdev/rte_ethdev.c +2
-1+ dev->data->mtu = max_rx_pktlen - overhead_len; +/* * If LRO is enabled, check that the maximum aggregated packet * size is supported by the configured device. -- 2.17.1
v7 cover fix default max mtu size when device configured
In reply to SteveX YangUpdate the max_rx_pkt_len to have MTU as RTE_ETHER_MTU.
v7:
* drop patch 2 due to Jumbo frame flag issue;
v6:
* change the max_rx_pkt_len in the init_config of testpmd;
* change the mtu value in the rte_ethdev;
v5:
* update comments and commit messages;
v4:
* add the adjust condition for max_rx_pkt_len;
v3:
* change the i40evf relative code;
v2:
* change the max_rx_pkt_len via mtu_set ops;
SteveX Yang (1):
app/testpmd: fix max rx packet length for VLAN packets
app/test-pmd/testpmd.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
Signature · 1 line
2.17.1
PATCH v7 1/1 app/testpmd: fix max rx packet length for VLAN packets
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped.
--- app/test-pmd/testpmd.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
app/test-pmd/testpmd.c +20 -0
@@ -1421,6 +1421,7 @@ init_config(void)struct rte_gro_param gro_param;uint32_t gso_types;uint16_t data_size; +uint16_t overhead_len;bool warning =0 ;int k;int ret;
@@ -1457,6 +1458,25 @@ init_config(void)rte_exit (EXIT_FAILURE ,"rte_eth_dev_info_get() failed\n" ); +/* Update the max_rx_pkt_len to have MTU as RTE_ETHER_MTU */ +if (port->dev_info.max_rx_pktlen && port->dev_info.max_mtu) + overhead_len = port->dev_info.max_rx_pktlen - + port->dev_info.max_mtu; +else + overhead_len =RTE_ETHER_HDR_LEN +RTE_ETHER_CRC_LEN ; + + port->dev_conf.rxmode.max_rx_pkt_len = +RTE_ETHER_MTU + overhead_len; + +/* +* Workaround: only adapt to RTE_ETHER_MAX_LEN as +* jumbo frame condition. +*/ +if (port->dev_conf.rxmode.max_rx_pkt_len >RTE_ETHER_MAX_LEN ) { + port->dev_conf.rxmode.offloads |= +DEV_RX_OFFLOAD_JUMBO_FRAME ; + } +if (!(port->dev_info.tx_offload_capa &DEV_TX_OFFLOAD_MBUF_FAST_FREE )) port->dev_conf.txmode.offloads &=
Signature · 1 line
2.17.1
Re: [dpdk-dev] [PATCH v7 1/1] app/testpmd: fix max rx packet length for VLAN packets
Quoted 35 lines · SteveX Yang
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped.
Fixes 35b2d13fd6fd ("net: add rte prefix to ether defines")Signed-off-by SteveX Yang <[email protected]>--- app/test-pmd/testpmd.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)app/test-pmd/testpmd.c +9
-0@@ -1421,6 +1421,7 @@ init_config(void)struct rte_gro_param gro_param;uint32_t gso_types;uint16_t data_size; +uint16_t overhead_len;bool warning =0 ;int k;int ret;@@ -1457,6 +1458,25 @@ init_config(void)rte_exit (EXIT_FAILURE ,"rte_eth_dev_info_get() failed\n" ); +/* Update the max_rx_pkt_len to have MTU as RTE_ETHER_MTU */ +if (port->dev_info.max_rx_pktlen && port->dev_info.max_mtu) + overhead_len = port->dev_info.max_rx_pktlen - + port->dev_info.max_mtu; +else + overhead_len =RTE_ETHER_HDR_LEN +RTE_ETHER_CRC_LEN ; + + port->dev_conf.rxmode.max_rx_pkt_len =
app/test-pmd/testpmd.c init_config(void) · line 1478
Quoted 10 lines
app/test-pmd/testpmd.c +10
-0+RTE_ETHER_MTU + overhead_len; + +/* +* Workaround: only adapt to RTE_ETHER_MAX_LEN as +* jumbo frame condition. +*/ +if (port->dev_conf.rxmode.max_rx_pkt_len >RTE_ETHER_MAX_LEN ) { + port->dev_conf.rxmode.offloads |= +DEV_RX_OFFLOAD_JUMBO_FRAME ; + }
I think this jumbo frame set can be dropped, above just set the frame size as "RTE_ETHER_MTU + overhead_len", so it can't be jumbo frame, right?
v8 cover fix default max mtu size when device configured
In reply to SteveX YangUpdate the max_rx_pkt_len to have MTU as RTE_ETHER_MTU.
v8:
* update workaround comment;
* add deprecation for ethdev;
v7:
* drop patch 2 due to Jumbo frame flag issue;
v6:
* change the max_rx_pkt_len in the init_config of testpmd;
* change the mtu value in the rte_ethdev;
v5:
* update comments and commit messages;
v4:
* add the adjust condition for max_rx_pkt_len;
v3:
* change the i40evf relative code;
v2:
* change the max_rx_pkt_len via mtu_set ops;
SteveX Yang (2):
app/testpmd: fix max rx packet length for VLAN packets
doc: annouce deprecation of jumbo frame flag condition
app/test-pmd/testpmd.c | 23 +++++++++++++++++++++++ doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++ 2 files changed, 35 insertions(+)
Signature · 1 line
2.17.1
PATCH v8 1/2 app/testpmd: fix max rx packet length for VLAN packets
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped.
--- app/test-pmd/testpmd.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+)
app/test-pmd/testpmd.c +23 -0
@@ -1421,6 +1421,7 @@ init_config(void)struct rte_gro_param gro_param;uint32_t gso_types;uint16_t data_size; +uint16_t overhead_len;bool warning =0 ;int k;int ret;
@@ -1457,6 +1458,28 @@ init_config(void)rte_exit (EXIT_FAILURE ,"rte_eth_dev_info_get() failed\n" ); +/* Update the max_rx_pkt_len to have MTU as RTE_ETHER_MTU */ +if (port->dev_info.max_rx_pktlen && port->dev_info.max_mtu) + overhead_len = port->dev_info.max_rx_pktlen - + port->dev_info.max_mtu; +else + overhead_len =RTE_ETHER_HDR_LEN +RTE_ETHER_CRC_LEN ; + + port->dev_conf.rxmode.max_rx_pkt_len = +RTE_ETHER_MTU + overhead_len; + +/* +* This is workaround to avoid resize max rx packet len. +* Ethdev assumes jumbo frame size must be greater than +* RTE_ETHER_MAX_LEN, and will resize 'max_rx_pkt_len' to +* default value when it is greater than RTE_ETHER_MAX_LEN +* for normal frame. +*/ +if (port->dev_conf.rxmode.max_rx_pkt_len >RTE_ETHER_MAX_LEN ) { + port->dev_conf.rxmode.offloads |= +DEV_RX_OFFLOAD_JUMBO_FRAME ; + } +if (!(port->dev_info.tx_offload_capa &DEV_TX_OFFLOAD_MBUF_FAST_FREE )) port->dev_conf.txmode.offloads &=
Signature · 1 line
2.17.1
Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets
Quoted 7 lines · SteveX Yang
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped.
Fixes 35b2d13fd6fd ("net: add rte prefix to ether defines")Signed-off-by SteveX Yang <[email protected]>
Ferruh Yigit
AppliedRe: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets
Quoted 11 lines · Ferruh Yigit
Quoted 7 lines · SteveX Yang
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped.
Fixes 35b2d13fd6fd ("net: add rte prefix to ether defines")Signed-off-by SteveX Yang <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>
Applied to dpdk-next-net/main, thanks.
only 1/2 applied since discussion is going on for 2/2.
Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets
03/11/2020 14:29, Ferruh Yigit:
Quoted 8 lines · Ferruh Yigit
Quoted 7 lines · SteveX Yang
Quoted 6 lines
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped.
Fixes 35b2d13fd6fd ("net: add rte prefix to ether defines")
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by SteveX Yang <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>Applied to dpdk-next-net/main, thanks.
only 1/2 applied since discussion is going on for 2/2.
I'm not sure this testpmd change is good.
Reminder: testpmd is for testing the PMDs.
Don't we want to see VLAN packets dropped in the case described above?
Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets
Quoted 13 lines · Thomas Monjalon
03/11/2020 14:29, Ferruh Yigit:
Quoted 12 lines · Ferruh Yigit
Quoted 10 lines · SteveX Yang
Quoted 7 lines
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped.
Fixes 35b2d13fd6fd ("net: add rte prefix to ether defines")Signed-off-by SteveX Yang <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>
Quoted 9 lines
Quoted 3 lines
Applied to dpdk-next-net/main, thanks.
only 1/2 applied since discussion is going on for 2/2.
I'm not sure this testpmd change is good.
Reminder: testpmd is for testing the PMDs.
Don't we want to see VLAN packets dropped in the case described above?
The patch set 'max_rx_pkt_len' in a way to make MTU 1500 for all PMDs,
otherwise testpmd set hard-coded 'RTE_ETHER_MAX_LEN' value, which makes MTU between 1492-1500 depending on PMD.
It is application responsibility to provide correct 'max_rx_pkt_len'.
I guess the original intention was to set MTU as 1500 but was not correct for all PMDs and this patch is fixing it.
The same problem in the ethdev, (assuming 'RTE_ETHER_MAX_LEN' will give MTU 1500), the other patch in the set is to fix it later.
Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets
04/11/2020 18:07, Ferruh Yigit:
Quoted 28 lines · Thomas Monjalon
Quoted 13 lines
03/11/2020 14:29, Ferruh Yigit:
Quoted 12 lines · Ferruh Yigit
Quoted 10 lines · SteveX Yang
Quoted 7 lines
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped.
Fixes 35b2d13fd6fd ("net: add rte prefix to ether defines")Signed-off-by SteveX Yang <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>Quoted 9 lines
Quoted 3 lines
Applied to dpdk-next-net/main, thanks.
only 1/2 applied since discussion is going on for 2/2.
I'm not sure this testpmd change is good.
Reminder: testpmd is for testing the PMDs.
Don't we want to see VLAN packets dropped in the case described above?The patch set '
max_rx_pkt_len' in a way to make MTU 1500 for all PMDs, otherwise testpmd set hard-coded 'RTE_ETHER_MAX_LEN' value, which makes MTU between 1492-1500 depending on PMD.
Quoted 6 lines
It is application responsibility to provide correct '
max_rx_pkt_len'. I guess the original intention was to set MTU as 1500 but was not correct for all PMDs and this patch is fixing it.The same problem in the ethdev, (assuming '
RTE_ETHER_MAX_LEN' will give MTU 1500), the other patch in the set is to fix it later.
OK but the testpmd patch is just hiding the issue, isn't it?
Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets
Quoted 29 lines · Thomas Monjalon
04/11/2020 18:07, Ferruh Yigit:
Quoted 28 lines · Thomas Monjalon
Quoted 13 lines
03/11/2020 14:29, Ferruh Yigit:
Quoted 12 lines · Ferruh Yigit
Quoted 10 lines · SteveX Yang
Quoted 7 lines
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped.
Fixes 35b2d13fd6fd ("net: add rte prefix to ether defines")Signed-off-by SteveX Yang <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>Quoted 9 lines
Quoted 3 lines
Applied to dpdk-next-net/main, thanks.
only 1/2 applied since discussion is going on for 2/2.
I'm not sure this testpmd change is good.
Reminder: testpmd is for testing the PMDs.
Don't we want to see VLAN packets dropped in the case described above?The patch set '
max_rx_pkt_len' in a way to make MTU 1500 for all PMDs, otherwise testpmd set hard-coded 'RTE_ETHER_MAX_LEN' value, which makes MTU between 1492-1500 depending on PMD.
Quoted 9 lines
Quoted 6 lines
It is application responsibility to provide correct '
max_rx_pkt_len'. I guess the original intention was to set MTU as 1500 but was not correct for all PMDs and this patch is fixing it.The same problem in the ethdev, (assuming '
RTE_ETHER_MAX_LEN' will give MTU 1500), the other patch in the set is to fix it later.OK but the testpmd patch is just hiding the issue, isn't it?
I don't think so, issue was application (testpmd) setting the 'max_rx_pkt_len' wrong.
What is hidden?
Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets
04/11/2020 21:19, Ferruh Yigit:
Quoted 37 lines · Thomas Monjalon
Quoted 36 lines
04/11/2020 18:07, Ferruh Yigit:
Quoted 34 lines · Thomas Monjalon
Quoted 13 lines
03/11/2020 14:29, Ferruh Yigit:
Quoted 12 lines · Ferruh Yigit
Quoted 10 lines · SteveX Yang
Quoted 7 lines
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped.
Fixes 35b2d13fd6fd ("net: add rte prefix to ether defines")Signed-off-by SteveX Yang <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>Quoted 9 lines
Quoted 3 lines
Applied to dpdk-next-net/main, thanks.
only 1/2 applied since discussion is going on for 2/2.
I'm not sure this testpmd change is good.
Reminder: testpmd is for testing the PMDs.
Don't we want to see VLAN packets dropped in the case described above?The patch set '
max_rx_pkt_len' in a way to make MTU 1500 for all PMDs, otherwise testpmd set hard-coded 'RTE_ETHER_MAX_LEN' value, which makes MTU between 1492-1500 depending on PMD.It is application responsibility to provide correct '
max_rx_pkt_len'. I guess the original intention was to set MTU as 1500 but was not correct for all PMDs and this patch is fixing it.The same problem in the ethdev, (assuming '
RTE_ETHER_MAX_LEN' will give MTU 1500), the other patch in the set is to fix it later.
Quoted 7 lines
Quoted 2 lines
OK but the testpmd patch is just hiding the issue, isn't it?
I don't think so, issue was application (testpmd) setting the '
max_rx_pkt_len' wrong.What is hidden?
I was looking for adding a helper in ethdev API. But I think I can agree with your way of thinking.
Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets
Quoted 41 lines · Thomas Monjalon
04/11/2020 21:19, Ferruh Yigit:
Quoted 40 lines · Thomas Monjalon
Quoted 38 lines
04/11/2020 18:07, Ferruh Yigit:
Quoted 28 lines · Thomas Monjalon
Quoted 13 lines
03/11/2020 14:29, Ferruh Yigit:
Quoted 12 lines · Ferruh Yigit
Quoted 10 lines · SteveX Yang
Quoted 7 lines
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped.
Fixes 35b2d13fd6fd ("net: add rte prefix to ether defines")Signed-off-by SteveX Yang <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>Quoted 9 lines
Quoted 3 lines
Applied to dpdk-next-net/main, thanks.
only 1/2 applied since discussion is going on for 2/2.
I'm not sure this testpmd change is good.
Reminder: testpmd is for testing the PMDs.
Don't we want to see VLAN packets dropped in the case described above?The patch set '
max_rx_pkt_len' in a way to make MTU 1500 for all PMDs, otherwise testpmd set hard-coded 'RTE_ETHER_MAX_LEN' value, which makes MTU between 1492-1500 depending on PMD.Quoted 6 lines
It is application responsibility to provide correct '
max_rx_pkt_len'. I guess the original intention was to set MTU as 1500 but was not correct for all PMDs and this patch is fixing it.The same problem in the ethdev, (assuming '
RTE_ETHER_MAX_LEN' will give MTU 1500), the other patch in the set is to fix it later.OK but the testpmd patch is just hiding the issue, isn't it?
Quoted 8 lines
Quoted 4 lines
I don't think so, issue was application (testpmd) setting the '
max_rx_pkt_len' wrong.What is hidden?
I was looking for adding a helper in ethdev API. But I think I can agree with your way of thinking.
The patch breaks running testpmd on Virtio-Net because the driver populates dev_info.max_rx_pktlen but keeps dev_info.max_mtu equal to UINT16_MAX as it was filled in by ethdev. As the result:
Ethdev port_id=0 max_rx_pkt_len 11229 > max valid value 9728 Fail to configure port 0
A message that is not in the archive (sent off-list or not yet received): DM6PR11MB43622CC5DF485DD034037CD3F9EE0@DM6PR11MB4362.namprd11.prod.outlook.com
Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets
Quoted 74 lines · SteveX
Quoted 74 lines
-----Original Message-----
From: Andrew Rybchenko <[email protected]>
Sent: Thursday, November 5, 2020 4:54 PM
To: Thomas Monjalon <[email protected]>; Yang, SteveX <[email protected]>; Yigit, Ferruh <[email protected]>
Cc: [email protected]; Ananyev, Konstantin <[email protected]>; Xing, Beilei <[email protected]>; Lu, Wenzhuo <[email protected]>; Iremonger, Bernard <[email protected]>; Yang, Qiming <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packetsQuoted 25 lines · Thomas Monjalon
04/11/2020 21:19, Ferruh Yigit:
Quoted 24 lines · Thomas Monjalon
Quoted 23 lines
04/11/2020 18:07, Ferruh Yigit:
Quoted 22 lines · Thomas Monjalon
Quoted 21 lines
03/11/2020 14:29, Ferruh Yigit:
Quoted 8 lines · Ferruh Yigit
Quoted 7 lines · SteveX Yang
Quoted 6 lines
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped.
Fixes 35b2d13fd6fd ("net: add rte prefix to ether defines")Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by SteveX Yang <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>Applied to dpdk-next-net/main, thanks.
only 1/2 applied since discussion is going on for 2/2.
I'm not sure this testpmd change is good.
Reminder: testpmd is for testing the PMDs.
Don't we want to see VLAN packets dropped in the case describedabove?
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
The patch set '
max_rx_pkt_len' in a way to make MTU 1500 for all PMDs, otherwise testpmd set hard-coded 'RTE_ETHER_MAX_LEN'value,
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
which makes MTU between 1492-1500 depending on PMD.
It is application responsibility to provide correct '
max_rx_pkt_len'. I guess the original intention was to set MTU as 1500 but was not correct for all PMDs and this patch is fixing it.The same problem in the ethdev, (assuming '
RTE_ETHER_MAX_LEN'will
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
give MTU 1500), the other patch in the set is to fix it later.
OK but the testpmd patch is just hiding the issue, isn't it?
I don't think so, issue was application (testpmd) setting the
'
max_rx_pkt_len'Quoted 7 lines
Quoted 3 lines
wrong.
What is hidden?
I was looking for adding a helper in ethdev API. But I think I can agree with your way of thinking.
The patch breaks running testpmd on Virtio-Net because the driver populates dev_info.max_rx_pktlen but keeps dev_info.max_mtu equal to
UINT16_MAXas it was filled in by ethdev. As the result:
Quoted 6 lines
Quoted 2 lines
Ethdev port_id=0
max_rx_pkt_len11229 > max valid value 9728 Fail to configure port 0Similar issue occurred for other net PMD drivers which use default
max_mtu(UINT16_MAX). More strict checking condition will be added within new patch sooner.
:(
For drivers not providing 'max_mtu' information explicitly, the default 'UINT16_MAX' is set in ethdev layer. This prevents calculating PMD specific 'overhead' and the logic in the patch is broken.
Indeed this makes inconsistency in the driver too, for example for virtio, it claims 'max_rx_pktlen' as "VIRTIO_MAX_RX_PKTLEN (9728)" and 'max_mtu' as UINT16_MAX. From 'virtio_mtu_set()' we can see the real limit is 'VIRTIO_MAX_RX_PKTLEN'.
When PMDs fixed, the logic in this patch can work but not sure if post -rc2 is good time to start fixing the PMDs.
Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets
05/11/2020 11:37, Ferruh Yigit:
Quoted 89 lines · SteveX
Quoted 74 lines
Quoted 74 lines
-----Original Message-----
From: Andrew Rybchenko <[email protected]>
Sent: Thursday, November 5, 2020 4:54 PM
To: Thomas Monjalon <[email protected]>; Yang, SteveX <[email protected]>; Yigit, Ferruh <[email protected]>
Cc: [email protected]; Ananyev, Konstantin <[email protected]>; Xing, Beilei <[email protected]>; Lu, Wenzhuo <[email protected]>; Iremonger, Bernard <[email protected]>; Yang, Qiming <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packetsQuoted 25 lines · Thomas Monjalon
04/11/2020 21:19, Ferruh Yigit:
Quoted 24 lines · Thomas Monjalon
Quoted 23 lines
04/11/2020 18:07, Ferruh Yigit:
Quoted 22 lines · Thomas Monjalon
Quoted 21 lines
03/11/2020 14:29, Ferruh Yigit:
Quoted 8 lines · Ferruh Yigit
Quoted 7 lines · SteveX Yang
Quoted 6 lines
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped.
Fixes 35b2d13fd6fd ("net: add rte prefix to ether defines")Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by SteveX Yang <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>Applied to dpdk-next-net/main, thanks.
only 1/2 applied since discussion is going on for 2/2.
I'm not sure this testpmd change is good.
Reminder: testpmd is for testing the PMDs.
Don't we want to see VLAN packets dropped in the case describedabove?
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
The patch set '
max_rx_pkt_len' in a way to make MTU 1500 for all PMDs, otherwise testpmd set hard-coded 'RTE_ETHER_MAX_LEN'value,
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
which makes MTU between 1492-1500 depending on PMD.
It is application responsibility to provide correct '
max_rx_pkt_len'. I guess the original intention was to set MTU as 1500 but was not correct for all PMDs and this patch is fixing it.The same problem in the ethdev, (assuming '
RTE_ETHER_MAX_LEN'will
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
give MTU 1500), the other patch in the set is to fix it later.
OK but the testpmd patch is just hiding the issue, isn't it?
I don't think so, issue was application (testpmd) setting the
'
max_rx_pkt_len'Quoted 7 lines
Quoted 3 lines
wrong.
What is hidden?
I was looking for adding a helper in ethdev API. But I think I can agree with your way of thinking.
The patch breaks running testpmd on Virtio-Net because the driver populates dev_info.max_rx_pktlen but keeps dev_info.max_mtu equal to
UINT16_MAXas it was filled in by ethdev. As the result:Quoted 6 lines
Quoted 2 lines
Ethdev port_id=0
max_rx_pkt_len11229 > max valid value 9728 Fail to configure port 0Similar issue occurred for other net PMD drivers which use default
max_mtu(UINT16_MAX). More strict checking condition will be added within new patch sooner.:(
For drivers not providing '
max_mtu' information explicitly, the default 'UINT16_MAX' is set in ethdev layer.
This prevents calculating PMD specific 'overhead' and the logic in the patch is broken.
Quoted 7 lines
Indeed this makes inconsistency in the driver too, for example for virtio, it claims '
max_rx_pktlen' as "VIRTIO_MAX_RX_PKTLEN(9728)" and 'max_mtu' asUINT16_MAX. From 'virtio_mtu_set()' we can see the real limit is 'VIRTIO_MAX_RX_PKTLEN'.When PMDs fixed, the logic in this patch can work but not sure if post -rc2 is good time to start fixing the PMDs.
Do you suggest revert is the best choice here?
Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets
+ more maintainers Cc'ed
We have a critical issue with testpmd in -rc2.
It is blocking a lot of testing.
Would be good to do a -rc3 today.
Please see below.
05/11/2020 11:44, Thomas Monjalon:
Quoted 96 lines
05/11/2020 11:37, Ferruh Yigit:
Quoted 86 lines · SteveX
Quoted 71 lines
From: Andrew Rybchenko <[email protected]>
Quoted 70 lines
Sent: Thursday, November 5, 2020 4:54 PM
To: Thomas Monjalon <[email protected]>; Yang, SteveX <[email protected]>; Yigit, Ferruh <[email protected]>
Cc: [email protected]; Ananyev, Konstantin <[email protected]>; Xing, Beilei <[email protected]>; Lu, Wenzhuo <[email protected]>; Iremonger, Bernard <[email protected]>; Yang, Qiming <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packetsQuoted 25 lines · Thomas Monjalon
04/11/2020 21:19, Ferruh Yigit:
Quoted 24 lines · Thomas Monjalon
Quoted 23 lines
04/11/2020 18:07, Ferruh Yigit:
Quoted 22 lines · Thomas Monjalon
Quoted 21 lines
03/11/2020 14:29, Ferruh Yigit:
Quoted 8 lines · Ferruh Yigit
Quoted 7 lines · SteveX Yang
Quoted 6 lines
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped.
Fixes 35b2d13fd6fd ("net: add rte prefix to ether defines")Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by SteveX Yang <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>Applied to dpdk-next-net/main, thanks.
only 1/2 applied since discussion is going on for 2/2.
I'm not sure this testpmd change is good.
Reminder: testpmd is for testing the PMDs.
Don't we want to see VLAN packets dropped in the case describedabove?
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
The patch set '
max_rx_pkt_len' in a way to make MTU 1500 for all PMDs, otherwise testpmd set hard-coded 'RTE_ETHER_MAX_LEN'value,
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
which makes MTU between 1492-1500 depending on PMD.
It is application responsibility to provide correct '
max_rx_pkt_len'. I guess the original intention was to set MTU as 1500 but was not correct for all PMDs and this patch is fixing it.The same problem in the ethdev, (assuming '
RTE_ETHER_MAX_LEN'will
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
give MTU 1500), the other patch in the set is to fix it later.
OK but the testpmd patch is just hiding the issue, isn't it?
I don't think so, issue was application (testpmd) setting the
'
max_rx_pkt_len'Quoted 7 lines
Quoted 3 lines
wrong.
What is hidden?
I was looking for adding a helper in ethdev API. But I think I can agree with your way of thinking.
The patch breaks running testpmd on Virtio-Net because the driver populates dev_info.max_rx_pktlen but keeps dev_info.max_mtu equal to
UINT16_MAXas it was filled in by ethdev. As the result:Quoted 6 lines
Quoted 2 lines
Ethdev port_id=0
max_rx_pkt_len11229 > max valid value 9728 Fail to configure port 0Similar issue occurred for other net PMD drivers which use default
max_mtu(UINT16_MAX). More strict checking condition will be added within new patch sooner.:(
For drivers not providing '
max_mtu' information explicitly, the default 'UINT16_MAX' is set in ethdev layer.
This prevents calculating PMD specific 'overhead' and the logic in the patch is broken.Quoted 7 lines
Indeed this makes inconsistency in the driver too, for example for virtio, it claims '
max_rx_pktlen' as "VIRTIO_MAX_RX_PKTLEN(9728)" and 'max_mtu' asUINT16_MAX. From 'virtio_mtu_set()' we can see the real limit is 'VIRTIO_MAX_RX_PKTLEN'.When PMDs fixed, the logic in this patch can work but not sure if post -rc2 is good time to start fixing the PMDs.
Do you suggest revert is the best choice here?
Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets
Quoted 106 lines · Thomas Monjalon
+ more maintainers Cc'ed
We have a critical issue with testpmd in -rc2.
It is blocking a lot of testing.
Would be good to do a -rc3 today.
Please see below.05/11/2020 11:44, Thomas Monjalon:
Quoted 96 lines
05/11/2020 11:37, Ferruh Yigit:
Quoted 86 lines · SteveX
Quoted 71 lines
From: Andrew Rybchenko <[email protected]>
Quoted 70 lines
Sent: Thursday, November 5, 2020 4:54 PM
To: Thomas Monjalon <[email protected]>; Yang, SteveX <[email protected]>; Yigit, Ferruh <[email protected]>
Cc: [email protected]; Ananyev, Konstantin <[email protected]>; Xing, Beilei <[email protected]>; Lu, Wenzhuo <[email protected]>; Iremonger, Bernard <[email protected]>; Yang, Qiming <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packetsQuoted 25 lines · Thomas Monjalon
04/11/2020 21:19, Ferruh Yigit:
Quoted 24 lines · Thomas Monjalon
Quoted 23 lines
04/11/2020 18:07, Ferruh Yigit:
Quoted 22 lines · Thomas Monjalon
Quoted 21 lines
03/11/2020 14:29, Ferruh Yigit:
Quoted 8 lines · Ferruh Yigit
Quoted 7 lines · SteveX Yang
Quoted 6 lines
When the max rx packet length is smaller than the sum of mtu
size and ether overhead size, it should be enlarged, otherwise
the VLAN packets will be dropped.Fixes: 35b2d13fd6fd ("net: add rte prefix to ether defines")
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by: SteveX Yang <[email protected]>
Reviewed-by Ferruh Yigit <[email protected]>Applied to dpdk-next-net/main, thanks.
only 1/2 applied since discussion is going on for 2/2.
I'm not sure this testpmd change is good.
Reminder: testpmd is for testing the PMDs.
Don't we want to see VLAN packets dropped in the case describedabove?
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
The patch set '
max_rx_pkt_len' in a way to make MTU 1500 for all PMDs, otherwise testpmd set hard-coded 'RTE_ETHER_MAX_LEN'value,
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
which makes MTU between 1492-1500 depending on PMD.
It is application responsibility to provide correct '
max_rx_pkt_len'. I guess the original intention was to set MTU as 1500 but was not correct for all PMDs and this patch is fixing it.The same problem in the ethdev, (assuming '
RTE_ETHER_MAX_LEN'will
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
give MTU 1500), the other patch in the set is to fix it later.
OK but the testpmd patch is just hiding the issue, isn't it?
I don't think so, issue was application (testpmd) setting the
'
max_rx_pkt_len'Quoted 7 lines
Quoted 3 lines
wrong.
What is hidden?
I was looking for adding a helper in ethdev API. But I think I can agree with your way of thinking.
The patch breaks running testpmd on Virtio-Net because the driver populates dev_info.max_rx_pktlen but keeps dev_info.max_mtu equal to
UINT16_MAXas it was filled in by ethdev. As the result:Quoted 6 lines
Quoted 2 lines
Ethdev port_id=0
max_rx_pkt_len11229 > max valid value 9728 Fail to configure port 0Similar issue occurred for other net PMD drivers which use default
max_mtu(UINT16_MAX). More strict checking condition will be added within new patch sooner.:(
For drivers not providing '
max_mtu' information explicitly, the default 'UINT16_MAX' is set in ethdev layer.
This prevents calculating PMD specific 'overhead' and the logic in the patch is broken.Quoted 7 lines
Indeed this makes inconsistency in the driver too, for example for virtio, it claims '
max_rx_pktlen' as "VIRTIO_MAX_RX_PKTLEN(9728)" and 'max_mtu' asUINT16_MAX. From 'virtio_mtu_set()' we can see the real limit is 'VIRTIO_MAX_RX_PKTLEN'.When PMDs fixed, the logic in this patch can work but not sure if post -rc2 is good time to start fixing the PMDs.
Do you suggest revert is the best choice here?
(copy/pasting previous reply to this eamil)
One option is revert, but than the issue this patch is trying to fix still remain.
Other option is the extend the patch as Steve sent [1], the check there is more like workaround in application, so not nice to have them, but with extending the deprecation notice (other patch in this patchset) to fix PMDs too in next release, I would be OK to have these checks. What do you think?
Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets
Quoted 108 lines · Ferruh Yigit
Quoted 106 lines · Thomas Monjalon
+ more maintainers Cc'ed
We have a critical issue with testpmd in -rc2.
It is blocking a lot of testing.
Would be good to do a -rc3 today.
Please see below.05/11/2020 11:44, Thomas Monjalon:
Quoted 96 lines
05/11/2020 11:37, Ferruh Yigit:
Quoted 86 lines · SteveX
Quoted 71 lines
From: Andrew Rybchenko <[email protected]>
Quoted 70 lines
Sent: Thursday, November 5, 2020 4:54 PM
To: Thomas Monjalon <[email protected]>; Yang, SteveX <[email protected]>; Yigit, Ferruh <[email protected]>
Cc: [email protected]; Ananyev, Konstantin <[email protected]>; Xing, Beilei <[email protected]>; Lu, Wenzhuo <[email protected]>; Iremonger, Bernard <[email protected]>; Yang, Qiming <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packetsQuoted 25 lines · Thomas Monjalon
04/11/2020 21:19, Ferruh Yigit:
Quoted 24 lines · Thomas Monjalon
Quoted 23 lines
04/11/2020 18:07, Ferruh Yigit:
Quoted 22 lines · Thomas Monjalon
Quoted 21 lines
03/11/2020 14:29, Ferruh Yigit:
Quoted 8 lines · Ferruh Yigit
Quoted 7 lines · SteveX Yang
When the max rx packet length is smaller than the sum of mtu
size and ether overhead size, it should be enlarged, otherwise
the VLAN packets will be dropped.Fixes: 35b2d13fd6fd ("net: add rte prefix to ether defines")
Quoted 7 lines
Quoted 3 lines
Signed-off-by: SteveX Yang <[email protected]>
Reviewed-by: Ferruh Yigit <[email protected]>
Applied to dpdk-next-net/main, thanks.
only 1/2 applied since discussion is going on for 2/2.
I'm not sure this testpmd change is good.
Reminder: testpmd is for testing the PMDs.
Don't we want to see VLAN packets dropped in the case describedabove?
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
The patch set '
max_rx_pkt_len' in a way to make MTU 1500 for all PMDs, otherwise testpmd set hard-coded 'RTE_ETHER_MAX_LEN'value,
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
which makes MTU between 1492-1500 depending on PMD.
It is application responsibility to provide correct '
max_rx_pkt_len'. I guess the original intention was to set MTU as 1500 but was not correct for all PMDs and this patch is fixing it.The same problem in the ethdev, (assuming '
RTE_ETHER_MAX_LEN'will
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
give MTU 1500), the other patch in the set is to fix it later.
OK but the testpmd patch is just hiding the issue, isn't it?
I don't think so, issue was application (testpmd) setting the
'
max_rx_pkt_len'Quoted 7 lines
Quoted 3 lines
wrong.
What is hidden?
I was looking for adding a helper in ethdev API. But I think I can agree with your way of thinking.
The patch breaks running testpmd on Virtio-Net because the driver populates dev_info.max_rx_pktlen but keeps dev_info.max_mtu equal to
UINT16_MAXas it was filled in by ethdev. As the result:Quoted 6 lines
Quoted 2 lines
Ethdev port_id=0
max_rx_pkt_len11229 > max valid value 9728 Fail to configure port 0Similar issue occurred for other net PMD drivers which use default
max_mtu(UINT16_MAX). More strict checking condition will be added within new patch sooner.:(
For drivers not providing '
max_mtu' information explicitly, the default 'UINT16_MAX' is set in ethdev layer.
This prevents calculating PMD specific 'overhead' and the logic in the patch is broken.Quoted 7 lines
Indeed this makes inconsistency in the driver too, for example for virtio, it claims '
max_rx_pktlen' as "VIRTIO_MAX_RX_PKTLEN(9728)" and 'max_mtu' asUINT16_MAX. From 'virtio_mtu_set()' we can see the real limit is 'VIRTIO_MAX_RX_PKTLEN'.When PMDs fixed, the logic in this patch can work but not sure if post -rc2 is good time to start fixing the PMDs.
Do you suggest revert is the best choice here?
Quoted 8 lines
(copy/pasting previous reply to this eamil)
One option is revert, but than the issue this patch is trying to fix still remain.
Other option is the extend the patch as Steve sent [1], the check there is more like workaround in application, so not nice to have them, but with extending the deprecation notice (other patch in this patchset) to fix PMDs too in next release, I would be OK to have these checks. What do you think?
+1 for this second option.
I think it is ok to have a workaround to fix an issue. Clarifying and uniformizing the ethdev/drivers behavior in that area can come in a second time.
Quoted 2 lines
Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets
With this change, the bnxt driver fails to initialize under testpmd:
Configuring Port 0 (socket 0)
Port 0 failed to enable Rx offload JUMBO_FRAME
Fail to configure port 0
EAL: Error - exiting with code: 1
It appears that the cause is this bit of code in bnxt_ethdev.c:
if (bp->eth_dev->data->mtu > RTE_ETHER_MTU) {
bp->eth_dev->data->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_JUMBO_FRAME;
bp->flags |= BNXT_FLAG_JUMBO;
} else {
bp->eth_dev->data->dev_conf.rxmode.offloads &=
~DEV_RX_OFFLOAD_JUMBO_FRAME;
bp->flags &= ~BNXT_FLAG_JUMBO;
}Should a PMD be overriding this offload on dev_start()? Or should this test be changed to be based on max_rx_pkt_len instead of mtu?
Thanks,
Lance
Quoted 127 lines · Olivier Matz
Quoted 108 lines · Ferruh Yigit
Quoted 106 lines · Thomas Monjalon
+ more maintainers Cc'ed
We have a critical issue with testpmd in -rc2.
It is blocking a lot of testing.
Would be good to do a -rc3 today.
Please see below.05/11/2020 11:44, Thomas Monjalon:
Quoted 96 lines
05/11/2020 11:37, Ferruh Yigit:
Quoted 86 lines · SteveX
Quoted 71 lines
From: Andrew Rybchenko <[email protected]>
Quoted 70 lines
Sent: Thursday, November 5, 2020 4:54 PM
To: Thomas Monjalon <[email protected]>; Yang, SteveX <[email protected]>; Yigit, Ferruh <[email protected]>
Cc: [email protected]; Ananyev, Konstantin <[email protected]>; Xing, Beilei <[email protected]>; Lu, Wenzhuo <[email protected]>; Iremonger, Bernard <[email protected]>; Yang, Qiming <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packetsQuoted 25 lines · Thomas Monjalon
04/11/2020 21:19, Ferruh Yigit:
Quoted 24 lines · Thomas Monjalon
Quoted 23 lines
04/11/2020 18:07, Ferruh Yigit:
Quoted 22 lines · Thomas Monjalon
Quoted 21 lines
03/11/2020 14:29, Ferruh Yigit:
Quoted 15 lines · Ferruh Yigit
On 11/2/2020 8:52 AM, SteveX Yang wrote:
When the max rx packet length is smaller than the sum of mtu
size and ether overhead size, it should be enlarged, otherwise
the VLAN packets will be dropped.Fixes: 35b2d13fd6fd ("net: add rte prefix to ether defines")
Signed-off-by: SteveX Yang <[email protected]>
Reviewed-by: Ferruh Yigit <[email protected]>
Applied to dpdk-next-net/main, thanks.
only 1/2 applied since discussion is going on for 2/2.
I'm not sure this testpmd change is good.
Reminder: testpmd is for testing the PMDs.
Don't we want to see VLAN packets dropped in the case describedabove?
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
The patch set '
max_rx_pkt_len' in a way to make MTU 1500 for all PMDs, otherwise testpmd set hard-coded 'RTE_ETHER_MAX_LEN'value,
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
which makes MTU between 1492-1500 depending on PMD.
It is application responsibility to provide correct '
max_rx_pkt_len'. I guess the original intention was to set MTU as 1500 but was not correct for all PMDs and this patch is fixing it.The same problem in the ethdev, (assuming '
RTE_ETHER_MAX_LEN'will
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
give MTU 1500), the other patch in the set is to fix it later.
OK but the testpmd patch is just hiding the issue, isn't it?
I don't think so, issue was application (testpmd) setting the
'
max_rx_pkt_len'Quoted 7 lines
Quoted 3 lines
wrong.
What is hidden?
I was looking for adding a helper in ethdev API. But I think I can agree with your way of thinking.
The patch breaks running testpmd on Virtio-Net because the driver populates dev_info.max_rx_pktlen but keeps dev_info.max_mtu equal to
UINT16_MAXas it was filled in by ethdev. As the result:Quoted 6 lines
Quoted 2 lines
Ethdev port_id=0
max_rx_pkt_len11229 > max valid value 9728 Fail to configure port 0Similar issue occurred for other net PMD drivers which use default
max_mtu(UINT16_MAX). More strict checking condition will be added within new patch sooner.:(
For drivers not providing '
max_mtu' information explicitly, the default 'UINT16_MAX' is set in ethdev layer.
This prevents calculating PMD specific 'overhead' and the logic in the patch is broken.Quoted 7 lines
Indeed this makes inconsistency in the driver too, for example for virtio, it claims '
max_rx_pktlen' as "VIRTIO_MAX_RX_PKTLEN(9728)" and 'max_mtu' asUINT16_MAX. From 'virtio_mtu_set()' we can see the real limit is 'VIRTIO_MAX_RX_PKTLEN'.When PMDs fixed, the logic in this patch can work but not sure if post -rc2 is good time to start fixing the PMDs.
Do you suggest revert is the best choice here?
Quoted 8 lines
(copy/pasting previous reply to this eamil)
One option is revert, but than the issue this patch is trying to fix still remain.
Other option is the extend the patch as Steve sent [1], the check there is more like workaround in application, so not nice to have them, but with extending the deprecation notice (other patch in this patchset) to fix PMDs too in next release, I would be OK to have these checks. What do you think?
+1 for this second option.
I think it is ok to have a workaround to fix an issue. Clarifying and uniformizing the ethdev/drivers behavior in that area can come in a second time.
Quoted 2 lines
Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets
Quoted 19 lines · Lance Richardson
With this change, the bnxt driver fails to initialize under testpmd:
Configuring Port 0 (socket 0)
Port 0 failed to enable Rx offloadJUMBO_FRAME
Fail to configure port 0
EAL: Error - exiting with code: 1It appears that the cause is this bit of code in
bnxt_ethdev.c:if (bp->eth_dev->data->mtu > RTE_ETHER_MTU) { bp->eth_dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME; bp->flags |= BNXT_FLAG_JUMBO; } else { bp->eth_dev->data->dev_conf.rxmode.offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME; bp->flags &= ~BNXT_FLAG_JUMBO; }
Quoted 3 lines
Should a PMD be overriding this offload on
dev_start()? Or should this test be changed to be based onmax_rx_pkt_leninstead of mtu?
I think testing 'mtu' is correct thing to do, problem looks somewhere else,
First the code cause problem in the driver looks in another place, following in 'bnxt_mtu_set_op()':
if (new_mtu > RTE_ETHER_MTU) {
bp->flags |= BNXT_FLAG_JUMBO;
bp->eth_dev->data->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_JUMBO_FRAME;
} else {
bp->eth_dev->data->dev_conf.rxmode.offloads &=
~DEV_RX_OFFLOAD_JUMBO_FRAME;
bp->flags &= ~BNXT_FLAG_JUMBO;
}The backtrace isrte_eth_dev_configure()
bnxt_dev_configure_op()
bnxt_mtu_set_op()
//cleans the JUMBO FRAME CONFIG
//complains requested JUMBO FRAME is not setHow 'ethdev' is checking for jumbo frame is wrong:
http://lxr.dpdk.org/dpdk/latest/source/lib/librte_ethdev/rte_ethdev.c#L1344
If application doesn't set the JUMBO FRAME flag, it doesn't allow max_rx_pkt_len to be more than 'RTE_ETHER_MAX_LEN', instead this should be checked against the MTU, not 'RTE_ETHER_MAX_LEN', the deprecation notice in other patch is to fix this.
To workaround above behavior, testpmd sets the JUMBO FRAME flag, and bnxt detects requested frame size doesn't require the JUMBO FRAME support and unsets the flag during configure, but this time 'rte_eth_dev_configure()' API complains that requested offload (JUMBO FRAME) is not enabled by the driver.
The ethdev part not fixed in this release because there are PMDs testing JUMBO frame against 'max_rx_pkt_len', didn't want to create unexpected side affect for them.
Not sure what to do,
Perhaps we can revert the patch for this release, and in next release we can fix testpmd, ethdev and PMDs altogether. Even possible to remove the JUMBO FRAME offload flag as already suggested:
https://mails.dpdk.org/archives/dev/2020-November/190940.html
Quoted 131 lines
Thanks,
LanceQuoted 127 lines · Olivier Matz
Quoted 108 lines · Ferruh Yigit
Quoted 106 lines · Thomas Monjalon
+ more maintainers Cc'ed
We have a critical issue with testpmd in -rc2.
It is blocking a lot of testing.
Would be good to do a -rc3 today.
Please see below.05/11/2020 11:44, Thomas Monjalon:
Quoted 96 lines
05/11/2020 11:37, Ferruh Yigit:
Quoted 86 lines · SteveX
Quoted 71 lines
From: Andrew Rybchenko <[email protected]>
Quoted 70 lines
Sent: Thursday, November 5, 2020 4:54 PM
To: Thomas Monjalon <[email protected]>; Yang, SteveX <[email protected]>; Yigit, Ferruh <[email protected]>
Cc: [email protected]; Ananyev, Konstantin <[email protected]>; Xing, Beilei <[email protected]>; Lu, Wenzhuo <[email protected]>; Iremonger, Bernard <[email protected]>; Yang, Qiming <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packetsQuoted 25 lines · Thomas Monjalon
04/11/2020 21:19, Ferruh Yigit:
Quoted 24 lines · Thomas Monjalon
Quoted 23 lines
04/11/2020 18:07, Ferruh Yigit:
Quoted 22 lines · Thomas Monjalon
Quoted 21 lines
03/11/2020 14:29, Ferruh Yigit:
On 11/2/2020 11:48 AM, Ferruh Yigit wrote:
On 11/2/2020 8:52 AM, SteveX Yang wrote:
When the max rx packet length is smaller than the sum of mtu
size and ether overhead size, it should be enlarged, otherwise
the VLAN packets will be dropped.Fixes: 35b2d13fd6fd ("net: add rte prefix to ether defines")
Signed-off-by: SteveX Yang <[email protected]>
Reviewed-by: Ferruh Yigit <[email protected]>
Applied to dpdk-next-net/main, thanks.
only 1/2 applied since discussion is going on for 2/2.
I'm not sure this testpmd change is good.
Reminder: testpmd is for testing the PMDs.
Don't we want to see VLAN packets dropped in the case describedabove?
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
The patch set '
max_rx_pkt_len' in a way to make MTU 1500 for all PMDs, otherwise testpmd set hard-coded 'RTE_ETHER_MAX_LEN'value,
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
which makes MTU between 1492-1500 depending on PMD.
It is application responsibility to provide correct '
max_rx_pkt_len'. I guess the original intention was to set MTU as 1500 but was not correct for all PMDs and this patch is fixing it.The same problem in the ethdev, (assuming '
RTE_ETHER_MAX_LEN'will
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
give MTU 1500), the other patch in the set is to fix it later.
OK but the testpmd patch is just hiding the issue, isn't it?
I don't think so, issue was application (testpmd) setting the
'
max_rx_pkt_len'Quoted 7 lines
Quoted 3 lines
wrong.
What is hidden?
I was looking for adding a helper in ethdev API. But I think I can agree with your way of thinking.
The patch breaks running testpmd on Virtio-Net because the driver populates dev_info.max_rx_pktlen but keeps dev_info.max_mtu equal to
UINT16_MAXas it was filled in by ethdev. As the result:Quoted 6 lines
Quoted 2 lines
Ethdev port_id=0
max_rx_pkt_len11229 > max valid value 9728 Fail to configure port 0Similar issue occurred for other net PMD drivers which use default
max_mtu(UINT16_MAX). More strict checking condition will be added within new patch sooner.:(
For drivers not providing '
max_mtu' information explicitly, the default 'UINT16_MAX' is set in ethdev layer.
This prevents calculating PMD specific 'overhead' and the logic in the patch is broken.Quoted 7 lines
Indeed this makes inconsistency in the driver too, for example for virtio, it claims '
max_rx_pktlen' as "VIRTIO_MAX_RX_PKTLEN(9728)" and 'max_mtu' asUINT16_MAX. From 'virtio_mtu_set()' we can see the real limit is 'VIRTIO_MAX_RX_PKTLEN'.When PMDs fixed, the logic in this patch can work but not sure if post -rc2 is good time to start fixing the PMDs.
Do you suggest revert is the best choice here?
Quoted 8 lines
(copy/pasting previous reply to this eamil)
One option is revert, but than the issue this patch is trying to fix still remain.
Other option is the extend the patch as Steve sent [1], the check there is more like workaround in application, so not nice to have them, but with extending the deprecation notice (other patch in this patchset) to fix PMDs too in next release, I would be OK to have these checks. What do you think?
+1 for this second option.
I think it is ok to have a workaround to fix an issue. Clarifying and uniformizing the ethdev/drivers behavior in that area can come in a second time.
Quoted 2 lines
Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets
Quoted 13 lines
First the code cause problem in the driver looks in another place, following in '
bnxt_mtu_set_op()':if (new_mtu > RTE_ETHER_MTU) { bp->flags |= BNXT_FLAG_JUMBO; bp->eth_dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME; } else { bp->eth_dev->data->dev_conf.rxmode.offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME; bp->flags &= ~BNXT_FLAG_JUMBO; }
You're correct, the issue in this case is definitely in bnxt_mtu_set_op(), not the similar code that is executed for the start op.
+1 to the idea of removing DEV_RX_OFFLOAD_JUMBO_FRAME.
PATCH 1/1 app/testpmd: revert max Rx packet length adjustment
In reply to Ferruh YigitThe fix of max_rx_pkt_len for allowing VLAN packets in all cases was breaking configuration of some drivers. Example with virtio:
Ethdev port_id=0 max_rx_pkt_len 11229 > max valid value 9728 Fail to configure port 0
Trying to fix the logic was revealing other issues in some drivers. That's why it is decided to revert.
The workaround for the original issue would be
to set the MTU explicitly from the application
with rte_eth_dev_set_mtu().
--- app/test-pmd/testpmd.c | 23 ----------------------- 1 file changed, 23 deletions(-)
app/test-pmd/testpmd.c +0 -23
@@ -1421,7 +1421,6 @@ init_config(void)struct rte_gro_param gro_param;uint32_t gso_types;uint16_t data_size; -uint16_t overhead_len;bool warning =0 ;int k;int ret;
@@ -1458,28 +1457,6 @@ init_config(void)rte_exit (EXIT_FAILURE ,"rte_eth_dev_info_get() failed\n" ); -/* Update the max_rx_pkt_len to have MTU as RTE_ETHER_MTU */ -if (port->dev_info.max_rx_pktlen && port->dev_info.max_mtu) - overhead_len = port->dev_info.max_rx_pktlen - - port->dev_info.max_mtu; -else - overhead_len =RTE_ETHER_HDR_LEN +RTE_ETHER_CRC_LEN ; - - port->dev_conf.rxmode.max_rx_pkt_len = -RTE_ETHER_MTU + overhead_len; - -/* -* This is workaround to avoid resize max rx packet len. -* Ethdev assumes jumbo frame size must be greater than -* RTE_ETHER_MAX_LEN, and will resize 'max_rx_pkt_len' to -* default value when it is greater than RTE_ETHER_MAX_LEN -* for normal frame. -*/ -if (port->dev_conf.rxmode.max_rx_pkt_len >RTE_ETHER_MAX_LEN ) { - port->dev_conf.rxmode.offloads |= -DEV_RX_OFFLOAD_JUMBO_FRAME ; - } -if (!(port->dev_info.tx_offload_capa &DEV_TX_OFFLOAD_MBUF_FAST_FREE )) port->dev_conf.txmode.offloads &=
Signature · 1 line
2.28.0
Re: [dpdk-dev] [PATCH 1/1] app/testpmd: revert max Rx packet length adjustment
Quoted 14 lines · Thomas Monjalon
The fix of
max_rx_pkt_lenfor allowing VLAN packets in all cases was breaking configuration of some drivers. Example with virtio:Ethdev port_id=0
max_rx_pkt_len11229 > max valid value 9728 Fail to configure port 0Trying to fix the logic was revealing other issues in some drivers. That's why it is decided to revert.
The workaround for the original issue would be
to set the MTU explicitly from the application
withrte_eth_dev_set_mtu().
Quoted 6 lines
Fixes f6870a7ed6b3 ("app/testpmd: fix max Rx packet length for VLAN packet")Reported-by Andrew Rybchenko <[email protected]>Signed-off-by Thomas Monjalon <[email protected]>---
Re: [dpdk-dev] [PATCH 1/1] app/testpmd: revert max Rx packet length adjustment
In reply to Thomas MonjalonQuoted 6 lines · Thomas Monjalon
The fix of
max_rx_pkt_lenfor allowing VLAN packets in all cases was breaking configuration of some drivers. Example with virtio:Ethdev port_id=0 max_rx_pkt_len 11229 > max valid value 9728 Fail to configure port 0
Quoted 7 lines
Trying to fix the logic was revealing other issues in some drivers. That's why it is decided to revert.
The workaround for the original issue would be
to set the MTU explicitly from the application
withrte_eth_dev_set_mtu().
Sent this option as RFC:
https://patches.dpdk.org/patch/83756/
Quoted 5 lines
Fixes f6870a7ed6b3 ("app/testpmd: fix max Rx packet length for VLAN packet")Reported-by Andrew Rybchenko <[email protected]>Signed-off-by Thomas Monjalon <[email protected]>
Thomas Monjalon
AppliedRe: [dpdk-dev] [PATCH 1/1] app/testpmd: revert max Rx packet length adjustment
05/11/2020 19:11, Ferruh Yigit:
Quoted 18 lines · Thomas Monjalon
Quoted 6 lines
The fix of
max_rx_pkt_lenfor allowing VLAN packets in all cases was breaking configuration of some drivers. Example with virtio:Ethdev port_id=0 max_rx_pkt_len 11229 > max valid value 9728 Fail to configure port 0Quoted 7 lines
Trying to fix the logic was revealing other issues in some drivers. That's why it is decided to revert.
The workaround for the original issue would be
to set the MTU explicitly from the application
withrte_eth_dev_set_mtu().Sent this option as RFC:
https://patches.dpdk.org/patch/83756/
Quoted 6 lines
Quoted 5 lines
Fixes f6870a7ed6b3 ("app/testpmd: fix max Rx packet length for VLAN packet")Reported-by Andrew Rybchenko <[email protected]>Signed-off-by Thomas Monjalon <[email protected]>Acked-by Ferruh Yigit <[email protected]>
Applied
Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets
In reply to Thomas MonjalonQuoted 95 lines · Thomas Monjalon
05/11/2020 11:37, Ferruh Yigit:
Quoted 94 lines · SteveX
Quoted 74 lines
Quoted 74 lines
-----Original Message-----
From: Andrew Rybchenko <[email protected]>
Sent: Thursday, November 5, 2020 4:54 PM
To: Thomas Monjalon <[email protected]>; Yang, SteveX <[email protected]>; Yigit, Ferruh <[email protected]>
Cc: [email protected]; Ananyev, Konstantin <[email protected]>; Xing, Beilei <[email protected]>; Lu, Wenzhuo <[email protected]>; Iremonger, Bernard <[email protected]>; Yang, Qiming <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packetsQuoted 25 lines · Thomas Monjalon
04/11/2020 21:19, Ferruh Yigit:
Quoted 24 lines · Thomas Monjalon
Quoted 23 lines
04/11/2020 18:07, Ferruh Yigit:
Quoted 22 lines · Thomas Monjalon
Quoted 21 lines
03/11/2020 14:29, Ferruh Yigit:
Quoted 8 lines · Ferruh Yigit
Quoted 7 lines · SteveX Yang
Quoted 6 lines
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped.
Fixes 35b2d13fd6fd ("net: add rte prefix to ether defines")Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by SteveX Yang <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>Applied to dpdk-next-net/main, thanks.
only 1/2 applied since discussion is going on for 2/2.
I'm not sure this testpmd change is good.
Reminder: testpmd is for testing the PMDs.
Don't we want to see VLAN packets dropped in the case describedabove?
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
The patch set '
max_rx_pkt_len' in a way to make MTU 1500 for all PMDs, otherwise testpmd set hard-coded 'RTE_ETHER_MAX_LEN'value,
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
which makes MTU between 1492-1500 depending on PMD.
It is application responsibility to provide correct '
max_rx_pkt_len'. I guess the original intention was to set MTU as 1500 but was not correct for all PMDs and this patch is fixing it.The same problem in the ethdev, (assuming '
RTE_ETHER_MAX_LEN'will
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
give MTU 1500), the other patch in the set is to fix it later.
OK but the testpmd patch is just hiding the issue, isn't it?
I don't think so, issue was application (testpmd) setting the
'
max_rx_pkt_len'Quoted 7 lines
Quoted 3 lines
wrong.
What is hidden?
I was looking for adding a helper in ethdev API. But I think I can agree with your way of thinking.
The patch breaks running testpmd on Virtio-Net because the driver populates dev_info.max_rx_pktlen but keeps dev_info.max_mtu equal to
UINT16_MAXas it was filled in by ethdev. As the result:Quoted 6 lines
Quoted 2 lines
Ethdev port_id=0
max_rx_pkt_len11229 > max valid value 9728 Fail to configure port 0Similar issue occurred for other net PMD drivers which use default
max_mtu(UINT16_MAX). More strict checking condition will be added within new patch sooner.:(
For drivers not providing '
max_mtu' information explicitly, the default 'UINT16_MAX' is set in ethdev layer.
This prevents calculating PMD specific 'overhead' and the logic in the patch is broken.Indeed this makes inconsistency in the driver too, for example for virtio, it claims '
max_rx_pktlen' as "VIRTIO_MAX_RX_PKTLEN(9728)" and 'max_mtu' asUINT16_MAX. From 'virtio_mtu_set()' we can see the real limit is 'VIRTIO_MAX_RX_PKTLEN'.
Quoted 5 lines
Quoted 2 lines
When PMDs fixed, the logic in this patch can work but not sure if post -rc2 is good time to start fixing the PMDs.
Do you suggest revert is the best choice here?
One option is revert, but than the issue this patch is trying to fix still remain.
Other option is the extend the patch as Steve sent [1], the check there is more like workaround in application, so not nice to have them, but with extending the deprecation notice (other patch in this patchset) to fix PMDs too in next release, I would be OK to have these checks. What do you think?
PATCH v8 2/2 doc: annouce deprecation of jumbo frame flag condition
In reply to SteveX YangAnnouce to replace 'RTE_ETHER_MAX_LEN' with 'RTE_ETHER_MTU' as type condition of jumbo frame. Involved scopes:
- rte_ethdev;
- app, e.g.: test-pmd, test-eventdev;
- examples, e.g.: ipsec-secgw, l3fwd, vhost;
- net PMDs which support VLAN tag(s) within overhead, e.g.: i40e, ixgbe;
--- doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+)
doc/guides/rel_notes/deprecation.rst +12 -0
@@ -138,6 +138,18 @@ Deprecation Notices will be limited to maximum 256 queues. Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed. +* ethdev: Offload flag ``DEV_RX_OFFLOAD_JUMBO_FRAME`` will be set according to + ``RTE_ETHER_MTU`` in next release. Currently, the jumbo frame uses the + ``RTE_ETHER_MAX_LEN`` as boundary condition. When the MTU (1500) set, the + frame type of rx packet will be different if used different overhead, it will + cause the consistency issue. Hence, using fixed value ``RTE_ETHER_MTU`` can + avoid this issue. + Following scopes will be changed: + - ``rte_ethdev`` + - ``app``, e.g.: ``test-pmd``, ``test-eventdev``; + - ``examples``, e.g.: ``ipsec-secgw``, ``l3fwd``, ``vhost``; + - net PMDs which support VLAN tag(s) within overhead, e.g.: ``i40e``; + * cryptodev: support for using IV with all sizes is added, J0 still can be used but only when IV length in following structs ``rte_crypto_auth_xform``, ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equal
Signature · 1 line
2.17.1
Re: [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag condition
Quoted 26 lines · SteveX Yang
Annouce to replace '
RTE_ETHER_MAX_LEN' with 'RTE_ETHER_MTU' as type condition of jumbo frame. Involved scopes:
-rte_ethdev;
- app, e.g.: test-pmd, test-eventdev;
- examples, e.g.: ipsec-secgw, l3fwd, vhost;
- net PMDs which support VLAN tag(s) within overhead, e.g.: i40e, ixgbe;Signed-off-by SteveX Yang <[email protected]>--- doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+)doc/guides/rel_notes/deprecation.rst +5
-0@@ -138,6 +138,18 @@ Deprecation Notices will be limited to maximum 256 queues. Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed. +* ethdev: Offload flag ``DEV_RX_OFFLOAD_JUMBO_FRAME`` will be set according to + ``RTE_ETHER_MTU`` in next release. Currently, the jumbo frame uses the + ``RTE_ETHER_MAX_LEN`` as boundary condition. When the MTU (1500) set, the + frame type of rx packet will be different if used different overhead, it will + cause the consistency issue. Hence, using fixed value ``RTE_ETHER_MTU`` can
doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 155
Quoted 10 lines
doc/guides/rel_notes/deprecation.rst +7
-0+ avoid this issue. + Following scopes will be changed: + - ``rte_ethdev`` + - ``app``, e.g.: ``test-pmd``, ``test-eventdev``; + - ``examples``, e.g.: ``ipsec-secgw``, ``l3fwd``, ``vhost``; + - net PMDs which support VLAN tag(s) within overhead, e.g.: ``i40e``; + * cryptodev: support for using IV with all sizes is added, J0 still can be used but only when IV length in following structs ``rte_crypto_auth_xform``, ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equal
The mentioned code in the ethdev is:
http://lxr.dpdk.org/dpdk/v20.08/source/lib/librte_ethdev/rte_ethdev.c#L1345
cc'ed other ethdev maintainers.
Re: [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag condition
In reply to SteveX YangQuoted 26 lines · SteveX Yang
Annouce to replace '
RTE_ETHER_MAX_LEN' with 'RTE_ETHER_MTU' as type condition of jumbo frame. Involved scopes:
-rte_ethdev;
- app, e.g.: test-pmd, test-eventdev;
- examples, e.g.: ipsec-secgw, l3fwd, vhost;
- net PMDs which support VLAN tag(s) within overhead, e.g.: i40e, ixgbe;Signed-off-by SteveX Yang <[email protected]>--- doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+)doc/guides/rel_notes/deprecation.rst +5
-0@@ -138,6 +138,18 @@ Deprecation Notices will be limited to maximum 256 queues. Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed. +* ethdev: Offload flag ``DEV_RX_OFFLOAD_JUMBO_FRAME`` will be set according to + ``RTE_ETHER_MTU`` in next release. Currently, the jumbo frame uses the + ``RTE_ETHER_MAX_LEN`` as boundary condition. When the MTU (1500) set, the + frame type of rx packet will be different if used different overhead, it will + cause the consistency issue. Hence, using fixed value ``RTE_ETHER_MTU`` can
doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 155
Quoted 10 lines
doc/guides/rel_notes/deprecation.rst +7
-0+ avoid this issue. + Following scopes will be changed: + - ``rte_ethdev`` + - ``app``, e.g.: ``test-pmd``, ``test-eventdev``; + - ``examples``, e.g.: ``ipsec-secgw``, ``l3fwd``, ``vhost``; + - net PMDs which support VLAN tag(s) within overhead, e.g.: ``i40e``; + * cryptodev: support for using IV with all sizes is added, J0 still can be used but only when IV length in following structs ``rte_crypto_auth_xform``, ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equal
If so, what's the point to have the offload? May be just deprecate and later remove it?
Re: [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag condition
Quoted 31 lines · Andrew Rybchenko
Quoted 30 lines · SteveX Yang
Annouce to replace '
RTE_ETHER_MAX_LEN' with 'RTE_ETHER_MTU' as type condition of jumbo frame. Involved scopes:
-rte_ethdev;
- app, e.g.: test-pmd, test-eventdev;
- examples, e.g.: ipsec-secgw, l3fwd, vhost;
- net PMDs which support VLAN tag(s) within overhead, e.g.: i40e, ixgbe;Signed-off-by SteveX Yang <[email protected]>---
doc/guides/rel_notes/deprecation.rst| 12 ++++++++++++1 file changed, 12 insertions(+)doc/guides/rel_notes/deprecation.rst +0
-0@@ -138,6 +138,18 @@ Deprecation Noticeswill be limited to maximum 256 queues.
Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed. +* ethdev: Offload flag ``DEV_RX_OFFLOAD_JUMBO_FRAME`` will be set according to + ``RTE_ETHER_MTU`` in next release. Currently, the jumbo frame uses the + ``RTE_ETHER_MAX_LEN`` as boundary condition. When the MTU (1500) set, the + frame type of rx packet will be different if used different overhead, it will + cause the consistency issue. Hence, using fixed value ``RTE_ETHER_MTU`` can + avoid this issue.
+ Following scopes will be changed:
+ - ``rte_ethdev``
+ - ``app``, e.g.: ``test-pmd``, ``test-eventdev``;
+ - ``examples``, e.g.: ``ipsec-secgw``, ``l3fwd``, ``vhost``;
+ - net PMDs which support VLAN tag(s) within overhead, e.g.: ``i40e``;
Quoted 9 lines
Quoted 5 lines
+
* cryptodev: support for using IV with all sizes is added, J0 still can be used but only when IV length in following structs ``rte_crypto_auth_xform``, ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equalIf so, what's the point to have the offload? May be just deprecate and later remove it?
Above just changes the condition of what is called jumbo frame, nothing more.
ethdev assumes max frame size (without jumbo frame support) can be 'RTE_ETHER_MAX_LEN' (1518)
But a PMD can support double VLAN, and it can have RTE_ETHER_MAX_LEN + 8 bytes frame size and still may not support jumbo frame.
In that case ethdev overwrites the frame size as RTE_ETHER_MAX_LEN, and this will reduce the supported MTU to 1492 (instead of expected 1500). Above deprecation notice is to fix this.
Re: [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag condition
Quoted 37 lines · Andrew Rybchenko
Quoted 34 lines · SteveX Yang
Quoted 33 lines
Annouce to replace '
RTE_ETHER_MAX_LEN' with 'RTE_ETHER_MTU' as type condition of jumbo frame. Involved scopes:
-rte_ethdev;
- app, e.g.: test-pmd, test-eventdev;
- examples, e.g.: ipsec-secgw, l3fwd, vhost;
- net PMDs which support VLAN tag(s) within overhead, e.g.: i40e, ixgbe;Signed-off-by SteveX Yang <[email protected]>---
doc/guides/rel_notes/deprecation.rst| 12 ++++++++++++1 file changed, 12 insertions(+)doc/guides/rel_notes/deprecation.rst +0
-0@@ -138,6 +138,18 @@ Deprecation Noticeswill be limited to maximum 256 queues.
Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed.doc/guides/rel_notes/deprecation.rst +12
-0+* ethdev: Offload flag ``DEV_RX_OFFLOAD_JUMBO_FRAME`` will be set according to + ``RTE_ETHER_MTU`` in next release. Currently, the jumbo frame uses the + ``RTE_ETHER_MAX_LEN`` as boundary condition. When the MTU (1500) set, the + frame type of rx packet will be different if used different overhead, it will + cause the consistency issue. Hence, using fixed value ``RTE_ETHER_MTU`` can + avoid this issue. + Following scopes will be changed: + - ``rte_ethdev`` + - ``app``, e.g.: ``test-pmd``, ``test-eventdev``; + - ``examples``, e.g.: ``ipsec-secgw``, ``l3fwd``, ``vhost``; + - net PMDs which support VLAN tag(s) within overhead, e.g.: ``i40e``; +* cryptodev: support for using IV with all sizes is added, J0 still can
Quoted 8 lines
Quoted 8 lines
Quoted 4 lines
be used but only when IV length in following structs ``rte_crypto_auth_xform``,
``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equalIf so, what's the point to have the offload? May be just deprecate and later remove it?
Same thought actually, can we remove DEV_RX_OFFLOAD_JUMBO_FRAME flag completely? PMD can decide based on provided MTU size does segmentation, etc. is needed.
Quoted 12 lines
Above just changes the condition of what is called jumbo frame, nothing more.
ethdev assumes max frame size (without jumbo frame support) can be '
RTE_ETHER_MAX_LEN' (1518)But a PMD can support double VLAN, and it can have
RTE_ETHER_MAX_LEN+ 8 bytes frame size and still may not support jumbo frame.In that case ethdev overwrites the frame size as
RTE_ETHER_MAX_LEN, and this will reduce the supported MTU to 1492 (instead of expected 1500). Above deprecation notice is to fix this.
A message that is not in the archive (sent off-list or not yet received): DM6PR11MB43625C5CF594BEDC9CE479F7F9110@DM6PR11MB4362.namprd11.prod.outlook.com
Re: [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag condition
Quoted 80 lines · SteveX
Quoted 74 lines
-----Original Message-----
From: Ananyev, Konstantin <[email protected]>
Sent: Tuesday, November 3, 2020 12:05 AM
To: Yigit, Ferruh <[email protected]>; Andrew Rybchenko <[email protected]>; Yang, SteveX <[email protected]>; [email protected]
Cc: Xing, Beilei <[email protected]>; Lu, Wenzhuo <[email protected]>; Iremonger, Bernard <[email protected]>; Yang, Qiming <[email protected]>; [email protected]; [email protected]
Subject: RE: [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag conditionQuoted 3 lines · Andrew Rybchenko
Quoted 2 lines · SteveX Yang
Quoted 1 line
Annouce to replace '
RTE_ETHER_MAX_LEN' with 'RTE_ETHER_MTU' astype
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
condition of jumbo frame. Involved scopes:
-rte_ethdev;
- app, e.g.: test-pmd, test-eventdev;
- examples, e.g.: ipsec-secgw, l3fwd, vhost;
- net PMDs which support VLAN tag(s) within overhead, e.g.: i40e, ixgbe;Signed-off-by SteveX Yang <[email protected]>--- doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+)Quoted 8 lines
Quoted 8 lines
doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 139
Quoted 8 lines
doc/guides/rel_notes/deprecation.rst +0
-0@@ -138,6 +138,18 @@ Deprecation Notices will be limited to maximum 256 queues. Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will beremoved.
Quoted 1 line
Quoted 1 line
doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 140
Quoted 1 line
doc/guides/rel_notes/deprecation.rst +1
-0+* ethdev: Offload flag ``DEV_RX_OFFLOAD_JUMBO_FRAME`` will beset
Quoted 4 lines
Quoted 4 lines
doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 144
Quoted 4 lines
doc/guides/rel_notes/deprecation.rst +4
-0+according to + ``RTE_ETHER_MTU`` in next release. Currently, the jumbo frame +uses the + ``RTE_ETHER_MAX_LEN`` as boundary condition. When the MTU(1500)
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
doc/guides/rel_notes/deprecation.rst +13
-0+set, the + frame type of rx packet will be different if used different +overhead, it will + cause the consistency issue. Hence, using fixed value +``RTE_ETHER_MTU`` can + avoid this issue. + Following scopes will be changed: + - ``rte_ethdev`` + - ``app``, e.g.: ``test-pmd``, ``test-eventdev``; + - ``examples``, e.g.: ``ipsec-secgw``, ``l3fwd``, ``vhost``; + - net PMDs which support VLAN tag(s) within overhead, e.g.: +``i40e``; + * cryptodev: support for using IV with all sizes is added, J0still can
be used but only when IV length in following structsQuoted 8 lines
Quoted 8 lines
Quoted 4 lines
``rte_crypto_auth_xform``,
``rte_crypto_aead_xform`` is set to zero. When IV length is
greater or equalIf so, what's the point to have the offload? May be just deprecate and later remove it?
Quoted 5 lines
Same thought actually, can we remove
DEV_RX_OFFLOAD_JUMBO_FRAMEflag completely?
PMD can decide based on provided MTU size does segmentation, etc. is needed.
Quoted 4 lines
Yes, it seems can be removed when base on MTU size.
I've checked related code of usingDEV_RX_OFFLOAD_JUMBO_FRAME.
Most of them use for checking boundary of max packet length and set 'dev->data->mtu'.
Steve already sent the RFC for above fix:
https://patches.dpdk.org/patch/84486/
We can consider removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' but anyway it is for 21.11.
This deprecation notice is required to fix the ethdev in next release, as in the above RFC.
I cc'ed a few more relevant people, can you please review this deprecation notice.
Thanks,
ferruh
Quoted 14 lines
Quoted 14 lines
Quoted 2 lines
Above just changes the condition of what is called jumbo frame, nothing
more.
Quoted 5 lines
ethdev assumes max frame size (without jumbo frame support) can be '
RTE_ETHER_MAX_LEN' (1518)But a PMD can support double VLAN, and it can have
RTE_ETHER_MAX_LEN+Quoted 5 lines
8 bytes frame size and still may not support jumbo frame.
In that case ethdev overwrites the frame size as
RTE_ETHER_MAX_LEN, and this will reduce the supported MTU to 1492 (instead of expected 1500). Above deprecation notice is to fix this.
Re: [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag condition
Quoted 85 lines · Ferruh Yigit
Quoted 72 lines · SteveX
Quoted 66 lines
-----Original Message-----
From: Ananyev, Konstantin <[email protected]>
Sent: Tuesday, November 3, 2020 12:05 AM
To: Yigit, Ferruh <[email protected]>; Andrew Rybchenko <[email protected]>; Yang, SteveX <[email protected]>; [email protected]
Cc: Xing, Beilei <[email protected]>; Lu, Wenzhuo <[email protected]>; Iremonger, Bernard <[email protected]>; Yang, Qiming <[email protected]>; [email protected]; [email protected]
Subject: RE: [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag conditionQuoted 44 lines · Andrew Rybchenko
Quoted 43 lines · SteveX Yang
Quoted 42 lines
Annouce to replace '
RTE_ETHER_MAX_LEN' with 'RTE_ETHER_MTU' as type condition of jumbo frame. Involved scopes:
-rte_ethdev;
- app, e.g.: test-pmd, test-eventdev;
- examples, e.g.: ipsec-secgw, l3fwd, vhost;
- net PMDs which support VLAN tag(s) within overhead, e.g.: i40e, ixgbe;Signed-off-by SteveX Yang <[email protected]>---
doc/guides/rel_notes/deprecation.rst| 12 ++++++++++++1 file changed, 12 insertions(+)doc/guides/rel_notes/deprecation.rst +0
-0@@ -138,6 +138,18 @@ Deprecation Noticeswill be limited to maximum 256 queues.
Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed.doc/guides/rel_notes/deprecation.rst +18
-0+* ethdev: Offload flag ``DEV_RX_OFFLOAD_JUMBO_FRAME`` will be set +according to + ``RTE_ETHER_MTU`` in next release. Currently, the jumbo frame +uses the + ``RTE_ETHER_MAX_LEN`` as boundary condition. When the MTU (1500) +set, the + frame type of rx packet will be different if used different +overhead, it will + cause the consistency issue. Hence, using fixed value +``RTE_ETHER_MTU`` can + avoid this issue. + Following scopes will be changed: + - ``rte_ethdev`` + - ``app``, e.g.: ``test-pmd``, ``test-eventdev``; + - ``examples``, e.g.: ``ipsec-secgw``, ``l3fwd``, ``vhost``; + - net PMDs which support VLAN tag(s) within overhead, e.g.: +``i40e``; +* cryptodev: support for using IV with all sizes is added, J0 still can
be used but only when IV length in following structsQuoted 8 lines
Quoted 8 lines
Quoted 4 lines
``rte_crypto_auth_xform``,
``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equalIf so, what's the point to have the offload? May be just deprecate and later remove it?
Quoted 5 lines
Same thought actually, can we remove
DEV_RX_OFFLOAD_JUMBO_FRAMEflag completely?
PMD can decide based on provided MTU size does segmentation, etc. is needed.Quoted 5 lines
Yes, it seems can be removed when base on MTU size.
I've checked related code of usingDEV_RX_OFFLOAD_JUMBO_FRAME. Most of them use for checking boundary of max packet length and set 'dev->data->mtu'.Steve already sent the RFC for above fix:
https://patches.dpdk.org/patch/84486/We can consider removing '
DEV_RX_OFFLOAD_JUMBO_FRAME' but anyway it is for 21.11.
Quoted 23 lines
This deprecation notice is required to fix the ethdev in next release, as in the above RFC.
I cc'ed a few more relevant people, can you please review this deprecation notice.
Thanks,
ferruhQuoted 13 lines
Quoted 13 lines
Quoted 13 lines
Above just changes the condition of what is called jumbo frame, nothing more.
ethdev assumes max frame size (without jumbo frame support) can be '
RTE_ETHER_MAX_LEN' (1518)But a PMD can support double VLAN, and it can have
RTE_ETHER_MAX_LEN+ 8 bytes frame size and still may not support jumbo frame.In that case ethdev overwrites the frame size as
RTE_ETHER_MAX_LEN, and this will reduce the supported MTU to 1492 (instead of expected 1500).
Above deprecation notice is to fix this.
My problem with the deprecation notice is that I don't actually understand what will be done to address it.
The idea explained by Ferruh in details makes sense. But I don't understand how the deprecation notice description corresponding to it. I read
"Offload flag ``DEV_RX_OFFLOAD_JUMBO_FRAME`` will be set.."
as an enforcement of the offload flag based on other parameters. I think it is incorrect. Or I still don't understand something...
Looking at [1] adds more confusion since I don't understand why we care about dev_conf->rxmode.max_rx_pkt_len when JUMBO_FRAME offload is disabled. As far as I know JUMBO_FRAME offload enable means that driver should take a look at it and apply. Otherwise, just ignore it.
[1]
http://lxr.dpdk.org/dpdk/v20.08/source/lib/librte_ethdev/rte_ethdev.c#L1345
Re: [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag condition
Quoted 121 lines · Andrew Rybchenko
Quoted 85 lines · Ferruh Yigit
Quoted 72 lines · SteveX
Quoted 66 lines
-----Original Message-----
From: Ananyev, Konstantin <[email protected]>
Sent: Tuesday, November 3, 2020 12:05 AM
To: Yigit, Ferruh <[email protected]>; Andrew Rybchenko <[email protected]>; Yang, SteveX <[email protected]>; [email protected]
Cc: Xing, Beilei <[email protected]>; Lu, Wenzhuo <[email protected]>; Iremonger, Bernard <[email protected]>; Yang, Qiming <[email protected]>; [email protected]; [email protected]
Subject: RE: [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag conditionQuoted 44 lines · Andrew Rybchenko
Quoted 43 lines · SteveX Yang
Quoted 42 lines
Annouce to replace '
RTE_ETHER_MAX_LEN' with 'RTE_ETHER_MTU' as type condition of jumbo frame. Involved scopes:
-rte_ethdev;
- app, e.g.: test-pmd, test-eventdev;
- examples, e.g.: ipsec-secgw, l3fwd, vhost;
- net PMDs which support VLAN tag(s) within overhead, e.g.: i40e, ixgbe;Signed-off-by SteveX Yang <[email protected]>---
doc/guides/rel_notes/deprecation.rst| 12 ++++++++++++1 file changed, 12 insertions(+)doc/guides/rel_notes/deprecation.rst +0
-0@@ -138,6 +138,18 @@ Deprecation Noticeswill be limited to maximum 256 queues.
Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed.doc/guides/rel_notes/deprecation.rst +18
-0+* ethdev: Offload flag ``DEV_RX_OFFLOAD_JUMBO_FRAME`` will be set +according to + ``RTE_ETHER_MTU`` in next release. Currently, the jumbo frame +uses the + ``RTE_ETHER_MAX_LEN`` as boundary condition. When the MTU (1500) +set, the + frame type of rx packet will be different if used different +overhead, it will + cause the consistency issue. Hence, using fixed value +``RTE_ETHER_MTU`` can + avoid this issue. + Following scopes will be changed: + - ``rte_ethdev`` + - ``app``, e.g.: ``test-pmd``, ``test-eventdev``; + - ``examples``, e.g.: ``ipsec-secgw``, ``l3fwd``, ``vhost``; + - net PMDs which support VLAN tag(s) within overhead, e.g.: +``i40e``; +* cryptodev: support for using IV with all sizes is added, J0 still can
be used but only when IV length in following structsQuoted 8 lines
Quoted 8 lines
Quoted 4 lines
``rte_crypto_auth_xform``,
``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equalIf so, what's the point to have the offload? May be just deprecate and later remove it?
Quoted 5 lines
Same thought actually, can we remove
DEV_RX_OFFLOAD_JUMBO_FRAMEflag completely?
PMD can decide based on provided MTU size does segmentation, etc. is needed.Quoted 5 lines
Yes, it seems can be removed when base on MTU size.
I've checked related code of usingDEV_RX_OFFLOAD_JUMBO_FRAME. Most of them use for checking boundary of max packet length and set 'dev->data->mtu'.Steve already sent the RFC for above fix:
https://patches.dpdk.org/patch/84486/We can consider removing '
DEV_RX_OFFLOAD_JUMBO_FRAME' but anyway it is for 21.11.Quoted 23 lines
This deprecation notice is required to fix the ethdev in next release, as in the above RFC.
I cc'ed a few more relevant people, can you please review this deprecation notice.
Thanks,
ferruhQuoted 13 lines
Quoted 13 lines
Quoted 13 lines
Above just changes the condition of what is called jumbo frame, nothing more.
ethdev assumes max frame size (without jumbo frame support) can be '
RTE_ETHER_MAX_LEN' (1518)But a PMD can support double VLAN, and it can have
RTE_ETHER_MAX_LEN+ 8 bytes frame size and still may not support jumbo frame.In that case ethdev overwrites the frame size as
RTE_ETHER_MAX_LEN, and this will reduce the supported MTU to 1492 (instead of expected 1500).
Above deprecation notice is to fix this.My problem with the deprecation notice is that I don't actually understand what will be done to address it.
The idea explained by Ferruh in details makes sense. But I don't understand how the deprecation notice description corresponding to it. I read
"Offload flag ``DEV_RX_OFFLOAD_JUMBO_FRAME`` will be set.."
as an enforcement of the offload flag based on other parameters. I think it is incorrect. Or I still don't understand something...
Quoted 6 lines
Looking at [1] adds more confusion since I don't understand why we care about
dev_conf->rxmode.max_rx_pkt_lenwhenJUMBO_FRAMEoffload is disabled. As far as I knowJUMBO_FRAMEoffload enable means that driver should take a look at it and apply. Otherwise, just ignore it.
I agree with the comment here - my understanding is the same that if the JUMBO_FRAME offload flag is not set, then the max_rx_pkt_len should be ignored (which for me implies that it should be set to 0 or similar sentinal value in ethdev to ensure drivers don't accidentally use it).
In terms of the deprecation notice, I also think it's fairly confusing, and after talking with Ferruh, I'm not convinced we need one. It seems that the planned changes based on this are just bug fixes, where packets that should not have been dropped were dropped. Perhaps someone could comment on the specific behaviour change that would affect apps (where it's not just plain buggy behaviour!)
However, it does appear that this area is in need of clean-up generally. The suggestion to drop the jumbo frame flag, packet_len/mtu value from the ethdev config, and just use the existing API calls, sounds interesting. If that is not the approach taken, I'd like to see the existing approach kept, so that a zero-initialized config is acceptable for packet size setting, i.e. no jumbo frame flag and zero max-length == default ethernet MTU.
Just my 2c.
/Bruce