block/blkdebug: fix memory leak
PATCH 1/1 block/blkdebug: fix memory leak
Spotted by PVS-Studio
Signed-off-by Elena Afanasova <[email protected]>
--- block/blkdebug.c | 1 + 1 file changed, 1 insertion(+)
block/blkdebug.c +1 -0
@@ -215,6 +215,7 @@ static int add_rule(void *opaque, QemuOpts *opts, Error **errp) BLKDEBUG_IO_TYPE__MAX, &local_error);if (local_error) {error_propagate (errp, local_error); +g_free (rule);return -1 ; }if (iotype !=BLKDEBUG_IO_TYPE__MAX ) {
Signature · 1 line
2.25.1
Quoted 6 lines · Elena Afanasova
Spotted by PVS-Studio
Signed-off-by Elena Afanasova <[email protected]>--- block/blkdebug.c | 1 + 1 file changed, 1 insertion(+)
Reviewed-by Eric Blake <[email protected]>
Quoted 14 lines
block/blkdebug.c +1
-0@@ -215,6 +215,7 @@ static int add_rule(void *opaque, QemuOpts *opts, Error **errp) BLKDEBUG_IO_TYPE__MAX, &local_error);if (local_error) {error_propagate (errp, local_error); +g_free (rule);return -1 ; }if (iotype !=BLKDEBUG_IO_TYPE__MAX ) {
Signature · 3 lines
Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
Laurent Vivier
AppliedLe 09/10/2020 à 21:09, Elena Afanasova a écrit :
Quoted 13 lines
Spotted by PVS-Studio
Signed-off-by Elena Afanasova <[email protected]>--- block/blkdebug.c | 1 + 1 file changed, 1 insertion(+)block/blkdebug.c +0
-0
block/blkdebug.c static int add_rule(void *opaque, QemuOpts *opts, Error **errp) · line 221
Quoted 7 lines
block/blkdebug.c +1
-0@@ -215,6 +215,7 @@ static int add_rule(void *opaque, QemuOpts *opts, Error **errp) BLKDEBUG_IO_TYPE__MAX, &local_error);if (local_error) {error_propagate (errp, local_error); +g_free (rule);return -1 ; }if (iotype !=BLKDEBUG_IO_TYPE__MAX ) {
Applied to my trivial-patches branch.
Thanks,
Laurent