package/gdb: enable gdbserver support for riscv
PATCH 1/2 package/gdb: enable gdbserver support for riscv
It turn out that gdbserver support for riscv is available since 10.1 release, since commit [1]
When BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTS is not enabled, gdb will use the stable version (9.x) where gdbserver for riscv is not available.
When BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTS enabled, only allow gdb 10.1 in version choice and allow enabling gdbserver for the target.
---
git tag --contains bf84f7066626c78884436e1c39fb60f04c665f21 returns gdb-10.1-release tag as the oldest containing this commit.
--- package/gdb/Config.in | 6 +++--- package/gdb/Config.in.host | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-)
package/gdb/Config.in +3 -3
@@ -19,8 +19,8 @@ config BR2_PACKAGE_GDB depends on BR2_PACKAGE_GDB_ARCH_SUPPORTS depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 depends on BR2_INSTALL_LIBSTDCPP - # no gdbserver on riscv - select BR2_PACKAGE_GDB_DEBUGGER if BR2_riscv + # no gdbserver on riscv until 10.1 release + select BR2_PACKAGE_GDB_DEBUGGER if BR2_riscv && !BR2_GDB_VERSION_10 # When the external toolchain gdbserver is copied to the # target, we don't allow building a separate gdbserver. The # one from the external toolchain should be used.
@@ -47,7 +47,7 @@ if BR2_PACKAGE_GDB config BR2_PACKAGE_GDB_SERVER bool "gdbserver" depends on !BR2_TOOLCHAIN_EXTERNAL_GDB_SERVER_COPY - depends on !BR2_riscv + depends on !BR2_riscv || BR2_riscv && BR2_GDB_VERSION_10 help Build the gdbserver stub to run on the target. A full gdb is needed to debug the progam.
package/gdb/Config.in.host +2 -1
@@ -4,7 +4,6 @@ config BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTS depends on !((BR2_arm || BR2_armeb) && BR2_BINFMT_FLAT) depends on !BR2_microblaze depends on !BR2_or1k - depends on !BR2_riscv depends on !BR2_nds32 comment "Host GDB Options"
@@ -70,9 +69,11 @@ choice config BR2_GDB_VERSION_8_3 bool "gdb 8.3.x" + depends on !BR2_riscv config BR2_GDB_VERSION_9_2 bool "gdb 9.2.x" + depends on !BR2_riscv config BR2_GDB_VERSION_10 bool "gdb 10.x"
Signature · 1 line
2.31.1
PATCH 2/2 package/gdb: improve gdb version choice comment
The comment has been introduced by commit [1] where the latest gdb version has been used when cross-gdb is not enabled.
But since then the gdb package doesn't use the latest gdb version when cross-gdb is not enabled. It's the "stable" version.
[1] https://git.buildroot.net/buildroot/commit/?id=fda818390b5e6a585608f4523356eafa0c587f53
--- package/gdb/Config.in.host | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/gdb/Config.in.host +1 -1
@@ -82,7 +82,7 @@ endchoice endif -# If cross-gdb is not enabled, the latest working version is chosen. +# If cross-gdb is not enabled, the latest stable version is chosen. config BR2_GDB_VERSION string default "arc-2020.09-release-gdb" if BR2_arc
Signature · 1 line
2.31.1
Arnout Vandecappelle
AppliedPATCH 2/2 package/gdb: improve gdb version choice comment
Quoted 10 lines · Romain Naour
The comment has been introduced by commit [1] where the latest gdb version has been used when cross-gdb is not enabled.
But since then the gdb package doesn't use the latest gdb version when cross-gdb is not enabled. It's the "stable" version.
[1] https://git.buildroot.net/buildroot/commit/?id=fda818390b5e6a585608f4523356eafa0c587f53
Signed-off-by Romain Naour <[email protected]>Cc Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Applied to master, thanks.
Regards,
Arnout
Quoted 18 lines
--- package/gdb/Config.in.host | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/gdb/Config.in.host +1
-1@@ -82,7 +82,7 @@ endchoice endif -# If cross-gdb is not enabled, the latest working version is chosen. +# If cross-gdb is not enabled, the latest stable version is chosen. config BR2_GDB_VERSION string default "arc-2020.09-release-gdb" if BR2_arc
PATCH 1/2 package/gdb: enable gdbserver support for riscv
In reply to Romain NaourQuoted 6 lines · Romain Naour
It turn out that gdbserver support for riscv is available since 10.1 release, since commit [1]
When
BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTSis not enabled, gdb will use the stable version (9.x) where gdbserver for riscv is not available.
Quoted 6 lines
When
BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTSenabled, only allow gdb 10.1 in version choice and allow enabling gdbserver for the target.Signed-off-by Romain Naour <[email protected]>
Alistair
Quoted 63 lines
---
git tag --containsbf84f7066626c78884436e1c39fb60f04c665f21returns gdb-10.1-release tag as the oldest containing this commit.--- package/gdb/Config.in | 6 +++--- package/gdb/Config.in.host | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-)package/gdb/Config.in +3
-3@@ -19,8 +19,8 @@ config BR2_PACKAGE_GDB depends on BR2_PACKAGE_GDB_ARCH_SUPPORTS depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 depends on BR2_INSTALL_LIBSTDCPP - # no gdbserver on riscv - select BR2_PACKAGE_GDB_DEBUGGER if BR2_riscv + # no gdbserver on riscv until 10.1 release + select BR2_PACKAGE_GDB_DEBUGGER if BR2_riscv && !BR2_GDB_VERSION_10 # When the external toolchain gdbserver is copied to the # target, we don't allow building a separate gdbserver. The # one from the external toolchain should be used.@@ -47,7 +47,7 @@ if BR2_PACKAGE_GDB config BR2_PACKAGE_GDB_SERVER bool "gdbserver" depends on !BR2_TOOLCHAIN_EXTERNAL_GDB_SERVER_COPY - depends on !BR2_riscv + depends on !BR2_riscv || BR2_riscv && BR2_GDB_VERSION_10 help Build the gdbserver stub to run on the target. A full gdb is needed to debug the progam.package/gdb/Config.in.host +2
-2@@ -4,7 +4,6 @@ config BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTS depends on !((BR2_arm || BR2_armeb) && BR2_BINFMT_FLAT) depends on !BR2_microblaze depends on !BR2_or1k - depends on !BR2_riscv depends on !BR2_nds32 comment "Host GDB Options"@@ -70,9 +69,11 @@ choice config BR2_GDB_VERSION_8_3 bool "gdb 8.3.x" + depends on !BR2_riscv config BR2_GDB_VERSION_9_2 bool "gdb 9.2.x" + depends on !BR2_riscv config BR2_GDB_VERSION_10 bool "gdb 10.x" --2.31.1
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 1/2 package/gdb: enable gdbserver support for riscv
In reply to Romain NaourQuoted 7 lines · Romain Naour
It turn out that gdbserver support for riscv is available since 10.1 release, since commit [1]
When
BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTSis not enabled, gdb will use the stable version (9.x) where gdbserver for riscv is not available.When
BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTSenabled, only allow gdb 10.1 in version choice and allow enabling gdbserver for the target.
Instead of all this complexity, I think it would be easier to just force gdb to
version 10 on riscv:
config BR2_GDB_VERSION
string
default "arc-2020.09-release-gdb" if BR2_arc
default "4ecb98fbc2f94dbe01b69384afbc515107de73df" if BR2_csky
default "8.3.1" if BR2_GDB_VERSION_8_3
default "9.2" if BR2_GDB_VERSION_9_2 || (!BR2_PACKAGE_HOST_GDB &&
!BR2_riscv)
default "10.1" if BR2_GDB_VERSION_10 || (!BR2_PACKAGE_HOST_GDB &&
BR2_riscv)
depends on BR2_PACKAGE_GDB || BR2_PACKAGE_HOST_GDB IMHO that will make the maintainance easier going forward: when 10 becomes the
default, we can simply drop the riscv condition and nothing more needs to be done.
Marked as Changes Requested.
Regards,
Arnout
Quoted 61 lines
Signed-off-by Romain Naour <[email protected]>---
git tag --containsbf84f7066626c78884436e1c39fb60f04c665f21returns gdb-10.1-release tag as the oldest containing this commit.--- package/gdb/Config.in | 6 +++--- package/gdb/Config.in.host | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-)package/gdb/Config.in +3
-3@@ -19,8 +19,8 @@ config BR2_PACKAGE_GDB depends on BR2_PACKAGE_GDB_ARCH_SUPPORTS depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 depends on BR2_INSTALL_LIBSTDCPP - # no gdbserver on riscv - select BR2_PACKAGE_GDB_DEBUGGER if BR2_riscv + # no gdbserver on riscv until 10.1 release + select BR2_PACKAGE_GDB_DEBUGGER if BR2_riscv && !BR2_GDB_VERSION_10 # When the external toolchain gdbserver is copied to the # target, we don't allow building a separate gdbserver. The # one from the external toolchain should be used.@@ -47,7 +47,7 @@ if BR2_PACKAGE_GDB config BR2_PACKAGE_GDB_SERVER bool "gdbserver" depends on !BR2_TOOLCHAIN_EXTERNAL_GDB_SERVER_COPY - depends on !BR2_riscv + depends on !BR2_riscv || BR2_riscv && BR2_GDB_VERSION_10 help Build the gdbserver stub to run on the target. A full gdb is needed to debug the progam.package/gdb/Config.in.host +2
-1@@ -4,7 +4,6 @@ config BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTS depends on !((BR2_arm || BR2_armeb) && BR2_BINFMT_FLAT) depends on !BR2_microblaze depends on !BR2_or1k - depends on !BR2_riscv depends on !BR2_nds32 comment "Host GDB Options"@@ -70,9 +69,11 @@ choice config BR2_GDB_VERSION_8_3 bool "gdb 8.3.x" + depends on !BR2_riscv config BR2_GDB_VERSION_9_2 bool "gdb 9.2.x" + depends on !BR2_riscv config BR2_GDB_VERSION_10 bool "gdb 10.x"
PATCH 1/2 package/gdb: enable gdbserver support for riscv
Hello Arnout,
Le 13/06/2021 ? 12:19, Arnout Vandecappelle a ?crit?:
Quoted 25 lines · Romain Naour
Quoted 7 lines
It turn out that gdbserver support for riscv is available since 10.1 release, since commit [1]
When
BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTSis not enabled, gdb will use the stable version (9.x) where gdbserver for riscv is not available.When
BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTSenabled, only allow gdb 10.1 in version choice and allow enabling gdbserver for the target.Instead of all this complexity, I think it would be easier to just force gdb to
version 10 on riscv:config
BR2_GDB_VERSIONstring default "arc-2020.09-release-gdb" if BR2_arc default "4ecb98fbc2f94dbe01b69384afbc515107de73df" if BR2_csky default "8.3.1" if BR2_GDB_VERSION_8_3 default "9.2" if BR2_GDB_VERSION_9_2 || (!BR2_PACKAGE_HOST_GDB && !BR2_riscv) default "10.1" if BR2_GDB_VERSION_10 || (!BR2_PACKAGE_HOST_GDB && BR2_riscv) depends on BR2_PACKAGE_GDB || BR2_PACKAGE_HOST_GDB
Quoted 2 lines
IMHO that will make the maintainance easier going forward: when 10 becomes the
default, we can simply drop the riscv condition and nothing more needs to be done.
I was not sure about restrict the gdb version for riscv just because gdb 10.1 can provide gdbserver.
Alistair, is it ok for you if we only provide gdb 10.1 ?
Best regards,
Romain
Quoted 6 lines
Marked as Changes Requested.
Regards,
Arnout
PATCH 1/2 package/gdb: enable gdbserver support for riscv
Quoted 28 lines · Romain Naour
Hello Arnout,
Le 13/06/2021 ? 12:19, Arnout Vandecappelle a ?crit?:
Quoted 25 lines · Romain Naour
Quoted 7 lines
It turn out that gdbserver support for riscv is available since 10.1 release, since commit [1]
When
BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTSis not enabled, gdb will use the stable version (9.x) where gdbserver for riscv is not available.When
BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTSenabled, only allow gdb 10.1 in version choice and allow enabling gdbserver for the target.Instead of all this complexity, I think it would be easier to just force gdb to
version 10 on riscv:config
BR2_GDB_VERSIONstring default "arc-2020.09-release-gdb" if BR2_arc default "4ecb98fbc2f94dbe01b69384afbc515107de73df" if BR2_csky default "8.3.1" if BR2_GDB_VERSION_8_3 default "9.2" if BR2_GDB_VERSION_9_2 || (!BR2_PACKAGE_HOST_GDB && !BR2_riscv) default "10.1" if BR2_GDB_VERSION_10 || (!BR2_PACKAGE_HOST_GDB && BR2_riscv) depends on BR2_PACKAGE_GDB || BR2_PACKAGE_HOST_GDB
Quoted 5 lines
Quoted 2 lines
IMHO that will make the maintainance easier going forward: when 10 becomes the
default, we can simply drop the riscv condition and nothing more needs to be done.I was not sure about restrict the gdb version for riscv just because gdb 10.1 can provide gdbserver.
Wow, hang on, I apparently misunderstood something here...
Now I see... It's just gdbserver that wasn't available before 10.1.
gdb-on-target was already available.. In that case, my simplification doesn't apply indeed.
Although... My suggestion just means that for riscv, we always use gdb 10.1 (on
target) instead of gdb 9. I don't see a big problem with that. Note that for gdb for target, we never had a version selection. So the only thing that happens is that riscv now already uses a gdb 10 on target, while the rest will only start using gdb 10 on target a few months from now when gdb 11 is released. Honestly, I think that's fine.
Regards,
Arnout
Quoted 13 lines
Alistair, is it ok for you if we only provide gdb 10.1 ?
Best regards,
RomainQuoted 6 lines
Marked as Changes Requested.
Regards,
Arnout
PATCH 1/2 package/gdb: enable gdbserver support for riscv
Quoted 44 lines · Arnout Vandecappelle
Quoted 28 lines · Romain Naour
Hello Arnout,
Le 13/06/2021 ? 12:19, Arnout Vandecappelle a ?crit :
Quoted 25 lines · Romain Naour
Quoted 7 lines
It turn out that gdbserver support for riscv is available since 10.1 release, since commit [1]
When
BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTSis not enabled, gdb will use the stable version (9.x) where gdbserver for riscv is not available.When
BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTSenabled, only allow gdb 10.1 in version choice and allow enabling gdbserver for the target.Instead of all this complexity, I think it would be easier to just force gdb to
version 10 on riscv:config
BR2_GDB_VERSIONstring default "arc-2020.09-release-gdb" if BR2_arc default "4ecb98fbc2f94dbe01b69384afbc515107de73df" if BR2_csky default "8.3.1" if BR2_GDB_VERSION_8_3 default "9.2" if BR2_GDB_VERSION_9_2 || (!BR2_PACKAGE_HOST_GDB && !BR2_riscv) default "10.1" if BR2_GDB_VERSION_10 || (!BR2_PACKAGE_HOST_GDB && BR2_riscv) depends on BR2_PACKAGE_GDB || BR2_PACKAGE_HOST_GDBQuoted 5 lines
Quoted 2 lines
IMHO that will make the maintainance easier going forward: when 10 becomes the
default, we can simply drop the riscv condition and nothing more needs to be done.I was not sure about restrict the gdb version for riscv just because gdb 10.1 can provide gdbserver.
Wow, hang on, I apparently misunderstood something here...
Now I see... It's just gdbserver that wasn't available before 10.1.
gdb-on-target was already available.. In that case, my simplification doesn't apply indeed.
Quoted 6 lines
Although... My suggestion just means that for riscv, we always use gdb 10.1 (on
target) instead of gdb 9. I don't see a big problem with that. Note that for gdb for target, we never had a version selection. So the only thing that happens is that riscv now already uses a gdb 10 on target, while the rest will only start using gdb 10 on target a few months from now when gdb 11 is released. Honestly, I think that's fine.
Agreed. I think it's best to just support GDB 10.1.
Quoted 6 lines
Regards,
ArnoutQuoted 2 lines
Alistair, is it ok for you if we only provide gdb 10.1 ?
Yep! I think that's the best plan of action here. From memory GDB 10.1 has some useful fixes for RISC-V anyway.
Alistair
Quoted 15 lines
Quoted 11 lines
Best regards,
RomainQuoted 6 lines
Marked as Changes Requested.
Regards,
Arnout_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 1/2 package/gdb: enable gdbserver support for riscv
Hello Alistair, Arnout, All,
Le 15/06/2021 ? 10:07, Alistair Francis a ?crit?:
Quoted 55 lines · Arnout Vandecappelle
Quoted 44 lines · Romain Naour
Quoted 28 lines
Hello Arnout,
Le 13/06/2021 ? 12:19, Arnout Vandecappelle a ?crit :
Quoted 25 lines · Romain Naour
Quoted 7 lines
It turn out that gdbserver support for riscv is available since 10.1 release, since commit [1]
When
BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTSis not enabled, gdb will use the stable version (9.x) where gdbserver for riscv is not available.When
BR2_PACKAGE_HOST_GDB_ARCH_SUPPORTSenabled, only allow gdb 10.1 in version choice and allow enabling gdbserver for the target.Instead of all this complexity, I think it would be easier to just force gdb to
version 10 on riscv:config
BR2_GDB_VERSIONstring default "arc-2020.09-release-gdb" if BR2_arc default "4ecb98fbc2f94dbe01b69384afbc515107de73df" if BR2_csky default "8.3.1" if BR2_GDB_VERSION_8_3 default "9.2" if BR2_GDB_VERSION_9_2 || (!BR2_PACKAGE_HOST_GDB && !BR2_riscv) default "10.1" if BR2_GDB_VERSION_10 || (!BR2_PACKAGE_HOST_GDB && BR2_riscv) depends on BR2_PACKAGE_GDB || BR2_PACKAGE_HOST_GDBQuoted 5 lines
Quoted 2 lines
IMHO that will make the maintainance easier going forward: when 10 becomes the
default, we can simply drop the riscv condition and nothing more needs to be done.I was not sure about restrict the gdb version for riscv just because gdb 10.1 can provide gdbserver.
Wow, hang on, I apparently misunderstood something here...
Now I see... It's just gdbserver that wasn't available before 10.1.
gdb-on-target was already available.. In that case, my simplification doesn't apply indeed.Quoted 6 lines
Although... My suggestion just means that for riscv, we always use gdb 10.1 (on
target) instead of gdb 9. I don't see a big problem with that. Note that for gdb for target, we never had a version selection. So the only thing that happens is that riscv now already uses a gdb 10 on target, while the rest will only start using gdb 10 on target a few months from now when gdb 11 is released. Honestly, I think that's fine.Agreed. I think it's best to just support GDB 10.1.
Quoted 1 line
Quoted 8 lines
Quoted 5 lines
Regards,
ArnoutQuoted 2 lines
Alistair, is it ok for you if we only provide gdb 10.1 ?
Yep! I think that's the best plan of action here. From memory GDB 10.1 has some useful fixes for RISC-V anyway.
Ok, thanks for the feedback.
Best regards,
Romain
Quoted 18 lines
Alistair
Quoted 15 lines
Quoted 11 lines
Best regards,
RomainQuoted 6 lines
Marked as Changes Requested.
Regards,
Arnout_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot