Enable Xenstore-stubdom Live Update
v3 cover Enable Xenstore-stubdom Live Update
With this series applied I was able to perform Live Update of Xenstore running in a PVH stubdom.
One relevant change in this series is how the Xenstore state is being read after activating the new binary. Instead of using mmap() the state records are read one by one via fread(). This might have a small performance impact for the daemon live update case, but it should be neglectable.
Changes in V2:
- rebase
- former patches 1 and 2 have been committed already
- former patch 5 moved to start of the series (has all needed Acks)
- new patches 8 and 9
Changes in V3:
- minor changes in patches 1 and 5
Juergen Gross (9):
xenstored: use fread() instead of mmap() for reading live update state
libevtchn: add O_CLOEXEC support for Mini-OS
libxengnttab: set the cloexec flag on Mini-OS
xenstored: don't use xenevtchn_fdopen() in stubdom tools/libxenevtchn: add xenevtchn_bind() under Mini-OS
xenstored: rebind event channels after live update in stubdom tools/xenstored: make stubdom_init() live update aware SUPPORT.md: add xenstorepvh-stubdom live update CHANGELOG.md: add xenstorepvh-stubdom live update
CHANGELOG.md | 1 + SUPPORT.md | 2 +- tools/include/xenevtchn.h | 13 +++++ tools/libs/evtchn/minios.c | 23 +++++++-- tools/libs/gnttab/minios.c | 1 + tools/xenstored/core.c | 5 +- tools/xenstored/core.h | 8 +++- tools/xenstored/domain.c | 25 ++++++---- tools/xenstored/domain.h | 2 +- tools/xenstored/lu.c | 97 +++++++++++++++++++++++--------------- tools/xenstored/minios.c | 22 +++++++-- tools/xenstored/posix.c | 10 ++++ 12 files changed, 150 insertions(+), 59 deletions(-)
Signature · 1 line
2.43.0
PATCH v3 1/9 xenstored: use fread() instead of mmap() for reading live update state
Mini-OS doesn't support using mmap() for accessing a file. In order to support reading the live update state from a 9pfs based file, use fread() instead of mmap().
While adding the offset member to lu_state, change the type of "size" to size_t in order to avoid problems with state exceeding 4GB.
---
V2:
- move to start of series
V3:
- change offset to off64_t and size to size_t (Andrew Cooper)
--- tools/xenstored/lu.c | 97 +++++++++++++++++++++++++++----------------- 1 file changed, 60 insertions(+), 37 deletions(-)
tools/xenstored/lu.c +60 -37
@@ -27,9 +27,11 @@ struct live_update *lu_status;struct lu_dump_state {void *buf; -unsigned int size; -int fd; +unsigned int buf_size; +size_t size; +size_t offset;char *filename; +FILE *fp; };static int lu_destroy (void *data)
@@ -80,9 +82,10 @@ bool lu_is_pending(void)return lu_status !=NULL ; } -static void lu_get_dump_state (struct lu_dump_state *state) +static void lu_get_dump_state (void *ctx,struct lu_dump_state *state) {struct stat statbuf; +int fd; state->size =0 ;
@@ -91,82 +94,107 @@ static void lu_get_dump_state(struct lu_dump_state *state)if (!state->filename)barf ("Allocation failure" ); - state->fd =open (state->filename,O_RDONLY ); -if (state->fd <0 ) -return ; -if (fstat (state->fd, &statbuf) !=0 ) - goto out_close; + fd =open (state->filename,O_RDONLY ); +if (fd <0 ) +barf ("No state file found" ); +if (fstat (fd, &statbuf) !=0 ) +barf ("Could not fstat state file" ); state->size = statbuf.st_size; - state->buf =mmap (NULL , state->size,PROT_READ ,MAP_PRIVATE , - state->fd,0 ); -if (state->buf ==MAP_FAILED ) { - state->size =0 ; - goto out_close; - } +/* Start with a 4k buffer. If needed we'll reallocate a larger one. */ + state->buf_size =4096 ; + state->buf =talloc_size (ctx, state->buf_size); +if (!state->buf) +barf ("Allocation failure" ); -return ; + state->fp =fdopen (fd,"r" ); +} - out_close: -close (state->fd); +static void lu_dump_close (FILE *fp) +{ +fclose (fp); }static void lu_close_dump_state (struct lu_dump_state *state) {assert (state->filename !=NULL ); -munmap (state->buf, state->size); -close (state->fd); +lu_dump_close (state->fp);unlink (state->filename);talloc_free (state->filename); +talloc_free (state->buf); +} + +static void lu_read_data (void *ctx,struct lu_dump_state *state, +unsigned int size) +{ +if (state->offset + size > state->size) +barf ("Inconsistent state data" ); + +if (size > state->buf_size) { + state->buf =talloc_realloc_size (ctx, state->buf, size); +if (!state->buf) +barf ("Allocation failure" ); + state->buf_size = size; + } + +if (fread (state->buf, size,1 , state->fp) !=1 ) +barf ("State read error" ); + + state->offset += size; }void lu_read_state (void ) {struct lu_dump_state state = {}; -struct xs_state_record_header *head; +struct xs_state_record_header head;void *ctx =talloc_new (NULL );/* Work context for subfunctions. */ struct xs_state_preamble *pre;unsigned int version;syslog (LOG_INFO ,"live-update: read state\n" ); -lu_get_dump_state (&state); +lu_get_dump_state (ctx, &state);if (state.size ==0 )barf_perror ("No state found after live-update" ); +lu_read_data (ctx, &state,sizeof (*pre)); pre = state.buf; version =be32toh (pre->version);if (memcmp (pre->ident,XS_STATE_IDENT ,sizeof (pre->ident)) || !version || version >XS_STATE_VERSION || pre->flags !=XS_STATE_FLAGS )barf ("Unknown record identifier" ); -for (head = state.buf +sizeof (*pre); - head->type !=XS_STATE_TYPE_END && - (void *)head - state.buf < state.size; - head = (void *)head +sizeof (*head) + head->length) { -switch (head->type) { + +for (;;) { +lu_read_data (ctx, &state,sizeof (head)); + head = *(struct xs_state_record_header *)(state.buf); +if (head.type ==XS_STATE_TYPE_END ) +break ; +lu_read_data (ctx, &state, head.length); + +switch (head.type) {case XS_STATE_TYPE_GLOBAL : -read_state_global (ctx, head +1 ); +read_state_global (ctx, state.buf);break ;case XS_STATE_TYPE_CONN : -read_state_connection (ctx, head +1 ); +read_state_connection (ctx, state.buf);break ;case XS_STATE_TYPE_WATCH : -read_state_watch (ctx, head +1 ); +read_state_watch (ctx, state.buf);break ;case XS_STATE_TYPE_TA :xprintf ("live-update: ignore transaction record\n" );break ;case XS_STATE_TYPE_NODE : -read_state_node (ctx, head +1 ); +read_state_node (ctx, state.buf);break ;case XS_STATE_TYPE_DOMAIN : -read_state_domain (ctx, head +1 , version); +read_state_domain (ctx, state.buf, version);break ;default :xprintf ("live-update: unknown state record %08x\n" , - head->type); + head.type);break ; } }
@@ -271,11 +299,6 @@ static FILE *lu_dump_open(const void *ctx)return fdopen (fd,"w" ); } -static void lu_dump_close (FILE *fp) -{ -fclose (fp); -} -static const char *lu_dump_state (const void *ctx,struct connection *conn) {FILE *fp;
Signature · 1 line
2.43.0
Re: [PATCH v3 1/9] xenstored: use fread() instead of mmap() for reading live update state
Quoted 7 lines · Juergen Gross
Mini-OS doesn't support using
mmap()for accessing a file. In order to support reading the live update state from a 9pfs based file, usefread()instead ofmmap().While adding the offset member to
lu_state, change the type of "size" tosize_tin order to avoid problems with state exceeding 4GB.
Quoted 7 lines
Signed-off-by Juergen Gross <[email protected]>Reviewed-by Jason Andryuk <[email protected]>---
V2:
- move to start of series
V3:
- change offset tooff64_tand size tosize_t(Andrew Cooper)
Wasn't that meant to also cover ...
tools/xenstored/lu.c struct live_update *lu_status; · line 30
Quoted 9 lines
tools/xenstored/lu.c +1
-2@@ -27,9 +27,11 @@ struct live_update *lu_status;struct lu_dump_state {void *buf; -unsigned int size; -int fd; +unsigned int buf_size;
... this field?
Jan
Quoted 5 lines
tools/xenstored/lu.c +3
-0+size_t size; +size_t offset;char *filename; +FILE *fp; };
Re: [PATCH v3 1/9] xenstored: use fread() instead of mmap() for reading live update state
Quoted 22 lines · Jan Beulich
Quoted 7 lines · Juergen Gross
Mini-OS doesn't support using
mmap()for accessing a file. In order to support reading the live update state from a 9pfs based file, usefread()instead ofmmap().While adding the offset member to
lu_state, change the type of "size" tosize_tin order to avoid problems with state exceeding 4GB.Quoted 7 lines
Signed-off-by Juergen Gross <[email protected]>Reviewed-by Jason Andryuk <[email protected]>---
V2:
- move to start of series
V3:
- change offset tooff64_tand size tosize_t(Andrew Cooper)Wasn't that meant to also cover ...
Quoted 4 lines
tools/xenstored/lu.c +0
-0@@ -27,9 +27,11 @@ struct live_update *lu_status;
Quoted 7 lines
tools/xenstored/lu.c struct live_update *lu_status; · line 30
Quoted 5 lines
tools/xenstored/lu.c +1
-2struct lu_dump_state {void *buf; -unsigned int size; -int fd; +unsigned int buf_size;... this field?
As this buffer is for a single state record only, an unsigned int is always enough. The record header is using uint32_t for the record length.
Juergen
PATCH v3 2/9 libevtchn: add O_CLOEXEC support for Mini-OS
In reply to Juergen GrossWith Mini-OS now supporting O_CLOEXEC for the kexec case, no longer ignore the XENEVTCHN_NO_CLOEXEC flag in minios.c.
--- tools/libs/evtchn/minios.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
tools/libs/evtchn/minios.c +2 -4
@@ -114,10 +114,6 @@ static void evtchn_initialize(void) ftype_evtchn =alloc_file_type (&evtchn_ops); } -/* -* XENEVTCHN_NO_CLOEXEC is being ignored, as there is no exec() call supported -* in Mini-OS. -*/ int osdep_evtchn_open (xenevtchn_handle *xce,unsigned int flags) {int fd;
@@ -137,6 +133,8 @@ int osdep_evtchn_open(xenevtchn_handle *xce, unsigned int flags)return -1 ; } +if ( !(flags &XENEVTCHN_NO_CLOEXEC ) ) + file->cloexec = true; file->dev = ports;XEN_LIST_INIT (&ports->list); xce->fd = fd;
Signature · 1 line
2.43.0
PATCH v3 3/9 libxengnttab: set the cloexec flag on Mini-OS
In reply to Juergen GrossWith Mini-OS now supporting the O_CLOEXEC flag for the kexec case, set the related cloexec flag in minios.c.
--- tools/libs/gnttab/minios.c | 1 + 1 file changed, 1 insertion(+)
tools/libs/gnttab/minios.c +1 -0
@@ -74,6 +74,7 @@ int osdep_gnttab_open(xengnttab_handle *xgt) } file->dev = gntmap; + file->cloexec = true;gntmap_init (gntmap); xgt->fd = fd;return 0 ;
Signature · 1 line
2.43.0
PATCH v3 4/9 xenstored: don't use xenevtchn_fdopen() in stubdom
In reply to Juergen GrossWhen running in a stubdom environment xenevtchn_fdopen() won't work, as any file descriptor state is lost across kexec().
Use a wrapper to replace the call of xenevtchn_fdopen() with the really needed xenevtchn_open() when running on top of Mini-OS.
--- tools/xenstored/core.h | 3 +++ tools/xenstored/domain.c | 2 +- tools/xenstored/minios.c | 5 +++++ tools/xenstored/posix.c | 5 +++++ 4 files changed, 14 insertions(+), 1 deletion(-)
tools/xenstored/core.h +3 -0
@@ -29,6 +29,7 @@#include <stdint.h> #include <time.h> #include <errno.h> +#include <xenevtchn.h> #include "xenstore_lib.h" #include "xenstore_state.h"
@@ -405,6 +406,8 @@ void handle_special_fds(void);int get_socket_fd (void );void set_socket_fd (int fd); +xenevtchn_handle *evtchn_fdopen (int fd); +#ifdef __MINIOS__void mount_9pfs (void );#endif
tools/xenstored/domain.c +1 -1
@@ -1396,7 +1396,7 @@ void domain_init(int evtfd)if (evtfd <0 ) xce_handle =xenevtchn_open (NULL ,XENEVTCHN_NO_CLOEXEC );else - xce_handle =xenevtchn_fdopen (NULL , evtfd,0 ); + xce_handle =evtchn_fdopen (evtfd);if (xce_handle ==NULL )barf_perror ("Failed to open evtchn device" );
tools/xenstored/minios.c +5 -0
@@ -85,6 +85,11 @@ void set_socket_fd(int fd) { } +xenevtchn_handle *evtchn_fdopen (int fd) +{ +return xenevtchn_open (NULL ,XENEVTCHN_NO_CLOEXEC ); +} +static void mount_thread (void *p) {xenbus_event_queue events =NULL ;
tools/xenstored/posix.c +5 -0
@@ -408,6 +408,11 @@ void set_socket_fd(int fd) sock = fd; } +xenevtchn_handle *evtchn_fdopen (int fd) +{ +return xenevtchn_fdopen (NULL , fd,0 ); +} +const char *xenstore_rundir (void ) {return xenstore_daemon_rundir ();
Signature · 1 line
2.43.0
PATCH v3 5/9 tools/libxenevtchn: add xenevtchn_bind() under Mini-OS
In reply to Juergen GrossIn order to reactivate an event channel after kexec() of Mini-OS, libxenevtchn needs to allocate the port data for the event channel and set the handler again. Add a new interface xenevtchn_bind() for that purpose, available under Mini-OS only.
---
V3:
- add #ifdef __MINIOS__ (Anthony Perard)
--- tools/include/xenevtchn.h | 13 +++++++++++++ tools/libs/evtchn/minios.c | 17 +++++++++++++++++ 2 files changed, 30 insertions(+)
tools/include/xenevtchn.h +13 -0
@@ -173,6 +173,19 @@ int xenevtchn_unmask(xenevtchn_handle *xce, evtchn_port_t port);*/ int xenevtchn_restrict (xenevtchn_handle *xce,domid_t domid); +#ifdef __MINIOS__ +/** +* Bind an event channel under Mini-OS. +* +* Bind an event channel specified by its known port after a kexec() of +* Mini-OS. This function is available under Mini-OS only! +* +* @parm xce handle to the open evtchn interface +* @parm port the event channel to bind again +* @return 0 on success, -1 on failure with errno set appropriately. +*/ +int xenevtchn_bind (xenevtchn_handle *xce,evtchn_port_t port); +#endif #endif /*
tools/libs/evtchn/minios.c +17 -0
@@ -259,6 +259,23 @@ xenevtchn_port_or_error_t xenevtchn_bind_interdomain(xenevtchn_handle *xce,return local_port; } +int xenevtchn_bind (xenevtchn_handle *xce,evtchn_port_t port) +{ +struct port_info *port_info; + port_info =port_alloc (xce); +if ( port_info ==NULL ) +return -1 ; + +printf ("xenevtchn_bind(%" PRId32")\n" , port); +bind_evtchn (port, evtchn_handler, xce); + + port_info->bound = true; + port_info->port = port; +unmask_evtchn (port); + +return 0 ; +} +int xenevtchn_unbind (xenevtchn_handle *xce,evtchn_port_t port) {int fd = xce->fd;
Signature · 1 line
2.43.0
PATCH v3 6/9 xenstored: rebind event channels after live update in stubdom
In reply to Juergen GrossAfter performing a live update in stubdom environment some information about inter-domain event channels is lost. In order to set this information again, call xenevtchn_bind() from new_domain() in the restore case.
--- tools/xenstored/core.c | 1 - tools/xenstored/core.h | 3 +++ tools/xenstored/domain.c | 8 ++++++-- tools/xenstored/minios.c | 5 +++++ tools/xenstored/posix.c | 5 +++++ 5 files changed, 19 insertions(+), 3 deletions(-)
tools/xenstored/core.c +0 -1
@@ -49,7 +49,6 @@#include "control.h" #include "lu.h" -extern xenevtchn_handle *xce_handle;/* in domain.c */ static int xce_pollfd_idx =-1 ;struct pollfd *poll_fds;static unsigned int current_array_size;
tools/xenstored/core.h +3 -0
@@ -394,6 +394,8 @@ static inline bool domain_is_unprivileged(const struct connection *conn)return conn &&domid_is_unprivileged (conn->id); } +extern xenevtchn_handle *xce_handle;/* in domain.c */ +/* Return the event channel used by xenbus. */ evtchn_port_t get_xenbus_evtchn (void );void early_init (bool live_update,bool dofork,const char *pidfile);
@@ -407,6 +409,7 @@ int get_socket_fd(void);void set_socket_fd (int fd);xenevtchn_handle *evtchn_fdopen (int fd); +int evtchn_rebind (int port);#ifdef __MINIOS__void mount_9pfs (void );
tools/xenstored/domain.c +6 -2
@@ -862,9 +862,13 @@ static int new_domain(struct domain *domain, int port, bool restore)wrl_domain_new (domain); -if (restore) +if (restore) { +if (evtchn_rebind (port)) { + errno =ENOMEM ; +return errno; + } domain->port = port; -else { + }else {/* Tell kernel we're interested in this event. */ rc =xenevtchn_bind_interdomain (xce_handle, domain->domid, port);
tools/xenstored/minios.c +5 -0
@@ -90,6 +90,11 @@ xenevtchn_handle *evtchn_fdopen(int fd)return xenevtchn_open (NULL ,XENEVTCHN_NO_CLOEXEC ); } +int evtchn_rebind (int port) +{ +return xenevtchn_bind (xce_handle, port); +} +static void mount_thread (void *p) {xenbus_event_queue events =NULL ;
tools/xenstored/posix.c +5 -0
@@ -413,6 +413,11 @@ xenevtchn_handle *evtchn_fdopen(int fd)return xenevtchn_fdopen (NULL , fd,0 ); } +int evtchn_rebind (int port) +{ +return 0 ; +} +const char *xenstore_rundir (void ) {return xenstore_daemon_rundir ();
Signature · 1 line
2.43.0
PATCH v3 7/9 tools/xenstored: make stubdom_init() live update aware
In reply to Juergen GrossPass the live_update bool to stubdom_init() in order to be able to handle it properly under Mini-OS.
As stubdom_init() will (re-)create the 9pfs device needed for reading the saved state, call stubdom_init() before lu_read_state().
--- tools/xenstored/core.c | 4 ++-- tools/xenstored/core.h | 2 +- tools/xenstored/domain.c | 15 +++++++++------ tools/xenstored/domain.h | 2 +- tools/xenstored/minios.c | 12 +++++++++--- 5 files changed, 22 insertions(+), 13 deletions(-)
tools/xenstored/core.c +2 -2
@@ -2774,14 +2774,14 @@ int main(int argc, char *argv[])if (tracefile) tracefile =absolute_filename (NULL , tracefile); +stubdom_init (live_update); +#ifndef NO_LIVE_UPDATE /* Read state in case of live update. */ if (live_update)lu_read_state ();#endif -stubdom_init (); -check_store ();/* Get ready to listen to the tools. */
tools/xenstored/core.h +1 -1
@@ -412,7 +412,7 @@ xenevtchn_handle *evtchn_fdopen(int fd);int evtchn_rebind (int port);#ifdef __MINIOS__ -void mount_9pfs (void ); +void mount_9pfs (bool live_update);#endif const char *xenstore_rundir (void );
tools/xenstored/domain.c +9 -6
@@ -1337,7 +1337,7 @@ void dom0_init(void)xenevtchn_notify (xce_handle, dom0->port); } -void stubdom_init (void ) +void stubdom_init (bool live_update) {#ifdef __MINIOS__struct domain *stubdom;
@@ -1345,13 +1345,16 @@ void stubdom_init(void)if (stub_domid <0 )return ; - stubdom =introduce_domain (NULL , stub_domid, xenbus_evtchn, false); -if (!stubdom) -barf_perror ("Failed to initialize stubdom" ); +if (!live_update) { + stubdom =introduce_domain (NULL , stub_domid, xenbus_evtchn, + false); +if (!stubdom) +barf_perror ("Failed to initialize stubdom" ); -xenevtchn_notify (xce_handle, stubdom->port); +xenevtchn_notify (xce_handle, stubdom->port); + } -mount_9pfs (); +mount_9pfs (live_update);#endif }
tools/xenstored/domain.h +1 -1
@@ -93,7 +93,7 @@ int do_set_feature(const void *ctx, struct connection *conn,void domain_early_init (void );void domain_init (int evtfd);void dom0_init (void ); -void stubdom_init (void ); +void stubdom_init (bool live_update);void domain_deinit (void );void ignore_connection (struct connection *conn,unsigned int err);
tools/xenstored/minios.c +9 -3
@@ -131,15 +131,21 @@ static void mount_thread(void *p)free (err); } - p9_device =init_9pfront (0 ,XENSTORE_LIB_DIR ); + p9_device =init_9pfront2 (0 ,XENSTORE_LIB_DIR ,INIT9P_FLAG_KEXEC );/* Start logging if selected. */ reopen_log (); } -void mount_9pfs (void ) +void mount_9pfs (bool live_update) { -create_thread ("mount-9pfs" , mount_thread,NULL ); +if (!live_update) +create_thread ("mount-9pfs" , mount_thread,NULL ); +else { + p9_device =init_9pfront2 (0 ,XENSTORE_LIB_DIR , +INIT9P_FLAG_REINIT ); +reopen_log (); + } }const char *xenstore_rundir (void )
Signature · 1 line
2.43.0
PATCH v3 8/9 SUPPORT.md: add xenstorepvh-stubdom live update
In reply to Juergen GrossLive update is now working with the PVH variant of xenstore-stubdom.
---
V2:
- new patch
--- SUPPORT.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
SUPPORT.md +1 -1
@@ -280,7 +280,7 @@ or itself will not be regarded a security issue. ### C xenstore stubdom PVH Status: Supported - Status, Liveupdate: Not implemented + Status, Liveupdate: Supported ### OCaml xenstored daemon
Signature · 1 line
2.43.0
Re: [PATCH v3 8/9] SUPPORT.md: add xenstorepvh-stubdom live update
Ping?
Quoted 23 lines · Juergen Gross
Live update is now working with the PVH variant of xenstore-stubdom.
Signed-off-by Juergen Gross <[email protected]>---
V2:
- new patch--- SUPPORT.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)SUPPORT.md +1
-1@@ -280,7 +280,7 @@ or itself will not be regarded a security issue. ### C xenstore stubdom PVH Status: Supported - Status, Liveupdate: Not implemented + Status, Liveupdate: Supported ### OCaml xenstored daemon
Re: [PATCH v3 8/9] SUPPORT.md: add xenstorepvh-stubdom live update
Quoted 13 lines · Juergen Gross
Ping?
Quoted 10 lines · Juergen Gross
Live update is now working with the PVH variant of xenstore-stubdom.
Signed-off-by Juergen Gross <[email protected]>---
V2:
- new patch
---
SUPPORT.md | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines
Quoted 10 lines
SUPPORT.md +0
-0@@ -280,7 +280,7 @@ or itself will not be regarded a security issue. ### C xenstore stubdom PVHStatus: Supported
- Status, Liveupdate: Not implemented
+ Status, Liveupdate: Supported
### OCaml xenstored daemon
And 40 days after sending out: PING?
Juergen
Re: [PATCH v3 8/9] SUPPORT.md: add xenstorepvh-stubdom live update
In reply to Juergen GrossHi Juergen,
Sorry for the late answer.
Quoted 14 lines · Juergen Gross
Live update is now working with the PVH variant of xenstore-stubdom.
Quoted 1 line
Signed-off-by Juergen Gross <[email protected]>---
V2:
- new patch--- SUPPORT.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)SUPPORT.md +0
-0
SUPPORT.md or itself will not be regarded a security issue. · line 283
Quoted 5 lines
SUPPORT.md +1
-1@@ -280,7 +280,7 @@ or itself will not be regarded a security issue. ### C xenstore stubdom PVH Status: Supported - Status, Liveupdate: Not implemented + Status, Liveupdate: Supported
I went through the changes in Xenstored for the stubdom and I have one question regarding [1]. Does this mean the event channel will be closed during Live-Update? Asking because I vaguely remember we need to keep them open to avoid losing events. I am wondering how this would work in stubdom?
Cheers,
Quoted 3 lines
SUPPORT.md +0
-0### OCaml xenstored daemon
Signature · 1 line
Julien Grall
Re: [PATCH v3 8/9] SUPPORT.md: add xenstorepvh-stubdom live update
Quoted 14 lines · Julien Grall
Hi Juergen,
Sorry for the late answer.
Quoted 9 lines · Juergen Gross
Live update is now working with the PVH variant of xenstore-stubdom.
Quoted 1 line
Signed-off-by Juergen Gross <[email protected]>---
V2:
- new patch
---
SUPPORT.md | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines
Quoted 9 lines
SUPPORT.md +0
-0@@ -280,7 +280,7 @@ or itself will not be regarded a security issue. ### C xenstore stubdom PVHStatus: Supported
- Status, Liveupdate: Not implemented
+ Status, Liveupdate: SupportedI went through the changes in Xenstored for the stubdom and I have one question regarding [1]. Does this mean the event channel will be closed during Live-Update? Asking because I vaguely remember we need to keep them open to avoid losing events. I am wondering how this would work in stubdom?
I forgot to mention, this is the only thing blocking my ack for this patch.
Cheers,
Signature · 1 line
Julien Grall
Re: [PATCH v3 8/9] SUPPORT.md: add xenstorepvh-stubdom live update
In reply to Julien GrallQuoted 14 lines · Julien Grall
Hi Juergen,
Sorry for the late answer.
Quoted 9 lines · Juergen Gross
Live update is now working with the PVH variant of xenstore-stubdom.
Quoted 1 line
Signed-off-by Juergen Gross <[email protected]>---
V2:
- new patch
---
SUPPORT.md | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines
Quoted 9 lines
SUPPORT.md +0
-0@@ -280,7 +280,7 @@ or itself will not be regarded a security issue. ### C xenstore stubdom PVHStatus: Supported
- Status, Liveupdate: Not implemented
+ Status, Liveupdate: SupportedI went through the changes in Xenstored for the stubdom and I have one question regarding [1]. Does this mean the event channel will be closed during Live- Update? Asking because I vaguely remember we need to keep them open to avoid losing events. I am wondering how this would work in stubdom?
The event channel is still open, its just the Mini-OS internals that don't know about this. This is the reason for calling xenevtchn_bind() to bring hypervisor and Mini-OS view in sync again, without changing the hypervisor side.
Juergen
Julien Grall
Acked-byRe: [PATCH v3 8/9] SUPPORT.md: add xenstorepvh-stubdom live update
Hi Juergen,
Quoted 27 lines · Jürgen Groß
Quoted 14 lines · Julien Grall
Hi Juergen,
Sorry for the late answer.
Quoted 1 line · Juergen Gross
Live update is now working with the PVH variant of xenstore-stubdom.
> > Signed-off-by: Juergen Gross <[email protected]>
Quoted 7 lines
---
V2:
- new patch
---
SUPPORT.md | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)Quoted 11 lines
Quoted 9 lines
SUPPORT.md +0
-0@@ -280,7 +280,7 @@ or itself will not be regarded a security issue. ### C xenstore stubdom PVHStatus: Supported
- Status, Liveupdate: Not implemented
+ Status, Liveupdate: SupportedI went through the changes in Xenstored for the stubdom and I have one question regarding [1]. Does this mean the event channel will be closed during Live- Update? Asking because I vaguely remember we need to keep them open to avoid losing events. I am wondering how this would work in stubdom?
Quoted 4 lines
The event channel is still open, its just the Mini-OS internals that don't know about this. This is the reason for calling
xenevtchn_bind()to bring hypervisor and Mini-OS view in sync again, without changing the hypervisor side.
Thanks for the clarification.
Cheers,
Signature · 1 line
Julien Grall
PATCH v3 9/9 CHANGELOG.md: add xenstorepvh-stubdom live update
In reply to Juergen Gross---
V2:
- new patch
--- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+)
CHANGELOG.md +1 -0
@@ -26,6 +26,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Support PCI passthrough for HVM domUs when dom0 is PVH (note SR-IOV capability usage is not yet supported on PVH dom0). - Smoke tests for the FreeBSD Xen builds in Cirrus CI. + - PVH xenstore-stubdom now supports Live Update. - On Arm: - Ability to enable stack protector
Signature · 1 line
2.43.0
Re: [PATCH v3 9/9] CHANGELOG.md: add xenstorepvh-stubdom live update
Ping?
Quoted 20 lines · Juergen Gross
Signed-off-by Juergen Gross <[email protected]>---
V2:
- new patch--- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+)CHANGELOG.md +1
-0@@ -26,6 +26,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Support PCI passthrough for HVM domUs when dom0 is PVH (note SR-IOV capability usage is not yet supported on PVH dom0). - Smoke tests for the FreeBSD Xen builds in Cirrus CI. + - PVH xenstore-stubdom now supports Live Update. - On Arm: - Ability to enable stack protector
Re: [PATCH v3 9/9] CHANGELOG.md: add xenstorepvh-stubdom live update
Quoted 11 lines · Juergen Gross
Ping?
Quoted 8 lines · Juergen Gross
Signed-off-by Juergen Gross <[email protected]>---
V2:
- new patch
---
CHANGELOG.md | 1 +1 file changed, 1 insertion(+)
Quoted 10 lines
Quoted 10 lines
CHANGELOG.md +0
-0@@ -26,6 +26,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)- Support PCI passthrough for HVM domUs when dom0 is PVH (note SR-IOV capability usage is not yet supported on PVH dom0).
- Smoke tests for the FreeBSD Xen builds in Cirrus CI.
+ - PVH xenstore-stubdom now supports Live Update.
LGTM: Acked-by: Oleksii Kurochko<[email protected]>
Thanks.
~ Oleksii
Quoted 3 lines
Quoted 2 lines
- On Arm:
- Ability to enable stack protector