Skip to contentSkip to conversation

wifi: rtw88: Add support for Mercusys MA30N and D-Link DWA-T185 rev. A1

PATCH In review Zenm Chen 2 participants 5 messages Feb 10, 2025 – Feb 21, 2025 Realtek wireless driver (rtw88)

lore
Share & tools
lore

Zenm Chen

author
#0 lore raw

PATCH 1/1 wifi: rtw88: Add support for Mercusys MA30N and D-Link DWA-T185 rev. A1

Add two more USB IDs found in
https://github.com/RinCat/RTL88x2BU-Linux-Driver
to support Mercusys MA30N and D-Link DWA-T185 rev. A1.

Signed-off-by Zenm Chen <[email protected]>

---
Related discussions:
https://github.com/RinCat/RTL88x2BU-Linux-Driver/issues/237
https://github.com/RinCat/RTL88x2BU-Linux-Driver/issues/146

---
 drivers/net/wireless/realtek/rtw88/rtw8822bu.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/wireless/realtek/rtw88/rtw8822bu.c +4 -0
index 8883300fc6ad..572d1f31832e 100644
@@ -73,6 +73,10 @@ static const struct usb_device_id rtw_8822bu_id_table[] = {
 	  .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* ELECOM WDB-867DU3S */
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x2c4e, 0x0107, 0xff, 0xff, 0xff),
 	  .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* Mercusys MA30H */
+	{ USB_DEVICE_AND_INTERFACE_INFO(0x2c4e, 0x010a, 0xff, 0xff, 0xff),
+	  .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* Mercusys MA30N */
+	{ USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x3322, 0xff, 0xff, 0xff),
+	  .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* D-Link DWA-T185 rev. A1 */
 	{},
 };
 MODULE_DEVICE_TABLE(usb, rtw_8822bu_id_table);
Signature · 1 line
2.48.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Zenm Chen

Add two more USB IDs found in
https://github.com/RinCat/RTL88x2BU-Linux-Driver
to support Mercusys MA30N and D-Link DWA-T185 rev. A1.

Signed-off-by Zenm Chen <[email protected]>
Acked-by Ping-Ke Shih <[email protected]>
Quoted 14 lines

---
Related discussions:
https://github.com/RinCat/RTL88x2BU-Linux-Driver/issues/237
https://github.com/RinCat/RTL88x2BU-Linux-Driver/issues/146

---
 drivers/net/wireless/realtek/rtw88/rtw8822bu.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/wireless/realtek/rtw88/rtw8822bu.c +0 -0
index 8883300fc6ad..572d1f31832e 100644

drivers/net/wireless/realtek/rtw88/rtw8822bu.c static const struct usb_device_id rtw_8822bu_id_table[] = { · line 79

Quoted 7 lines
drivers/net/wireless/realtek/rtw88/rtw8822bu.c +4 -0
@@ -73,6 +73,10 @@ static const struct usb_device_id rtw_8822bu_id_table[] = {
          .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* ELECOM WDB-867DU3S */
        { USB_DEVICE_AND_INTERFACE_INFO(0x2c4e, 0x0107, 0xff, 0xff, 0xff),
          .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* Mercusys MA30H */
+       { USB_DEVICE_AND_INTERFACE_INFO(0x2c4e, 0x010a, 0xff, 0xff, 0xff),
+         .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* Mercusys MA30N */
+       { USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x3322, 0xff, 0xff, 0xff),
+         .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* D-Link DWA-T185 rev. A1 */

By the way, these IDs aren't in increasing order, how did you pick IDs from vendor driver?

Not sure if it's worth to sort these IDs so that it would be easier to align IDs with vendor driver (it should be sorted as well).

author
#2 lore raw
Quoted 2 lines

By the way, these IDs aren't in increasing order, how did you pick IDs from vendor driver?

Mikhail Novosyolov taught me a good command [1] to find out the missing USB IDs. :)

$ diff -u --color \
<(modinfo a.ko | grep ^alias | sort -u) \
<(modinfo b.ko | grep ^alias | sort -u)

[1] https://github.com/morrownr/88x2bu-20210702/issues/224#issuecomment-2404823387

Quoted 2 lines

Not sure if it's worth to sort these IDs so that it would be easier to align IDs with vendor driver (it should be sorted as well).

okay, I will send another patch to sort them after this is merged.

maintainer
#3 lore raw
Quoted 12 lines
Quoted 2 lines

By the way, these IDs aren't in increasing order, how did you pick IDs from vendor driver?

Mikhail Novosyolov taught me a good command [1] to find out the missing USB IDs. :)

$ diff -u --color \
<(modinfo a.ko | grep ^alias | sort -u) \
<(modinfo b.ko | grep ^alias | sort -u)

[1] https://github.com/morrownr/88x2bu-20210702/issues/224#issuecomment-2404823387

Cool. I thought you compared them with source code rather than binary code. So maybe it is not necessary to align them in source code.

maintainer
#4 lore raw
In reply to Zenm Chen
Quoted 6 lines · Zenm Chen

Add two more USB IDs found in
https://github.com/RinCat/RTL88x2BU-Linux-Driver
to support Mercusys MA30N and D-Link DWA-T185 rev. A1.

Signed-off-by Zenm Chen <[email protected]>
Acked-by Ping-Ke Shih <[email protected]>

1 patch(es) applied to rtw-next branch of rtw.git, thanks.

80c4668d024f wifi: rtw88: Add support for Mercusys MA30N and D-Link DWA-T185 rev. A1

---
https://github.com/pkshih/rtw.git