Power Supply Cold Redundancy
Hi Brad & James,
I am going to upstream an Intel specific feature called Power Supply Cold Redundancy which is to keep one PSU in standby mode when there are two PSU on the system.
You can get more information about this feature in design doc https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/27637
My question is which repo should I push the code, is there any exist repo maintain all PSU related features? If not can you help to create a repo for this?
Thank you very much!
Quoted 7 lines · Cheng C
Hi Brad & James,
I am going to upstream an Intel specific feature called Power
Supply Cold Redundancy which is to keep one PSU in standby mode when there are two PSU on the system.
Quoted 6 lines
You can get more information about this feature in design doc
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/27637My question is which repo should I push the code, is there any exist repo maintain all PSU related features? If not can you help to create a repo for this?
phosphor-power is the repo for power supply related services and tools, and it has a C++ i2c library that could be used to interact with i2c devices.
It looks like a good place to add the service.
Be noted that if you have PSU driver bind to the device, e.g. for PSU vin/vout/fault monitor, it's not possible to do i2c read/write directly, unless you unbind the driver.
Originally, I also thought I may push my code to phosphor-power, but when I was trying to devtool modify phosphor-power, I found a error happen
ERROR: Nothing PROVIDES 'openpower-dbus-interfaces' (but /home/cyang29/openbmc-openbmc/meta-phosphor/recipes-phosphor/power/phosphor-power_git.bb DEPENDS on or otherwise requires it).
We do not use openpower-dbus-interfaces.
Quoted 22 lines · Lei YU
Quoted 6 lines · Cheng C
Hi Brad & James,
I am going to upstream an Intel specific feature called Power
Supply Cold Redundancy which is to keep one PSU in standby mode when there are two PSU on the system.Quoted 6 lines
You can get more information about this feature in design doc
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/27637My question is which repo should I push the code, is there any exist repo maintain all PSU related features? If not can you help to create a repo for this?
phosphor-power is the repo for power supply related services and tools, and it has a C++ i2c library that could be used to interact with i2c devices.
It looks like a good place to add the service.Be noted that if you have PSU driver bind to the device, e.g. for PSU vin/vout/fault monitor, it's not possible to do i2c read/write directly, unless you unbind the driver.
Quoted 9 lines · Cheng C
Originally, I also thought I may push my code to phosphor-power, but when I was trying to devtool modify phosphor-power, I found a error happen
ERROR: Nothing PROVIDES 'openpower-dbus-interfaces' (but
/home/cyang29/openbmc-openbmc/meta-phosphor/recipes-phosphor/power/phosphor-power_git.bbDEPENDS on or otherwise requires it).We do not use openpower-dbus-interfaces.
Right, that is a problem, and the good news is that Matt is already moving openpower-dbus-interfaces into phosphor-dbus-interfaces
(https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/27380),
so it will be no problem in future :)
Quoted 14 lines · Lei YU
Quoted 8 lines · Cheng C
Originally, I also thought I may push my code to phosphor-power, but when I was trying to devtool modify phosphor-power, I found a error happen
ERROR: Nothing PROVIDES 'openpower-dbus-interfaces' (but
/home/cyang29/openbmc-openbmc/meta-phosphor/recipes-phosphor/power/phosphor-power_git.bbDEPENDS on or otherwise requires it).
Quoted 6 lines
Quoted 1 line
We do not use openpower-dbus-interfaces.
Right, that is a problem, and the good news is that Matt is already moving openpower-dbus-interfaces into phosphor-dbus-interfaces
(https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/27380),
so it will be no problem in future :)
This ^ does help but I don’t think its the whole story. It sounds like phosphor-power needs a meson option to turn off its dependency on org.openpower dbus interfaces…regardless of what repository is providing those.
Going a step further - what are the org.openpower interfaces that phosphor-power depends on anyway? Can they just be moved to xyz.openbmc_project?
-brad
Quoted 22 lines · Brad Bishop
Quoted 15 lines · Lei YU
Quoted 8 lines · Cheng C
Originally, I also thought I may push my code to phosphor-power, but when I was trying to devtool modify phosphor-power, I found a error happen
ERROR: Nothing PROVIDES 'openpower-dbus-interfaces' (but
/home/cyang29/openbmc-openbmc/meta-phosphor/recipes-phosphor/power/phosphor-power_git.bbDEPENDS on or otherwise requires it).Quoted 6 lines
Quoted 1 line
We do not use openpower-dbus-interfaces.
Right, that is a problem, and the good news is that Matt is already moving openpower-dbus-interfaces into phosphor-dbus-interfaces
(https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/27380),
so it will be no problem in future :)
Quoted 5 lines
This ^ does help but I don’t think its the whole story. It sounds like phosphor-power needs a meson option to turn off its dependency on org.openpower dbus interfaces…regardless of what repository is providing those.
Going a step further - what are the org.openpower interfaces that phosphor-power depends on anyway? Can they just be moved to xyz.openbmc_project?
-brad
I am not looking to chase anyone away from phosphor-power, but I do recall seeing some power supply related commits in x86-power-control, which seems to be some intel related repository.
https://github.com/openbmc/x86-power-control/commits/master
Hi Wyman,
X86-power-control only contains some power on/off related features, we do not have any plan to put any PSU related feature to it.
Thank you very much!
Quoted 28 lines · Brandon Wyman
Quoted 18 lines · Brad Bishop
Quoted 13 lines · Lei YU
Quoted 7 lines · Cheng C
Originally, I also thought I may push my code to phosphor-power, but when I was trying to devtool modify phosphor-power, I found a error happen
ERROR: Nothing PROVIDES 'openpower-dbus-interfaces' (but
/home/cyang29/openbmc-openbmc/meta-phosphor/recipes-phosphor/power/phosphor-power_git.bbDEPENDS on or otherwise requires it).Quoted 5 lines
Quoted 1 line
We do not use openpower-dbus-interfaces.
Right, that is a problem, and the good news is that Matt is already moving openpower-dbus-interfaces into phosphor-dbus-interfaces
(https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/27380),
so it will be no problem in future :)Quoted 5 lines
This ^ does help but I don’t think its the whole story. It sounds like phosphor-power needs a meson option to turn off its dependency on org.openpower dbus interfaces…regardless of what repository is providing those.
Going a step further - what are the org.openpower interfaces that phosphor-power depends on anyway? Can they just be moved to xyz.openbmc_project?
-brad
I am not looking to chase anyone away from phosphor-power, but I do recall seeing some power supply related commits in x86-power-control, which seems to be some intel related repository.
https://github.com/openbmc/x86-power-control/commits/master
Quoted 17 lines · Brad Bishop
Quoted 17 lines · Lei YU
Quoted 9 lines · Cheng C
Originally, I also thought I may push my code to phosphor-power, but when I was trying to devtool modify phosphor-power, I found a error happen
ERROR: Nothing PROVIDES 'openpower-dbus-interfaces' (but
/home/cyang29/openbmc-openbmc/meta-phosphor/recipes-phosphor/power/phosphor-power_git.bbDEPENDS on or otherwise requires it).We do not use openpower-dbus-interfaces.
Quoted 8 lines
Quoted 4 lines
Right, that is a problem, and the good news is that Matt is already moving openpower-dbus-interfaces into phosphor-dbus-interfaces
(https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/27380),
so it will be no problem in future :)This ^ does help but I don’t think its the whole story. It sounds like phosphor-power needs a meson option to turn off its dependency on org.openpower dbus interfaces…regardless of what repository is providing those.
Going a step further - what are the org.openpower interfaces that phosphor-power depends on anyway? Can they just be moved to xyz.openbmc_project?
There is nothing special but an interface defined in org.open_power. When Matt's commit of moving openpower-dbus-interfaces into phosphor-dbus-interfaces is merged, the related code in phosphor-power could be simply moved to xyz.openbmc_project.