Skip to contentSkip to conversation

drivers: tty: serial: Add missing of_node_put() in serial-tegra.c

PATCH In review heliang 5 participants 10 messages Jun 15, 2022 – Jun 16, 2022

Subsystems (4)
lore
Share & tools
lore

heliang

author
#0 lore raw

PATCH 1/1 drivers: tty: serial: Add missing of_node_put() in serial-tegra.c

In tegra_uart_init(), of_find_matching_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore.

---
 drivers/tty/serial/serial-tegra.c | 1 +
 1 file changed, 1 insertion(+)
drivers/tty/serial/serial-tegra.c +1 -0
index d942ab152f5a..5c4850a3762c 100644
@@ -1667,6 +1667,7 @@ static int __init tegra_uart_init(void)
 	node = of_find_matching_node(NULL, tegra_uart_of_match);
 	if (node)
 		match = of_match_node(tegra_uart_of_match, node);
+	of_node_put(node);
 	if (match)
 		cdata = match->data;
 	if (cdata)
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 5 lines · heliang

In tegra_uart_init(), of_find_matching_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore.

We need a real name please, one you sign documents with.

thanks,

greg k-h

#2 lore raw
Quoted 9 lines · Greg KH
Quoted 5 lines · heliang

In tegra_uart_init(), of_find_matching_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore.

We need a real name please, one you sign documents with.

How do we enforce that? What if Wong, Adele or Beyonce submit a patch?

What happens if that patch gets reposted, with S-o-b: He Liang <[email protected]> or Hel Iang, Heli Ang? Do you know any of those are real names? What happens if they post a real name in Mandarin/Thai/Cyrillic, can you validate it?

Really we require you have an identity attached to an email. If there is a problem in the future, we'd prefer the email continues to work so that you are contactable. If you are submitting a small amount of changes it's probably never going to matter. If you are submitting larger bodies of work of course it would be good to have a company or larger org attached to track things down legally later, but again that isn't always possible.

I don't think alienating the numerous developers who no longer use their legal names are identified by one name, but haven't changed their legal one yet people who get married and change their legal name but don't change their contribution name and I could run this sentence on forever.

Dave.

#3 lore raw
Quoted 27 lines · Dave Airlie
Quoted 9 lines · Greg KH
Quoted 5 lines · heliang

In tegra_uart_init(), of_find_matching_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore.

We need a real name please, one you sign documents with.

How do we enforce that? What if Wong, Adele or Beyonce submit a patch?

What happens if that patch gets reposted, with S-o-b: He Liang <[email protected]> or Hel Iang, Heli Ang? Do you know any of those are real names? What happens if they post a real name in Mandarin/Thai/Cyrillic, can you validate it?

Really we require you have an identity attached to an email. If there is a problem in the future, we'd prefer the email continues to work so that you are contactable. If you are submitting a small amount of changes it's probably never going to matter. If you are submitting larger bodies of work of course it would be good to have a company or larger org attached to track things down legally later, but again that isn't always possible.

Quoted 5 lines

I don't think alienating the numerous developers who no longer use their legal names are identified by one name, but haven't changed their legal one yet people who get married and change their legal name but don't change their contribution name and I could run this sentence on forever.

Yeah like absolute best case trying to "enforce" this just results in encouraging people to come up with entirely fake but English looking names for themselves. Which ... just no.
-Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
maintainer
#4 lore raw
Quoted 34 lines · Daniel Vetter
Quoted 27 lines · Dave Airlie
Quoted 9 lines · Greg KH
Quoted 5 lines · heliang

In tegra_uart_init(), of_find_matching_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore.

We need a real name please, one you sign documents with.

How do we enforce that? What if Wong, Adele or Beyonce submit a patch?

What happens if that patch gets reposted, with S-o-b: He Liang <[email protected]> or Hel Iang, Heli Ang? Do you know any of those are real names? What happens if they post a real name in Mandarin/Thai/Cyrillic, can you validate it?

Really we require you have an identity attached to an email. If there is a problem in the future, we'd prefer the email continues to work so that you are contactable. If you are submitting a small amount of changes it's probably never going to matter. If you are submitting larger bodies of work of course it would be good to have a company or larger org attached to track things down legally later, but again that isn't always possible.

Quoted 5 lines

I don't think alienating the numerous developers who no longer use their legal names are identified by one name, but haven't changed their legal one yet people who get married and change their legal name but don't change their contribution name and I could run this sentence on forever.

Quoted 3 lines

Yeah like absolute best case trying to "enforce" this just results in encouraging people to come up with entirely fake but English looking names for themselves. Which ... just no.

Agree, again, I'd prefer to take real names in native languages, our tools can handle that just fine. No need to make up anything.

thanks,

greg k-h

author
#5 lore raw
Quoted 39 lines · Greg KH
Quoted 34 lines · Daniel Vetter
Quoted 27 lines · Dave Airlie
Quoted 9 lines · Greg KH
Quoted 5 lines · heliang

In tegra_uart_init(), of_find_matching_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore.

We need a real name please, one you sign documents with.

How do we enforce that? What if Wong, Adele or Beyonce submit a patch?

What happens if that patch gets reposted, with S-o-b: He Liang <[email protected]> or Hel Iang, Heli Ang? Do you know any of those are real names? What happens if they post a real name in Mandarin/Thai/Cyrillic, can you validate it?

Really we require you have an identity attached to an email. If there is a problem in the future, we'd prefer the email continues to work so that you are contactable. If you are submitting a small amount of changes it's probably never going to matter. If you are submitting larger bodies of work of course it would be good to have a company or larger org attached to track things down legally later, but again that isn't always possible.

Quoted 5 lines

I don't think alienating the numerous developers who no longer use their legal names are identified by one name, but haven't changed their legal one yet people who get married and change their legal name but don't change their contribution name and I could run this sentence on forever.

Quoted 3 lines

Yeah like absolute best case trying to "enforce" this just results in encouraging people to come up with entirely fake but English looking names for themselves. Which ... just no.

Quoted 6 lines

Agree, again, I'd prefer to take real names in native languages, our tools can handle that just fine. No need to make up anything.

thanks,

greg k-h

hi, Greg K-H,

I have resent a new patch for my commit of tegra_uart_init() bug with my real name for Sob.

So there is anyother thing I should do?

#6 lore raw
Quoted 44 lines · Liang He

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 41 lines · Greg KH
Quoted 34 lines · Daniel Vetter
Quoted 27 lines · Dave Airlie
Quoted 9 lines · Greg KH
Quoted 5 lines · heliang

In tegra_uart_init(), of_find_matching_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore.

We need a real name please, one you sign documents with.

How do we enforce that? What if Wong, Adele or Beyonce submit a patch?

What happens if that patch gets reposted, with S-o-b: He Liang <[email protected]> or Hel Iang, Heli Ang? Do you know any of those are real names? What happens if they post a real name in Mandarin/Thai/Cyrillic, can you validate it?

Really we require you have an identity attached to an email. If there is a problem in the future, we'd prefer the email continues to work so that you are contactable. If you are submitting a small amount of changes it's probably never going to matter. If you are submitting larger bodies of work of course it would be good to have a company or larger org attached to track things down legally later, but again that isn't always possible.

Quoted 5 lines

I don't think alienating the numerous developers who no longer use their legal names are identified by one name, but haven't changed their legal one yet people who get married and change their legal name but don't change their contribution name and I could run this sentence on forever.

Quoted 3 lines

Yeah like absolute best case trying to "enforce" this just results in encouraging people to come up with entirely fake but English looking names for themselves. Which ... just no.

Agree, again, I'd prefer to take real names in native languages, our tools can handle that just fine. No need to make up anything.

Since this is the only mail from this chain in my inbox and I asked the same question as Greg on other patches:
I think it is pretty reasonable to /ask/ if something is not a real name when you see something like "heliang <[email protected]>" where there's a clear difference. And "It is my real name" is a perfectly reasonable response /shrug.
Trust but verify right? It's not like I'm gonna argue the toss with someone if they say it is their real name...

Thanks,
Conchubhar ;)

Quoted 10 lines
Quoted 4 lines

thanks,

greg k-h

hi, Greg K-H,

I have resent a new patch for my commit of tegra_uart_init() bug with my real name for Sob.

So there is anyother thing I should do?

author
#7 lore raw
Quoted 55 lines · At 2022-06-16 17:20:24, [email protected] wrote:
Quoted 44 lines · Liang He

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 41 lines · Greg KH
Quoted 34 lines · Daniel Vetter
Quoted 27 lines · Dave Airlie
Quoted 9 lines · Greg KH
Quoted 5 lines · heliang

In tegra_uart_init(), of_find_matching_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore.

We need a real name please, one you sign documents with.

How do we enforce that? What if Wong, Adele or Beyonce submit a patch?

What happens if that patch gets reposted, with S-o-b: He Liang <[email protected]> or Hel Iang, Heli Ang? Do you know any of those are real names? What happens if they post a real name in Mandarin/Thai/Cyrillic, can you validate it?

Really we require you have an identity attached to an email. If there is a problem in the future, we'd prefer the email continues to work so that you are contactable. If you are submitting a small amount of changes it's probably never going to matter. If you are submitting larger bodies of work of course it would be good to have a company or larger org attached to track things down legally later, but again that isn't always possible.

Quoted 5 lines

I don't think alienating the numerous developers who no longer use their legal names are identified by one name, but haven't changed their legal one yet people who get married and change their legal name but don't change their contribution name and I could run this sentence on forever.

Quoted 3 lines

Yeah like absolute best case trying to "enforce" this just results in encouraging people to come up with entirely fake but English looking names for themselves. Which ... just no.

Agree, again, I'd prefer to take real names in native languages, our tools can handle that just fine. No need to make up anything.

Since this is the only mail from this chain in my inbox and I asked the same question as Greg on other patches:
I think it is pretty reasonable to /ask/ if something is not a real name when you see something like "heliang <[email protected]>" where there's a clear difference. And "It is my real name" is a perfectly reasonable response /shrug.
Trust but verify right? It's not like I'm gonna argue the toss with someone if they say it is their real name...

Quoted 14 lines

Thanks,
Conchubhar ;)

Quoted 10 lines
Quoted 4 lines

thanks,

greg k-h

hi, Greg K-H,

I have resent a new patch for my commit of tegra_uart_init() bug with my real name for Sob.

So there is anyother thing I should do?

Sorry, Conor and Grep K-H.

I did not explain clearly and I respect all your suggestions.

I have resent with 'Liang He' as my real name for all patches which I sent with heliang yesterday. And I use '[PATCH v2]' for there resent patches.

Sorry again.

#8 lore raw
Quoted 68 lines · Liang He

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 65 lines · At 2022-06-16 17:20:24, [email protected] wrote:
Quoted 44 lines · Liang He

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 41 lines · Greg KH
Quoted 34 lines · Daniel Vetter
Quoted 27 lines · Dave Airlie
Quoted 9 lines · Greg KH
Quoted 5 lines · heliang

In tegra_uart_init(), of_find_matching_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore.

We need a real name please, one you sign documents with.

How do we enforce that? What if Wong, Adele or Beyonce submit a patch?

What happens if that patch gets reposted, with S-o-b: He Liang <[email protected]> or Hel Iang, Heli Ang? Do you know any of those are real names? What happens if they post a real name in Mandarin/Thai/Cyrillic, can you validate it?

Really we require you have an identity attached to an email. If there is a problem in the future, we'd prefer the email continues to work so that you are contactable. If you are submitting a small amount of changes it's probably never going to matter. If you are submitting larger bodies of work of course it would be good to have a company or larger org attached to track things down legally later, but again that isn't always possible.

Quoted 5 lines

I don't think alienating the numerous developers who no longer use their legal names are identified by one name, but haven't changed their legal one yet people who get married and change their legal name but don't change their contribution name and I could run this sentence on forever.

Quoted 3 lines

Yeah like absolute best case trying to "enforce" this just results in encouraging people to come up with entirely fake but English looking names for themselves. Which ... just no.

Agree, again, I'd prefer to take real names in native languages, our tools can handle that just fine. No need to make up anything.

Since this is the only mail from this chain in my inbox and I asked the same question as Greg on other patches:
I think it is pretty reasonable to /ask/ if something is not a real name when you see something like "heliang <[email protected]>" where there's a clear difference. And "It is my real name" is a perfectly reasonable response /shrug.
Trust but verify right? It's not like I'm gonna argue the toss with someone if they say it is their real name...

Thanks,
Conchubhar ;)

Quoted 7 lines
Quoted 4 lines

thanks,

greg k-h

hi, Greg K-H,

Quoted 7 lines
Quoted 4 lines
Quoted 3 lines

I have resent a new patch for my commit of tegra_uart_init() bug with my real name for Sob.

So there is anyother thing I should do?

Sorry, Conor and Grep K-H.

No need to apologise, my mail was directed at Daniel & Dave not you :)

Quoted 7 lines

I did not explain clearly and I respect all your suggestions.

I have resent with 'Liang He' as my real name for all patches which I sent with heliang yesterday. And I use '[PATCH v2]' for there resent patches.

Sorry again.

maintainer
#9 lore raw
In reply to Dave Airlie
Quoted 7 lines · Dave Airlie
Quoted 6 lines · Greg KH
Quoted 4 lines · heliang

In tegra_uart_init(), of_find_matching_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

We need a real name please, one you sign documents with.

How do we enforce that? What if Wong, Adele or Beyonce submit a patch?

As per our rules in the kernel, we can not accept a signed-off-by by a known anonymous person. When you can obviously see that the name is incorrect (as has happened recently with different names being used for the from: and the s-o-b lines in the email address), you have to ask for clarification. It's something that all maintainers should be doing.

Quoted 4 lines

What happens if that patch gets reposted, with S-o-b: He Liang <[email protected]> or Hel Iang, Heli Ang? Do you know any of those are real names? What happens if they post a real name in Mandarin/Thai/Cyrillic, can you validate it?

I would love for people to use their names in their native language, there's no need to make up english-sounding names at all. We have many examples of this in commits already, I would be happy if we get more.

And yes, validating names in those languages is usually not very difficult.

thanks,

greg k-h