Skip to contentSkip to conversation

MPC8245 vs XPC8245

PATCH New Marc Leeman 2 participants 4 messages Nov 5, 2004 – Apr 3, 2005 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MPC8245 vs XPC8245

Signature · 16 lines
ash nazg durbatul?k, ash nazg gimbatul,
ash nazg thrakatul?k agh burzum-ishi krimpatul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CHANGELOG.diff
Type: text/x-patch
Size: 525 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20041105/719e02f7/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cpu_init.c.diff
Type: text/x-patch
Size: 1302 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20041105/719e02f7/attachment-0001.bin 
#1 lore raw

PATCH 1/1 MPC8245 vs XPC8245

Review

Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 1 line
(quoted diff) +3 -0
+* Patch by Marc Leeman, 05 Nov 2003:
+  - enable all 4 PCMBRW buffers for the MPC8245 processor since it 
+    only affects the XPC8245 processors

Please explain which problem you are trying to fix?

Best regards,

Wolfgang Denk

Signature · 5 lines
See us @ Embedded/Electronica Munich, Nov 09 - 12, Hall A.6 Booth 513
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If it's working, the diagnostics say it's fine. If it's not  working,
the diagnostics  say  it's  fine.
              - A proposed addition to rules for realtime programming

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

PATCH 1/1 MPC8245 vs XPC8245

Sorry, this mail was not send to the mailing list.

---------- Forwarded message ----------

Quoted 1 line

Please explain which problem you are trying to fix?

Not trying, is fixed :)

It concerns DMA operations where an external device is reading memory from the ppc.

The patch is already in your CVS since June (IIRC). Since then I noticed that the bug only affects XPC8245 processors (from the type numbers and the age of the boards, I would think they are old (prototype) versions).

The newer processors do not have this bug anymore and I have disabled this patch for 4 months now on our firmware: none of the newer production processors seems to be affected.

I don't know if many ppl are still working with XPC versions of the 8245. This is the reason I put #if 0 #endif around the silicon work around the code again. Feel free to suppress the code completely.

--
ash nazg durbatul?k, ash nazg gimbatul,
ash nazg thrakatul?k agh burzum-ishi krimpatul

Signature · 2 lines
ash nazg durbatul?k, ash nazg gimbatul,
ash nazg thrakatul?k agh burzum-ishi krimpatul
#4 lore raw

PATCH 1/1 MPC8245 vs XPC8245

In reply to Marc Leeman
Quoted 4 lines · In message <[email protected]> you wrote:

* Patch by Marc Leeman, 05 Nov 2003:
- enable all 4 PCMBRW buffers for the MPC8245 processor since it=20 only affects the XPC8245 processors

Thanks, added.

Best regards,

Wolfgang Denk

Signature · 3 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Horses just naturally have mohawk haircuts.