soundwire: intel: Fix uninitialized adev deref
Vinod Koul
maintainerPATCH 1/1 soundwire: intel: Fix uninitialized adev deref
In case of error, we can dereference uninitialized 'adev'
drivers/soundwire/intel_init.c:154 sdw_intel_acpi_cb()
error: uninitialized symbol 'adev'.
Fix that by not using adev for warn print and make it pr_err.
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Vinod Koul <[email protected]>
--- drivers/soundwire/intel_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soundwire/intel_init.c +1 -1
@@ -151,7 +151,7 @@ static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level,struct acpi_device *adev;if (acpi_bus_get_device (handle, &adev)) { -dev_err (&adev->dev,"Couldn't find ACPI handle\n" ); +pr_err ("%s: Couldn't find ACPI handle\n" , __func__);return AE_NOT_FOUND ; }
Signature · 1 line
2.14.4
Quoted 9 lines · Vinod Koul
In case of error, we can dereference uninitialized 'adev'
drivers/soundwire/intel_init.c:154sdw_intel_acpi_cb()
error: uninitialized symbol 'adev'.Fix that by not using adev for warn print and make it
pr_err.Reported-by Dan Carpenter <[email protected]>Signed-off-by Vinod Koul <[email protected]>
Quoted 18 lines
--- drivers/soundwire/intel_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/soundwire/intel_init.c +1
-1@@ -151,7 +151,7 @@ static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level,struct acpi_device *adev;if (acpi_bus_get_device (handle, &adev)) { -dev_err (&adev->dev,"Couldn't find ACPI handle\n" ); +pr_err ("%s: Couldn't find ACPI handle\n" , __func__);return AE_NOT_FOUND ; }