perf pmu intel: Adjust cpumaks for sub-NUMA clusters on graniterapids
Ian Rogers
reviewerPATCH v3 1/1 perf pmu intel: Adjust cpumaks for sub-NUMA clusters on graniterapids
On graniterapids the cache home agent (CHA) and memory controller (IMC) PMUs all have their cpumask set to per-socket information. In order for per NUMA node aggregation to work correctly the PMUs cpumask needs to be set to CPUs for the relevant sub-NUMA grouping.
For example, on a 2 socket graniterapids machine with sub NUMA clustering of 3, for uncore_cha and uncore_imc PMUs the cpumask is "0,120" leading to aggregation only on NUMA nodes 0 and 3:
```
$ perf stat --per-node -e 'UNC_CHA_CLOCKTICKS,UNC_M_CLOCKTICKS' -a sleep 1
Performance counter stats for 'system wide':
N0 1 277,835,681,344 UNC_CHA_CLOCKTICKS
N0 1 19,242,894,228 UNC_M_CLOCKTICKS
N3 1 277,803,448,124 UNC_CHA_CLOCKTICKS
N3 1 19,240,741,498 UNC_M_CLOCKTICKS
1.002113847 seconds time elapsed
```By updating the PMUs cpumasks to "0,120", "40,160" and "80,200" then the correctly 6 NUMA node aggregations are achieved:
```
$ perf stat --per-node -e 'UNC_CHA_CLOCKTICKS,UNC_M_CLOCKTICKS' -a sleep 1
Performance counter stats for 'system wide':
N0 1 92,748,667,796 UNC_CHA_CLOCKTICKS
N0 0 6,424,021,142 UNC_M_CLOCKTICKS
N1 0 92,753,504,424 UNC_CHA_CLOCKTICKS
N1 1 6,424,308,338 UNC_M_CLOCKTICKS
N2 0 92,751,170,084 UNC_CHA_CLOCKTICKS
N2 0 6,424,227,402 UNC_M_CLOCKTICKS
N3 1 92,745,944,144 UNC_CHA_CLOCKTICKS
N3 0 6,423,752,086 UNC_M_CLOCKTICKS
N4 0 92,725,793,788 UNC_CHA_CLOCKTICKS
N4 1 6,422,393,266 UNC_M_CLOCKTICKS
N5 0 92,717,504,388 UNC_CHA_CLOCKTICKS
N5 0 6,421,842,618 UNC_M_CLOCKTICKS
1.003406645 seconds time elapsed
```In general, having the perf tool adjust cpumasks isn't desirable as ideally the PMU driver would be advertising the correct cpumask.
---
v3: Return early for unexpected PMU cpumask (Kan) extra asserts/debug
prints for robustness.
v2: Fix asan/ref count checker build. Fix bad patch migration where
'+' was lost in uncore_cha_imc_compute_cpu_adjust and add assert to make this easier to debug in the future.
--- tools/perf/arch/x86/util/pmu.c | 268 ++++++++++++++++++++++++++++++++- 1 file changed, 263 insertions(+), 5 deletions(-)
tools/perf/arch/x86/util/pmu.c +263 -5
@@ -8,6 +8,8 @@#include <linux/perf_event.h> #include <linux/zalloc.h> #include <api/fs/fs.h> +#include <api/io_dir.h> +#include <internal/cpumap.h> #include <errno.h> #include "../../../util/intel-pt.h"
@@ -16,7 +18,256 @@#include "../../../util/fncache.h" #include "../../../util/pmus.h" #include "mem-events.h" +#include "util/debug.h" #include "util/env.h" +#include "util/header.h" + +static bool x86__is_intel_graniterapids (void ) +{ +static bool checked_if_graniterapids; +static bool is_graniterapids; + +if (!checked_if_graniterapids) { +const char *graniterapids_cpuid ="GenuineIntel-6-A[DE]" ; +char *cpuid =get_cpuid_str ((struct perf_cpu ){0 }); + + is_graniterapids = cpuid &&strcmp_cpuid_str (graniterapids_cpuid, cpuid) ==0 ; +free (cpuid); + checked_if_graniterapids = true; + } +return is_graniterapids; +} + +static struct perf_cpu_map *read_sysfs_cpu_map (const char *sysfs_path) +{ +struct perf_cpu_map *cpus; +char *buf =NULL ; +size_t buf_len; + +if (sysfs__read_str (sysfs_path, &buf, &buf_len) <0 ) +return NULL ; + + cpus =perf_cpu_map__new (buf); +free (buf); +return cpus; +} + +static int snc_nodes_per_l3_cache (void ) +{ +static bool checked_snc; +static int snc_nodes; + +if (!checked_snc) { +struct perf_cpu_map *node_cpus = +read_sysfs_cpu_map ("devices/system/node/node0/cpulist" ); +struct perf_cpu_map *cache_cpus = +read_sysfs_cpu_map ("devices/system/cpu/cpu0/cache/index3/shared_cpu_list" ); + + snc_nodes =perf_cpu_map__nr (cache_cpus) /perf_cpu_map__nr (node_cpus); +perf_cpu_map__put (cache_cpus); +perf_cpu_map__put (node_cpus); + checked_snc = true; + } +return snc_nodes; +} + +static bool starts_with (const char *str,const char *prefix) +{ +return !strncmp (prefix, str,strlen (prefix)); +} + +static int num_chas (void ) +{ +static bool checked_chas; +static int num_chas; + +if (!checked_chas) { +int fd =perf_pmu__event_source_devices_fd (); +struct io_dir dir; +struct io_dirent64 *dent; + +if (fd <0 ) +return -1 ; + +io_dir__init (&dir, fd); + +while ((dent =io_dir__readdir (&dir)) !=NULL ) { +/* Note, dent->d_type will be DT_LNK and so isn't a useful filter. */ +if (starts_with (dent->d_name,"uncore_cha_" )) + num_chas++; + } +close (fd); + checked_chas = true; + } +return num_chas; +} + +#define MAX_SNCS 6 + +static int uncore_cha_snc (struct perf_pmu *pmu) +{ +// CHA SNC numbers are ordered correspond to the CHAs number. +unsigned int cha_num; +int num_cha, chas_per_node, cha_snc; +int snc_nodes =snc_nodes_per_l3_cache (); + +if (snc_nodes <=1 ) +return 0 ; + + num_cha =num_chas (); +if (num_cha <=0 ) { +pr_warning ("Unexpected: no CHAs found\n" ); +return 0 ; + } + +/* Compute SNC for PMU. */ +if (sscanf (pmu->name,"uncore_cha_%u" , &cha_num) !=1 ) { +pr_warning ("Unexpected: unable to compute CHA number '%s'\n" , pmu->name); +return 0 ; + } + chas_per_node = num_cha / snc_nodes; + cha_snc = cha_num / chas_per_node; + +/* Range check cha_snc. for unexpected out of bounds. */ +return cha_snc >=MAX_SNCS ?0 : cha_snc; +} + +static int uncore_imc_snc (struct perf_pmu *pmu) +{ +// Compute the IMC SNC using lookup tables. +unsigned int imc_num; +int snc_nodes =snc_nodes_per_l3_cache (); +const u8 snc2_map[] = {1 ,1 ,0 ,0 ,1 ,1 ,0 ,0 }; +const u8 snc3_map[] = {1 ,1 ,0 ,0 ,2 ,2 ,1 ,1 ,0 ,0 ,2 ,2 }; +const u8 *snc_map; +size_t snc_map_len; + +switch (snc_nodes) { +case 2 : + snc_map = snc2_map; + snc_map_len =ARRAY_SIZE (snc2_map); +break ; +case 3 : + snc_map = snc3_map; + snc_map_len =ARRAY_SIZE (snc3_map); +break ; +default : +/* Error or no lookup support for SNC with >3 nodes. */ +return 0 ; + } + +/* Compute SNC for PMU. */ +if (sscanf (pmu->name,"uncore_imc_%u" , &imc_num) !=1 ) { +pr_warning ("Unexpected: unable to compute IMC number '%s'\n" , pmu->name); +return 0 ; + } +if (imc_num >= snc_map_len) { +pr_warning ("Unexpected IMC %d for SNC%d mapping\n" , imc_num, snc_nodes); +return 0 ; + } +return snc_map[imc_num]; +} + +static int uncore_cha_imc_compute_cpu_adjust (int pmu_snc) +{ +static bool checked_cpu_adjust[MAX_SNCS ]; +static int cpu_adjust[MAX_SNCS ]; +struct perf_cpu_map *node_cpus; +char node_path[] ="devices/system/node/node0/cpulist" ; + +/* Was adjust already computed? */ +if (checked_cpu_adjust[pmu_snc]) +return cpu_adjust[pmu_snc]; + +/* SNC0 doesn't need an adjust. */ +if (pmu_snc ==0 ) { + cpu_adjust[0 ] =0 ; + checked_cpu_adjust[0 ] = true; +return 0 ; + } + +/* +* Use NUMA topology to compute first CPU of the NUMA node, we want to +* adjust CPU 0 to be this and similarly for other CPUs if there is >1 +* socket. +*/ +assert (pmu_snc >=0 && pmu_snc <=9 ); + node_path[24 ] += pmu_snc;// Shift node0 to be node<pmu_snc>. + node_cpus =read_sysfs_cpu_map (node_path); + cpu_adjust[pmu_snc] =perf_cpu_map__cpu (node_cpus,0 ).cpu; +if (cpu_adjust[pmu_snc] <0 ) { +pr_debug ("Failed to read valid CPU list from <sysfs>/%s\n" , node_path); + cpu_adjust[pmu_snc] =0 ; + }else { + checked_cpu_adjust[pmu_snc] = true; + } +perf_cpu_map__put (node_cpus); +return cpu_adjust[pmu_snc]; +} + +static void gnr_uncore_cha_imc_adjust_cpumask_for_snc (struct perf_pmu *pmu,bool cha) +{ +// With sub-NUMA clustering (SNC) there is a NUMA node per SNC in the +// topology. For example, a two socket graniterapids machine may be set +// up with 3-way SNC meaning there are 6 NUMA nodes that should be +// displayed with --per-node. The cpumask of the CHA and IMC PMUs +// reflects per-socket information meaning, for example, uncore_cha_60 +// on a two socket graniterapids machine with 120 cores per socket will +// have a cpumask of "0,120". This cpumask needs adjusting to "40,160" +// to reflect that uncore_cha_60 is used for the 2nd SNC of each +// socket. Without the adjustment events on uncore_cha_60 will appear in +// node 0 and node 3 (in our example 2 socket 3-way set up), but with +// the adjustment they will appear in node 1 and node 4. The number of +// CHAs is typically larger than the number of cores. The CHA numbers +// are assumed to split evenly and inorder wrt core numbers. There are +// fewer memory IMC PMUs than cores and mapping is handled using lookup +// tables. +static struct perf_cpu_map *cha_adjusted[MAX_SNCS ]; +static struct perf_cpu_map *imc_adjusted[MAX_SNCS ]; +struct perf_cpu_map **adjusted = cha ? cha_adjusted : imc_adjusted; +int idx, pmu_snc, cpu_adjust; +struct perf_cpu cpu; +bool alloc; + +// Cpus from the kernel holds first CPU of each socket. e.g. 0,120. +if (perf_cpu_map__cpu (pmu->cpus,0 ).cpu !=0 ) { +pr_debug ("Ignoring cpumask adjust for %s as unexpected first CPU\n" , pmu->name); +return ; + } + + pmu_snc = cha ?uncore_cha_snc (pmu) :uncore_imc_snc (pmu); +if (pmu_snc ==0 ) { +// No adjustment necessary for the first SNC. +return ; + } + + alloc = adjusted[pmu_snc] ==NULL ; +if (alloc) { +// Hold onto the perf_cpu_map globally to avoid recomputation. + cpu_adjust =uncore_cha_imc_compute_cpu_adjust (pmu_snc); + adjusted[pmu_snc] =perf_cpu_map__empty_new (perf_cpu_map__nr (pmu->cpus)); +if (!adjusted[pmu_snc]) +return ; + } + +perf_cpu_map__for_each_cpu (cpu, idx, pmu->cpus) { +// Compute the new cpu map values or if not allocating, assert +// that they match expectations. asserts will be removed to +// avoid overhead in NDEBUG builds. +if (alloc) { +RC_CHK_ACCESS (adjusted[pmu_snc])->map[idx].cpu = cpu.cpu + cpu_adjust; + }else if (idx ==0 ) { + cpu_adjust =perf_cpu_map__cpu (adjusted[pmu_snc], idx).cpu - cpu.cpu; +assert (uncore_cha_imc_compute_cpu_adjust (pmu_snc) == cpu_adjust); + }else { +assert (perf_cpu_map__cpu (adjusted[pmu_snc], idx).cpu == + cpu.cpu + cpu_adjust); + } + } + +perf_cpu_map__put (pmu->cpus); + pmu->cpus =perf_cpu_map__get (adjusted[pmu_snc]); +}void perf_pmu__arch_init (struct perf_pmu *pmu) {
@@ -49,10 +300,17 @@ void perf_pmu__arch_init(struct perf_pmu *pmu) perf_mem_events__loads_ldlat =0 ; pmu->mem_events = perf_mem_events_amd_ldlat; - }else if (pmu->is_core) { -if (perf_pmu__have_event (pmu,"mem-loads-aux" )) - pmu->mem_events = perf_mem_events_intel_aux; -else - pmu->mem_events = perf_mem_events_intel; + }else { +if (pmu->is_core) { +if (perf_pmu__have_event (pmu,"mem-loads-aux" )) + pmu->mem_events = perf_mem_events_intel_aux; +else + pmu->mem_events = perf_mem_events_intel; + }else if (x86__is_intel_graniterapids ()) { +if (starts_with (pmu->name,"uncore_cha_" )) +gnr_uncore_cha_imc_adjust_cpumask_for_snc (pmu,/*cha=*/ true); +else if (starts_with (pmu->name,"uncore_imc_" )) +gnr_uncore_cha_imc_adjust_cpumask_for_snc (pmu,/*cha=*/ false); + } } }
Signature · 1 line
2.49.0.1101.gccaa498523-goog
Quoted 28 lines · Ian Rogers
On graniterapids the cache home agent (CHA) and memory controller (IMC) PMUs all have their cpumask set to per-socket information. In order for per NUMA node aggregation to work correctly the PMUs cpumask needs to be set to CPUs for the relevant sub-NUMA grouping.
For example, on a 2 socket graniterapids machine with sub NUMA clustering of 3, for
uncore_chaanduncore_imcPMUs the cpumask is "0,120" leading to aggregation only on NUMA nodes 0 and 3:``` $ perf stat --per-node -e 'UNC_CHA_CLOCKTICKS,UNC_M_CLOCKTICKS' -a sleep 1 Performance counter stats for 'system wide': N0 1 277,835,681,344 UNC_CHA_CLOCKTICKS N0 1 19,242,894,228 UNC_M_CLOCKTICKS N3 1 277,803,448,124 UNC_CHA_CLOCKTICKS N3 1 19,240,741,498 UNC_M_CLOCKTICKS 1.002113847 seconds time elapsed ```By updating the PMUs cpumasks to "0,120", "40,160" and "80,200" then the correctly 6 NUMA node aggregations are achieved:
```$ perf stat --per-node -e 'UNC_CHA_CLOCKTICKS,UNC_M_CLOCKTICKS' -a sleep 1Performance counter stats for 'system wide':
Quoted 12 lines
N0 1 92,748,667,796 UNC_CHA_CLOCKTICKS N0 0 6,424,021,142 UNC_M_CLOCKTICKS N1 0 92,753,504,424 UNC_CHA_CLOCKTICKS N1 1 6,424,308,338 UNC_M_CLOCKTICKS N2 0 92,751,170,084 UNC_CHA_CLOCKTICKS N2 0 6,424,227,402 UNC_M_CLOCKTICKS N3 1 92,745,944,144 UNC_CHA_CLOCKTICKS N3 0 6,423,752,086 UNC_M_CLOCKTICKS N4 0 92,725,793,788 UNC_CHA_CLOCKTICKS N4 1 6,422,393,266 UNC_M_CLOCKTICKS N5 0 92,717,504,388 UNC_CHA_CLOCKTICKS N5 0 6,421,842,618 UNC_M_CLOCKTICKS
Is the second coloum the number of units?
If so, it's wrong.
On my GNR with SNC-2, I observed the similar issue.
$ sudo ./perf stat -e 'UNC_M_CLOCKTICKS' --per-node -a sleep 1 Performance counter stats for 'system wide':
N0 0 6,405,811,284 UNC_M_CLOCKTICKS N1 1 6,405,895,988 UNC_M_CLOCKTICKS N2 0 6,152,906,692 UNC_M_CLOCKTICKS N3 1 6,063,415,630 UNC_M_CLOCKTICKS
It's supposed to be 4?
Thanks,
Kan>
Quoted 310 lines
1.003406645 seconds time elapsed```
In general, having the perf tool adjust cpumasks isn't desirable as ideally the PMU driver would be advertising the correct cpumask.
Signed-off-by Ian Rogers <[email protected]>---
v3: Return early for unexpected PMU cpumask (Kan) extra asserts/debug
prints for robustness.
v2: Fix asan/ref count checker build. Fix bad patch migration where
'+' was lost inuncore_cha_imc_compute_cpu_adjustand add assert to make this easier to debug in the future.--- tools/perf/arch/x86/util/pmu.c | 268 ++++++++++++++++++++++++++++++++- 1 file changed, 263 insertions(+), 5 deletions(-)tools/perf/arch/x86/util/pmu.c +263
-5@@ -8,6 +8,8 @@#include <linux/perf_event.h> #include <linux/zalloc.h> #include <api/fs/fs.h> +#include <api/io_dir.h> +#include <internal/cpumap.h> #include <errno.h> #include "../../../util/intel-pt.h" @@ -16,7 +18,256 @@#include "../../../util/fncache.h" #include "../../../util/pmus.h" #include "mem-events.h" +#include "util/debug.h" #include "util/env.h" +#include "util/header.h" + +static bool x86__is_intel_graniterapids (void ) +{ +static bool checked_if_graniterapids; +static bool is_graniterapids; + +if (!checked_if_graniterapids) { +const char *graniterapids_cpuid ="GenuineIntel-6-A[DE]" ; +char *cpuid =get_cpuid_str ((struct perf_cpu ){0 }); + + is_graniterapids = cpuid &&strcmp_cpuid_str (graniterapids_cpuid, cpuid) ==0 ; +free (cpuid); + checked_if_graniterapids = true; + } +return is_graniterapids; +} + +static struct perf_cpu_map *read_sysfs_cpu_map (const char *sysfs_path) +{ +struct perf_cpu_map *cpus; +char *buf =NULL ; +size_t buf_len; + +if (sysfs__read_str (sysfs_path, &buf, &buf_len) <0 ) +return NULL ; + + cpus =perf_cpu_map__new (buf); +free (buf); +return cpus; +} + +static int snc_nodes_per_l3_cache (void ) +{ +static bool checked_snc; +static int snc_nodes; + +if (!checked_snc) { +struct perf_cpu_map *node_cpus = +read_sysfs_cpu_map ("devices/system/node/node0/cpulist" ); +struct perf_cpu_map *cache_cpus = +read_sysfs_cpu_map ("devices/system/cpu/cpu0/cache/index3/shared_cpu_list" ); + + snc_nodes =perf_cpu_map__nr (cache_cpus) /perf_cpu_map__nr (node_cpus); +perf_cpu_map__put (cache_cpus); +perf_cpu_map__put (node_cpus); + checked_snc = true; + } +return snc_nodes; +} + +static bool starts_with (const char *str,const char *prefix) +{ +return !strncmp (prefix, str,strlen (prefix)); +} + +static int num_chas (void ) +{ +static bool checked_chas; +static int num_chas; + +if (!checked_chas) { +int fd =perf_pmu__event_source_devices_fd (); +struct io_dir dir; +struct io_dirent64 *dent; + +if (fd <0 ) +return -1 ; + +io_dir__init (&dir, fd); + +while ((dent =io_dir__readdir (&dir)) !=NULL ) { +/* Note, dent->d_type will be DT_LNK and so isn't a useful filter. */ +if (starts_with (dent->d_name,"uncore_cha_" )) + num_chas++; + } +close (fd); + checked_chas = true; + } +return num_chas; +} + +#define MAX_SNCS 6 + +static int uncore_cha_snc (struct perf_pmu *pmu) +{ +// CHA SNC numbers are ordered correspond to the CHAs number. +unsigned int cha_num; +int num_cha, chas_per_node, cha_snc; +int snc_nodes =snc_nodes_per_l3_cache (); + +if (snc_nodes <=1 ) +return 0 ; + + num_cha =num_chas (); +if (num_cha <=0 ) { +pr_warning ("Unexpected: no CHAs found\n" ); +return 0 ; + } + +/* Compute SNC for PMU. */ +if (sscanf (pmu->name,"uncore_cha_%u" , &cha_num) !=1 ) { +pr_warning ("Unexpected: unable to compute CHA number '%s'\n" , pmu->name); +return 0 ; + } + chas_per_node = num_cha / snc_nodes; + cha_snc = cha_num / chas_per_node; + +/* Range check cha_snc. for unexpected out of bounds. */ +return cha_snc >=MAX_SNCS ?0 : cha_snc; +} + +static int uncore_imc_snc (struct perf_pmu *pmu) +{ +// Compute the IMC SNC using lookup tables. +unsigned int imc_num; +int snc_nodes =snc_nodes_per_l3_cache (); +const u8 snc2_map[] = {1 ,1 ,0 ,0 ,1 ,1 ,0 ,0 }; +const u8 snc3_map[] = {1 ,1 ,0 ,0 ,2 ,2 ,1 ,1 ,0 ,0 ,2 ,2 }; +const u8 *snc_map; +size_t snc_map_len; + +switch (snc_nodes) { +case 2 : + snc_map = snc2_map; + snc_map_len =ARRAY_SIZE (snc2_map); +break ; +case 3 : + snc_map = snc3_map; + snc_map_len =ARRAY_SIZE (snc3_map); +break ; +default : +/* Error or no lookup support for SNC with >3 nodes. */ +return 0 ; + } + +/* Compute SNC for PMU. */ +if (sscanf (pmu->name,"uncore_imc_%u" , &imc_num) !=1 ) { +pr_warning ("Unexpected: unable to compute IMC number '%s'\n" , pmu->name); +return 0 ; + } +if (imc_num >= snc_map_len) { +pr_warning ("Unexpected IMC %d for SNC%d mapping\n" , imc_num, snc_nodes); +return 0 ; + } +return snc_map[imc_num]; +} + +static int uncore_cha_imc_compute_cpu_adjust (int pmu_snc) +{ +static bool checked_cpu_adjust[MAX_SNCS ]; +static int cpu_adjust[MAX_SNCS ]; +struct perf_cpu_map *node_cpus; +char node_path[] ="devices/system/node/node0/cpulist" ; + +/* Was adjust already computed? */ +if (checked_cpu_adjust[pmu_snc]) +return cpu_adjust[pmu_snc]; + +/* SNC0 doesn't need an adjust. */ +if (pmu_snc ==0 ) { + cpu_adjust[0 ] =0 ; + checked_cpu_adjust[0 ] = true; +return 0 ; + } + +/* +* Use NUMA topology to compute first CPU of the NUMA node, we want to +* adjust CPU 0 to be this and similarly for other CPUs if there is >1 +* socket. +*/ +assert (pmu_snc >=0 && pmu_snc <=9 ); + node_path[24 ] += pmu_snc;// Shift node0 to be node<pmu_snc>. + node_cpus =read_sysfs_cpu_map (node_path); + cpu_adjust[pmu_snc] =perf_cpu_map__cpu (node_cpus,0 ).cpu; +if (cpu_adjust[pmu_snc] <0 ) { +pr_debug ("Failed to read valid CPU list from <sysfs>/%s\n" , node_path); + cpu_adjust[pmu_snc] =0 ; + }else { + checked_cpu_adjust[pmu_snc] = true; + } +perf_cpu_map__put (node_cpus); +return cpu_adjust[pmu_snc]; +} + +static void gnr_uncore_cha_imc_adjust_cpumask_for_snc (struct perf_pmu *pmu,bool cha) +{ +// With sub-NUMA clustering (SNC) there is a NUMA node per SNC in the +// topology. For example, a two socket graniterapids machine may be set +// up with 3-way SNC meaning there are 6 NUMA nodes that should be +// displayed with --per-node. The cpumask of the CHA and IMC PMUs +// reflects per-socket information meaning, for example, uncore_cha_60 +// on a two socket graniterapids machine with 120 cores per socket will +// have a cpumask of "0,120". This cpumask needs adjusting to "40,160" +// to reflect that uncore_cha_60 is used for the 2nd SNC of each +// socket. Without the adjustment events on uncore_cha_60 will appear in +// node 0 and node 3 (in our example 2 socket 3-way set up), but with +// the adjustment they will appear in node 1 and node 4. The number of +// CHAs is typically larger than the number of cores. The CHA numbers +// are assumed to split evenly and inorder wrt core numbers. There are +// fewer memory IMC PMUs than cores and mapping is handled using lookup +// tables. +static struct perf_cpu_map *cha_adjusted[MAX_SNCS ]; +static struct perf_cpu_map *imc_adjusted[MAX_SNCS ]; +struct perf_cpu_map **adjusted = cha ? cha_adjusted : imc_adjusted; +int idx, pmu_snc, cpu_adjust; +struct perf_cpu cpu; +bool alloc; + +// Cpus from the kernel holds first CPU of each socket. e.g. 0,120. +if (perf_cpu_map__cpu (pmu->cpus,0 ).cpu !=0 ) { +pr_debug ("Ignoring cpumask adjust for %s as unexpected first CPU\n" , pmu->name); +return ; + } + + pmu_snc = cha ?uncore_cha_snc (pmu) :uncore_imc_snc (pmu); +if (pmu_snc ==0 ) { +// No adjustment necessary for the first SNC. +return ; + } + + alloc = adjusted[pmu_snc] ==NULL ; +if (alloc) { +// Hold onto the perf_cpu_map globally to avoid recomputation. + cpu_adjust =uncore_cha_imc_compute_cpu_adjust (pmu_snc); + adjusted[pmu_snc] =perf_cpu_map__empty_new (perf_cpu_map__nr (pmu->cpus)); +if (!adjusted[pmu_snc]) +return ; + } + +perf_cpu_map__for_each_cpu (cpu, idx, pmu->cpus) { +// Compute the new cpu map values or if not allocating, assert +// that they match expectations. asserts will be removed to +// avoid overhead in NDEBUG builds. +if (alloc) { +RC_CHK_ACCESS (adjusted[pmu_snc])->map[idx].cpu = cpu.cpu + cpu_adjust; + }else if (idx ==0 ) { + cpu_adjust =perf_cpu_map__cpu (adjusted[pmu_snc], idx).cpu - cpu.cpu; +assert (uncore_cha_imc_compute_cpu_adjust (pmu_snc) == cpu_adjust); + }else { +assert (perf_cpu_map__cpu (adjusted[pmu_snc], idx).cpu == + cpu.cpu + cpu_adjust); + } + } + +perf_cpu_map__put (pmu->cpus); + pmu->cpus =perf_cpu_map__get (adjusted[pmu_snc]); +}void perf_pmu__arch_init (struct perf_pmu *pmu) {@@ -49,10 +300,17 @@ void perf_pmu__arch_init(struct perf_pmu *pmu) perf_mem_events__loads_ldlat =0 ; pmu->mem_events = perf_mem_events_amd_ldlat; - }else if (pmu->is_core) { -if (perf_pmu__have_event (pmu,"mem-loads-aux" )) - pmu->mem_events = perf_mem_events_intel_aux; -else - pmu->mem_events = perf_mem_events_intel; + }else { +if (pmu->is_core) { +if (perf_pmu__have_event (pmu,"mem-loads-aux" )) + pmu->mem_events = perf_mem_events_intel_aux; +else + pmu->mem_events = perf_mem_events_intel; + }else if (x86__is_intel_graniterapids ()) { +if (starts_with (pmu->name,"uncore_cha_" )) +gnr_uncore_cha_imc_adjust_cpumask_for_snc (pmu,/*cha=*/ true); +else if (starts_with (pmu->name,"uncore_imc_" )) +gnr_uncore_cha_imc_adjust_cpumask_for_snc (pmu,/*cha=*/ false); + } } }
Ian Rogers
reviewerQuoted 51 lines · Kan
Quoted 28 lines · Ian Rogers
On graniterapids the cache home agent (CHA) and memory controller (IMC) PMUs all have their cpumask set to per-socket information. In order for per NUMA node aggregation to work correctly the PMUs cpumask needs to be set to CPUs for the relevant sub-NUMA grouping.
For example, on a 2 socket graniterapids machine with sub NUMA clustering of 3, for
uncore_chaanduncore_imcPMUs the cpumask is "0,120" leading to aggregation only on NUMA nodes 0 and 3:``` $ perf stat --per-node -e 'UNC_CHA_CLOCKTICKS,UNC_M_CLOCKTICKS' -a sleep 1 Performance counter stats for 'system wide': N0 1 277,835,681,344 UNC_CHA_CLOCKTICKS N0 1 19,242,894,228 UNC_M_CLOCKTICKS N3 1 277,803,448,124 UNC_CHA_CLOCKTICKS N3 1 19,240,741,498 UNC_M_CLOCKTICKS 1.002113847 seconds time elapsed ```By updating the PMUs cpumasks to "0,120", "40,160" and "80,200" then the correctly 6 NUMA node aggregations are achieved:
```$ perf stat --per-node -e 'UNC_CHA_CLOCKTICKS,UNC_M_CLOCKTICKS' -a sleep 1Performance counter stats for 'system wide':
Quoted 12 lines
N0 1 92,748,667,796 UNC_CHA_CLOCKTICKS N0 0 6,424,021,142 UNC_M_CLOCKTICKS N1 0 92,753,504,424 UNC_CHA_CLOCKTICKS N1 1 6,424,308,338 UNC_M_CLOCKTICKS N2 0 92,751,170,084 UNC_CHA_CLOCKTICKS N2 0 6,424,227,402 UNC_M_CLOCKTICKS N3 1 92,745,944,144 UNC_CHA_CLOCKTICKS N3 0 6,423,752,086 UNC_M_CLOCKTICKS N4 0 92,725,793,788 UNC_CHA_CLOCKTICKS N4 1 6,422,393,266 UNC_M_CLOCKTICKS N5 0 92,717,504,388 UNC_CHA_CLOCKTICKS N5 0 6,421,842,618 UNC_M_CLOCKTICKSIs the second coloum the number of units?
If so, it's wrong.On my GNR with SNC-2, I observed the similar issue.
$ sudo ./perf stat -e 'UNC_M_CLOCKTICKS' --per-node -a sleep 1 Performance counter stats for 'system wide':
Quoted 6 lines
N0 0 6,405,811,284 UNC_M_CLOCKTICKS N1 1 6,405,895,988 UNC_M_CLOCKTICKS N2 0 6,152,906,692 UNC_M_CLOCKTICKS N3 1 6,063,415,630 UNC_M_CLOCKTICKSIt's supposed to be 4?
Agreed it is weird, but it is what has historically been displayed. The number is the aggregation number:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat-display.c?h=perf-tools-next#n307
which comes from:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat-display.c?h=perf-tools-next#n135
which comes from:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat.c?h=perf-tools-next#n435
However, I think it is missing updates from:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat.c?h=perf-tools-next#n526
but there is a comment there saying "don't increase aggr.nr for aliases" and all the uncore events are aliases. I don't understand what the aggregation number is supposed to be, it is commented as "number of entries (CPUs) aggregated":
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat.h?h=perf-tools-next#n26
it would seem to make sense in the CHA case with SNC3 and 42 evsels per NUMA node that the value should be 42. Maybe Namhyung (who did the evsel__merge_aggr_counters clean up) knows why it is this way but in my eyes it just seems like something that has been broken for a long time.
Thanks,
Ian
Namhyung Kim
maintainerHello,
Quoted 70 lines · Ian Rogers
Quoted 51 lines · Kan
Quoted 28 lines · Ian Rogers
On graniterapids the cache home agent (CHA) and memory controller (IMC) PMUs all have their cpumask set to per-socket information. In order for per NUMA node aggregation to work correctly the PMUs cpumask needs to be set to CPUs for the relevant sub-NUMA grouping.
For example, on a 2 socket graniterapids machine with sub NUMA clustering of 3, for
uncore_chaanduncore_imcPMUs the cpumask is "0,120" leading to aggregation only on NUMA nodes 0 and 3:``` $ perf stat --per-node -e 'UNC_CHA_CLOCKTICKS,UNC_M_CLOCKTICKS' -a sleep 1 Performance counter stats for 'system wide': N0 1 277,835,681,344 UNC_CHA_CLOCKTICKS N0 1 19,242,894,228 UNC_M_CLOCKTICKS N3 1 277,803,448,124 UNC_CHA_CLOCKTICKS N3 1 19,240,741,498 UNC_M_CLOCKTICKS 1.002113847 seconds time elapsed ```By updating the PMUs cpumasks to "0,120", "40,160" and "80,200" then the correctly 6 NUMA node aggregations are achieved:
```$ perf stat --per-node -e 'UNC_CHA_CLOCKTICKS,UNC_M_CLOCKTICKS' -a sleep 1Performance counter stats for 'system wide':
Quoted 12 lines
N0 1 92,748,667,796 UNC_CHA_CLOCKTICKS N0 0 6,424,021,142 UNC_M_CLOCKTICKS N1 0 92,753,504,424 UNC_CHA_CLOCKTICKS N1 1 6,424,308,338 UNC_M_CLOCKTICKS N2 0 92,751,170,084 UNC_CHA_CLOCKTICKS N2 0 6,424,227,402 UNC_M_CLOCKTICKS N3 1 92,745,944,144 UNC_CHA_CLOCKTICKS N3 0 6,423,752,086 UNC_M_CLOCKTICKS N4 0 92,725,793,788 UNC_CHA_CLOCKTICKS N4 1 6,422,393,266 UNC_M_CLOCKTICKS N5 0 92,717,504,388 UNC_CHA_CLOCKTICKS N5 0 6,421,842,618 UNC_M_CLOCKTICKSIs the second coloum the number of units?
If so, it's wrong.On my GNR with SNC-2, I observed the similar issue.
$ sudo ./perf stat -e 'UNC_M_CLOCKTICKS' --per-node -a sleep 1 Performance counter stats for 'system wide':Quoted 6 lines
N0 0 6,405,811,284 UNC_M_CLOCKTICKS N1 1 6,405,895,988 UNC_M_CLOCKTICKS N2 0 6,152,906,692 UNC_M_CLOCKTICKS N3 1 6,063,415,630 UNC_M_CLOCKTICKSIt's supposed to be 4?
Agreed it is weird, but it is what has historically been displayed. The number is the aggregation number:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat-display.c?h=perf-tools-next#n307
which comes from:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat-display.c?h=perf-tools-next#n135
which comes from:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat.c?h=perf-tools-next#n435
However, I think it is missing updates from:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat.c?h=perf-tools-next#n526
but there is a comment there saying "don't increase aggr.nr for aliases" and all the uncore events are aliases. I don't understand
Quoted 8 lines
what the aggregation number is supposed to be, it is commented as "number of entries (CPUs) aggregated":
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat.h?h=perf-tools-next#n26
it would seem to make sense in the CHA case with SNC3 and 42 evsels per NUMA node that the value should be 42. Maybe Namhyung (who did theevsel__merge_aggr_countersclean up) knows why it is this way but in my eyes it just seems like something that has been broken for a long time.
I think it's the number of aggregated entries (FDs?).
For core events, it's the number of CPUs for the given aggregation as it collects from all CPUs. But it'd be confusing with uncore events which have cpumask to collect data from a few CPUs.
On my laptop, --per-socket gives different numbers depending on the events/PMUs.
For core events, it's 4.
$ sudo ./perf stat -a --per-socket -e cycles sleep 1
Performance counter stats for 'system wide':
S0 4 225,297,257 cycles
1.002581995 seconds time elapsed
While uncore events give 1.
$ sudo ./perf stat -a --per-socket -e unc_mc0_rdcas_count_freerun sleep 1
Performance counter stats for 'system wide':
S0 1 23,665,510 unc_mc0_rdcas_count_freerun
1.002148012 seconds time elapsed
Thanks,
Namhyung
Ian Rogers
reviewerQuoted 104 lines · Namhyung Kim
Hello,
Quoted 70 lines · Ian Rogers
Quoted 51 lines · Kan
Quoted 28 lines · Ian Rogers
On graniterapids the cache home agent (CHA) and memory controller (IMC) PMUs all have their cpumask set to per-socket information. In order for per NUMA node aggregation to work correctly the PMUs cpumask needs to be set to CPUs for the relevant sub-NUMA grouping.
For example, on a 2 socket graniterapids machine with sub NUMA clustering of 3, for
uncore_chaanduncore_imcPMUs the cpumask is "0,120" leading to aggregation only on NUMA nodes 0 and 3:``` $ perf stat --per-node -e 'UNC_CHA_CLOCKTICKS,UNC_M_CLOCKTICKS' -a sleep 1 Performance counter stats for 'system wide': N0 1 277,835,681,344 UNC_CHA_CLOCKTICKS N0 1 19,242,894,228 UNC_M_CLOCKTICKS N3 1 277,803,448,124 UNC_CHA_CLOCKTICKS N3 1 19,240,741,498 UNC_M_CLOCKTICKS 1.002113847 seconds time elapsed ```By updating the PMUs cpumasks to "0,120", "40,160" and "80,200" then the correctly 6 NUMA node aggregations are achieved:
```$ perf stat --per-node -e 'UNC_CHA_CLOCKTICKS,UNC_M_CLOCKTICKS' -a sleep 1Performance counter stats for 'system wide':
Quoted 12 lines
N0 1 92,748,667,796 UNC_CHA_CLOCKTICKS N0 0 6,424,021,142 UNC_M_CLOCKTICKS N1 0 92,753,504,424 UNC_CHA_CLOCKTICKS N1 1 6,424,308,338 UNC_M_CLOCKTICKS N2 0 92,751,170,084 UNC_CHA_CLOCKTICKS N2 0 6,424,227,402 UNC_M_CLOCKTICKS N3 1 92,745,944,144 UNC_CHA_CLOCKTICKS N3 0 6,423,752,086 UNC_M_CLOCKTICKS N4 0 92,725,793,788 UNC_CHA_CLOCKTICKS N4 1 6,422,393,266 UNC_M_CLOCKTICKS N5 0 92,717,504,388 UNC_CHA_CLOCKTICKS N5 0 6,421,842,618 UNC_M_CLOCKTICKSIs the second coloum the number of units?
If so, it's wrong.On my GNR with SNC-2, I observed the similar issue.
$ sudo ./perf stat -e 'UNC_M_CLOCKTICKS' --per-node -a sleep 1 Performance counter stats for 'system wide':Quoted 6 lines
N0 0 6,405,811,284 UNC_M_CLOCKTICKS N1 1 6,405,895,988 UNC_M_CLOCKTICKS N2 0 6,152,906,692 UNC_M_CLOCKTICKS N3 1 6,063,415,630 UNC_M_CLOCKTICKSIt's supposed to be 4?
Agreed it is weird, but it is what has historically been displayed. The number is the aggregation number:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat-display.c?h=perf-tools-next#n307
which comes from:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat-display.c?h=perf-tools-next#n135
which comes from:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat.c?h=perf-tools-next#n435
However, I think it is missing updates from:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat.c?h=perf-tools-next#n526
but there is a comment there saying "don't increase aggr.nr for aliases" and all the uncore events are aliases. I don't understandQuoted 8 lines
what the aggregation number is supposed to be, it is commented as "number of entries (CPUs) aggregated":
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat.h?h=perf-tools-next#n26
it would seem to make sense in the CHA case with SNC3 and 42 evsels per NUMA node that the value should be 42. Maybe Namhyung (who did theevsel__merge_aggr_countersclean up) knows why it is this way but in my eyes it just seems like something that has been broken for a long time.I think it's the number of aggregated entries (FDs?).
For core events, it's the number of CPUs for the given aggregation as it collects from all CPUs. But it'd be confusing with uncore events which have cpumask to collect data from a few CPUs.
On my laptop, --per-socket gives different numbers depending on the events/PMUs.
For core events, it's 4.
$ sudo ./perf stat -a --per-socket -e cycles sleep 1Performance counter stats for 'system wide':
S0 4 225,297,257 cycles
1.002581995 seconds time elapsedWhile uncore events give 1.
Quoted 7 lines
$ sudo ./perf stat -a --per-socket -e unc_mc0_rdcas_count_freerun sleep 1Performance counter stats for 'system wide':
S0 1 23,665,510
unc_mc0_rdcas_count_freerun1.002148012 seconds time elapsed
I think we're agreeing. I wonder that the intent of the aggregation number is to make it so that you can work out an average from the aggregated count. So for core PMUs you divide the count by the aggregation number and get the average count per core (CPU?). If we're getting an aggregated count of say uncore memory controller events then it would make sense to me that we show the aggregated total and the aggregation count is the number of memory controller PMUs, so we can have an average per memory controller. This should line up with using the number of file descriptors.
I think this isn't the current behavior, on perf v6.12:
```
$ sudo perf stat --per-socket -e data_read -a sleep 1
Performance counter stats for 'system wide':
S0 1 2,484.96 MiB data_read
1.001365319 seconds time elapsed
$ sudo perf stat -A -e data_read -a sleep 1
Performance counter stats for 'system wide':
CPU0 1,336.48 MiB data_read [uncore_imc_free_running_0]
CPU0 1,337.06 MiB data_read [uncore_imc_free_running_1]
1.001049096 seconds time elapsed
```so the aggregation number shows 1 but 2 events were aggregated together.
I think computing the aggregation number in the stat code is probably wrong. The value should be constant for an evsel and aggr_cpu_id, it's just computing it for an aggr_cpu_id is a pain due to needing topology and/or PMU information. The code is ripe for refactoring. I'd prefer not to do it as part of this change though which is altering a particular Intel Granite Rapids issue.
Thanks,
Ian
Namhyung Kim
maintainerQuoted 113 lines · Ian Rogers
Quoted 104 lines · Namhyung Kim
Hello,
Quoted 70 lines · Ian Rogers
Quoted 51 lines · Kan
Quoted 28 lines · Ian Rogers
On graniterapids the cache home agent (CHA) and memory controller (IMC) PMUs all have their cpumask set to per-socket information. In order for per NUMA node aggregation to work correctly the PMUs cpumask needs to be set to CPUs for the relevant sub-NUMA grouping.
For example, on a 2 socket graniterapids machine with sub NUMA clustering of 3, for
uncore_chaanduncore_imcPMUs the cpumask is "0,120" leading to aggregation only on NUMA nodes 0 and 3:``` $ perf stat --per-node -e 'UNC_CHA_CLOCKTICKS,UNC_M_CLOCKTICKS' -a sleep 1 Performance counter stats for 'system wide': N0 1 277,835,681,344 UNC_CHA_CLOCKTICKS N0 1 19,242,894,228 UNC_M_CLOCKTICKS N3 1 277,803,448,124 UNC_CHA_CLOCKTICKS N3 1 19,240,741,498 UNC_M_CLOCKTICKS 1.002113847 seconds time elapsed ```By updating the PMUs cpumasks to "0,120", "40,160" and "80,200" then the correctly 6 NUMA node aggregations are achieved:
```$ perf stat --per-node -e 'UNC_CHA_CLOCKTICKS,UNC_M_CLOCKTICKS' -a sleep 1Performance counter stats for 'system wide':
Quoted 12 lines
N0 1 92,748,667,796 UNC_CHA_CLOCKTICKS N0 0 6,424,021,142 UNC_M_CLOCKTICKS N1 0 92,753,504,424 UNC_CHA_CLOCKTICKS N1 1 6,424,308,338 UNC_M_CLOCKTICKS N2 0 92,751,170,084 UNC_CHA_CLOCKTICKS N2 0 6,424,227,402 UNC_M_CLOCKTICKS N3 1 92,745,944,144 UNC_CHA_CLOCKTICKS N3 0 6,423,752,086 UNC_M_CLOCKTICKS N4 0 92,725,793,788 UNC_CHA_CLOCKTICKS N4 1 6,422,393,266 UNC_M_CLOCKTICKS N5 0 92,717,504,388 UNC_CHA_CLOCKTICKS N5 0 6,421,842,618 UNC_M_CLOCKTICKSIs the second coloum the number of units?
If so, it's wrong.On my GNR with SNC-2, I observed the similar issue.
$ sudo ./perf stat -e 'UNC_M_CLOCKTICKS' --per-node -a sleep 1 Performance counter stats for 'system wide':Quoted 6 lines
N0 0 6,405,811,284 UNC_M_CLOCKTICKS N1 1 6,405,895,988 UNC_M_CLOCKTICKS N2 0 6,152,906,692 UNC_M_CLOCKTICKS N3 1 6,063,415,630 UNC_M_CLOCKTICKSIt's supposed to be 4?
Agreed it is weird, but it is what has historically been displayed. The number is the aggregation number:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat-display.c?h=perf-tools-next#n307
which comes from:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat-display.c?h=perf-tools-next#n135
which comes from:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat.c?h=perf-tools-next#n435
However, I think it is missing updates from:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat.c?h=perf-tools-next#n526
but there is a comment there saying "don't increase aggr.nr for aliases" and all the uncore events are aliases. I don't understandQuoted 8 lines
what the aggregation number is supposed to be, it is commented as "number of entries (CPUs) aggregated":
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat.h?h=perf-tools-next#n26
it would seem to make sense in the CHA case with SNC3 and 42 evsels per NUMA node that the value should be 42. Maybe Namhyung (who did theevsel__merge_aggr_countersclean up) knows why it is this way but in my eyes it just seems like something that has been broken for a long time.I think it's the number of aggregated entries (FDs?).
For core events, it's the number of CPUs for the given aggregation as it collects from all CPUs. But it'd be confusing with uncore events which have cpumask to collect data from a few CPUs.
On my laptop, --per-socket gives different numbers depending on the events/PMUs.
For core events, it's 4.
$ sudo ./perf stat -a --per-socket -e cycles sleep 1Performance counter stats for 'system wide':
S0 4 225,297,257 cycles
1.002581995 seconds time elapsedWhile uncore events give 1.
Quoted 7 lines
$ sudo ./perf stat -a --per-socket -e unc_mc0_rdcas_count_freerun sleep 1Performance counter stats for 'system wide':
S0 1 23,665,510
unc_mc0_rdcas_count_freerun1.002148012 seconds time elapsed
Quoted 9 lines
I think we're agreeing. I wonder that the intent of the aggregation number is to make it so that you can work out an average from the aggregated count. So for core PMUs you divide the count by the aggregation number and get the average count per core (CPU?). If we're getting an aggregated count of say uncore memory controller events then it would make sense to me that we show the aggregated total and the aggregation count is the number of memory controller PMUs, so we can have an average per memory controller. This should line up with using the number of file descriptors.
Sounds right.
Quoted 20 lines
I think this isn't the current behavior, on perf v6.12:
``` $ sudo perf stat --per-socket -e data_read -a sleep 1 Performance counter stats for 'system wide': S0 1 2,484.96 MiB data_read 1.001365319 seconds time elapsed $ sudo perf stat -A -e data_read -a sleep 1 Performance counter stats for 'system wide': CPU0 1,336.48 MiB data_read [uncore_imc_free_running_0] CPU0 1,337.06 MiB data_read [uncore_imc_free_running_1] 1.001049096 seconds time elapsed ```
Quoted 1 line
so the aggregation number shows 1 but 2 events were aggregated together.
Ugh.. right. Merging uncore PMU instances can add more confusion. :(
Quoted 7 lines
I think computing the aggregation number in the stat code is probably wrong. The value should be constant for an evsel and
aggr_cpu_id, it's just computing it for anaggr_cpu_idis a pain due to needing topology and/or PMU information. The code is ripe for refactoring. I'd prefer not to do it as part of this change though which is altering a particular Intel Granite Rapids issue.
That's ok. Just one more TODO items..
Thanks,
Namhyung
Liang, Kan
Tested-byQuoted 151 lines · Namhyung Kim
Quoted 113 lines · Ian Rogers
Quoted 104 lines · Namhyung Kim
Hello,
Quoted 70 lines · Ian Rogers
Quoted 51 lines · Kan
Quoted 28 lines · Ian Rogers
On graniterapids the cache home agent (CHA) and memory controller (IMC) PMUs all have their cpumask set to per-socket information. In order for per NUMA node aggregation to work correctly the PMUs cpumask needs to be set to CPUs for the relevant sub-NUMA grouping.
For example, on a 2 socket graniterapids machine with sub NUMA clustering of 3, for
uncore_chaanduncore_imcPMUs the cpumask is "0,120" leading to aggregation only on NUMA nodes 0 and 3:``` $ perf stat --per-node -e 'UNC_CHA_CLOCKTICKS,UNC_M_CLOCKTICKS' -a sleep 1 Performance counter stats for 'system wide': N0 1 277,835,681,344 UNC_CHA_CLOCKTICKS N0 1 19,242,894,228 UNC_M_CLOCKTICKS N3 1 277,803,448,124 UNC_CHA_CLOCKTICKS N3 1 19,240,741,498 UNC_M_CLOCKTICKS 1.002113847 seconds time elapsed ```By updating the PMUs cpumasks to "0,120", "40,160" and "80,200" then the correctly 6 NUMA node aggregations are achieved:
```$ perf stat --per-node -e 'UNC_CHA_CLOCKTICKS,UNC_M_CLOCKTICKS' -a sleep 1Performance counter stats for 'system wide':
Quoted 12 lines
N0 1 92,748,667,796 UNC_CHA_CLOCKTICKS N0 0 6,424,021,142 UNC_M_CLOCKTICKS N1 0 92,753,504,424 UNC_CHA_CLOCKTICKS N1 1 6,424,308,338 UNC_M_CLOCKTICKS N2 0 92,751,170,084 UNC_CHA_CLOCKTICKS N2 0 6,424,227,402 UNC_M_CLOCKTICKS N3 1 92,745,944,144 UNC_CHA_CLOCKTICKS N3 0 6,423,752,086 UNC_M_CLOCKTICKS N4 0 92,725,793,788 UNC_CHA_CLOCKTICKS N4 1 6,422,393,266 UNC_M_CLOCKTICKS N5 0 92,717,504,388 UNC_CHA_CLOCKTICKS N5 0 6,421,842,618 UNC_M_CLOCKTICKSIs the second coloum the number of units?
If so, it's wrong.On my GNR with SNC-2, I observed the similar issue.
$ sudo ./perf stat -e 'UNC_M_CLOCKTICKS' --per-node -a sleep 1 Performance counter stats for 'system wide':Quoted 6 lines
N0 0 6,405,811,284 UNC_M_CLOCKTICKS N1 1 6,405,895,988 UNC_M_CLOCKTICKS N2 0 6,152,906,692 UNC_M_CLOCKTICKS N3 1 6,063,415,630 UNC_M_CLOCKTICKSIt's supposed to be 4?
Agreed it is weird, but it is what has historically been displayed. The number is the aggregation number:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat-display.c?h=perf-tools-next#n307
which comes from:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat-display.c?h=perf-tools-next#n135
which comes from:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat.c?h=perf-tools-next#n435
However, I think it is missing updates from:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat.c?h=perf-tools-next#n526
but there is a comment there saying "don't increase aggr.nr for aliases" and all the uncore events are aliases. I don't understandQuoted 8 lines
what the aggregation number is supposed to be, it is commented as "number of entries (CPUs) aggregated":
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/stat.h?h=perf-tools-next#n26
it would seem to make sense in the CHA case with SNC3 and 42 evsels per NUMA node that the value should be 42. Maybe Namhyung (who did theevsel__merge_aggr_countersclean up) knows why it is this way but in my eyes it just seems like something that has been broken for a long time.I think it's the number of aggregated entries (FDs?).
For core events, it's the number of CPUs for the given aggregation as it collects from all CPUs. But it'd be confusing with uncore events which have cpumask to collect data from a few CPUs.
On my laptop, --per-socket gives different numbers depending on the events/PMUs.
For core events, it's 4.
$ sudo ./perf stat -a --per-socket -e cycles sleep 1Performance counter stats for 'system wide':
S0 4 225,297,257 cycles
1.002581995 seconds time elapsedWhile uncore events give 1.
Quoted 7 lines
$ sudo ./perf stat -a --per-socket -e unc_mc0_rdcas_count_freerun sleep 1Performance counter stats for 'system wide':
S0 1 23,665,510
unc_mc0_rdcas_count_freerun1.002148012 seconds time elapsedQuoted 9 lines
I think we're agreeing. I wonder that the intent of the aggregation number is to make it so that you can work out an average from the aggregated count. So for core PMUs you divide the count by the aggregation number and get the average count per core (CPU?). If we're getting an aggregated count of say uncore memory controller events then it would make sense to me that we show the aggregated total and the aggregation count is the number of memory controller PMUs, so we can have an average per memory controller. This should line up with using the number of file descriptors.
Sounds right.
Quoted 20 lines
I think this isn't the current behavior, on perf v6.12:
``` $ sudo perf stat --per-socket -e data_read -a sleep 1 Performance counter stats for 'system wide': S0 1 2,484.96 MiB data_read 1.001365319 seconds time elapsed $ sudo perf stat -A -e data_read -a sleep 1 Performance counter stats for 'system wide': CPU0 1,336.48 MiB data_read [uncore_imc_free_running_0] CPU0 1,337.06 MiB data_read [uncore_imc_free_running_1] 1.001049096 seconds time elapsed ```Quoted 1 line
so the aggregation number shows 1 but 2 events were aggregated together.
Ugh.. right. Merging uncore PMU instances can add more confusion. :(
Quoted 1 line
Quoted 9 lines
Quoted 6 lines
I think computing the aggregation number in the stat code is probably wrong. The value should be constant for an evsel and
aggr_cpu_id, it's just computing it for anaggr_cpu_idis a pain due to needing topology and/or PMU information. The code is ripe for refactoring. I'd prefer not to do it as part of this change though which is altering a particular Intel Granite Rapids issue.That's ok. Just one more TODO items..
Sounds good to me as well.
For this patch, I've verified it with SNC-2. The rest looks good to me.
Thanks,
Kan
Quoted 46 lines · Kan
Quoted 45 lines · Namhyung Kim
Quoted 10 lines · Ian Rogers
On Sun, May 18, 2025 at 10:09 AM Namhyung Kim <[email protected]> wrote:
I think we're agreeing. I wonder that the intent of the aggregation number is to make it so that you can work out an average from the aggregated count. So for core PMUs you divide the count by the aggregation number and get the average count per core (CPU?). If we're getting an aggregated count of say uncore memory controller events then it would make sense to me that we show the aggregated total and the aggregation count is the number of memory controller PMUs, so we can have an average per memory controller. This should line up with using the number of file descriptors.Sounds right.
Quoted 19 lines
I think this isn't the current behavior, on perf v6.12:
``` $ sudo perf stat --per-socket -e data_read -a sleep 1 Performance counter stats for 'system wide': S0 1 2,484.96 MiB data_read 1.001365319 seconds time elapsed $ sudo perf stat -A -e data_read -a sleep 1 Performance counter stats for 'system wide': CPU0 1,336.48 MiB data_read [uncore_imc_free_running_0] CPU0 1,337.06 MiB data_read [uncore_imc_free_running_1] 1.001049096 seconds time elapsed ```Quoted 1 line
so the aggregation number shows 1 but 2 events were aggregated together.
Ugh.. right. Merging uncore PMU instances can add more confusion. :(
Quoted 7 lines
I think computing the aggregation number in the stat code is probably wrong. The value should be constant for an evsel and
aggr_cpu_id, it's just computing it for anaggr_cpu_idis a pain due to needing topology and/or PMU information. The code is ripe for refactoring. I'd prefer not to do it as part of this change though which is altering a particular Intel Granite Rapids issue.
Quoted 5 lines
Quoted 1 line
That's ok. Just one more TODO items..
Sounds good to me as well.
For this patch, I've verified it with SNC-2. The rest looks good to me.
Thanks, applied to perf-tools-next, will go public tomorrow, after I redo tests, off to bed now...
- Arnaldo
Quoted 63 lines
-----Original Message-----
From: Ian Rogers <[email protected]>
Sent: Thursday, May 15, 2025 11:14 AM
To: Wang, Weilin <[email protected]>; Kan Liang <[email protected]>; Peter Zijlstra <[email protected]>; Ingo Molnar <[email protected]>; Arnaldo Carvalho de Melo <[email protected]>; Namhyung Kim <[email protected]>; Mark Rutland <[email protected]>; Alexander Shishkin <[email protected]>; Jiri Olsa <[email protected]>; Ian Rogers <[email protected]>; Hunter, Adrian <[email protected]>; Ravi Bangoria <[email protected]>; [email protected]; [email protected]
Subject: [PATCH v3] perf pmu intel: Adjust cpumaks for sub-NUMA clusters on graniterapidsOn graniterapids the cache home agent (CHA) and memory controller (IMC) PMUs all have their cpumask set to per-socket information. In order for per NUMA node aggregation to work correctly the PMUs cpumask needs to be set to CPUs for the relevant sub-NUMA grouping.
For example, on a 2 socket graniterapids machine with sub NUMA clustering of 3, for
uncore_chaanduncore_imcPMUs the cpumask is "0,120" leading to aggregation only on NUMA nodes 0 and 3:``` $ perf stat --per-node -e 'UNC_CHA_CLOCKTICKS,UNC_M_CLOCKTICKS' -a sleep 1 Performance counter stats for 'system wide': N0 1 277,835,681,344 UNC_CHA_CLOCKTICKS N0 1 19,242,894,228 UNC_M_CLOCKTICKS N3 1 277,803,448,124 UNC_CHA_CLOCKTICKS N3 1 19,240,741,498 UNC_M_CLOCKTICKS 1.002113847 seconds time elapsed ```By updating the PMUs cpumasks to "0,120", "40,160" and "80,200" then the correctly 6 NUMA node aggregations are achieved:
``` $ perf stat --per-node -e 'UNC_CHA_CLOCKTICKS,UNC_M_CLOCKTICKS' -a sleep 1 Performance counter stats for 'system wide': N0 1 92,748,667,796 UNC_CHA_CLOCKTICKS N0 0 6,424,021,142 UNC_M_CLOCKTICKS N1 0 92,753,504,424 UNC_CHA_CLOCKTICKS N1 1 6,424,308,338 UNC_M_CLOCKTICKS N2 0 92,751,170,084 UNC_CHA_CLOCKTICKS N2 0 6,424,227,402 UNC_M_CLOCKTICKS N3 1 92,745,944,144 UNC_CHA_CLOCKTICKS N3 0 6,423,752,086 UNC_M_CLOCKTICKS N4 0 92,725,793,788 UNC_CHA_CLOCKTICKS N4 1 6,422,393,266 UNC_M_CLOCKTICKS N5 0 92,717,504,388 UNC_CHA_CLOCKTICKS N5 0 6,421,842,618 UNC_M_CLOCKTICKS 1.003406645 seconds time elapsed ```
Quoted 4 lines
In general, having the perf tool adjust cpumasks isn't desirable as ideally the PMU driver would be advertising the correct cpumask.
Signed-off-by Ian Rogers <[email protected]>
Quoted 342 lines
---
v3: Return early for unexpected PMU cpumask (Kan) extra asserts/debug
prints for robustness.
v2: Fix asan/ref count checker build. Fix bad patch migration where
'+' was lost inuncore_cha_imc_compute_cpu_adjustand add assert to make this easier to debug in the future.--- tools/perf/arch/x86/util/pmu.c | 268 ++++++++++++++++++++++++++++++++- 1 file changed, 263 insertions(+), 5 deletions(-)tools/perf/arch/x86/util/pmu.c +45
-0@@ -8,6 +8,8 @@#include <linux/perf_event.h> #include <linux/zalloc.h> #include <api/fs/fs.h> +#include <api/io_dir.h> +#include <internal/cpumap.h> #include <errno.h> #include "../../../util/intel-pt.h" @@ -16,7 +18,256 @@#include "../../../util/fncache.h" #include "../../../util/pmus.h" #include "mem-events.h" +#include "util/debug.h" #include "util/env.h" +#include "util/header.h" + +static bool x86__is_intel_graniterapids (void ) +{ +static bool checked_if_graniterapids; +static bool is_graniterapids; + +if (!checked_if_graniterapids) { +const char *graniterapids_cpuid ="GenuineIntel-6-A[DE]" ; +char *cpuid =get_cpuid_str ((struct perf_cpu ){0 }); + + is_graniterapids = cpuid &&strcmp_cpuid_str (graniterapids_cpuid, cpuid) ==0 ; +free (cpuid); + checked_if_graniterapids = true; + } +return is_graniterapids; +} + +static struct perf_cpu_map *read_sysfs_cpu_map (const char *sysfs_path) +{ +struct perf_cpu_map *cpus; +char *buf =NULL ; +size_t buf_len; + +if (sysfs__read_str (sysfs_path, &buf, &buf_len) <0 ) +return NULL ; + + cpus =perf_cpu_map__new (buf); +free (buf); +return cpus; +} + +static int snc_nodes_per_l3_cache (void ) +{ +static bool checked_snc; +static int snc_nodes; + +if (!checked_snc) { +struct perf_cpu_map *node_cpus = +read_sysfs_cpu_map ("devices/system/node/node0/cpulist" ); +struct perf_cpu_map *cache_cpus = + read_sysfs_cpu_map("devices/system/cpu/cpu0/cache/index3/share
d_cpu_list");tools/perf/arch/x86/util/pmu.c +2
-0+ + snc_nodes = perf_cpu_map__nr(cache_cpus) /
perf_cpu_map__nr(node_cpus);tools/perf/arch/x86/util/pmu.c +29
-0+perf_cpu_map__put (cache_cpus); +perf_cpu_map__put (node_cpus); + checked_snc = true; + } +return snc_nodes; +} + +static bool starts_with (const char *str,const char *prefix) +{ +return !strncmp (prefix, str,strlen (prefix)); +} + +static int num_chas (void ) +{ +static bool checked_chas; +static int num_chas; + +if (!checked_chas) { +int fd =perf_pmu__event_source_devices_fd (); +struct io_dir dir; +struct io_dirent64 *dent; + +if (fd <0 ) +return -1 ; + +io_dir__init (&dir, fd); + +while ((dent =io_dir__readdir (&dir)) !=NULL ) { +/* Note, dent->d_type will be DT_LNK and so isn't a useful filter. */
tools/perf/arch/x86/util/pmu.c +30
-0+if (starts_with (dent->d_name,"uncore_cha_" )) + num_chas++; + } +close (fd); + checked_chas = true; + } +return num_chas; +} + +#define MAX_SNCS 6 + +static int uncore_cha_snc (struct perf_pmu *pmu) +{ +// CHA SNC numbers are ordered correspond to the CHAs number. +unsigned int cha_num; +int num_cha, chas_per_node, cha_snc; +int snc_nodes =snc_nodes_per_l3_cache (); + +if (snc_nodes <=1 ) +return 0 ; + + num_cha =num_chas (); +if (num_cha <=0 ) { +pr_warning ("Unexpected: no CHAs found\n" ); +return 0 ; + } + +/* Compute SNC for PMU. */ +if (sscanf (pmu->name,"uncore_cha_%u" , &cha_num) !=1 ) { + pr_warning("Unexpected: unable to compute CHA number'%s'\n",
pmu->name);tools/perf/arch/x86/util/pmu.c +36
-0+return 0 ; + } + chas_per_node = num_cha / snc_nodes; + cha_snc = cha_num / chas_per_node; + +/* Range check cha_snc. for unexpected out of bounds. */ +return cha_snc >=MAX_SNCS ?0 : cha_snc; +} + +static int uncore_imc_snc (struct perf_pmu *pmu) +{ +// Compute the IMC SNC using lookup tables. +unsigned int imc_num; +int snc_nodes =snc_nodes_per_l3_cache (); +const u8 snc2_map[] = {1 ,1 ,0 ,0 ,1 ,1 ,0 ,0 }; +const u8 snc3_map[] = {1 ,1 ,0 ,0 ,2 ,2 ,1 ,1 ,0 ,0 ,2 ,2 }; +const u8 *snc_map; +size_t snc_map_len; + +switch (snc_nodes) { +case 2 : + snc_map = snc2_map; + snc_map_len =ARRAY_SIZE (snc2_map); +break ; +case 3 : + snc_map = snc3_map; + snc_map_len =ARRAY_SIZE (snc3_map); +break ; +default : +/* Error or no lookup support for SNC with >3 nodes. */ +return 0 ; + } + +/* Compute SNC for PMU. */ +if (sscanf (pmu->name,"uncore_imc_%u" , &imc_num) !=1 ) { + pr_warning("Unexpected: unable to compute IMC number'%s'\n",
pmu->name);tools/perf/arch/x86/util/pmu.c +4
-0+return 0 ; + } +if (imc_num >= snc_map_len) { + pr_warning("Unexpected IMC %d for SNC%d mapping\n",
imc_num,snc_nodes);tools/perf/arch/x86/util/pmu.c +25
-0+return 0 ; + } +return snc_map[imc_num]; +} + +static int uncore_cha_imc_compute_cpu_adjust (int pmu_snc) +{ +static bool checked_cpu_adjust[MAX_SNCS ]; +static int cpu_adjust[MAX_SNCS ]; +struct perf_cpu_map *node_cpus; +char node_path[] ="devices/system/node/node0/cpulist" ; + +/* Was adjust already computed? */ +if (checked_cpu_adjust[pmu_snc]) +return cpu_adjust[pmu_snc]; + +/* SNC0 doesn't need an adjust. */ +if (pmu_snc ==0 ) { + cpu_adjust[0 ] =0 ; + checked_cpu_adjust[0 ] = true; +return 0 ; + } + +/* +* Use NUMA topology to compute first CPU of the NUMA node, we want to
tools/perf/arch/x86/util/pmu.c +9
-0+* adjust CPU 0 to be this and similarly for other CPUs if there is >1 +* socket. +*/ +assert (pmu_snc >=0 && pmu_snc <=9 ); + node_path[24 ] += pmu_snc;// Shift node0 to be node<pmu_snc>. + node_cpus =read_sysfs_cpu_map (node_path); + cpu_adjust[pmu_snc] =perf_cpu_map__cpu (node_cpus,0 ).cpu; +if (cpu_adjust[pmu_snc] <0 ) { + pr_debug("Failed to read valid CPU list from <sysfs>/%s\n",
node_path);tools/perf/arch/x86/util/pmu.c +9
-0+ cpu_adjust[pmu_snc] =0 ; + }else { + checked_cpu_adjust[pmu_snc] = true; + } +perf_cpu_map__put (node_cpus); +return cpu_adjust[pmu_snc]; +} + +static void gnr_uncore_cha_imc_adjust_cpumask_for_snc(struct perf_pmu*pmu, bool cha)
tools/perf/arch/x86/util/pmu.c +2
-0+{ +// With sub-NUMA clustering (SNC) there is a NUMA node per SNC in the
tools/perf/arch/x86/util/pmu.c +1
-0+// topology. For example, a two socket graniterapids machine may be set
tools/perf/arch/x86/util/pmu.c +1
-0+// up with 3-way SNC meaning there are 6 NUMA nodes that should be
tools/perf/arch/x86/util/pmu.c +2
-0+// displayed with --per-node. The cpumask of the CHA and IMC PMUs +// reflects per-socket information meaning, for example,
uncore_cha_60tools/perf/arch/x86/util/pmu.c +1
-0+// on a two socket graniterapids machine with 120 cores per socket will
tools/perf/arch/x86/util/pmu.c +1
-0+// have a cpumask of "0,120". This cpumask needs adjusting to "40,160"
tools/perf/arch/x86/util/pmu.c +2
-0+// to reflect that uncore_cha_60 is used for the 2nd SNC of each +// socket. Without the adjustment events on uncore_cha_60 will appear in
tools/perf/arch/x86/util/pmu.c +2
-0+// node 0 and node 3 (in our example 2 socket 3-way set up), but with +// the adjustment they will appear in node 1 and node 4. The number of
tools/perf/arch/x86/util/pmu.c +1
-0+// CHAs is typically larger than the number of cores. The CHA numbers
tools/perf/arch/x86/util/pmu.c +1
-0+// are assumed to split evenly and inorder wrt core numbers. There are
tools/perf/arch/x86/util/pmu.c +1
-0+// fewer memory IMC PMUs than cores and mapping is handled using lookup
tools/perf/arch/x86/util/pmu.c +11
-0+// tables. +static struct perf_cpu_map *cha_adjusted[MAX_SNCS ]; +static struct perf_cpu_map *imc_adjusted[MAX_SNCS ]; +struct perf_cpu_map **adjusted = cha ? cha_adjusted : imc_adjusted; +int idx, pmu_snc, cpu_adjust; +struct perf_cpu cpu; +bool alloc; + +// Cpus from the kernel holds first CPU of each socket. e.g. 0,120. +if (perf_cpu_map__cpu (pmu->cpus,0 ).cpu !=0 ) { + pr_debug("Ignoring cpumask adjust for %s as unexpectedfirst CPU\n",
pmu->name);tools/perf/arch/x86/util/pmu.c +12
-0+return ; + } + + pmu_snc = cha ?uncore_cha_snc (pmu) :uncore_imc_snc (pmu); +if (pmu_snc ==0 ) { +// No adjustment necessary for the first SNC. +return ; + } + + alloc = adjusted[pmu_snc] ==NULL ; +if (alloc) { +// Hold onto the perf_cpu_map globally to avoid recomputation.
tools/perf/arch/x86/util/pmu.c +1
-0+ cpu_adjust =
uncore_cha_imc_compute_cpu_adjust(pmu_snc);tools/perf/arch/x86/util/pmu.c +1
-0+ adjusted[pmu_snc] =perf_cpu_map__empty_new(perf_cpu_map__nr(pmu->cpus));
tools/perf/arch/x86/util/pmu.c +6
-0+if (!adjusted[pmu_snc]) +return ; + } + +perf_cpu_map__for_each_cpu (cpu, idx, pmu->cpus) { +// Compute the new cpu map values or if not allocating, assert
tools/perf/arch/x86/util/pmu.c +4
-0+// that they match expectations. asserts will be removed to +// avoid overhead in NDEBUG builds. +if (alloc) { +RC_CHK_ACCESS (adjusted[pmu_snc])->map[idx].cpu= cpu.cpu +
cpu_adjust;tools/perf/arch/x86/util/pmu.c +2
-0+ }else if (idx ==0 ) { + cpu_adjust =
perf_cpu_map__cpu(adjusted[pmu_snc], idx).cpu - cpu.cpu; +assert(uncore_cha_imc_compute_cpu_adjust(pmu_snc) ==
cpu_adjust);tools/perf/arch/x86/util/pmu.c +2
-0+ }else { + assert(perf_cpu_map__cpu(adjusted[pmu_snc],idx).cpu ==
tools/perf/arch/x86/util/pmu.c +16
-5+ cpu.cpu + cpu_adjust); + } + } + +perf_cpu_map__put (pmu->cpus); + pmu->cpus =perf_cpu_map__get (adjusted[pmu_snc]); +}void perf_pmu__arch_init (struct perf_pmu *pmu) {@@ -49,10 +300,17 @@ void perf_pmu__arch_init(struct perf_pmu *pmu) perf_mem_events__loads_ldlat =0 ; pmu->mem_events = perf_mem_events_amd_ldlat; - }else if (pmu->is_core) { -if (perf_pmu__have_event (pmu,"mem-loads-aux" )) - pmu->mem_events = perf_mem_events_intel_aux; -else - pmu->mem_events = perf_mem_events_intel; + }else { +if (pmu->is_core) { +if (perf_pmu__have_event (pmu,"mem-loads-aux" )) + pmu->mem_events = perf_mem_events_intel_aux; +else + pmu->mem_events = perf_mem_events_intel; + }else if (x86__is_intel_graniterapids ()) { +if (starts_with (pmu->name,"uncore_cha_" )) +gnr_uncore_cha_imc_adjust_cpumask_for_snc(pmu, /*cha=*/true);tools/perf/arch/x86/util/pmu.c +2
-0+else if (starts_with (pmu->name,"uncore_imc_" )) +gnr_uncore_cha_imc_adjust_cpumask_for_snc(pmu, /*cha=*/false);tools/perf/arch/x86/util/pmu.c +1
-1+ } } } --2.49.0.1101.gccaa498523-goog