Skip to contentSkip to conversation

tests/kms_busy: Limit the execution to two pipes

PATCH In review Bhanuprakash Modem 3 participants 6 messages Apr 12, 2021 – May 26, 2021

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/1 tests/kms_busy: Limit the execution to two pipes

As all pipes are symmetric, restrict the execution to two pipes can save lot of CI time.

If we want to execute on all pipes, we need to pass an extra argument "-e" indicates extended.

Example: ./build/tests/kms_busy -e --r basic

V2, V3:
* Fix the typo in args handler (Petri)
V4:
* Handle clampling cleanly (Petri)
* Restore lost test coverage in the previous version (Petri/Bhanu) V5:
* Fix two subtest with the name "basic" (Petri)

Cc Karthik B S <[email protected]>
Cc Latvala Petri <[email protected]>
Cc Kunche Kishore <[email protected]>
Cc Uma Shankar <[email protected]>
---
 tests/kms_busy.c | 139 ++++++++++++++++++++++++++++++-----------------
 1 file changed, 89 insertions(+), 50 deletions(-)
tests/kms_busy.c +89 -50
index df1f8e11a..095896db5 100644
@@ -30,6 +30,11 @@
 
 IGT_TEST_DESCRIPTION("Basic check of KMS ABI with busy framebuffers.");
 
+/* restricted pipe count */
+#define CRTC_RESTRICT_CNT 2
+
+static bool all_pipes = false;
+
 static igt_output_t *
 set_fb_on_crtc(igt_display_t *dpy, int pipe, struct igt_fb *fb)
 {
@@ -287,10 +292,41 @@ static void test_pageflip_modeset_hang(igt_display_t *dpy, enum pipe pipe)
 	igt_remove_fb(dpy->drm_fd, &fb);
 }
 
-igt_main
+static int opt_handler(int opt, int opt_index, void *data)
+{
+	switch (opt) {
+		case 'e':
+			all_pipes = true;
+			break;
+		default:
+			return IGT_OPT_HANDLER_ERROR;
+	}
+
+	return IGT_OPT_HANDLER_SUCCESS;
+}
+
+const char *help_str =
+	"  -e \tRun on all pipes. (By default subtests will run on two pipes)\n";
+
+igt_main_args("e", NULL, help_str, opt_handler, NULL)
 {
 	igt_display_t display = { .drm_fd = -1, .n_pipes = IGT_MAX_PIPES };
-	enum pipe n;
+
+	int crtc_count;
+	int i;
+	struct {
+		const char *name;
+		bool modeset;
+		bool hang_newfb;
+		bool reset;
+	} tests[] = {
+		{ "extended-pageflip-hang-oldfb", false, false, false },
+		{ "extended-pageflip-hang-newfb", false, true, false },
+		{ "extended-modeset-hang-oldfb", true, false, false },
+		{ "extended-modeset-hang-newfb", true, true, false },
+		{ "extended-modeset-hang-oldfb-with-reset", true, false, true },
+		{ "extended-modeset-hang-newfb-with-reset", true, true, true },
+	};
 
 	igt_fixture {
 		int fd = drm_open_driver_master(DRIVER_INTEL);
@@ -318,70 +354,73 @@ igt_main
 		}
 	}
 
-	for_each_pipe_static(n) igt_subtest_group {
-		igt_hang_t hang;
-
+	igt_subtest_with_dynamic("basic-hang") {
+		enum pipe pipe;
+		igt_output_t *output;
+		int count = 0;
+		igt_hang_t hang = igt_allow_hang(display.drm_fd, 0, 0);
 		errno = 0;
 
-		igt_fixture {
-			igt_display_require_output_on_pipe(&display, n);
-		}
-
-		igt_subtest_f("basic-flip-pipe-%s", kmstest_pipe_name(n)) {
-			test_flip(&display, n, false);
-		}
-		igt_subtest_f("basic-modeset-pipe-%s", kmstest_pipe_name(n)) {
-
-			test_flip(&display, n, true);
-		}
-
-		igt_fixture {
-			hang = igt_allow_hang(display.drm_fd, 0, 0);
-		}
+		crtc_count = (all_pipes)? display.n_pipes : CRTC_RESTRICT_CNT;
+		for_each_pipe_with_valid_output(&display, pipe, output) {
+			igt_dynamic_f("flip-pipe-%s", kmstest_pipe_name(pipe))
+				test_flip(&display, pipe, false);
+			igt_dynamic_f("modeset-pipe-%s", kmstest_pipe_name(pipe))
+				test_flip(&display, pipe, true);
 
-		igt_subtest_f("extended-pageflip-modeset-hang-oldfb-pipe-%s",
-			      kmstest_pipe_name(n)) {
-			test_pageflip_modeset_hang(&display, n);
+			if (++count >= crtc_count)
+				break;
 		}
 
-		igt_fixture
-			igt_require(display.is_atomic);
+		igt_disallow_hang(display.drm_fd, hang);
+	}
 
-		igt_subtest_f("extended-pageflip-hang-oldfb-pipe-%s",
-			      kmstest_pipe_name(n))
-			test_hang(&display, n, false, false);
+	igt_subtest_with_dynamic("extended-pageflip-modeset-hang-oldfb") {
+		enum pipe pipe;
+		igt_output_t *output;
+		int count = 0;
+		igt_hang_t hang = igt_allow_hang(display.drm_fd, 0, 0);
+		errno = 0;
 
-		igt_subtest_f("extended-pageflip-hang-newfb-pipe-%s",
-			      kmstest_pipe_name(n))
-			test_hang(&display, n, false, true);
+		crtc_count = (all_pipes)? display.n_pipes : CRTC_RESTRICT_CNT;
+		for_each_pipe_with_valid_output(&display, pipe, output) {
+			igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe))
+				test_pageflip_modeset_hang(&display, pipe);
 
-		igt_subtest_f("extended-modeset-hang-oldfb-pipe-%s",
-			      kmstest_pipe_name(n))
-			test_hang(&display, n, true, false);
+			if (++count >= crtc_count)
+				break;
+		}
 
-		igt_subtest_f("extended-modeset-hang-newfb-pipe-%s",
-			      kmstest_pipe_name(n))
-			test_hang(&display, n, true, true);
+		igt_disallow_hang(display.drm_fd, hang);
+	}
 
-		igt_subtest_f("extended-modeset-hang-oldfb-with-reset-pipe-%s",
-			      kmstest_pipe_name(n)) {
-			igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 1);
+	for (i = 0; i < sizeof(tests) / sizeof (tests[0]); i++) {
+		igt_subtest_with_dynamic(tests[i].name) {
+			enum pipe pipe;
+			igt_output_t *output;
+			int count = 0;
+			igt_hang_t hang;
+			errno = 0;
 
-			test_hang(&display, n, true, false);
+			igt_require(display.is_atomic);
+			hang = igt_allow_hang(display.drm_fd, 0, 0);
 
-			igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 0);
-		}
+			crtc_count = (all_pipes)? display.n_pipes : CRTC_RESTRICT_CNT;
+			for_each_pipe_with_valid_output(&display, pipe, output) {
+				igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
+					if (tests[i].reset)
+						igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 1);
 
-		igt_subtest_f("extended-modeset-hang-newfb-with-reset-pipe-%s",
-			      kmstest_pipe_name(n)) {
-			igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 1);
+					test_hang(&display, pipe, tests[i].modeset, tests[i].hang_newfb);
 
-			test_hang(&display, n, true, true);
+					if (tests[i].reset)
+						igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 0);
+				}
 
-			igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 0);
-		}
+				if (++count >= crtc_count)
+					break;
+			}
 
-		igt_fixture {
 			igt_disallow_hang(display.drm_fd, hang);
 		}
 	}
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_busy: Limit the execution to two pipes (rev5)

== Series Details ==

== Series Details ==

Series: tests/kms_busy: Limit the execution to two pipes (rev5)
URL : https://patchwork.freedesktop.org/series/87829/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9956 -> IGTPW_5731
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/index.html

Known issues
------------

Here are the changes found in IGTPW_5731 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [PASS][1] -> [FAIL][2] ([i915#1372])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/fi-kbl-7500u/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/fi-kbl-7500u/igt@[email protected]

* igt@kms_flip@basic-flip-vs-wf_vblank@a-dvi-d1:
- fi-bwr-2160: [PASS][3] -> [FAIL][4] ([i915#2122])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/fi-bwr-2160/igt@kms_flip@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/fi-bwr-2160/igt@kms_flip@[email protected]

* igt@prime_self_import@basic-with_one_bo_two_files:
- fi-tgl-y: [PASS][5] -> [DMESG-WARN][6] ([i915#402]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html

#### Possible fixes ####

* igt@i915_selftest@live@reset:
- {fi-tgl-dsi}: [FAIL][7] -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/fi-tgl-dsi/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/fi-tgl-dsi/igt@i915_selftest@[email protected]

* igt@prime_vgem@basic-write:
- fi-tgl-y: [DMESG-WARN][9] ([i915#402]) -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/fi-tgl-y/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/fi-tgl-y/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#3004]: https://gitlab.freedesktop.org/drm/intel/issues/3004
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541

Participating hosts (44 -> 38)
------------------------------

Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-dg1-1 fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6063 -> IGTPW_5731

CI-20190529: 20190529
CI_DRM_9956: 188f3fea945b4edbc74418492cd1004a9e7931dd @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5731: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/index.html
IGT_6063: d3b7f74ce5df6fdea03e490b7c64f0c6bfe76f03 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Testlist changes ==

+igt@kms_busy@basic-hang +igt@kms_busy@extended-modeset-hang-newfb +igt@kms_busy@extended-modeset-hang-newfb-with-reset +igt@kms_busy@extended-modeset-hang-oldfb +igt@kms_busy@extended-modeset-hang-oldfb-with-reset +igt@kms_busy@extended-pageflip-hang-newfb +igt@kms_busy@extended-pageflip-hang-oldfb +igt@kms_busy@extended-pageflip-modeset-hang-oldfb -igt@kms_busy@basic-flip-pipe-a -igt@kms_busy@basic-flip-pipe-b -igt@kms_busy@basic-flip-pipe-c -igt@kms_busy@basic-flip-pipe-d -igt@kms_busy@basic-flip-pipe-e -igt@kms_busy@basic-flip-pipe-f -igt@kms_busy@basic-modeset-pipe-a -igt@kms_busy@basic-modeset-pipe-b -igt@kms_busy@basic-modeset-pipe-c -igt@kms_busy@basic-modeset-pipe-d -igt@kms_busy@basic-modeset-pipe-e -igt@kms_busy@basic-modeset-pipe-f -igt@kms_busy@extended-modeset-hang-newfb-pipe-a -igt@kms_busy@extended-modeset-hang-newfb-pipe-b -igt@kms_busy@extended-modeset-hang-newfb-pipe-c -igt@kms_busy@extended-modeset-hang-newfb-pipe-d -igt@kms_busy@extended-modeset-hang-newfb-pipe-e -igt@kms_busy@extended-modeset-hang-newfb-pipe-f -igt@kms_busy@extended-modeset-hang-newfb-with-reset-pipe-a -igt@kms_busy@extended-modeset-hang-newfb-with-reset-pipe-b -igt@kms_busy@extended-modeset-hang-newfb-with-reset-pipe-c -igt@kms_busy@extended-modeset-hang-newfb-with-reset-pipe-d -igt@kms_busy@extended-modeset-hang-newfb-with-reset-pipe-e -igt@kms_busy@extended-modeset-hang-newfb-with-reset-pipe-f -igt@kms_busy@extended-modeset-hang-oldfb-pipe-a -igt@kms_busy@extended-modeset-hang-oldfb-pipe-b -igt@kms_busy@extended-modeset-hang-oldfb-pipe-c -igt@kms_busy@extended-modeset-hang-oldfb-pipe-d -igt@kms_busy@extended-modeset-hang-oldfb-pipe-e -igt@kms_busy@extended-modeset-hang-oldfb-pipe-f -igt@kms_busy@extended-modeset-hang-oldfb-with-reset-pipe-a -igt@kms_busy@extended-modeset-hang-oldfb-with-reset-pipe-b -igt@kms_busy@extended-modeset-hang-oldfb-with-reset-pipe-c -igt@kms_busy@extended-modeset-hang-oldfb-with-reset-pipe-d -igt@kms_busy@extended-modeset-hang-oldfb-with-reset-pipe-e -igt@kms_busy@extended-modeset-hang-oldfb-with-reset-pipe-f -igt@kms_busy@extended-pageflip-hang-newfb-pipe-a -igt@kms_busy@extended-pageflip-hang-newfb-pipe-b -igt@kms_busy@extended-pageflip-hang-newfb-pipe-c -igt@kms_busy@extended-pageflip-hang-newfb-pipe-d -igt@kms_busy@extended-pageflip-hang-newfb-pipe-e -igt@kms_busy@extended-pageflip-hang-newfb-pipe-f -igt@kms_busy@extended-pageflip-hang-oldfb-pipe-a -igt@kms_busy@extended-pageflip-hang-oldfb-pipe-b -igt@kms_busy@extended-pageflip-hang-oldfb-pipe-c -igt@kms_busy@extended-pageflip-hang-oldfb-pipe-d -igt@kms_busy@extended-pageflip-hang-oldfb-pipe-e -igt@kms_busy@extended-pageflip-hang-oldfb-pipe-f -igt@kms_busy@extended-pageflip-modeset-hang-oldfb-pipe-a -igt@kms_busy@extended-pageflip-modeset-hang-oldfb-pipe-b -igt@kms_busy@extended-pageflip-modeset-hang-oldfb-pipe-c -igt@kms_busy@extended-pageflip-modeset-hang-oldfb-pipe-d -igt@kms_busy@extended-pageflip-modeset-hang-oldfb-pipe-e -igt@kms_busy@extended-pageflip-modeset-hang-oldfb-pipe-f

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#2 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_busy: Limit the execution to two pipes (rev5)

In reply to Bhanuprakash Modem
== Series Details ==

== Series Details ==

Series: tests/kms_busy: Limit the execution to two pipes (rev5)
URL : https://patchwork.freedesktop.org/series/87829/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9956_full -> IGTPW_5731_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/index.html

New tests
---------

New tests have been introduced between CI_DRM_9956_full and IGTPW_5731_full:

### New IGT tests (8) ###

* igt@kms_busy@basic-hang:
- Statuses :
- Exec time: [None] s

* igt@kms_busy@extended-modeset-hang-newfb:
- Statuses :
- Exec time: [None] s

* igt@kms_busy@extended-modeset-hang-newfb-with-reset:
- Statuses :
- Exec time: [None] s

* igt@kms_busy@extended-modeset-hang-oldfb:
- Statuses :
- Exec time: [None] s

* igt@kms_busy@extended-modeset-hang-oldfb-with-reset:
- Statuses :
- Exec time: [None] s

* igt@kms_busy@extended-pageflip-hang-newfb:
- Statuses :
- Exec time: [None] s

* igt@kms_busy@extended-pageflip-hang-oldfb:
- Statuses :
- Exec time: [None] s

* igt@kms_busy@extended-pageflip-modeset-hang-oldfb:
- Statuses :
- Exec time: [None] s

Known issues
------------

Here are the changes found in IGTPW_5731_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_create@create-massive:
- shard-kbl: NOTRUN -> [DMESG-WARN][1] ([i915#3002])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-kbl2/igt@[email protected]

* igt@gem_ctx_persistence@engines-cleanup:
- shard-snb: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099]) +4 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-snb7/igt@[email protected]

* igt@gem_ctx_persistence@smoketest:
- shard-tglb: [PASS][3] -> [FAIL][4] ([i915#2896])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-tglb7/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-tglb6/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][5] -> [TIMEOUT][6] ([i915#2369] / [i915#3063])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-tglb7/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-tglb3/igt@[email protected]
- shard-snb: NOTRUN -> [FAIL][7] ([i915#3354])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-snb6/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [PASS][8] -> [FAIL][9] ([i915#2846])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-kbl4/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-kbl4/igt@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-glk7/igt@gem_exec_fair@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-glk9/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-kbl: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-kbl7/igt@gem_exec_fair@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-kbl7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][14] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@rcs0:
- shard-tglb: [PASS][15] -> [FAIL][16] ([i915#2842])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-tglb6/igt@gem_exec_fair@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-tglb6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][17] -> [SKIP][18] ([fdo#109271])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-kbl7/igt@gem_exec_fair@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_reloc@basic-parallel:
- shard-iclb: [PASS][19] -> [TIMEOUT][20] ([i915#3183])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-iclb3/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb4/igt@[email protected]

* igt@gem_exec_reloc@basic-wide-active@rcs0:
- shard-snb: NOTRUN -> [FAIL][21] ([i915#2389]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-snb2/igt@gem_exec_reloc@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#2190])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl2/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-big-copy-odd:
- shard-iclb: [PASS][23] -> [FAIL][24] ([i915#307]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-iclb3/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb2/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-big-copy-xy:
- shard-iclb: [PASS][25] -> [FAIL][26] ([i915#2428])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-iclb2/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb6/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3323])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl8/igt@[email protected]

* igt@gem_userptr_blits@input-checking:
- shard-apl: NOTRUN -> [DMESG-WARN][28] ([i915#3002]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl2/igt@[email protected]

* igt@gem_userptr_blits@readonly-unsync:
- shard-tglb: NOTRUN -> [SKIP][29] ([i915#3297])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-tglb5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][30] ([i915#3297])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb7/igt@[email protected]

* igt@gem_userptr_blits@set-cache-level:
- shard-snb: NOTRUN -> [FAIL][31] ([i915#3324])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-snb7/igt@[email protected]

* igt@gen7_exec_parse@basic-rejected:
- shard-tglb: NOTRUN -> [SKIP][32] ([fdo#109289])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-tglb3/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][33] ([fdo#109289])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb5/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-fence:
- shard-tglb: NOTRUN -> [WARN][34] ([i915#2681])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-tglb6/igt@[email protected]
- shard-iclb: NOTRUN -> [WARN][35] ([i915#1804] / [i915#2684])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb6/igt@[email protected]

* igt@kms_big_fb@x-tiled-32bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][36] ([fdo#110725] / [fdo#111614]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb1/igt@[email protected]

* igt@kms_big_fb@y-tiled-8bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][37] ([fdo#111614]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-tglb7/igt@[email protected]

* igt@kms_big_fb@yf-tiled-32bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][38] ([fdo#111615])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-tglb8/igt@[email protected]

* igt@kms_color_chamelium@pipe-c-ctm-red-to-blue:
- shard-snb: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +16 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-snb7/igt@[email protected]

* igt@kms_color_chamelium@pipe-c-degamma:
- shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-kbl4/igt@[email protected]

* igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes:
- shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +23 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl2/igt@[email protected]

* igt@kms_content_protection@lic:
- shard-apl: NOTRUN -> [TIMEOUT][42] ([i915#1319]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl7/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-32x10-random:
- shard-kbl: NOTRUN -> [SKIP][43] ([fdo#109271]) +49 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-kbl2/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-max-size-offscreen:
- shard-glk: NOTRUN -> [SKIP][44] ([fdo#109271]) +16 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-glk5/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][45] ([i915#3359])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-tglb8/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: NOTRUN -> [DMESG-WARN][46] ([i915#180])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl8/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-512x512-onscreen:
- shard-tglb: NOTRUN -> [SKIP][47] ([fdo#109279] / [i915#3359])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-tglb5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109278] / [fdo#109279])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb7/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-64x64-onscreen:
- shard-glk: [PASS][49] -> [FAIL][50] ([i915#54])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-glk3/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-glk3/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][51] ([i915#54])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl8/igt@[email protected]
- shard-kbl: [PASS][52] -> [FAIL][53] ([i915#54])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-kbl7/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-kbl1/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-256x85-onscreen:
- shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109278]) +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb7/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-render-ytiled:
- shard-glk: [PASS][55] -> [FAIL][56] ([i915#52] / [i915#54]) +3 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-glk9/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-glk5/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-apl: [PASS][57] -> [DMESG-WARN][58] ([i915#180]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-apl6/igt@kms_flip@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl8/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-apl: NOTRUN -> [FAIL][59] ([i915#2641])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl6/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2642])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl8/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-render:
- shard-glk: [PASS][61] -> [FAIL][62] ([i915#49])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-render.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary:
- shard-kbl: [PASS][63] -> [FAIL][64] ([i915#2546] / [i915#49])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-kbl1/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-kbl7/igt@[email protected]
- shard-apl: [PASS][65] -> [FAIL][66] ([i915#49])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-apl8/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-onoff:
- shard-iclb: NOTRUN -> [SKIP][67] ([fdo#109280])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][68] ([fdo#111825])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-tglb5/igt@[email protected]

* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][69] -> [SKIP][70] ([i915#433])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-tglb2/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-tglb7/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][71] -> [INCOMPLETE][72] ([i915#155] / [i915#794])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-kbl7/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-kbl3/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][73] ([fdo#108145] / [i915#265]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][74] ([fdo#108145] / [i915#265])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-kbl4/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][75] ([i915#265])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl8/igt@[email protected]

* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: NOTRUN -> [SKIP][76] ([i915#658])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb6/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#658]) +4 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl2/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
- shard-kbl: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#658]) +2 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-kbl4/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-glk: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#658]) +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-glk6/igt@kms_psr2_su@page_flip.html
- shard-iclb: NOTRUN -> [SKIP][80] ([fdo#109642] / [fdo#111068] / [i915#658])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb4/igt@kms_psr2_su@page_flip.html

* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][81] -> [SKIP][82] ([fdo#109441]) +2 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb1/igt@kms_psr@psr2_cursor_blt.html

* igt@kms_psr@psr2_primary_render:
- shard-iclb: NOTRUN -> [SKIP][83] ([fdo#109441])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb1/igt@kms_psr@psr2_primary_render.html

* igt@kms_vblank@pipe-d-query-forked-hang:
- shard-snb: NOTRUN -> [SKIP][84] ([fdo#109271]) +395 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-snb2/igt@[email protected]

* igt@kms_vblank@pipe-d-ts-continuation-idle:
- shard-apl: NOTRUN -> [SKIP][85] ([fdo#109271]) +242 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl8/igt@[email protected]

* igt@kms_vblank@pipe-d-wait-idle:
- shard-kbl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#533])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-kbl1/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#533]) +3 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl8/igt@[email protected]

* igt@kms_writeback@writeback-check-output:
- shard-kbl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#2437])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-kbl6/igt@[email protected]

* igt@prime_udl:
- shard-iclb: NOTRUN -> [SKIP][89] ([fdo#109291])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb6/igt@prime_udl.html
- shard-tglb: NOTRUN -> [SKIP][90] ([fdo#109291])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-tglb5/igt@prime_udl.html

* igt@prime_vgem@fence-write-hang:
- shard-iclb: NOTRUN -> [SKIP][91] ([fdo#109295])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb8/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][92] ([fdo#109295])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-tglb6/igt@[email protected]

* igt@sysfs_clients@split-25:
- shard-apl: NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#2994])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl1/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [FAIL][94] ([i915#2842]) -> [PASS][95] +3 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-glk1/igt@gem_exec_fair@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-glk5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [FAIL][96] ([i915#2842]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-iclb5/igt@gem_exec_fair@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][98] ([i915#2842]) -> [PASS][99] +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-tglb2/igt@gem_exec_fair@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-tglb6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs0:
- shard-kbl: [FAIL][100] ([i915#2842]) -> [PASS][101] +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-kbl7/igt@gem_exec_fair@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_mmap_offset@clear:
- shard-iclb: [FAIL][102] ([i915#3160]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-iclb6/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb8/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][104] ([i915#2782]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-snb5/igt@i915_selftest@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-snb7/igt@i915_selftest@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled:
- shard-glk: [FAIL][106] ([i915#52] / [i915#54]) -> [PASS][107] +3 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-glk3/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-glk5/igt@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [INCOMPLETE][108] ([i915#180]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-apl2/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl2/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][110] ([i915#2122]) -> [PASS][111] +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-glk1/igt@kms_flip@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-glk1/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [INCOMPLETE][112] ([i915#155]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-kbl2/igt@kms_flip@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-kbl3/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [DMESG-WARN][114] ([i915#180]) -> [PASS][115] +1 similar issue
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-apl8/igt@kms_flip@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl6/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [DMESG-WARN][116] ([i915#180]) -> [PASS][117] +1 similar issue
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-kbl1/igt@kms_flip@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-kbl6/igt@kms_flip@[email protected]

* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [SKIP][118] ([fdo#109441]) -> [PASS][119] +1 similar issue
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-iclb7/igt@kms_psr@psr2_cursor_plane_move.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html

#### Warnings ####

* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][120] ([i915#658]) -> [SKIP][121] ([i915#588])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-iclb4/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb2/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][122] ([i915#658]) -> [SKIP][123] ([i915#2920]) +2 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-iclb8/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb2/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-iclb: [SKIP][124] ([i915#2920]) -> [SKIP][125] ([i915#658]) +1 similar issue
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-iclb2/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-iclb4/igt@[email protected]

* igt@runner@aborted:
- shard-kbl: ([FAIL][126], [FAIL][127], [FAIL][128]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002]) -> ([FAIL][129], [FAIL][130]) ([i915#3002])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-kbl1/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-kbl7/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-kbl1/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-kbl7/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-kbl2/igt@[email protected]
- shard-apl: ([FAIL][131], [FAIL][132], [FAIL][133]) ([i915#180] / [i915#1814]) -> ([FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138]) ([i915#180] / [i915#1814] / [i915#3002])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-apl8/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-apl1/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9956/shard-apl2/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl6/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl8/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl6/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl8/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/shard-apl2/igt@[email protected]

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2428]: https://gitlab.freedesktop.org/drm/intel/issues/2428
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#2641]: https://gitlab.freedesktop.org/drm

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5731/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#3 lore raw
In reply to Bhanuprakash Modem
Quoted 2 lines · Bhanuprakash Modem

As all pipes are symmetric, restrict the execution to two pipes can save lot of CI time.

Above statement is not correct, all pipes are not symmetric, AFAIK PIPE_A has lower power capability with DMC save/restore (low power single pipe)
Which is even extend to PIPE_B on XE_LPD, which adds DMC save/restore even for PIPE_B as well (low power dual pipe).

please mention the property of each pipe in commit message, so it can be known, we should not loose any validation coverage in order to save CI time.

This patch doesn't choose distinct crtc's to run the test.

Thanks,
Anshuman Gupta.

Quoted 213 lines

If we want to execute on all pipes, we need to pass an extra argument "-e" indicates extended.

Example: ./build/tests/kms_busy -e --r basic

V2, V3:
* Fix the typo in args handler (Petri)
V4:
* Handle clampling cleanly (Petri)
* Restore lost test coverage in the previous version (Petri/Bhanu) V5:
* Fix two subtest with the name "basic" (Petri)

Cc Karthik B S <[email protected]>
Cc Latvala Petri <[email protected]>
Cc Kunche Kishore <[email protected]>
Cc Uma Shankar <[email protected]>
---
 tests/kms_busy.c | 139 ++++++++++++++++++++++++++++++-----------------
 1 file changed, 89 insertions(+), 50 deletions(-)
tests/kms_busy.c +89 -50
index df1f8e11a..095896db5 100644
@@ -30,6 +30,11 @@
 
 IGT_TEST_DESCRIPTION("Basic check of KMS ABI with busy framebuffers.");
 
+/* restricted pipe count */
+#define CRTC_RESTRICT_CNT 2
+
+static bool all_pipes = false;
+
 static igt_output_t *
 set_fb_on_crtc(igt_display_t *dpy, int pipe, struct igt_fb *fb)
 {
@@ -287,10 +292,41 @@ static void test_pageflip_modeset_hang(igt_display_t *dpy, enum pipe pipe)
 	igt_remove_fb(dpy->drm_fd, &fb);
 }
 
-igt_main
+static int opt_handler(int opt, int opt_index, void *data)
+{
+	switch (opt) {
+		case 'e':
+			all_pipes = true;
+			break;
+		default:
+			return IGT_OPT_HANDLER_ERROR;
+	}
+
+	return IGT_OPT_HANDLER_SUCCESS;
+}
+
+const char *help_str =
+	"  -e \tRun on all pipes. (By default subtests will run on two pipes)\n";
+
+igt_main_args("e", NULL, help_str, opt_handler, NULL)
 {
 	igt_display_t display = { .drm_fd = -1, .n_pipes = IGT_MAX_PIPES };
-	enum pipe n;
+
+	int crtc_count;
+	int i;
+	struct {
+		const char *name;
+		bool modeset;
+		bool hang_newfb;
+		bool reset;
+	} tests[] = {
+		{ "extended-pageflip-hang-oldfb", false, false, false },
+		{ "extended-pageflip-hang-newfb", false, true, false },
+		{ "extended-modeset-hang-oldfb", true, false, false },
+		{ "extended-modeset-hang-newfb", true, true, false },
+		{ "extended-modeset-hang-oldfb-with-reset", true, false, true },
+		{ "extended-modeset-hang-newfb-with-reset", true, true, true },
+	};
 
 	igt_fixture {
 		int fd = drm_open_driver_master(DRIVER_INTEL);
@@ -318,70 +354,73 @@ igt_main
 		}
 	}
 
-	for_each_pipe_static(n) igt_subtest_group {
-		igt_hang_t hang;
-
+	igt_subtest_with_dynamic("basic-hang") {
+		enum pipe pipe;
+		igt_output_t *output;
+		int count = 0;
+		igt_hang_t hang = igt_allow_hang(display.drm_fd, 0, 0);
 		errno = 0;
 
-		igt_fixture {
-			igt_display_require_output_on_pipe(&display, n);
-		}
-
-		igt_subtest_f("basic-flip-pipe-%s", kmstest_pipe_name(n)) {
-			test_flip(&display, n, false);
-		}
-		igt_subtest_f("basic-modeset-pipe-%s", kmstest_pipe_name(n)) {
-
-			test_flip(&display, n, true);
-		}
-
-		igt_fixture {
-			hang = igt_allow_hang(display.drm_fd, 0, 0);
-		}
+		crtc_count = (all_pipes)? display.n_pipes : CRTC_RESTRICT_CNT;
+		for_each_pipe_with_valid_output(&display, pipe, output) {
+			igt_dynamic_f("flip-pipe-%s", kmstest_pipe_name(pipe))
+				test_flip(&display, pipe, false);
+			igt_dynamic_f("modeset-pipe-%s", kmstest_pipe_name(pipe))
+				test_flip(&display, pipe, true);
 
-		igt_subtest_f("extended-pageflip-modeset-hang-oldfb-pipe-%s",
-			      kmstest_pipe_name(n)) {
-			test_pageflip_modeset_hang(&display, n);
+			if (++count >= crtc_count)
+				break;
 		}
 
-		igt_fixture
-			igt_require(display.is_atomic);
+		igt_disallow_hang(display.drm_fd, hang);
+	}
 
-		igt_subtest_f("extended-pageflip-hang-oldfb-pipe-%s",
-			      kmstest_pipe_name(n))
-			test_hang(&display, n, false, false);
+	igt_subtest_with_dynamic("extended-pageflip-modeset-hang-oldfb") {
+		enum pipe pipe;
+		igt_output_t *output;
+		int count = 0;
+		igt_hang_t hang = igt_allow_hang(display.drm_fd, 0, 0);
+		errno = 0;
 
-		igt_subtest_f("extended-pageflip-hang-newfb-pipe-%s",
-			      kmstest_pipe_name(n))
-			test_hang(&display, n, false, true);
+		crtc_count = (all_pipes)? display.n_pipes : CRTC_RESTRICT_CNT;
+		for_each_pipe_with_valid_output(&display, pipe, output) {
+			igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe))
+				test_pageflip_modeset_hang(&display, pipe);
 
-		igt_subtest_f("extended-modeset-hang-oldfb-pipe-%s",
-			      kmstest_pipe_name(n))
-			test_hang(&display, n, true, false);
+			if (++count >= crtc_count)
+				break;
+		}
 
-		igt_subtest_f("extended-modeset-hang-newfb-pipe-%s",
-			      kmstest_pipe_name(n))
-			test_hang(&display, n, true, true);
+		igt_disallow_hang(display.drm_fd, hang);
+	}
 
-		igt_subtest_f("extended-modeset-hang-oldfb-with-reset-pipe-%s",
-			      kmstest_pipe_name(n)) {
-			igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 1);
+	for (i = 0; i < sizeof(tests) / sizeof (tests[0]); i++) {
+		igt_subtest_with_dynamic(tests[i].name) {
+			enum pipe pipe;
+			igt_output_t *output;
+			int count = 0;
+			igt_hang_t hang;
+			errno = 0;
 
-			test_hang(&display, n, true, false);
+			igt_require(display.is_atomic);
+			hang = igt_allow_hang(display.drm_fd, 0, 0);
 
-			igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 0);
-		}
+			crtc_count = (all_pipes)? display.n_pipes : CRTC_RESTRICT_CNT;
+			for_each_pipe_with_valid_output(&display, pipe, output) {
+				igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
+					if (tests[i].reset)
+						igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 1);
 
-		igt_subtest_f("extended-modeset-hang-newfb-with-reset-pipe-%s",
-			      kmstest_pipe_name(n)) {
-			igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 1);
+					test_hang(&display, pipe, tests[i].modeset, tests[i].hang_newfb);
 
-			test_hang(&display, n, true, true);
+					if (tests[i].reset)
+						igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 0);
+				}
 
-			igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 0);
-		}
+				if (++count >= crtc_count)
+					break;
+			}
 
-		igt_fixture {
 			igt_disallow_hang(display.drm_fd, hang);
 		}
 	}
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#4 lore raw
Quoted 18 lines

From: Gupta, Anshuman <[email protected]>
Sent: Monday, May 24, 2021 10:24 AM
To: Modem, Bhanuprakash <[email protected]>
Cc: [email protected]; Joshi, Kunal1 <[email protected]>; Latvala, Petri <[email protected]>; Kunche, Kishore <[email protected]>
Subject: Re: [igt-dev] [v5 i-g-t] tests/kms_busy: Limit the execution to two pipes

Quoted 2 lines · Bhanuprakash Modem

As all pipes are symmetric, restrict the execution to two pipes can save lot of CI time.

Above statement is not correct, all pipes are not symmetric, AFAIK PIPE_A has lower power capability with DMC save/restore (low power single pipe)
Which is even extend to PIPE_B on XE_LPD, which adds DMC save/restore even for PIPE_B as well (low power dual pipe).

Quoted 5 lines

please mention the property of each pipe in commit message, so it can be known, we should not loose any validation coverage in order to save CI time.

This patch doesn't choose distinct crtc's to run the test.

Actually, we are not touching any crtc properties here, these tests will perform "page flip" (or) "modeset" by injecting the HANG.

I am not sure that pipe's power capabilities effects flip/modeset. If it effects, we must find a way to identify distinct CRTCs, else restricting the execution to pipe A & B seems fine to me.

@Anshuman, Please suggest.

And, sure I'll update the commit message in next rev.

- Bhanu

Quoted 222 lines

Thanks,
Anshuman Gupta.

tests/kms_busy.c static void test_pageflip_modeset_hang(igt_display_t

Quoted 41 lines

If we want to execute on all pipes, we need to pass an extra argument "-e" indicates extended.

Example: ./build/tests/kms_busy -e --r basic

V2, V3:
* Fix the typo in args handler (Petri)
V4:
* Handle clampling cleanly (Petri)
* Restore lost test coverage in the previous version (Petri/Bhanu) V5:
* Fix two subtest with the name "basic" (Petri)

Cc Karthik B S <[email protected]>
Cc Latvala Petri <[email protected]>
Cc Kunche Kishore <[email protected]>
Cc Uma Shankar <[email protected]>
---
 tests/kms_busy.c | 139 ++++++++++++++++++++++++++++++-----------------
 1 file changed, 89 insertions(+), 50 deletions(-)
tests/kms_busy.c +5 -0
index df1f8e11a..095896db5 100644
@@ -30,6 +30,11 @@
 
 IGT_TEST_DESCRIPTION("Basic check of KMS ABI with busy framebuffers.");
 
+/* restricted pipe count */
+#define CRTC_RESTRICT_CNT 2
+
+static bool all_pipes = false;
+
 static igt_output_t *
 set_fb_on_crtc(igt_display_t *dpy, int pipe, struct igt_fb *fb)
 {
@@ -287,10 +292,41 @@ static void test_pageflip_modeset_hang(igt_display_t

*dpy, enum pipe pipe)

Quoted 9 lines
tests/kms_busy.c +5 -1
 	igt_remove_fb(dpy->drm_fd, &fb);
 }
 
-igt_main
+static int opt_handler(int opt, int opt_index, void *data)
+{
+	switch (opt) {
+		case 'e':
+			all_pipes = true;

tests/kms_busy.c static void test_pageflip_modeset_hang(igt_display_t *dpy, enum pipe pipe)

Quoted 10 lines
tests/kms_busy.c +10 -0
+			break;
+		default:
+			return IGT_OPT_HANDLER_ERROR;
+	}
+
+	return IGT_OPT_HANDLER_SUCCESS;
+}
+
+const char *help_str =
+	"  -e \tRun on all pipes. (By default subtests will run on two

pipes)\n";

Quoted 96 lines
tests/kms_busy.c +46 -33
+
+igt_main_args("e", NULL, help_str, opt_handler, NULL)
 {
 	igt_display_t display = { .drm_fd = -1, .n_pipes = IGT_MAX_PIPES };
-	enum pipe n;
+
+	int crtc_count;
+	int i;
+	struct {
+		const char *name;
+		bool modeset;
+		bool hang_newfb;
+		bool reset;
+	} tests[] = {
+		{ "extended-pageflip-hang-oldfb", false, false, false },
+		{ "extended-pageflip-hang-newfb", false, true, false },
+		{ "extended-modeset-hang-oldfb", true, false, false },
+		{ "extended-modeset-hang-newfb", true, true, false },
+		{ "extended-modeset-hang-oldfb-with-reset", true, false, true },
+		{ "extended-modeset-hang-newfb-with-reset", true, true, true },
+	};
 
 	igt_fixture {
 		int fd = drm_open_driver_master(DRIVER_INTEL);
@@ -318,70 +354,73 @@ igt_main
 		}
 	}
 
-	for_each_pipe_static(n) igt_subtest_group {
-		igt_hang_t hang;
-
+	igt_subtest_with_dynamic("basic-hang") {
+		enum pipe pipe;
+		igt_output_t *output;
+		int count = 0;
+		igt_hang_t hang = igt_allow_hang(display.drm_fd, 0, 0);
 		errno = 0;
 
-		igt_fixture {
-			igt_display_require_output_on_pipe(&display, n);
-		}
-
-		igt_subtest_f("basic-flip-pipe-%s", kmstest_pipe_name(n)) {
-			test_flip(&display, n, false);
-		}
-		igt_subtest_f("basic-modeset-pipe-%s", kmstest_pipe_name(n)) {
-
-			test_flip(&display, n, true);
-		}
-
-		igt_fixture {
-			hang = igt_allow_hang(display.drm_fd, 0, 0);
-		}
+		crtc_count = (all_pipes)? display.n_pipes : CRTC_RESTRICT_CNT;
+		for_each_pipe_with_valid_output(&display, pipe, output) {
+			igt_dynamic_f("flip-pipe-%s", kmstest_pipe_name(pipe))
+				test_flip(&display, pipe, false);
+			igt_dynamic_f("modeset-pipe-%s", kmstest_pipe_name(pipe))
+				test_flip(&display, pipe, true);
 
-		igt_subtest_f("extended-pageflip-modeset-hang-oldfb-pipe-%s",
-			      kmstest_pipe_name(n)) {
-			test_pageflip_modeset_hang(&display, n);
+			if (++count >= crtc_count)
+				break;
 		}
 
-		igt_fixture
-			igt_require(display.is_atomic);
+		igt_disallow_hang(display.drm_fd, hang);
+	}
 
-		igt_subtest_f("extended-pageflip-hang-oldfb-pipe-%s",
-			      kmstest_pipe_name(n))
-			test_hang(&display, n, false, false);
+	igt_subtest_with_dynamic("extended-pageflip-modeset-hang-oldfb") {
+		enum pipe pipe;
+		igt_output_t *output;
+		int count = 0;
+		igt_hang_t hang = igt_allow_hang(display.drm_fd, 0, 0);
+		errno = 0;
 
-		igt_subtest_f("extended-pageflip-hang-newfb-pipe-%s",
-			      kmstest_pipe_name(n))
-			test_hang(&display, n, false, true);
+		crtc_count = (all_pipes)? display.n_pipes : CRTC_RESTRICT_CNT;
+		for_each_pipe_with_valid_output(&display, pipe, output) {
+			igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe))
+				test_pageflip_modeset_hang(&display, pipe);
 
-		igt_subtest_f("extended-modeset-hang-oldfb-pipe-%s",
-			      kmstest_pipe_name(n))
-			test_hang(&display, n, true, false);
+			if (++count >= crtc_count)
+				break;
+		}

tests/kms_busy.c igt_main · line 368

Quoted 10 lines
tests/kms_busy.c +2 -6
 
-		igt_subtest_f("extended-modeset-hang-newfb-pipe-%s",
-			      kmstest_pipe_name(n))
-			test_hang(&display, n, true, true);
+		igt_disallow_hang(display.drm_fd, hang);
+	}
 
-		igt_subtest_f("extended-modeset-hang-oldfb-with-reset-pipe-%s",
-			      kmstest_pipe_name(n)) {
-			igt_set_module_param_int(display.drm_fd,

"force_reset_modeset_test", 1);

tests/kms_busy.c igt_main

Quoted 13 lines
tests/kms_busy.c +9 -2
+	for (i = 0; i < sizeof(tests) / sizeof (tests[0]); i++) {
+		igt_subtest_with_dynamic(tests[i].name) {
+			enum pipe pipe;
+			igt_output_t *output;
+			int count = 0;
+			igt_hang_t hang;
+			errno = 0;
 
-			test_hang(&display, n, true, false);
+			igt_require(display.is_atomic);
+			hang = igt_allow_hang(display.drm_fd, 0, 0);
 
-			igt_set_module_param_int(display.drm_fd,

"force_reset_modeset_test", 0);

tests/kms_busy.c igt_main · line 408

Quoted 2 lines
tests/kms_busy.c +1 -1
-		}
+			crtc_count = (all_pipes)? display.n_pipes :

CRTC_RESTRICT_CNT;

tests/kms_busy.c igt_main

Quoted 4 lines
tests/kms_busy.c +4 -0
+			for_each_pipe_with_valid_output(&display, pipe, output) {
+				igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
+					if (tests[i].reset)
+						igt_set_module_param_int(display.drm_fd,

"force_reset_modeset_test", 1);

tests/kms_busy.c igt_main

Quoted 4 lines
tests/kms_busy.c +0 -3
-		igt_subtest_f("extended-modeset-hang-newfb-with-reset-pipe-%s",
-			      kmstest_pipe_name(n)) {
-			igt_set_module_param_int(display.drm_fd,

"force_reset_modeset_test", 1);

tests/kms_busy.c igt_main · line 413

Quoted 1 line
tests/kms_busy.c +1 -0
+					test_hang(&display, pipe, tests[i].modeset,

tests[i].hang_newfb);

tests/kms_busy.c igt_main

Quoted 4 lines
tests/kms_busy.c +2 -1
-			test_hang(&display, n, true, true);
+					if (tests[i].reset)
+						igt_set_module_param_int(display.drm_fd,

"force_reset_modeset_test", 0);

tests/kms_busy.c static void test_pageflip_modeset_hang(igt_display_t *dpy, enum pipe pipe)

Quoted 3 lines
tests/kms_busy.c +1 -1
+				}
 
-			igt_set_module_param_int(display.drm_fd,

"force_reset_modeset_test", 0);

Quoted 12 lines
tests/kms_busy.c +3 -3
-		}
+				if (++count >= crtc_count)
+					break;
+			}
 
-		igt_fixture {
 			igt_disallow_hang(display.drm_fd, hang);
 		}
 	}
--

2.20.1

Quoted 4 lines
Quoted 4 lines

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#5 lore raw
Quoted 35 lines

-----Original Message-----
From: Modem, Bhanuprakash <[email protected]>
Sent: Monday, May 24, 2021 2:22 PM
To: Gupta, Anshuman <[email protected]>; igt- [email protected]
Cc: Joshi, Kunal1 <[email protected]>; Latvala, Petri <[email protected]>; Kunche, Kishore <[email protected]>; Shankar, Uma <[email protected]>; B S, Karthik <[email protected]>
Subject: RE: [igt-dev] [v5 i-g-t] tests/kms_busy: Limit the execution to two pipes

Quoted 21 lines

From: Gupta, Anshuman <[email protected]>
Sent: Monday, May 24, 2021 10:24 AM
To: Modem, Bhanuprakash <[email protected]>
Cc: [email protected]; Joshi, Kunal1 <[email protected]>; Latvala, Petri <[email protected]>; Kunche, Kishore <[email protected]>
Subject: Re: [igt-dev] [v5 i-g-t] tests/kms_busy: Limit the execution to two pipes

Quoted 2 lines · Bhanuprakash Modem

As all pipes are symmetric, restrict the execution to two pipes can save lot of CI time.

Above statement is not correct, all pipes are not symmetric, AFAIK PIPE_A has lower power capability with DMC save/restore (low power single pipe) Which is even extend to PIPE_B on XE_LPD, which adds DMC save/restore even for PIPE_B as well (low power dual pipe).

please mention the property of each pipe in commit message, so it can be known, we should not loose any validation coverage in order to save CI time.

Quoted 8 lines
Quoted 1 line

This patch doesn't choose distinct crtc's to run the test.

Actually, we are not touching any crtc properties here, these tests will perform "page flip" (or) "modeset" by injecting the HANG.

I am not sure that pipe's power capabilities effects flip/modeset. If it effects, we must find a way to identify distinct CRTCs, else restricting the execution to pipe A & B seems fine to me.

Above mentioned pipe properties related to power was known to me,
There can be other distinct pipe properties as well.
We can can't overlook any pipe power capabilities, and assume it won't impact flip or modeset. We had observed underruns from flips/modeset related test in past.
In my opinion there is no harm to execute these test on distinct crtc.

Thanks,
Anshuman.

Quoted 247 lines

@Anshuman, Please suggest.

And, sure I'll update the commit message in next rev.

- Bhanu

Quoted 23 lines

Thanks,
Anshuman Gupta.

Quoted 20 lines

If we want to execute on all pipes, we need to pass an extra argument "-e" indicates extended.

Example: ./build/tests/kms_busy -e --r basic

V2, V3:
* Fix the typo in args handler (Petri)
V4:
* Handle clampling cleanly (Petri)
* Restore lost test coverage in the previous version (Petri/Bhanu) V5:
* Fix two subtest with the name "basic" (Petri)

Cc Karthik B S <[email protected]>
Cc Latvala Petri <[email protected]>
Cc Kunche Kishore <[email protected]>
Cc Uma Shankar <[email protected]>
Signed-off-by Bhanuprakash Modem

<[email protected]>

Quoted 54 lines
Quoted 22 lines
---
 tests/kms_busy.c | 139
++++++++++++++++++++++++++++++-----------------
 1 file changed, 89 insertions(+), 50 deletions(-)
tests/kms_busy.c index renamed from tests/kms_busy.c +0 -0

df1f8e11a..095896db5 100644

tests/kms_busy.c +5 -0
@@ -30,6 +30,11 @@
 
 IGT_TEST_DESCRIPTION("Basic check of KMS ABI with busy
 framebuffers.");
 
+/* restricted pipe count */
+#define CRTC_RESTRICT_CNT 2
+
+static bool all_pipes = false;
+
 static igt_output_t *
 set_fb_on_crtc(igt_display_t *dpy, int pipe, struct igt_fb *fb)  {
@@ -287,10 +292,41 @@ static void
Quoted 1 line

test_pageflip_modeset_hang(igt_display_t

*dpy, enum pipe pipe)

Quoted 8 lines
tests/kms_busy.c +4 -1
 	igt_remove_fb(dpy->drm_fd, &fb);
 }
 
-igt_main
+static int opt_handler(int opt, int opt_index, void *data) {
+	switch (opt) {
+		case 'e':
+			all_pipes = true;

tests/kms_busy.c static void test_pageflip_modeset_hang(igt_display_t *dpy, enum pipe pipe)

Quoted 10 lines
tests/kms_busy.c +10 -0
+			break;
+		default:
+			return IGT_OPT_HANDLER_ERROR;
+	}
+
+	return IGT_OPT_HANDLER_SUCCESS;
+}
+
+const char *help_str =
+	"  -e \tRun on all pipes. (By default subtests will run on two

pipes)\n";

Quoted 11 lines
tests/kms_busy.c +8 -1
+
+igt_main_args("e", NULL, help_str, opt_handler, NULL)
 {
 	igt_display_t display = { .drm_fd = -1, .n_pipes = IGT_MAX_PIPES };
-	enum pipe n;
+
+	int crtc_count;
+	int i;
+	struct {
+		const char *name;
+		bool modeset;
Quoted 8 lines

tests/kms_busy.c static void test_pageflip_modeset_hang(igt_display_t *dpy, enum pipe pipe)

Quoted 8 lines
tests/kms_busy.c +8 -0
+		bool hang_newfb;
+		bool reset;
+	} tests[] = {
+		{ "extended-pageflip-hang-oldfb", false, false, false },
+		{ "extended-pageflip-hang-newfb", false, true, false },
+		{ "extended-modeset-hang-oldfb", true, false, false },
+		{ "extended-modeset-hang-newfb", true, true, false },
+		{ "extended-modeset-hang-oldfb-with-reset", true, false, true

},

Quoted 1 line

tests/kms_busy.c

Quoted 1 line
tests/kms_busy.c +1 -0
+		{ "extended-modeset-hang-newfb-with-reset", true, true,

true },

Quoted 18 lines
Quoted 18 lines
tests/kms_busy.c +6 -3
+	};
 
 	igt_fixture {
 		int fd = drm_open_driver_master(DRIVER_INTEL);
@@ -318,70 +354,73 @@ igt_main
 		}
 	}
 
-	for_each_pipe_static(n) igt_subtest_group {
-		igt_hang_t hang;
-
+	igt_subtest_with_dynamic("basic-hang") {
+		enum pipe pipe;
+		igt_output_t *output;
+		int count = 0;
+		igt_hang_t hang = igt_allow_hang(display.drm_fd, 0, 0);
 		errno = 0;
 
Quoted 8 lines

tests/kms_busy.c igt_main

Quoted 8 lines
tests/kms_busy.c +0 -8
-		igt_fixture {
-			igt_display_require_output_on_pipe(&display, n);
-		}
-
-		igt_subtest_f("basic-flip-pipe-%s", kmstest_pipe_name(n)) {
-			test_flip(&display, n, false);
-		}
-		igt_subtest_f("basic-modeset-pipe-%s",

kmstest_pipe_name(n)) {

Quoted 8 lines

tests/kms_busy.c igt_main

Quoted 8 lines
tests/kms_busy.c +1 -7
-
-			test_flip(&display, n, true);
-		}
-
-		igt_fixture {
-			hang = igt_allow_hang(display.drm_fd, 0, 0);
-		}
+		crtc_count = (all_pipes)? display.n_pipes :

CRTC_RESTRICT_CNT;

Quoted 2 lines

tests/kms_busy.c igt_main · line 366

Quoted 2 lines
tests/kms_busy.c +2 -0
+		for_each_pipe_with_valid_output(&display, pipe, output) {
+			igt_dynamic_f("flip-pipe-%s",

kmstest_pipe_name(pipe))

Quoted 2 lines

tests/kms_busy.c igt_main · line 368

Quoted 2 lines
tests/kms_busy.c +2 -0
+				test_flip(&display, pipe, false);
+			igt_dynamic_f("modeset-pipe-%s",

kmstest_pipe_name(pipe))

Quoted 3 lines

tests/kms_busy.c igt_main

Quoted 3 lines
tests/kms_busy.c +1 -1
+				test_flip(&display, pipe, true);
 
-		igt_subtest_f("extended-pageflip-modeset-hang-oldfb-pipe-

%s",

Quoted 11 lines
Quoted 11 lines
tests/kms_busy.c +4 -4
-			      kmstest_pipe_name(n)) {
-			test_pageflip_modeset_hang(&display, n);
+			if (++count >= crtc_count)
+				break;
 		}
 
-		igt_fixture
-			igt_require(display.is_atomic);
+		igt_disallow_hang(display.drm_fd, hang);
+	}
 
Quoted 4 lines

tests/kms_busy.c igt_main

Quoted 4 lines
tests/kms_busy.c +1 -3
-		igt_subtest_f("extended-pageflip-hang-oldfb-pipe-%s",
-			      kmstest_pipe_name(n))
-			test_hang(&display, n, false, false);
+	igt_subtest_with_dynamic("extended-pageflip-modeset-hang-oldfb")

{

Quoted 10 lines

tests/kms_busy.c igt_main

Quoted 10 lines
tests/kms_busy.c +6 -3
+		enum pipe pipe;
+		igt_output_t *output;
+		int count = 0;
+		igt_hang_t hang = igt_allow_hang(display.drm_fd, 0, 0);
+		errno = 0;
 
-		igt_subtest_f("extended-pageflip-hang-newfb-pipe-%s",
-			      kmstest_pipe_name(n))
-			test_hang(&display, n, false, true);
+		crtc_count = (all_pipes)? display.n_pipes :

CRTC_RESTRICT_CNT;

Quoted 11 lines
Quoted 11 lines
tests/kms_busy.c +6 -3
+		for_each_pipe_with_valid_output(&display, pipe, output) {
+			igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe))
+				test_pageflip_modeset_hang(&display, pipe);
 
-		igt_subtest_f("extended-modeset-hang-oldfb-pipe-%s",
-			      kmstest_pipe_name(n))
-			test_hang(&display, n, true, false);
+			if (++count >= crtc_count)
+				break;
+		}
 
Quoted 7 lines

tests/kms_busy.c igt_main

Quoted 7 lines
tests/kms_busy.c +2 -4
-		igt_subtest_f("extended-modeset-hang-newfb-pipe-%s",
-			      kmstest_pipe_name(n))
-			test_hang(&display, n, true, true);
+		igt_disallow_hang(display.drm_fd, hang);
+	}
 
-		igt_subtest_f("extended-modeset-hang-oldfb-with-reset-

pipe-%s",

Quoted 15 lines

tests/kms_busy.c igt_main · line 368

Quoted 2 lines
tests/kms_busy.c +0 -2
-			      kmstest_pipe_name(n)) {
-			igt_set_module_param_int(display.drm_fd,

"force_reset_modeset_test", 1);

Quoted 12 lines
tests/kms_busy.c +9 -1
+	for (i = 0; i < sizeof(tests) / sizeof (tests[0]); i++) {
+		igt_subtest_with_dynamic(tests[i].name) {
+			enum pipe pipe;
+			igt_output_t *output;
+			int count = 0;
+			igt_hang_t hang;
+			errno = 0;
 
-			test_hang(&display, n, true, false);
+			igt_require(display.is_atomic);
+			hang = igt_allow_hang(display.drm_fd, 0, 0);
 
Quoted 6 lines

tests/kms_busy.c igt_main · line 372

Quoted 1 line
tests/kms_busy.c +0 -1
-			igt_set_module_param_int(display.drm_fd,

"force_reset_modeset_test", 0);

tests/kms_busy.c igt_main · line 408

Quoted 2 lines
tests/kms_busy.c +1 -1
-		}
+			crtc_count = (all_pipes)? display.n_pipes :

CRTC_RESTRICT_CNT;

tests/kms_busy.c igt_main · line 409

Quoted 1 line
tests/kms_busy.c +1 -0
+			for_each_pipe_with_valid_output(&display, pipe,

output) {

Quoted 1 line

tests/kms_busy.c igt_main · line 410

Quoted 1 line
tests/kms_busy.c +1 -0
+				igt_dynamic_f("pipe-%s",

kmstest_pipe_name(pipe)) {

Quoted 2 lines

tests/kms_busy.c igt_main · line 412

Quoted 2 lines
tests/kms_busy.c +2 -0
+					if (tests[i].reset)
+

igt_set_module_param_int(display.drm_fd,

Quoted 3 lines

"force_reset_modeset_test", 1);

tests/kms_busy.c igt_main · line 374

Quoted 2 lines
tests/kms_busy.c +0 -1
-		igt_subtest_f("extended-modeset-hang-newfb-with-reset-

pipe-%s",

Quoted 4 lines

tests/kms_busy.c igt_main · line 376

Quoted 2 lines
tests/kms_busy.c +0 -2
-			      kmstest_pipe_name(n)) {
-			igt_set_module_param_int(display.drm_fd,

"force_reset_modeset_test", 1);

tests/kms_busy.c igt_main · line 413

Quoted 1 line
tests/kms_busy.c +1 -0
+					test_hang(&display, pipe,

tests[i].modeset,

Quoted 5 lines

tests[i].hang_newfb);

tests/kms_busy.c igt_main

Quoted 4 lines
tests/kms_busy.c +2 -1
-			test_hang(&display, n, true, true);
+					if (tests[i].reset)
+

igt_set_module_param_int(display.drm_fd,

Quoted 17 lines

"force_reset_modeset_test", 0);

tests/kms_busy.c static void test_pageflip_modeset_hang(igt_display_t *dpy, enum pipe pipe)

Quoted 3 lines
tests/kms_busy.c +1 -1
+				}
 
-			igt_set_module_param_int(display.drm_fd,

"force_reset_modeset_test", 0);

Quoted 12 lines
tests/kms_busy.c +3 -3
-		}
+				if (++count >= crtc_count)
+					break;
+			}
 
-		igt_fixture {
 			igt_disallow_hang(display.drm_fd, hang);
 		}
 	}
--

2.20.1

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev