Skip to contentSkip to conversation

tests/kms_cdclk: Drop basic subtest

PATCH In review Swati Sharma 3 participants 6 messages Jul 5, 2021 – Jul 6, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/kms_cdclk: Drop basic subtest

This drops basic subtest since use case is already getting covered by mode transition subtest.

---
 tests/kms_cdclk.c | 61 +++++------------------------------------------
 1 file changed, 6 insertions(+), 55 deletions(-)
tests/kms_cdclk.c +6 -55
index b2e32d25..d2a9fa5f 100644
@@ -26,7 +26,7 @@
 
 #include "igt.h"
 
-IGT_TEST_DESCRIPTION("Test cdclk features : squasher and crawling");
+IGT_TEST_DESCRIPTION("Test cdclk features : crawling");
 
 #define HDISPLAY_4K     3840
 #define VDISPLAY_4K     2160
@@ -34,9 +34,8 @@ IGT_TEST_DESCRIPTION("Test cdclk features : squasher and crawling");
 
 /* Test flags */
 enum {
-	TEST_BASIC = 1 << 0,
-	TEST_PLANESCALING = 1 << 1,
-	TEST_MODETRANSITION = 1 << 2,
+	TEST_PLANESCALING = 1 << 0,
+	TEST_MODETRANSITION = 1 << 1,
 };
 
 typedef struct {
@@ -132,45 +131,6 @@ static void do_cleanup_display(igt_display_t *dpy)
 	igt_display_commit2(dpy, dpy->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
 }
 
-static void test_basic(data_t *data, enum pipe pipe, igt_output_t *output)
-{
-	igt_display_t *display = &data->display;
-	int debugfs_fd = data->debugfs_fd;
-	int cdclk_ref, cdclk_new;
-	struct igt_fb fb;
-	igt_plane_t *primary;
-	drmModeModeInfo *mode;
-
-	do_cleanup_display(display);
-	igt_display_reset(display);
-
-	igt_output_set_pipe(output, pipe);
-	mode = get_highres_mode(output);
-	igt_require(mode != NULL);
-	igt_output_override_mode(output, mode);
-
-	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
-
-	igt_create_color_pattern_fb(display->drm_fd,
-				    mode->hdisplay, mode->vdisplay,
-				    DRM_FORMAT_XRGB8888,
-				    I915_TILING_NONE,
-				    0.0, 0.0, 0.0, &fb);
-
-	igt_plane_set_fb(primary, &fb);
-	cdclk_ref = get_current_cdclk_freq(debugfs_fd);
-	igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
-	cdclk_new = get_current_cdclk_freq(debugfs_fd);
-	igt_info("CD clock frequency %d -> %d\n", cdclk_ref, cdclk_new);
-
-	/* cdclk should bump */
-	igt_assert_lt(cdclk_ref, cdclk_new);
-
-	/* cleanup */
-	do_cleanup_display(display);
-	igt_remove_fb(display->drm_fd, &fb);
-}
-
 static void test_plane_scaling(data_t *data, enum pipe pipe, igt_output_t *output)
 {
 	igt_display_t *display = &data->display;
@@ -284,8 +244,6 @@ static void run_cdclk_test(data_t *data, uint32_t flags)
 	for_each_pipe_with_valid_output(display, pipe, output) {
 		igt_dynamic_f("%s-pipe-%s", output->name, kmstest_pipe_name(pipe))
 			if (igt_pipe_connector_valid(pipe, output)) {
-				if (flags & TEST_BASIC)
-					test_basic(data, pipe, output);
 				if (flags & TEST_PLANESCALING)
 					test_plane_scaling(data, pipe, output);
 				if (flags & TEST_MODETRANSITION)
@@ -306,22 +264,15 @@ igt_main
 		kmstest_set_vt_graphics_mode();
 		data.devid = intel_get_drm_devid(data.drm_fd);
 		igt_require_f(hardware_supported(&data),
-			      "Hardware doesn't support either squashing "\
-			      "or crawling.\n");
+			      "Hardware doesn't support crawling.\n");
 		igt_display_require(&data.display, data.drm_fd);
 		igt_display_require_output(&data.display);
 	}
 
-	igt_describe("Basic test to validate cdclk frequency change w/o "\
-		     "requiring full modeset.");
-	igt_subtest_with_dynamic("basic")
-		run_cdclk_test(&data, TEST_BASIC);
-	igt_describe("Plane scaling test to validate cdclk frequency change w/o "\
-		     "requiring full modeset.");
+	igt_describe("Plane scaling test to validate cdclk frequency change");
 	igt_subtest_with_dynamic("plane-scaling")
 		run_cdclk_test(&data, TEST_PLANESCALING);
-	igt_describe("Mode transition (low to high) test to validate cdclk frequency "\
-		     "change w/o requiring full modeset.");
+	igt_describe("Mode transition (low to high) test to validate cdclk frequency change");
 	igt_subtest_with_dynamic("mode-transition")
 		run_cdclk_test(&data, TEST_MODETRANSITION);
 
Signature · 6 lines
2.25.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_cdclk: Drop basic subtest

== Series Details ==

== Series Details ==

Series: tests/kms_cdclk: Drop basic subtest
URL : https://patchwork.freedesktop.org/series/92211/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10305 -> IGTPW_5981
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_5981 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_5981, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_5981:

### IGT changes ###

#### Possible regressions ####

* igt@gem_exec_parallel@engines@basic:
- fi-icl-y: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-icl-y/igt@gem_exec_parallel@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-icl-y/igt@gem_exec_parallel@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@i915_module_load@reload:
- {fi-tgl-1115g4}: NOTRUN -> [DMESG-WARN][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-tgl-1115g4/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_5981 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@memory-alloc:
- fi-cml-u2: NOTRUN -> [SKIP][4] ([fdo#109315]) +17 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cml-u2/igt@amdgpu/[email protected]

* igt@amdgpu/amd_basic@semaphore:
- fi-bsw-nick: NOTRUN -> [SKIP][5] ([fdo#109271]) +17 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bsw-nick/igt@amdgpu/[email protected]
- fi-bdw-5557u: NOTRUN -> [SKIP][6] ([fdo#109271]) +27 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bdw-5557u/igt@amdgpu/[email protected]

* igt@amdgpu/amd_prime@i915-to-amd:
- fi-snb-2520m: NOTRUN -> [SKIP][7] ([fdo#109271]) +33 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-snb-2520m/igt@amdgpu/[email protected]

* igt@core_hotunplug@unbind-rebind:
- fi-hsw-4770: NOTRUN -> [WARN][8] ([i915#3718])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]
- fi-bdw-5557u: NOTRUN -> [WARN][9] ([i915#3718])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bdw-5557u/igt@[email protected]

* igt@gem_exec_fence@basic-busy@bcs0:
- fi-apl-guc: NOTRUN -> [SKIP][10] ([fdo#109271]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-apl-guc/igt@gem_exec_fence@[email protected]

* igt@gem_exec_parallel@engines@basic:
- fi-bxt-dsi: [PASS][11] -> [DMESG-WARN][12] ([i915#1610])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-bxt-dsi/igt@gem_exec_parallel@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bxt-dsi/igt@gem_exec_parallel@[email protected]
- fi-apl-guc: NOTRUN -> [DMESG-WARN][13] ([i915#1610])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-apl-guc/igt@gem_exec_parallel@[email protected]

* igt@gem_exec_parallel@engines@userptr:
- fi-cfl-8109u: [PASS][14] -> [DMESG-WARN][15] ([i915#1610])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-cfl-8109u/igt@gem_exec_parallel@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cfl-8109u/igt@gem_exec_parallel@[email protected]
- fi-glk-dsi: [PASS][16] -> [DMESG-WARN][17] ([i915#1610])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-glk-dsi/igt@gem_exec_parallel@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-glk-dsi/igt@gem_exec_parallel@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-hsw-4770: NOTRUN -> [SKIP][18] ([fdo#109271]) +4 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]
- fi-kbl-8809g: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#2190])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-kbl-8809g/igt@[email protected]

* igt@i915_pm_backlight@basic-brightness:
- fi-hsw-4770: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#3012])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]

* igt@i915_selftest@live@active:
- fi-hsw-4770: NOTRUN -> [DMESG-FAIL][21] ([i915#2927])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@i915_selftest@[email protected]

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-4770: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111827]) +8 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]

* igt@kms_chamelium@dp-crc-fast:
- fi-bdw-5557u: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111827]) +8 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bdw-5557u/igt@[email protected]

* igt@kms_chamelium@dp-hpd-fast:
- fi-cml-u2: NOTRUN -> [SKIP][24] ([fdo#109284] / [fdo#111827]) +8 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cml-u2/igt@[email protected]

* igt@kms_chamelium@hdmi-edid-read:
- fi-kbl-8809g: NOTRUN -> [SKIP][25] ([fdo#109271] / [fdo#111827]) +8 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-kbl-8809g/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-snb-2520m: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +8 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-snb-2520m/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-cml-u2: NOTRUN -> [SKIP][27] ([fdo#109285])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cml-u2/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-hsw-4770: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#533])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]
- fi-cml-u2: NOTRUN -> [SKIP][29] ([fdo#109278] / [i915#533])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cml-u2/igt@[email protected]
- fi-kbl-8809g: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#533])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-kbl-8809g/igt@[email protected]

* igt@kms_psr@cursor_plane_move:
- fi-kbl-8809g: NOTRUN -> [SKIP][31] ([fdo#109271]) +37 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-kbl-8809g/igt@kms_psr@cursor_plane_move.html

* igt@kms_psr@primary_mmap_gtt:
- fi-hsw-4770: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#1072]) +3 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@kms_psr@primary_mmap_gtt.html

* igt@prime_vgem@basic-userptr:
- fi-cml-u2: NOTRUN -> [SKIP][33] ([i915#3301])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cml-u2/igt@[email protected]

* igt@runner@aborted:
- fi-cfl-8109u: NOTRUN -> [FAIL][34] ([i915#2426] / [i915#3363] / [i915#3364])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cfl-8109u/igt@[email protected]
- fi-apl-guc: NOTRUN -> [FAIL][35] ([i915#2426] / [i915#3363] / [i915#3364] / [i915#337])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-apl-guc/igt@[email protected]
- fi-bxt-dsi: NOTRUN -> [FAIL][36] ([i915#2426] / [i915#3363] / [i915#3364])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bxt-dsi/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_parallel@engines@basic:
- fi-glk-dsi: [DMESG-WARN][37] ([i915#1610]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-glk-dsi/igt@gem_exec_parallel@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-glk-dsi/igt@gem_exec_parallel@[email protected]

* igt@gem_exec_parallel@engines@contexts:
- fi-snb-2520m: [DMESG-WARN][39] -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-snb-2520m/igt@gem_exec_parallel@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-snb-2520m/igt@gem_exec_parallel@[email protected]

* igt@gem_exec_parallel@engines@userptr:
- fi-icl-y: [DMESG-WARN][41] -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-icl-y/igt@gem_exec_parallel@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-icl-y/igt@gem_exec_parallel@[email protected]

* igt@gem_exec_suspend@basic-s3:
- fi-hsw-4770: [DMESG-WARN][43] -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-hsw-4770/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]

* igt@gem_sync@basic-each:
- fi-cml-u2: [DMESG-WARN][45] ([i915#1610]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-cml-u2/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cml-u2/igt@[email protected]

* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [INCOMPLETE][47] ([i915#2782] / [i915#2940]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-bsw-nick/igt@i915_selftest@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bsw-nick/igt@i915_selftest@[email protected]

* igt@kms_flip@basic-flip-vs-dpms@b-dp3:
- {fi-tgl-1115g4}: [DMESG-WARN][49] -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-tgl-1115g4/igt@kms_flip@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-tgl-1115g4/igt@kms_flip@[email protected]

#### Warnings ####

* igt@runner@aborted:
- fi-hsw-4770: [FAIL][51] ([i915#2505]) -> [FAIL][52] ([fdo#109271] / [i915#1436] / [i915#2505])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-hsw-4770/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2292]: https://gitlab.freedesktop.org/drm/intel/issues/2292
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3364]: https://gitlab.freedesktop.org/drm/intel/issues/3364
[i915#337]: https://gitlab.freedesktop.org/drm/intel/issues/337
[i915#3690]: https://gitlab.freedesktop.org/drm/intel/issues/3690
[i915#3717]: https://gitlab.freedesktop.org/drm/intel/issues/3717
[i915#3718]: https://gitlab.freedesktop.org/drm/intel/issues/3718
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[k.org#204565]: https://bugzilla.kernel.org/show_bug.cgi?id=204565

Participating hosts (32 -> 28)
------------------------------

Additional (1): fi-apl-guc
Missing (5): fi-kbl-soraka fi-hsw-4200u fi-kbl-7500u fi-pnv-d510 fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6128 -> IGTPW_5981

CI-20190529: 20190529
CI_DRM_10305: fd899b57cb480c98e60ee842671bddd4759dfca3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5981: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/index.html
IGT_6128: b24e5949af7e51f0af484d2ce4cb4c5a41ac5358 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Testlist changes ==

-igt@kms_cdclk@basic

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#2 lore raw

Re: [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_cdclk: Drop basic subtest

The regression is not linked to the patch submitted. Merging.

Thanks and Regards,
Swati

From: Patchwork <[email protected]>
Sent: Monday, July 5, 2021 8:11 PM
To: Sharma, Swati2 <[email protected]>
Cc: [email protected]
Subject: ✗ Fi.CI.BAT: failure for tests/kms_cdclk: Drop basic subtest

Patch Details
Series:

tests/kms_cdclk: Drop basic subtest

URL:

https://patchwork.freedesktop.org/series/92211/

State:

failure

Details:

https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/index.html

CI Bug Log - changes from CI_DRM_10305 -> IGTPW_5981 Summary

FAILURE

Serious unknown changes coming with IGTPW_5981 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_5981, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/index.html

Possible new issues

Here are the unknown changes that may have been introduced in IGTPW_5981:

IGT changes
Possible regressions

* igt@gem_exec_parallel@engines@basic:
* fi-icl-y: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-icl-y/igt@gem_exec_parallel@[email protected]> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-icl-y/igt@gem_exec_parallel@[email protected]>

Suppressed

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@i915_module_load@reload:
* {fi-tgl-1115g4}: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-tgl-1115g4/igt@[email protected]>

Known issues

Here are the changes found in IGTPW_5981 that come from known issues:

IGT changes
Issues hit

* igt@amdgpu/amd_basic@memory-alloc:
* fi-cml-u2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cml-u2/igt@amdgpu/[email protected]> (fdo#109315<https://bugs.freedesktop.org/show_bug.cgi?id=109315>) +17 similar issues
* igt@amdgpu/amd_basic@semaphore:
* fi-bsw-nick: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bsw-nick/igt@amdgpu/[email protected]> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +17 similar issues
* fi-bdw-5557u: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bdw-5557u/igt@amdgpu/[email protected]> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +27 similar issues
* igt@amdgpu/amd_prime@i915-to-amd:
* fi-snb-2520m: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-snb-2520m/igt@amdgpu/[email protected]> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +33 similar issues
* igt@core_hotunplug@unbind-rebind:
* fi-hsw-4770: NOTRUN -> WARN<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]> (i915#3718<https://gitlab.freedesktop.org/drm/intel/issues/3718>)
* fi-bdw-5557u: NOTRUN -> WARN<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bdw-5557u/igt@[email protected]> (i915#3718<https://gitlab.freedesktop.org/drm/intel/issues/3718>)
* igt@gem_exec_fence@basic-busy@bcs0:
* fi-apl-guc: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-apl-guc/igt@gem_exec_fence@[email protected]> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +1 similar issue
* igt@gem_exec_parallel@engines@basic:
* fi-bxt-dsi: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-bxt-dsi/igt@gem_exec_parallel@[email protected]> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bxt-dsi/igt@gem_exec_parallel@[email protected]> (i915#1610<https://gitlab.freedesktop.org/drm/intel/issues/1610>)
* fi-apl-guc: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-apl-guc/igt@gem_exec_parallel@[email protected]> (i915#1610<https://gitlab.freedesktop.org/drm/intel/issues/1610>)
* igt@gem_exec_parallel@engines@userptr:
* fi-cfl-8109u: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-cfl-8109u/igt@gem_exec_parallel@[email protected]> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cfl-8109u/igt@gem_exec_parallel@[email protected]> (i915#1610<https://gitlab.freedesktop.org/drm/intel/issues/1610>)
* fi-glk-dsi: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-glk-dsi/igt@gem_exec_parallel@[email protected]> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-glk-dsi/igt@gem_exec_parallel@[email protected]> (i915#1610<https://gitlab.freedesktop.org/drm/intel/issues/1610>)
* igt@gem_huc_copy@huc-copy:
* fi-hsw-4770: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +4 similar issues
* fi-kbl-8809g: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-kbl-8809g/igt@[email protected]> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#2190<https://gitlab.freedesktop.org/drm/intel/issues/2190>)
* igt@i915_pm_backlight@basic-brightness:
* fi-hsw-4770: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#3012<https://gitlab.freedesktop.org/drm/intel/issues/3012>)
* igt@i915_selftest@live@active:
* fi-hsw-4770: NOTRUN -> DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@i915_selftest@[email protected]> (i915#2927<https://gitlab.freedesktop.org/drm/intel/issues/2927>)
* igt@kms_chamelium@common-hpd-after-suspend:
* fi-hsw-4770: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +8 similar issues
* igt@kms_chamelium@dp-crc-fast:
* fi-bdw-5557u: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bdw-5557u/igt@[email protected]> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +8 similar issues
* igt@kms_chamelium@dp-hpd-fast:
* fi-cml-u2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cml-u2/igt@[email protected]> (fdo#109284<https://bugs.freedesktop.org/show_bug.cgi?id=109284> / fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +8 similar issues
* igt@kms_chamelium@hdmi-edid-read:
* fi-kbl-8809g: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-kbl-8809g/igt@[email protected]> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +8 similar issues
* igt@kms_chamelium@hdmi-hpd-fast:
* fi-snb-2520m: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-snb-2520m/igt@[email protected]> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +8 similar issues
* igt@kms_force_connector_basic@force-load-detect:
* fi-cml-u2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cml-u2/igt@[email protected]> (fdo#109285<https://bugs.freedesktop.org/show_bug.cgi?id=109285>)
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:

     *   fi-hsw-4770: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#533<https://gitlab.freedesktop.org/drm/intel/issues/533>)
     *   fi-cml-u2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cml-u2/igt@[email protected]> (fdo#109278<https://bugs.freedesktop.org/show_bug.cgi?id=109278> / i915#533<https://gitlab.freedesktop.org/drm/intel/issues/533>)
     *   fi-kbl-8809g: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-kbl-8809g/igt@[email protected]> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#533<https://gitlab.freedesktop.org/drm/intel/issues/533>)
  *   igt@kms_psr@cursor_plane_move:
     *   fi-kbl-8809g: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-kbl-8809g/igt@kms_psr@cursor_plane_move.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +37 similar issues
  *   igt@kms_psr@primary_mmap_gtt:
     *   fi-hsw-4770: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@kms_psr@primary_mmap_gtt.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#1072<https://gitlab.freedesktop.org/drm/intel/issues/1072>) +3 similar issues
  *   igt@prime_vgem@basic-userptr:
     *   fi-cml-u2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cml-u2/igt@[email protected]> (i915#3301<https://gitlab.freedesktop.org/drm/intel/issues/3301>)
  *   igt@runner@aborted:
     *   fi-cfl-8109u: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cfl-8109u/igt@[email protected]> (i915#2426<https://gitlab.freedesktop.org/drm/intel/issues/2426> / i915#3363<https://gitlab.freedesktop.org/drm/intel/issues/3363> / i915#3364<https://gitlab.freedesktop.org/drm/intel/issues/3364>)
     *   fi-apl-guc: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-apl-guc/igt@[email protected]> (i915#2426<https://gitlab.freedesktop.org/drm/intel/issues/2426> / i915#3363<https://gitlab.freedesktop.org/drm/intel/issues/3363> / i915#3364<https://gitlab.freedesktop.org/drm/intel/issues/3364> / i915#337<https://gitlab.freedesktop.org/drm/intel/issues/337>)
     *   fi-bxt-dsi: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bxt-dsi/igt@[email protected]> (i915#2426<https://gitlab.freedesktop.org/drm/intel/issues/2426> / i915#3363<https://gitlab.freedesktop.org/drm/intel/issues/3363> / i915#3364<https://gitlab.freedesktop.org/drm/intel/issues/3364>)

Possible fixes

* igt@gem_exec_parallel@engines@basic:
* fi-glk-dsi: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-glk-dsi/igt@gem_exec_parallel@[email protected]> (i915#1610<https://gitlab.freedesktop.org/drm/intel/issues/1610>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-glk-dsi/igt@gem_exec_parallel@[email protected]>
* igt@gem_exec_parallel@engines@contexts:
* fi-snb-2520m: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-snb-2520m/igt@gem_exec_parallel@[email protected]> -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-snb-2520m/igt@gem_exec_parallel@[email protected]>
* igt@gem_exec_parallel@engines@userptr:
* fi-icl-y: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-icl-y/igt@gem_exec_parallel@[email protected]> -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-icl-y/igt@gem_exec_parallel@[email protected]>
* igt@gem_exec_suspend@basic-s3:
* fi-hsw-4770: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-hsw-4770/igt@[email protected]> -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]>
* igt@gem_sync@basic-each:
* fi-cml-u2: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-cml-u2/igt@[email protected]> (i915#1610<https://gitlab.freedesktop.org/drm/intel/issues/1610>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cml-u2/igt@[email protected]>
* igt@i915_selftest@live@execlists:
* fi-bsw-nick: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-bsw-nick/igt@i915_selftest@[email protected]> (i915#2782<https://gitlab.freedesktop.org/drm/intel/issues/2782> / i915#2940<https://gitlab.freedesktop.org/drm/intel/issues/2940>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bsw-nick/igt@i915_selftest@[email protected]>
* igt@kms_flip@basic-flip-vs-dpms@b-dp3:
* {fi-tgl-1115g4}: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-tgl-1115g4/igt@kms_flip@[email protected]> -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-tgl-1115g4/igt@kms_flip@[email protected]>

Warnings

* igt@runner@aborted:
* fi-hsw-4770: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-hsw-4770/igt@[email protected]> (i915#2505<https://gitlab.freedesktop.org/drm/intel/issues/2505>) -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#1436<https://gitlab.freedesktop.org/drm/intel/issues/1436> / i915#2505<https://gitlab.freedesktop.org/drm/intel/issues/2505>)

{name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (32 -> 28)

Additional (1): fi-apl-guc
Missing (5): fi-kbl-soraka fi-hsw-4200u fi-kbl-7500u fi-pnv-d510 fi-bdw-samus

Build changes

* CI: CI-20190529 -> None
* IGT: IGT_6128 -> IGTPW_5981

CI-20190529: 20190529
CI_DRM_10305: fd899b57cb480c98e60ee842671bddd4759dfca3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5981: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/index.html
IGT_6128: b24e5949af7e51f0af484d2ce4cb4c5a41ac5358 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Testlist changes ==

-igt@kms_cdclk@basic

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Acked-by on v1 1/1
#3 lore raw
In reply to Swati Sharma
Quoted 102 lines

-----Original Message-----
From: Sharma, Swati2 <[email protected]>
Sent: Monday, July 5, 2021 7:48 PM
To: [email protected]
Cc: Sharma, Swati2 <[email protected]>; Shankar, Uma <[email protected]>
Subject: [PATCH i-g-t] tests/kms_cdclk: Drop basic subtest

This drops basic subtest since use case is already getting covered by mode transition subtest.

---
 tests/kms_cdclk.c | 61 +++++------------------------------------------
 1 file changed, 6 insertions(+), 55 deletions(-)
tests/kms_cdclk.c +3 -4
@@ -26,7 +26,7 @@
 
 #include "igt.h"
 
-IGT_TEST_DESCRIPTION("Test cdclk features : squasher and crawling");
+IGT_TEST_DESCRIPTION("Test cdclk features : crawling");
 
 #define HDISPLAY_4K     3840
 #define VDISPLAY_4K     2160
@@ -34,9 +34,8 @@ IGT_TEST_DESCRIPTION("Test cdclk features : squasher and
 crawling");
 
 /* Test flags */
 enum {
-	TEST_BASIC = 1 << 0,
-	TEST_PLANESCALING = 1 << 1,
-	TEST_MODETRANSITION = 1 << 2,
+	TEST_PLANESCALING = 1 << 0,
+	TEST_MODETRANSITION = 1 << 1,
 };
 

typedef struct {

tests/kms_cdclk.c +0 -38
@@ -132,45 +131,6 @@ static void do_cleanup_display(igt_display_t *dpy)
 	igt_display_commit2(dpy, dpy->is_atomic ? COMMIT_ATOMIC :
 COMMIT_LEGACY);  }
 
-static void test_basic(data_t *data, enum pipe pipe, igt_output_t *output) -{
-	igt_display_t *display = &data->display;
-	int debugfs_fd = data->debugfs_fd;
-	int cdclk_ref, cdclk_new;
-	struct igt_fb fb;
-	igt_plane_t *primary;
-	drmModeModeInfo *mode;
-
-	do_cleanup_display(display);
-	igt_display_reset(display);
-
-	igt_output_set_pipe(output, pipe);
-	mode = get_highres_mode(output);
-	igt_require(mode != NULL);
-	igt_output_override_mode(output, mode);
-
-	primary = igt_output_get_plane_type(output,
 DRM_PLANE_TYPE_PRIMARY);
-
-	igt_create_color_pattern_fb(display->drm_fd,
-				    mode->hdisplay, mode->vdisplay,
-				    DRM_FORMAT_XRGB8888,
-				    I915_TILING_NONE,
-				    0.0, 0.0, 0.0, &fb);
-
-	igt_plane_set_fb(primary, &fb);
-	cdclk_ref = get_current_cdclk_freq(debugfs_fd);
-	igt_display_commit_atomic(display,
 DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
-	cdclk_new = get_current_cdclk_freq(debugfs_fd);
-	igt_info("CD clock frequency %d -> %d\n", cdclk_ref, cdclk_new);
-
-	/* cdclk should bump */
-	igt_assert_lt(cdclk_ref, cdclk_new);
-
-	/* cleanup */
-	do_cleanup_display(display);
-	igt_remove_fb(display->drm_fd, &fb);
-}
-
 static void test_plane_scaling(data_t *data, enum pipe pipe, igt_output_t *output)

{
igt_display_t *display = &data->display; @@ -284,8 +244,6 @@ static void
run_cdclk_test(data_t *data, uint32_t flags)

tests/kms_cdclk.c +0 -0
 	for_each_pipe_with_valid_output(display, pipe, output) {
 		igt_dynamic_f("%s-pipe-%s", output->name,

kmstest_pipe_name(pipe))

tests/kms_cdclk.c +0 -2
 			if (igt_pipe_connector_valid(pipe, output)) {
-				if (flags & TEST_BASIC)
-					test_basic(data, pipe, output);
 				if (flags & TEST_PLANESCALING)
 					test_plane_scaling(data, pipe, output);
 				if (flags & TEST_MODETRANSITION)

tests/kms_cdclk.c igt_main · line 267

Quoted 6 lines
tests/kms_cdclk.c +1 -2
@@ -306,22 +264,15 @@ igt_main
 		kmstest_set_vt_graphics_mode();
 		data.devid = intel_get_drm_devid(data.drm_fd);
 		igt_require_f(hardware_supported(&data),
-			      "Hardware doesn't support either squashing "\
-			      "or crawling.\n");
+			      "Hardware doesn't support crawling.\n");

We can still use both, whether to use squashing or crawling depends if a PLL ratio is required or not. So let this test cover both crawling and squashing.

With that fixed.

Quoted 22 lines
tests/kms_cdclk.c +3 -9
 		igt_display_require(&data.display, data.drm_fd);
 		igt_display_require_output(&data.display);
 	}
 
-	igt_describe("Basic test to validate cdclk frequency change w/o "\
-		     "requiring full modeset.");
-	igt_subtest_with_dynamic("basic")
-		run_cdclk_test(&data, TEST_BASIC);
-	igt_describe("Plane scaling test to validate cdclk frequency change w/o "\
-		     "requiring full modeset.");
+	igt_describe("Plane scaling test to validate cdclk frequency change");
 	igt_subtest_with_dynamic("plane-scaling")
 		run_cdclk_test(&data, TEST_PLANESCALING);
-	igt_describe("Mode transition (low to high) test to validate cdclk frequency
 "\
-		     "change w/o requiring full modeset.");
+	igt_describe("Mode transition (low to high) test to validate cdclk
+frequency change");
 	igt_subtest_with_dynamic("mode-transition")
 		run_cdclk_test(&data, TEST_MODETRANSITION);
 
--
Quoted 1 line

2.25.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by
#4 lore raw
Quoted 122 lines

-----Original Message-----
From: Shankar, Uma
Sent: Monday, July 5, 2021 8:26 PM
To: Sharma, Swati2 <[email protected]>; [email protected]
Subject: RE: [PATCH i-g-t] tests/kms_cdclk: Drop basic subtest

Quoted 102 lines

-----Original Message-----
From: Sharma, Swati2 <[email protected]>
Sent: Monday, July 5, 2021 7:48 PM
To: [email protected]
Cc: Sharma, Swati2 <[email protected]>; Shankar, Uma <[email protected]>
Subject: [PATCH i-g-t] tests/kms_cdclk: Drop basic subtest

This drops basic subtest since use case is already getting covered by mode transition subtest.

---
 tests/kms_cdclk.c | 61
+++++------------------------------------------
 1 file changed, 6 insertions(+), 55 deletions(-)
tests/kms_cdclk.c index renamed from tests/kms_cdclk.c +0 -0

b2e32d25..d2a9fa5f 100644

tests/kms_cdclk.c +3 -4
@@ -26,7 +26,7 @@
 
 #include "igt.h"
 
-IGT_TEST_DESCRIPTION("Test cdclk features : squasher and crawling");
+IGT_TEST_DESCRIPTION("Test cdclk features : crawling");
 
 #define HDISPLAY_4K     3840
 #define VDISPLAY_4K     2160
@@ -34,9 +34,8 @@ IGT_TEST_DESCRIPTION("Test cdclk features : squasher
 and crawling");
 
 /* Test flags */
 enum {
-	TEST_BASIC = 1 << 0,
-	TEST_PLANESCALING = 1 << 1,
-	TEST_MODETRANSITION = 1 << 2,
+	TEST_PLANESCALING = 1 << 0,
+	TEST_MODETRANSITION = 1 << 1,
 };
 

typedef struct {

tests/kms_cdclk.c +0 -38
@@ -132,45 +131,6 @@ static void do_cleanup_display(igt_display_t *dpy)
 	igt_display_commit2(dpy, dpy->is_atomic ? COMMIT_ATOMIC :
 COMMIT_LEGACY);  }
 
-static void test_basic(data_t *data, enum pipe pipe, igt_output_t *output) -{
-	igt_display_t *display = &data->display;
-	int debugfs_fd = data->debugfs_fd;
-	int cdclk_ref, cdclk_new;
-	struct igt_fb fb;
-	igt_plane_t *primary;
-	drmModeModeInfo *mode;
-
-	do_cleanup_display(display);
-	igt_display_reset(display);
-
-	igt_output_set_pipe(output, pipe);
-	mode = get_highres_mode(output);
-	igt_require(mode != NULL);
-	igt_output_override_mode(output, mode);
-
-	primary = igt_output_get_plane_type(output,
 DRM_PLANE_TYPE_PRIMARY);
-
-	igt_create_color_pattern_fb(display->drm_fd,
-				    mode->hdisplay, mode->vdisplay,
-				    DRM_FORMAT_XRGB8888,
-				    I915_TILING_NONE,
-				    0.0, 0.0, 0.0, &fb);
-
-	igt_plane_set_fb(primary, &fb);
-	cdclk_ref = get_current_cdclk_freq(debugfs_fd);
-	igt_display_commit_atomic(display,
 DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
-	cdclk_new = get_current_cdclk_freq(debugfs_fd);
-	igt_info("CD clock frequency %d -> %d\n", cdclk_ref, cdclk_new);
-
-	/* cdclk should bump */
-	igt_assert_lt(cdclk_ref, cdclk_new);
-
-	/* cleanup */
-	do_cleanup_display(display);
-	igt_remove_fb(display->drm_fd, &fb);
-}
-
 static void test_plane_scaling(data_t *data, enum pipe pipe,

igt_output_t *output) {
igt_display_t *display = &data->display; @@ -284,8 +244,6 @@ static
void run_cdclk_test(data_t *data, uint32_t flags)

tests/kms_cdclk.c +0 -0
 	for_each_pipe_with_valid_output(display, pipe, output) {
 		igt_dynamic_f("%s-pipe-%s", output->name,

kmstest_pipe_name(pipe))

tests/kms_cdclk.c +0 -2
 			if (igt_pipe_connector_valid(pipe, output)) {
-				if (flags & TEST_BASIC)
-					test_basic(data, pipe, output);
 				if (flags & TEST_PLANESCALING)
 					test_plane_scaling(data, pipe, output);
 				if (flags & TEST_MODETRANSITION)

tests/kms_cdclk.c igt_main · line 267

Quoted 6 lines
tests/kms_cdclk.c +1 -2
@@ -306,22 +264,15 @@ igt_main
 		kmstest_set_vt_graphics_mode();
 		data.devid = intel_get_drm_devid(data.drm_fd);
 		igt_require_f(hardware_supported(&data),
-			      "Hardware doesn't support either squashing "\
-			      "or crawling.\n");
+			      "Hardware doesn't support crawling.\n");

We can still use both, whether to use squashing or crawling depends if a PLL ratio is required or not. So let this test cover both crawling and squashing.

Quoted 2 lines

With that fixed.

You also have my:

Quoted 23 lines
Quoted 23 lines
tests/kms_cdclk.c +4 -8
 		igt_display_require(&data.display, data.drm_fd);
 		igt_display_require_output(&data.display);
 	}
 
-	igt_describe("Basic test to validate cdclk frequency change w/o "\
-		     "requiring full modeset.");
-	igt_subtest_with_dynamic("basic")
-		run_cdclk_test(&data, TEST_BASIC);
-	igt_describe("Plane scaling test to validate cdclk frequency change w/o "\
-		     "requiring full modeset.");
+	igt_describe("Plane scaling test to validate cdclk frequency
+change");
 	igt_subtest_with_dynamic("plane-scaling")
 		run_cdclk_test(&data, TEST_PLANESCALING);
-	igt_describe("Mode transition (low to high) test to validate cdclk frequency
 "\
-		     "change w/o requiring full modeset.");
+	igt_describe("Mode transition (low to high) test to validate cdclk
+frequency change");
 	igt_subtest_with_dynamic("mode-transition")
 		run_cdclk_test(&data, TEST_MODETRANSITION);
Quoted 2 lines
Quoted 2 lines

--
2.25.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#5 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_cdclk: Drop basic subtest

In reply to Swati Sharma
== Series Details ==

== Series Details ==

Series: tests/kms_cdclk: Drop basic subtest
URL : https://patchwork.freedesktop.org/series/92211/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10305 -> IGTPW_5981
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_5981 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_5981, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_5981:

### IGT changes ###

#### Possible regressions ####

* igt@gem_exec_parallel@engines@basic:
- fi-icl-y: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-icl-y/igt@gem_exec_parallel@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-icl-y/igt@gem_exec_parallel@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@i915_module_load@reload:
- {fi-tgl-1115g4}: NOTRUN -> [DMESG-WARN][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-tgl-1115g4/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_5981 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@memory-alloc:
- fi-cml-u2: NOTRUN -> [SKIP][4] ([fdo#109315]) +17 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cml-u2/igt@amdgpu/[email protected]

* igt@amdgpu/amd_basic@semaphore:
- fi-bsw-nick: NOTRUN -> [SKIP][5] ([fdo#109271]) +17 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bsw-nick/igt@amdgpu/[email protected]
- fi-bdw-5557u: NOTRUN -> [SKIP][6] ([fdo#109271]) +27 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bdw-5557u/igt@amdgpu/[email protected]

* igt@amdgpu/amd_prime@i915-to-amd:
- fi-snb-2520m: NOTRUN -> [SKIP][7] ([fdo#109271]) +33 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-snb-2520m/igt@amdgpu/[email protected]

* igt@core_hotunplug@unbind-rebind:
- fi-hsw-4770: NOTRUN -> [WARN][8] ([i915#3718])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]
- fi-bdw-5557u: NOTRUN -> [WARN][9] ([i915#3718])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bdw-5557u/igt@[email protected]

* igt@gem_exec_fence@basic-busy@bcs0:
- fi-apl-guc: NOTRUN -> [SKIP][10] ([fdo#109271]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-apl-guc/igt@gem_exec_fence@[email protected]

* igt@gem_exec_parallel@engines@basic:
- fi-bxt-dsi: [PASS][11] -> [DMESG-WARN][12] ([i915#1610])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-bxt-dsi/igt@gem_exec_parallel@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bxt-dsi/igt@gem_exec_parallel@[email protected]
- fi-apl-guc: NOTRUN -> [DMESG-WARN][13] ([i915#1610])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-apl-guc/igt@gem_exec_parallel@[email protected]

* igt@gem_exec_parallel@engines@userptr:
- fi-cfl-8109u: [PASS][14] -> [DMESG-WARN][15] ([i915#1610])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-cfl-8109u/igt@gem_exec_parallel@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cfl-8109u/igt@gem_exec_parallel@[email protected]
- fi-glk-dsi: [PASS][16] -> [DMESG-WARN][17] ([i915#1610])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-glk-dsi/igt@gem_exec_parallel@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-glk-dsi/igt@gem_exec_parallel@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-hsw-4770: NOTRUN -> [SKIP][18] ([fdo#109271]) +4 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]
- fi-kbl-8809g: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#2190])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-kbl-8809g/igt@[email protected]

* igt@i915_pm_backlight@basic-brightness:
- fi-hsw-4770: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#3012])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]

* igt@i915_selftest@live@active:
- fi-hsw-4770: NOTRUN -> [DMESG-FAIL][21] ([i915#2927])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@i915_selftest@[email protected]

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-4770: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111827]) +8 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]

* igt@kms_chamelium@dp-crc-fast:
- fi-bdw-5557u: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111827]) +8 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bdw-5557u/igt@[email protected]

* igt@kms_chamelium@dp-hpd-fast:
- fi-cml-u2: NOTRUN -> [SKIP][24] ([fdo#109284] / [fdo#111827]) +8 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cml-u2/igt@[email protected]

* igt@kms_chamelium@hdmi-edid-read:
- fi-kbl-8809g: NOTRUN -> [SKIP][25] ([fdo#109271] / [fdo#111827]) +8 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-kbl-8809g/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-snb-2520m: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +8 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-snb-2520m/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-cml-u2: NOTRUN -> [SKIP][27] ([fdo#109285])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cml-u2/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-hsw-4770: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#533])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]
- fi-cml-u2: NOTRUN -> [SKIP][29] ([fdo#109278] / [i915#533])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cml-u2/igt@[email protected]
- fi-kbl-8809g: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#533])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-kbl-8809g/igt@[email protected]

* igt@kms_psr@cursor_plane_move:
- fi-kbl-8809g: NOTRUN -> [SKIP][31] ([fdo#109271]) +37 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-kbl-8809g/igt@kms_psr@cursor_plane_move.html

* igt@kms_psr@primary_mmap_gtt:
- fi-hsw-4770: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#1072]) +3 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@kms_psr@primary_mmap_gtt.html

* igt@prime_vgem@basic-userptr:
- fi-cml-u2: NOTRUN -> [SKIP][33] ([i915#3301])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cml-u2/igt@[email protected]

* igt@runner@aborted:
- fi-cfl-8109u: NOTRUN -> [FAIL][34] ([i915#2426] / [i915#3363] / [i915#3364])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cfl-8109u/igt@[email protected]
- fi-apl-guc: NOTRUN -> [FAIL][35] ([i915#2426] / [i915#3363] / [i915#3364] / [i915#337])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-apl-guc/igt@[email protected]
- fi-bxt-dsi: NOTRUN -> [FAIL][36] ([i915#2426] / [i915#3363] / [i915#3364])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bxt-dsi/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_parallel@engines@basic:
- fi-glk-dsi: [DMESG-WARN][37] ([i915#1610]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-glk-dsi/igt@gem_exec_parallel@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-glk-dsi/igt@gem_exec_parallel@[email protected]

* igt@gem_exec_parallel@engines@contexts:
- fi-snb-2520m: [DMESG-WARN][39] -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-snb-2520m/igt@gem_exec_parallel@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-snb-2520m/igt@gem_exec_parallel@[email protected]

* igt@gem_exec_parallel@engines@userptr:
- fi-icl-y: [DMESG-WARN][41] -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-icl-y/igt@gem_exec_parallel@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-icl-y/igt@gem_exec_parallel@[email protected]

* igt@gem_exec_suspend@basic-s3:
- fi-hsw-4770: [DMESG-WARN][43] -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-hsw-4770/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]

* igt@gem_sync@basic-each:
- fi-cml-u2: [DMESG-WARN][45] ([i915#1610]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-cml-u2/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-cml-u2/igt@[email protected]

* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [INCOMPLETE][47] ([i915#2782] / [i915#2940]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-bsw-nick/igt@i915_selftest@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-bsw-nick/igt@i915_selftest@[email protected]

* igt@kms_flip@basic-flip-vs-dpms@b-dp3:
- {fi-tgl-1115g4}: [DMESG-WARN][49] -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-tgl-1115g4/igt@kms_flip@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-tgl-1115g4/igt@kms_flip@[email protected]

#### Warnings ####

* igt@runner@aborted:
- fi-hsw-4770: [FAIL][51] ([i915#2505]) -> [FAIL][52] ([fdo#109271] / [i915#1436] / [i915#2505])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10305/fi-hsw-4770/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/fi-hsw-4770/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2292]: https://gitlab.freedesktop.org/drm/intel/issues/2292
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3364]: https://gitlab.freedesktop.org/drm/intel/issues/3364
[i915#337]: https://gitlab.freedesktop.org/drm/intel/issues/337
[i915#3690]: https://gitlab.freedesktop.org/drm/intel/issues/3690
[i915#3717]: https://gitlab.freedesktop.org/drm/intel/issues/3717
[i915#3718]: https://gitlab.freedesktop.org/drm/intel/issues/3718
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[k.org#204565]: https://bugzilla.kernel.org/show_bug.cgi?id=204565

Participating hosts (32 -> 28)
------------------------------

Additional (1): fi-apl-guc
Missing (5): fi-kbl-soraka fi-hsw-4200u fi-kbl-7500u fi-pnv-d510 fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6128 -> IGTPW_5981

CI-20190529: 20190529
CI_DRM_10305: fd899b57cb480c98e60ee842671bddd4759dfca3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5981: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/index.html
IGT_6128: b24e5949af7e51f0af484d2ce4cb4c5a41ac5358 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Testlist changes ==

-igt@kms_cdclk@basic

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5981/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev