arm64: dts: meson-sm1: add spdifin spdifout nodes
Subsystems (2)
PATCH 1/1 arm64: dts: meson-sm1: add spdifin spdifout nodes
Add spdifin spdifout spdifout_b nodes for Amlogic SM1 SoCs.
--- arch/arm64/boot/dts/amlogic/meson-sm1.dtsi | 40 ++++++++++++++++++++++ 1 file changed, 40 insertions(+)
arch/arm64/boot/dts/amlogic/meson-sm1.dtsi +40 -0
@@ -356,6 +356,33 @@ tdmin_lb: audio-controller@3c0 { status = "disabled"; }; + spdifin: audio-controller@400 { + compatible = "amlogic,g12a-spdifin", + "amlogic,axg-spdifin"; + reg = <0x0 0x400 0x0 0x30>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFIN"; + interrupts = <GIC_SPI 151 IRQ_TYPE_EDGE_RISING>; + clocks = <&clkc_audio AUD_CLKID_SPDIFIN>, + <&clkc_audio AUD_CLKID_SPDIFIN_CLK>; + clock-names = "pclk", "refclk"; + resets = <&clkc_audio AUD_RESET_SPDIFIN>; + status = "disabled"; + }; + + spdifout: audio-controller@480 { + compatible = "amlogic,g12a-spdifout", + "amlogic,axg-spdifout"; + reg = <0x0 0x480 0x0 0x50>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFOUT"; + clocks = <&clkc_audio AUD_CLKID_SPDIFOUT>, + <&clkc_audio AUD_CLKID_SPDIFOUT_CLK>; + clock-names = "pclk", "mclk"; + resets = <&clkc_audio AUD_RESET_SPDIFOUT>; + status = "disabled"; + }; + tdmout_a: audio-controller@500 { compatible = "amlogic,sm1-tdmout"; reg = <0x0 0x500 0x0 0x40>;
@@ -401,6 +428,19 @@ tdmout_c: audio-controller@580 { status = "disabled"; }; + spdifout_b: audio-controller@680 { + compatible = "amlogic,g12a-spdifout", + "amlogic,axg-spdifout"; + reg = <0x0 0x680 0x0 0x50>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFOUT_B"; + clocks = <&clkc_audio AUD_CLKID_SPDIFOUT_B>, + <&clkc_audio AUD_CLKID_SPDIFOUT_B_CLK>; + clock-names = "pclk", "mclk"; + resets = <&clkc_audio AUD_RESET_SPDIFOUT_B>; + status = "disabled"; + }; + toacodec: audio-controller@740 { compatible = "amlogic,sm1-toacodec", "amlogic,g12a-toacodec";
Signature · 1 line
2.25.1
Hi,
Quoted 56 lines · Artem Lapkin
Add spdifin spdifout
spdifout_bnodes for Amlogic SM1 SoCs.Signed-off-by Artem Lapkin <[email protected]>--- arch/arm64/boot/dts/amlogic/meson-sm1.dtsi | 40 ++++++++++++++++++++++ 1 file changed, 40 insertions(+)arch/arm64/boot/dts/amlogic/meson-sm1.dtsi +33
-0@@ -356,6 +356,33 @@ tdmin_lb: audio-controller@3c0 { status = "disabled"; }; + spdifin: audio-controller@400 { + compatible = "amlogic,g12a-spdifin", + "amlogic,axg-spdifin"; + reg = <0x0 0x400 0x0 0x30>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFIN"; + interrupts = <GIC_SPI 151 IRQ_TYPE_EDGE_RISING>; + clocks = <&clkc_audio AUD_CLKID_SPDIFIN>, + <&clkc_audio AUD_CLKID_SPDIFIN_CLK>; + clock-names = "pclk", "refclk"; + resets = <&clkc_audio AUD_RESET_SPDIFIN>; + status = "disabled"; + }; + + spdifout: audio-controller@480 { + compatible = "amlogic,g12a-spdifout", + "amlogic,axg-spdifout"; + reg = <0x0 0x480 0x0 0x50>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFOUT"; + clocks = <&clkc_audio AUD_CLKID_SPDIFOUT>, + <&clkc_audio AUD_CLKID_SPDIFOUT_CLK>; + clock-names = "pclk", "mclk"; + resets = <&clkc_audio AUD_RESET_SPDIFOUT>; + status = "disabled"; + }; + tdmout_a: audio-controller@500 { compatible = "amlogic,sm1-tdmout"; reg = <0x0 0x500 0x0 0x40>;@@ -401,6 +428,19 @@ tdmout_c: audio-controller@580 { status = "disabled"; }; + spdifout_b: audio-controller@680 { + compatible = "amlogic,g12a-spdifout", + "amlogic,axg-spdifout"; + reg = <0x0 0x680 0x0 0x50>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFOUT_B";
arch/arm64/boot/dts/amlogic/meson-sm1.dtsi tdmout_c: audio-controller@580 { · line 446
Quoted 10 lines
arch/arm64/boot/dts/amlogic/meson-sm1.dtsi +7
-0+ clocks = <&clkc_audio AUD_CLKID_SPDIFOUT_B>, + <&clkc_audio AUD_CLKID_SPDIFOUT_B_CLK>; + clock-names = "pclk", "mclk"; + resets = <&clkc_audio AUD_RESET_SPDIFOUT_B>; + status = "disabled"; + }; + toacodec: audio-controller@740 { compatible = "amlogic,sm1-toacodec", "amlogic,g12a-toacodec";
Jerome could you quickly review this ?
Thanks,
Neil
Jerome Brunet
reviewerQuoted 63 lines · Neil Armstrong
Hi,
Quoted 60 lines · Artem Lapkin
Add spdifin spdifout
spdifout_bnodes for Amlogic SM1 SoCs.Signed-off-by Artem Lapkin <[email protected]>--- arch/arm64/boot/dts/amlogic/meson-sm1.dtsi | 40 ++++++++++++++++++++++ 1 file changed, 40 insertions(+)arch/arm64/boot/dts/amlogic/meson-sm1.dtsi +38
-0@@ -356,6 +356,33 @@ tdmin_lb: audio-controller@3c0 { status = "disabled"; }; + spdifin: audio-controller@400 { + compatible = "amlogic,g12a-spdifin", + "amlogic,axg-spdifin"; + reg = <0x0 0x400 0x0 0x30>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFIN"; + interrupts = <GIC_SPI 151 IRQ_TYPE_EDGE_RISING>; + clocks = <&clkc_audio AUD_CLKID_SPDIFIN>, + <&clkc_audio AUD_CLKID_SPDIFIN_CLK>; + clock-names = "pclk", "refclk"; + resets = <&clkc_audio AUD_RESET_SPDIFIN>; + status = "disabled"; + }; + + spdifout: audio-controller@480 { + compatible = "amlogic,g12a-spdifout", + "amlogic,axg-spdifout"; + reg = <0x0 0x480 0x0 0x50>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFOUT"; + clocks = <&clkc_audio AUD_CLKID_SPDIFOUT>, + <&clkc_audio AUD_CLKID_SPDIFOUT_CLK>; + clock-names = "pclk", "mclk"; + resets = <&clkc_audio AUD_RESET_SPDIFOUT>; + status = "disabled"; + }; + tdmout_a: audio-controller@500 { compatible = "amlogic,sm1-tdmout"; reg = <0x0 0x500 0x0 0x40>;@@ -401,6 +428,19 @@ tdmout_c: audio-controller@580 { status = "disabled"; }; + spdifout_b: audio-controller@680 { + compatible = "amlogic,g12a-spdifout", + "amlogic,axg-spdifout"; + reg = <0x0 0x680 0x0 0x50>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFOUT_B"; + clocks = <&clkc_audio AUD_CLKID_SPDIFOUT_B>, + <&clkc_audio AUD_CLKID_SPDIFOUT_B_CLK>; + clock-names = "pclk", "mclk"; + resets = <&clkc_audio AUD_RESET_SPDIFOUT_B>; + status = "disabled";
Quoted 9 lines
arch/arm64/boot/dts/amlogic/meson-sm1.dtsi tdmout_c: audio-controller@580 { · line 446
Quoted 6 lines
arch/arm64/boot/dts/amlogic/meson-sm1.dtsi +2
-0+ }; + toacodec: audio-controller@740 { compatible = "amlogic,sm1-toacodec", "amlogic,g12a-toacodec";Jerome could you quickly review this ?
Just this, without the related card change is not usefull as it won't be part of the card.
It would be nice to indicate how it was tested ?
AFAIK:
- spdifout b can only be routed to hdmi and dw-hdmi driver does not support that yet
- the VIM3 does not have connectors for the spdif (in or out). If it requires some extension card, it should be noted somewhere, at least
Quoted 2 lines
Thanks,
Neil
Quoted 1 line
It would be nice to indicate how it was tested ?
i have test it
i2s and spdif output from gpio headers - works well
Quoted 92 lines · Jerome Brunet
Quoted 63 lines · Neil Armstrong
Hi,
Quoted 60 lines · Artem Lapkin
Add spdifin spdifout
spdifout_bnodes for Amlogic SM1 SoCs.Signed-off-by Artem Lapkin <[email protected]>--- arch/arm64/boot/dts/amlogic/meson-sm1.dtsi | 40 ++++++++++++++++++++++ 1 file changed, 40 insertions(+)arch/arm64/boot/dts/amlogic/meson-sm1.dtsi +38
-0@@ -356,6 +356,33 @@ tdmin_lb: audio-controller@3c0 { status = "disabled"; }; + spdifin: audio-controller@400 { + compatible = "amlogic,g12a-spdifin", + "amlogic,axg-spdifin"; + reg = <0x0 0x400 0x0 0x30>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFIN"; + interrupts = <GIC_SPI 151 IRQ_TYPE_EDGE_RISING>; + clocks = <&clkc_audio AUD_CLKID_SPDIFIN>, + <&clkc_audio AUD_CLKID_SPDIFIN_CLK>; + clock-names = "pclk", "refclk"; + resets = <&clkc_audio AUD_RESET_SPDIFIN>; + status = "disabled"; + }; + + spdifout: audio-controller@480 { + compatible = "amlogic,g12a-spdifout", + "amlogic,axg-spdifout"; + reg = <0x0 0x480 0x0 0x50>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFOUT"; + clocks = <&clkc_audio AUD_CLKID_SPDIFOUT>, + <&clkc_audio AUD_CLKID_SPDIFOUT_CLK>; + clock-names = "pclk", "mclk"; + resets = <&clkc_audio AUD_RESET_SPDIFOUT>; + status = "disabled"; + }; + tdmout_a: audio-controller@500 { compatible = "amlogic,sm1-tdmout"; reg = <0x0 0x500 0x0 0x40>;@@ -401,6 +428,19 @@ tdmout_c: audio-controller@580 { status = "disabled"; }; + spdifout_b: audio-controller@680 { + compatible = "amlogic,g12a-spdifout", + "amlogic,axg-spdifout"; + reg = <0x0 0x680 0x0 0x50>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFOUT_B"; + clocks = <&clkc_audio AUD_CLKID_SPDIFOUT_B>, + <&clkc_audio AUD_CLKID_SPDIFOUT_B_CLK>; + clock-names = "pclk", "mclk"; + resets = <&clkc_audio AUD_RESET_SPDIFOUT_B>; + status = "disabled";Quoted 9 lines
arch/arm64/boot/dts/amlogic/meson-sm1.dtsi tdmout_c: audio-controller@580 { · line 446
Quoted 6 lines
arch/arm64/boot/dts/amlogic/meson-sm1.dtsi +2
-0+ }; + toacodec: audio-controller@740 { compatible = "amlogic,sm1-toacodec", "amlogic,g12a-toacodec";Jerome could you quickly review this ?
Just this, without the related card change is not usefull as it won't be part of the card.
It would be nice to indicate how it was tested ?
AFAIK:
- spdifout b can only be routed to hdmi and dw-hdmi driver does not support that yet
- the VIM3 does not have connectors for the spdif (in or out). If it requires some extension card, it should be noted somewhere, at leastQuoted 2 lines
Thanks,
Neil
Quoted 94 lines · Art Nikpal
Quoted 1 line
It would be nice to indicate how it was tested ?
i have test it
i2s and spdif output from gpio headers - works well
Quoted 85 lines · Jerome Brunet
Quoted 63 lines · Neil Armstrong
Hi,
Quoted 60 lines · Artem Lapkin
Add spdifin spdifout
spdifout_bnodes for Amlogic SM1 SoCs.Signed-off-by Artem Lapkin <[email protected]>--- arch/arm64/boot/dts/amlogic/meson-sm1.dtsi | 40 ++++++++++++++++++++++ 1 file changed, 40 insertions(+)arch/arm64/boot/dts/amlogic/meson-sm1.dtsi +38
-0@@ -356,6 +356,33 @@ tdmin_lb: audio-controller@3c0 { status = "disabled"; }; + spdifin: audio-controller@400 { + compatible = "amlogic,g12a-spdifin", + "amlogic,axg-spdifin"; + reg = <0x0 0x400 0x0 0x30>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFIN"; + interrupts = <GIC_SPI 151 IRQ_TYPE_EDGE_RISING>; + clocks = <&clkc_audio AUD_CLKID_SPDIFIN>, + <&clkc_audio AUD_CLKID_SPDIFIN_CLK>; + clock-names = "pclk", "refclk"; + resets = <&clkc_audio AUD_RESET_SPDIFIN>; + status = "disabled"; + }; + + spdifout: audio-controller@480 { + compatible = "amlogic,g12a-spdifout", + "amlogic,axg-spdifout"; + reg = <0x0 0x480 0x0 0x50>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFOUT"; + clocks = <&clkc_audio AUD_CLKID_SPDIFOUT>, + <&clkc_audio AUD_CLKID_SPDIFOUT_CLK>; + clock-names = "pclk", "mclk"; + resets = <&clkc_audio AUD_RESET_SPDIFOUT>; + status = "disabled"; + }; + tdmout_a: audio-controller@500 { compatible = "amlogic,sm1-tdmout"; reg = <0x0 0x500 0x0 0x40>;@@ -401,6 +428,19 @@ tdmout_c: audio-controller@580 { status = "disabled"; }; + spdifout_b: audio-controller@680 { + compatible = "amlogic,g12a-spdifout", + "amlogic,axg-spdifout"; + reg = <0x0 0x680 0x0 0x50>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFOUT_B"; + clocks = <&clkc_audio AUD_CLKID_SPDIFOUT_B>, + <&clkc_audio AUD_CLKID_SPDIFOUT_B_CLK>; + clock-names = "pclk", "mclk"; + resets = <&clkc_audio AUD_RESET_SPDIFOUT_B>; + status = "disabled";Quoted 9 lines
arch/arm64/boot/dts/amlogic/meson-sm1.dtsi tdmout_c: audio-controller@580 { · line 446
Quoted 6 lines
arch/arm64/boot/dts/amlogic/meson-sm1.dtsi +2
-0+ }; + toacodec: audio-controller@740 { compatible = "amlogic,sm1-toacodec", "amlogic,g12a-toacodec";Jerome could you quickly review this ?
Just this, without the related card change is not usefull as it won't be part of the card.
It would be nice to indicate how it was tested ?
AFAIK:
- spdifout b can only be routed to hdmi and dw-hdmi driver does not support that yet
It doesn't harm to have it described in DT, maybe one day the dw-hdmi driver will support SPDIF input.
Neil
Quoted 7 lines
Quoted 7 lines
- the VIM3 does not have connectors for the spdif (in or out). If it requires some extension card, it should be noted somewhere, at least
Quoted 2 lines
Thanks,
Neil
Jerome Brunet
reviewerQuoted 7 lines · Art Nikpal
Quoted 1 line
It would be nice to indicate how it was tested ?
i have test it
i2s and spdif output from gpio headers - works well
You have tested spdifout_a then.
Nothing says spdifin (which was only tested on the axg series so far) or spdifout_b would actually work if enabled at a later point.
I would prefer if things could at least be tested once before being added DT.
Quoted 91 lines · Jerome Brunet
Quoted 89 lines · Neil Armstrong
Quoted 64 lines
Hi,
Quoted 60 lines · Artem Lapkin
Add spdifin spdifout
spdifout_bnodes for Amlogic SM1 SoCs.Signed-off-by Artem Lapkin <[email protected]>--- arch/arm64/boot/dts/amlogic/meson-sm1.dtsi | 40 ++++++++++++++++++++++ 1 file changed, 40 insertions(+)arch/arm64/boot/dts/amlogic/meson-sm1.dtsi +38
-0@@ -356,6 +356,33 @@ tdmin_lb: audio-controller@3c0 { status = "disabled"; }; + spdifin: audio-controller@400 { + compatible = "amlogic,g12a-spdifin", + "amlogic,axg-spdifin"; + reg = <0x0 0x400 0x0 0x30>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFIN"; + interrupts = <GIC_SPI 151 IRQ_TYPE_EDGE_RISING>; + clocks = <&clkc_audio AUD_CLKID_SPDIFIN>, + <&clkc_audio AUD_CLKID_SPDIFIN_CLK>; + clock-names = "pclk", "refclk"; + resets = <&clkc_audio AUD_RESET_SPDIFIN>; + status = "disabled"; + }; + + spdifout: audio-controller@480 { + compatible = "amlogic,g12a-spdifout", + "amlogic,axg-spdifout"; + reg = <0x0 0x480 0x0 0x50>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFOUT"; + clocks = <&clkc_audio AUD_CLKID_SPDIFOUT>, + <&clkc_audio AUD_CLKID_SPDIFOUT_CLK>; + clock-names = "pclk", "mclk"; + resets = <&clkc_audio AUD_RESET_SPDIFOUT>; + status = "disabled"; + }; + tdmout_a: audio-controller@500 { compatible = "amlogic,sm1-tdmout"; reg = <0x0 0x500 0x0 0x40>;@@ -401,6 +428,19 @@ tdmout_c: audio-controller@580 { status = "disabled"; }; + spdifout_b: audio-controller@680 { + compatible = "amlogic,g12a-spdifout", + "amlogic,axg-spdifout"; + reg = <0x0 0x680 0x0 0x50>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFOUT_B"; + clocks = <&clkc_audio AUD_CLKID_SPDIFOUT_B>, + <&clkc_audio AUD_CLKID_SPDIFOUT_B_CLK>; + clock-names = "pclk", "mclk"; + resets = <&clkc_audio AUD_RESET_SPDIFOUT_B>; + status = "disabled";Quoted 9 lines
arch/arm64/boot/dts/amlogic/meson-sm1.dtsi tdmout_c: audio-controller@580 { · line 446
Quoted 6 lines
arch/arm64/boot/dts/amlogic/meson-sm1.dtsi +2
-0+ }; + toacodec: audio-controller@740 { compatible = "amlogic,sm1-toacodec", "amlogic,g12a-toacodec";Jerome could you quickly review this ?
Just this, without the related card change is not usefull as it won't be part of the card.
It would be nice to indicate how it was tested ?
AFAIK:
- spdifout b can only be routed to hdmi and dw-hdmi driver does not support that yet
- the VIM3 does not have connectors for the spdif (in or out). If it requires some extension card, it should be noted somewhere, at least
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
Thanks,
Neil
_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
Quoted 12 lines · Jerome Brunet
Quoted 7 lines · Art Nikpal
Quoted 1 line
It would be nice to indicate how it was tested ?
i have test it
i2s and spdif output from gpio headers - works well
Quoted 89 lines
You have tested
spdifout_athen.Nothing says spdifin (which was only tested on the axg series so far) or
spdifout_bwould actually work if enabled at a later point.I would prefer if things could at least be tested once before being added DT.
Quoted 81 lines · Jerome Brunet
Quoted 79 lines · Neil Armstrong
Quoted 64 lines
Hi,
Quoted 60 lines · Artem Lapkin
Add spdifin spdifout
spdifout_bnodes for Amlogic SM1 SoCs.Signed-off-by Artem Lapkin <[email protected]>--- arch/arm64/boot/dts/amlogic/meson-sm1.dtsi | 40 ++++++++++++++++++++++ 1 file changed, 40 insertions(+)arch/arm64/boot/dts/amlogic/meson-sm1.dtsi +38
-0@@ -356,6 +356,33 @@ tdmin_lb: audio-controller@3c0 { status = "disabled"; }; + spdifin: audio-controller@400 { + compatible = "amlogic,g12a-spdifin", + "amlogic,axg-spdifin"; + reg = <0x0 0x400 0x0 0x30>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFIN"; + interrupts = <GIC_SPI 151 IRQ_TYPE_EDGE_RISING>; + clocks = <&clkc_audio AUD_CLKID_SPDIFIN>, + <&clkc_audio AUD_CLKID_SPDIFIN_CLK>; + clock-names = "pclk", "refclk"; + resets = <&clkc_audio AUD_RESET_SPDIFIN>; + status = "disabled"; + }; + + spdifout: audio-controller@480 { + compatible = "amlogic,g12a-spdifout", + "amlogic,axg-spdifout"; + reg = <0x0 0x480 0x0 0x50>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFOUT"; + clocks = <&clkc_audio AUD_CLKID_SPDIFOUT>, + <&clkc_audio AUD_CLKID_SPDIFOUT_CLK>; + clock-names = "pclk", "mclk"; + resets = <&clkc_audio AUD_RESET_SPDIFOUT>; + status = "disabled"; + }; + tdmout_a: audio-controller@500 { compatible = "amlogic,sm1-tdmout"; reg = <0x0 0x500 0x0 0x40>;@@ -401,6 +428,19 @@ tdmout_c: audio-controller@580 { status = "disabled"; }; + spdifout_b: audio-controller@680 { + compatible = "amlogic,g12a-spdifout", + "amlogic,axg-spdifout"; + reg = <0x0 0x680 0x0 0x50>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFOUT_B"; + clocks = <&clkc_audio AUD_CLKID_SPDIFOUT_B>, + <&clkc_audio AUD_CLKID_SPDIFOUT_B_CLK>; + clock-names = "pclk", "mclk"; + resets = <&clkc_audio AUD_RESET_SPDIFOUT_B>; + status = "disabled";Quoted 9 lines
arch/arm64/boot/dts/amlogic/meson-sm1.dtsi tdmout_c: audio-controller@580 { · line 446
Quoted 6 lines
arch/arm64/boot/dts/amlogic/meson-sm1.dtsi +2
-0+ }; + toacodec: audio-controller@740 { compatible = "amlogic,sm1-toacodec", "amlogic,g12a-toacodec";Jerome could you quickly review this ?
Just this, without the related card change is not usefull as it won't be part of the card.
Current sound card dt configuration not configured for it, but we can apply dt overlays anytime.
IMHO: current sound configuration is not ideal and for some tasks better to use custom configuration.
but anyway i think meson-sm1.dtsi must be completed by missed spdif in/out nodes
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
It would be nice to indicate how it was tested ?
AFAIK:
- spdifout b can only be routed to hdmi and dw-hdmi driver does not support that yet
Ok! But why not accept it at this moment - next time will be easy to improve dw-hdmi driver
+like options i can submit new patch without spdifout_b node
Quoted 1 line
Quoted 1 line
Quoted 1 line
- the VIM3 does not have connectors for the spdif (in or out). If it
we have test SPDIF in and SPDIF OUT both works fine on VIM3L meson-sm1
Quoted 1 line
Quoted 1 line
Quoted 1 line
requires some extension card, it should be noted somewhere, at least
SPDIF in and SPDIF OUT both pins available via GPIO header ( SPDIF_OUT PIN 13 and SPDIF_IN PIN 35 - same PWM_F )
Quoted 6 lines
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
Thanks,
Neil
Jerome Brunet
reviewerQuoted 100 lines · Art Nikpal
Quoted 99 lines · Jerome Brunet
Quoted 7 lines · Art Nikpal
Quoted 1 line
It would be nice to indicate how it was tested ?
i have test it
i2s and spdif output from gpio headers - works well
You have tested
spdifout_athen.Nothing says spdifin (which was only tested on the axg series so far) or
spdifout_bwould actually work if enabled at a later point.I would prefer if things could at least be tested once before being added DT.
Quoted 79 lines · Jerome Brunet
Quoted 77 lines · Neil Armstrong
Quoted 73 lines
Hi,
Quoted 56 lines · Artem Lapkin
Add spdifin spdifout
spdifout_bnodes for Amlogic SM1 SoCs.Signed-off-by Artem Lapkin <[email protected]>--- arch/arm64/boot/dts/amlogic/meson-sm1.dtsi | 40 ++++++++++++++++++++++ 1 file changed, 40 insertions(+)arch/arm64/boot/dts/amlogic/meson-sm1.dtsi +33
-0@@ -356,6 +356,33 @@ tdmin_lb: audio-controller@3c0 { status = "disabled"; }; + spdifin: audio-controller@400 { + compatible = "amlogic,g12a-spdifin", + "amlogic,axg-spdifin"; + reg = <0x0 0x400 0x0 0x30>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFIN"; + interrupts = <GIC_SPI 151 IRQ_TYPE_EDGE_RISING>; + clocks = <&clkc_audio AUD_CLKID_SPDIFIN>, + <&clkc_audio AUD_CLKID_SPDIFIN_CLK>; + clock-names = "pclk", "refclk"; + resets = <&clkc_audio AUD_RESET_SPDIFIN>; + status = "disabled"; + }; + + spdifout: audio-controller@480 { + compatible = "amlogic,g12a-spdifout", + "amlogic,axg-spdifout"; + reg = <0x0 0x480 0x0 0x50>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFOUT"; + clocks = <&clkc_audio AUD_CLKID_SPDIFOUT>, + <&clkc_audio AUD_CLKID_SPDIFOUT_CLK>; + clock-names = "pclk", "mclk"; + resets = <&clkc_audio AUD_RESET_SPDIFOUT>; + status = "disabled"; + }; + tdmout_a: audio-controller@500 { compatible = "amlogic,sm1-tdmout"; reg = <0x0 0x500 0x0 0x40>;@@ -401,6 +428,19 @@ tdmout_c: audio-controller@580 { status = "disabled"; }; + spdifout_b: audio-controller@680 { + compatible = "amlogic,g12a-spdifout", + "amlogic,axg-spdifout"; + reg = <0x0 0x680 0x0 0x50>; + #sound-dai-cells = <0>; + sound-name-prefix = "SPDIFOUT_B";arch/arm64/boot/dts/amlogic/meson-sm1.dtsi tdmout_c: audio-controller@580 { · line 446
Quoted 10 lines
arch/arm64/boot/dts/amlogic/meson-sm1.dtsi +7
-0+ clocks = <&clkc_audio AUD_CLKID_SPDIFOUT_B>, + <&clkc_audio AUD_CLKID_SPDIFOUT_B_CLK>; + clock-names = "pclk", "mclk"; + resets = <&clkc_audio AUD_RESET_SPDIFOUT_B>; + status = "disabled"; + }; + toacodec: audio-controller@740 { compatible = "amlogic,sm1-toacodec", "amlogic,g12a-toacodec";Jerome could you quickly review this ?
Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Just this, without the related card change is not usefull as it won't be part of the card.
Current sound card dt configuration not configured for it, but we can apply dt overlays anytime.
Maybe you should do so
Quoted 5 lines
IMHO: current sound configuration is not ideal and for some tasks better to use custom configuration.
but anyway i thinkmeson-sm1.dtsimust be completed by missed spdif in/out nodes
Tested ones, sure
Quoted 11 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
It would be nice to indicate how it was tested ?
AFAIK:
- spdifout b can only be routed to hdmi and dw-hdmi driver does not support that yetOk! But why not accept it at this moment - next time will be easy to improve dw-hdmi driver
+like options i can submit new patch withoutspdifout_bnode
Because as it stands, it is useless. No one tried it. What lands in the kernel should work, or at least we should do our best to confirm it does.
We should not place code here hoping everything will be fine when someone finally turns it on.
When dw-hdmi driver support spdif input and you can confirm it works with your change, you are welcome to submit it again.
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
- the VIM3 does not have connectors for the spdif (in or out). If it
we have test SPDIF in and SPDIF OUT both works fine on VIM3L meson-sm1
Then adding to spdifin and spdifout_a nodes is fine by me
Quoted 6 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
requires some extension card, it should be noted somewhere, at least
SPDIF in and SPDIF OUT both pins available via GPIO header (
SPDIF_OUTPIN 13 andSPDIF_INPIN 35 - samePWM_F)
Like other thing on those GPIO connectors, we don't enable them by default.
Now that the kernel accepts overlays, it would be nice to submit one so other can replicate your test setup, if you wish to.
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
Thanks,
Neil