Skip to contentSkip to conversation

clk: meson: Kconfig: fix dependency for G12A

PATCH In review Kevin Hilman 2 participants 3 messages Nov 18, 2020 – Nov 19, 2020

Subsystems (3)
lore
Share & tools
lore

Kevin Hilman

author maintainer
#0 lore raw

PATCH 1/1 clk: meson: Kconfig: fix dependency for G12A

When building only G12A, ensure that VID_PLL_DIV clock driver is selected, otherwise results in this build error:

ERROR: modpost: "meson_vid_pll_div_ro_ops" [drivers/clk/meson/g12a.ko] undefined!

---
 drivers/clk/meson/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/meson/Kconfig +1 -0
index 034da203e8e0..9a8a548d839d 100644
@@ -110,6 +110,7 @@ config COMMON_CLK_G12A
 	select COMMON_CLK_MESON_AO_CLKC
 	select COMMON_CLK_MESON_EE_CLKC
 	select COMMON_CLK_MESON_CPU_DYNDIV
+	select COMMON_CLK_MESON_VID_PLL_DIV
 	select MFD_SYSCON
 	help
 	  Support for the clock controller on Amlogic S905D2, S905X2 and S905Y2
Signature · 1 line
2.28.0
maintainer
#1 lore raw
Quoted 6 lines · Kevin Hilman

When building only G12A, ensure that VID_PLL_DIV clock driver is selected, otherwise results in this build error:

ERROR: modpost: "meson_vid_pll_div_ro_ops" [drivers/clk/meson/g12a.ko] undefined!

Fixes 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
Quoted 16 lines
---
 drivers/clk/meson/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/meson/Kconfig +1 -0
index 034da203e8e0..9a8a548d839d 100644
@@ -110,6 +110,7 @@ config COMMON_CLK_G12A
 	select COMMON_CLK_MESON_AO_CLKC
 	select COMMON_CLK_MESON_EE_CLKC
 	select COMMON_CLK_MESON_CPU_DYNDIV
+	select COMMON_CLK_MESON_VID_PLL_DIV
 	select MFD_SYSCON
 	help
 	  Support for the clock controller on Amlogic S905D2, S905X2 and S905Y2
maintainer
#2 lore raw
Quoted 10 lines · Jerome Brunet
Quoted 6 lines · Kevin Hilman

When building only G12A, ensure that VID_PLL_DIV clock driver is selected, otherwise results in this build error:

ERROR: modpost: "meson_vid_pll_div_ro_ops" [drivers/clk/meson/g12a.ko] undefined!

Fixes 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")

And applied, Thx

Quoted 17 lines
Quoted 17 lines
---
 drivers/clk/meson/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/meson/Kconfig +1 -0
index 034da203e8e0..9a8a548d839d 100644
@@ -110,6 +110,7 @@ config COMMON_CLK_G12A
 	select COMMON_CLK_MESON_AO_CLKC
 	select COMMON_CLK_MESON_EE_CLKC
 	select COMMON_CLK_MESON_CPU_DYNDIV
+	select COMMON_CLK_MESON_VID_PLL_DIV
 	select MFD_SYSCON
 	help
 	  Support for the clock controller on Amlogic S905D2, S905X2 and S905Y2