Skip to contentSkip to conversation

PATCH: 2.2 series FEC driver performance improvements

DISCUSSION Graham Stoney 1 participant 1 message Aug 23, 2000 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 6 lines · A partly satisfied customer

I've installed your patch, as I liked very much the changes you made.

I cannot get it to link though:
arch/ppc/8xx_io/8xx_io.a: In function `fec_enet_rx':
arch/ppc/8xx_io/8xx_io.a(.text+0x3198): undefined reference to `invalidate_dcache_range'

...

Quoted 2 lines

My kernel is based on a hardhat kernel (2.2.13-7). Any ideas why I don't have
that function?

Hmmm. Sounds like it's missing from your kernel; it's not used by many other drivers. Applying the patch below should add it for you.

Quoted 2 lines

Are you planning to make the same kind of improvements in the 10Mbit driver (enet.c)?

Our project only has a FEC-based interface, so probably not. Most of the changes are in fec_enet_rx, and cpm_enet_rx looks almost identical. It shouldn't be hard to apply the equivalent changes to enet.c by hand.

Regards,
Graham

Index: arch/ppc/kernel/head.S
===================================================================
RCS file: /u/archive/epc/sw/linux/arch/ppc/kernel/head.S,v

ppc/kernel/head.S +23 -0
diff -u -r1.1.1.2 -r1.1.1.3
@@ -2450,6 +2578,29 @@
        bdnz    1b
        sync                            /* wait for dcbst's to get to ram */
        blr
+
+/*
+ * Like above, but invalidate the D-cache.  This is used by the 8xx
+ * to invalidate the cache so the PPC core doesn't get stale data
+ * from the CPM (no cache snooping here :-).
+ *
+ * invalidate_dcache_range(unsigned long start, unsigned long stop)
+ */
+_GLOBAL(invalidate_dcache_range)
+       li      r5,CACHE_LINE_SIZE-1
+       andc    r3,r3,r5
+       subf    r4,r3,r4
+       add     r4,r4,r5
+       srwi.   r4,r4,LG_CACHE_LINE_SIZE
+       beqlr
+       mtctr   r4
+
+1:     dcbi    0,r3
+       addi    r3,r3,CACHE_LINE_SIZE
+       bdnz    1b
+       sync                            /* wait for dcbst's to get to ram */
+       blr
+
 
 /*
  * Flush a particular page from the DATA cache

Index: include/asm-ppc/cache.h
===================================================================
RCS file: /u/archive/epc/sw/linux/include/asm-ppc/cache.h,v retrieving revision 1.2

asm-ppc/cache.h +1 -0
diff -u -r1.2 cache.h
@@ -21,6 +21,7 @@
 
 #if defined(__KERNEL__) && !defined(__ASSEMBLY__)
 extern void flush_dcache_range(unsigned long start, unsigned long stop);
+extern void invalidate_dcache_range(unsigned long start, unsigned long stop);
 
 static inline unsigned long unlock_dcache(void)
 {

--
Graham Stoney
Principal Hardware/Software Engineer
Canon Information Systems Research Australia
Ph: +61 2 9805 2909 Fax: +61 2 9805 2929

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/