address-space identification for /proc
PATCH 1/1 address-space identification for /proc
Hi,
/proc has no way to indicate whether tasks share an address space. This one-liner patch adds a new ASID: field to /proc/<pid>/status so there's some way to see address-space sharing between tasks.
While this is hardly a bug-fix, it is a pretty useful thing to know which is otherwise completely absent.
J
fs/proc/array.c renamed from 2.3/fs/proc/array.c +1 -0
@@ -294,6 +294,7 @@for (line=0 ;(len=sprintf_regs (line,buffer,task,NULL ,NULL ))!=0 ;line++) buffer+=len;#endif + buffer +=sprintf ("ASID: %p\n" , mm);return buffer - orig; }
fs/proc/array.c line 297
Quoted 1 line · On Thu, Oct 26, 2000 at 03:45:27PM -0700, I wrote:
fs/proc/array.c renamed from 2.3/fs/proc/array.c +1
-0+ buffer +=sprintf ("ASID: %p\n" , mm);
Obviously, this should be:
+ buffer += sprintf("ASID:\t%p\n", mm);
for consistency.
J
Review
Quoted 6 lines · Jeremy Fitzhardinge
fs/proc/array.c line 297
Quoted 1 line · On Thu, Oct 26, 2000 at 03:45:27PM -0700, I wrote:
fs/proc/array.c renamed from 2.3/fs/proc/array.c +1
-0+ buffer +=sprintf ("ASID: %p\n" , mm);Obviously, this should be:
(quoted diff) +1
-0+ buffer += sprintf("ASID:\t%p\n", mm);
and even more obvious:
+ buffer += sprintf(buffer, "ASID:\t%p\n", mm);
Actually putting it into the buffer would be useful as well :)
JE
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/
Quoted 5 lines · Johannes Erdfelt
and even more obvious:
(quoted diff) +1
-0+ buffer += sprintf(buffer, "ASID:\t%p\n", mm);Actually putting it into the buffer would be useful as well :)
That serves me right for hand-editing patches.
J
--
Repeat to self: I am not Linus