silly [< >] and other excess
Quoted 2 lines
Thats because too many things get put on a line then.
And because we do [<foo>] [<bar>] not [<foo>][<bar>] ?
In the good old times we had foo bar for a total of 8*(8+1) = 72 positions. Now we have [<foo>] [<bar>] which takes 8*(8+1+4) = 104 positions. If you turned this into 6 items per line instead of 8, it would certainly improve matters a bit.
Still..
Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/
Quoted 7 lines · [email protected] <[email protected]> wrote:
Quoted 2 lines
Thats because too many things get put on a line then.
And because we do [<foo>] [<bar>] not [<foo>][<bar>] ?In the good old times we had foo bar for a total of 8*(8+1) = 72 positions. Now we have [<foo>] [<bar>] which takes 8*(8+1+4) = 104 positions. If you turned this into 6 items per line instead of 8, it would certainly improve matters a bit.
The original poster complained the output lines were too wide for the screen on his PC. Perhaps he should change his console mode to 132 characters wide (via SVGATextMode or such) -- voila, no more problem, no broken kernel patches.
Charles
Signature · 8 lines
-------------------------------------------------------------- Charles Cazabon <[email protected]> My opinions do not necessarily represent those of my employer. -------------------------------------------------------------- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] Please read the FAQ at http://www.tux.org/lkml/
Quoted 5 lines · Charles Cazabon
Quoted 3 lines · [email protected] <[email protected]> wrote:
Quoted 2 lines
Thats because too many things get put on a line then.
And because we do [<foo>] [<bar>] not [<foo>][<bar>] ?
Quoted 8 lines
Quoted 4 lines
In the good old times we had foo bar for a total of 8*(8+1) = 72 positions. Now we have [<foo>] [<bar>] which takes 8*(8+1+4) = 104 positions. If you turned this into 6 items per line instead of 8, it would certainly improve matters a bit.
The original poster complained the output lines were too wide for the screen on his PC. Perhaps he should change his console mode to 132 characters wide (via SVGATextMode or such) -- voila, no more problem, no broken kernel patches.
Well that 72 characters is also known as the "safe" email line length... ... and besides some people still use the old VT330s and alike ;)
But in practice even those 79 chars would be better than 104.
--
No .sig here... especially no 128x48 .sig here - nor 132xYuch...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/
PATCH 1/1 silly [< >] and other excess
In reply to [email protected][Alan Cox]
Quoted 2 lines
Quoted 2 lines
Thats because too many things get put on a line then.
And because we do [<foo>] [<bar>] not [<foo>][<bar>] ?
[Andries Brouwer]
Quoted 2 lines
In the good old times we had foo bar for a total of 8*(8+1) = 72 positions. Now we have [<foo>] [<bar>] which takes 8*(8+1+4) = 104
I've got it! Put multiple addresses within one set of [< >]. ksymoops and klogd will require a small adjustment, of course.
The following show_stack() is 8 addrs per line, 79 columns. Comments?
Peter
i386/kernel/traps.c renamed from i386/kernel/traps.c.orig +8 -4
@@ -126,7 +126,6 @@printk ("%08lx " , *stack++); } -printk ("\nCall Trace: " ); stack = esp; i =1 ; module_start =VMALLOC_START ;
@@ -144,12 +143,17 @@if (((addr >= (unsigned long ) &_stext) && (addr <= (unsigned long ) &_etext)) || ((addr >= module_start) && (addr <= module_end))) { -if (i && ((i %8 ) ==0 )) -printk ("\n " ); -printk ("[<%08lx>] " , addr); +if (i==1 ) +printk ("\nCall Trace: [<" ); +else if ((i %8 )==0 ) +printk (">]\n [<" ); +else +printk (" " ); +printk ("%08lx" , addr); i++; } } +printk (">]\n" ); }static void show_registers (struct pt_regs *regs)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/