Skip to contentSkip to conversation

2.4.0-test11 ext2 fs corruption

DISCUSSION Petr Vandrovec 4 participants 5 messages Nov 28, 2000 – Nov 29, 2000 Block layer

lore
Share & tools
lore
#0 lore raw
Quoted 6 lines · David S. Miller

Yes, it is identical copy. But I do not think that hdd can write same data into two places with one command...

Petr, did the af_inet.c assertions get triggered on this same machine?

No, ext2fs is at home, and af_inet is at work... At work I'm using vmware, at home I do not use it... But kernel sources are same (g450 patch for matroxfb, ncpfs supporting device nodes, threaded ipx; but neither ncpfs nor ipx is compiled at home).
Petr Vandrovec [email protected]

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#1 lore raw
Quoted 8 lines · Petr Vandrovec
Quoted 6 lines · David S. Miller

Yes, it is identical copy. But I do not think that hdd can write same data into two places with one command...

Petr, did the af_inet.c assertions get triggered on this same machine?

Quoted 6 lines

No, ext2fs is at home, and af_inet is at work... At work I'm using vmware, at home I do not use it... But kernel sources are same (g450 patch for matroxfb, ncpfs supporting device nodes, threaded ipx; but neither ncpfs nor ipx is compiled at home).
Petr Vandrovec [email protected]

Petr,

Could you try and reproduce with attached patch? If this would trigger I would assume fs corruption as well (which doesn't seem to be the case for you), but it's worth a shot.

block/ll_rw_blk.c renamed from block/ll_rw_blk.c~ +2 -1
@@ -684,7 +684,7 @@
 	int max_segments = MAX_SEGMENTS;
 	struct request * req = NULL, *freereq = NULL;
 	int rw_ahead, max_sectors, el_ret;
-	struct list_head *head = &q->queue_head;
+	struct list_head *head;
 	int latency;
 	elevator_t *elevator = &q->elevator;
 
@@ -734,6 +734,7 @@
 	 */
 again:
 	spin_lock_irq(&io_request_lock);
+	head = &q->queue_head;
 
 	/*
 	 * skip first entry, for devices with active queue head
Signature · 6 lines
* Jens Axboe <[email protected]>
* SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/
#3 lore raw
In reply to Petr Vandrovec
Quoted 2 lines · Andrea Arcangeli

Side note: that could generate mem/io corruption only on headactive devices (like IDE).

Yep, that's why I told Linus it was a long shot and couldn't possibly account for all the corruption cases reported. And one would expect fs corruption to go with that as well. So it's of course a long shot, but still worth trying for Petr.

Signature · 6 lines
* Jens Axboe <[email protected]>
* SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/
#4 lore raw
Quoted 8 lines · Jens Axboe
Quoted 2 lines · Andrea Arcangeli

Side note: that could generate mem/io corruption only on headactive devices (like IDE).

Yep, that's why I told Linus it was a long shot and couldn't possibly account for all the corruption cases reported. And one would expect fs corruption to go with that as well. So it's of course a long shot, but still worth trying for Petr.

Okay, I have spent part of the afternoon kicking my FW around and have not followed all of the thread. However we are talking FSC and ATA so what are the details? And where are we poking into the driver.

Andre Hedrick
Linux ATA Development

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/