Skip to contentSkip to conversation

17 month late patch for Linux v2.2.x

DISCUSSION John Fort 2 participants 2 messages Dec 13, 2000 – Dec 17, 2000

lore
Share & tools
lore

John Fort

author
#0 lore raw

Alan, this is identical to the patch that was in patch-2.3.10 of Jul 5 1999 except a line number difference of one.

It is only needed if you build your v2.2.x kernel for the Initio 1060p LVD SCSI controller using a later compiler
than 2.7.2.3 and then are stupid enough to ignore any compiler warnings about 'ambiguous else, suggest using braces'.

Harbison & Steele 2nd Ed, p202, under 'Dangling Else problem' also show the misleading indentation.

This aggravation was prompted by trying to install RedHat 7.0 and Mandrake 7.2 to my SCSI disks last week.

In linux/drivers/scsi/i60uscsi.c:
Line 768: add ' {' at end of line
Line 771: replace 4th Tab with '} '
Line 772: delete 5th Tab.

I tried hand entering the patch into Outhouse Exploder 5.5 and conceeded.

cu johnf

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#1 lore raw

[John Fort]

Quoted 4 lines

It is only needed if you build your v2.2.x kernel for the Initio 1060p LVD SCSI controller using a later compiler than 2.7.2.3 and then are stupid enough to ignore any compiler warnings about 'ambiguous else, suggest using braces'.

You mean gcc 2.7.2.3 actually gives you the *other* meaning for that wrong construction? That is too weird. The C standard is clear, 'else' always goes with the immediately preceding 'if' statement.

Peter
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/