Skip to contentSkip to conversation

time for compiling test_ring.c

dpdk-dev Thomas Monjalon 3 participants 7 messages Apr 22, 2020

lore
Share & tools
lore
#0 lore raw

Hi,

I don't want know why and when, but it seems the file test_ring.c became very long to compile, especially with clang.

I have no solution to shorten the compilation time, so I propose to rename test_ring.c to test_patien.ce.
Disclosure: I am failing this test :-(

#1 lore raw

<snip>

Quoted 5 lines

Hi,

I don't want know why and when, but it seems the file test_ring.c became very long to compile, especially with clang.

What is the compiler version? Is this on master?
Any info on test_ring_perf.c?

Quoted 5 lines

I have no solution to shorten the compilation time, so I propose to rename test_ring.c to test_patien.ce.
Disclosure: I am failing this test :-(

#2 lore raw

22/04/2020 02:05, Honnappa Nagarahalli:

Quoted 5 lines

22/04/2020 02:00, Thomas Monjalon:

Quoted 2 lines

I don't want know why and when, but it seems the file test_ring.c became very long to compile, especially with clang.

What is the compiler version? Is this on master?

clang 9.0.1 compiling DPDK master.

Quoted 1 line

Any info on test_ring_perf.c?

This one looks slow to compile as well.

Quoted 3 lines
Quoted 3 lines

I have no solution to shorten the compilation time, so I propose to rename test_ring.c to test_patien.ce.
Disclosure: I am failing this test :-(

The object file takes 5 to 11MB.
I don't know how much this test is magic, but I hope it does a lot more than this 256B program: https://www.youtube.com/watch?v=Imquk_3oFf4

#3 lore raw

<snip>

Quoted 9 lines

22/04/2020 02:05, Honnappa Nagarahalli:

Quoted 5 lines

22/04/2020 02:00, Thomas Monjalon:

Quoted 2 lines

I don't want know why and when, but it seems the file test_ring.c became very long to compile, especially with clang.

What is the compiler version? Is this on master?

clang 9.0.1 compiling DPDK master.

I think, it is the compiler. The issues were observed with clang-7 during the last release. Clang-8 worked fine. Still, test_ring.c was re-worked to compile in shorter time. Looks like things are back to broken in 9.0.1.

Quoted 13 lines
Quoted 2 lines

Any info on test_ring_perf.c?

This one looks slow to compile as well.

Quoted 3 lines
Quoted 3 lines

I have no solution to shorten the compilation time, so I propose to rename test_ring.c to test_patien.ce.
Disclosure: I am failing this test :-(

The object file takes 5 to 11MB.
I don't know how much this test is magic, but I hope it does a lot more than this 256B program: https://www.youtube.com/watch?v=Imquk_3oFf4

#4 lore raw

<snip>

Quoted 7 lines
Quoted 7 lines

22/04/2020 02:05, Honnappa Nagarahalli:

Quoted 4 lines

22/04/2020 02:00, Thomas Monjalon:

Quoted 2 lines

I don't want know why and when, but it seems the file test_ring.c became very long to compile, especially with clang.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

What is the compiler version? Is this on master?

clang 9.0.1 compiling DPDK master.

I think, it is the compiler. The issues were observed with clang-7 during the last release. Clang-8 worked fine. Still, test_ring.c was re-worked to compile in shorter time. Looks like things are back to broken in 9.0.1.

I am able to reproduce, need sometime to come up with a fix.

Quoted 15 lines
Quoted 15 lines
Quoted 3 lines

Any info on test_ring_perf.c?

This one looks slow to compile as well.

Quoted 3 lines
Quoted 3 lines

I have no solution to shorten the compilation time, so I propose to rename test_ring.c to test_patien.ce.
Disclosure: I am failing this test :-(

The object file takes 5 to 11MB.
I don't know how much this test is magic, but I hope it does a lot more than this 256B program:
https://www.youtube.com/watch?v=Imquk_3oFf4

#5 lore raw

22/04/2020 07:11, Honnappa Nagarahalli:

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

22/04/2020 02:05, Honnappa Nagarahalli:

Quoted 4 lines

22/04/2020 02:00, Thomas Monjalon:

Quoted 2 lines

I don't want know why and when, but it seems the file test_ring.c became very long to compile, especially with clang.

Quoted 7 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

What is the compiler version? Is this on master?

clang 9.0.1 compiling DPDK master.

I think, it is the compiler. The issues were observed with clang-7 during the last release. Clang-8 worked fine. Still, test_ring.c was re-worked to compile in shorter time. Looks like things are back to broken in 9.0.1.

I am able to reproduce, need sometime to come up with a fix.

OK thank you.
Note that I was not asking for a fix ;-)

Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 1 line

Any info on test_ring_perf.c?

This one looks slow to compile as well.

Quoted 3 lines
Quoted 3 lines

I have no solution to shorten the compilation time, so I propose to rename test_ring.c to test_patien.ce.
Disclosure: I am failing this test :-(

The object file takes 5 to 11MB.
I don't know how much this test is magic, but I hope it does a lot more than this 256B program:
https://www.youtube.com/watch?v=Imquk_3oFf4

#6 lore raw
Quoted 12 lines · Thomas Monjalon

22/04/2020 07:11, Honnappa Nagarahalli:

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

22/04/2020 02:05, Honnappa Nagarahalli:

Quoted 5 lines

22/04/2020 02:00, Thomas Monjalon:

Quoted 2 lines

I don't want know why and when, but it seems the file test_ring.c became very long to compile, especially with clang.

What is the compiler version? Is this on master?

Quoted 8 lines
Quoted 5 lines
Quoted 4 lines
Quoted 1 line

clang 9.0.1 compiling DPDK master.

I think, it is the compiler. The issues were observed with clang-7 during the last release. Clang-8 worked fine. Still, test_ring.c was re-worked to compile in shorter time. Looks like things are back to broken in 9.0.1.

I am able to reproduce, need sometime to come up with a fix.

OK thank you.
Note that I was not asking for a fix ;-)

Is it possible to break the file into smaller parts, then you can use multiple threads to build all of the parts. I noticed in some of the other files with large tables or macros it was easier to split the file up and have ninja use multiple threads to build it. $0.02

Quoted 17 lines
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Quoted 3 lines

Any info on test_ring_perf.c?

This one looks slow to compile as well.

Quoted 3 lines
Quoted 3 lines

I have no solution to shorten the compilation time, so I propose to rename test_ring.c to test_patien.ce.
Disclosure: I am failing this test :-(

The object file takes 5 to 11MB.
I don't know how much this test is magic, but I hope it does a lot more than this 256B program:
https://www.youtube.com/watch?v=Imquk_3oFf4