Skip to contentSkip to conversation

/linux/drivers/char/serial.c: missing __devinitdata

PATCH New Andrey Panin 1 participant 1 message Jan 3, 2001

lore
Share & tools
lore

Andrey Panin

author
#0 lore raw

PATCH 1/1 /linux/drivers/char/serial.c: missing __devinitdata

Hi all,

this small and obvious patch adds some missing __devinitdata directives to the 16x50 serial driver.

Best regards,
Andrey

P.S. Question: why __init and friends are nop when CONFIG_HOTPLUG is defined ? IMHO only __devinit and __devinitdata should be nop, isn't it ?

Signature · 2 lines
Andrey Panin            | Embedded systems software engineer
[email protected]        | PGP key: http://www.orbita1.ru/~pazke/AndreyPanin.asc
linux/drivers/char/serial.c renamed from linux/drivers/char/serial.c.orig +5 -5
diff -u /linux/drivers/char/serial.c.orig /linux/drivers/char/serial.c
@@ -4133,26 +4133,26 @@
  * growing *huge*, we use this function to collapse some 70 entries
  * in the PCI table into one, for sanity's and compactness's sake.
  */
-static unsigned short timedia_single_port[] = {
+static unsigned short timedia_single_port[] __devinitdata = {
 	0x4025, 0x4027, 0x4028, 0x5025, 0x5027, 0 };
-static unsigned short timedia_dual_port[] = {
+static unsigned short timedia_dual_port[] __devinitdata = {
 	0x0002, 0x4036, 0x4037, 0x4038, 0x4078, 0x4079, 0x4085,
 	0x4088, 0x4089, 0x5037, 0x5078, 0x5079, 0x5085, 0x6079, 
 	0x7079, 0x8079, 0x8137, 0x8138, 0x8237, 0x8238, 0x9079, 
 	0x9137, 0x9138, 0x9237, 0x9238, 0xA079, 0xB079, 0xC079,
 	0xD079, 0 };
-static unsigned short timedia_quad_port[] = {
+static unsigned short timedia_quad_port[] __devinitdata = {
 	0x4055, 0x4056, 0x4095, 0x4096, 0x5056, 0x8156, 0x8157, 
 	0x8256, 0x8257, 0x9056, 0x9156, 0x9157, 0x9158, 0x9159, 
 	0x9256, 0x9257, 0xA056, 0xA157, 0xA158, 0xA159, 0xB056,
 	0xB157, 0 };
-static unsigned short timedia_eight_port[] = {
+static unsigned short timedia_eight_port[] __devinitdata = {
 	0x4065, 0x4066, 0x5065, 0x5066, 0x8166, 0x9066, 0x9166, 
 	0x9167, 0x9168, 0xA066, 0xA167, 0xA168, 0 };
 static struct timedia_struct {
 	int num;
 	unsigned short *ids;
-} timedia_data[] = {
+} timedia_data[] __devinitdata = {
 	{ 1, timedia_single_port },
 	{ 2, timedia_dual_port },
 	{ 4, timedia_quad_port },