Skip to contentSkip to conversation

vgcfgrestore bug followup

linux-lvm Brad Corsello 3 participants 4 messages Jan 7, 2001 – Jan 8, 2001

lore
Share & tools
lore

Brad Corsello

author
#0 lore raw

Following up on my own post, I seem to have solved my problem by editing the vg data in the first physical volume with a hex editor, adding the uuid of the second PV where it was supposed to be. Once I did that, vgscan ran successfully and found the volume group. But I think this just proves vgcfgrestore is not restoring the uuid list to disk properly.

(But then I pushed my luck and tried doing vgextends. After adding three PVs, vgscan started to throw up with a weird error: vg_read_with_pv_and_lv():
allocated LE of LV" can't get data of volume group "vg1" from physical volume(s). I don't know if this is related to the vgcfgrestore problem or not.)

#1 lore raw
Quoted 5 lines · Brad Corsello

(But then I pushed my luck and tried doing vgextends. After adding three PVs, vgscan started to throw up with a weird error: vg_read_with_pv_and_lv():
allocated LE of LV" can't get data of volume group "vg1" from physical volume(s). I don't know if this is related to the vgcfgrestore problem or not.)

This one looks like a problem I had myself. For me, the following patch did help: (I already posted this patch, with a description, on Dec 23)

Index: pv_read_all_pv_of_vg.c
===================================================================
RCS file: /data/cvs/LVM/tools/lib/pv_read_all_pv_of_vg.c,v retrieving revision 1.3

pv_read_all_pv_of_vg.c +3 -3
diff -u -1 -b -p -r1.3 pv_read_all_pv_of_vg.c
@@ -103,2 +103,3 @@ int pv_read_all_pv_of_vg ( char *vg_name
             pv_this_sav = pv_this;
+	    if(np<pv_tmp[p]->pv_number) np=pv_tmp[p]->pv_number;
             if ( ( pv_this = realloc ( pv_this,

@@ -111,5 +112,4 @@ int pv_read_all_pv_of_vg ( char *vg_name
             }
-            pv_this[np] = pv_tmp[p];
-            pv_this[np+1] = NULL;
-            np++;
+            pv_this[pv_tmp[p]->pv_number-1] = pv_tmp[p];
+            //pv_this[np+1] = NULL; // XXX???
          }
#2 lore raw
Quoted 3 lines · Rik van Riel

The patch posted on december 23rd by Jan Niehusmann has the extra result that vgscan always segfaults, and not just when in debugging output...

and

On Sun, Jan 07, 2001 at 10:33:00PM +0100, Jan Niehusmann wrote:
[...]

Quoted 15 lines

This one looks like a problem I had myself. For me, the following patch did help: (I already posted this patch, with a description, on Dec 23)

Index: pv_read_all_pv_of_vg.c
===================================================================
RCS file: /data/cvs/LVM/tools/lib/pv_read_all_pv_of_vg.c,v retrieving revision 1.3
diff -u -1 -b -p -r1.3 pv_read_all_pv_of_vg.c

pv_read_all_pv_of_vg.c +1 -0
@@ -103,2 +103,3 @@ int pv_read_all_pv_of_vg ( char *vg_name
             pv_this_sav = pv_this;
+	    if(np<pv_tmp[p]->pv_number) np=pv_tmp[p]->pv_number;
             if ( ( pv_this = realloc ( pv_this,

pv_read_all_pv_of_vg.c int pv_read_all_pv_of_vg ( char *vg_name · line 114

Quoted 6 lines
pv_read_all_pv_of_vg.c +2 -3
@@ -111,5 +112,4 @@ int pv_read_all_pv_of_vg ( char *vg_name
             }
-            pv_this[np] = pv_tmp[p];
-            pv_this[np+1] = NULL;
-            np++;
+            pv_this[pv_tmp[p]->pv_number-1] = pv_tmp[p];
+            //pv_this[np+1] = NULL; // XXX???

               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

IMHO the pv_this list has to be terminated by NULL (see next lines of source). Otherwise you may get "seg faults" while running vgscan (see. Rik's mail). Replacing the marked line with 'pv_this[np] = NULL;' worked for me.

Holger

Signature · 2 lines
Holger Grothe  (Email: [email protected])
Fachbereich Mathematik, TU Darmstadt
#3 lore raw
Quoted 19 lines · Holger Grothe
Quoted 12 lines

Index: pv_read_all_pv_of_vg.c
===================================================================
RCS file: /data/cvs/LVM/tools/lib/pv_read_all_pv_of_vg.c,v retrieving revision 1.3
diff -u -1 -b -p -r1.3 pv_read_all_pv_of_vg.c

pv_read_all_pv_of_vg.c +1 -0
@@ -103,2 +103,3 @@ int pv_read_all_pv_of_vg ( char *vg_name
             pv_this_sav = pv_this;
+	    if(np<pv_tmp[p]->pv_number) np=pv_tmp[p]->pv_number;
             if ( ( pv_this = realloc ( pv_this,

pv_read_all_pv_of_vg.c int pv_read_all_pv_of_vg ( char *vg_name · line 114

Quoted 6 lines
pv_read_all_pv_of_vg.c +2 -3
@@ -111,5 +112,4 @@ int pv_read_all_pv_of_vg ( char *vg_name
             }
-            pv_this[np] = pv_tmp[p];
-            pv_this[np+1] = NULL;
-            np++;
+            pv_this[pv_tmp[p]->pv_number-1] = pv_tmp[p];
+            //pv_this[np+1] = NULL; // XXX???

               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Quoted 4 lines

IMHO the pv_this list has to be terminated by NULL (see next lines of source). Otherwise you may get "seg faults" while running vgscan (see. Rik's mail). Replacing the marked line with 'pv_this[np] = NULL;' worked for me.

Yes, that's why I marked this line with XXX ;-).
I did fix the bug that hit me, but I didn't check if I may have introduced new bugs.
You are probably right that pv_this[np]=NULL is needed. By the way, the realloc can be changed to (np+1)*sizeof(...) instead of (np+2)*sizeof(...).

Jan