Skip to contentSkip to conversation

n_r3964: restore_flags on failure

PATCH In review Arnaldo Carvalho de Melo 2 participants 2 messages Jan 9, 2001 – Jan 10, 2001 Char and misc drivers

lore
Share & tools
lore

Arnaldo Carvalho de Melo

author
#0 lore raw

PATCH 1/1 n_r3964: restore_flags on failure

Hi,

Please consider applying.

- Arnaldo

drivers/char/n_r3964.c +3 -1
@@ -988,8 +988,10 @@
 
       pMsg = kmalloc(sizeof(struct r3964_message), GFP_KERNEL);
       TRACE_M("add_msg - kmalloc %x",(int)pMsg);
-      if(pMsg==NULL)
+      if(pMsg==NULL) {
+      	 restore_flags(flags);
          return;
+      }
 
       pMsg->msg_id = msg_id;
       pMsg->arg    = arg;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#1 lore raw

drivers/char/n_r3964.c line 992

Quoted 4 lines · Arnaldo Carvalho de Melo
drivers/char/n_r3964.c +1 -0
 
+      	 restore_flags(flags);

/me scratches head...

Err.... is there any reason to believe that the locking therein actually works at all?

Signature · 7 lines
dwmw2


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/