Skip to contentSkip to conversation

sparc64 compile fix

PATCH In review Petru Paler 3 participants 6 messages Jan 13, 2001 – Jan 14, 2001

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sparc64 compile fix

sparc64/kernel/sys_sparc32.c Sat Jan 13 08:00:23 2001 renamed from sparc64/kernel/sys_sparc32.c.orig Sat Jan 13 07:59:43 2001 +1 -1
@@ -904,7 +904,7 @@
 {
        int cmds = cmd >> SUBCMDSHIFT;
        int err;
-       struct dqblk d;
+       struct dqblk32 d;
        mm_segment_t old_fs;
        char *spec;                                                                       
 

--
Petru Paler, mailto:[email protected]
http://www.ppetru.net - ICQ: 41817235
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#1 lore raw

sparc64/kernel/sys_sparc32.c Sat Jan 13 08:00:23 2001 line 907

Quoted 2 lines · Petru Paler
sparc64/kernel/sys_sparc32.c Sat Jan 13 08:00:23 2001 renamed from sparc64/kernel/sys_sparc32.c.orig Sat Jan 13 07:59:43 2001 +1 -1
-       struct dqblk d;
+       struct dqblk32 d;

What does this fix? Things compile just fine without it and looking at the code it was intended to be of the original type.

Please explain exactly what submitted patches fix in the future, thanks.

Later,
David S. Miller
[email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
Quoted 3 lines

What does this fix? Things compile just fine without it and looking at the code it was intended to be of the original type.

2.4.0-ac has quota fixes (there are bad quota races in 2.4.0) and changes to support 32bit uid. They aren't in the sparc64 diffs yet and until Linus has the major bugs out they probably arent a major worry.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#3 lore raw
In reply to Petru Paler
Quoted 10 lines · David S. Miller

sparc64/kernel/sys_sparc32.c Sat Jan 13 08:00:23 2001 line 907

Quoted 2 lines · Petru Paler
sparc64/kernel/sys_sparc32.c Sat Jan 13 08:00:23 2001 renamed from sparc64/kernel/sys_sparc32.c.orig Sat Jan 13 07:59:43 2001 +1 -1
-       struct dqblk d;
+       struct dqblk32 d;

What does this fix? Things compile just fine without it and looking at the code it was intended to be of the original type.

Please explain exactly what submitted patches fix in the future, thanks.

Sorry, my fingers slipped and I sent the mail too fast :(

Trying to compile 2.4.0-ac8 resulted in an error about storage size of variable d not being known (I don't have the exact error at hand, the network connectivity to that server is down right now). Changing it to dqblk32 got it to compile.

Am I doing something else wrong ?

--
Petru Paler, mailto:[email protected]
http://www.ppetru.net - ICQ: 41817235
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#4 lore raw
Quoted 6 lines · Petru Paler

Trying to compile 2.4.0-ac8 resulted in an error about storage size of variable d not being known (I don't have the exact error at hand, the network connectivity to that server is down right now). Changing it to dqblk32 got it to compile.

Am I doing something else wrong ?

If the quota interfaces have changed, then all of the translation code support for them in sys_sparc32.c/systbls.S/etc. need to change to accomodate.

Stick with non-AC kernels for no on sparc64, thanks. (But feel free to use the zerocopy patches :-)

Later,
David S. Miller
[email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#5 lore raw
In reply to Petru Paler
Quoted 6 lines · David S. Miller
Quoted 5 lines · Petru Paler

Trying to compile 2.4.0-ac8 resulted in an error about storage size of variable d not being known (I don't have the exact error at hand, the network connectivity to that server is down right now). Changing it to dqblk32 got it to compile.

Quoted 8 lines
Quoted 1 line

Am I doing something else wrong ?

If the quota interfaces have changed, then all of the translation code support for them in sys_sparc32.c/systbls.S/etc. need to change to accomodate.

Stick with non-AC kernels for no on sparc64, thanks. (But feel free to use the zerocopy patches :-)

Ok :)

Actually I'm just looking for a kernel to run fast & smoothly on those servers... Will give 2.4.0-pre3 + zerocopy a try.

--
Petru Paler, mailto:[email protected]
http://www.ppetru.net - ICQ: 41817235
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/