make drivers/scsi/mvme147.c care about (some) return codes (240p3)
Subsystems (2)
PATCH 1/1 make drivers/scsi/mvme147.c care about (some) return codes (240p3)
Hi.
(I have not been able to find a maintainer for this code.)
The following patch makes drivers/scsi/mvme147.c check the return code from request_irq and scsi_register. It applies cleanly against 240p3 and ac9.
Please comment.
drivers/scsi/mvme147.c +15 -2
@@ -74,13 +74,18 @@ tpnt->proc_info = &wd33c93_proc_info; mvme147_host =scsi_register (tpnt,sizeof (struct WD33C93_hostdata )); +if (!mvme147_host) + goto err_out; + mvme147_host->base =0xfffe4000 ; mvme147_host->irq =MVME147_IRQ_SCSI_PORT ;wd33c93_init (mvme147_host, (wd33c93_regs *)0xfffe4000 , dma_setup, dma_stop,WD33C93_FS_8_10 ); -request_irq (MVME147_IRQ_SCSI_PORT , mvme147_intr,0 ,"MVME147 SCSI PORT" , mvme147_intr); -request_irq (MVME147_IRQ_SCSI_DMA , mvme147_intr,0 ,"MVME147 SCSI DMA" , mvme147_intr); +if (request_irq (MVME147_IRQ_SCSI_PORT , mvme147_intr,0 ,"MVME147 SCSI PORT" , mvme147_intr)) + goto err_unregister; +if (request_irq (MVME147_IRQ_SCSI_DMA , mvme147_intr,0 ,"MVME147 SCSI DMA" , mvme147_intr)) + goto err_free_irq;#if 0 /* Disabled; causes problems booting */ m147_pcc->scsi_interrupt =0x10 ;/* Assert SCSI bus reset */ udelay (100 );
@@ -94,6 +99,14 @@ m147_pcc->dma_intr =0x89 ;/* Ack and enable ints */ return 1 ; + + err_free_irq: +free_irq (MVME147_IRQ_SCSI_PORT , mvme147_intr); + err_unregister: +wd33c93_release (); +scsi_unregister (mvme147_host); + err_out: +return 0 ; }#define HOSTS_C
Signature · 9 lines
Regards,
Rasmus([email protected])
"I begin by taking. I shall find scholars later to demonstrate my
perfect right." - Frederick (II) the Great
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/