missing exported symbols
PATCH 1/1 missing exported symbols
All
I had to add these two symbol exports to this file.
The first one I have noticed was not available for the last few weks or so of 2.4.0 and 2.4.0-pre kernels. The second one I only noticed today when I tried to build the gmac as a module.
The first one I am pretty sure belongs in this file as i have noticed a few other archs have to export it here.
The gmac one i am unsure if this is the best place to put the export, but it works so I put it here.
Most if not all filesystems need the flush_dcache_page exported if they are built as modules. The gmac thing needs to be exported if gmac is built as a module.
This is from a paulus 2.4.0 rsynced yesterday (saturday AEST).
arch/ppc/kernel/ppc_ksyms.c Sun Jan 21 13:07:08 2001 renamed from linux-pmac-devel/arch/ppc/kernel/ppc_ksyms.c Tue Jan 9 14:49:03 2001 +4 -0
@@ -364,3 +364,7 @@ EXPORT_SYMBOL_NOVERS(__no_use_restore_flags); EXPORT_SYMBOL_NOVERS(__no_use_save_flags); #endif + +/* needed by some modules */ +EXPORT_SYMBOL(flush_dcache_page); +EXPORT_SYMBOL(feature_set_gmac_phy_reset);
See You
Steve
--
[email protected] http://wibble.net/~sjh/
Look Up In The Sky
Is it a bird? No
Is it a plane? No
Is it a small blue banana?
YES
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
Quoted 2 lines · Steven Hanley
The first one I am pretty sure belongs in this file as i have noticed a few other archs have to export it here.
Err, what needs this symbol tho? And are you sure this is actually needed? I'm about to re-do my modtest config vs 2.4.1pre9, but as of ~2.4.0 release or an early 2.4.1 the bk tree was fine wrt modules now.. And, as of 2.4.1pre9 only sh exports flush_dcache_page, and sparc64 exports __flush_dcache_page, so are you sure this is needed?
Quoted 2 lines
The gmac one i am unsure if this is the best place to put the export, but it works so I put it here.
This has been fixed in the 2_4 bk for atleast a week, and 2_5 for much longer.
--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
Quoted 10 lines · Tom Rini
Quoted 2 lines · Steven Hanley
The first one I am pretty sure belongs in this file as i have noticed a few other archs have to export it here.
Err, what needs this symbol tho? And are you sure this is actually needed? I'm about to re-do my modtest config vs 2.4.1pre9, but as of ~2.4.0 release or an early 2.4.1 the bk tree was fine wrt modules now.. And, as of 2.4.1pre9 only sh exports
flush_dcache_page, and sparc64 exports__flush_dcache_page, so are you sure this is needed?
smbfs and nfs modules, I need nfsa, I notice it works fine in 2.4.0 on i386, jiust it has not worked for more than a month in the 2.4) type kernels on ppc.
Quoted 4 lines
Quoted 2 lines
The gmac one i am unsure if this is the best place to put the export, but it works so I put it here.
This has been fixed in the 2_4 bk for atleast a week, and 2_5 for much longer.
Was that the correct place to export it?
I tend to run paulus kernels, probably mostly because I have rsync or cvs available, have not played with bk yet (though I am su re it is easy) and also that I tend to be able to go speak with paulus in person or such if I want to ask him stuff or some such.
See You
Steve
--
[email protected] http://wibble.net/~sjh
Look Up In The Sky
Is it a bird? No
Is it a plane No
Is it a small blue banana?
Yes
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
Quoted 13 lines · Steven Hanley
Quoted 10 lines · Tom Rini
Quoted 2 lines · Steven Hanley
The first one I am pretty sure belongs in this file as i have noticed a few other archs have to export it here.
Err, what needs this symbol tho? And are you sure this is actually needed? I'm about to re-do my modtest config vs 2.4.1pre9, but as of ~2.4.0 release or an early 2.4.1 the bk tree was fine wrt modules now.. And, as of 2.4.1pre9 only sh exports
flush_dcache_page, and sparc64 exports__flush_dcache_page, so are you sure this is needed?
Quoted 3 lines
smbfs and nfs modules, I need nfsa, I notice it works fine in 2.4.0 on i386, jiust it has not worked for more than a month in the 2.4) type kernels on ppc.
Er, I would switch trees if I were you then. NFS in bk 2_4/2_5 has been working great here (nfs & nfsd) and neither need flush_dcache_page added there (Because it's been added to the normal netsyms, now that I think of it.)
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
The gmac one i am unsure if this is the best place to put the export, but it works so I put it here.
This has been fixed in the 2_4 bk for atleast a week, and 2_5 for much longer.
Was that the correct place to export it?
For 2_4, yes. 2_5 I moved lots of garbage (makefile junk > preprocessor magic) and has feature_xxx exported in feature.c
Quoted 4 lines
I tend to run paulus kernels, probably mostly because I have rsync or cvs available, have not played with bk yet (though I am su re it is easy) and also that I tend to be able to go speak with paulus in person or such if I want to ask him stuff or some such.
The 2_4 bk tree has an rsync avail. Paulus even commits to the bk tree from time to time. :)
--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/